Skip to content

test(desktop): verify session launch reviews, cleanup, and account isolation - #1112

Merged
elyasmnvidian merged 1 commit into
emehtabuddin/s30-desktop-session-cleanupfrom
emehtabuddin/s31-desktop-session-tests
Oct 27, 2026
Merged

elyasmnvidian merged 1 commit into
emehtabuddin/s30-desktop-session-cleanupfrom
emehtabuddin/s31-desktop-session-tests

Conversation

@elyasmnvidian

@elyasmnvidian elyasmnvidian commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

This PR adds end-to-end tests for worktree sessions.

The tests check these behaviors:

  • A failed setup removes its worktree, branch, and private settings.
  • A session uses the chosen account and leaves the user's defaults unchanged.
  • Launch writes files only when the reviewed plan still matches the current repository and settings.

@elyasmnvidian
elyasmnvidian requested a review from a team as a code owner October 22, 2026 22:07
@elyasmnvidian
elyasmnvidian force-pushed the emehtabuddin/s31-desktop-session-tests branch from c376010 to c701dc9 Compare October 22, 2026 23:25
@elyasmnvidian
elyasmnvidian force-pushed the emehtabuddin/s30-desktop-session-cleanup branch from 3c3ce5a to 93cd92f Compare October 22, 2026 23:38
@elyasmnvidian
elyasmnvidian force-pushed the emehtabuddin/s31-desktop-session-tests branch 2 times, most recently from 52e9673 to c4eab54 Compare October 23, 2026 22:01
@elyasmnvidian
elyasmnvidian force-pushed the emehtabuddin/s30-desktop-session-cleanup branch from 93cd92f to 60e5180 Compare October 23, 2026 22:01
@elyasmnvidian
elyasmnvidian force-pushed the emehtabuddin/s30-desktop-session-cleanup branch from 60e5180 to f67984f Compare October 26, 2026 19:20
@elyasmnvidian
elyasmnvidian force-pushed the emehtabuddin/s31-desktop-session-tests branch from c4eab54 to b5b9127 Compare October 26, 2026 19:20
@elyasmnvidian
elyasmnvidian force-pushed the emehtabuddin/s30-desktop-session-cleanup branch from f67984f to f65f418 Compare October 26, 2026 20:57
@elyasmnvidian
elyasmnvidian force-pushed the emehtabuddin/s31-desktop-session-tests branch from b5b9127 to 270db2e Compare October 26, 2026 20:57
…olation

Signed-off-by: Elyas Mehtabuddin <emehtabuddin@nvidia.com>
@elyasmnvidian
elyasmnvidian force-pushed the emehtabuddin/s31-desktop-session-tests branch from 270db2e to f44fbb9 Compare October 26, 2026 21:11
@elyasmnvidian
elyasmnvidian merged commit 45a495e into emehtabuddin/s30-desktop-session-cleanup Oct 27, 2026
16 checks passed
@elyasmnvidian
elyasmnvidian deleted the emehtabuddin/s31-desktop-session-tests branch October 27, 2026 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant