Repository navigation
fix(home): show built-in preset names in the current language (#744) - #765
Merged
Merged
Conversation
) History kept the preset's name as text, so a conversion made while Filee was in Chinese still read 长图 after switching to English. An entry now also keeps the built-in preset's name key when the job showed its translated name, and Home shows that key in the current language. The user's own names and older entries keep the saved text; search matches both. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 29, 2026
Closed
Marouane-elfadli
pushed a commit
to Marouane-elfadli/Filee
that referenced
this pull request
Oct 29, 2026
A_program_that_keeps_reporting_runs_well_past_the_stall_limit touched every 50 ms against a 300 ms limit and failed several times today when a loaded runner delayed one wait past 300 ms (KnifeLemon#759, KnifeLemon#765, KnifeLemon#766). The limit is now 1 s and the fake program reports for 3 s, still three times the limit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #744.
Home's recent conversions kept the preset name as the text shown when the job ran, so after switching languages a row still read e.g. 长图 instead of "Long image".
HistoryEntry.PresetNameKey: the built-in preset's name key, recorded only when the job showed exactly that key's translation (no user name, same text). Callers that pass another label (Spreadsheet Print Studio, a group's ring name) keep today's behaviour.HistoryItemViewModelshows the key in the current language; the user's own names, entries from before and a key that no longer exists keep the saved text.Home is rebuilt on a language change, so nothing else is needed.
How was it tested?
dotnet test(RecentConversionTests, FailedFilesTests): newA_built_in_preset_name_follows_the_language_filee_is_in_nowdotnet format whitespace --verify-no-changeson the changed files🤖 Generated with Claude Code