Repository navigation
test: give the stall-watch progress test room on busy CI runners - #768
Merged
Merged
Conversation
A_program_that_keeps_reporting_runs_well_past_the_stall_limit touched every 50 ms against a 300 ms limit and failed several times today when a loaded runner delayed one wait past 300 ms (#759, #765, #766). The limit is now 1 s and the fake program reports for 3 s, still three times the limit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2 tasks done
KnifeLemon
added a commit
to skyhilam/Filee
that referenced
this pull request
Oct 30, 2026
A_program_that_keeps_reporting_runs_well_past_the_stall_limit still failed on CI after KnifeLemon#768 (KnifeLemon#790's run): its fake output was a Task.Delay loop, which waits for the thread pool, and the other test classes running in parallel can hold that up for over a second, so the watch saw a stall. The output now comes from a dedicated thread, like the real output reader, and the test's continuation runs asynchronously so it never joins its own thread. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
adnan-bhaldar
pushed a commit
to adnan-bhaldar/Filee
that referenced
this pull request
Oct 30, 2026
A_program_that_keeps_reporting_runs_well_past_the_stall_limit still failed on CI after KnifeLemon#768 (KnifeLemon#790's run): its fake output was a Task.Delay loop, which waits for the thread pool, and the other test classes running in parallel can hold that up for over a second, so the watch saw a stall. The output now comes from a dedicated thread, like the real output reader, and the test's continuation runs asynchronously so it never joins its own thread. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StallWatchTests.A_program_that_keeps_reporting_runs_well_past_the_stall_limittouched the watch every 50 ms against a 300 ms limit. On loaded runners one 50 ms wait sometimes took longer than 300 ms, and the test failed on unrelated PRs (#759, #765, #766, #745).The limit is now 1 s and the fake program reports for 3 s, still three times the limit. The test takes 2 s longer.
🤖 Generated with Claude Code