Repository navigation
Conversation
antuz123
marked this pull request as ready for review
October 7, 2026 13:52
This was referenced Oct 8, 2026
Collaborator
Author
Codex Cloud continuation handoffState: NEEDS_CLOUD (source is on GitHub; review and final integration remain open). Baseline checked: 12 October 2026. Workstream and exact source
Completed and observed
Partial work, dependencies, and blockers
Exact next Cloud tasks, in priority order
Restrictions
Preserved one-off A/B fixture sourceRun as const assert = require('node:assert/strict');
const path = require('node:path');
const root = process.argv[2];
if (!root) throw Error('Pass source checkout');
const { harness, wallet } = require(path.join(root, 'tests/recovery/helpers.cjs'));
(async () => {
let reads = 0;
let failFirstRead = false;
const fixture = harness({
post: async ({ path: requestPath }) => {
if (failFirstRead && requestPath.endsWith('getBackupSnapshot') && ++reads === 1)
throw { code: 'ERR_NETWORK' };
},
});
fixture.local.Wallet.push(wallet('existing-disposable-wallet'));
assert.equal(await fixture.run(true), 'verified');
const backupBeforeCheck = JSON.stringify(fixture.remote);
fixture.calls.length = 0;
fixture.phases.length = 0;
failFirstRead = true;
const phase = await fixture.run();
assert.deepEqual(fixture.calls, Array(reads).fill('getBackupSnapshot'));
assert.equal(fixture.calls.some((call) => call !== 'getBackupSnapshot'), false);
assert.equal(JSON.stringify(fixture.remote), backupBeforeCheck);
console.log(JSON.stringify({
source: root,
phase,
reads,
calls: fixture.calls,
phases: fixture.phases,
}));
})().catch((error) => { console.error(error); process.exitCode = 1; }); |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current delivery scope — R4 / 2.6.4 (8 October owner decision)
All unfinished R3 work is now part of R4. This PR is reused in the complete coordinated 2.6.4 app set, with separately tracked backend/Desktop delivery where applicable. Keep existing source and review evidence; this scope transfer publishes no build or backend. One independent developer approval remains required, feasible agent checks precede submission, and owner phone/Desktop/hardware testing remains retrospective. The original branch and older QA version labels below are provenance, not the next release scope.
Current iPhone and source checkpoint — 8 October 2026
ac868253f3460dd875035e1a4f73fc99ca658c1b, still based on frozenrelease/2.6.3(84476d7b). R4 / 2.6.4 is the target, not a built or delivered version. Keep this base until R4: bring the shipped 2.6.3 baseline into sprint #7031 (fee03fab6) receives current independent approval and merges intosprint; then reconcile the test-file overlap, retarget, and rerun sprint CI.Read-only Assisted Server Backup checks can report
Backup not verifiedwhile a healthy snapshot is briefly unavailable or an incremental write is queued. This change waits for login wallet sync to finish, retries one transient snapshot failure or queued-write revision change, and preserves privacy-safe failure-stage diagnostics.Validation: 212/212 disposable recovery fixtures pass at
8fa6bf744, including iOS/Android RestClient wiring, transient failures, shared deadline, account switches and repair boundaries. Against the previous source, the new fixtures reproduce falseunverifiedresults for transient failures. Production Babel transformation retains the stage/category warning. Formatting and diff checks pass; current-head CI is pending.The affected live iPhone's failure stage and cause remain unknown. Earlier Android emulator failure was explained by the retired development Relay returning 404; production Android behavior has not been established. Human phone validation is after release. These changes correct reproducible shared-client causes but do not claim that the live defect is proven fixed. The public Relay contributor snapshot-API gap is being handled separately; this PR deploys no backend changes.
Keep this change focused on the existing release baseline until the approved baseline backmerge is in sprint, then retarget to sprint and run its required CI. Ben, Utkarsh or Parsh can provide the one required developer approval; product signoff is separate.
Earlier engineering/review checkpoint at 8fa6bf7 (historical)
Ready for developer review at
8fa6bf7446bd828b8c446503312eec0566d8b400: 212 focused recovery tests and current-head GitHub CI's 306 tests/24 suites pass. The older release branch's SonarCloud check failed while querying PR metadata with a service error; sprint has replaced that integration with CodeQL/Lint. No check or approval gate was bypassed.An actual Copilot review was requested (event32695145509), but response5443291469 reports the requester's quota limit. Copilot source review did not complete. This PR is ready for the already required human developer review; no merge is authorized here. Ben, Utkarsh and Parsh remain requested.
The base stays
release/2.6.3until baseline PR #7031 is actually approved and merged into sprint. Then retarget/update to sprint with feature-only diffs and run current sprint checks before any delivery merge. Affected-phone acceptance remains retrospective after release, as the owner requested. No production backend deployment is included.