Skip to content

[R4] Bind Assisted Server Backup to account consent and origin - #7040

Draft
antuz123 wants to merge 3 commits into
codex/r4-vault-registration-metadatafrom
codex/r4-backup-account-consent
Draft

antuz123 wants to merge 3 commits into
codex/r4-vault-registration-metadatafrom
codex/r4-backup-account-consent

Conversation

@antuz123

@antuz123 antuz123 commented Oct 8, 2026 •

Copy link
Copy Markdown
Collaborator

Scope

  • Bind Assisted Server Backup writes and backup-related local persistence to the originating account. Recheck the selected Redux account and open Realm after asynchronous waits and before queued Relay execution.
  • Store consent, pending state, and results per account. New accounts start off; a legacy global opt-in migrates only when the authenticated account is unambiguous. Recovery Key and seed confirmation do not opt in implicitly.
  • Cover wallet, vault, signer, node, label, USDT, receive-address, and signer-policy paths. Failed or partial deletes retain accurate local state and report backup drift.
  • Preserve the parent branch's read-only freshness check after wallet sync. Explicit backup completion now requires the originating account to remain selected; dispatch-time guards reject stale consent-enable and success actions.

Exact-head verification

Current head: 81bc417cb. node --test tests/recovery/*.test.cjs passes 261/261. Regression fixtures cover A→B before execution, during connectivity, before queued transport, while Realm still has A open, and before/after vault registration repair upload. git diff --check passes. TypeScript diagnostics compared with the #7038 base remain 1,399 baseline error lines versus 1,388 here, with zero new diagnostic messages; the repository-wide typecheck still has existing failures. All fixtures are disposable. No real account, key, backup, consent, production database, or credential was used.

Baseline integration rehearsal

This draft is stacked on #7038, which is stacked on #7027. #7031 is a separate, open sprint baseline PR and is not an ancestor. An isolated, unpushed merge rehearsal of #7031 with this R4 stack resolved six source/test conflicts, kept #7031's persistence-failure and cancellation behavior, and passed 273/273 recovery tests plus 19/19 release tests at local rehearsal head f10cb6ddc. The rehearsal is evidence for the merge path, not a change to the PR branches.

Review and release gates

Copy link
Copy Markdown
Collaborator Author

R4 account-scope integration boundary

This source remains 81bc417cb42372a4eb7dc918db073684f8bf2687, integrated in #7045 final a3b87774573fd8d54a05528290c84f12494493bb. The strict originating-account wallet/key guards exposed a combined onboarding gap: default creation ran before Redux selected its new account. #7045 now atomically publishes the persisted account, verifies wallet/Recovery Key before readiness, preserves wallet/balance on retry, and prevents setup/faucet/refresh/loading writes after account/network/Realm switches. Candidate regression tests pass; those corrections are not asserted as commits on this source PR.

Keep backup consent/ownership reviews independent. Per-account opt-in/legacy migration/readback/registration repair and pending A -> B backup/label/key operations still need actual native/staged acceptance. Reconcile the combined setup correction during source integration; do not drop the guard to make onboarding work. Current combined tests 380 Jest / 308 recovery pass; source approval and final own-head/native checks remain open. No backup/key mutation on the owner's device, merge or release occurred.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant