fix(riscv): trap on instruction fetch at misaligned PC without C - #306
Closed
carlosqwqqwq wants to merge 1 commit into
Closed
fix(riscv): trap on instruction fetch at misaligned PC without C#306carlosqwqqwq wants to merge 1 commit into
carlosqwqqwq wants to merge 1 commit into
Conversation
Member
|
Thank you for the report and implementation proposal. I independently reproduced and validated the accepted behavior, then reimplemented it with direct and SMIR/JIT coverage in #296 at commit 9027ae1. No contributor patch was imported; the consolidation commit records @carlosqwqqwq as co-author. I am closing this implementation PR because it is now consolidated into #296. Please review the rollup there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fetch at a misaligned PC must raise an instruction-address-misaligned exception. RAX's fetch path has no IALIGN check, so with the C extension disabled a fetch at an odd PC reads a 16-bit compressed parcel and executes it. This change adds the alignment trap before decode (no trap when aligned; legal halfword fetch with C is preserved).
Validation
fetch_pc_alignment_traps_without_compressed_extension: PCs 0x1001/0x1002 withisa.c=falsetrap with cause INSTR_MISALIGNED, mepc reads back aligned (WARL), mtval keeps the exact PC, and an aligned PC executes normally.fetch_pc_alignment_allows_halfwords_with_compressed_extension: with C, halfword-aligned PCs fetch a 16-bit parcel (c.nop) and advance by 2.cargo test --libtargeted tests pass; full suite shows no regressions.Closes #301