fix(riscv): reject masked vector instructions writing v0 - #272
Closed
carlosqwqqwq wants to merge 3 commits into
Closed
fix(riscv): reject masked vector instructions writing v0#272carlosqwqqwq wants to merge 3 commits into
carlosqwqqwq wants to merge 3 commits into
Conversation
Member
|
Thanks for the report and patch. I independently reproduced and validated this issue, then reimplemented the accepted masked-destination rule with shared direct/SMIR validation and expanded tests in #296. That rollup includes your co-author credit and asks for your review. I’m closing this PR as superseded by #296. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #267
Summary
The RISC-V V extension reserves any masked vector instruction (
vm=0) whose destination vector register group overlaps the mask registerv0, because the mask is read fromv0while the destination is being written. The affectedexec_vectorpath performed no such check for the ordinary arithmetic/logical/comparison families, sovadd.vv v0, v1, v2, v0.texecuted and clobbered the mask mid-operation instead of raising an illegal-instruction trap. QEMU raises SIGILL for these encodings.The fix rejects
vm=0withvd==v0at the top ofexec_vector, with exceptions for the carry/mask families that validate their own overlap constraints (vadc/vsbc/vmadc/vmsbc/vcompressand the mask-prefix opsviota/vmsbf/vmsif/vmsof, all of which already have dedicated checks).Validation
cargo test --lib: the targeted masked-destination tests pass, and the full library test suite passes with no regressions.No new upstream test files are added; this is a source-only change.