fix(riscv): require aligned register groups for vaadd family - #252
Closed
carlosqwqqwq wants to merge 1 commit into
Closed
fix(riscv): require aligned register groups for vaadd family#252carlosqwqqwq wants to merge 1 commit into
carlosqwqqwq wants to merge 1 commit into
Conversation
Member
|
Thank you for reporting #247 and proposing a fix. This is now independently consolidated in #255 for all vaadd/vaaddu/vasub/vasubu vv and vx forms, with complete LMUL group validation and legal controls across direct, SMIR/JIT, and QEMU paths. To keep review and CI focused on one rollup, I am closing this PR in favor of #255. You are credited as co-author on the rollup commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(riscv): require aligned register groups for vaadd family
Closes #247
Summary
The averaging add/subtract instructions
vaadd,vaaddu,vasubandvasubuname vector register groups invd,vs2and (for the.vvform)vs1, and the RISC-V V extension requires each group to be specified by its lowest-numbered register (riscv-v-spec, Section 3.4.2). The affectedVaaddu | Vaadd | Vasubu | Vasubbranch executed the arithmetic without any register-group alignment check, so reserved encodings such asvaadd.vv v2, v2, v1with e32/m2 (vs2=v1 misaligned) were executed. QEMU raises SIGILL for these encodings viaopivv_check/opivx_check.The fix rejects any
.vvform with a misaligned vd, vs1 or vs2, and any.vxform with a misaligned vd or vs2, computing EMUL from vtype.Validation
cargo test --lib: the targeted vaadd-family alignment tests pass, and the full library test suite passes with no regressions.No new upstream test files are added; this is a source-only change.