fix(riscv): canonicalize reserved mtvec MODE encodings - #230
Closed
carlosqwqqwq wants to merge 2 commits into
Closed
fix(riscv): canonicalize reserved mtvec MODE encodings#230carlosqwqqwq wants to merge 2 commits into
carlosqwqqwq wants to merge 2 commits into
Conversation
cpu.rs exceeded the AGENTS.md hard split triggers (2000 lines / 150 kB). Move the vector (RVV) element access and data-path execution group, including set_vtype, into cpu/vector.rs with no behavior change.
Member
|
Thank you for reporting and proposing this fix. I independently reimplemented and validated reserved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(riscv): canonicalize reserved mtvec MODE encodings
Closes #229
Summary
Writing a reserved
mtvec.MODEvalue (2 or 3) is stored verbatim and read back verbatim. The RISC-V privileged specification definesMODEas a WARL field with legal values 0 (Direct) and 1 (Vectored); encodings >= 2 are reserved, and a WARL write of an unsupported value must be canonicalized to a legal value instead of being observable as a reserved encoding.The fix canonicalizes the mode on write:
MODE=1stays vectored, every other encoding becomes Direct. The base address remains XLEN-masked, and existing vectored interrupt delivery is unaffected.Validation
mtvec_warl_canonicalizes_reserved_modesfails on the affected source withleft: 4098, right: 4096and passes with the fix.cargo test --lib: full library test suite passes with no regressions.No new upstream test files are added; this is a source-only change.