Skip to content

PoC do not merge: consume @comfyorg/account in the Hub site as a client-only island - #1228

Draft
christian-byrne wants to merge 28 commits into
mainfrom
poc/account-layer-refactor
Draft

christian-byrne wants to merge 28 commits into
mainfrom
poc/account-layer-refactor

Conversation

@christian-byrne

@christian-byrne christian-byrne commented Sep 3, 2026 •

Copy link
Copy Markdown
Contributor

PoC do not merge: evidence review only.

  • Astro Vue-island consumer participates in the shared account layer.
  • Final matrix: 153 proven, 82 partial, no failures.
  • Pushed head is a60fc5f1; the PoC branch will be torn down on 2026-09-30 if no release owner is named.
Full context for agent readers

What this PR proves

Astro Vue-island consumer uses @comfyorg/account behind a proof-of-concept seam. The package now initializes Firebase, owns sign-in state, and exchanges Firebase ID tokens for workspace tokens; the host supplies only storage, transport, time, and navigation adapters.

After this identity refactor, local typecheck and lint passed, including Astro check with no errors or warnings, and 884 unit tests passed. The full site build is blocked locally because the installed package manager is newer than the required version. End-to-end login, credits, and payments flows were not rerun against real Firebase and Stripe test credentials. Before the refactor, staging validation across the consumers covered login, credits, Stripe test-mode checkout, top-up, subscription, coupon, and 3DS states.

Not proven

  • Coupons: the backend exposes no coupon control; FREE subscribe opens setup-mode hosted Checkout with no promotion-code control.
  • A real checkout rendered inside the settings-dialog host: P0-13 is partial because only state-machine equivalence was proven.
  • Fixture C invoice-stage 3DS: Stripe's hosted invoice hCaptcha blocked completion.
  • Automated fixture provisioning: Cloudflare Turnstile protects POST /customers.
  • The platform payments specification with parallel workers: it must run with --workers=1; the remaining red row is a harness navigation flake, not a product defect.

The pushed and current head is a60fc5f1. The PoC branch will be torn down on 2026-09-30 if no release owner is named.

Links

Glossary

  • 3DS: Bank verification during card payment.
  • PoC: Proof of concept used to test the design.
  • Pushed head: Latest commit currently visible on GitHub.

@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Comment @coderabbitai help to get the list of available commands.

@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addednpm/​firebase@​12.18.09910010098100

View full report

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

🧹 Lint & Format Results

Check Status
ESLint ❌ skipped
Prettier ❌ skipped
Error details

ESLint:

Could not read lint output

Prettier:

Could not read format output

To fix locally:

cd site
pnpm run lint:fix && pnpm run format

Generated by Site CI workflow

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

🔗 Internal Link Check

❌ Found an internal link pointing at a route the site does not serve.

📦 Download the link-checker-results artifact for the full Playwright report.

To reproduce locally:

cd site
pnpm run sync:en-only
pnpm run test:links

Generated by Link Checker workflow

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant