Repository navigation
PoC do not merge: consume @comfyorg/account in the Hub site as a client-only island - #1228
Draft
christian-byrne wants to merge 28 commits into
Draft
christian-byrne wants to merge 28 commits into
christian-byrne wants to merge 28 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
🧹 Lint & Format Results
Error detailsESLint: Prettier: To fix locally: cd site
pnpm run lint:fix && pnpm run formatGenerated by Site CI workflow |
Contributor
🔗 Internal Link Check❌ Found an internal link pointing at a route the site does not serve. 📦 Download the link-checker-results artifact for the full Playwright report. To reproduce locally: cd site
pnpm run sync:en-only
pnpm run test:linksGenerated by Link Checker workflow |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PoC do not merge: evidence review only.
a60fc5f1; the PoC branch will be torn down on 2026-09-30 if no release owner is named.Full context for agent readers
What this PR proves
Astro Vue-island consumer uses
@comfyorg/accountbehind a proof-of-concept seam. The package now initializes Firebase, owns sign-in state, and exchanges Firebase ID tokens for workspace tokens; the host supplies only storage, transport, time, and navigation adapters.After this identity refactor, local typecheck and lint passed, including Astro check with no errors or warnings, and 884 unit tests passed. The full site build is blocked locally because the installed package manager is newer than the required version. End-to-end login, credits, and payments flows were not rerun against real Firebase and Stripe test credentials. Before the refactor, staging validation across the consumers covered login, credits, Stripe test-mode checkout, top-up, subscription, coupon, and 3DS states.
Not proven
POST /customers.--workers=1; the remaining red row is a harness navigation flake, not a product defect.The pushed and current head is
a60fc5f1. The PoC branch will be torn down on 2026-09-30 if no release owner is named.Links
Glossary