Repository navigation
fix(open-on-cloud): frame Deploy your setup around running workflows on Comfy Cloud (DPLAT-4259) - #23475
Conversation
…on Comfy Cloud (DPLAT-4259)
📦 Bundle: 12.4 MB gzip 🔴 +165 BDetailsSummary
Category Glance App Entry Points — 7.05 kB (baseline 7.05 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 3.69 MB (baseline 3.69 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 4 added / 4 removed / 1 unchanged Views & Navigation — 152 kB (baseline 152 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 15 added / 15 removed / 3 unchanged Panels & Settings — 899 kB (baseline 899 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 14 added / 14 removed / 21 unchanged User & Accounts — 108 kB (baseline 108 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 11 added / 11 removed / 7 unchanged Editors & Dialogs — 502 kB (baseline 502 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 13 added / 13 removed / 6 unchanged UI Components — 369 kB (baseline 369 kB) • 🔴 +16 BReusable component library chunks
Status: 13 added / 13 removed / 21 unchanged Data & Services — 2.03 MB (baseline 2.03 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 41 added / 41 removed / 5 unchanged Utilities & Hooks — 1.44 MB (baseline 1.44 MB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 51 added / 51 removed / 35 unchanged Vendor & Third-Party — 9.7 MB (baseline 9.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 36.6 MB (baseline 36.6 MB) • 🔴 +67 BBundles that do not match a named category
Status: 118 added / 118 removed / 648 unchanged ⚡ Performance: ⏳ Performance tests in progress…🎭 Playwright: ✅ 3327 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure
Findings and check detailsExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Full docs: scripts/registry-census/README.md Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
🌾 Fallow: ✅ PassedFindings and check detailsFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Full docs: ADR-DEVEX-LINT-0015 Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since d24f4470149d8bd6cfcf1fdb55497d2a6ffe2f78
🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (518)
Full docs: Frontend domain catalog Reproduce locallypnpm architecture:check |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @shrimbly.
✅ No high-signal findings.
Panel: 6/6 reviewers contributed findings.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #23475 +/- ##
==========================================
- Coverage 88.02% 87.93% -0.10%
==========================================
Files 3173 3057 -116
Lines 169943 166193 -3750
Branches 45866 42538 -3328
==========================================
- Hits 149594 146135 -3459
+ Misses 19377 19255 -122
+ Partials 972 803 -169
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 122 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…ndoff (#23501) ## Summary Use the Comfy Cloud video and updated copy in the deployment dialogs. Keep the agent choice explicit and prefill an unsent handoff without replacing an existing draft. Backport of #23463 — show the Comfy Cloud video in the deployment dialogs Backport of #23475 — frame Deploy your setup around running workflows on Comfy Cloud Backport of #23470 — preserve agent choice and update Cloud handoff Keeps the release branch’s UI and telemetry imports and retains its consent tests. With Open on Cloud enabled, Desktop and Desktop 2 now show the toolbar button. The target branch already includes the system-browser relay (backport #23154). Local and Desktop handoffs reference a saved workflow on the server; Cloud handoffs still export JSON. The separate Deploy to Comfy API dialog now asks localhost users to export the workflow themselves. ## Verification - Commit hooks passed, including changed-file lint and app type checking. - Both video formats and the poster returned HTTP 200 with the expected media type. - 734 tests passed across eight focused suites (toolbar, dialog, agent consent and composer, and handoff). - 36 tests passed across the Desktop relay, Cloud receiver, and handoff protocol suites. --------- Co-authored-by: Willie <falloon.willie@gmail.com> Co-authored-by: huang47 <157390+huang47@users.noreply.github.com>
…doff (#23503) ## Summary Use the Comfy Cloud video and updated copy in the deployment dialogs. Keep the agent choice explicit and prefill an unsent handoff without replacing an existing draft. Backport of #23463 — show the Comfy Cloud video in the deployment dialogs Backport of #23475 — frame Deploy your setup around running workflows on Comfy Cloud Backport of #23470 — preserve agent choice and update Cloud handoff Keeps the release branch’s UI and telemetry imports and retains its consent tests. With Open on Cloud enabled, Desktop and Desktop 2 now show the toolbar button. The target branch already includes the system-browser relay (backport #23155). Local and Desktop handoffs reference a saved workflow on the server; Cloud handoffs still export JSON. The separate Deploy to Comfy API dialog now asks localhost users to export the workflow themselves. The sign-in continuation restores the unsent handoff and prior draft after a reload. Deploy to Comfy API now uses the shared video URLs on this release too. ## Verification - Commit hooks passed, including changed-file lint and app type checking. - Both video formats and the poster returned HTTP 200 with the expected media type. - Before the follow-up, 745 tests passed across eight focused suites (toolbar, dialog, agent consent and composer, and handoff). - 36 tests passed across the Desktop relay, Cloud receiver, and handoff protocol suites before the follow-up. - The follow-up passed 74 tests in the agent chooser and consent suites, including reload recovery; the regression test failed before the fix. - The Deploy to Comfy API Chromium spec passed against a local multi-user backend. --------- Co-authored-by: Willie <falloon.willie@gmail.com> Co-authored-by: huang47 <157390+huang47@users.noreply.github.com>
…doff (#23502) ## Summary Use the Comfy Cloud video and updated copy in the deployment dialogs. Keep the agent choice explicit and prefill an unsent handoff without replacing an existing draft. Backport of #23463 — show the Comfy Cloud video in the deployment dialogs Backport of #23475 — frame Deploy your setup around running workflows on Comfy Cloud Backport of #23470 — preserve agent choice and update Cloud handoff Uses the release telemetry package and adds the Cloud handoff state without importing the unrelated error-context feature. With Open on Cloud enabled, Desktop and Desktop 2 now show the toolbar button. The target branch already includes the system-browser relay (backport #23212). Local and Desktop handoffs reference a saved workflow on the server; Cloud handoffs still export JSON. The separate Deploy to Comfy API dialog now asks localhost users to export the workflow themselves. The sign-in continuation restores the unsent handoff and prior draft after a reload. ## Verification - Commit hooks passed, including changed-file lint and app type checking. - Both video formats and the poster returned HTTP 200 with the expected media type. - Before the follow-up, 763 tests passed across eight focused suites (toolbar, dialog, agent consent and composer, and handoff). - 36 tests passed across the Desktop relay, Cloud receiver, and handoff protocol suites before the follow-up. - The follow-up passed 74 tests in the agent chooser and consent suites, including reload recovery; the regression test failed before the fix. --------- Co-authored-by: Willie <falloon.willie@gmail.com> Co-authored-by: huang47 <157390+huang47@users.noreply.github.com>
…ndoff (#23504) ## Summary Use the Comfy Cloud video and updated copy in the deployment dialogs. Keep the agent choice explicit and prefill an unsent handoff without replacing an existing draft. Backport of #23463 — show the Comfy Cloud video in the deployment dialogs Backport of #23475 — frame Deploy your setup around running workflows on Comfy Cloud Backport of #23470 — preserve agent choice and update Cloud handoff Uses the release telemetry package and adds the Cloud handoff state without importing the unrelated error-context feature. With Open on Cloud enabled, Desktop and Desktop 2 now show the toolbar button. The target branch already includes the system-browser relay (backport #23211). Local and Desktop handoffs reference a saved workflow on the server; Cloud handoffs still export JSON. The separate Deploy to Comfy API dialog now asks localhost users to export the workflow themselves. The sign-in continuation restores the unsent handoff and prior draft after a reload. ## Verification - Commit hooks passed, including changed-file lint and app type checking. - Both video formats and the poster returned HTTP 200 with the expected media type. - Before the follow-up, 765 tests passed across eight focused suites (toolbar, dialog, agent consent and composer, and handoff). - 36 tests passed across the Desktop relay, Cloud receiver, and handoff protocol suites before the follow-up. - The follow-up passed 74 tests in the agent chooser and consent suites, including reload recovery; the regression test failed before the fix. --------- Co-authored-by: Willie <falloon.willie@gmail.com> Co-authored-by: huang47 <157390+huang47@users.noreply.github.com>
Summary
The Deploy your setup dialog on local ComfyUI and Desktop framed deploying as an API. Most users run workflows in the UI, so the copy now leads with running workflows on Comfy Cloud. Closes DPLAT-4259.
openOnCloud.deploySetupDialog.title. The error panel button (CloudErrorAction) keepsopenOnCloud.deploySetup, "Deploy your setup to Comfy Cloud".deploySetupDialog.pointApiis removed, because the line now mentions the API. Nothing else read it.pointPricingis new.src/locales/en/main.jsonchanges. CI generates the other languages.deploySetupDialogstrings on its branch, so it needs to take this copy when it rebases. The cloud/1.60 backport [backport cloud/1.60] Open on Cloud: handoff, Desktop relay, agent brief, OOM offer and flag-off gate (#23074, #23075, #23076, #23077, #23078, #23134) #23205 carries the old copy.Verification
pnpm test:unit src/platform/openOnCloud: 13 files, 114 tests pass.typecheck:appandtypecheck:browser.browser_tests/tests/liveCloud/openOnCloud.spec.tsnow expects the new heading. It was not run locally, because it needs live Cloud.openDeploySetupDialog(). The screenshots above show it at 1440x900.