Repository navigation
fix(open-on-cloud): name Builds in the Deploy your setup dialog (DPLAT-4263) - #23482
Conversation
📦 Bundle: 12.4 MB gzip 🟢 -18 BDetailsSummary
Category Glance App Entry Points — 7.05 kB (baseline 7.05 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 3.69 MB (baseline 3.69 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 4 added / 4 removed / 1 unchanged Views & Navigation — 152 kB (baseline 152 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 15 added / 15 removed / 3 unchanged Panels & Settings — 899 kB (baseline 899 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 14 added / 14 removed / 21 unchanged User & Accounts — 108 kB (baseline 108 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 11 added / 11 removed / 7 unchanged Editors & Dialogs — 502 kB (baseline 502 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 13 added / 13 removed / 6 unchanged UI Components — 369 kB (baseline 369 kB) • ⚪ 0 BReusable component library chunks
Status: 13 added / 13 removed / 21 unchanged Data & Services — 2.03 MB (baseline 2.03 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 41 added / 41 removed / 5 unchanged Utilities & Hooks — 1.44 MB (baseline 1.44 MB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 51 added / 51 removed / 35 unchanged Vendor & Third-Party — 9.7 MB (baseline 9.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 36.6 MB (baseline 36.6 MB) • 🟢 -4 BBundles that do not match a named category
Status: 118 added / 118 removed / 648 unchanged ⚡ Performance: ⏳ Performance tests in progress…🎭 Playwright: ✅ 3328 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure
Findings and check detailsExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Full docs: scripts/registry-census/README.md Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
🌾 Fallow: ✅ PassedFindings and check detailsFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Full docs: ADR-DEVEX-LINT-0015 Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 86bb73297db2b2834b39a82693feb06bc6d90162
🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (518)
Full docs: Frontend domain catalog Reproduce locallypnpm architecture:check |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @shrimbly.
✅ No high-signal findings.
Panel: 6/6 reviewers contributed findings.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #23482 +/- ##
==========================================
- Coverage 88.02% 87.93% -0.10%
==========================================
Files 3173 3057 -116
Lines 169944 166186 -3758
Branches 43840 42537 -1303
==========================================
- Hits 149592 146133 -3459
+ Misses 19380 19250 -130
+ Partials 972 803 -169
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
|
|
|
Summary
The Deploy your setup dialog on local ComfyUI and Desktop did not name the product. The copy now calls it a Build, with a capital B, as "Open Builds on Platform" does elsewhere in the editor. The pricing point also said billing covers only job time and one charge for a build's storage. Billing covers the time a GPU worker is up, idle time included, and storage for each deployment, so the point now says that. Closes DPLAT-4263.
openOnCloud.deploySetupDialog.bodyopenOnCloud.deploySetupDialog.pointPricingsrc/locales/en/main.jsonchanges. CI generates the other languages.Verification
pnpm test:unit src/platform/openOnCloud: 13 files, 114 tests pass. No test or story asserts either old string.openDeploySetupDialog(). The screenshot above shows it at 1440x900.