Repository navigation
[backport cloud/1.59] Update the Cloud deployment dialog and agent handoff - #23501
Conversation
…0) (#23463) ## Summary The deployment dialogs showed the Comfy API video. They now show the new Comfy Cloud video. Closes DPLAT-4240. The diff changes one folder name and three file names in `src/platform/workflow/deploy/constants.ts`. The e2e media route in `browser_tests/fixtures/deployToComfyApiFixture.ts` follows the new folder, so the spec still serves local files. No component, dialog or constant name changes. The constant feeds four places: - `openCustomDeploymentDialog.ts`: New deployment and Extensions on Comfy Cloud. - `RunOnCloudDialog.vue`: Run on Cloud on local. - `openRunOnCloudDialog.ts`: the deploy setup card on local. - `useDeployToComfyApiDialog.ts`: Deploy to Comfy API on local. **Do not merge until the media is uploaded.** The three files must be in `gs://comfy-org-videos/website/cloud-deploy/` first. Status on 17 Nov: | URL | Status | | --- | --- | | https://media.comfy.org/website/cloud-deploy/cloud-deploy-1280.webm | 404 | | https://media.comfy.org/website/cloud-deploy/cloud-deploy-1280.mp4 | 404 | | https://media.comfy.org/website/cloud-deploy/cloud-deploy-poster.jpg | 404 | The new files match the old ones in format: 1280×720, VP9 WebM and H.264 MP4, no audio, `+faststart` on the MP4, and a 1280×720 JPEG poster. The video is 46.75 s at 24 fps. The WebM is 7.2 MB and the MP4 is 9.0 MB. The old video was 28 s, 3.3 MB and 10 MB. Comfy Cloud needs a backport to `cloud/1.60`. This PR does not open one. ## Verification - `pnpm test:unit src/platform/workspace/openCustomDeploymentDialog.test.ts src/platform/workflow/deploy src/platform/openOnCloud`: 226 passed, 0 failed. - The pre-commit hook passed: oxfmt, oxlint, eslint, `typecheck:app` and `typecheck:browser`. - Human QA on a local dev server, with the three URLs routed to the encoded files. The custom deployment dialog showed the poster. The video then played the WebM at 1280×720, muted, with a duration of 46.75 s. - I did not run the Playwright spec. CI runs it.  (cherry picked from commit 642a4d9)
…on Comfy Cloud (DPLAT-4259) (#23475) ## Summary The Deploy your setup dialog on local ComfyUI and Desktop framed deploying as an API. Most users run workflows in the UI, so the copy now leads with running workflows on Comfy Cloud. Closes DPLAT-4259. | | Before | After | |---|---|---| | Title | Deploy your setup to Comfy Cloud | Run your workflows on Comfy Cloud | | Line | This creates a deployment of your setup on Comfy Cloud. You manage it from Comfy Platform. | Deploy your local setup to Comfy Cloud, then use it in ComfyUI or call it as an autoscaling API. | | Point 1 | Work in ComfyUI on the GPU you choose | Bring your custom nodes and models | | Point 2 | Call it from your product as an autoscaling API | Run on powerful cloud GPUs | | Point 3 | Bring your custom nodes and models | Pay only for the GPU seconds your jobs use and your build's storage | | Before | After | |---|---| |  |  | - The card title has its own key, `openOnCloud.deploySetupDialog.title`. The error panel button (`CloudErrorAction`) keeps `openOnCloud.deploySetup`, "Deploy your setup to Comfy Cloud". - `deploySetupDialog.pointApi` is removed, because the line now mentions the API. Nothing else read it. `pointPricing` is new. - Only `src/locales/en/main.json` changes. CI generates the other languages. - Buttons, video, layout and the custom deployment dialog on Cloud are unchanged. - #22949 adds the old `deploySetupDialog` strings on its branch, so it needs to take this copy when it rebases. The cloud/1.60 backport #23205 carries the old copy. ## Verification - `pnpm test:unit src/platform/openOnCloud`: 13 files, 114 tests pass. - The pre-commit hook passed: oxfmt, stylelint, oxlint, eslint, `typecheck:app` and `typecheck:browser`. - `browser_tests/tests/liveCloud/openOnCloud.spec.ts` now expects the new heading. It was not run locally, because it needs live Cloud. - Human QA: dev server on the local build, card opened with `openDeploySetupDialog()`. The screenshots above show it at 1440x900. (cherry picked from commit da09d18)
Preserve agent choice in the local-to-Cloud dialog: show **Use local agent** first when `useAgentPanelStore().enabled` is true, while retaining Claude desktop, Codex, and Copy prompt. Selecting the local agent handles consent and prefills an unsent prompt without replacing an existing draft; the Cloud toolbar button no longer automatically chooses an agent. The handoff follows the agreed prompt: “Run my ComfyUI workflow on Comfy Cloud and give me the link that opens it.” It requires comfy-cli 1.26.0+ and delegates the workflow to `comfy-run-on-cloud`. Local/Desktop handoffs reference the saved server workflow, ComfyUI address (including subpaths), and user ID only in multi-user mode. They never download JSON; Cloud retains the exported-file handoff. Unsaved workflows or edits show a save-first message to avoid referencing a missing or stale server file. - The prompt wording correction passed all 18 handoff/dropdown tests, changed-file lint, and required commit/push hooks. CodeRabbit follow-up reported no new findings. - 803 tests passed across 11 focused suites covering the dropdown, toolbar, dialog host, handoff, consent, composer, and clipboard. Chooser/handoff suites also passed with one worker and shuffle seeds `23472` and `23473`. - Regression tests fail against the prior automatic-agent selection and missing-prefill behavior. - Required commit hooks passed, including formatting, lint, server-fact checks, app typecheck, and i18n/frozen-directory checks. Required push hooks also passed: dependency audit, Knip, schema drift, and Fallow. - CodeRabbit completed. Its clipboard-signature finding refers to an older helper; the current helper already accepts `toastOnSuccess` and returns `Promise<boolean>`, verified by source, typecheck, and all five clipboard tests. - Tests use real panel/composer/dialog stores, with network and external effects mocked. Live build → deploy → workflow URL validation remains outstanding; this PR does not establish release/GTM readiness. --------- Co-authored-by: huang47 <157390+huang47@users.noreply.github.com> (cherry picked from commit 1baae5f)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
⚡ Performance: ❌ 7 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-16T22:16:51.572Z",
"gitSha": "90a49deca586a49af29ae293185609a9af4517b6",
"branch": "codex/backport-23463-23475-23470-cloud-1.59",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2026.486000000034,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.28,
"layouts": 11,
"layoutDurationMs": 2.142,
"taskDurationMs": 344.66600000000005,
"heapDeltaBytes": -10528456,
"heapUsedBytes": 62144552,
"domNodes": -161,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 5.557000000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-idle",
"durationMs": 2009.6690000000308,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.1380000000000003,
"layouts": 10,
"layoutDurationMs": 1.9929999999999999,
"taskDurationMs": 289.68499999999995,
"heapDeltaBytes": -725140,
"heapUsedBytes": 60349888,
"domNodes": 0,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 4.957,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1677.1040000000426,
"styleRecalcs": 72,
"styleRecalcDurationMs": 10.902999999999999,
"layouts": 10,
"layoutDurationMs": 2.196,
"taskDurationMs": 524.1980000000001,
"heapDeltaBytes": 18534636,
"heapUsedBytes": 80045924,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 97.26400000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665346534653462,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1707.4569999999767,
"styleRecalcs": 72,
"styleRecalcDurationMs": 12.009,
"layouts": 11,
"layoutDurationMs": 2.3890000000000007,
"taskDurationMs": 583.6049999999999,
"heapDeltaBytes": -1459312,
"heapUsedBytes": 59687044,
"domNodes": -161,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 98.79199999999999,
"eventListeners": -91,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.6450000000232,
"styleRecalcs": 18,
"styleRecalcDurationMs": 3.811,
"layouts": 10,
"layoutDurationMs": 2.215,
"taskDurationMs": 241.267,
"heapDeltaBytes": 20832760,
"heapUsedBytes": 81514108,
"domNodes": 56,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 6.638000000000002,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262138,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1710.7760000000098,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.007999999999999,
"layouts": 12,
"layoutDurationMs": 2.578,
"taskDurationMs": 241.03000000000003,
"heapDeltaBytes": 1907912,
"heapUsedBytes": 75179240,
"domNodes": 56,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 6.982000000000002,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262135,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 477.48300000000654,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.5709999999999993,
"layouts": 9,
"layoutDurationMs": 2.124,
"taskDurationMs": 316.623,
"heapDeltaBytes": 876844,
"heapUsedBytes": 62813180,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 107.237,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668965517241382,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 482.99200000008113,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.5869999999999997,
"layouts": 9,
"layoutDurationMs": 2.227,
"taskDurationMs": 314.26200000000006,
"heapDeltaBytes": 3595352,
"heapUsedBytes": 64728876,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 107.00999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379302,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 910.494999999969,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 532.092,
"heapDeltaBytes": -12841468,
"heapUsedBytes": 75901112,
"domNodes": -191,
"jsHeapTotalBytes": 21241856,
"scriptDurationMs": 36.26100000000001,
"eventListeners": -107,
"totalBlockingTimeMs": 264,
"frameDurationMs": 25.463888888888896,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 927.5800000000345,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 553.9720000000001,
"heapDeltaBytes": -12247424,
"heapUsedBytes": 75991680,
"domNodes": -191,
"jsHeapTotalBytes": 20717568,
"scriptDurationMs": 37.962999999999994,
"eventListeners": -107,
"totalBlockingTimeMs": 288,
"frameDurationMs": 26.668571428571433,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 735.61600000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 333.5499999999998,
"heapDeltaBytes": -21640284,
"heapUsedBytes": 67354296,
"domNodes": -191,
"jsHeapTotalBytes": 3801088,
"scriptDurationMs": 94.52499999999999,
"eventListeners": -107,
"totalBlockingTimeMs": 90,
"frameDurationMs": 20.372222222222213,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 702.4599999999737,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 266.2819999999999,
"heapDeltaBytes": -2920420,
"heapUsedBytes": 71272312,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 83.99300000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 81,
"frameDurationMs": 20.58823529411765,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6559.671999999978,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.7590000000000001,
"layouts": 3,
"layoutDurationMs": 0.65,
"taskDurationMs": 5391.85,
"heapDeltaBytes": -16573080,
"heapUsedBytes": 73902020,
"domNodes": -257,
"jsHeapTotalBytes": 6418432,
"scriptDurationMs": 4101.868,
"eventListeners": -91,
"totalBlockingTimeMs": 5,
"frameDurationMs": 20.14233128834356,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6236.358999999993,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.8249999999999993,
"layouts": 3,
"layoutDurationMs": 0.6970000000000002,
"taskDurationMs": 5140.531999999999,
"heapDeltaBytes": 61863896,
"heapUsedBytes": 136021236,
"domNodes": -257,
"jsHeapTotalBytes": 57012224,
"scriptDurationMs": 3907.2340000000004,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.061467889908258,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6172.245000000032,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.9659999999999999,
"layouts": 4,
"layoutDurationMs": 0.879,
"taskDurationMs": 5110.322999999999,
"heapDeltaBytes": 46672820,
"heapUsedBytes": 120971340,
"domNodes": -257,
"jsHeapTotalBytes": 55439360,
"scriptDurationMs": 3917.2780000000002,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.4437106918239,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6597.20399999992,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.7699999999999998,
"layouts": 3,
"layoutDurationMs": 0.7279999999999999,
"taskDurationMs": 5442.519,
"heapDeltaBytes": 71077080,
"heapUsedBytes": 144235000,
"domNodes": -257,
"jsHeapTotalBytes": 64876544,
"scriptDurationMs": 4229.1669999999995,
"eventListeners": -69,
"totalBlockingTimeMs": 21,
"frameDurationMs": 20.76687697160883,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "large-combo-open",
"durationMs": 135.7070000000249,
"styleRecalcs": 21,
"styleRecalcDurationMs": 10.312,
"layouts": 12,
"layoutDurationMs": 2.8420000000000005,
"taskDurationMs": 99.184,
"heapDeltaBytes": 14505696,
"heapUsedBytes": 92105016,
"domNodes": 936,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 5.365,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.04285714285717,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "large-combo-open",
"durationMs": 148.46699999998236,
"styleRecalcs": 21,
"styleRecalcDurationMs": 10.798000000000002,
"layouts": 12,
"layoutDurationMs": 3.003,
"taskDurationMs": 110.32300000000001,
"heapDeltaBytes": -7091044,
"heapUsedBytes": 76160620,
"domNodes": 936,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 6.427,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.41428571428573,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2026.3310000000274,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.863,
"layouts": 8,
"layoutDurationMs": 1.695,
"taskDurationMs": 395.525,
"heapDeltaBytes": 5711468,
"heapUsedBytes": 79132160,
"domNodes": -257,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 24.314,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2008.7120000000596,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.7959999999999998,
"layouts": 9,
"layoutDurationMs": 1.7349999999999999,
"taskDurationMs": 296.688,
"heapDeltaBytes": -12477280,
"heapUsedBytes": 64527624,
"domNodes": -257,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 21.237,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760334,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2130.734000000018,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.654,
"layouts": 7,
"layoutDurationMs": 1.375,
"taskDurationMs": 1056.0179999999998,
"heapDeltaBytes": 16584744,
"heapUsedBytes": 76386912,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 542.108,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66535433070866,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-pan",
"durationMs": 2166.9299999999794,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.207,
"layouts": 9,
"layoutDurationMs": 2.0610000000000004,
"taskDurationMs": 1083.526,
"heapDeltaBytes": -22262528,
"heapUsedBytes": 71907648,
"domNodes": -257,
"jsHeapTotalBytes": 6156288,
"scriptDurationMs": 531.586,
"eventListeners": -89,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665116279069768,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-zoom",
"durationMs": 3168.645000000083,
"styleRecalcs": 74,
"styleRecalcDurationMs": 10.889,
"layouts": 67,
"layoutDurationMs": 11.41,
"taskDurationMs": 1186.0949999999998,
"heapDeltaBytes": -7814536,
"heapUsedBytes": 64274700,
"domNodes": -233,
"jsHeapTotalBytes": 1961984,
"scriptDurationMs": 522.6690000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684207,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3122.3449999999957,
"styleRecalcs": 73,
"styleRecalcDurationMs": 10.848,
"layouts": 67,
"layoutDurationMs": 11.331,
"taskDurationMs": 1186.4350000000002,
"heapDeltaBytes": -16697576,
"heapUsedBytes": 62094308,
"domNodes": 24,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 533.006,
"eventListeners": -4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666844919786094,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "legacy-node-drag",
"durationMs": 2222.8240000000596,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.176,
"layouts": 7,
"layoutDurationMs": 1.549,
"taskDurationMs": 1279.5899999999997,
"heapDeltaBytes": 13981184,
"heapUsedBytes": 90535180,
"domNodes": 0,
"jsHeapTotalBytes": 6184960,
"scriptDurationMs": 648.5880000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665413533834588,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2275.700000000029,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.7780000000000005,
"layouts": 6,
"layoutDurationMs": 1.3940000000000003,
"taskDurationMs": 1283.154,
"heapDeltaBytes": 16440488,
"heapUsedBytes": 98266784,
"domNodes": 0,
"jsHeapTotalBytes": 8282112,
"scriptDurationMs": 631.0519999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665693430656937,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2739.471999999978,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.687,
"layouts": 9,
"layoutDurationMs": 1.7069999999999999,
"taskDurationMs": 485.07,
"heapDeltaBytes": -8858968,
"heapUsedBytes": 67169152,
"domNodes": -257,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 221.70999999999998,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666463414634148,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2755.6190000000242,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.9889999999999994,
"layouts": 8,
"layoutDurationMs": 1.832,
"taskDurationMs": 488.44300000000004,
"heapDeltaBytes": -2689560,
"heapUsedBytes": 74266160,
"domNodes": -257,
"jsHeapTotalBytes": -397312,
"scriptDurationMs": 223.57000000000002,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666060606060608,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-idle",
"durationMs": 2021.40600000007,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.954,
"layouts": 9,
"layoutDurationMs": 1.7730000000000001,
"taskDurationMs": 396.708,
"heapDeltaBytes": -806200,
"heapUsedBytes": 75621692,
"domNodes": -257,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 24.609,
"eventListeners": -91,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2037.0470000000296,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.7399999999999993,
"layouts": 8,
"layoutDurationMs": 1.6370000000000002,
"taskDurationMs": 387.454,
"heapDeltaBytes": -20862668,
"heapUsedBytes": 63054916,
"domNodes": -257,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 23.649000000000004,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2696.302000000003,
"styleRecalcs": 27,
"styleRecalcDurationMs": 9.959,
"layouts": 8,
"layoutDurationMs": 1.452,
"taskDurationMs": 398.27900000000005,
"heapDeltaBytes": -10923848,
"heapUsedBytes": 64420216,
"domNodes": -256,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 134.588,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66604938271605,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2675.297999999998,
"styleRecalcs": 28,
"styleRecalcDurationMs": 9.770000000000001,
"layouts": 9,
"layoutDurationMs": 1.7350000000000003,
"taskDurationMs": 381.829,
"heapDeltaBytes": -10764356,
"heapUsedBytes": 62730016,
"domNodes": -243,
"jsHeapTotalBytes": 389120,
"scriptDurationMs": 121.80899999999998,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66645962732919,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-topology-cadence",
"durationMs": 2881.7549999999983,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.6179999999999997,
"layouts": 8,
"layoutDurationMs": 1.5090000000000001,
"taskDurationMs": 608.095,
"heapDeltaBytes": -10717904,
"heapUsedBytes": 66142000,
"domNodes": -257,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 234.47199999999998,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666473988439304,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 2874.7260000000097,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.3680000000000003,
"layouts": 7,
"layoutDurationMs": 1.195,
"taskDurationMs": 594.6320000000001,
"heapDeltaBytes": -11368780,
"heapUsedBytes": 65921200,
"domNodes": -257,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 228.32000000000002,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665697674418606,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 441.5759999999409,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.93,
"layouts": 10,
"layoutDurationMs": 2.426,
"taskDurationMs": 285.32800000000003,
"heapDeltaBytes": 21535688,
"heapUsedBytes": 83850964,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 97.33200000000001,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66538461538462,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 431.00700000002234,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.605,
"layouts": 9,
"layoutDurationMs": 2.1080000000000005,
"taskDurationMs": 288.484,
"heapDeltaBytes": -171716,
"heapUsedBytes": 62277620,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 99.348,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2026.2809999999831,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.5500000000000003,
"layouts": 10,
"layoutDurationMs": 2.058,
"taskDurationMs": 350.75600000000003,
"heapDeltaBytes": -25242764,
"heapUsedBytes": 57995920,
"domNodes": -183,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 5.885,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2022.1990000000005,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.183,
"layouts": 11,
"layoutDurationMs": 2.063,
"taskDurationMs": 337.787,
"heapDeltaBytes": -7809000,
"heapUsedBytes": 75288052,
"domNodes": -183,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 5.018999999999999,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1676.7130000000066,
"styleRecalcs": 75,
"styleRecalcDurationMs": 11.973999999999998,
"layouts": 9,
"layoutDurationMs": 1.926,
"taskDurationMs": 527.897,
"heapDeltaBytes": 18083068,
"heapUsedBytes": 81168516,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 77.064,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.3180000000903,
"styleRecalcs": 75,
"styleRecalcDurationMs": 12.971,
"layouts": 10,
"layoutDurationMs": 2.2950000000000004,
"taskDurationMs": 548.769,
"heapDeltaBytes": 19017448,
"heapUsedBytes": 82076148,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 78.657,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509802,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 833.972000000017,
"styleRecalcs": 19,
"styleRecalcDurationMs": 14.795,
"layouts": 5,
"layoutDurationMs": 8.961,
"taskDurationMs": 635.651,
"heapDeltaBytes": 38140300,
"heapUsedBytes": 114392680,
"domNodes": 16030,
"jsHeapTotalBytes": 14815232,
"scriptDurationMs": 17.933,
"eventListeners": 3246,
"totalBlockingTimeMs": 81,
"frameDurationMs": 19.379069767441855,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8170.586999999955,
"styleRecalcs": 250,
"styleRecalcDurationMs": 33.389,
"layouts": 9,
"layoutDurationMs": 2.061,
"taskDurationMs": 3747.8389999999995,
"heapDeltaBytes": 10554784,
"heapUsedBytes": 85404844,
"domNodes": -257,
"jsHeapTotalBytes": 1138688,
"scriptDurationMs": 1777.634,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66591836734694,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8371.70900000001,
"styleRecalcs": 250,
"styleRecalcDurationMs": 34.575,
"layouts": 10,
"layoutDurationMs": 2.1399999999999997,
"taskDurationMs": 4002.7270000000003,
"heapDeltaBytes": -10528560,
"heapUsedBytes": 63527212,
"domNodes": -257,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 1940.6989999999998,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666202783300196,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 15800.486999999976,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15034.295,
"heapDeltaBytes": -15508472,
"heapUsedBytes": 282361644,
"domNodes": -3343,
"jsHeapTotalBytes": -4726784,
"scriptDurationMs": 200.89200000000002,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.716216216216218,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-idle",
"durationMs": 17452.775999999973,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16684.286,
"heapDeltaBytes": -14728976,
"heapUsedBytes": 283261816,
"domNodes": -3343,
"jsHeapTotalBytes": -6561792,
"scriptDurationMs": 233.402,
"eventListeners": -653,
"totalBlockingTimeMs": 10,
"frameDurationMs": 29.8791095890411,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "vue-large-graph-pan",
"durationMs": 18956.772,
"styleRecalcs": 167,
"styleRecalcDurationMs": 16.28299999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18479.094,
"heapDeltaBytes": -17369332,
"heapUsedBytes": 275545592,
"domNodes": -3343,
"jsHeapTotalBytes": 14143488,
"scriptDurationMs": 695.219,
"eventListeners": -651,
"totalBlockingTimeMs": 65,
"frameDurationMs": 34.485610200364306,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 20307.476000000064,
"styleRecalcs": 163,
"styleRecalcDurationMs": 20.482,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19992.359,
"heapDeltaBytes": -8671820,
"heapUsedBytes": 289294448,
"domNodes": -3343,
"jsHeapTotalBytes": 21155840,
"scriptDurationMs": 685.8409999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 24,
"frameDurationMs": 37.87164179104478,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 5570.263999999952,
"styleRecalcs": 20,
"styleRecalcDurationMs": 52.88200000000001,
"layouts": 20,
"layoutDurationMs": 28.453000000000007,
"taskDurationMs": 5453.883999999999,
"heapDeltaBytes": 570028,
"heapUsedBytes": 278445972,
"domNodes": -3343,
"jsHeapTotalBytes": 26202112,
"scriptDurationMs": 74.349,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.53253012048192,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6133.192000000008,
"styleRecalcs": 20,
"styleRecalcDurationMs": 43.635000000000005,
"layouts": 20,
"layoutDurationMs": 23.671,
"taskDurationMs": 5982.61,
"heapDeltaBytes": -40931420,
"heapUsedBytes": 262534292,
"domNodes": -3343,
"jsHeapTotalBytes": 21745664,
"scriptDurationMs": 103.44699999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 30,
"frameDurationMs": 35.9625730994152,
"p95FrameDurationMs": 83.30000000000018
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5601.40899999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5265.461,
"heapDeltaBytes": 6643456,
"heapUsedBytes": 273903944,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 64.54799999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.805405405405406,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7536.440999999968,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7263.449,
"heapDeltaBytes": -4410844,
"heapUsedBytes": 274245852,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 87.35199999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.363636363636363,
"p95FrameDurationMs": 50
},
{
"name": "workflow-execution",
"durationMs": 438.9139999999543,
"styleRecalcs": 13,
"styleRecalcDurationMs": 7.672000000000001,
"layouts": 11,
"layoutDurationMs": 2.6899999999999995,
"taskDurationMs": 85.65899999999999,
"heapDeltaBytes": -16500708,
"heapUsedBytes": 62535792,
"domNodes": 102,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 7.597000000000001,
"eventListeners": 3,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 93.42500000002474,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.6480000000000015,
"layouts": 7,
"layoutDurationMs": 2.1710000000000003,
"taskDurationMs": 51.235,
"heapDeltaBytes": 4672432,
"heapUsedBytes": 76059844,
"domNodes": 106,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 4.193,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 177.6630000000523,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.5860000000000001,
"layouts": 76,
"layoutDurationMs": 8.94,
"taskDurationMs": 146.832,
"heapDeltaBytes": 9497300,
"heapUsedBytes": 50495212,
"domNodes": 4,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 58.044,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636382,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 195.8110000000488,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.615,
"layouts": 76,
"layoutDurationMs": 9.953999999999999,
"taskDurationMs": 162.916,
"heapDeltaBytes": 9822692,
"heapUsedBytes": 51424292,
"domNodes": 4,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 66.83500000000001,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 239.89699999992808,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.148,
"layouts": 76,
"layoutDurationMs": 9.931000000000001,
"taskDurationMs": 209.31900000000002,
"heapDeltaBytes": -1485276,
"heapUsedBytes": 88244808,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 68.07900000000001,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 249.81700000000728,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.1520000000000001,
"layouts": 76,
"layoutDurationMs": 10.147,
"taskDurationMs": 215.82399999999998,
"heapDeltaBytes": -1358256,
"heapUsedBytes": 91425608,
"domNodes": 4,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 71.609,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662500000000023,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage: 🟡 59.5% of linesCoverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3158 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 2346d52f60f3d57b766fec94df14769573b26608
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (328)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## cloud/1.59 #23501 +/- ##
=============================================
Coverage ? 87.13%
=============================================
Files ? 3127
Lines ? 163091
Branches ? 40900
=============================================
Hits ? 142108
Misses ? 20306
Partials ? 677
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Approved as a backport, per the requested backport review policy. No code-change review or tests run.
Summary
Use the Comfy Cloud video and updated copy in the deployment dialogs. Keep the agent choice explicit and prefill an unsent handoff without replacing an existing draft.
Backport of #23463 — show the Comfy Cloud video in the deployment dialogs
Backport of #23475 — frame Deploy your setup around running workflows on Comfy Cloud
Backport of #23470 — preserve agent choice and update Cloud handoff
Keeps the release branch’s UI and telemetry imports and retains its consent tests.
With Open on Cloud enabled, Desktop and Desktop 2 now show the toolbar button. The target branch already includes the system-browser relay (backport #23154). Local and Desktop handoffs reference a saved workflow on the server; Cloud handoffs still export JSON. The separate Deploy to Comfy API dialog now asks localhost users to export the workflow themselves.
Verification