Repository navigation
[backport cloud/1.59] feat: Workflow-id links open the saved workflow on Comfy Cloud (#23051) - #23239
Conversation
… on Comfy Cloud (#23051) Backport of #23051 to cloud/1.59. Conflicts resolved by hand: the generated ingest-types files take cloud/1.59's copy plus the sidebar-file route lines #23051 added, and imports use cloud/1.59's paths (@/platform/telemetry, @/platform/workspace, @/types). (cherry picked from commit fe18e38)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 7 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-10T22:41:27.805Z",
"gitSha": "0a87f1ef4b34f88a66b9545b11f9d7ddb68b07b4",
"branch": "backport-23051-to-cloud-1.59",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2006.8729999999846,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.301,
"layouts": 9,
"layoutDurationMs": 2.326,
"taskDurationMs": 513.5730000000001,
"heapDeltaBytes": 4381296,
"heapUsedBytes": 66755612,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 8.028,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2040.1879999999437,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.4430000000000005,
"layouts": 8,
"layoutDurationMs": 2.5189999999999997,
"taskDurationMs": 572.3979999999999,
"heapDeltaBytes": -10682448,
"heapUsedBytes": 50714416,
"domNodes": -161,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 9.498,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1775.5089999999996,
"styleRecalcs": 74,
"styleRecalcDurationMs": 12.083,
"layouts": 9,
"layoutDurationMs": 2.5980000000000003,
"taskDurationMs": 918.554,
"heapDeltaBytes": -10912520,
"heapUsedBytes": 62039000,
"domNodes": -161,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 157.26500000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665094339622645,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1860.2470000000721,
"styleRecalcs": 75,
"styleRecalcDurationMs": 13.597999999999999,
"layouts": 9,
"layoutDurationMs": 2.8089999999999997,
"taskDurationMs": 922.782,
"heapDeltaBytes": 22006180,
"heapUsedBytes": 84094188,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 167.487,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665178571428573,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.1099999999865,
"styleRecalcs": 20,
"styleRecalcDurationMs": 4.819,
"layouts": 9,
"layoutDurationMs": 2.64,
"taskDurationMs": 400.811,
"heapDeltaBytes": 1057516,
"heapUsedBytes": 62194772,
"domNodes": 56,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 10.134,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1706.0339999999314,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.287000000000001,
"layouts": 10,
"layoutDurationMs": 2.282,
"taskDurationMs": 400.578,
"heapDeltaBytes": 1681548,
"heapUsedBytes": 72019328,
"domNodes": 56,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 9.629999999999999,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 665.7749999999965,
"styleRecalcs": 15,
"styleRecalcDurationMs": 2.858,
"layouts": 10,
"layoutDurationMs": 2.469,
"taskDurationMs": 480.96000000000004,
"heapDeltaBytes": 6542036,
"heapUsedBytes": 77595776,
"domNodes": 0,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 169.535,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 693.7249999999722,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.158,
"layouts": 10,
"layoutDurationMs": 2.851,
"taskDurationMs": 503.965,
"heapDeltaBytes": 654660,
"heapUsedBytes": 60570264,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 173.674,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853658,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1130.156999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 806.0299999999999,
"heapDeltaBytes": 18281716,
"heapUsedBytes": 85541016,
"domNodes": 0,
"jsHeapTotalBytes": 9076736,
"scriptDurationMs": 63.58700000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 503,
"frameDurationMs": 33.332352941176474,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1132.7420000000075,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 826.355,
"heapDeltaBytes": 17658724,
"heapUsedBytes": 88317444,
"domNodes": 0,
"jsHeapTotalBytes": 11698176,
"scriptDurationMs": 64.33100000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 509,
"frameDurationMs": 34.339393939393936,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 841.7909999999722,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 478.58299999999997,
"heapDeltaBytes": -4997728,
"heapUsedBytes": 70676828,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 149.928,
"eventListeners": 0,
"totalBlockingTimeMs": 215,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 843.7099999999873,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 476.6469999999998,
"heapDeltaBytes": -4567828,
"heapUsedBytes": 70544904,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 150.428,
"eventListeners": 0,
"totalBlockingTimeMs": 210,
"frameDurationMs": 24.9970588235294,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10886.515000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9956.884,
"heapDeltaBytes": -11513716,
"heapUsedBytes": 67116128,
"domNodes": 0,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 8062.901,
"eventListeners": 0,
"totalBlockingTimeMs": 1081,
"frameDurationMs": 31.728571428571428,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10229.007000000023,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9459.525,
"heapDeltaBytes": 63542152,
"heapUsedBytes": 137579484,
"domNodes": -257,
"jsHeapTotalBytes": 71430144,
"scriptDurationMs": 7561.476,
"eventListeners": -69,
"totalBlockingTimeMs": 746,
"frameDurationMs": 31.925625000000004,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10555.409999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9831.609,
"heapDeltaBytes": 41196,
"heapUsedBytes": 80606888,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 8008.963999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 978,
"frameDurationMs": 31.49134328358209,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9847.433000000023,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9051.714,
"heapDeltaBytes": 53114976,
"heapUsedBytes": 126574788,
"domNodes": -257,
"jsHeapTotalBytes": 60157952,
"scriptDurationMs": 7207.945,
"eventListeners": -69,
"totalBlockingTimeMs": 701,
"frameDurationMs": 31.169936708860757,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 283.190999999988,
"styleRecalcs": 25,
"styleRecalcDurationMs": 15.034000000000002,
"layouts": 13,
"layoutDurationMs": 8.652,
"taskDurationMs": 249.487,
"heapDeltaBytes": -16557188,
"heapUsedBytes": 66606348,
"domNodes": -2315,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 9.713999999999999,
"eventListeners": -574,
"totalBlockingTimeMs": 6,
"frameDurationMs": 23.60833333333331,
"p95FrameDurationMs": 100
},
{
"name": "large-combo-open",
"durationMs": 235.41999999997643,
"styleRecalcs": 23,
"styleRecalcDurationMs": 12.626,
"layouts": 9,
"layoutDurationMs": 2.8870000000000005,
"taskDurationMs": 179.78900000000004,
"heapDeltaBytes": 14676100,
"heapUsedBytes": 71213536,
"domNodes": -2315,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.991999999999999,
"eventListeners": 205,
"totalBlockingTimeMs": 4,
"frameDurationMs": 23.339999999999964,
"p95FrameDurationMs": 83.30000000000018
},
{
"name": "large-graph-idle",
"durationMs": 2060.280999999975,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.1599999999999997,
"layouts": 8,
"layoutDurationMs": 2.2560000000000002,
"taskDurationMs": 456.88000000000005,
"heapDeltaBytes": -12068860,
"heapUsedBytes": 70180384,
"domNodes": -257,
"jsHeapTotalBytes": -659456,
"scriptDurationMs": 30.645000000000007,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2065.270000000055,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.66,
"layouts": 7,
"layoutDurationMs": 5.468,
"taskDurationMs": 695.639,
"heapDeltaBytes": -12913360,
"heapUsedBytes": 69622828,
"domNodes": -257,
"jsHeapTotalBytes": -397312,
"scriptDurationMs": 40.214999999999996,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2424.851999999987,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.013,
"layouts": 6,
"layoutDurationMs": 1.626,
"taskDurationMs": 1658.217,
"heapDeltaBytes": -18740380,
"heapUsedBytes": 61418468,
"domNodes": -257,
"jsHeapTotalBytes": 913408,
"scriptDurationMs": 801.873,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666438356164385,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2433.836999999926,
"styleRecalcs": 66,
"styleRecalcDurationMs": 7.380999999999999,
"layouts": 4,
"layoutDurationMs": 0.719,
"taskDurationMs": 1620.5909999999997,
"heapDeltaBytes": 15553148,
"heapUsedBytes": 76375544,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 799.903,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665753424657535,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3593.4330000000045,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.191,
"layouts": 62,
"layoutDurationMs": 9.631,
"taskDurationMs": 1689.2559999999999,
"heapDeltaBytes": 1636748,
"heapUsedBytes": 62582160,
"domNodes": -233,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 753.437,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666046511627908,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3523.6700000000383,
"styleRecalcs": 68,
"styleRecalcDurationMs": 7.921999999999999,
"layouts": 62,
"layoutDurationMs": 8.962000000000002,
"taskDurationMs": 1695.2969999999998,
"heapDeltaBytes": 4570052,
"heapUsedBytes": 66772152,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 757.356,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665876777251185,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2885.5239999999753,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.635,
"layouts": 5,
"layoutDurationMs": 1.1620000000000004,
"taskDurationMs": 1902.1540000000002,
"heapDeltaBytes": 16779460,
"heapUsedBytes": 97699104,
"domNodes": 0,
"jsHeapTotalBytes": 5922816,
"scriptDurationMs": 954.678,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.860818713450293,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2932.9910000000154,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.425999999999999,
"layouts": 5,
"layoutDurationMs": 1.2100000000000002,
"taskDurationMs": 1932.5649999999998,
"heapDeltaBytes": -9115128,
"heapUsedBytes": 73396768,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 970.2360000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.858045977011496,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3063.1799999999885,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.4969999999999992,
"layouts": 6,
"layoutDurationMs": 1.5989999999999998,
"taskDurationMs": 749.9840000000002,
"heapDeltaBytes": -1692088,
"heapUsedBytes": 81733528,
"domNodes": -257,
"jsHeapTotalBytes": 1961984,
"scriptDurationMs": 346.294,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666304347826088,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3082.0750000000317,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.503999999999999,
"layouts": 6,
"layoutDurationMs": 1.5790000000000002,
"taskDurationMs": 794.8820000000001,
"heapDeltaBytes": -266148,
"heapUsedBytes": 82306660,
"domNodes": -257,
"jsHeapTotalBytes": 651264,
"scriptDurationMs": 377.01,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66576086956522,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2021.19399999998,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.5200000000000005,
"layouts": 2,
"layoutDurationMs": 0.49299999999999994,
"taskDurationMs": 594.7489999999999,
"heapDeltaBytes": 10606840,
"heapUsedBytes": 72215372,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 31.135999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "minimap-idle",
"durationMs": 2028.0370000000403,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.8349999999999997,
"layouts": 6,
"layoutDurationMs": 1.768,
"taskDurationMs": 662.6860000000001,
"heapDeltaBytes": -5284308,
"heapUsedBytes": 74043020,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 32.17099999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2753.0280000000002,
"styleRecalcs": 25,
"styleRecalcDurationMs": 11.900999999999998,
"layouts": 6,
"layoutDurationMs": 1.7380000000000004,
"taskDurationMs": 600.6389999999999,
"heapDeltaBytes": -2435944,
"heapUsedBytes": 75820392,
"domNodes": -253,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 190.26700000000002,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666060606060604,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2763.8529999999832,
"styleRecalcs": 22,
"styleRecalcDurationMs": 10.270999999999999,
"layouts": 3,
"layoutDurationMs": 0.826,
"taskDurationMs": 537.806,
"heapDeltaBytes": 674132,
"heapUsedBytes": 63414284,
"domNodes": 19,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 180.67300000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66566265060241,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-topology-cadence",
"durationMs": 3189.2740000000117,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.46200000000000063,
"layouts": 2,
"layoutDurationMs": 0.43199999999999966,
"taskDurationMs": 838.8930000000001,
"heapDeltaBytes": 3073640,
"heapUsedBytes": 64814404,
"domNodes": 0,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 345.873,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665968586387436,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-topology-cadence",
"durationMs": 3218.028000000004,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.503,
"layouts": 2,
"layoutDurationMs": 0.4639999999999996,
"taskDurationMs": 870.772,
"heapDeltaBytes": 4202240,
"heapUsedBytes": 66336396,
"domNodes": 0,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 364.298,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66580310880829,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 598.2369999999833,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.837999999999999,
"layouts": 9,
"layoutDurationMs": 2.233,
"taskDurationMs": 439.425,
"heapDeltaBytes": 1026416,
"heapUsedBytes": 62932524,
"domNodes": 0,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 146.318,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663888888888877,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 607.2769999999537,
"styleRecalcs": 48,
"styleRecalcDurationMs": 4.939,
"layouts": 11,
"layoutDurationMs": 2.745,
"taskDurationMs": 426.458,
"heapDeltaBytes": 21088536,
"heapUsedBytes": 82853252,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 144.468,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2038.6780000000044,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.3369999999999997,
"layouts": 9,
"layoutDurationMs": 2.519,
"taskDurationMs": 544.896,
"heapDeltaBytes": 2724748,
"heapUsedBytes": 64885624,
"domNodes": -183,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 7.289000000000001,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2022.1010000000206,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.893,
"layouts": 9,
"layoutDurationMs": 2.937,
"taskDurationMs": 522.7270000000001,
"heapDeltaBytes": 2564596,
"heapUsedBytes": 65824740,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 8.232000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1718.2300000000055,
"styleRecalcs": 76,
"styleRecalcDurationMs": 12.378,
"layouts": 10,
"layoutDurationMs": 2.6079999999999997,
"taskDurationMs": 831.725,
"heapDeltaBytes": 13616856,
"heapUsedBytes": 74269548,
"domNodes": -183,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 103.962,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.0160000000196,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.152999999999999,
"layouts": 9,
"layoutDurationMs": 3.147,
"taskDurationMs": 910.71,
"heapDeltaBytes": -14628484,
"heapUsedBytes": 60607532,
"domNodes": -183,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 113.138,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 1485.492000000022,
"styleRecalcs": 20,
"styleRecalcDurationMs": 22.037000000000003,
"layouts": 5,
"layoutDurationMs": 16.191999999999997,
"taskDurationMs": 1077.743,
"heapDeltaBytes": 11503780,
"heapUsedBytes": 106402016,
"domNodes": 16030,
"jsHeapTotalBytes": 16916480,
"scriptDurationMs": 29.061000000000003,
"eventListeners": 3246,
"totalBlockingTimeMs": 152,
"frameDurationMs": 19.229487179487187,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9283.231999999998,
"styleRecalcs": 248,
"styleRecalcDurationMs": 26.019000000000002,
"layouts": 5,
"layoutDurationMs": 1.081,
"taskDurationMs": 5884.319,
"heapDeltaBytes": 15807768,
"heapUsedBytes": 75947792,
"domNodes": -257,
"jsHeapTotalBytes": 192512,
"scriptDurationMs": 2684.008,
"eventListeners": -63,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665888689407538,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9056.084000000055,
"styleRecalcs": 251,
"styleRecalcDurationMs": 27.544,
"layouts": 8,
"layoutDurationMs": 2.353999999999999,
"taskDurationMs": 5876.9800000000005,
"heapDeltaBytes": 935712,
"heapUsedBytes": 81004884,
"domNodes": -257,
"jsHeapTotalBytes": 876544,
"scriptDurationMs": 2707.134,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611418047882,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 23283.026000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22470.625000000004,
"heapDeltaBytes": -30755604,
"heapUsedBytes": 266034868,
"domNodes": -3343,
"jsHeapTotalBytes": 9687040,
"scriptDurationMs": 354.16600000000005,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.0041237113402,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-large-graph-idle",
"durationMs": 23761.990999999965,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23164.239999999998,
"heapDeltaBytes": -36640792,
"heapUsedBytes": 261032240,
"domNodes": -3343,
"jsHeapTotalBytes": 4444160,
"scriptDurationMs": 321.483,
"eventListeners": -664,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.25972222222222,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 28088.932,
"styleRecalcs": 181,
"styleRecalcDurationMs": 17.58900000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27718.487,
"heapDeltaBytes": 18084668,
"heapUsedBytes": 267327520,
"domNodes": -3343,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 860.8739999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 14,
"frameDurationMs": 51.77790055248619,
"p95FrameDurationMs": 116.60000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 28675.86599999993,
"styleRecalcs": 181,
"styleRecalcDurationMs": 19.696999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28314.686,
"heapDeltaBytes": -53961444,
"heapUsedBytes": 248976444,
"domNodes": -3343,
"jsHeapTotalBytes": 6279168,
"scriptDurationMs": 899.045,
"eventListeners": -651,
"totalBlockingTimeMs": 17,
"frameDurationMs": 53.67716981132075,
"p95FrameDurationMs": 116.60000000000218
},
{
"name": "vue-node-resize-workload",
"durationMs": 8424.585000000036,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.52500000000002,
"layouts": 20,
"layoutDurationMs": 28.543999999999986,
"taskDurationMs": 8256.061000000002,
"heapDeltaBytes": -32285224,
"heapUsedBytes": 264909048,
"domNodes": -3372,
"jsHeapTotalBytes": 9424896,
"scriptDurationMs": 160.022,
"eventListeners": -653,
"totalBlockingTimeMs": 56,
"frameDurationMs": 47.91477272727274,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8589.843999999972,
"styleRecalcs": 20,
"styleRecalcDurationMs": 67.66899999999998,
"layouts": 20,
"layoutDurationMs": 25.516999999999985,
"taskDurationMs": 8471.623,
"heapDeltaBytes": -19203000,
"heapUsedBytes": 255265896,
"domNodes": -3343,
"jsHeapTotalBytes": 19386368,
"scriptDurationMs": 127.48700000000002,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 49.14057142857142,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11769.649000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11386.972,
"heapDeltaBytes": 36344804,
"heapUsedBytes": 283811008,
"domNodes": 0,
"jsHeapTotalBytes": -14942208,
"scriptDurationMs": 150.70600000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.713494809688584,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-zoom-out-idle",
"durationMs": 12592.518999999924,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12208.91,
"heapDeltaBytes": -1824920,
"heapUsedBytes": 276623348,
"domNodes": 0,
"jsHeapTotalBytes": -5767168,
"scriptDurationMs": 172.92199999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 44.99857142857144,
"p95FrameDurationMs": 100
},
{
"name": "workflow-execution",
"durationMs": 485.1239999999848,
"styleRecalcs": 17,
"styleRecalcDurationMs": 9.785,
"layouts": 11,
"layoutDurationMs": 4.129,
"taskDurationMs": 141.19400000000002,
"heapDeltaBytes": -10666568,
"heapUsedBytes": 63482180,
"domNodes": 132,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 14.097000000000001,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 132.59500000003754,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.158000000000001,
"layouts": 9,
"layoutDurationMs": 4.1370000000000005,
"taskDurationMs": 94.93299999999999,
"heapDeltaBytes": 4664860,
"heapUsedBytes": 75015724,
"domNodes": 125,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.97,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.674999999999955,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 646.1360000000695,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.6579999999999999,
"layouts": 76,
"layoutDurationMs": 17.291,
"taskDurationMs": 608.047,
"heapDeltaBytes": -1362392,
"heapUsedBytes": 46472364,
"domNodes": 4,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 298.197,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66500000000001,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 579.947000000061,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.664,
"layouts": 76,
"layoutDurationMs": 16.267,
"taskDurationMs": 526.269,
"heapDeltaBytes": -2332236,
"heapUsedBytes": 45768668,
"domNodes": 4,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 255.88499999999996,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66285714285714,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 616.5889999999763,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.939,
"layouts": 76,
"layoutDurationMs": 15.626000000000001,
"taskDurationMs": 579.6809999999999,
"heapDeltaBytes": 1147752,
"heapUsedBytes": 103995244,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 228.64100000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567563,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 574.5149999999057,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.821,
"layouts": 76,
"layoutDurationMs": 14.447,
"taskDurationMs": 545.716,
"heapDeltaBytes": 1093316,
"heapUsedBytes": 104489272,
"domNodes": 4,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 218.203,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714266,
"p95FrameDurationMs": 16.700000000000728
}
]
}🎭 Playwright: ✅ 3153 passed, 0 failed · 4 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 8157722c9732bf9243a6f4d74d27380ed0dbbca4
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (324)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report❌ Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
cloud/1.59 classifies src/platform/workflow/management/composables as workflow-management, whose zone may not import telemetry, toast, i18n, navigation, workspace or the API client, and which app-host and workflow-persistence may not import. Move the workflow-id loader, its test and the linked-workflow loader to unclassified src/composables, where the other cross-domain URL loaders already live, and move the settled-link sweep out of useUrlActionLoaders so its navigation import stays as the base has it. Move the redirect round-trip test to preservedQueryTracker.test.ts, whose zone may import the tracker and manager, and cover the registry's trackWorkflowLinkOpened dispatch. Behavior is unchanged.
dante01yoon
left a comment
There was a problem hiding this comment.
Approved as a backport of #23051 to cloud/1.59, per the backport review policy. Tests were not run; CI is still in progress.
A navigation guard can hold a newer ?workflowId while the URL still shows the link that just opened. The URL-action pass then cleaned up for the opened link: its router.replace cancelled the held navigation and the cleanup cleared the newer link's stash, so the newer link was lost. Ownership of the URL and the stash now belongs to the link being handled. When the URL and the stash name different links, the loader treats the stash as a navigation still in flight and leaves both alone, even for a link it already opened. The loader tests now run on a real memory router with the preserved-query tracker, and hold navigations in real guards instead of faking cancellation through a replace mock. On cloud/1.59 reportError has no shared mock, so the test file mocks it; without that, the six tests that assert a report failed.
When the sidebar-file lookup succeeded but reading the linked file
failed, the loader reported the read error as the cause of its own
error. That error names the file ("Failed to load file
'workflows/<name>.json': 500 ..."), and the error sinks keep a nested
cause, so a user's workflow file name reached error reporting. A lookup
reply that was not JSON did the same with the parser's message, which
quotes the reply.
The loader now reports a fixed message with the error's class name as
context, and never the caught error itself.
|
Thanks @dante01yoon. Two commits landed after your approval, the same two fixes as #23245 on main:
Each has a test that failed before the fix. The full list is at the end of the PR body. |
Opening /?workflowId= while the session still held an earlier workflow id left that id saved: an empty value was not worth capturing, so the capture kept the old one. The loader then read the saved id as a newer navigation in flight and returned pending without reporting the empty link or clearing it, on every reload. For namespaces that mark ambiguous values (rejectRepeated), a key present with an empty value now clears the saved value when the router captures it. The empty link is rejected as invalid, reported, and cleared from the URL and the stash, as before. A newer link a navigation guard holds is still captured after the empty one, so it keeps its protection.
|
@dante01yoon one more commit after your approval, also going to
Its tests failed before the fix. Auto-merge is on for this head. |
…reports (Comfy-Org#23245) ## Summary Six fixes to workflow-id links (Comfy-Org#23051). **A newer link could be lost.** You open a `?workflowId=` link and it opens. Before its URL cleanup finishes, the browser goes to a second `?workflowId=` link, and a navigation guard (sign-in, for example) holds it. Then the URL actions run after boot and clean up for the first link again. That cleanup cancelled the held navigation and cleared its saved query, so the second link never opened. Now, when the URL and the saved query name different links, the loader treats the saved one as a navigation still in flight. It makes no replace and clears neither, even for a link it already opened. **A file name could reach error reports.** The lookup finds the linked file, but reading the file fails (a 500, or the file was deleted in between). The read error says `Failed to load file 'workflows/<name>.json'`, and the loader passed it on as the cause of its own report. The error sinks keep nested causes, so the user's file name reached them. A lookup reply that was not JSON did the same with the parser message, which quotes the reply. Now the loader reports a fixed message with the error's class name only. **An empty link could stay stuck.** A tab still holds the saved query from an earlier link that has not finished (a sign-in, for example). You then open `?workflowId=` with no value. The empty value did not replace the saved one, so the loader saw two different links, treated the old one as a navigation in flight and stayed pending: no error message, and nothing cleared. Now an empty `workflowId` saves a `,` marker in place of the older link. While a guard holds the empty link, an older lookup still sees a newer link and stays pending, so its cleanup cannot cancel that navigation or drop its other URL actions. Once the empty link lands, the loader treats `''` and the marker as the same link: it is rejected as invalid, reported once, and cleared. For `workspace`, `deployment` and `workflows`, an empty URL value clears the stale saved value at capture; their loaders already treat an empty value as no value. **Custom node code could put its own text in error reports.** Loading a workflow runs custom node code, such as a widget's `computeSize`. That code can throw an error under any name, user data included, and the loader reported that name as the error's class. Now the report names the class only when it is a built-in JavaScript error (`Error`, `TypeError`, `SyntaxError` and the rest) and says `other` for any other name, or when reading the name throws. **A newer malformed link could be lost.** You open a malformed link such as `?workflowId=bad1`. While it is rejected, the browser goes to `?workflowId=bad2` with another URL action, and a navigation guard holds it. The loader counted any two values that are not workflow ids as the same link, so the cleanup for `bad1` replaced the route and cleared the saved `bad2`: the held navigation was cancelled and its other URL actions were lost. Now two different malformed values are different links. Only the forms the saved query records for one URL value (a repeated value joined with `,`, a bare `?workflowId` as `,`) still count as the same link. The loader tests now use a real memory router with the preserved-query tracker. They hold navigations in real guards instead of faking cancellation through a `router.replace` mock. ADR WORKFLOW-LINKS-0053 is updated for all six rules. **Why** Workflow-id links (Comfy-Org#23051) open one saved workflow on Comfy Cloud. Self-reviews of its backport to `cloud/1.59` (Comfy-Org#23239) found three ways they go wrong in the code Comfy-Org#23051 put on `main`: a second link held by sign-in never opens, a user's file name reaches the error sinks, and an empty `?workflowId=` leaves the page stuck with no message. The backport carries the same three commits; this PR puts them on `main` so the next cloud release line has them too. ## Verification - `vitest run src/platform/workflow/management/composables/useWorkflowLinkUrlLoader.test.ts`: on `main`, the new race test and both new reporting tests fail; with these commits, 41 passed. - The empty-link test (`rejects an empty workflowId while an older link is still stashed`) and the tracker test (`clears a stale rejectRepeated value when the URL supplies an empty value`) failed before the third commit. With it, the navigation tests, the loader and `useUrlActionLoaders` pass: 180 tests in 9 files. - The new tests `reports that custom node code throws an error under its own name without the file name or the error text` and `leaves a newer malformed link a navigation guard holds while an older malformed link is rejected` each failed before its fix (1 failed, 41 and 42 passed). With both fixes, the loader and `preservedQueryTracker` tests pass: 64 tests in 2 files. - `leaves a newer empty link a navigation guard holds after a newer guard-held link superseded the lookup` (the reviewer's four-step race), `reports an empty link once when another navigation cancels its URL cleanup, and clears it later`, the tracker test `stashes an empty markEmpty value as a bare comma in place of a stale value`, and the `an error name cannot be read` row each failed before its fix. With both fixes, the tracker, loader, `useUrlActionLoaders` and `useWorkflowPersistenceV2` tests pass: 203 tests in 8 files. - Not run: the full unit suite, lint, typecheck beyond the pre-commit hook, and the browser tests. CI runs them.
…ames out of its error reports (#23245) (#23263) Backport of #23245 to `cloud/1.59`. The backport bot hit conflicts, so this copy was made by hand. `cloud/1.59` already has the first three of #23245's fixes, carried in #23239: a newer link held by a navigation guard is kept, a file read or parser error stays out of the report, and an empty `?workflowId=` is rejected. This copy adds the other three: - A report names the error's class only when it is a built-in JavaScript error (`Error`, `TypeError` and the rest). Any other name, or a name that throws when read, is reported as `other`. Custom node code can throw an error under any name. - Two different malformed links, such as `?workflowId=bad1` and `?workflowId=bad2`, count as different links. The cleanup for `bad1` no longer cancels a held navigation to `bad2`. - An empty `?workflowId=` saves a `,` marker in place of an older saved link, so an older lookup still sees a newer link while a guard holds the empty one. How the conflicts were resolved: - `src/composables/useWorkflowLinkUrlLoader.ts` and its test take `main`'s code after #23245 and keep `cloud/1.59`'s imports: `@/platform/telemetry`, `@/composables/useLinkedWorkflowUrlLoader`, the `@/platform/workspace` mocks, and the local `reportError` mock. The files stay in `src/composables`, where #23239 put them for `cloud/1.59`'s domain zones. - `src/platform/navigation/preservedQueryTracker.ts` takes `main`'s version, which adds the `markEmpty` flag `workflowId` sets. - `preservedQueryTracker.test.ts` adds #23245's `markEmpty` test and keeps `cloud/1.59`'s other tests, including the redirect round-trip test #23239 moved there. - The ADR takes `main`'s text, which describes all six rules and names no file path. No other change from #23245. The loader and its test differ from `main` only in the import lines. `fallow audit` on the change: no new findings. Not run locally: unit tests, lint, typecheck and the browser tests. CI runs them.
… on Comfy Cloud (#23051, #23245) (#23265) Backport of #23051 and #23245 to `cloud/1.60`. A `?workflowId=` link opens the saved workflow it names on Comfy Cloud (#23051). #23245 fixes six ways that loader goes wrong: a newer link held by sign-in was cancelled, a file read or parser error reached error reports with the user's file name, an empty `?workflowId=` stayed pending with no message, a custom node's error name reached reports, a newer malformed link was cancelled, and an empty link held by a guard could be cancelled. The backport bot hit conflicts on #23051, so this copy was made by hand, in three commits: - #23051, cherry-picked. `packages/ingest-types/src/types.gen.ts` and `zod.gen.ts` keep `cloud/1.60`'s generated files and add only the sidebar-file route lines #23051 added (the same 70 and 25 lines). Every other file applied cleanly. - #23245, cherry-picked with no conflicts. - One commit only on this branch, for `cloud/1.60`'s architecture check (`fallow`): the redirect round-trip test moved from `preservedQueryDefinitions.test.ts` to `preservedQueryTracker.test.ts`. The definitions test's zone may not import the query manager or tracker; the tracker test's zone may. #23239 made the same move on `cloud/1.59`. The test is unchanged. The loader, its test and the ADR are the same as on `main`. `cloud/1.60` has `main`'s package layout (`@comfyorg/telemetry`, the shared `reportError` mock), so none of #23239's other `cloud/1.59` changes were needed. No suppressions and no baseline edits. `fallow audit` on the change: no new findings. Not run locally: unit tests, lint, typecheck and the browser tests. CI runs them.
Backport of #23051 to
cloud/1.59.The backport bot hit conflicts, so this copy was made by hand:
packages/ingest-types/src/types.gen.tsandzod.gen.tskeepcloud/1.59's generated files and add only the sidebar-file route lines feat: Workflow-id links open the saved workflow on Comfy Cloud #23051 added (the same 70 and 25 lines).src/composables/useUrlActionLoaders.tskeepscloud/1.59's imports and adds the workflow-link loader.cloud/1.59's paths:@/platform/telemetryfor@comfyorg/telemetry,@/platform/workspace/composables/...for@/platform/account/composables/..., and@/typesfor@comfyorg/api-client/types.No other change from #23051.
Later commits on this branch
Also going to
mainin #23245:?workflowIdlink held by a navigation guard (sign-in, for example) is no longer cancelled and cleared by the cleanup for a link that already opened.?workflowId=opened while an older link's query is still saved in the tab is rejected and cleared, instead of staying pending with no message. An empty value now clears the saved value for the keys that take one value only (workflowId,workspace,deployment,workflows); a newer link held in a guard still lands.Only on this branch, for
cloud/1.59's architecture check (fallow), which failed on 36 imports across domain zones and one unused class member:cloud/1.59putssrc/platform/workflow/management/composablesin the workflow-management zone, which may not import telemetry, toast, i18n, navigation, workspace or the API client, and whichuseUrlActionLoadersanduseWorkflowPersistenceV2may not import. Onmainthat folder is not in a zone yet, so the same imports pass there. The workflow-id loader, the linked-workflow loader and their test moved tosrc/composables, beside the other URL loaders. The sweep of settled workflow-id params moved intosrc/composables/sweptWorkflowLinkParams.ts.preservedQueryDefinitions.test.tstopreservedQueryTracker.test.ts, whose zone may import the tracker.TelemetryRegistry.trackWorkflowLinkOpenedis called only through the provider interface, sofallowcounted it unused. A registry test now calls it and checks the dispatch. The event still fires.cloud/1.59has no shared mock forreportError, so the loader test mocks it. Without it, six tests that check a report failed.No suppressions and no baseline edits. Run locally: vitest on the loader test and on the test files the move and the fixes touched (121 passed in 6 files), and
fallow auditon the change (no new findings). Not run: the full unit suite and the browser tests.