Skip to content

[backport cloud/1.59] feat: Workflow-id links open the saved workflow on Comfy Cloud (#23051) - #23239

Merged
vqt123 merged 5 commits into
cloud/1.59from
backport-23051-to-cloud-1.59
Nov 10, 2026
Merged

vqt123 merged 5 commits into
cloud/1.59from
backport-23051-to-cloud-1.59

Conversation

@vqt123

@vqt123 vqt123 commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Backport of #23051 to cloud/1.59.

The backport bot hit conflicts, so this copy was made by hand:

  • packages/ingest-types/src/types.gen.ts and zod.gen.ts keep cloud/1.59's generated files and add only the sidebar-file route lines feat: Workflow-id links open the saved workflow on Comfy Cloud #23051 added (the same 70 and 25 lines).
  • src/composables/useUrlActionLoaders.ts keeps cloud/1.59's imports and adds the workflow-link loader.
  • The new files import cloud/1.59's paths: @/platform/telemetry for @comfyorg/telemetry, @/platform/workspace/composables/... for @/platform/account/composables/..., and @/types for @comfyorg/api-client/types.

No other change from #23051.

Later commits on this branch

Also going to main in #23245:

  • A newer ?workflowId link held by a navigation guard (sign-in, for example) is no longer cancelled and cleared by the cleanup for a link that already opened.
  • Error reports for a link no longer carry the file read or parser error, which named the user's workflow file.
  • An empty ?workflowId= opened while an older link's query is still saved in the tab is rejected and cleared, instead of staying pending with no message. An empty value now clears the saved value for the keys that take one value only (workflowId, workspace, deployment, workflows); a newer link held in a guard still lands.

Only on this branch, for cloud/1.59's architecture check (fallow), which failed on 36 imports across domain zones and one unused class member:

  • cloud/1.59 puts src/platform/workflow/management/composables in the workflow-management zone, which may not import telemetry, toast, i18n, navigation, workspace or the API client, and which useUrlActionLoaders and useWorkflowPersistenceV2 may not import. On main that folder is not in a zone yet, so the same imports pass there. The workflow-id loader, the linked-workflow loader and their test moved to src/composables, beside the other URL loaders. The sweep of settled workflow-id params moved into src/composables/sweptWorkflowLinkParams.ts.
  • The redirect round-trip test moved from preservedQueryDefinitions.test.ts to preservedQueryTracker.test.ts, whose zone may import the tracker.
  • TelemetryRegistry.trackWorkflowLinkOpened is called only through the provider interface, so fallow counted it unused. A registry test now calls it and checks the dispatch. The event still fires.
  • cloud/1.59 has no shared mock for reportError, so the loader test mocks it. Without it, six tests that check a report failed.

No suppressions and no baseline edits. Run locally: vitest on the loader test and on the test files the move and the fixes touched (121 passed in 6 files), and fallow audit on the change (no new findings). Not run: the full unit suite and the browser tests.

… on Comfy Cloud (#23051)

Backport of #23051 to cloud/1.59. Conflicts resolved by hand: the generated ingest-types files take cloud/1.59's copy plus the sidebar-file route lines #23051 added, and imports use cloud/1.59's paths (@/platform/telemetry, @/platform/workspace, @/types).

(cherry picked from commit fe18e38)
@vqt123
vqt123 requested a review from a team as a code owner November 10, 2026 21:37
@vqt123 vqt123 added the backport Backporting a PR onto a release candidate label Nov 10, 2026
@coderabbitai

coderabbitai Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords: 2

  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@github-actions

github-actions Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle: ⏳ Size data collection in progress…

⚡ Performance: ❌ 7 below 52 FPS target · ℹ️ No baseline — significance unavailable

❌ 7 scenarios below the ≥52 P5 FPS target. Expand the scenario timings below and profile the affected scenarios before merging.

Details
Scenario timings

canvas-idle: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 56.0 MB heap
canvas-mouse-sweep: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.7 MB heap
canvas-zoom-sweep: 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.0 MB heap
dom-widget-clipping: 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.9 MB heap
dom-widget-order-dense-n200-w200-i120: 29.6 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 506ms TBT · 82.9 MB heap
dom-widget-order-sparse-n1000-w20-i120: 40.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 213ms TBT · 67.3 MB heap
extension-clean-combined-draw: 31.4 avg FPS · 17.1 P5 FPS ❌ (target: ≥52) · 914ms TBT · 97.6 MB heap
extension-rgthree-prototype-draw: 31.9 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 840ms TBT · 98.8 MB heap
large-combo-open: 42.6 avg FPS · 10.9 P5 FPS ❌ (target: ≥52) · 5ms TBT · 65.7 MB heap
large-graph-idle: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.7 MB heap
large-graph-pan: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.7 MB heap
large-graph-zoom: 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.7 MB heap
legacy-node-drag: 59.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.6 MB heap
minimap-geometry-cadence: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.2 MB heap
minimap-idle: 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.7 MB heap
minimap-progress-execution-cadence: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.4 MB heap
minimap-topology-cadence: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.5 MB heap
subgraph-dom-widget-clipping: 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.5 MB heap
subgraph-idle: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.3 MB heap
subgraph-mouse-sweep: 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.3 MB heap
subgraph-transition-enter: 52.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 152ms TBT · 101.5 MB heap
viewport-pan-sweep: 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.8 MB heap
vue-large-graph-idle: 24.6 avg FPS · 12.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 251.3 MB heap
vue-large-graph-pan: 19.0 avg FPS · 8.6 P5 FPS ❌ (target: ≥52) · 16ms TBT · 246.2 MB heap
vue-node-resize-workload: 20.6 avg FPS · 10.0 P5 FPS ❌ (target: ≥52) · 28ms TBT · 248.0 MB heap
vue-zoom-out-idle: 23.3 avg FPS · 10.9 P5 FPS ❌ (target: ≥52) · 0ms TBT · 267.2 MB heap
workflow-execution: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.0 MB heap
agent-composer-empty-conversation-typing: 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 44.0 MB heap
agent-composer-long-conversation-typing: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 99.4 MB heap

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 2ms
canvas-idle: style recalc duration 2ms
canvas-idle: layout count 9
canvas-idle: style recalc count 9
canvas-idle: task duration 543ms
canvas-idle: script duration 9ms
canvas-idle: TBT 0ms
canvas-idle: heap used 56.0 MB
canvas-idle: DOM nodes -81
canvas-idle: event listeners -35
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 3ms
canvas-mouse-sweep: style recalc duration 13ms
canvas-mouse-sweep: layout count 9
canvas-mouse-sweep: style recalc count 75
canvas-mouse-sweep: task duration 921ms
canvas-mouse-sweep: script duration 162ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 69.7 MB
canvas-mouse-sweep: DOM nodes -81
canvas-mouse-sweep: event listeners -32
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 2ms
canvas-zoom-sweep: style recalc duration 5ms
canvas-zoom-sweep: layout count 10
canvas-zoom-sweep: style recalc count 20
canvas-zoom-sweep: task duration 401ms
canvas-zoom-sweep: script duration 10ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 64.0 MB
canvas-zoom-sweep: DOM nodes 56
canvas-zoom-sweep: event listeners 43
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 3ms
dom-widget-clipping: style recalc duration 3ms
dom-widget-clipping: layout count 10
dom-widget-clipping: style recalc count 15
dom-widget-clipping: task duration 492ms
dom-widget-clipping: script duration 172ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 65.9 MB
dom-widget-clipping: DOM nodes 0
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 34ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 816ms
dom-widget-order-dense-n200-w200-i120: script duration 64ms
dom-widget-order-dense-n200-w200-i120: TBT 506ms
dom-widget-order-dense-n200-w200-i120: heap used 82.9 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes 0
dom-widget-order-dense-n200-w200-i120: event listeners 0
dom-widget-order-sparse-n1000-w20-i120: avg frame time 25ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 478ms
dom-widget-order-sparse-n1000-w20-i120: script duration 150ms
dom-widget-order-sparse-n1000-w20-i120: TBT 213ms
dom-widget-order-sparse-n1000-w20-i120: heap used 67.3 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 32ms
extension-clean-combined-draw: p95 frame time 58ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 0ms
extension-clean-combined-draw: layout count 0
extension-clean-combined-draw: style recalc count 0
extension-clean-combined-draw: task duration 9708ms
extension-clean-combined-draw: script duration 7812ms
extension-clean-combined-draw: TBT 914ms
extension-clean-combined-draw: heap used 97.6 MB
extension-clean-combined-draw: DOM nodes -129
extension-clean-combined-draw: event listeners -35
extension-rgthree-prototype-draw: avg frame time 31ms
extension-rgthree-prototype-draw: p95 frame time 50ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 0ms
extension-rgthree-prototype-draw: layout count 0
extension-rgthree-prototype-draw: style recalc count 0
extension-rgthree-prototype-draw: task duration 9442ms
extension-rgthree-prototype-draw: script duration 7608ms
extension-rgthree-prototype-draw: TBT 840ms
extension-rgthree-prototype-draw: heap used 98.8 MB
extension-rgthree-prototype-draw: DOM nodes -129
extension-rgthree-prototype-draw: event listeners -35
large-combo-open: avg frame time 23ms
large-combo-open: p95 frame time 92ms
large-combo-open: layout duration 6ms
large-combo-open: style recalc duration 14ms
large-combo-open: layout count 11
large-combo-open: style recalc count 24
large-combo-open: task duration 215ms
large-combo-open: script duration 10ms
large-combo-open: TBT 5ms
large-combo-open: heap used 65.7 MB
large-combo-open: DOM nodes -2315
large-combo-open: event listeners -185
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 4ms
large-graph-idle: style recalc duration 2ms
large-graph-idle: layout count 8
large-graph-idle: style recalc count 8
large-graph-idle: task duration 576ms
large-graph-idle: script duration 35ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 66.7 MB
large-graph-idle: DOM nodes -257
large-graph-idle: event listeners -69
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 1ms
large-graph-pan: style recalc duration 8ms
large-graph-pan: layout count 5
large-graph-pan: style recalc count 67
large-graph-pan: task duration 1639ms
large-graph-pan: script duration 801ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 65.7 MB
large-graph-pan: DOM nodes -129
large-graph-pan: event listeners -33
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 9ms
large-graph-zoom: style recalc duration 8ms
large-graph-zoom: layout count 62
large-graph-zoom: style recalc count 69
large-graph-zoom: task duration 1692ms
large-graph-zoom: script duration 755ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 61.7 MB
large-graph-zoom: DOM nodes -105
large-graph-zoom: event listeners 0
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 1ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 5
legacy-node-drag: style recalc count 44
legacy-node-drag: task duration 1917ms
legacy-node-drag: script duration 962ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 81.6 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 182
minimap-geometry-cadence: avg frame time 17ms
minimap-geometry-cadence: p95 frame time 17ms
minimap-geometry-cadence: layout duration 2ms
minimap-geometry-cadence: style recalc duration 2ms
minimap-geometry-cadence: layout count 6
minimap-geometry-cadence: style recalc count 7
minimap-geometry-cadence: task duration 772ms
minimap-geometry-cadence: script duration 362ms
minimap-geometry-cadence: TBT 0ms
minimap-geometry-cadence: heap used 78.2 MB
minimap-geometry-cadence: DOM nodes -257
minimap-geometry-cadence: event listeners -69
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 1ms
minimap-idle: style recalc duration 1ms
minimap-idle: layout count 4
minimap-idle: style recalc count 5
minimap-idle: task duration 629ms
minimap-idle: script duration 32ms
minimap-idle: TBT 0ms
minimap-idle: heap used 69.7 MB
minimap-idle: DOM nodes -129
minimap-idle: event listeners -35
minimap-progress-execution-cadence: avg frame time 17ms
minimap-progress-execution-cadence: p95 frame time 17ms
minimap-progress-execution-cadence: layout duration 1ms
minimap-progress-execution-cadence: style recalc duration 11ms
minimap-progress-execution-cadence: layout count 5
minimap-progress-execution-cadence: style recalc count 24
minimap-progress-execution-cadence: task duration 569ms
minimap-progress-execution-cadence: script duration 185ms
minimap-progress-execution-cadence: TBT 0ms
minimap-progress-execution-cadence: heap used 66.4 MB
minimap-progress-execution-cadence: DOM nodes -117
minimap-progress-execution-cadence: event listeners -35
minimap-topology-cadence: avg frame time 17ms
minimap-topology-cadence: p95 frame time 17ms
minimap-topology-cadence: layout duration 0ms
minimap-topology-cadence: style recalc duration 0ms
minimap-topology-cadence: layout count 2
minimap-topology-cadence: style recalc count 2
minimap-topology-cadence: task duration 855ms
minimap-topology-cadence: script duration 355ms
minimap-topology-cadence: TBT 0ms
minimap-topology-cadence: heap used 62.5 MB
minimap-topology-cadence: DOM nodes 0
minimap-topology-cadence: event listeners 0
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 2ms
subgraph-dom-widget-clipping: style recalc duration 5ms
subgraph-dom-widget-clipping: layout count 10
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 433ms
subgraph-dom-widget-clipping: script duration 145ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 69.5 MB
subgraph-dom-widget-clipping: DOM nodes 0
subgraph-dom-widget-clipping: event listeners 46
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 3ms
subgraph-idle: style recalc duration 3ms
subgraph-idle: layout count 9
subgraph-idle: style recalc count 10
subgraph-idle: task duration 534ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 62.3 MB
subgraph-idle: DOM nodes -92
subgraph-idle: event listeners -58
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 3ms
subgraph-mouse-sweep: style recalc duration 13ms
subgraph-mouse-sweep: layout count 10
subgraph-mouse-sweep: style recalc count 76
subgraph-mouse-sweep: task duration 871ms
subgraph-mouse-sweep: script duration 109ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 64.3 MB
subgraph-mouse-sweep: DOM nodes -183
subgraph-mouse-sweep: event listeners -116
subgraph-transition-enter: avg frame time 19ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 16ms
subgraph-transition-enter: style recalc duration 22ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 1078ms
subgraph-transition-enter: script duration 29ms
subgraph-transition-enter: TBT 152ms
subgraph-transition-enter: heap used 101.5 MB
subgraph-transition-enter: DOM nodes 16030
subgraph-transition-enter: event listeners 3246
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 2ms
viewport-pan-sweep: style recalc duration 27ms
viewport-pan-sweep: layout count 7
viewport-pan-sweep: style recalc count 250
viewport-pan-sweep: task duration 5881ms
viewport-pan-sweep: script duration 2696ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 74.8 MB
viewport-pan-sweep: DOM nodes -257
viewport-pan-sweep: event listeners -65
vue-large-graph-idle: avg frame time 41ms
vue-large-graph-idle: p95 frame time 83ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 22817ms
vue-large-graph-idle: script duration 338ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 251.3 MB
vue-large-graph-idle: DOM nodes -3343
vue-large-graph-idle: event listeners -659
vue-large-graph-pan: avg frame time 53ms
vue-large-graph-pan: p95 frame time 117ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 19ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 181
vue-large-graph-pan: task duration 28017ms
vue-large-graph-pan: script duration 880ms
vue-large-graph-pan: TBT 16ms
vue-large-graph-pan: heap used 246.2 MB
vue-large-graph-pan: DOM nodes -3343
vue-large-graph-pan: event listeners -651
vue-node-resize-workload: avg frame time 49ms
vue-node-resize-workload: p95 frame time 100ms
vue-node-resize-workload: layout duration 27ms
vue-node-resize-workload: style recalc duration 74ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 8364ms
vue-node-resize-workload: script duration 144ms
vue-node-resize-workload: TBT 28ms
vue-node-resize-workload: heap used 248.0 MB
vue-node-resize-workload: DOM nodes -3358
vue-node-resize-workload: event listeners -653
vue-zoom-out-idle: avg frame time 43ms
vue-zoom-out-idle: p95 frame time 92ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 11798ms
vue-zoom-out-idle: script duration 162ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 267.2 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners 0
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 4ms
workflow-execution: style recalc duration 10ms
workflow-execution: layout count 10
workflow-execution: style recalc count 13
workflow-execution: task duration 118ms
workflow-execution: script duration 11ms
workflow-execution: TBT 0ms
workflow-execution: heap used 66.0 MB
workflow-execution: DOM nodes 129
workflow-execution: event listeners 6
agent-composer-empty-conversation-typing: avg frame time 17ms
agent-composer-empty-conversation-typing: p95 frame time 17ms
agent-composer-empty-conversation-typing: layout duration 17ms
agent-composer-empty-conversation-typing: style recalc duration 1ms
agent-composer-empty-conversation-typing: layout count 76
agent-composer-empty-conversation-typing: style recalc count 5
agent-composer-empty-conversation-typing: task duration 567ms
agent-composer-empty-conversation-typing: script duration 277ms
agent-composer-empty-conversation-typing: TBT 0ms
agent-composer-empty-conversation-typing: heap used 44.0 MB
agent-composer-empty-conversation-typing: DOM nodes 4
agent-composer-empty-conversation-typing: event listeners 292
agent-composer-long-conversation-typing: avg frame time 17ms
agent-composer-long-conversation-typing: p95 frame time 17ms
agent-composer-long-conversation-typing: layout duration 15ms
agent-composer-long-conversation-typing: style recalc duration 2ms
agent-composer-long-conversation-typing: layout count 76
agent-composer-long-conversation-typing: style recalc count 5
agent-composer-long-conversation-typing: task duration 563ms
agent-composer-long-conversation-typing: script duration 223ms
agent-composer-long-conversation-typing: TBT 0ms
agent-composer-long-conversation-typing: heap used 99.4 MB
agent-composer-long-conversation-typing: DOM nodes 4
agent-composer-long-conversation-typing: event listeners 296
Raw data
{
  "timestamp": "2026-11-10T22:41:27.805Z",
  "gitSha": "0a87f1ef4b34f88a66b9545b11f9d7ddb68b07b4",
  "branch": "backport-23051-to-cloud-1.59",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2006.8729999999846,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 2.301,
      "layouts": 9,
      "layoutDurationMs": 2.326,
      "taskDurationMs": 513.5730000000001,
      "heapDeltaBytes": 4381296,
      "heapUsedBytes": 66755612,
      "domNodes": 0,
      "jsHeapTotalBytes": 8126464,
      "scriptDurationMs": 8.028,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66611570247934,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2040.1879999999437,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 2.4430000000000005,
      "layouts": 8,
      "layoutDurationMs": 2.5189999999999997,
      "taskDurationMs": 572.3979999999999,
      "heapDeltaBytes": -10682448,
      "heapUsedBytes": 50714416,
      "domNodes": -161,
      "jsHeapTotalBytes": 10485760,
      "scriptDurationMs": 9.498,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6655737704918,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1775.5089999999996,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 12.083,
      "layouts": 9,
      "layoutDurationMs": 2.5980000000000003,
      "taskDurationMs": 918.554,
      "heapDeltaBytes": -10912520,
      "heapUsedBytes": 62039000,
      "domNodes": -161,
      "jsHeapTotalBytes": 10747904,
      "scriptDurationMs": 157.26500000000001,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665094339622645,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1860.2470000000721,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 13.597999999999999,
      "layouts": 9,
      "layoutDurationMs": 2.8089999999999997,
      "taskDurationMs": 922.782,
      "heapDeltaBytes": 22006180,
      "heapUsedBytes": 84094188,
      "domNodes": 0,
      "jsHeapTotalBytes": 7602176,
      "scriptDurationMs": 167.487,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665178571428573,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1722.1099999999865,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 4.819,
      "layouts": 9,
      "layoutDurationMs": 2.64,
      "taskDurationMs": 400.811,
      "heapDeltaBytes": 1057516,
      "heapUsedBytes": 62194772,
      "domNodes": 56,
      "jsHeapTotalBytes": 9699328,
      "scriptDurationMs": 10.134,
      "eventListeners": 43,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66601941747573,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1706.0339999999314,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 4.287000000000001,
      "layouts": 10,
      "layoutDurationMs": 2.282,
      "taskDurationMs": 400.578,
      "heapDeltaBytes": 1681548,
      "heapUsedBytes": 72019328,
      "domNodes": 56,
      "jsHeapTotalBytes": 10485760,
      "scriptDurationMs": 9.629999999999999,
      "eventListeners": 43,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 665.7749999999965,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 2.858,
      "layouts": 10,
      "layoutDurationMs": 2.469,
      "taskDurationMs": 480.96000000000004,
      "heapDeltaBytes": 6542036,
      "heapUsedBytes": 77595776,
      "domNodes": 0,
      "jsHeapTotalBytes": 10747904,
      "scriptDurationMs": 169.535,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 693.7249999999722,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 3.158,
      "layouts": 10,
      "layoutDurationMs": 2.851,
      "taskDurationMs": 503.965,
      "heapDeltaBytes": 654660,
      "heapUsedBytes": 60570264,
      "domNodes": 0,
      "jsHeapTotalBytes": 3407872,
      "scriptDurationMs": 173.674,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66585365853658,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1130.156999999997,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 806.0299999999999,
      "heapDeltaBytes": 18281716,
      "heapUsedBytes": 85541016,
      "domNodes": 0,
      "jsHeapTotalBytes": 9076736,
      "scriptDurationMs": 63.58700000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 503,
      "frameDurationMs": 33.332352941176474,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1132.7420000000075,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 826.355,
      "heapDeltaBytes": 17658724,
      "heapUsedBytes": 88317444,
      "domNodes": 0,
      "jsHeapTotalBytes": 11698176,
      "scriptDurationMs": 64.33100000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 509,
      "frameDurationMs": 34.339393939393936,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 841.7909999999722,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 478.58299999999997,
      "heapDeltaBytes": -4997728,
      "heapUsedBytes": 70676828,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 149.928,
      "eventListeners": 0,
      "totalBlockingTimeMs": 215,
      "frameDurationMs": 25,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 843.7099999999873,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 476.6469999999998,
      "heapDeltaBytes": -4567828,
      "heapUsedBytes": 70544904,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 150.428,
      "eventListeners": 0,
      "totalBlockingTimeMs": 210,
      "frameDurationMs": 24.9970588235294,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 10886.515000000003,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9956.884,
      "heapDeltaBytes": -11513716,
      "heapUsedBytes": 67116128,
      "domNodes": 0,
      "jsHeapTotalBytes": 2359296,
      "scriptDurationMs": 8062.901,
      "eventListeners": 0,
      "totalBlockingTimeMs": 1081,
      "frameDurationMs": 31.728571428571428,
      "p95FrameDurationMs": 66.59999999999854
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 10229.007000000023,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9459.525,
      "heapDeltaBytes": 63542152,
      "heapUsedBytes": 137579484,
      "domNodes": -257,
      "jsHeapTotalBytes": 71430144,
      "scriptDurationMs": 7561.476,
      "eventListeners": -69,
      "totalBlockingTimeMs": 746,
      "frameDurationMs": 31.925625000000004,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 10555.409999999994,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9831.609,
      "heapDeltaBytes": 41196,
      "heapUsedBytes": 80606888,
      "domNodes": 0,
      "jsHeapTotalBytes": 3932160,
      "scriptDurationMs": 8008.963999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 978,
      "frameDurationMs": 31.49134328358209,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 9847.433000000023,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9051.714,
      "heapDeltaBytes": 53114976,
      "heapUsedBytes": 126574788,
      "domNodes": -257,
      "jsHeapTotalBytes": 60157952,
      "scriptDurationMs": 7207.945,
      "eventListeners": -69,
      "totalBlockingTimeMs": 701,
      "frameDurationMs": 31.169936708860757,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "large-combo-open",
      "durationMs": 283.190999999988,
      "styleRecalcs": 25,
      "styleRecalcDurationMs": 15.034000000000002,
      "layouts": 13,
      "layoutDurationMs": 8.652,
      "taskDurationMs": 249.487,
      "heapDeltaBytes": -16557188,
      "heapUsedBytes": 66606348,
      "domNodes": -2315,
      "jsHeapTotalBytes": 1048576,
      "scriptDurationMs": 9.713999999999999,
      "eventListeners": -574,
      "totalBlockingTimeMs": 6,
      "frameDurationMs": 23.60833333333331,
      "p95FrameDurationMs": 100
    },
    {
      "name": "large-combo-open",
      "durationMs": 235.41999999997643,
      "styleRecalcs": 23,
      "styleRecalcDurationMs": 12.626,
      "layouts": 9,
      "layoutDurationMs": 2.8870000000000005,
      "taskDurationMs": 179.78900000000004,
      "heapDeltaBytes": 14676100,
      "heapUsedBytes": 71213536,
      "domNodes": -2315,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 9.991999999999999,
      "eventListeners": 205,
      "totalBlockingTimeMs": 4,
      "frameDurationMs": 23.339999999999964,
      "p95FrameDurationMs": 83.30000000000018
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2060.280999999975,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 2.1599999999999997,
      "layouts": 8,
      "layoutDurationMs": 2.2560000000000002,
      "taskDurationMs": 456.88000000000005,
      "heapDeltaBytes": -12068860,
      "heapUsedBytes": 70180384,
      "domNodes": -257,
      "jsHeapTotalBytes": -659456,
      "scriptDurationMs": 30.645000000000007,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665853658536584,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2065.270000000055,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 2.66,
      "layouts": 7,
      "layoutDurationMs": 5.468,
      "taskDurationMs": 695.639,
      "heapDeltaBytes": -12913360,
      "heapUsedBytes": 69622828,
      "domNodes": -257,
      "jsHeapTotalBytes": -397312,
      "scriptDurationMs": 40.214999999999996,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66666666666667,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2424.851999999987,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 8.013,
      "layouts": 6,
      "layoutDurationMs": 1.626,
      "taskDurationMs": 1658.217,
      "heapDeltaBytes": -18740380,
      "heapUsedBytes": 61418468,
      "domNodes": -257,
      "jsHeapTotalBytes": 913408,
      "scriptDurationMs": 801.873,
      "eventListeners": -67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666438356164385,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2433.836999999926,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 7.380999999999999,
      "layouts": 4,
      "layoutDurationMs": 0.719,
      "taskDurationMs": 1620.5909999999997,
      "heapDeltaBytes": 15553148,
      "heapUsedBytes": 76375544,
      "domNodes": 0,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 799.903,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665753424657535,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3593.4330000000045,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 8.191,
      "layouts": 62,
      "layoutDurationMs": 9.631,
      "taskDurationMs": 1689.2559999999999,
      "heapDeltaBytes": 1636748,
      "heapUsedBytes": 62582160,
      "domNodes": -233,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 753.437,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666046511627908,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3523.6700000000383,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 7.921999999999999,
      "layouts": 62,
      "layoutDurationMs": 8.962000000000002,
      "taskDurationMs": 1695.2969999999998,
      "heapDeltaBytes": 4570052,
      "heapUsedBytes": 66772152,
      "domNodes": 24,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 757.356,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665876777251185,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2885.5239999999753,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 4.635,
      "layouts": 5,
      "layoutDurationMs": 1.1620000000000004,
      "taskDurationMs": 1902.1540000000002,
      "heapDeltaBytes": 16779460,
      "heapUsedBytes": 97699104,
      "domNodes": 0,
      "jsHeapTotalBytes": 5922816,
      "scriptDurationMs": 954.678,
      "eventListeners": 182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.860818713450293,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2932.9910000000154,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 4.425999999999999,
      "layouts": 5,
      "layoutDurationMs": 1.2100000000000002,
      "taskDurationMs": 1932.5649999999998,
      "heapDeltaBytes": -9115128,
      "heapUsedBytes": 73396768,
      "domNodes": 0,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 970.2360000000001,
      "eventListeners": 182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.858045977011496,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-geometry-cadence",
      "durationMs": 3063.1799999999885,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 1.4969999999999992,
      "layouts": 6,
      "layoutDurationMs": 1.5989999999999998,
      "taskDurationMs": 749.9840000000002,
      "heapDeltaBytes": -1692088,
      "heapUsedBytes": 81733528,
      "domNodes": -257,
      "jsHeapTotalBytes": 1961984,
      "scriptDurationMs": 346.294,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666304347826088,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "minimap-geometry-cadence",
      "durationMs": 3082.0750000000317,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 2.503999999999999,
      "layouts": 6,
      "layoutDurationMs": 1.5790000000000002,
      "taskDurationMs": 794.8820000000001,
      "heapDeltaBytes": -266148,
      "heapUsedBytes": 82306660,
      "domNodes": -257,
      "jsHeapTotalBytes": 651264,
      "scriptDurationMs": 377.01,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66576086956522,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2021.19399999998,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 0.5200000000000005,
      "layouts": 2,
      "layoutDurationMs": 0.49299999999999994,
      "taskDurationMs": 594.7489999999999,
      "heapDeltaBytes": 10606840,
      "heapUsedBytes": 72215372,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 31.135999999999996,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "minimap-idle",
      "durationMs": 2028.0370000000403,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 1.8349999999999997,
      "layouts": 6,
      "layoutDurationMs": 1.768,
      "taskDurationMs": 662.6860000000001,
      "heapDeltaBytes": -5284308,
      "heapUsedBytes": 74043020,
      "domNodes": -257,
      "jsHeapTotalBytes": 3534848,
      "scriptDurationMs": 32.17099999999999,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66639344262295,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-progress-execution-cadence",
      "durationMs": 2753.0280000000002,
      "styleRecalcs": 25,
      "styleRecalcDurationMs": 11.900999999999998,
      "layouts": 6,
      "layoutDurationMs": 1.7380000000000004,
      "taskDurationMs": 600.6389999999999,
      "heapDeltaBytes": -2435944,
      "heapUsedBytes": 75820392,
      "domNodes": -253,
      "jsHeapTotalBytes": 4059136,
      "scriptDurationMs": 190.26700000000002,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666060606060604,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-progress-execution-cadence",
      "durationMs": 2763.8529999999832,
      "styleRecalcs": 22,
      "styleRecalcDurationMs": 10.270999999999999,
      "layouts": 3,
      "layoutDurationMs": 0.826,
      "taskDurationMs": 537.806,
      "heapDeltaBytes": 674132,
      "heapUsedBytes": 63414284,
      "domNodes": 19,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 180.67300000000003,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66566265060241,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-topology-cadence",
      "durationMs": 3189.2740000000117,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 0.46200000000000063,
      "layouts": 2,
      "layoutDurationMs": 0.43199999999999966,
      "taskDurationMs": 838.8930000000001,
      "heapDeltaBytes": 3073640,
      "heapUsedBytes": 64814404,
      "domNodes": 0,
      "jsHeapTotalBytes": 1572864,
      "scriptDurationMs": 345.873,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665968586387436,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "minimap-topology-cadence",
      "durationMs": 3218.028000000004,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 0.503,
      "layouts": 2,
      "layoutDurationMs": 0.4639999999999996,
      "taskDurationMs": 870.772,
      "heapDeltaBytes": 4202240,
      "heapUsedBytes": 66336396,
      "domNodes": 0,
      "jsHeapTotalBytes": 1572864,
      "scriptDurationMs": 364.298,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66580310880829,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 598.2369999999833,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 4.837999999999999,
      "layouts": 9,
      "layoutDurationMs": 2.233,
      "taskDurationMs": 439.425,
      "heapDeltaBytes": 1026416,
      "heapUsedBytes": 62932524,
      "domNodes": 0,
      "jsHeapTotalBytes": 10223616,
      "scriptDurationMs": 146.318,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663888888888877,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 607.2769999999537,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 4.939,
      "layouts": 11,
      "layoutDurationMs": 2.745,
      "taskDurationMs": 426.458,
      "heapDeltaBytes": 21088536,
      "heapUsedBytes": 82853252,
      "domNodes": 0,
      "jsHeapTotalBytes": 3932160,
      "scriptDurationMs": 144.468,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2038.6780000000044,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 2.3369999999999997,
      "layouts": 9,
      "layoutDurationMs": 2.519,
      "taskDurationMs": 544.896,
      "heapDeltaBytes": 2724748,
      "heapUsedBytes": 64885624,
      "domNodes": -183,
      "jsHeapTotalBytes": 3145728,
      "scriptDurationMs": 7.289000000000001,
      "eventListeners": -116,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666393442622947,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2022.1010000000206,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 2.893,
      "layouts": 9,
      "layoutDurationMs": 2.937,
      "taskDurationMs": 522.7270000000001,
      "heapDeltaBytes": 2564596,
      "heapUsedBytes": 65824740,
      "domNodes": 0,
      "jsHeapTotalBytes": 7077888,
      "scriptDurationMs": 8.232000000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665289256198346,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1718.2300000000055,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 12.378,
      "layouts": 10,
      "layoutDurationMs": 2.6079999999999997,
      "taskDurationMs": 831.725,
      "heapDeltaBytes": 13616856,
      "heapUsedBytes": 74269548,
      "domNodes": -183,
      "jsHeapTotalBytes": 4194304,
      "scriptDurationMs": 103.962,
      "eventListeners": -116,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666019417475724,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1709.0160000000196,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 14.152999999999999,
      "layouts": 9,
      "layoutDurationMs": 3.147,
      "taskDurationMs": 910.71,
      "heapDeltaBytes": -14628484,
      "heapUsedBytes": 60607532,
      "domNodes": -183,
      "jsHeapTotalBytes": 11010048,
      "scriptDurationMs": 113.138,
      "eventListeners": -116,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666019417475727,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1485.492000000022,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 22.037000000000003,
      "layouts": 5,
      "layoutDurationMs": 16.191999999999997,
      "taskDurationMs": 1077.743,
      "heapDeltaBytes": 11503780,
      "heapUsedBytes": 106402016,
      "domNodes": 16030,
      "jsHeapTotalBytes": 16916480,
      "scriptDurationMs": 29.061000000000003,
      "eventListeners": 3246,
      "totalBlockingTimeMs": 152,
      "frameDurationMs": 19.229487179487187,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9283.231999999998,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 26.019000000000002,
      "layouts": 5,
      "layoutDurationMs": 1.081,
      "taskDurationMs": 5884.319,
      "heapDeltaBytes": 15807768,
      "heapUsedBytes": 75947792,
      "domNodes": -257,
      "jsHeapTotalBytes": 192512,
      "scriptDurationMs": 2684.008,
      "eventListeners": -63,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665888689407538,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9056.084000000055,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 27.544,
      "layouts": 8,
      "layoutDurationMs": 2.353999999999999,
      "taskDurationMs": 5876.9800000000005,
      "heapDeltaBytes": 935712,
      "heapUsedBytes": 81004884,
      "domNodes": -257,
      "jsHeapTotalBytes": 876544,
      "scriptDurationMs": 2707.134,
      "eventListeners": -67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66611418047882,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 23283.026000000005,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22470.625000000004,
      "heapDeltaBytes": -30755604,
      "heapUsedBytes": 266034868,
      "domNodes": -3343,
      "jsHeapTotalBytes": 9687040,
      "scriptDurationMs": 354.16600000000005,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 40.0041237113402,
      "p95FrameDurationMs": 83.39999999999964
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 23761.990999999965,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 23164.239999999998,
      "heapDeltaBytes": -36640792,
      "heapUsedBytes": 261032240,
      "domNodes": -3343,
      "jsHeapTotalBytes": 4444160,
      "scriptDurationMs": 321.483,
      "eventListeners": -664,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 41.25972222222222,
      "p95FrameDurationMs": 83.40000000000146
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 28088.932,
      "styleRecalcs": 181,
      "styleRecalcDurationMs": 17.58900000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 27718.487,
      "heapDeltaBytes": 18084668,
      "heapUsedBytes": 267327520,
      "domNodes": -3343,
      "jsHeapTotalBytes": 8912896,
      "scriptDurationMs": 860.8739999999999,
      "eventListeners": -651,
      "totalBlockingTimeMs": 14,
      "frameDurationMs": 51.77790055248619,
      "p95FrameDurationMs": 116.60000000000218
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 28675.86599999993,
      "styleRecalcs": 181,
      "styleRecalcDurationMs": 19.696999999999992,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 28314.686,
      "heapDeltaBytes": -53961444,
      "heapUsedBytes": 248976444,
      "domNodes": -3343,
      "jsHeapTotalBytes": 6279168,
      "scriptDurationMs": 899.045,
      "eventListeners": -651,
      "totalBlockingTimeMs": 17,
      "frameDurationMs": 53.67716981132075,
      "p95FrameDurationMs": 116.60000000000218
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 8424.585000000036,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 80.52500000000002,
      "layouts": 20,
      "layoutDurationMs": 28.543999999999986,
      "taskDurationMs": 8256.061000000002,
      "heapDeltaBytes": -32285224,
      "heapUsedBytes": 264909048,
      "domNodes": -3372,
      "jsHeapTotalBytes": 9424896,
      "scriptDurationMs": 160.022,
      "eventListeners": -653,
      "totalBlockingTimeMs": 56,
      "frameDurationMs": 47.91477272727274,
      "p95FrameDurationMs": 100
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 8589.843999999972,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 67.66899999999998,
      "layouts": 20,
      "layoutDurationMs": 25.516999999999985,
      "taskDurationMs": 8471.623,
      "heapDeltaBytes": -19203000,
      "heapUsedBytes": 255265896,
      "domNodes": -3343,
      "jsHeapTotalBytes": 19386368,
      "scriptDurationMs": 127.48700000000002,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 49.14057142857142,
      "p95FrameDurationMs": 100
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 11769.649000000016,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11386.972,
      "heapDeltaBytes": 36344804,
      "heapUsedBytes": 283811008,
      "domNodes": 0,
      "jsHeapTotalBytes": -14942208,
      "scriptDurationMs": 150.70600000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 40.713494809688584,
      "p95FrameDurationMs": 83.39999999999782
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 12592.518999999924,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12208.91,
      "heapDeltaBytes": -1824920,
      "heapUsedBytes": 276623348,
      "domNodes": 0,
      "jsHeapTotalBytes": -5767168,
      "scriptDurationMs": 172.92199999999997,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 44.99857142857144,
      "p95FrameDurationMs": 100
    },
    {
      "name": "workflow-execution",
      "durationMs": 485.1239999999848,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 9.785,
      "layouts": 11,
      "layoutDurationMs": 4.129,
      "taskDurationMs": 141.19400000000002,
      "heapDeltaBytes": -10666568,
      "heapUsedBytes": 63482180,
      "domNodes": 132,
      "jsHeapTotalBytes": 7864320,
      "scriptDurationMs": 14.097000000000001,
      "eventListeners": 7,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "workflow-execution",
      "durationMs": 132.59500000003754,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 10.158000000000001,
      "layouts": 9,
      "layoutDurationMs": 4.1370000000000005,
      "taskDurationMs": 94.93299999999999,
      "heapDeltaBytes": 4664860,
      "heapUsedBytes": 75015724,
      "domNodes": 125,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 7.97,
      "eventListeners": 5,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.674999999999955,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 646.1360000000695,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 0.6579999999999999,
      "layouts": 76,
      "layoutDurationMs": 17.291,
      "taskDurationMs": 608.047,
      "heapDeltaBytes": -1362392,
      "heapUsedBytes": 46472364,
      "domNodes": 4,
      "jsHeapTotalBytes": 1572864,
      "scriptDurationMs": 298.197,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66500000000001,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 579.947000000061,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 0.664,
      "layouts": 76,
      "layoutDurationMs": 16.267,
      "taskDurationMs": 526.269,
      "heapDeltaBytes": -2332236,
      "heapUsedBytes": 45768668,
      "domNodes": 4,
      "jsHeapTotalBytes": 2359296,
      "scriptDurationMs": 255.88499999999996,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66285714285714,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 616.5889999999763,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 2.939,
      "layouts": 76,
      "layoutDurationMs": 15.626000000000001,
      "taskDurationMs": 579.6809999999999,
      "heapDeltaBytes": 1147752,
      "heapUsedBytes": 103995244,
      "domNodes": 4,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 228.64100000000002,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.667567567567563,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 574.5149999999057,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 1.821,
      "layouts": 76,
      "layoutDurationMs": 14.447,
      "taskDurationMs": 545.716,
      "heapDeltaBytes": 1093316,
      "heapUsedBytes": 104489272,
      "domNodes": 4,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 218.203,
      "eventListeners": 300,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665714285714266,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🎭 Playwright: ✅ 3153 passed, 0 failed · 4 flaky

📊 Browser Reports
  • chromium: View Report (✅ 2330 / ❌ 0 / ⚠️ 3 / ⏭️ 0)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • cloud: View Report (✅ 792 / ❌ 0 / ⚠️ 1 / ⏭️ 0)
  • desktop: View Report (✅ 6 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 19 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-safari: View Report (✅ 3 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 11/10/2026, 10:30:14 PM UTC

Links

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

No verdict is available. Open the workflow run to confirm the check was intentionally skipped, or fix the collection failure and re-run it.

Findings and check details

The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

Findings and check details

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 8157722c9732bf9243a6f4d74d27380ed0dbbca4

Full docs: ADR-DEVEX-LINT-0015

🏛️ Architecture: ✅ Passed

Findings and check details

Warnings (324)

  • workspace path matches no source files: src/platform/workspace/fixtures/**. Remove or update it in docs/architecture/domains/records/workspace.domain.json.
  • src/components/graph/selectionToolbox/LinkSelectionActions.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/searchbox/v2/filterChip.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/Popover.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.stories.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardFooter.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardHeader.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/card.variants.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/graph/menuOption.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/sweptWorkflowLinkParams.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useLinkedWorkflowUrlLoader.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useLiveGraphNode.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useLiveGraphNode.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWorkflowLinkUrlLoader.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWorkflowLinkUrlLoader.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/litegraphServiceAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/nodeDef/ComfyNodeDefImpl.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupEnforcementBoundary.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/syncPromotedComboHostOptions.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/legacyUI/attachLegacyUI.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/selection/selectionIntent.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/agentPanel.historyIdentity.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/cloudBadges.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/dynamicPrompts.serializeValue.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/electronAdapter.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/index.cloud.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/index.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/cameraInfo.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/findNumericWidget.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dHost.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dHost.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dInstances.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dLazy.retry.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dSettings.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dWidgets.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dWidgets.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/reportLoadModelOutcome.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/reportLoadModelOutcome.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/slotDefaults.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/touchCanvasAccess.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/touchCanvasAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • …and 274 more
Reproduce locally
pnpm architecture:check

Full docs: Frontend domain catalog

@codecov

codecov Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 99.11894% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ersistence/composables/useWorkflowPersistenceV2.ts 88.23% 2 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.59   #23239   +/-   ##
=============================================
  Coverage              ?   86.91%           
=============================================
  Files                 ?     2844           
  Lines                 ?   144819           
  Branches              ?    42042           
=============================================
  Hits                  ?   125872           
  Misses                ?    17963           
  Partials              ?      984           
Flag Coverage Δ
billing-web-unit 92.14% <ø> (?)
unit 86.79% <99.11%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/composables/sweptWorkflowLinkParams.ts 100.00% <100.00%> (ø)
src/composables/useLinkedWorkflowUrlLoader.ts 100.00% <100.00%> (ø)
src/composables/useUrlActionLoaders.ts 100.00% <100.00%> (ø)
src/composables/useWorkflowLinkUrlLoader.ts 100.00% <100.00%> (ø)
...c/platform/navigation/preservedQueryDefinitions.ts 100.00% <ø> (ø)
...rc/platform/navigation/preservedQueryNamespaces.ts 100.00% <ø> (ø)
src/platform/navigation/preservedQueryTracker.ts 100.00% <100.00%> (ø)
src/platform/telemetry/TelemetryRegistry.ts 55.50% <100.00%> (ø)
...emetry/providers/cloud/PostHogTelemetryProvider.ts 76.45% <100.00%> (ø)
src/platform/telemetry/types.ts 100.00% <ø> (ø)
... and 1 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-official

This comment has been minimized.

@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Nov 10, 2026
cloud/1.59 classifies src/platform/workflow/management/composables as
workflow-management, whose zone may not import telemetry, toast, i18n,
navigation, workspace or the API client, and which app-host and
workflow-persistence may not import. Move the workflow-id loader, its
test and the linked-workflow loader to unclassified src/composables,
where the other cross-domain URL loaders already live, and move the
settled-link sweep out of useUrlActionLoaders so its navigation import
stays as the base has it.

Move the redirect round-trip test to preservedQueryTracker.test.ts,
whose zone may import the tracker and manager, and cover the
registry's trackWorkflowLinkOpened dispatch. Behavior is unchanged.

@dante01yoon dante01yoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as a backport of #23051 to cloud/1.59, per the backport review policy. Tests were not run; CI is still in progress.

@dante01yoon dante01yoon assigned vqt123 and unassigned dante01yoon Nov 10, 2026
A navigation guard can hold a newer ?workflowId while the URL still shows
the link that just opened. The URL-action pass then cleaned up for the
opened link: its router.replace cancelled the held navigation and the
cleanup cleared the newer link's stash, so the newer link was lost.

Ownership of the URL and the stash now belongs to the link being
handled. When the URL and the stash name different links, the loader
treats the stash as a navigation still in flight and leaves both alone,
even for a link it already opened.

The loader tests now run on a real memory router with the preserved-query
tracker, and hold navigations in real guards instead of faking
cancellation through a replace mock.

On cloud/1.59 reportError has no shared mock, so the test file mocks
it; without that, the six tests that assert a report failed.
When the sidebar-file lookup succeeded but reading the linked file
failed, the loader reported the read error as the cause of its own
error. That error names the file ("Failed to load file
'workflows/<name>.json': 500 ..."), and the error sinks keep a nested
cause, so a user's workflow file name reached error reporting. A lookup
reply that was not JSON did the same with the parser's message, which
quotes the reply.

The loader now reports a fixed message with the error's class name as
context, and never the caught error itself.
@vqt123

vqt123 commented Nov 10, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @dante01yoon. Two commits landed after your approval, the same two fixes as #23245 on main:

  • 76d5c6909d: when a second workflow link is opened while the first is still loading, the first link's URL cleanup no longer cancels the second.
  • 8277e08f27: when opening a linked workflow fails, the error report no longer carries the workflow's file name or the raw error text.

Each has a test that failed before the fix. The full list is at the end of the PR body.

Opening /?workflowId= while the session still held an earlier workflow id
left that id saved: an empty value was not worth capturing, so the capture
kept the old one. The loader then read the saved id as a newer navigation
in flight and returned pending without reporting the empty link or clearing
it, on every reload.

For namespaces that mark ambiguous values (rejectRepeated), a key present
with an empty value now clears the saved value when the router captures
it. The empty link is rejected as invalid, reported, and cleared from the
URL and the stash, as before. A newer link a navigation guard holds is
still captured after the empty one, so it keeps its protection.
@vqt123
vqt123 enabled auto-merge (squash) November 10, 2026 22:29
@vqt123

vqt123 commented Nov 10, 2026

Copy link
Copy Markdown
Contributor Author

@dante01yoon one more commit after your approval, also going to main in #23245:

  • dc7cf6bce7: an empty ?workflowId= opened while an older link's query is still saved in the tab is now rejected and cleared, instead of staying pending with no message.

Its tests failed before the fix. Auto-merge is on for this head.

@vqt123
vqt123 merged commit 24cad5c into cloud/1.59 Nov 10, 2026
112 checks passed
@vqt123
vqt123 deleted the backport-23051-to-cloud-1.59 branch November 10, 2026 22:47
xeinherjer-dev pushed a commit to xeinherjer-dev/ComfyUI_frontend that referenced this pull request Nov 11, 2026
…reports (Comfy-Org#23245)

## Summary

Six fixes to workflow-id links (Comfy-Org#23051).

**A newer link could be lost.** You open a `?workflowId=` link and it
opens. Before its URL cleanup finishes, the browser goes to a second
`?workflowId=` link, and a navigation guard (sign-in, for example) holds
it. Then the URL actions run after boot and clean up for the first link
again. That cleanup cancelled the held navigation and cleared its saved
query, so the second link never opened. Now, when the URL and the saved
query name different links, the loader treats the saved one as a
navigation still in flight. It makes no replace and clears neither, even
for a link it already opened.

**A file name could reach error reports.** The lookup finds the linked
file, but reading the file fails (a 500, or the file was deleted in
between). The read error says `Failed to load file
'workflows/<name>.json'`, and the loader passed it on as the cause of
its own report. The error sinks keep nested causes, so the user's file
name reached them. A lookup reply that was not JSON did the same with
the parser message, which quotes the reply. Now the loader reports a
fixed message with the error's class name only.

**An empty link could stay stuck.** A tab still holds the saved query
from an earlier link that has not finished (a sign-in, for example). You
then open `?workflowId=` with no value. The empty value did not replace
the saved one, so the loader saw two different links, treated the old
one as a navigation in flight and stayed pending: no error message, and
nothing cleared. Now an empty `workflowId` saves a `,` marker in place
of the older link. While a guard holds the empty link, an older lookup
still sees a newer link and stays pending, so its cleanup cannot cancel
that navigation or drop its other URL actions. Once the empty link
lands, the loader treats `''` and the marker as the same link: it is
rejected as invalid, reported once, and cleared. For `workspace`,
`deployment` and `workflows`, an empty URL value clears the stale saved
value at capture; their loaders already treat an empty value as no
value.

**Custom node code could put its own text in error reports.** Loading a
workflow runs custom node code, such as a widget's `computeSize`. That
code can throw an error under any name, user data included, and the
loader reported that name as the error's class. Now the report names the
class only when it is a built-in JavaScript error (`Error`, `TypeError`,
`SyntaxError` and the rest) and says `other` for any other name, or when
reading the name throws.

**A newer malformed link could be lost.** You open a malformed link such
as `?workflowId=bad1`. While it is rejected, the browser goes to
`?workflowId=bad2` with another URL action, and a navigation guard holds
it. The loader counted any two values that are not workflow ids as the
same link, so the cleanup for `bad1` replaced the route and cleared the
saved `bad2`: the held navigation was cancelled and its other URL
actions were lost. Now two different malformed values are different
links. Only the forms the saved query records for one URL value (a
repeated value joined with `,`, a bare `?workflowId` as `,`) still count
as the same link.

The loader tests now use a real memory router with the preserved-query
tracker. They hold navigations in real guards instead of faking
cancellation through a `router.replace` mock. ADR WORKFLOW-LINKS-0053 is
updated for all six rules.

**Why**

Workflow-id links (Comfy-Org#23051) open one saved workflow on Comfy Cloud.
Self-reviews of its backport to `cloud/1.59` (Comfy-Org#23239) found three ways
they go wrong in the code Comfy-Org#23051 put on `main`: a second link held by
sign-in never opens, a user's file name reaches the error sinks, and an
empty `?workflowId=` leaves the page stuck with no message. The backport
carries the same three commits; this PR puts them on `main` so the next
cloud release line has them too.

## Verification

- `vitest run
src/platform/workflow/management/composables/useWorkflowLinkUrlLoader.test.ts`:
on `main`, the new race test and both new reporting tests fail; with
these commits, 41 passed.
- The empty-link test (`rejects an empty workflowId while an older link
is still stashed`) and the tracker test (`clears a stale rejectRepeated
value when the URL supplies an empty value`) failed before the third
commit. With it, the navigation tests, the loader and
`useUrlActionLoaders` pass: 180 tests in 9 files.
- The new tests `reports that custom node code throws an error under its
own name without the file name or the error text` and `leaves a newer
malformed link a navigation guard holds while an older malformed link is
rejected` each failed before its fix (1 failed, 41 and 42 passed). With
both fixes, the loader and `preservedQueryTracker` tests pass: 64 tests
in 2 files.
- `leaves a newer empty link a navigation guard holds after a newer
guard-held link superseded the lookup` (the reviewer's four-step race),
`reports an empty link once when another navigation cancels its URL
cleanup, and clears it later`, the tracker test `stashes an empty
markEmpty value as a bare comma in place of a stale value`, and the `an
error name cannot be read` row each failed before its fix. With both
fixes, the tracker, loader, `useUrlActionLoaders` and
`useWorkflowPersistenceV2` tests pass: 203 tests in 8 files.
- Not run: the full unit suite, lint, typecheck beyond the pre-commit
hook, and the browser tests. CI runs them.
comfy-pr-bot pushed a commit that referenced this pull request Nov 11, 2026
…ames out of its error reports (#23245) (#23263)

Backport of #23245 to `cloud/1.59`.

The backport bot hit conflicts, so this copy was made by hand.
`cloud/1.59` already has the first three of #23245's fixes, carried in
#23239: a newer link held by a navigation guard is kept, a file read or
parser error stays out of the report, and an empty `?workflowId=` is
rejected. This copy adds the other three:

- A report names the error's class only when it is a built-in JavaScript
error (`Error`, `TypeError` and the rest). Any other name, or a name
that throws when read, is reported as `other`. Custom node code can
throw an error under any name.
- Two different malformed links, such as `?workflowId=bad1` and
`?workflowId=bad2`, count as different links. The cleanup for `bad1` no
longer cancels a held navigation to `bad2`.
- An empty `?workflowId=` saves a `,` marker in place of an older saved
link, so an older lookup still sees a newer link while a guard holds the
empty one.

How the conflicts were resolved:

- `src/composables/useWorkflowLinkUrlLoader.ts` and its test take
`main`'s code after #23245 and keep `cloud/1.59`'s imports:
`@/platform/telemetry`, `@/composables/useLinkedWorkflowUrlLoader`, the
`@/platform/workspace` mocks, and the local `reportError` mock. The
files stay in `src/composables`, where #23239 put them for
`cloud/1.59`'s domain zones.
- `src/platform/navigation/preservedQueryTracker.ts` takes `main`'s
version, which adds the `markEmpty` flag `workflowId` sets.
- `preservedQueryTracker.test.ts` adds #23245's `markEmpty` test and
keeps `cloud/1.59`'s other tests, including the redirect round-trip test
#23239 moved there.
- The ADR takes `main`'s text, which describes all six rules and names
no file path.

No other change from #23245. The loader and its test differ from `main`
only in the import lines.

`fallow audit` on the change: no new findings. Not run locally: unit
tests, lint, typecheck and the browser tests. CI runs them.
vqt123 added a commit that referenced this pull request Nov 11, 2026
… on Comfy Cloud (#23051, #23245) (#23265)

Backport of #23051 and #23245 to `cloud/1.60`.

A `?workflowId=` link opens the saved workflow it names on Comfy Cloud
(#23051). #23245 fixes six ways that loader goes wrong: a newer link
held by sign-in was cancelled, a file read or parser error reached error
reports with the user's file name, an empty `?workflowId=` stayed
pending with no message, a custom node's error name reached reports, a
newer malformed link was cancelled, and an empty link held by a guard
could be cancelled.

The backport bot hit conflicts on #23051, so this copy was made by hand,
in three commits:

- #23051, cherry-picked. `packages/ingest-types/src/types.gen.ts` and
`zod.gen.ts` keep `cloud/1.60`'s generated files and add only the
sidebar-file route lines #23051 added (the same 70 and 25 lines). Every
other file applied cleanly.
- #23245, cherry-picked with no conflicts.
- One commit only on this branch, for `cloud/1.60`'s architecture check
(`fallow`): the redirect round-trip test moved from
`preservedQueryDefinitions.test.ts` to `preservedQueryTracker.test.ts`.
The definitions test's zone may not import the query manager or tracker;
the tracker test's zone may. #23239 made the same move on `cloud/1.59`.
The test is unchanged.

The loader, its test and the ADR are the same as on `main`. `cloud/1.60`
has `main`'s package layout (`@comfyorg/telemetry`, the shared
`reportError` mock), so none of #23239's other `cloud/1.59` changes were
needed.

No suppressions and no baseline edits. `fallow audit` on the change: no
new findings. Not run locally: unit tests, lint, typecheck and the
browser tests. CI runs them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants