Repository navigation
[backport cloud/1.59] fix: keep a newer workflow link and keep file names out of its error reports (#23245) - #23263
Conversation
…ames out of its error reports (#23245) Backport of #23245 to cloud/1.59, made by hand because the backport bot hit conflicts. cloud/1.59 already has the first three of #23245's fixes from #23239, and keeps the workflow-link loader in src/composables (moved there in #23239 for cloud/1.59's domain zones). This copy adds the other three: only built-in error class names reach a report, two different malformed links are different links, and an empty link saves a "," marker so a held newer link is not cancelled. Conflicts: - src/composables/useWorkflowLinkUrlLoader.ts and its test take main's code after #23245 and keep cloud/1.59's imports (@/platform/telemetry, @/composables/useLinkedWorkflowUrlLoader, @/platform/workspace mocks, and the local reportError mock). - src/platform/navigation/preservedQueryTracker.ts takes main's version: it adds the markEmpty flag, which workflowId sets, and drops a JSDoc line that no longer holds for workflowId. - preservedQueryTracker.test.ts adds #23245's markEmpty test and keeps cloud/1.59's other tests, including the redirect round-trip test. - The ADR takes main's text, which already describes all six rules. (cherry picked from commit 336fc6a)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
⚡ Performance: ❌ 7 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-11T02:53:38.354Z",
"gitSha": "6bc8188d5db991987c5e71ebf4d6632168193b43",
"branch": "backport-23245-to-cloud-1.59",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2007.706000000013,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.1870000000000007,
"layouts": 9,
"layoutDurationMs": 1.975,
"taskDurationMs": 416.34499999999997,
"heapDeltaBytes": 3286804,
"heapUsedBytes": 65363912,
"domNodes": 0,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 8.024,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-idle",
"durationMs": 2008.974999999964,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.0509999999999997,
"layouts": 9,
"layoutDurationMs": 2.0610000000000004,
"taskDurationMs": 410.08000000000004,
"heapDeltaBytes": 4379356,
"heapUsedBytes": 65999132,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 7.511,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1709.5529999999997,
"styleRecalcs": 72,
"styleRecalcDurationMs": 10.683000000000002,
"layouts": 9,
"layoutDurationMs": 1.8599999999999999,
"taskDurationMs": 700.1500000000001,
"heapDeltaBytes": 24439228,
"heapUsedBytes": 85592212,
"domNodes": 0,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 120.009,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1707.7500000000327,
"styleRecalcs": 72,
"styleRecalcDurationMs": 11.029,
"layouts": 11,
"layoutDurationMs": 2.503,
"taskDurationMs": 755.023,
"heapDeltaBytes": -19109380,
"heapUsedBytes": 58304988,
"domNodes": -161,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 122.346,
"eventListeners": -91,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1706.9030000000112,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.047,
"layouts": 10,
"layoutDurationMs": 3.469,
"taskDurationMs": 342.265,
"heapDeltaBytes": 25118752,
"heapUsedBytes": 86912796,
"domNodes": 56,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 9.895,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1704.1939999999158,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.760999999999999,
"layouts": 9,
"layoutDurationMs": 2.8790000000000004,
"taskDurationMs": 333.359,
"heapDeltaBytes": -105452,
"heapUsedBytes": 61641376,
"domNodes": 56,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 9.653,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666666,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 542.9110000000037,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.437,
"layouts": 9,
"layoutDurationMs": 2.132,
"taskDurationMs": 402.423,
"heapDeltaBytes": 5540636,
"heapUsedBytes": 68208352,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 137.469,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 566.9680000000312,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.655,
"layouts": 9,
"layoutDurationMs": 2.3499999999999996,
"taskDurationMs": 400.16599999999994,
"heapDeltaBytes": 6209660,
"heapUsedBytes": 67783432,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 136.08200000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667647058823523,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1069.4930000000227,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 721.408,
"heapDeltaBytes": -13562552,
"heapUsedBytes": 76175432,
"domNodes": -191,
"jsHeapTotalBytes": 21766144,
"scriptDurationMs": 51.58800000000001,
"eventListeners": -107,
"totalBlockingTimeMs": 384,
"frameDurationMs": 28.82972972972974,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1055.2240000000097,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 712.175,
"heapDeltaBytes": -13799036,
"heapUsedBytes": 75906568,
"domNodes": -191,
"jsHeapTotalBytes": 21241856,
"scriptDurationMs": 53.913000000000004,
"eventListeners": -107,
"totalBlockingTimeMs": 372,
"frameDurationMs": 29.16388888888889,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 799.5940000000132,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 439.40399999999966,
"heapDeltaBytes": -26812892,
"heapUsedBytes": 65731524,
"domNodes": -191,
"jsHeapTotalBytes": 4587520,
"scriptDurationMs": 119.71800000000002,
"eventListeners": -107,
"totalBlockingTimeMs": 157,
"frameDurationMs": 22.857142857142858,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 815.1319999999487,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.67300000000023,
"heapDeltaBytes": -26765256,
"heapUsedBytes": 67331572,
"domNodes": -191,
"jsHeapTotalBytes": 4587520,
"scriptDurationMs": 116.535,
"eventListeners": -107,
"totalBlockingTimeMs": 157,
"frameDurationMs": 22.68333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8351.060999999987,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.183,
"layouts": 1,
"layoutDurationMs": 0.15899999999999986,
"taskDurationMs": 7482.428999999999,
"heapDeltaBytes": 80104368,
"heapUsedBytes": 154737604,
"domNodes": -257,
"jsHeapTotalBytes": 63565824,
"scriptDurationMs": 5844.88,
"eventListeners": -69,
"totalBlockingTimeMs": 101,
"frameDurationMs": 24.77655786350148,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7559.53199999999,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.055999999999999626,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6733.367,
"heapDeltaBytes": 9697084,
"heapUsedBytes": 70575624,
"domNodes": -257,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 5288.505,
"eventListeners": -69,
"totalBlockingTimeMs": 28,
"frameDurationMs": 23.816088328075708,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7484.240999999997,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.7290000000000005,
"layouts": 3,
"layoutDurationMs": 0.6580000000000001,
"taskDurationMs": 6741.597,
"heapDeltaBytes": 61922832,
"heapUsedBytes": 135848884,
"domNodes": -257,
"jsHeapTotalBytes": 57012224,
"scriptDurationMs": 5201.157,
"eventListeners": -69,
"totalBlockingTimeMs": 126,
"frameDurationMs": 24.86046511627907,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7591.642000000036,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.6710000000000006,
"layouts": 3,
"layoutDurationMs": 0.83,
"taskDurationMs": 6824.125,
"heapDeltaBytes": 50835720,
"heapUsedBytes": 125299084,
"domNodes": -257,
"jsHeapTotalBytes": 58585088,
"scriptDurationMs": 5289.7480000000005,
"eventListeners": -69,
"totalBlockingTimeMs": 74,
"frameDurationMs": 24.280191693290735,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "large-combo-open",
"durationMs": 202.76300000000447,
"styleRecalcs": 23,
"styleRecalcDurationMs": 11.096000000000002,
"layouts": 10,
"layoutDurationMs": 2.681,
"taskDurationMs": 162.04799999999997,
"heapDeltaBytes": -8143408,
"heapUsedBytes": 75547120,
"domNodes": 936,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 7.726999999999999,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.670000000000027,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-combo-open",
"durationMs": 238.89300000001867,
"styleRecalcs": 25,
"styleRecalcDurationMs": 12.804,
"layouts": 11,
"layoutDurationMs": 2.7970000000000006,
"taskDurationMs": 200.69600000000003,
"heapDeltaBytes": -25464228,
"heapUsedBytes": 58078372,
"domNodes": 936,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 7.436,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.22307692307693,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2024.7779999999977,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.254,
"layouts": 9,
"layoutDurationMs": 1.9729999999999999,
"taskDurationMs": 518.692,
"heapDeltaBytes": -11621552,
"heapUsedBytes": 62448428,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 28.250000000000004,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2026.407000000006,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.0439999999999996,
"layouts": 9,
"layoutDurationMs": 1.986,
"taskDurationMs": 529.3950000000001,
"heapDeltaBytes": 11310580,
"heapUsedBytes": 84911448,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 30.049999999999994,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2253.2390000000078,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.372000000000002,
"layouts": 7,
"layoutDurationMs": 1.6300000000000001,
"taskDurationMs": 1335.91,
"heapDeltaBytes": -3042080,
"heapUsedBytes": 72902896,
"domNodes": -257,
"jsHeapTotalBytes": 4808704,
"scriptDurationMs": 635.623,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665925925925922,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2349.3690000000242,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.725999999999999,
"layouts": 7,
"layoutDurationMs": 1.6079999999999999,
"taskDurationMs": 1377.327,
"heapDeltaBytes": -14008704,
"heapUsedBytes": 61298680,
"domNodes": -257,
"jsHeapTotalBytes": 5894144,
"scriptDurationMs": 669.87,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665957446808513,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3436.7349999999988,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.259,
"layouts": 65,
"layoutDurationMs": 9.947000000000001,
"taskDurationMs": 1496.3220000000001,
"heapDeltaBytes": 7095556,
"heapUsedBytes": 84335132,
"domNodes": -233,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 643.004,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3354.9059999999713,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.027000000000001,
"layouts": 63,
"layoutDurationMs": 9.604000000000001,
"taskDurationMs": 1418.171,
"heapDeltaBytes": 4664104,
"heapUsedBytes": 81621600,
"domNodes": 24,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 629.8549999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665671641791047,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "legacy-node-drag",
"durationMs": 2490.329000000031,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.220999999999999,
"layouts": 6,
"layoutDurationMs": 1.317,
"taskDurationMs": 1642.899,
"heapDeltaBytes": 15921464,
"heapUsedBytes": 95451452,
"domNodes": 0,
"jsHeapTotalBytes": 6184960,
"scriptDurationMs": 814.905,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.778378378378378,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2419.263000000001,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.252000000000001,
"layouts": 6,
"layoutDurationMs": 1.4029999999999998,
"taskDurationMs": 1579.9,
"heapDeltaBytes": 16961956,
"heapUsedBytes": 102093936,
"domNodes": 0,
"jsHeapTotalBytes": 6971392,
"scriptDurationMs": 806.5369999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.78125,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2976.6799999999876,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.0040000000000004,
"layouts": 8,
"layoutDurationMs": 2.021,
"taskDurationMs": 645.7620000000001,
"heapDeltaBytes": 4712684,
"heapUsedBytes": 81155172,
"domNodes": -257,
"jsHeapTotalBytes": 1961984,
"scriptDurationMs": 288.744,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666292134831462,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2941.8059999999855,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.8830000000000002,
"layouts": 7,
"layoutDurationMs": 1.6689999999999998,
"taskDurationMs": 658.826,
"heapDeltaBytes": 1762280,
"heapUsedBytes": 79298100,
"domNodes": -257,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 288.718,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665536723163843,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2036.6879999999696,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.015,
"layouts": 8,
"layoutDurationMs": 1.8,
"taskDurationMs": 518.0040000000001,
"heapDeltaBytes": -15256120,
"heapUsedBytes": 62320872,
"domNodes": -257,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 31.037000000000003,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2036.519999999996,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.32,
"layouts": 9,
"layoutDurationMs": 2.298,
"taskDurationMs": 533.421,
"heapDeltaBytes": -16760204,
"heapUsedBytes": 59815592,
"domNodes": -257,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 31.249000000000006,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2692.7709999999934,
"styleRecalcs": 27,
"styleRecalcDurationMs": 11.029,
"layouts": 8,
"layoutDurationMs": 1.9709999999999996,
"taskDurationMs": 508.95200000000006,
"heapDeltaBytes": 6325804,
"heapUsedBytes": 82915976,
"domNodes": -238,
"jsHeapTotalBytes": -921600,
"scriptDurationMs": 149.84,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666049382716047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2713.008000000002,
"styleRecalcs": 26,
"styleRecalcDurationMs": 11.172,
"layouts": 7,
"layoutDurationMs": 1.576,
"taskDurationMs": 421.934,
"heapDeltaBytes": -7300400,
"heapUsedBytes": 69579404,
"domNodes": -254,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 150.34399999999997,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665644171779142,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-topology-cadence",
"durationMs": 2978.447000000017,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.059,
"layouts": 5,
"layoutDurationMs": 0.9330000000000003,
"taskDurationMs": 653.8730000000002,
"heapDeltaBytes": 7518604,
"heapUsedBytes": 69137900,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 298.027,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665730337078653,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-topology-cadence",
"durationMs": 3071.583999999973,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.673,
"layouts": 7,
"layoutDurationMs": 1.5010000000000001,
"taskDurationMs": 746.946,
"heapDeltaBytes": 3573092,
"heapUsedBytes": 80449176,
"domNodes": -257,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 298.53999999999996,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66576086956522,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 531.5590000000157,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.396,
"layouts": 9,
"layoutDurationMs": 2.156,
"taskDurationMs": 348.69800000000004,
"heapDeltaBytes": 618460,
"heapUsedBytes": 63628432,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 120.317,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662499999999994,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 560.4240000000118,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.476,
"layouts": 9,
"layoutDurationMs": 2.091,
"taskDurationMs": 352.48699999999997,
"heapDeltaBytes": -1096072,
"heapUsedBytes": 60911796,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 119.113,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2024.9210000000062,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.2920000000000007,
"layouts": 9,
"layoutDurationMs": 2.156,
"taskDurationMs": 447.40500000000003,
"heapDeltaBytes": -1963584,
"heapUsedBytes": 61580064,
"domNodes": -183,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 7.187,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2042.363000000023,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.135,
"layouts": 8,
"layoutDurationMs": 1.875,
"taskDurationMs": 469.266,
"heapDeltaBytes": -5883468,
"heapUsedBytes": 57901900,
"domNodes": -183,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 8.256999999999998,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.8030000000026,
"styleRecalcs": 75,
"styleRecalcDurationMs": 11.775999999999998,
"layouts": 9,
"layoutDurationMs": 2.0160000000000005,
"taskDurationMs": 658.2139999999999,
"heapDeltaBytes": 18605448,
"heapUsedBytes": 81058360,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 87.87299999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.1620000000098,
"styleRecalcs": 75,
"styleRecalcDurationMs": 11.374,
"layouts": 10,
"layoutDurationMs": 1.9579999999999997,
"taskDurationMs": 647.888,
"heapDeltaBytes": 18554756,
"heapUsedBytes": 81728940,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 86.214,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665346534653462,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 1334.9120000000312,
"styleRecalcs": 21,
"styleRecalcDurationMs": 17.476000000000003,
"layouts": 5,
"layoutDurationMs": 12.014000000000001,
"taskDurationMs": 843.191,
"heapDeltaBytes": 9494104,
"heapUsedBytes": 101678292,
"domNodes": 16030,
"jsHeapTotalBytes": 16392192,
"scriptDurationMs": 23.953999999999997,
"eventListeners": 3246,
"totalBlockingTimeMs": 118,
"frameDurationMs": 18.748611111111106,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8733.734999999968,
"styleRecalcs": 249,
"styleRecalcDurationMs": 29.253,
"layouts": 7,
"layoutDurationMs": 1.6260000000000003,
"taskDurationMs": 4840.862999999999,
"heapDeltaBytes": 23372196,
"heapUsedBytes": 83855104,
"domNodes": -257,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 2251.779,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665965583174,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8596.699000000059,
"styleRecalcs": 250,
"styleRecalcDurationMs": 28.622,
"layouts": 9,
"layoutDurationMs": 1.859,
"taskDurationMs": 4667.166,
"heapDeltaBytes": -30894160,
"heapUsedBytes": 62828600,
"domNodes": -257,
"jsHeapTotalBytes": 5668864,
"scriptDurationMs": 2115.157,
"eventListeners": -89,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666085271317826,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 20148.42699999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19472.795,
"heapDeltaBytes": -26772652,
"heapUsedBytes": 256685252,
"domNodes": -3343,
"jsHeapTotalBytes": 9162752,
"scriptDurationMs": 267.203,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.50199275362319,
"p95FrameDurationMs": 83.19999999999891
},
{
"name": "vue-large-graph-idle",
"durationMs": 20152.198999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19555.9,
"heapDeltaBytes": 2304300,
"heapUsedBytes": 280731868,
"domNodes": -3343,
"jsHeapTotalBytes": 16240640,
"scriptDurationMs": 265.47700000000003,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.49068901303538,
"p95FrameDurationMs": 66.80000000000109
},
{
"name": "vue-large-graph-pan",
"durationMs": 24062.230999999996,
"styleRecalcs": 181,
"styleRecalcDurationMs": 18.730999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23707.699,
"heapDeltaBytes": -20016640,
"heapUsedBytes": 246079716,
"domNodes": -3343,
"jsHeapTotalBytes": -12058624,
"scriptDurationMs": 714.621,
"eventListeners": -651,
"totalBlockingTimeMs": 1,
"frameDurationMs": 45.547348484848484,
"p95FrameDurationMs": 99.90000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 24217.85199999999,
"styleRecalcs": 181,
"styleRecalcDurationMs": 18.440000000000012,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23922.561999999998,
"heapDeltaBytes": -35611820,
"heapUsedBytes": 266760456,
"domNodes": -3343,
"jsHeapTotalBytes": 16769024,
"scriptDurationMs": 777.8960000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 4,
"frameDurationMs": 46.87117988394584,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 7156.931000000042,
"styleRecalcs": 20,
"styleRecalcDurationMs": 47.013,
"layouts": 20,
"layoutDurationMs": 20.418000000000006,
"taskDurationMs": 7012.146999999999,
"heapDeltaBytes": -30202108,
"heapUsedBytes": 271829840,
"domNodes": -3343,
"jsHeapTotalBytes": 17817600,
"scriptDurationMs": 104.12200000000001,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.66453488372094,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-node-resize-workload",
"durationMs": 7268.402000000037,
"styleRecalcs": 20,
"styleRecalcDurationMs": 50.479,
"layouts": 20,
"layoutDurationMs": 22.052000000000003,
"taskDurationMs": 7128.429999999999,
"heapDeltaBytes": -19145924,
"heapUsedBytes": 258076740,
"domNodes": -3343,
"jsHeapTotalBytes": 25157632,
"scriptDurationMs": 101.204,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.77349397590361,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9803.248999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9611.271,
"heapDeltaBytes": -22910672,
"heapUsedBytes": 254310380,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 127.137,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.36802973977696,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10027.243999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9711.779,
"heapDeltaBytes": -4099252,
"heapUsedBytes": 259172732,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 126.21800000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.39293286219082,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "workflow-execution",
"durationMs": 100.47399999996287,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.882,
"layouts": 7,
"layoutDurationMs": 2.504,
"taskDurationMs": 67.97200000000001,
"heapDeltaBytes": 4849488,
"heapUsedBytes": 65744244,
"domNodes": 127,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.895999999999999,
"eventListeners": 3,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 107.77199999995446,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.375000000000001,
"layouts": 9,
"layoutDurationMs": 2.8269999999999995,
"taskDurationMs": 68.545,
"heapDeltaBytes": 4593556,
"heapUsedBytes": 64586624,
"domNodes": 124,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 4.478000000000001,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.650000000000016,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 298.5079999999698,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.596,
"layouts": 76,
"layoutDurationMs": 11.99,
"taskDurationMs": 260.05100000000004,
"heapDeltaBytes": -5771428,
"heapUsedBytes": 36892556,
"domNodes": 4,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 118.566,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 306.4430000000584,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.5630000000000001,
"layouts": 76,
"layoutDurationMs": 11.726,
"taskDurationMs": 273.94599999999997,
"heapDeltaBytes": -4547004,
"heapUsedBytes": 40512404,
"domNodes": 4,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 122.825,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 339.1080000000102,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.516,
"layouts": 76,
"layoutDurationMs": 11.647,
"taskDurationMs": 297.363,
"heapDeltaBytes": -1699152,
"heapUsedBytes": 89684480,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 107.571,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664999999999964,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 338.7589999999818,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.484,
"layouts": 76,
"layoutDurationMs": 12.207,
"taskDurationMs": 316.92600000000004,
"heapDeltaBytes": -1375912,
"heapUsedBytes": 94365100,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 116.07100000000001,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E Coverage: 🟡 59.5% of linesCoverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3154 passed, 0 failed · 4 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 24cad5c596ca6fe8af61edef91c406ac2f0dbfa4
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (324)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.59 #23263 +/- ##
=============================================
Coverage ? 87.24%
=============================================
Files ? 3106
Lines ? 162453
Branches ? 43424
=============================================
Hits ? 141726
Misses ? 20050
Partials ? 677
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Approved as a backport of #23245 to cloud/1.59, as requested. No additional code-change review. Tests were not run.
Backport of #23245 to
cloud/1.59.The backport bot hit conflicts, so this copy was made by hand.
cloud/1.59already has the first three of #23245's fixes, carried in #23239: a newer link held by a navigation guard is kept, a file read or parser error stays out of the report, and an empty?workflowId=is rejected. This copy adds the other three:Error,TypeErrorand the rest). Any other name, or a name that throws when read, is reported asother. Custom node code can throw an error under any name.?workflowId=bad1and?workflowId=bad2, count as different links. The cleanup forbad1no longer cancels a held navigation tobad2.?workflowId=saves a,marker in place of an older saved link, so an older lookup still sees a newer link while a guard holds the empty one.How the conflicts were resolved:
src/composables/useWorkflowLinkUrlLoader.tsand its test takemain's code after fix: keep a newer workflow link and keep file names out of its error reports #23245 and keepcloud/1.59's imports:@/platform/telemetry,@/composables/useLinkedWorkflowUrlLoader, the@/platform/workspacemocks, and the localreportErrormock. The files stay insrc/composables, where [backport cloud/1.59] feat: Workflow-id links open the saved workflow on Comfy Cloud (#23051) #23239 put them forcloud/1.59's domain zones.src/platform/navigation/preservedQueryTracker.tstakesmain's version, which adds themarkEmptyflagworkflowIdsets.preservedQueryTracker.test.tsadds fix: keep a newer workflow link and keep file names out of its error reports #23245'smarkEmptytest and keepscloud/1.59's other tests, including the redirect round-trip test [backport cloud/1.59] feat: Workflow-id links open the saved workflow on Comfy Cloud (#23051) #23239 moved there.main's text, which describes all six rules and names no file path.No other change from #23245. The loader and its test differ from
mainonly in the import lines.fallow auditon the change: no new findings. Not run locally: unit tests, lint, typecheck and the browser tests. CI runs them.