Repository navigation
[backport cloud/1.60] feat: Workflow-id links open the saved workflow on Comfy Cloud (#23051, #23245) - #23265
Conversation
… on Comfy Cloud (#23051) Backport of #23051 to cloud/1.60, made by hand because the backport bot hit conflicts. Conflicts: - packages/ingest-types/src/types.gen.ts and zod.gen.ts keep cloud/1.60's generated files and add only the sidebar-file route lines #23051 added (the same 70 and 25 lines). Every other file applied cleanly. (cherry picked from commit fe18e38)
…reports (#23245) ## Summary Six fixes to workflow-id links (#23051). **A newer link could be lost.** You open a `?workflowId=` link and it opens. Before its URL cleanup finishes, the browser goes to a second `?workflowId=` link, and a navigation guard (sign-in, for example) holds it. Then the URL actions run after boot and clean up for the first link again. That cleanup cancelled the held navigation and cleared its saved query, so the second link never opened. Now, when the URL and the saved query name different links, the loader treats the saved one as a navigation still in flight. It makes no replace and clears neither, even for a link it already opened. **A file name could reach error reports.** The lookup finds the linked file, but reading the file fails (a 500, or the file was deleted in between). The read error says `Failed to load file 'workflows/<name>.json'`, and the loader passed it on as the cause of its own report. The error sinks keep nested causes, so the user's file name reached them. A lookup reply that was not JSON did the same with the parser message, which quotes the reply. Now the loader reports a fixed message with the error's class name only. **An empty link could stay stuck.** A tab still holds the saved query from an earlier link that has not finished (a sign-in, for example). You then open `?workflowId=` with no value. The empty value did not replace the saved one, so the loader saw two different links, treated the old one as a navigation in flight and stayed pending: no error message, and nothing cleared. Now an empty `workflowId` saves a `,` marker in place of the older link. While a guard holds the empty link, an older lookup still sees a newer link and stays pending, so its cleanup cannot cancel that navigation or drop its other URL actions. Once the empty link lands, the loader treats `''` and the marker as the same link: it is rejected as invalid, reported once, and cleared. For `workspace`, `deployment` and `workflows`, an empty URL value clears the stale saved value at capture; their loaders already treat an empty value as no value. **Custom node code could put its own text in error reports.** Loading a workflow runs custom node code, such as a widget's `computeSize`. That code can throw an error under any name, user data included, and the loader reported that name as the error's class. Now the report names the class only when it is a built-in JavaScript error (`Error`, `TypeError`, `SyntaxError` and the rest) and says `other` for any other name, or when reading the name throws. **A newer malformed link could be lost.** You open a malformed link such as `?workflowId=bad1`. While it is rejected, the browser goes to `?workflowId=bad2` with another URL action, and a navigation guard holds it. The loader counted any two values that are not workflow ids as the same link, so the cleanup for `bad1` replaced the route and cleared the saved `bad2`: the held navigation was cancelled and its other URL actions were lost. Now two different malformed values are different links. Only the forms the saved query records for one URL value (a repeated value joined with `,`, a bare `?workflowId` as `,`) still count as the same link. The loader tests now use a real memory router with the preserved-query tracker. They hold navigations in real guards instead of faking cancellation through a `router.replace` mock. ADR WORKFLOW-LINKS-0053 is updated for all six rules. **Why** Workflow-id links (#23051) open one saved workflow on Comfy Cloud. Self-reviews of its backport to `cloud/1.59` (#23239) found three ways they go wrong in the code #23051 put on `main`: a second link held by sign-in never opens, a user's file name reaches the error sinks, and an empty `?workflowId=` leaves the page stuck with no message. The backport carries the same three commits; this PR puts them on `main` so the next cloud release line has them too. ## Verification - `vitest run src/platform/workflow/management/composables/useWorkflowLinkUrlLoader.test.ts`: on `main`, the new race test and both new reporting tests fail; with these commits, 41 passed. - The empty-link test (`rejects an empty workflowId while an older link is still stashed`) and the tracker test (`clears a stale rejectRepeated value when the URL supplies an empty value`) failed before the third commit. With it, the navigation tests, the loader and `useUrlActionLoaders` pass: 180 tests in 9 files. - The new tests `reports that custom node code throws an error under its own name without the file name or the error text` and `leaves a newer malformed link a navigation guard holds while an older malformed link is rejected` each failed before its fix (1 failed, 41 and 42 passed). With both fixes, the loader and `preservedQueryTracker` tests pass: 64 tests in 2 files. - `leaves a newer empty link a navigation guard holds after a newer guard-held link superseded the lookup` (the reviewer's four-step race), `reports an empty link once when another navigation cancels its URL cleanup, and clears it later`, the tracker test `stashes an empty markEmpty value as a bare comma in place of a stale value`, and the `an error name cannot be read` row each failed before its fix. With both fixes, the tracker, loader, `useUrlActionLoaders` and `useWorkflowPersistenceV2` tests pass: 203 tests in 8 files. - Not run: the full unit suite, lint, typecheck beyond the pre-commit hook, and the browser tests. CI runs them. (cherry picked from commit 336fc6a)
… domain zones On cloud/1.60, fallow puts preservedQueryDefinitions.test.ts in a zone that may not import preservedQueryManager or preservedQueryTracker. The redirect round-trip test #23051 added there moves to preservedQueryTracker.test.ts, whose zone may import both, as #23239 did on cloud/1.59. The test is unchanged.
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
⚡ Performance: ❌ 7 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-11T03:24:26.598Z",
"gitSha": "64af694c88758cb7336fc9e83c7960073e591f76",
"branch": "backport-23051-23245-to-cloud-1.60",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2025.2389999999991,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.669,
"layouts": 10,
"layoutDurationMs": 2.4699999999999998,
"taskDurationMs": 490.67499999999995,
"heapDeltaBytes": -22162316,
"heapUsedBytes": 55520732,
"domNodes": -178,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 8.662999999999998,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-idle",
"durationMs": 2021.2260000000697,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.331,
"layouts": 9,
"layoutDurationMs": 2.064,
"taskDurationMs": 457.0570000000001,
"heapDeltaBytes": 3551996,
"heapUsedBytes": 63734852,
"domNodes": -178,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 7.346000000000002,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1747.150999999974,
"styleRecalcs": 73,
"styleRecalcDurationMs": 11.702,
"layouts": 9,
"layoutDurationMs": 2.197,
"taskDurationMs": 804.433,
"heapDeltaBytes": 4027100,
"heapUsedBytes": 64833076,
"domNodes": -178,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 131.817,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1739.1179999999622,
"styleRecalcs": 73,
"styleRecalcDurationMs": 11.516,
"layouts": 10,
"layoutDurationMs": 2.411,
"taskDurationMs": 767.003,
"heapDeltaBytes": -3835284,
"heapUsedBytes": 57945948,
"domNodes": -178,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 126.521,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1736.4149999999654,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.490000000000001,
"layouts": 12,
"layoutDurationMs": 2.6170000000000004,
"taskDurationMs": 332.81,
"heapDeltaBytes": 25389272,
"heapUsedBytes": 87482152,
"domNodes": 57,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 9.914000000000001,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.5139999999756,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.286,
"layouts": 11,
"layoutDurationMs": 2.4720000000000004,
"taskDurationMs": 330.501,
"heapDeltaBytes": 3312248,
"heapUsedBytes": 65270708,
"domNodes": 57,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 9.609000000000002,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 550.4410000000348,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.7579999999999996,
"layouts": 10,
"layoutDurationMs": 2.368,
"taskDurationMs": 368.03000000000003,
"heapDeltaBytes": -16311096,
"heapUsedBytes": 60316048,
"domNodes": 0,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 140.407,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 560.8099999999467,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.373,
"layouts": 9,
"layoutDurationMs": 2.015,
"taskDurationMs": 414.419,
"heapDeltaBytes": 6040644,
"heapUsedBytes": 68790812,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 136.36,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66176470588235,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1069.6230000000355,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 740.4379999999999,
"heapDeltaBytes": -11226084,
"heapUsedBytes": 78161592,
"domNodes": -208,
"jsHeapTotalBytes": 20455424,
"scriptDurationMs": 50.20100000000001,
"eventListeners": -107,
"totalBlockingTimeMs": 396,
"frameDurationMs": 29.627777777777776,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1016.5660000000116,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 669.412,
"heapDeltaBytes": -3269696,
"heapUsedBytes": 80200744,
"domNodes": -208,
"jsHeapTotalBytes": 13533184,
"scriptDurationMs": 50.145999999999994,
"eventListeners": -107,
"totalBlockingTimeMs": 371,
"frameDurationMs": 29.045714285714283,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 809.6699999999828,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 465.05399999999986,
"heapDeltaBytes": -24170000,
"heapUsedBytes": 69117232,
"domNodes": -208,
"jsHeapTotalBytes": 3276800,
"scriptDurationMs": 127.44,
"eventListeners": -107,
"totalBlockingTimeMs": 164,
"frameDurationMs": 23.33142857142858,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 812.3640000000023,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 460.30799999999994,
"heapDeltaBytes": -27032616,
"heapUsedBytes": 67515288,
"domNodes": -208,
"jsHeapTotalBytes": 5111808,
"scriptDurationMs": 118.562,
"eventListeners": -107,
"totalBlockingTimeMs": 159,
"frameDurationMs": 22.683333333333344,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8055.515000000014,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.5599999999999997,
"layouts": 2,
"layoutDurationMs": 0.38800000000000034,
"taskDurationMs": 7188.874999999999,
"heapDeltaBytes": 46448532,
"heapUsedBytes": 141118820,
"domNodes": -274,
"jsHeapTotalBytes": 69332992,
"scriptDurationMs": 5617.717,
"eventListeners": -69,
"totalBlockingTimeMs": 83,
"frameDurationMs": 24.616819571865445,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8446.70700000006,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.23499999999999996,
"layouts": 1,
"layoutDurationMs": 0.196,
"taskDurationMs": 7755.653999999999,
"heapDeltaBytes": 78853576,
"heapUsedBytes": 155737472,
"domNodes": -274,
"jsHeapTotalBytes": 72740864,
"scriptDurationMs": 6168.918,
"eventListeners": -69,
"totalBlockingTimeMs": 93,
"frameDurationMs": 24.925073746312684,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7594.09199999999,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.5850000000000004,
"layouts": 2,
"layoutDurationMs": 0.464,
"taskDurationMs": 6782.766,
"heapDeltaBytes": 30591600,
"heapUsedBytes": 125196132,
"domNodes": -274,
"jsHeapTotalBytes": 59895808,
"scriptDurationMs": 5163.542,
"eventListeners": -69,
"totalBlockingTimeMs": 67,
"frameDurationMs": 24.304487179487182,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7854.151000000002,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8289999999999998,
"layouts": 3,
"layoutDurationMs": 0.702,
"taskDurationMs": 7070.092,
"heapDeltaBytes": 79691400,
"heapUsedBytes": 156430884,
"domNodes": -274,
"jsHeapTotalBytes": 63565824,
"scriptDurationMs": 5520.959,
"eventListeners": -69,
"totalBlockingTimeMs": 70,
"frameDurationMs": 24.377950310559005,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "large-combo-open",
"durationMs": 184.98599999998078,
"styleRecalcs": 22,
"styleRecalcDurationMs": 11.653,
"layouts": 10,
"layoutDurationMs": 2.46,
"taskDurationMs": 146.39099999999996,
"heapDeltaBytes": 14803708,
"heapUsedBytes": 89683588,
"domNodes": 936,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 7.129000000000001,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.22222222222222,
"p95FrameDurationMs": 66.59999999999991
},
{
"name": "large-combo-open",
"durationMs": 183.31299999999828,
"styleRecalcs": 23,
"styleRecalcDurationMs": 11.063,
"layouts": 11,
"layoutDurationMs": 2.7609999999999997,
"taskDurationMs": 141.89,
"heapDeltaBytes": 14807356,
"heapUsedBytes": 90684316,
"domNodes": 936,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 6.985,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.377777777777737,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2025.2740000000244,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.463,
"layouts": 10,
"layoutDurationMs": 2.28,
"taskDurationMs": 548.813,
"heapDeltaBytes": 2846180,
"heapUsedBytes": 86673744,
"domNodes": -274,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 32.342000000000006,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2025.6489999999303,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.4009999999999994,
"layouts": 9,
"layoutDurationMs": 2.1330000000000005,
"taskDurationMs": 528.5179999999999,
"heapDeltaBytes": -8226312,
"heapUsedBytes": 74403132,
"domNodes": -274,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 28.307,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2598.1550000000198,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.643999999999998,
"layouts": 8,
"layoutDurationMs": 1.7990000000000002,
"taskDurationMs": 1443.7989999999998,
"heapDeltaBytes": 4659016,
"heapUsedBytes": 80689004,
"domNodes": -274,
"jsHeapTotalBytes": 4284416,
"scriptDurationMs": 712.375,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66602564102564,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2304.7409999999218,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.621,
"layouts": 8,
"layoutDurationMs": 1.801,
"taskDurationMs": 1365.8389999999997,
"heapDeltaBytes": -322028,
"heapUsedBytes": 83609156,
"domNodes": -274,
"jsHeapTotalBytes": 4546560,
"scriptDurationMs": 658.633,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665942028985512,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3519.1879999999855,
"styleRecalcs": 73,
"styleRecalcDurationMs": 9.617,
"layouts": 66,
"layoutDurationMs": 9.84,
"taskDurationMs": 1487.833,
"heapDeltaBytes": -11473844,
"heapUsedBytes": 66382848,
"domNodes": -250,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 635.25,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666350710900474,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-zoom",
"durationMs": 3466.9569999999794,
"styleRecalcs": 72,
"styleRecalcDurationMs": 9.455,
"layouts": 66,
"layoutDurationMs": 9.924,
"taskDurationMs": 1489.6730000000002,
"heapDeltaBytes": -11739492,
"heapUsedBytes": 62028052,
"domNodes": -250,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 636.5020000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2500.518999999997,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.736999999999999,
"layouts": 6,
"layoutDurationMs": 1.2200000000000002,
"taskDurationMs": 1609.3619999999999,
"heapDeltaBytes": 23525416,
"heapUsedBytes": 96408208,
"domNodes": 0,
"jsHeapTotalBytes": 6184960,
"scriptDurationMs": 799.693,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665100671140937,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2414.9530000000823,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.462,
"layouts": 8,
"layoutDurationMs": 1.9100000000000001,
"taskDurationMs": 1569.0810000000001,
"heapDeltaBytes": 22632792,
"heapUsedBytes": 96607668,
"domNodes": 0,
"jsHeapTotalBytes": 5660672,
"scriptDurationMs": 770.7769999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.78125,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2937.848000000031,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.0810000000000004,
"layouts": 7,
"layoutDurationMs": 1.8940000000000001,
"taskDurationMs": 637.7579999999999,
"heapDeltaBytes": -19143068,
"heapUsedBytes": 73468288,
"domNodes": 0,
"jsHeapTotalBytes": 5541888,
"scriptDurationMs": 307.813,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610169491526,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2941.520999999966,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.9729999999999999,
"layouts": 9,
"layoutDurationMs": 1.9060000000000001,
"taskDurationMs": 642.63,
"heapDeltaBytes": 8487628,
"heapUsedBytes": 81678952,
"domNodes": -274,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 282.961,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665536723163843,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2035.024999999962,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.6880000000000002,
"layouts": 7,
"layoutDurationMs": 1.467,
"taskDurationMs": 534.2739999999999,
"heapDeltaBytes": -2747692,
"heapUsedBytes": 83095544,
"domNodes": -274,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 29.208,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2033.994000000007,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.025000000000001,
"layouts": 8,
"layoutDurationMs": 1.741,
"taskDurationMs": 527.423,
"heapDeltaBytes": 7931928,
"heapUsedBytes": 85846792,
"domNodes": -274,
"jsHeapTotalBytes": 2748416,
"scriptDurationMs": 28.874999999999996,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2676.1469999999576,
"styleRecalcs": 28,
"styleRecalcDurationMs": 11.277000000000001,
"layouts": 8,
"layoutDurationMs": 1.647,
"taskDurationMs": 457.786,
"heapDeltaBytes": -18250100,
"heapUsedBytes": 74077780,
"domNodes": 19,
"jsHeapTotalBytes": 4493312,
"scriptDurationMs": 150.333,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665838509316767,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2724.965999999995,
"styleRecalcs": 27,
"styleRecalcDurationMs": 10.724999999999998,
"layouts": 8,
"layoutDurationMs": 2.085,
"taskDurationMs": 449.681,
"heapDeltaBytes": -18003272,
"heapUsedBytes": 74261432,
"domNodes": 19,
"jsHeapTotalBytes": 3969024,
"scriptDurationMs": 147.927,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66524390243902,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3111.940000000004,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.8619999999999999,
"layouts": 7,
"layoutDurationMs": 1.574,
"taskDurationMs": 795.4689999999999,
"heapDeltaBytes": -5511112,
"heapUsedBytes": 71784276,
"domNodes": -274,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 307.977,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665775401069517,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3073.030000000017,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.6959999999999995,
"layouts": 7,
"layoutDurationMs": 1.482,
"taskDurationMs": 755.2180000000001,
"heapDeltaBytes": 15365188,
"heapUsedBytes": 88319784,
"domNodes": -274,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 292.74300000000005,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66576086956522,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 546.2079999999787,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.86,
"layouts": 10,
"layoutDurationMs": 2.214,
"taskDurationMs": 366.832,
"heapDeltaBytes": 5121380,
"heapUsedBytes": 77392452,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 120.191,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 514.6200000000363,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.716999999999999,
"layouts": 9,
"layoutDurationMs": 1.9919999999999998,
"taskDurationMs": 348.045,
"heapDeltaBytes": 24461508,
"heapUsedBytes": 88558176,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 117.11799999999998,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667741935483864,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2025.5799999999908,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.216,
"layouts": 9,
"layoutDurationMs": 1.933,
"taskDurationMs": 475.412,
"heapDeltaBytes": -6373992,
"heapUsedBytes": 69272920,
"domNodes": -200,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 7.721,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2007.7509999999847,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.0660000000000003,
"layouts": 9,
"layoutDurationMs": 1.8739999999999999,
"taskDurationMs": 424.96500000000003,
"heapDeltaBytes": 9412568,
"heapUsedBytes": 71808020,
"domNodes": 0,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 6.987000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1710.2310000000216,
"styleRecalcs": 77,
"styleRecalcDurationMs": 13.124,
"layouts": 10,
"layoutDurationMs": 2.273,
"taskDurationMs": 773.424,
"heapDeltaBytes": -17308716,
"heapUsedBytes": 59689328,
"domNodes": -192,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 95.19800000000001,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.580999999971,
"styleRecalcs": 75,
"styleRecalcDurationMs": 12.412999999999998,
"layouts": 9,
"layoutDurationMs": 2.0809999999999995,
"taskDurationMs": 710.3000000000001,
"heapDeltaBytes": -9512000,
"heapUsedBytes": 53839460,
"domNodes": -200,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 90.831,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 1469.9719999999843,
"styleRecalcs": 20,
"styleRecalcDurationMs": 20.625999999999998,
"layouts": 5,
"layoutDurationMs": 14.514000000000003,
"taskDurationMs": 1107.2269999999999,
"heapDeltaBytes": 10608204,
"heapUsedBytes": 89962272,
"domNodes": -1320,
"jsHeapTotalBytes": 15728640,
"scriptDurationMs": 27.598,
"eventListeners": -262,
"totalBlockingTimeMs": 140,
"frameDurationMs": 19.26233766233766,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8993.42999999999,
"styleRecalcs": 250,
"styleRecalcDurationMs": 28.449,
"layouts": 8,
"layoutDurationMs": 1.6740000000000002,
"taskDurationMs": 4854.6230000000005,
"heapDeltaBytes": -20737904,
"heapUsedBytes": 73664820,
"domNodes": -274,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 2208.624,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665925925925926,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8829.269000000068,
"styleRecalcs": 251,
"styleRecalcDurationMs": 28.701000000000004,
"layouts": 10,
"layoutDurationMs": 2.2880000000000003,
"taskDurationMs": 4817.737,
"heapDeltaBytes": -7206024,
"heapUsedBytes": 74818452,
"domNodes": -274,
"jsHeapTotalBytes": 3760128,
"scriptDurationMs": 2172.866,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66622641509434,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 21101.516000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20211.186,
"heapDeltaBytes": 1084948,
"heapUsedBytes": 285355036,
"domNodes": -3482,
"jsHeapTotalBytes": 13090816,
"scriptDurationMs": 299.755,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.851308900523556,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-idle",
"durationMs": 21146.777000000042,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20379.152000000002,
"heapDeltaBytes": -9141344,
"heapUsedBytes": 273246580,
"domNodes": -3482,
"jsHeapTotalBytes": 16498688,
"scriptDurationMs": 282.143,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.90161290322581,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 24890.634999999973,
"styleRecalcs": 180,
"styleRecalcDurationMs": 23.299999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24442.747,
"heapDeltaBytes": -33060464,
"heapUsedBytes": 269601568,
"domNodes": -3482,
"jsHeapTotalBytes": 11522048,
"scriptDurationMs": 751.652,
"eventListeners": -659,
"totalBlockingTimeMs": 7,
"frameDurationMs": 46.627340823970044,
"p95FrameDurationMs": 100
},
{
"name": "vue-large-graph-pan",
"durationMs": 24804.89399999999,
"styleRecalcs": 181,
"styleRecalcDurationMs": 19.56100000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24407.399,
"heapDeltaBytes": -45071560,
"heapUsedBytes": 259254432,
"domNodes": -3482,
"jsHeapTotalBytes": 14663680,
"scriptDurationMs": 763.408,
"eventListeners": -659,
"totalBlockingTimeMs": 25,
"frameDurationMs": 46.99962121212121,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 7480.089999999962,
"styleRecalcs": 20,
"styleRecalcDurationMs": 45.44300000000001,
"layouts": 20,
"layoutDurationMs": 19.970000000000002,
"taskDurationMs": 7341.988,
"heapDeltaBytes": -28825164,
"heapUsedBytes": 275712724,
"domNodes": -3482,
"jsHeapTotalBytes": 15187968,
"scriptDurationMs": 105.69600000000001,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 44.01764705882353,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-node-resize-workload",
"durationMs": 7387.321999999926,
"styleRecalcs": 20,
"styleRecalcDurationMs": 45.904,
"layouts": 20,
"layoutDurationMs": 19.755999999999997,
"taskDurationMs": 7252.169,
"heapDeltaBytes": -10141004,
"heapUsedBytes": 286931768,
"domNodes": -3482,
"jsHeapTotalBytes": 21745664,
"scriptDurationMs": 105.827,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.42941176470589,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10650.823000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10311.018999999998,
"heapDeltaBytes": -20819544,
"heapUsedBytes": 266968244,
"domNodes": 0,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 138.40699999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.17060931899641,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10617.71800000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10296.582,
"heapDeltaBytes": -7124344,
"heapUsedBytes": 282458312,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 141.50199999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.734256055363325,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "workflow-execution",
"durationMs": 446.20700000001534,
"styleRecalcs": 17,
"styleRecalcDurationMs": 9.537,
"layouts": 12,
"layoutDurationMs": 3.954,
"taskDurationMs": 101.916,
"heapDeltaBytes": 7524056,
"heapUsedBytes": 68926968,
"domNodes": 108,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.139000000000001,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 92.73100000007162,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.361999999999999,
"layouts": 7,
"layoutDurationMs": 2.0220000000000002,
"taskDurationMs": 68.82700000000001,
"heapDeltaBytes": -13135420,
"heapUsedBytes": 61392308,
"domNodes": 124,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 4.055999999999999,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 289.3730000000687,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.585,
"layouts": 76,
"layoutDurationMs": 11.252,
"taskDurationMs": 257.492,
"heapDeltaBytes": -5264736,
"heapUsedBytes": 37679876,
"domNodes": 4,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 116.20800000000001,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 294.1920000000664,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.585,
"layouts": 76,
"layoutDurationMs": 11.555,
"taskDurationMs": 266.00700000000006,
"heapDeltaBytes": -5083976,
"heapUsedBytes": 39219548,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 121.07600000000001,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.661111111111115,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 338.8689999999315,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.582,
"layouts": 76,
"layoutDurationMs": 11.467,
"taskDurationMs": 304.907,
"heapDeltaBytes": -995408,
"heapUsedBytes": 101509956,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 109.099,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 355.6340000000091,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.616,
"layouts": 76,
"layoutDurationMs": 11.642,
"taskDurationMs": 325.473,
"heapDeltaBytes": -496248,
"heapUsedBytes": 99891160,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 114.661,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636382,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage: 🟡 59.1% of linesCoverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3239 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure
Findings and check detailsExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Full docs: scripts/registry-census/README.md Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
🌾 Fallow: ✅ PassedFindings and check detailsFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Full docs: ADR-DEVEX-LINT-0015 Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 71fe532dedc38fec80cf14e06428294c2c2fcb1b
🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (394)
Full docs: Frontend domain catalog Reproduce locallypnpm architecture:check |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.60 #23265 +/- ##
===============================================
+ Coverage 59.33% 87.55% +28.22%
===============================================
Files 2356 3029 +673
Lines 103544 164489 +60945
Branches 0 44354 +44354
===============================================
+ Hits 61434 144013 +82579
+ Misses 42110 19545 -22565
- Partials 0 931 +931
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2674 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…#23269) (#23270) Backport of #23269 to `cloud/1.60`. #23265 brought workflow-id links to `cloud/1.60`. Its self-review found problems in that code, and the self-reviews of #23269 and this PR found more. #23269 fixes them on `main`: - A file read that fails with a 500 no longer sends the file name to Sentry and Datadog. - A workflow-id link replaced by a newer link while its graph loads no longer shows its graph under the newer link's address. - The workflow that was open is then painted back. Its unsaved edits stay marked unsaved, and its outputs and preview images stay. That repaint does not replace a newer load, such as a pasted workflow. - A newer link held by the sign-in guard is no longer cancelled by the older URL's Settings cleanup. - A skipped repaint no longer clears the unsaved mark of an edit still open in the expanded text editor, so the draft and the reload warning stay. - A preview frame that arrives while a replaced open loads is kept, instead of the repaint showing an older frame. - An open replaced during an extension's `afterConfigureGraph` hook stops before it activates. - A preview frame for a node inside a subgraph that arrives while a replaced open loads is no longer kept in memory under the other workflow's subgraph. That node shows the next frame instead. **Why**: #23265 put this code on `cloud/1.60`, so the file name in failed-read error reports and the other bugs above are on that branch too. Waiting for #23269 to merge before backporting would leave them there longer. The first three commits are cherry-picked with `-x`. One conflict: `workflowService.test.ts` keeps `cloud/1.60`'s tests and adds only the new failed-read test. The next three commits follow #23269's repaint fixes. `cloud/1.60` has no canvas ownership tracking, so the workflow service keeps one flag for whether the canvas still shows the selected workflow. The next four commits are cherry-picked from #23269's later fixes; their tests drop the canvas ownership calls that `cloud/1.60` does not have. One more commit makes the saved-baseline test run the outgoing load first: before, the repaint never ran in that test, so it passed without the fix. Each new test failed with its fix reverted and passes with it on this branch. Linear: https://linear.app/comfyorg/issue/DPLAT-3900 Not run: browser e2e (`browser_tests/tests/workflow/cloudWorkflowLink.spec.ts`).
## Summary A workflow-id link whose file read fails (the server returns 500) sent the file name, for example `workflows/Customer Jane Doe.json`, to Sentry and Datadog. The file read's error named the path, and the workflow load queue reported that error before the link loader could replace it with a fixed message. Now the error carries only the status: `Failed to load file: 500 Internal Server Error`. Open link A to a workflow with a Load3D node, then link B while A is still loading: A's graph appeared on the canvas under B's address. Load3D loads its code before the graph is set up, and the open did not check again after that wait. Now `loadGraphData` checks that the open is still current after that wait. A replaced open stops before the graph is set up, and the workflow that was open is painted back. That repaint keeps its saved state, so unsaved edits stay marked unsaved. It keeps its outputs and preview images. It is skipped when a newer load, such as a pasted workflow, has taken the canvas. A graph load whose open was replaced while it waited in the queue now skips without touching the canvas. Open link A that also has `settings=plan-credits`, then link B that the sign-in guard holds: B never opened. After A's URL cleanup was cancelled, the Settings loader replaced the URL with A's query. That wrote A over B's saved link and cancelled B's navigation. Now, while a newer link waits, the loaders after the workflow-id link (Settings, top-up, pricing, invite, assets, local handoff) and the final sweep do not run, so B lands. Their params stay saved for the next page load. Type in the expanded text editor, then open link A and link B before A's graph load starts: the workflow lost its unsaved mark. The draft saver then deleted the unsaved copy, and reloading the page no longer warned, so the text was lost. The editor marks the workflow unsaved without recording the edit, and the skipped repaint reset that mark. Now a repaint that is skipped leaves the workflow as it was. The saved state is put back only when the repaint ran. A running workflow's node preview could go back to an older frame after a replaced open. A frame that arrived while the replaced open was loading was dropped, and the repaint showed the frame stored before it. Now that frame is added to the stored previews and wins over the older one. An open replaced while an extension's `afterConfigureGraph` hook ran still activated its workflow. Now the load checks again after that hook, stops, and the workflow that was open is painted back. A preview frame for a node inside a subgraph that arrived while a replaced open loaded was kept under the other workflow's subgraph. The running workflow's later frames never replaced it, so its image stayed in memory. Now the repaint drops previews for subgraphs the workflow does not have, and that node shows the next frame. **Why**: the self-review of the `cloud/1.60` backport (Comfy-Org#23265) found the first three. The self-reviews of this PR and Comfy-Org#23270 found the unsaved mark and the preview frame, and CodeRabbit found the `afterConfigureGraph` case. The same code is on `main`. Ref DPLAT-3900 ## Verification Tested (focused vitest files; each new test failed with its fix reverted and passes with it): - `src/platform/workflow/core/services/workflowService.test.ts`: "reports the failed read without the file name" (real workflow service and file store, HTTP 500). - `src/scripts/app.test.ts`: "does not configure or activate a graph whose load stopped being current during beforeConfigureGraph". - `src/platform/workflow/core/services/workflowService.test.ts`: "keeps the current workflow when the open is superseded while its graph loads". - `src/platform/workflow/core/services/workflowService.test.ts`: "keeps the saved baseline of a modified workflow kept by a superseded open", "keeps the outputs and previews of a workflow kept by a superseded open", "keeps a workflow pasted while a superseded open was loading". - `src/scripts/app.test.ts`: "leaves the canvas untouched for a load that stopped being current while it waited its turn". - `src/platform/workflow/core/services/workflowService.test.ts`: "keeps an uncaptured edit modified when a superseded open skips restoring its workflow", "keeps a preview that arrived while a superseded open was loading". - `src/stores/nodeOutputStore.workflowSwitch.test.ts`: "adds a frame that arrived while the workflow was off the canvas to its stash". - `src/scripts/app.test.ts`: "does not activate a graph whose load stopped being current during afterConfigureGraph". - `src/platform/workflow/core/services/workflowService.test.ts`: "does not keep a subgraph preview resolved against a superseded open". - "reports the failed read without the file name" now also checks the error's `cause`. It fails when the path is put in the cause, and passes on this code. - `src/platform/workflow/management/composables/useWorkflowLinkUrlLoader.test.ts`: "lets a newer link held in a navigation guard land when the older link also opens Settings" (real router, query tracker and Settings loader; only the Settings dialog is mocked). - Also passing: `src/stores/userFileStore.test.ts`, `src/composables/useUrlActionLoaders.test.ts`, `src/platform/settings/composables/useSettingsUrlLoader.test.ts`, `src/platform/settings/composables/useSettingsUrlLoader.integration.test.ts`. Not run: browser e2e (`browser_tests/tests/workflow/cloudWorkflowLink.spec.ts`).
Backport of #23051 and #23245 to
cloud/1.60.A
?workflowId=link opens the saved workflow it names on Comfy Cloud (#23051). #23245 fixes six ways that loader goes wrong: a newer link held by sign-in was cancelled, a file read or parser error reached error reports with the user's file name, an empty?workflowId=stayed pending with no message, a custom node's error name reached reports, a newer malformed link was cancelled, and an empty link held by a guard could be cancelled.The backport bot hit conflicts on #23051, so this copy was made by hand, in three commits:
packages/ingest-types/src/types.gen.tsandzod.gen.tskeepcloud/1.60's generated files and add only the sidebar-file route lines feat: Workflow-id links open the saved workflow on Comfy Cloud #23051 added (the same 70 and 25 lines). Every other file applied cleanly.cloud/1.60's architecture check (fallow): the redirect round-trip test moved frompreservedQueryDefinitions.test.tstopreservedQueryTracker.test.ts. The definitions test's zone may not import the query manager or tracker; the tracker test's zone may. [backport cloud/1.59] feat: Workflow-id links open the saved workflow on Comfy Cloud (#23051) #23239 made the same move oncloud/1.59. The test is unchanged.The loader, its test and the ADR are the same as on
main.cloud/1.60hasmain's package layout (@comfyorg/telemetry, the sharedreportErrormock), so none of #23239's othercloud/1.59changes were needed.No suppressions and no baseline edits.
fallow auditon the change: no new findings. Not run locally: unit tests, lint, typecheck and the browser tests. CI runs them.