Skip to content

FRONT-3796 refactor(account-core): move Billing tab section rules into the billing SDK - #22746

Merged
dante01yoon merged 1 commit into
mainfrom
dante/front-3796-billing-tab-rules
Nov 3, 2026
Merged

dante01yoon merged 1 commit into
mainfrom
dante/front-3796-billing-tab-rules

Conversation

@dante01yoon

@dante01yoon dante01yoon commented Nov 2, 2026 •

Copy link
Copy Markdown
Collaborator

Why

The ComfyUI Billing tab and Platform billing implement the same sections twice, so every rule change lands as two PRs and drifts. Agreed in #proj-billing: rules and UI move into the Billing SDK, ComfyUI being the default look and Platform overriding styling. This is the first step: the framework-free section rules move into @comfyorg/account-core/billing so account-ui (FRONT-3797) and Platform (FRONT-3801) can consume them.

How

  • Moved with their tests, unchanged in logic, into packages/account-core/src/core/billing/billingTab/: planRow, planLifecycle, creditsCard, planCheckoutBanner, topupCheckoutBanner. Exported from @comfyorg/account-core/billing.
  • Extracted the auto top-up card state derivation from useBillingAutoTopUpCard as deriveAutoTopUpCard({ isLoading, settings }) (same precedence: served settings win, else loading, else unavailable), with a table test. The scoped auto top-up reader stays in the app; it moves with FRONT-3650 feat(account-core): auto top-up reader, save and preview in the billing SDK #22413 (FRONT-3650).
  • No new package dependency: billing-core type aliases are replaced by the ingest-types types they re-export, and deriveCreditsCard takes a structural CreditsCardBalance instead of the app's BalanceInfo (which satisfies it).
  • App components and composables only rewire imports to the package; nothing is duplicated. Moving the remaining consumers is FRONT-3799.
  • Inputs stay served facts as received, outputs discriminated view states; no role/tier/isCloud checks (lint:server-facts clean).

Dependency graph

flowchart LR
  F3650[FRONT-3650 auto top-up reader in SDK #22413] --> F3796
  F3796 --> M4[Unmerged PRs rebuilt on the SDK: #22696 #22711 #22437 #22435 #22431 #22717]
  F3796[FRONT-3796 account-core rules] --> F3797[FRONT-3797 account-ui components]
  F3796 --> F3799[FRONT-3799 Migration: ComfyUI reads SDK rules]
  F3797 --> F3798[FRONT-3798 Publish to npm]
  F3796 --> F3798
  F3797 --> F3800[FRONT-3800 Migration: ComfyUI renders account-ui]
  F3799 --> F3800
  F3798 --> F3801[FRONT-3801 Integration: Platform billing]
  DPLAT[DPLAT-2852 Platform reads via SDK #1547 #1518] --> F3801
  F3793[FRONT-3793 Add credits dialog package] -. same package home .- F3797
Loading

AS IS / TO BE

No UI change: a module move with behaviour unchanged. Covered by the moved rule tests (account-core: 100 files, 1896 tests) and the Billing tab component tests (src/platform/billing, settings: 135 files, 3395 tests), all passing.

  • Fixes FRONT-3796

After the SDK rebuild

Rendered from the stack top (e6202d5), behaviour unchanged by the rebuild unless noted.

State Render
plan-active
credits-plan
autotopup-on
banner-plan-verify-payment
banner-topup-processing

No UI change; same render after the move.

…ng SDK

Move planRow, planLifecycle, creditsCard, planCheckoutBanner and
topupCheckoutBanner with their tests into
@comfyorg/account-core/billing, and extract the auto top-up card state
derivation as deriveAutoTopUpCard. The credits card now takes a
structural CreditsCardBalance instead of the app BalanceInfo type; the
billing-core aliases are replaced by the ingest-types they re-export.
App composables and components import from the package; behaviour is
unchanged.
@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle: 12.1 MB gzip 🔴 +155 B

Details

Summary

  • Raw size: 54.2 MB baseline 54.2 MB — 🔴 +304 B
  • Gzip: 12.1 MB baseline 12.1 MB — 🔴 +155 B
  • Brotli: 9.48 MB baseline 9.48 MB — 🔴 +149 B
  • Bundles: 1009 current • 1009 baseline • 76 added / 76 removed

Category Glance
Utilities & Hooks 🔴 +269 B (2.43 MB) · Other 🔴 +35 B (35.5 MB) · Vendor & Third-Party ⚪ 0 B (9.7 MB) · Graph Workspace ⚪ 0 B (2.64 MB) · Data & Services ⚪ 0 B (1.98 MB) · Panels & Settings ⚪ 0 B (880 kB) · + 5 more

App Entry Points — 6.71 kB (baseline 6.71 kB) • ⚪ 0 B

Main entry bundles and manifests

File Before After Δ Raw Δ Gzip Δ Brotli
assets/index-DdK9JFyO.js (new) — 6.71 kB 🔴 +6.71 kB 🔴 +3.4 kB 🔴 +2.87 kB
assets/index-DZmkgKdw.js (removed) 6.71 kB — 🟢 -6.71 kB 🟢 -3.41 kB 🟢 -2.83 kB

Status: 1 added / 1 removed

Graph Workspace — 2.64 MB (baseline 2.64 MB) • ⚪ 0 B

Graph editor runtime, canvas, workflow orchestration

File Before After Δ Raw Δ Gzip Δ Brotli
assets/GraphView-Bvu9o-ue.js (removed) 2.62 MB — 🟢 -2.62 MB 🟢 -576 kB 🟢 -420 kB
assets/GraphView-DVQpgbOA.js (new) — 2.62 MB 🔴 +2.62 MB 🔴 +576 kB 🔴 +420 kB
assets/WidgetCompositor-BGi2NCpg.js (new) — 8.13 kB 🔴 +8.13 kB 🔴 +2.62 kB 🔴 +2.35 kB
assets/WidgetCompositor-DRguF1pV.js (removed) 8.13 kB — 🟢 -8.13 kB 🟢 -2.63 kB 🟢 -2.35 kB

Status: 2 added / 2 removed / 2 unchanged

Views & Navigation — 148 kB (baseline 148 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

File Before After Δ Raw Δ Gzip Δ Brotli
assets/WidgetResolutionPreview-DciyJ_PP.js (removed) 3.88 kB — 🟢 -3.88 kB 🟢 -1.53 kB 🟢 -1.37 kB
assets/WidgetResolutionPreview-DTYqStWn.js (new) — 3.88 kB 🔴 +3.88 kB 🔴 +1.53 kB 🔴 +1.37 kB

Status: 1 added / 1 removed / 17 unchanged

Panels & Settings — 880 kB (baseline 880 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

File Before After Δ Raw Δ Gzip Δ Brotli
assets/CrdtDevPanel-BAf_2mji.js (removed) 85.3 kB — 🟢 -85.3 kB 🟢 -24.5 kB 🟢 -21.1 kB
assets/CrdtDevPanel-DLQtEbPD.js (new) — 85.3 kB 🔴 +85.3 kB 🔴 +24.5 kB 🔴 +21.2 kB
assets/CreditsPanel-B976wEC0.js (removed) 41.3 kB — 🟢 -41.3 kB 🟢 -9.37 kB 🟢 -8.19 kB
assets/CreditsPanel-DfPfDPEM.js (new) — 41.3 kB 🔴 +41.3 kB 🔴 +9.37 kB 🔴 +8.19 kB
assets/agentPanel-B5WJs_w7.js (removed) 13.6 kB — 🟢 -13.6 kB 🟢 -3.77 kB 🟢 -3.36 kB
assets/agentPanel-CoCIgluz.js (new) — 13.6 kB 🔴 +13.6 kB 🔴 +3.77 kB 🔴 +3.36 kB
assets/DockedAgentPanel-B6UySo0f.js (new) — 13.4 kB 🔴 +13.4 kB 🔴 +5.89 kB 🔴 +4.98 kB
assets/DockedAgentPanel-CpLOqTXr.js (removed) 13.4 kB — 🟢 -13.4 kB 🟢 -5.89 kB 🟢 -4.96 kB
assets/CreditsPanel-CcQBZDDg.js (new) — 116 B 🔴 +116 B 🔴 +95 B 🔴 +85 B
assets/CreditsPanel-RmcP5dU0.js (removed) 116 B — 🟢 -116 B 🟢 -95 B 🟢 -91 B

Status: 5 added / 5 removed / 30 unchanged

User & Accounts — 108 kB (baseline 108 kB) • ⚪ 0 B

Authentication, profile, and account management bundles

Status: 18 unchanged

Editors & Dialogs — 502 kB (baseline 502 kB) • ⚪ 0 B

Modals, dialogs, drawers, and in-app editors

File Before After Δ Raw Δ Gzip Δ Brotli
assets/ComfyHubPublishDialog-BfXOoHWM.js (removed) 86.9 kB — 🟢 -86.9 kB 🟢 -18.6 kB 🟢 -16 kB
assets/ComfyHubPublishDialog-DYbb9OZS.js (new) — 86.9 kB 🔴 +86.9 kB 🔴 +18.6 kB 🔴 +16 kB
assets/BoundingBoxesEditor-8djoePqs.js (new) — 45.3 kB 🔴 +45.3 kB 🔴 +12.2 kB 🔴 +10.6 kB
assets/BoundingBoxesEditor-DSStJBFg.js (removed) 45.3 kB — 🟢 -45.3 kB 🟢 -12.2 kB 🟢 -10.7 kB
assets/useShareDialog-BNy9sNFH.js (new) — 23.7 kB 🔴 +23.7 kB 🔴 +5.63 kB 🔴 +5 kB
assets/useShareDialog-DcFsPfjf.js (removed) 23.7 kB — 🟢 -23.7 kB 🟢 -5.63 kB 🟢 -5.01 kB
assets/layerEditorDialog-CIVGwGAd.js (new) — 7.78 kB 🔴 +7.78 kB 🔴 +3.69 kB 🔴 +3.15 kB
assets/layerEditorDialog-DTYkqyjL.js (removed) 7.78 kB — 🟢 -7.78 kB 🟢 -3.69 kB 🟢 -3.14 kB
assets/useComfyHubPublishDialog--bz-bZBA.js (new) — 6.42 kB 🔴 +6.42 kB 🔴 +3.21 kB 🔴 +2.72 kB
assets/useComfyHubPublishDialog-CM_BvYA8.js (removed) 6.42 kB — 🟢 -6.42 kB 🟢 -3.21 kB 🟢 -2.73 kB
assets/boundingBoxesDialog-9rCq6IfR.js (removed) 4.79 kB — 🟢 -4.79 kB 🟢 -1.67 kB 🟢 -1.46 kB
assets/boundingBoxesDialog-DqNJbql_.js (new) — 4.79 kB 🔴 +4.79 kB 🔴 +1.67 kB 🔴 +1.46 kB
assets/useLayerEditor-BtILVhOA.js (removed) 1.25 kB — 🟢 -1.25 kB 🟢 -562 B 🟢 -490 B
assets/useLayerEditor-D859wHgs.js (new) — 1.25 kB 🔴 +1.25 kB 🔴 +562 B 🔴 +490 B

Status: 7 added / 7 removed / 10 unchanged

UI Components — 359 kB (baseline 359 kB) • ⚪ 0 B

Reusable component library chunks

File Before After Δ Raw Δ Gzip Δ Brotli
assets/useMoreOptionsMenu-DN7ndlSr.js (removed) 64.5 kB — 🟢 -64.5 kB 🟢 -16.2 kB 🟢 -14 kB
assets/useMoreOptionsMenu-dXkLO1xl.js (new) — 64.5 kB 🔴 +64.5 kB 🔴 +16.2 kB 🔴 +14 kB
assets/WorkflowNeedsDeploymentCard-C02r7x3Y.js (new) — 12.3 kB 🔴 +12.3 kB 🔴 +3.58 kB 🔴 +3.21 kB
assets/WorkflowNeedsDeploymentCard-dcMD5-RV.js (removed) 12.3 kB — 🟢 -12.3 kB 🟢 -3.58 kB 🟢 -3.21 kB

Status: 2 added / 2 removed / 30 unchanged

Data & Services — 1.98 MB (baseline 1.98 MB) • ⚪ 0 B

Stores, services, APIs, and repositories

File Before After Δ Raw Δ Gzip Δ Brotli
assets/agentRunModeStore-DrlHxtyc.js (new) — 34.2 kB 🔴 +34.2 kB 🔴 +11.9 kB 🔴 +10.2 kB
assets/agentRunModeStore-DuTFSf60.js (removed) 34.2 kB — 🟢 -34.2 kB 🟢 -11.9 kB 🟢 -10.2 kB
assets/workflowShareService-Bf_zYWHj.js (new) — 17.5 kB 🔴 +17.5 kB 🔴 +5.13 kB 🔴 +4.55 kB
assets/workflowShareService-gJjkEYhP.js (removed) 17.5 kB — 🟢 -17.5 kB 🟢 -5.13 kB 🟢 -4.55 kB
assets/load3dService-BW5H2ugW.js (new) — 9.01 kB 🔴 +9.01 kB 🔴 +3.9 kB 🔴 +3.32 kB
assets/load3dService-F1v8baMD.js (removed) 9.01 kB — 🟢 -9.01 kB 🟢 -3.91 kB 🟢 -3.31 kB

Status: 3 added / 3 removed / 41 unchanged

Utilities & Hooks — 2.43 MB (baseline 2.43 MB) • 🔴 +269 B

Helpers, composables, and utility bundles

File Before After Δ Raw Δ Gzip Δ Brotli
assets/useLayerEditorSession-CJOeqvDR.js (removed) 159 kB — 🟢 -159 kB 🟢 -40.8 kB 🟢 -34.5 kB
assets/useLayerEditorSession-HpctVm8w.js (new) — 159 kB 🔴 +159 kB 🔴 +40.8 kB 🔴 +34.5 kB
assets/useConflictDetection-BBSEXXo3.js (new) — 93.2 kB 🔴 +93.2 kB 🔴 +23.8 kB 🔴 +20.6 kB
assets/useConflictDetection-hXkJKFeA.js (removed) 93.2 kB — 🟢 -93.2 kB 🟢 -23.8 kB 🟢 -20.7 kB
assets/useBillingDialogs-Bp50U2wD.js (new) — 80.1 kB 🔴 +80.1 kB 🔴 +20.7 kB 🔴 +17.4 kB
assets/useBillingDialogs-Iw1TTwUN.js (removed) 79.8 kB — 🟢 -79.8 kB 🟢 -20.6 kB 🟢 -17.3 kB
assets/useLoad3d-BE_TAEDS.js (new) — 32.2 kB 🔴 +32.2 kB 🔴 +7.44 kB 🔴 +6.65 kB
assets/useLoad3d-CXfio_P8.js (removed) 32.2 kB — 🟢 -32.2 kB 🟢 -7.44 kB 🟢 -6.65 kB
assets/useVideoSourceUrl-BTk58gkZ.js (new) — 19 kB 🔴 +19 kB 🔴 +5.65 kB 🔴 +5.03 kB
assets/useVideoSourceUrl-FQPRH20W.js (removed) 19 kB — 🟢 -19 kB 🟢 -5.65 kB 🟢 -5.03 kB
assets/useImageCrop-auiHsjBo.js (new) — 15.5 kB 🔴 +15.5 kB 🔴 +3.64 kB 🔴 +3.19 kB
assets/useImageCrop-BVj-ZLy5.js (removed) 15.5 kB — 🟢 -15.5 kB 🟢 -3.64 kB 🟢 -3.18 kB
assets/useCompositorLayers-CtC8LjlA.js (removed) 3.02 kB — 🟢 -3.02 kB 🟢 -888 B 🟢 -817 B
assets/useCompositorLayers-DtVkEsGR.js (new) — 3.02 kB 🔴 +3.02 kB 🔴 +890 B 🔴 +815 B
assets/useLiveGraphNode-BPxibW87.js (removed) 653 B — 🟢 -653 B 🟢 -383 B 🟢 -334 B
assets/useLiveGraphNode-D_MBcHx3.js (new) — 653 B 🔴 +653 B 🔴 +380 B 🔴 +341 B
assets/useWidgetHostNode-DtyFT4wq.js (removed) 619 B — 🟢 -619 B 🟢 -363 B 🟢 -343 B
assets/useWidgetHostNode-Dw9GTicK.js (new) — 619 B 🔴 +619 B 🔴 +364 B 🔴 +327 B
assets/useLoad3d-6bScZOTG.js (removed) 364 B — 🟢 -364 B 🟢 -179 B 🟢 -160 B
assets/useLoad3d-C2eLEHsI.js (new) — 364 B 🔴 +364 B 🔴 +179 B 🔴 +158 B

Status: 10 added / 10 removed / 71 unchanged

Vendor & Third-Party — 9.7 MB (baseline 9.7 MB) • ⚪ 0 B

External libraries and shared vendor chunks

Status: 16 unchanged

Other — 35.5 MB (baseline 35.5 MB) • 🔴 +35 B

Bundles that do not match a named category

File Before After Δ Raw Δ Gzip Δ Brotli
assets/AgentPanelRoot-BY2MbpEC.js (new) — 752 kB 🔴 +752 kB 🔴 +182 kB 🔴 +145 kB
assets/AgentPanelRoot-DdxVUdPj.js (removed) 752 kB — 🟢 -752 kB 🟢 -182 kB 🟢 -145 kB
assets/app-D1VDeukD.js (new) — 467 kB 🔴 +467 kB 🔴 +123 kB 🔴 +100 kB
assets/app-DIoeLWVr.js (removed) 467 kB — 🟢 -467 kB 🟢 -123 kB 🟢 -100 kB
assets/core-Dk3RCw5S.js (removed) 154 kB — 🟢 -154 kB 🟢 -39.7 kB 🟢 -32.9 kB
assets/core-SJzDJQnx.js (new) — 154 kB 🔴 +154 kB 🔴 +39.7 kB 🔴 +32.9 kB
assets/WorkspaceSettingsPanelContent-DeteDj9q.js (new) — 106 kB 🔴 +106 kB 🔴 +20.9 kB 🔴 +17.9 kB
assets/WorkspaceSettingsPanelContent-yoao1v0l.js (removed) 106 kB — 🟢 -106 kB 🟢 -20.9 kB 🟢 -17.9 kB
assets/BillingTab-BIR4w0Ku.js (new) — 87.3 kB 🔴 +87.3 kB 🔴 +17.7 kB 🔴 +15 kB
assets/BillingTab-c-ing9SI.js (removed) 87.3 kB — 🟢 -87.3 kB 🟢 -17.6 kB 🟢 -15 kB
assets/main-BQ55fcaA.js (removed) 85.5 kB — 🟢 -85.5 kB 🟢 -25.6 kB 🟢 -21.6 kB
assets/main-CwQX8rkJ.js (new) — 85.5 kB 🔴 +85.5 kB 🔴 +25.7 kB 🔴 +21.7 kB
assets/Load3D-CSU6poMG.js (removed) 84.8 kB — 🟢 -84.8 kB 🟢 -13.9 kB 🟢 -11.7 kB
assets/Load3D-DqQmtVxD.js (new) — 84.8 kB 🔴 +84.8 kB 🔴 +13.9 kB 🔴 +11.7 kB
assets/firstRunEntry-CIOiG_mr.js (removed) 63.2 kB — 🟢 -63.2 kB 🟢 -17.5 kB 🟢 -15.2 kB
assets/firstRunEntry-kPKeJ9mQ.js (new) — 63.2 kB 🔴 +63.2 kB 🔴 +17.5 kB 🔴 +15.2 kB
assets/WidgetVideoEdit-Bjt3rnzK.js (new) — 57.4 kB 🔴 +57.4 kB 🔴 +13 kB 🔴 +11.5 kB
assets/WidgetVideoEdit-DyfHI2jg.js (removed) 57.4 kB — 🟢 -57.4 kB 🟢 -13 kB 🟢 -11.5 kB
assets/restoreOpMinter-B0AGEqci.js (new) — 47.1 kB 🔴 +47.1 kB 🔴 +12.9 kB 🔴 +11.3 kB
assets/restoreOpMinter-DihzJ-zE.js (removed) 47.1 kB — 🟢 -47.1 kB 🟢 -12.9 kB 🟢 -11.3 kB
assets/LayerEditorContent-BmqUBket.js (new) — 44.6 kB 🔴 +44.6 kB 🔴 +10.5 kB 🔴 +9.21 kB
assets/LayerEditorContent-knfm1E1y.js (removed) 44.6 kB — 🟢 -44.6 kB 🟢 -10.5 kB 🟢 -9.2 kB
assets/LightInfo-BILEvVbT.js (new) — 44 kB 🔴 +44 kB 🔴 +11.1 kB 🔴 +9.82 kB
assets/LightInfo-BR7afaaP.js (removed) 44 kB — 🟢 -44 kB 🟢 -11.1 kB 🟢 -9.8 kB
assets/CameraInfo-CBNbgpfR.js (new) — 42.2 kB 🔴 +42.2 kB 🔴 +10.2 kB 🔴 +8.99 kB
assets/CameraInfo-Ymy5MyHi.js (removed) 42.2 kB — 🟢 -42.2 kB 🟢 -10.2 kB 🟢 -9 kB
assets/WidgetPainter-5zWBIih4.js (removed) 41.7 kB — 🟢 -41.7 kB 🟢 -10.4 kB 🟢 -9.23 kB
assets/WidgetPainter-Cn6bmNuD.js (new) — 41.7 kB 🔴 +41.7 kB 🔴 +10.4 kB 🔴 +9.21 kB
assets/floating-ui.vue-6ONCM-Jk.js (new) — 34.5 kB 🔴 +34.5 kB 🔴 +9.88 kB 🔴 +8.7 kB
assets/floating-ui.vue-CsWDkYbF.js (removed) 34.5 kB — 🟢 -34.5 kB 🟢 -9.88 kB 🟢 -8.7 kB
assets/Load3dViewerContent-DV68T7tM.js (new) — 31.2 kB 🔴 +31.2 kB 🔴 +6.19 kB 🔴 +5.36 kB
assets/Load3dViewerContent-kiuzMnxQ.js (removed) 31.2 kB — 🟢 -31.2 kB 🟢 -6.18 kB 🟢 -5.36 kB
assets/BillingStatusBanner-CAYrVoht.js (removed) 31.1 kB — 🟢 -31.1 kB 🟢 -7.77 kB 🟢 -6.9 kB
assets/BillingStatusBanner-CwC8a7Lr.js (new) — 31.1 kB 🔴 +31.1 kB 🔴 +7.77 kB 🔴 +6.9 kB
assets/WidgetVideoConcat-C5_j4QFM.js (new) — 30 kB 🔴 +30 kB 🔴 +8.21 kB 🔴 +7.31 kB
assets/WidgetVideoConcat-CWjM9GdV.js (removed) 30 kB — 🟢 -30 kB 🟢 -8.21 kB 🟢 -7.31 kB
assets/CameraAngle-CczT9inX.js (removed) 27.9 kB — 🟢 -27.9 kB 🟢 -8.07 kB 🟢 -7.14 kB
assets/CameraAngle-COB-ubVu.js (new) — 27.9 kB 🔴 +27.9 kB 🔴 +8.07 kB 🔴 +7.14 kB
assets/ShareAssetWarningBox-B2JnXWi4.js (removed) 25.7 kB — 🟢 -25.7 kB 🟢 -7.67 kB 🟢 -6.55 kB
assets/ShareAssetWarningBox-D01xMb1s.js (new) — 25.7 kB 🔴 +25.7 kB 🔴 +7.67 kB 🔴 +6.56 kB
assets/openWorkflowForCheck-rUpwnDhi.js (removed) 23.1 kB — 🟢 -23.1 kB 🟢 -7.01 kB 🟢 -6.23 kB
assets/openWorkflowForCheck-sY_EZhWs.js (new) — 23.1 kB 🔴 +23.1 kB 🔴 +7.01 kB 🔴 +6.24 kB
assets/ui-BawIQ9uX.js (new) — 21.8 kB 🔴 +21.8 kB 🔴 +6.11 kB 🔴 +5.29 kB
assets/ui-Dvqz4_YR.js (removed) 21.8 kB — 🟢 -21.8 kB 🟢 -6.11 kB 🟢 -5.29 kB
assets/WidgetRecordAudio-80DRLAty.js (removed) 16.3 kB — 🟢 -16.3 kB 🟢 -4.52 kB 🟢 -4.04 kB
assets/WidgetRecordAudio-DUDQ52uT.js (new) — 16.3 kB 🔴 +16.3 kB 🔴 +4.52 kB 🔴 +4.05 kB
assets/load3d-cX-NTjki.js (new) — 15.2 kB 🔴 +15.2 kB 🔴 +3.75 kB 🔴 +3.28 kB
assets/load3d-Hz9V22L2.js (removed) 15.2 kB — 🟢 -15.2 kB 🟢 -3.75 kB 🟢 -3.27 kB
assets/WidgetRange-CqTLO_sM.js (removed) 15 kB — 🟢 -15 kB 🟢 -3.93 kB 🟢 -3.48 kB
assets/WidgetRange-DSfZoT5G.js (new) — 15 kB 🔴 +15 kB 🔴 +3.93 kB 🔴 +3.48 kB
assets/WidgetCurve--zpDpLyz.js (new) — 12.5 kB 🔴 +12.5 kB 🔴 +3.86 kB 🔴 +3.48 kB
assets/WidgetCurve-CvMcW7pD.js (removed) 12.5 kB — 🟢 -12.5 kB 🟢 -3.85 kB 🟢 -3.48 kB
assets/WidgetTextarea-BcbKqU3Y.js (removed) 11.9 kB — 🟢 -11.9 kB 🟢 -3.73 kB 🟢 -3.32 kB
assets/WidgetTextarea-DJZVerNz.js (new) — 11.9 kB 🔴 +11.9 kB 🔴 +3.73 kB 🔴 +3.31 kB
assets/createViewport3d-DG3LKkp2.js (new) — 11.9 kB 🔴 +11.9 kB 🔴 +3.54 kB 🔴 +3.21 kB
assets/createViewport3d-DnWWuMqD.js (removed) 11.9 kB — 🟢 -11.9 kB 🟢 -3.54 kB 🟢 -3.21 kB
assets/nodeTemplates-CaPHXMqW.js (new) — 10.6 kB 🔴 +10.6 kB 🔴 +3.45 kB 🔴 +3.02 kB
assets/nodeTemplates-xZfG3fC4.js (removed) 10.6 kB — 🟢 -10.6 kB 🟢 -3.45 kB 🟢 -3.02 kB
assets/WidgetImageCrop-CJ9bK1uO.js (new) — 9.5 kB 🔴 +9.5 kB 🔴 +2.95 kB 🔴 +2.62 kB
assets/WidgetImageCrop-CpyrLd9-.js (removed) 9.5 kB — 🟢 -9.5 kB 🟢 -2.95 kB 🟢 -2.62 kB
assets/WidgetImageCompare-CA7hWVsP.js (removed) 8.97 kB — 🟢 -8.97 kB 🟢 -2.63 kB 🟢 -2.33 kB
assets/WidgetImageCompare-CZkNO3RV.js (new) — 8.97 kB 🔴 +8.97 kB 🔴 +2.63 kB 🔴 +2.33 kB
assets/async-BzBUjHsp.js (new) — 8.23 kB 🔴 +8.23 kB 🔴 +3.3 kB 🔴 +2.83 kB
assets/async-CTrfuILj.js (removed) 8.23 kB — 🟢 -8.23 kB 🟢 -3.3 kB 🟢 -2.83 kB
assets/WidgetBoundingBoxes-D_LUDIMU.js (new) — 7.2 kB 🔴 +7.2 kB 🔴 +3.55 kB 🔴 +3.01 kB
assets/WidgetBoundingBoxes-DvGqLaXj.js (removed) 7.2 kB — 🟢 -7.2 kB 🟢 -3.55 kB 🟢 -3.02 kB
assets/load3dPreviewExtensions-B9S7VssG.js (new) — 6.69 kB 🔴 +6.69 kB 🔴 +1.94 kB 🔴 +1.72 kB
assets/load3dPreviewExtensions-CtnRdeDC.js (removed) 6.69 kB — 🟢 -6.69 kB 🟢 -1.94 kB 🟢 -1.73 kB
assets/WidgetBoundingBox-Db8d9Q5J.js (removed) 4.67 kB — 🟢 -4.67 kB 🟢 -1.44 kB 🟢 -1.29 kB
assets/WidgetBoundingBox-N8tCCMt8.js (new) — 4.67 kB 🔴 +4.67 kB 🔴 +1.44 kB 🔴 +1.29 kB
assets/saveMesh-BaOIt1z7.js (removed) 3.61 kB — 🟢 -3.61 kB 🟢 -1.14 kB 🟢 -1.01 kB
assets/saveMesh-BPUQS9Bt.js (new) — 3.61 kB 🔴 +3.61 kB 🔴 +1.14 kB 🔴 +1.01 kB
assets/widgetHistoryScope-BlDyjD8M.js (new) — 2.66 kB 🔴 +2.66 kB 🔴 +1.01 kB 🔴 +908 B
assets/widgetHistoryScope-Cv-csBih.js (removed) 2.66 kB — 🟢 -2.66 kB 🟢 -1.01 kB 🟢 -905 B
assets/WidgetColors-BhFKlwP9.js (new) — 2.66 kB 🔴 +2.66 kB 🔴 +1.14 kB 🔴 +1.04 kB
assets/WidgetColors-BQO_B_VE.js (removed) 2.66 kB — 🟢 -2.66 kB 🟢 -1.14 kB 🟢 -1.04 kB
assets/load3dAdvanced-CNh8xeq4.js (removed) 2.2 kB — 🟢 -2.2 kB 🟢 -859 B 🟢 -756 B
assets/load3dAdvanced-p4fDY6EQ.js (new) — 2.2 kB 🔴 +2.2 kB 🔴 +858 B 🔴 +756 B
assets/widgetInputSource-CV7lQsAP.js (new) — 1.46 kB 🔴 +1.46 kB 🔴 +612 B 🔴 +531 B
assets/widgetInputSource-WsVkh6Vq.js (removed) 1.46 kB — 🟢 -1.46 kB 🟢 -611 B 🟢 -532 B
assets/Load3DAdvanced-C2HJlG9L.js (removed) 783 B — 🟢 -783 B 🟢 -435 B 🟢 -370 B
assets/Load3DAdvanced-CWGOurML.js (new) — 783 B 🔴 +783 B 🔴 +434 B 🔴 +367 B
assets/savedImageUrls-B83tFwbR.js (removed) 739 B — 🟢 -739 B 🟢 -435 B 🟢 -396 B
assets/savedImageUrls-DHHiJwF9.js (new) — 739 B 🔴 +739 B 🔴 +435 B 🔴 +396 B
assets/Load3dViewerContent-C8rdpOuU.js (removed) 137 B — 🟢 -137 B 🟢 -103 B 🟢 -93 B
assets/Load3dViewerContent-FIEt7tHy.js (new) — 137 B 🔴 +137 B 🔴 +103 B 🔴 +95 B
assets/WidgetBoundingBox-DOKYXvR1.js (removed) 131 B — 🟢 -131 B 🟢 -100 B 🟢 -93 B
assets/WidgetBoundingBox-DsUbLtNm.js (new) — 131 B 🔴 +131 B 🔴 +100 B 🔴 +91 B
assets/Load3D-CHp-L041.js (removed) 98 B — 🟢 -98 B 🟢 -89 B 🟢 -85 B
assets/Load3D-mFc8-slk.js (new) — 98 B 🔴 +98 B 🔴 +89 B 🔴 +88 B

Status: 45 added / 45 removed / 698 unchanged

⚡ Performance: ⏳ Performance tests in progress…

🎭 Playwright: ✅ 3217 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 2354 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-2x: View Report (✅ 3 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • cloud: View Report (✅ 827 / ❌ 0 / ⚠️ 1 / ⏭️ 0)
  • desktop: View Report (✅ 9 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 19 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-safari: View Report (✅ 3 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 11/02/2026, 10:52:32 PM UTC

Links

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

No verdict is available. Open the workflow run to confirm the check was intentionally skipped, or fix the collection failure and re-run it.

Findings and check details

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped.

Full docs: scripts/registry-census/README.md

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

🌾 Fallow: ✅ Passed

Findings and check details

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Full docs: ADR-DEVEX-LINT-0015

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 917b85bccea70e97332d66ca529ffaa9f43ca17b

🏛️ Architecture: ✅ Passed

Findings and check details

Warnings (352)

  • billing path matches no source files: src/platform/billing/composables/activateBillingScope.testUtils.ts. Remove or update it in docs/architecture/domains/records/billing.domain.json.
  • error-handling path matches no source files: src/utils/errorUtil.ts. Remove or update it in docs/architecture/domains/records/error-handling.domain.json.
  • graph-model path matches no source files: src/types/linkTopology.ts. Remove or update it in docs/architecture/domains/records/graph-model.domain.json.
  • graph-model path matches no source files: src/types/nodeState.ts. Remove or update it in docs/architecture/domains/records/graph-model.domain.json.
  • job-queue path matches no source files: src/platform/remote/comfyui/jobs/**. Remove or update it in docs/architecture/domains/records/job-queue.domain.json.
  • linear-mode path matches no source files: src/utils/appMode.ts. Remove or update it in docs/architecture/domains/records/linear-mode.domain.json.
  • link-connection path matches no source files: src/lib/litegraph/src/infrastructure/LinkConnectorEventMap.ts. Remove or update it in docs/architecture/domains/records/link-connection.domain.json.
  • node-widgets path matches no source files: src/types/widgetState.ts. Remove or update it in docs/architecture/domains/records/node-widgets.domain.json.
  • subgraphs path matches no source files: src/lib/litegraph/src/infrastructure/SubgraphEventMap.ts. Remove or update it in docs/architecture/domains/records/subgraphs.domain.json.
  • vue-node-widgets path matches no source files: src/types/positionConfig.ts. Remove or update it in docs/architecture/domains/records/vue-node-widgets.domain.json.
  • workspace path matches no source files: src/platform/workspace/fixtures/**. Remove or update it in docs/architecture/domains/records/workspace.domain.json.
  • packages/api-client/src/abortSignal.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/abortSignal.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/fetchRouteTemplate.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/fetchWithRetry.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/fetchWithRetry.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/retryPolicy.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/retryPolicy.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/statusRetryTelemetry.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/statusRetryTelemetry.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/formatUtil.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/formatUtil.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/geometry.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/loadExternalScript.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/networkUtil.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/telemetry.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/telemetry.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/urlSafety.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/urlSafety.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/tailwind-utils/src/index.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/TopbarActions.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/searchbox/v2/filterChip.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/VideoConcatClipStrip.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/VideoConcatClipTile.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/VideoConcatPanel.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/VideoConcatPanel.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/VideoConcatPlaybackBar.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/WidgetVideoConcat.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/WidgetVideoConcat.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/__fixtures__/clipTiles.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/graph/menuOption.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useAgentExtensionActions.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useAgentExtensionActions.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useAgentExtensionNotices.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useAgentExtensionNotices.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useAgentSidebarTabs.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useLiveGraphNode.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useLiveGraphNode.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • …and 302 more

Full docs: Frontend domain catalog

Reproduce locally
pnpm architecture:check

@coderabbitai

coderabbitai Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Walkthrough

The billing entry point now exports billing-tab types and helpers from account-core. Platform billing components and composables import those exports. Auto-top-up card state derivation is added to account-core and used by its composable.

Changes: Account-core billing API

Layer / File(s) Summary
Billing-tab contracts and derivations
packages/account-core/src/core/billing/billingTab/planRow.ts, planRow.test.ts, planLifecycle.ts, creditsCard.ts, autoTopUpCard.ts, autoTopUpCard.test.ts
Billing-tab modules update type sources and define a credits balance contract. A new auto-top-up card derivation returns loaded when settings are present, loading when settings are absent and loading is active, and unavailable otherwise. Tests cover these states and the returned settings.
Billing entry-point exports
packages/account-core/src/core/billing/index.ts
The billing entry point re-exports billing-tab plan-row, lifecycle, credits-card, checkout-banner, and auto-top-up types and helpers.
Platform billing consumers
src/platform/account/components/dialogs/settings/BillingTab.vue, src/platform/billing/components/billingTab/*, src/platform/billing/composables/*
Billing components and composables import billing types and helpers from account-core. The auto-top-up composable delegates state derivation to deriveAutoTopUpCard.

Estimated code review effort: 3 (Moderate) | ~15 minutes

Change: Refactor

Suggested reviewers: drjkl

Merge Risk: Low · up to e35bd

SDK consumers supplying micro-unit balances can receive values 10,000 times too large. Correct the units before relying on the new API.

Pre-merge checks: Passed 6
Check name Status Explanation
Title check Passed The title clearly identifies the refactor and the primary change: moving Billing tab section rules into the billing SDK.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
End-To-End Test Suggestion For User-Facing Changes Passed PASS. The diff moves framework-free billing rules into @comfyorg/account-core/billing, extracts equivalent auto-top-up state derivation, and rewires imports. The supplied diff states that logic and …
Adr Compliance For Entity/Litegraph Changes Passed The changed-file list contains no files under src/lib/litegraph/, src/ecs/, or files related to graph entities. The ADR-LAYOUT and ADR-ECS checks do not apply.
Description check Passed The description is complete and relevant. It explains the problem, the implementation, expected behavior, risks and dependencies, and reports tests, lint results, and visual verification. It uses Why …
Full details: End-To-End Test Suggestion For User-Facing Changes

Explanation

PASS. The diff moves framework-free billing rules into @comfyorg/account-core/billing, extracts equivalent auto-top-up state derivation, and rewires imports. The supplied diff states that logic and UI behavior remain unchanged. Therefore, it does not add or change a user-facing frontend feature, so this optional end-to-end test suggestion does not apply.

Full details: Description check

Explanation

The description is complete and relevant. It explains the problem, the implementation, expected behavior, risks and dependencies, and reports tests, lint results, and visual verification. It uses Why and How sections instead of the template headings Summary and Verification, but it provides the required information.

Finishing Touches
Generate docstrings
  • Commit to this branch
  • Create a new PR
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.
Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between e35bd95 and e35bd95.

Files selected for processing: 29
  • packages/account-core/src/core/billing/billingTab/autoTopUpCard.test.ts
  • packages/account-core/src/core/billing/billingTab/autoTopUpCard.ts
  • packages/account-core/src/core/billing/billingTab/creditsCard.test.ts
  • packages/account-core/src/core/billing/billingTab/creditsCard.ts
  • packages/account-core/src/core/billing/billingTab/planCheckoutBanner.test.ts
  • packages/account-core/src/core/billing/billingTab/planCheckoutBanner.ts
  • packages/account-core/src/core/billing/billingTab/planLifecycle.test.ts
  • packages/account-core/src/core/billing/billingTab/planLifecycle.ts
  • packages/account-core/src/core/billing/billingTab/planRow.test.ts
  • packages/account-core/src/core/billing/billingTab/planRow.ts
  • packages/account-core/src/core/billing/billingTab/topupCheckoutBanner.test.ts
  • packages/account-core/src/core/billing/billingTab/topupCheckoutBanner.ts
  • packages/account-core/src/core/billing/index.ts
  • src/platform/account/components/dialogs/settings/BillingTab.vue
  • src/platform/billing/components/billingTab/BillingAutoTopUpCard.vue
  • src/platform/billing/components/billingTab/BillingCreditsCard.test.ts
  • src/platform/billing/components/billingTab/BillingCreditsCard.vue
  • src/platform/billing/components/billingTab/BillingCreditsPlanCell.vue
  • src/platform/billing/components/billingTab/BillingPlanCheckoutBanner.test.ts
  • src/platform/billing/components/billingTab/BillingPlanCheckoutBanner.vue
  • src/platform/billing/components/billingTab/BillingPlanLifecycle.vue
  • src/platform/billing/components/billingTab/BillingPlanRow.vue
  • src/platform/billing/components/billingTab/BillingTopupCheckoutBanner.vue
  • src/platform/billing/components/billingTab/useBillingCreditsCard.ts
  • src/platform/billing/components/billingTab/useBillingPlanRow.ts
  • src/platform/billing/components/billingTab/usePlanLifecycleCommands.ts
  • src/platform/billing/composables/useBillingAutoTopUpCard.ts
  • src/platform/billing/composables/usePlanCheckoutBanner.ts
  • src/platform/billing/composables/useTopupCheckoutBanner.ts
Files with no reviewable changes: 6
  • packages/account-core/src/core/billing/billingTab/planLifecycle.test.ts
  • packages/account-core/src/core/billing/billingTab/planCheckoutBanner.test.ts
  • packages/account-core/src/core/billing/billingTab/topupCheckoutBanner.test.ts
  • packages/account-core/src/core/billing/billingTab/planCheckoutBanner.ts
  • packages/account-core/src/core/billing/billingTab/creditsCard.test.ts
  • packages/account-core/src/core/billing/billingTab/topupCheckoutBanner.ts

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 2 remain after this review.

@codecov

codecov Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main   #22746      +/-   ##
==========================================
- Coverage   87.58%   87.56%   -0.02%     
==========================================
  Files        2991     2992       +1     
  Lines      162548   162474      -74     
  Branches    41781    41728      -53     
==========================================
- Hits       142360   142267      -93     
- Misses      19255    19273      +18     
- Partials      933      934       +1     
Flag Coverage Δ
billing-web-unit 91.98% <ø> (ø)
e2e 59.35% <0.00%> (-0.01%) ⬇️
unit 86.64% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...-core/src/core/billing/billingTab/autoTopUpCard.ts 100.00% <100.00%> (ø)
...nt-core/src/core/billing/billingTab/creditsCard.ts 12.00% <ø> (ø)
.../src/core/billing/billingTab/planCheckoutBanner.ts 100.00% <ø> (ø)
...-core/src/core/billing/billingTab/planLifecycle.ts 100.00% <ø> (ø)
...ccount-core/src/core/billing/billingTab/planRow.ts 91.66% <ø> (ø)
...src/core/billing/billingTab/topupCheckoutBanner.ts 100.00% <ø> (ø)
...account/components/dialogs/settings/BillingTab.vue 97.64% <ø> (ø)
...ing/components/billingTab/BillingAutoTopUpCard.vue 100.00% <ø> (ø)
...lling/components/billingTab/BillingCreditsCard.vue 100.00% <ø> (ø)
...g/components/billingTab/BillingCreditsPlanCell.vue 100.00% <ø> (ø)
... and 10 more

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coderabbitai coderabbitai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Fix comments: Fix CodeRabbit comments on this PR

@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Nov 2, 2026
@dante01yoon
dante01yoon added this pull request to stack #22747 November 2, 2026 23:11
@dante01yoon dante01yoon added needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch core/1.60 Backport PRs for core 1.60 cloud/1.60 Backport PRs for cloud 1.60 and removed needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch core/1.60 Backport PRs for core 1.60 cloud/1.60 Backport PRs for cloud 1.60 labels Nov 3, 2026

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on exact head e35bd95ce947df56227731e51f117ec88b03d373.

  • The billing-tab rules move into account-core without changing their inputs, precedence, or app behavior.
  • The package exports and app rewiring remain framework-neutral, with moved and parity coverage green.

@dante01yoon
dante01yoon added this pull request to the merge queue Nov 3, 2026
Merged via the queue into main with commit d5049a6 Nov 3, 2026
181 of 187 checks passed
@dante01yoon
dante01yoon deleted the dante/front-3796-billing-tab-rules branch November 3, 2026 07:45
dante01yoon added a commit that referenced this pull request Nov 3, 2026
…bled with the served reason (#22711) (#22798)

## Why
The automatic `cloud/1.60` backport of #22711 failed with conflicts: the
merged change is built on #22746, which moved the Billing tab rules into
the billing SDK and is After M4, so it must not go to 1.60.

## How
Cherry-picked the pre-SDK version of the change (e924b2e) instead of
the merged squash, which depends on the After-M4 billing SDK refactor
#22746. Conflicts were import-only in CreditsTile.vue and its test,
resolved by keeping both sides; no packages/ files are touched.

The pre-SDK change put the availability branches inline in three
templates, which pushed them over the fallow complexity gate (on main
that logic lives in the SDK). A second commit moves the button and
refusal line into `AddCreditsButton` and `AddCreditsRefusalReason`;
behaviour is unchanged.

Verified on this branch: billing, settings and workspace unit tests
pass, and `pnpm typecheck:app` is clean.

AS IS / TO BE: same behaviour as #22711; screenshots are in #22711.

- Backport of #22711
dante01yoon added a commit that referenced this pull request Nov 3, 2026
…lock to members (#22696) (#22795)

## Why
The automatic `core/1.60` backport of #22696 failed with conflicts: the
merged change is built on #22746, which moved the Billing tab rules into
the billing SDK and is After M4, so it must not go to 1.60.

## How
Cherry-picked the pre-SDK version of the change (1746901, plus the
app-side capabilities test 0ee0f2a) instead of the merged squash,
which depends on the After-M4 billing SDK refactor #22746. Both apply
cleanly; no packages/ files are touched.

Verified on this branch: billing, settings and workspace unit tests
pass, and `pnpm typecheck:app` is clean.

AS IS / TO BE: same behaviour as #22696; screenshots are in #22696.

- Backport of #22696
dante01yoon added a commit that referenced this pull request Nov 3, 2026
…block to members (#22696) (#22796)

## Why
The automatic `cloud/1.60` backport of #22696 failed with conflicts: the
merged change is built on #22746, which moved the Billing tab rules into
the billing SDK and is After M4, so it must not go to 1.60.

## How
Cherry-picked the pre-SDK version of the change (1746901, plus the
app-side capabilities test 0ee0f2a) instead of the merged squash,
which depends on the After-M4 billing SDK refactor #22746. Both apply
cleanly; no packages/ files are touched.

Verified on this branch: billing, settings and workspace unit tests
pass, and `pnpm typecheck:app` is clean.

AS IS / TO BE: same behaviour as #22696; screenshots are in #22696.

- Backport of #22696
dante01yoon added a commit that referenced this pull request Nov 3, 2026
…led with the served reason (#22711) (#22797)

## Why
The automatic `core/1.60` backport of #22711 failed with conflicts: the
merged change is built on #22746, which moved the Billing tab rules into
the billing SDK and is After M4, so it must not go to 1.60.

## How
Cherry-picked the pre-SDK version of the change (e924b2e) instead of
the merged squash, which depends on the After-M4 billing SDK refactor
#22746. Conflicts were import-only in CreditsTile.vue and its test,
resolved by keeping both sides; no packages/ files are touched.

The pre-SDK change put the availability branches inline in three
templates, which pushed them over the fallow complexity gate (on main
that logic lives in the SDK). A second commit moves the button and
refusal line into `AddCreditsButton` and `AddCreditsRefusalReason`;
behaviour is unchanged.

Verified on this branch: billing, settings and workspace unit tests
pass, and `pnpm typecheck:app` is clean.

AS IS / TO BE: same behaviour as #22711; screenshots are in #22711.

- Backport of #22711
dante01yoon added a commit that referenced this pull request Nov 3, 2026
… auto top-up card (#22431) (#22838)

## Why

The automatic backport of #22431 failed with cherry-pick conflicts: the
merged change sits on the After-M4 billing SDK refactor #22746, which
must not reach the 1.60 line.

## How

- Rebuilt from the pre-SDK head of #22431, `46771cceee` (pushed
2026-11-02T00:13Z, before the SDK rebuild force-push). It is not a
descendant of `e35bd95ce9`. Two picks, squashed into one commit:
- its main merge `3a76c9336e`, picked with `-x -m 2` against origin/main
`9065563d47`. This carries the PR's own commits `f3263d3b17`,
`bdd8ff9ed3`, `f8de5859df`, `20c6927b03` and `87e0ed61fc`.
  - `46771cceee`, the review fix for the card mock.
- It applied with no conflicts on top of the #22696 and FRONT-3650
backports already on 1.60. It does not need the #22437 or #22435
backports.
- No SDK code from #22746 or #22759 is included. The merged version's
`packages/account-core/src/core/billing/billingTab/autoTopUpCard.ts`
changes are from the SDK rebuild and are left out. This backport touches
no `packages/` files.

## Verification

On this branch:
- `pnpm vitest run src/platform/billing src/platform/workspace
src/platform/account` (includes `BillingAutoTopUpCard.test.ts` and
`useAutoTopUpBannerKind.test.ts`): all pass
- `pnpm typecheck:app`: pass
- `pnpm fallow:audit --base origin/cloud/1.60`: exit 0
- `pnpm architecture:check`: exit 0

AS IS / TO BE: same behaviour as #22431; screenshots are in #22431.

- Backport of #22431
dante01yoon added a commit that referenced this pull request Nov 3, 2026
…refill on the Credits card and out-of-credits banners (#22437) (#22833)

## Why

The automatic backport of #22437 failed with cherry-pick conflicts: the
merged change sits on the After-M4 billing SDK refactor #22746, which
must not reach the 1.60 line.

## How

- Rebuilt from the pre-SDK head of #22437, `8618e8cfa5` (pushed
2026-11-02T12:21Z, before the SDK rebuild force-push). It is not a
descendant of `e35bd95ce9`. Picked with `-x -m 2` against its last main
merge `dcb6476d28`, so the commit carries only the PR's own net change,
which folds in #22438 (display plan balance) and #22453
(purchases-paused state).
- Conflicts were with #22711 (refused Add credits reason), which is
already on 1.60. They were resolved the way the merged #22437 resolved
them on main. The paused top-up reason goes through the refused-reason
path and uses the dated paused copy. The Credits card keeps 1.60's
`AddCreditsButton` / `AddCreditsRefusalReason` and drops the pre-SDK
`topUpPaused` prop. The `src/` files match the merged #22437 diff,
except that `deriveCreditsCard` stays in 1.60's
`src/platform/billing/components/billingTab/creditsCard.ts`.
- No SDK code from #22746 or #22759 is included. Nothing under
`packages/account-core/src/core/billing/billingTab` or
`packages/account-ui` is touched. The only `packages/` edits are
#22453's pre-SDK changes to files that already exist on 1.60:
`capabilityDenials.ts` (decode `topup_purchases_paused`) and its tests.

## Verification

On this branch:
- `pnpm vitest run packages/account-core/src/core/billing
src/platform/billing src/platform/workspace src/platform/account`: all
pass
- `pnpm typecheck:app`: pass
- `pnpm fallow:audit --base origin/core/1.60`: exit 0
- `pnpm architecture:check`: exit 0

AS IS / TO BE: same behaviour as #22437; screenshots are in #22437.

- Backport of #22437
dante01yoon added a commit that referenced this pull request Nov 3, 2026
… refill on the Credits card and out-of-credits banners (#22437) (#22834)

## Why

The automatic backport of #22437 failed with cherry-pick conflicts: the
merged change sits on the After-M4 billing SDK refactor #22746, which
must not reach the 1.60 line.

## How

- Rebuilt from the pre-SDK head of #22437, `8618e8cfa5` (pushed
2026-11-02T12:21Z, before the SDK rebuild force-push). It is not a
descendant of `e35bd95ce9`. Picked with `-x -m 2` against its last main
merge `dcb6476d28`, so the commit carries only the PR's own net change,
which folds in #22438 (display plan balance) and #22453
(purchases-paused state).
- Conflicts were with #22711 (refused Add credits reason), which is
already on 1.60. They were resolved the way the merged #22437 resolved
them on main. The paused top-up reason goes through the refused-reason
path and uses the dated paused copy. The Credits card keeps 1.60's
`AddCreditsButton` / `AddCreditsRefusalReason` and drops the pre-SDK
`topUpPaused` prop. The `src/` files match the merged #22437 diff,
except that `deriveCreditsCard` stays in 1.60's
`src/platform/billing/components/billingTab/creditsCard.ts`.
- No SDK code from #22746 or #22759 is included. Nothing under
`packages/account-core/src/core/billing/billingTab` or
`packages/account-ui` is touched. The only `packages/` edits are
#22453's pre-SDK changes to files that already exist on 1.60:
`capabilityDenials.ts` (decode `topup_purchases_paused`) and its tests.

## Verification

On this branch:
- `pnpm vitest run packages/account-core/src/core/billing
src/platform/billing src/platform/workspace src/platform/account`: all
pass
- `pnpm typecheck:app`: pass
- `pnpm fallow:audit --base origin/cloud/1.60`: exit 0
- `pnpm architecture:check`: exit 0

AS IS / TO BE: same behaviour as #22437; screenshots are in #22437.

- Backport of #22437
dante01yoon added a commit that referenced this pull request Nov 3, 2026
…and maximum in Add credits (#22435) (#22835)

## Why

The automatic backport of #22435 failed with cherry-pick conflicts: the
merged change sits on the After-M4 billing SDK refactor #22746, which
must not reach the 1.60 line.

## How

- Rebuilt from the pre-SDK head of #22435, `43e9a6bcdb` (pushed
2026-11-02T14:12Z, before the SDK rebuild force-push). It is not a
descendant of `e35bd95ce9`. Picked with `-x -m 2` against its last main
merge `f710711926`, so the commit carries only the PR's own commits:
`4e232e0128` (served minimum), `0feb35b405` (served maximum) and
`83c507a7c6` (cap the credits input).
- It applied with no conflicts. It does not need the #22437 backport.
- No SDK code from #22746 or #22759 is included. The merged version's
`packages/account-core/src/core/billing/topUpBounds.ts` is from the SDK
rebuild and is left out. This backport touches no `packages/` files.

## Verification

On this branch:
- `pnpm vitest run src/platform/billing src/platform/workspace
src/platform/account` (includes
`TopUpCreditsDialogContentWorkspace.test.ts`): all pass
- `pnpm typecheck:app`: pass
- `pnpm fallow:audit --base origin/core/1.60`: exit 0
- `pnpm architecture:check`: exit 0

AS IS / TO BE: same behaviour as #22435; screenshots are in #22435.

- Backport of #22435
dante01yoon added a commit that referenced this pull request Nov 3, 2026
… and maximum in Add credits (#22435) (#22836)

## Why

The automatic backport of #22435 failed with cherry-pick conflicts: the
merged change sits on the After-M4 billing SDK refactor #22746, which
must not reach the 1.60 line.

## How

- Rebuilt from the pre-SDK head of #22435, `43e9a6bcdb` (pushed
2026-11-02T14:12Z, before the SDK rebuild force-push). It is not a
descendant of `e35bd95ce9`. Picked with `-x -m 2` against its last main
merge `f710711926`, so the commit carries only the PR's own commits:
`4e232e0128` (served minimum), `0feb35b405` (served maximum) and
`83c507a7c6` (cap the credits input).
- It applied with no conflicts. It does not need the #22437 backport.
- No SDK code from #22746 or #22759 is included. The merged version's
`packages/account-core/src/core/billing/topUpBounds.ts` is from the SDK
rebuild and is left out. This backport touches no `packages/` files.

## Verification

On this branch:
- `pnpm vitest run src/platform/billing src/platform/workspace
src/platform/account` (includes
`TopUpCreditsDialogContentWorkspace.test.ts`): all pass
- `pnpm typecheck:app`: pass
- `pnpm fallow:audit --base origin/cloud/1.60`: exit 0
- `pnpm architecture:check`: exit 0

AS IS / TO BE: same behaviour as #22435; screenshots are in #22435.

- Backport of #22435
dante01yoon added a commit that referenced this pull request Nov 3, 2026
…auto top-up card (#22431) (#22837)

## Why

The automatic backport of #22431 failed with cherry-pick conflicts: the
merged change sits on the After-M4 billing SDK refactor #22746, which
must not reach the 1.60 line.

## How

- Rebuilt from the pre-SDK head of #22431, `46771cceee` (pushed
2026-11-02T00:13Z, before the SDK rebuild force-push). It is not a
descendant of `e35bd95ce9`. Two picks, squashed into one commit:
- its main merge `3a76c9336e`, picked with `-x -m 2` against origin/main
`9065563d47`. This carries the PR's own commits `f3263d3b17`,
`bdd8ff9ed3`, `f8de5859df`, `20c6927b03` and `87e0ed61fc`.
  - `46771cceee`, the review fix for the card mock.
- It applied with no conflicts on top of the #22696 and FRONT-3650
backports already on 1.60. It does not need the #22437 or #22435
backports.
- No SDK code from #22746 or #22759 is included. The merged version's
`packages/account-core/src/core/billing/billingTab/autoTopUpCard.ts`
changes are from the SDK rebuild and are left out. This backport touches
no `packages/` files.

## Verification

On this branch:
- `pnpm vitest run src/platform/billing src/platform/workspace
src/platform/account` (includes `BillingAutoTopUpCard.test.ts` and
`useAutoTopUpBannerKind.test.ts`): all pass
- `pnpm typecheck:app`: pass
- `pnpm fallow:audit --base origin/core/1.60`: exit 0
- `pnpm architecture:check`: exit 0

AS IS / TO BE: same behaviour as #22431; screenshots are in #22431.

- Backport of #22431
dante01yoon added a commit that referenced this pull request Nov 3, 2026
…gma (#22392) (#22856)

## Why

The auto backport of #22392 to `cloud/1.60` conflicted. This keeps only
the app-side style change, with no billing SDK code.

## Root cause

The #22392 squash touches SDK files under `packages/account-ui` and sits
on main code from #22711, #22746 and #22759 that 1.60 does not have.

## How

Cherry-pick (`-x`) of the #22392 squash, then:
- Taken: `src/` Billing tab components (`BillingTab.vue`, credits card,
plan cell, auto top-up card, plan row), the new `BillingInfoTip.vue` and
its test, the banner radius/stroke changes, `src/locales/en/main.json`
copy, and the matching test updates.
- Dropped: everything under `packages/`
(`packages/account-ui/src/billing/tab/*`, restored to
`origin/cloud/1.60`) and `BillingCreditsCard.parity.test.ts`, which does
not exist on 1.60.
- Conflicts:
- `BillingCreditsCard.vue`: main uses `AddCreditsAction` (#22711). Kept
1.60's `AddCreditsButton` + `AddCreditsRefusalReason` markup (from
#22797/#22798) and moved it into #22392's new top-up row, so Add credits
centers on the Top-up label and value with "In use" below. Imports keep
`@/platform/billing/components/billingTab/creditsCard`.
- `BillingCreditsPlanCell.vue`: took `BillingInfoTip`; kept 1.60's
`PlanCreditsState` import from `billingTab/creditsCard` instead of
`@comfyorg/account-core/billing`.
- Both files are identical on `core/1.60` and `cloud/1.60`, so the
resolution matches the core backport. Everything else, including the
auto top-up card and `BillingStatusBanner.vue`, applied cleanly.

Verification on `cloud/1.60`:
- `pnpm vitest run src/platform/billing src/platform/account`: 156
files, 4103 tests pass
- `pnpm typecheck:app`: pass
- `pnpm fallow:audit --base origin/cloud/1.60`: exit 0
- `pnpm architecture:check`: exit 0

AS IS / TO BE: same look as #22392; screenshots are in #22392.

- Backport of #22392
dante01yoon added a commit that referenced this pull request Nov 3, 2026
…ma (#22392) (#22855)

## Why

The auto backport of #22392 to `core/1.60` conflicted. This keeps only
the app-side style change, with no billing SDK code.

## Root cause

The #22392 squash touches SDK files under `packages/account-ui` and sits
on main code from #22711, #22746 and #22759 that 1.60 does not have.

## How

Cherry-pick (`-x`) of the #22392 squash, then:
- Taken: `src/` Billing tab components (`BillingTab.vue`, credits card,
plan cell, auto top-up card, plan row), the new `BillingInfoTip.vue` and
its test, the banner radius/stroke changes, `src/locales/en/main.json`
copy, and the matching test updates.
- Dropped: everything under `packages/`
(`packages/account-ui/src/billing/tab/*`, restored to
`origin/core/1.60`) and `BillingCreditsCard.parity.test.ts`, which does
not exist on 1.60.
- Conflicts:
- `BillingCreditsCard.vue`: main uses `AddCreditsAction` (#22711). Kept
1.60's `AddCreditsButton` + `AddCreditsRefusalReason` markup (from
#22797/#22798) and moved it into #22392's new top-up row, so Add credits
centers on the Top-up label and value with "In use" below. Imports keep
`@/platform/billing/components/billingTab/creditsCard`.
- `BillingCreditsPlanCell.vue`: took `BillingInfoTip`; kept 1.60's
`PlanCreditsState` import from `billingTab/creditsCard` instead of
`@comfyorg/account-core/billing`.
  - Everything else, including the auto top-up card, applied cleanly.

Verification on `core/1.60`:
- `pnpm vitest run src/platform/billing src/platform/account`: 156
files, 4111 tests pass
- `pnpm typecheck:app`: pass
- `pnpm fallow:audit --base origin/core/1.60`: exit 0
- `pnpm architecture:check`: exit 0

AS IS / TO BE: same look as #22392; screenshots are in #22392.

- Backport of #22392
j0n4t pushed a commit to j0n4t/ComfyUI_frontend that referenced this pull request Nov 4, 2026
…ections (Comfy-Org#22764)

## Why

FRONT-3797 (part of FRONT-3795): the ComfyUI Billing tab and Platform
billing render the same sections twice. FRONT-3796 moved the rules into
`@comfyorg/account-core/billing`; this moves the first section's view
into `@comfyorg/account-ui/billing`, ComfyUI's look as the default and
Platform restyling through hooks (agreed with Alex in #proj-billing).
Package work only: consumers migrate in FRONT-3800 (ComfyUI) and
FRONT-3801 (Platform).

FRONT-3797 is split into four stacked PRs to stay reviewable: plan row
(this), credits card, auto top-up card + member block, billing banners.

## How

- `BillingPlanRow.vue` renders the served `PlanRowState` and the
`PlanRowAction` from account-core.
- Copy comes from the host as `PlanRowCopy` (strings and typed
functions), the same pattern as the checkout components, so the package
carries no i18n runtime. `planRowText` turns state + copy into the title
and status line and is exported for hosts that render their own row.
- The action is emitted (`@action`), never performed: the host opens the
plans page or the sales contact.
- Platform hooks: `classes` per part (`root`, `title`, `line`,
`actions`), `salesVariant` / `addCreditsVariant` props, an `#action`
scoped slot to replace the button (for example with an anchor), and a
`#leading` slot for host actions such as Stay/Resume.
- ADR-PACKAGES-ACCOUNT-UI-0034 amended: the Billing tab sections live in
account-ui. Storybook now picks up `packages/account-ui` stories.
- `canManageSubscription` is the served fact passed through as received;
no role, tier or `isCloud` check in the package.

## Dependency graph

```mermaid
flowchart LR
  F3796[FRONT-3796 account-core rules Comfy-Org#22746 stack] --> P1[3797 plan row]
  P1 --> P2[3797 credits card]
  P2 --> P3[3797 auto top-up + member block]
  P3 --> P4[3797 banners]
  P4 --> F3798[FRONT-3798 npm publish]
  P4 --> F3800[FRONT-3800 ComfyUI renders account-ui]
```

## AS IS / TO BE

| AS IS | TO BE |
| --- | --- |
| <img width="420"
src="https://gist.githubusercontent.com/dante01yoon/aa35483cb18885036fe69ae26581459f/raw/1a6237a1a3cd0baa5f84520ac899caabb9f264f7/account-ui-asis-plan-active.png">
| <img width="420"
src="https://gist.githubusercontent.com/dante01yoon/aa35483cb18885036fe69ae26581459f/raw/1a6237a1a3cd0baa5f84520ac899caabb9f264f7/account-ui-tobe-plan-active.png">
|
| <img width="420"
src="https://gist.githubusercontent.com/dante01yoon/aa35483cb18885036fe69ae26581459f/raw/1a6237a1a3cd0baa5f84520ac899caabb9f264f7/account-ui-asis-plan-ending.png">
| <img width="420"
src="https://gist.githubusercontent.com/dante01yoon/aa35483cb18885036fe69ae26581459f/raw/1a6237a1a3cd0baa5f84520ac899caabb9f264f7/account-ui-tobe-plan-ending.png">
|
| <img width="420"
src="https://gist.githubusercontent.com/dante01yoon/aa35483cb18885036fe69ae26581459f/raw/1a6237a1a3cd0baa5f84520ac899caabb9f264f7/account-ui-asis-plan-paused.png">
| <img width="420"
src="https://gist.githubusercontent.com/dante01yoon/aa35483cb18885036fe69ae26581459f/raw/1a6237a1a3cd0baa5f84520ac899caabb9f264f7/account-ui-tobe-plan-paused.png">
|

In-app, dark theme. TO BE renders the package component through a local,
uncommitted swap inside the app's Billing tab section components (copy
and views built the same way as the parity tests); the app switches over
in FRONT-3800.

## Tests

- Behaviour parity:
`src/platform/billing/components/billingTab/BillingPlanRow.parity.test.ts`
renders the app's `BillingPlanRow` and the package one (copy built from
the same en messages) for all 13 plan states, with and without
`can_manage_subscription`, and all actions, and asserts the same title,
status line and action label (31 cases). Removing the member line from
the package turns 13 of them red.
- `packages/account-ui`: `vitest run src/billing` 22 files / 206 tests
pass, including a table per plan state, member line, emitted actions,
the action slot and the class hook.

- Part of FRONT-3797
Penguinjanator pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Nov 12, 2026
…led (Comfy-Org#23276)

## Why

`billing_new_ux_enabled` (Comfy-Org#23248) rolls 1.61 billing back to 1.60
behavior when it is off, but the Billing settings tab was not covered.
Comfy-Org#22746 moved the tab's rules (plan row, credits card, auto top-up card,
plan lifecycle, the tab's banners) into the SDK packages and deleted the
app-side 1.60 implementation. So 1.61 renders the Billing tab through
the SDK for everyone, and a regression there has no switch to turn it
off. The 1.61 release review lists the Team-workspace Billing tab (owner
and member) as a post-deploy check for exactly this reason.

## How

- One branch point: the settings panel now renders
`BillingTabLegacy.vue` while `billing_new_ux_enabled` is off and the
current `BillingTab.vue` when it is on. The choice is read at render
time, so a flag that resolves after the dialog opens still swaps the
tab.
- `BillingTabLegacy.vue` is the `core/1.60` tab. Everything it reaches
that main deleted, or that main moved onto SDK rules, is restored
verbatim from `core/1.60` under `src/platform/billing/legacy160/` (34
files), with its 1.60 tests (22 files, 580 cases). Shared infrastructure
that did not change rules (capabilities reader, SDK store, dialogs) is
main's, and the restored tree typechecks against it unchanged.
- Restored with a script (copy from `core/1.60`, rewrite imports between
restored files), so the tree is reproducible rather than hand-edited.
Two hand edits: the two `tier === 'ENTERPRISE'` checks are wrapped in
the existing `pendingServerFact('BE-25244', ...)` bridge (ADR-0042
lint), the same bridge Comfy-Org#23248 uses for the flag-off notices; and the
legacy root carries `data-billing-release="1.60"` so a browser test can
tell the tabs apart (their markup is otherwise identical by design).
- The current `BillingTab.vue` loses its own flag-off branch (member
auto top-up view) and that branch's test, since the tab now only renders
with the flag on.
- `legacy160/` and `BillingTabLegacy.*` are excluded from the fallow
audit: it is 1.60 code kept as-is and deleted with the flag, not new
code to refactor.

The other 1.61 SDK-rule screens get the same flag-off path, so turning
the flag off leaves no 1.61 billing SDK rules on screen:

- The previous profile popover (`CurrentUserPopoverWorkspace.vue`,
rendered only with the flag off) is its `core/1.60` content again.
- `CreditsPanel` and the Plan & Credits panel render the `core/1.60`
credits tile with the flag off.
- The settings status banner, and the Plan & Credits panel's banner
kind, come from the `core/1.60` banner rules with the flag off.
- The previous Add credits dialog
(`TopUpCreditsDialogContentWorkspace.vue`) and its auto top-up card
(`TopUpAutoTopUpCard.vue`), both rendered only with the flag off, are
their `core/1.60` content again: the served top-up bounds go through the
1.60 local helper instead of the SDK's `servedTopUpBound`, and the card
reads auto top-up through the 1.60 composable, so the Billing tab and
the dialog share one auto top-up read again.

This only changes what main (1.61) renders with the flag off;
`core/1.60` is untouched.

Bug fixes stay outside the flag. Every 1.61 `fix(...)` commit touching a
restored file was checked against `core/1.60`: Comfy-Org#22372, Comfy-Org#22392, Comfy-Org#22717,
Comfy-Org#22888, Comfy-Org#22914, Comfy-Org#22921 and Comfy-Org#23060 were backported, so the restored
copies already contain them. Comfy-Org#22887, Comfy-Org#22889 and Comfy-Org#22979 only restructure
code or add server-fact markers, with no user-visible change. Comfy-Org#22931
(served notice audience) was already put behind this flag by Comfy-Org#23248. The
plan-change confirmation fix Comfy-Org#23048 lives in the SDK
`CheckoutTransitionConfirm`, which this PR does not gate.

Delete `BillingTabLegacy.*`, `legacy160/` and the fallow entry together
when the flag is removed.

## AS IS / TO BE

AS IS: flag off, the Billing tab renders through the SDK rules.
TO BE: flag off, the 1.60 Billing tab; flag on, the current tab.

AS IS for flag off is the same picture as flag on: before this PR the
flag did not affect the Billing tab.

| Flag off (TO BE): 1.60 Billing tab | Flag on: current Billing tab |
| --- | --- |
| <img
src="https://gist.githubusercontent.com/dante01yoon/4dab1584fdedaaaa6722859310c69446/raw/469248fb30804f421c863e6cd3ac97d9e855db62/pr23276-billing-flag-off.png"
width="480"> | <img
src="https://gist.githubusercontent.com/dante01yoon/4dab1584fdedaaaa6722859310c69446/raw/469248fb30804f421c863e6cd3ac97d9e855db62/pr23276-billing-flag-on.png"
width="480"> |

## Verification

- `useSettingUI.test.ts`: renders the 1.60 tab with the flag off, then
the current tab after the flag turns on in the same render. Goes red
when the switch is forced to the current tab.
- Browser (`@cloud`, `Billing rollout`): opens the Billing tab with
`/api/features` serving the flag off and on and asserts which tab
rendered. Ran locally, 4/4 pass; the 1.60 case goes red when the switch
is forced to the current tab.
- 580 restored 1.60 tests; billing, settings and account settings suites
(4,398 tests); app and browser typecheck; knip; dependency-cruiser;
server-facts lint.

## Dependencies

```
Comfy-Org#23248 (merged, billing_new_ux_enabled rollout)
  └── this PR (Billing tab under the same flag)
cloud#18886 (serves billing_new_ux_enabled on /api/features)
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants