Repository navigation
[backport cloud/1.60] M4 feat(billing): show refused Add credits disabled with the served reason (#22711) - #22798
Conversation
Add credits now hides only for not_workspace_owner and not_a_member. Every other can_top_up refusal, including unrecognized values, shows the button disabled with the reason: paused purchases, past due, or a generic line. A past-due owner keeps a separate Update payment action gated on payment_recovery_available. The out-of-credits banners follow the same served reason instead of can_manage_subscription, so a refused owner now gets a banner. (cherry picked from commit e924b2e)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 8 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-03T11:02:46.781Z",
"gitSha": "c7e94017e9e09fa0cf4092624e0a3ce17e1eff22",
"branch": "backport-22711-to-cloud-1.60",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2048.0289999999854,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.546,
"layouts": 8,
"layoutDurationMs": 2.6220000000000003,
"taskDurationMs": 643.571,
"heapDeltaBytes": 8344248,
"heapUsedBytes": 68902316,
"domNodes": -178,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 10.970999999999998,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2037.3579999999265,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.7470000000000003,
"layouts": 9,
"layoutDurationMs": 2.76,
"taskDurationMs": 610.7860000000001,
"heapDeltaBytes": -4385208,
"heapUsedBytes": 69193928,
"domNodes": -178,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 9.395000000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1875.017000000014,
"styleRecalcs": 76,
"styleRecalcDurationMs": 12.748000000000003,
"layouts": 8,
"layoutDurationMs": 2.3649999999999998,
"taskDurationMs": 974.7149999999999,
"heapDeltaBytes": -3284216,
"heapUsedBytes": 58893612,
"domNodes": -178,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 172.495,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666071428571424,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1859.0179999999918,
"styleRecalcs": 78,
"styleRecalcDurationMs": 13.417000000000002,
"layouts": 11,
"layoutDurationMs": 3.0489999999999995,
"taskDurationMs": 961.2900000000001,
"heapDeltaBytes": -7924964,
"heapUsedBytes": 60414356,
"domNodes": -178,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 166.69899999999998,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1695.2980000000366,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.7,
"layouts": 10,
"layoutDurationMs": 3.9120000000000004,
"taskDurationMs": 487.9599999999999,
"heapDeltaBytes": 25388796,
"heapUsedBytes": 85960264,
"domNodes": 57,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 14.034999999999998,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.002999999986,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.726999999999999,
"layouts": 11,
"layoutDurationMs": 3.3989999999999996,
"taskDurationMs": 470.53599999999994,
"heapDeltaBytes": 8936388,
"heapUsedBytes": 82477924,
"domNodes": 57,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 13.264000000000001,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 716.0910000000058,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.524,
"layouts": 8,
"layoutDurationMs": 2.289,
"taskDurationMs": 506.84200000000004,
"heapDeltaBytes": 2219584,
"heapUsedBytes": 62536024,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 174.598,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66744186046511,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 722.1410000000787,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.595,
"layouts": 8,
"layoutDurationMs": 2.27,
"taskDurationMs": 519.0360000000001,
"heapDeltaBytes": -13034624,
"heapUsedBytes": 60446024,
"domNodes": 0,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 172.993,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665116279069764,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1232.4600000000032,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 942.4319999999999,
"heapDeltaBytes": -11057148,
"heapUsedBytes": 77428424,
"domNodes": -208,
"jsHeapTotalBytes": 20455424,
"scriptDurationMs": 74.44300000000001,
"eventListeners": -107,
"totalBlockingTimeMs": 539,
"frameDurationMs": 33.33243243243244,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1227.8499999999894,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 897.788,
"heapDeltaBytes": 19230580,
"heapUsedBytes": 89632572,
"domNodes": 0,
"jsHeapTotalBytes": 15630336,
"scriptDurationMs": 72.81400000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 561,
"frameDurationMs": 34.258333333333326,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 891.2109999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 579.7809999999996,
"heapDeltaBytes": -25883732,
"heapUsedBytes": 64466712,
"domNodes": -208,
"jsHeapTotalBytes": 3801088,
"scriptDurationMs": 175.815,
"eventListeners": -107,
"totalBlockingTimeMs": 232,
"frameDurationMs": 24.997222222222213,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 855.7789999999841,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 507.8510000000005,
"heapDeltaBytes": -2707404,
"heapUsedBytes": 73341268,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 158.95000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 222,
"frameDurationMs": 24.9970588235294,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11680.693999999989,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10841.162,
"heapDeltaBytes": 79387784,
"heapUsedBytes": 173936224,
"domNodes": -274,
"jsHeapTotalBytes": 84275200,
"scriptDurationMs": 8748.329,
"eventListeners": -69,
"totalBlockingTimeMs": 1465,
"frameDurationMs": 31.32117962466488,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11473.861999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10703.03,
"heapDeltaBytes": 90318668,
"heapUsedBytes": 165618348,
"domNodes": -274,
"jsHeapTotalBytes": 82440192,
"scriptDurationMs": 8644.422,
"eventListeners": -69,
"totalBlockingTimeMs": 1834,
"frameDurationMs": 31.475271739130438,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10051.198999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9269.207,
"heapDeltaBytes": -26856864,
"heapUsedBytes": 67439816,
"domNodes": -274,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 7401.957,
"eventListeners": -69,
"totalBlockingTimeMs": 678,
"frameDurationMs": 31.255140186915888,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10880.340999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10084.384,
"heapDeltaBytes": 62818668,
"heapUsedBytes": 156396784,
"domNodes": -274,
"jsHeapTotalBytes": 68546560,
"scriptDurationMs": 8034.445999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 1311,
"frameDurationMs": 31.272988505747126,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-combo-open",
"durationMs": 252.66300000001252,
"styleRecalcs": 21,
"styleRecalcDurationMs": 14.956999999999999,
"layouts": 6,
"layoutDurationMs": 2.5369999999999995,
"taskDurationMs": 188.34499999999997,
"heapDeltaBytes": 14903504,
"heapUsedBytes": 76239600,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.953999999999999,
"eventListeners": 205,
"totalBlockingTimeMs": 5,
"frameDurationMs": 25,
"p95FrameDurationMs": 100
},
{
"name": "large-combo-open",
"durationMs": 282.14200000002165,
"styleRecalcs": 25,
"styleRecalcDurationMs": 14.314999999999998,
"layouts": 11,
"layoutDurationMs": 3.6229999999999998,
"taskDurationMs": 251.66600000000005,
"heapDeltaBytes": -7560908,
"heapUsedBytes": 68326784,
"domNodes": -2427,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 9.729000000000001,
"eventListeners": -582,
"totalBlockingTimeMs": 7,
"frameDurationMs": 21.792307692307705,
"p95FrameDurationMs": 83.29999999999973
},
{
"name": "large-graph-idle",
"durationMs": 2052.301,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.3649999999999998,
"layouts": 7,
"layoutDurationMs": 2.219,
"taskDurationMs": 726.825,
"heapDeltaBytes": -16581960,
"heapUsedBytes": 77115932,
"domNodes": -274,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 33.785999999999994,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666664,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2040.6489999999167,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.1580000000000004,
"layouts": 8,
"layoutDurationMs": 2.326,
"taskDurationMs": 668.129,
"heapDeltaBytes": -16752416,
"heapUsedBytes": 77143924,
"domNodes": -274,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 31.895,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406507,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2786.528999999973,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.5,
"layouts": 7,
"layoutDurationMs": 2.006,
"taskDurationMs": 1825.281,
"heapDeltaBytes": -19275488,
"heapUsedBytes": 63853560,
"domNodes": -274,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 867.356,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666265060240967,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2770.9690000000364,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.486,
"layouts": 7,
"layoutDurationMs": 1.9390000000000003,
"taskDurationMs": 1801.8929999999998,
"heapDeltaBytes": -22985992,
"heapUsedBytes": 61148544,
"domNodes": -274,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 863.1990000000001,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66586826347305,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3883.3849999999757,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.644,
"layouts": 64,
"layoutDurationMs": 11.057,
"taskDurationMs": 1907.265,
"heapDeltaBytes": 532048,
"heapUsedBytes": 84531872,
"domNodes": -250,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 821.952,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666379310344826,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3989.6439999999984,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.967,
"layouts": 65,
"layoutDurationMs": 10.527,
"taskDurationMs": 1946.756,
"heapDeltaBytes": 1531244,
"heapUsedBytes": 86210040,
"domNodes": -250,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 856.866,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66652719665272,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3159.591999999975,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.159999999999999,
"layouts": 5,
"layoutDurationMs": 1.0929999999999997,
"taskDurationMs": 2017.1580000000001,
"heapDeltaBytes": -15011920,
"heapUsedBytes": 72009328,
"domNodes": 0,
"jsHeapTotalBytes": 6905856,
"scriptDurationMs": 1005.465,
"eventListeners": 182,
"totalBlockingTimeMs": 29,
"frameDurationMs": 17.02192513368984,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3188.218000000006,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.376,
"layouts": 5,
"layoutDurationMs": 1.3940000000000003,
"taskDurationMs": 2079.894,
"heapDeltaBytes": -22316216,
"heapUsedBytes": 72241036,
"domNodes": 0,
"jsHeapTotalBytes": 7467008,
"scriptDurationMs": 1016.3229999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 29,
"frameDurationMs": 17.020212765957442,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3108.637999999985,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.2040000000000002,
"layouts": 5,
"layoutDurationMs": 1.2150000000000003,
"taskDurationMs": 833.087,
"heapDeltaBytes": -7858988,
"heapUsedBytes": 68038924,
"domNodes": -274,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 378.017,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258066,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3124.769000000015,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.5690000000000002,
"layouts": 6,
"layoutDurationMs": 1.4660000000000002,
"taskDurationMs": 833.1370000000001,
"heapDeltaBytes": 10897384,
"heapUsedBytes": 83786572,
"domNodes": -274,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 391.52899999999994,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665957446808513,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2043.641999999977,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.74,
"layouts": 8,
"layoutDurationMs": 2.665,
"taskDurationMs": 766.568,
"heapDeltaBytes": 1571492,
"heapUsedBytes": 86496936,
"domNodes": -274,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 40.585,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2043.068000000062,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.6049999999999995,
"layouts": 7,
"layoutDurationMs": 2.4040000000000004,
"taskDurationMs": 753.8020000000001,
"heapDeltaBytes": 6716512,
"heapUsedBytes": 82749284,
"domNodes": -274,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 40.364,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2946.698999999995,
"styleRecalcs": 26,
"styleRecalcDurationMs": 11.440999999999999,
"layouts": 6,
"layoutDurationMs": 1.5639999999999998,
"taskDurationMs": 650.8080000000001,
"heapDeltaBytes": -5890832,
"heapUsedBytes": 70428668,
"domNodes": -258,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 197.91500000000002,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.760795454545452,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2904.4639999999617,
"styleRecalcs": 25,
"styleRecalcDurationMs": 11.386999999999999,
"layouts": 6,
"layoutDurationMs": 1.4979999999999998,
"taskDurationMs": 662.905,
"heapDeltaBytes": 1935552,
"heapUsedBytes": 83307208,
"domNodes": -268,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 203.524,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666091954022985,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3324.955999999986,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.9040000000000004,
"layouts": 7,
"layoutDurationMs": 1.7689999999999997,
"taskDurationMs": 999.478,
"heapDeltaBytes": -23120628,
"heapUsedBytes": 61140648,
"domNodes": -274,
"jsHeapTotalBytes": 6156288,
"scriptDurationMs": 395.13899999999995,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66532663316583,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-topology-cadence",
"durationMs": 3368.9679999999953,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.9220000000000002,
"layouts": 6,
"layoutDurationMs": 1.7400000000000002,
"taskDurationMs": 1036.0240000000001,
"heapDeltaBytes": -10749072,
"heapUsedBytes": 74036720,
"domNodes": -274,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 402.583,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665841584158414,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 674.2449999999849,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.343000000000001,
"layouts": 9,
"layoutDurationMs": 2.4319999999999995,
"taskDurationMs": 466.267,
"heapDeltaBytes": -1214288,
"heapUsedBytes": 72742504,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 149.332,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667500000000008,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 668.700000000058,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.894,
"layouts": 8,
"layoutDurationMs": 2.668,
"taskDurationMs": 468.12399999999997,
"heapDeltaBytes": 24918664,
"heapUsedBytes": 86247412,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 152.317,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667500000000008,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2024.549000000036,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.2979999999999996,
"layouts": 9,
"layoutDurationMs": 2.4479999999999995,
"taskDurationMs": 575.001,
"heapDeltaBytes": 1203348,
"heapUsedBytes": 65528484,
"domNodes": -200,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 8.466000000000001,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2055.095000000051,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.0860000000000003,
"layouts": 9,
"layoutDurationMs": 2.714,
"taskDurationMs": 671.311,
"heapDeltaBytes": -20198952,
"heapUsedBytes": 54546100,
"domNodes": -200,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 10.867,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1737.0009999999638,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.360999999999999,
"layouts": 8,
"layoutDurationMs": 2.0280000000000005,
"taskDurationMs": 905.6580000000001,
"heapDeltaBytes": -15860096,
"heapUsedBytes": 55609320,
"domNodes": -200,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 112.586,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1742.0470000000705,
"styleRecalcs": 77,
"styleRecalcDurationMs": 15.288,
"layouts": 9,
"layoutDurationMs": 2.556,
"taskDurationMs": 940.6159999999999,
"heapDeltaBytes": -8908332,
"heapUsedBytes": 66733924,
"domNodes": -200,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 115.369,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1627.1839999999997,
"styleRecalcs": 19,
"styleRecalcDurationMs": 29.295,
"layouts": 5,
"layoutDurationMs": 20.734,
"taskDurationMs": 1473.0700000000004,
"heapDeltaBytes": 7062140,
"heapUsedBytes": 83990876,
"domNodes": -1320,
"jsHeapTotalBytes": 15728640,
"scriptDurationMs": 38.004000000000005,
"eventListeners": -262,
"totalBlockingTimeMs": 218,
"frameDurationMs": 20.37037037037037,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 10359.307999999999,
"styleRecalcs": 251,
"styleRecalcDurationMs": 29.447000000000003,
"layouts": 9,
"layoutDurationMs": 2.678,
"taskDurationMs": 6377.458,
"heapDeltaBytes": -6586372,
"heapUsedBytes": 83284752,
"domNodes": -274,
"jsHeapTotalBytes": 4812800,
"scriptDurationMs": 2843.118,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69274193548387,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9953.461999999945,
"styleRecalcs": 250,
"styleRecalcDurationMs": 28.556,
"layouts": 8,
"layoutDurationMs": 1.8550000000000002,
"taskDurationMs": 6321.504,
"heapDeltaBytes": -10225432,
"heapUsedBytes": 83081176,
"domNodes": -274,
"jsHeapTotalBytes": 5337088,
"scriptDurationMs": 2859.815,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66599664991625,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 24716.85199999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23879.836,
"heapDeltaBytes": -8288240,
"heapUsedBytes": 281488956,
"domNodes": -3482,
"jsHeapTotalBytes": 10043392,
"scriptDurationMs": 343.97200000000004,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.466256590509666,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-idle",
"durationMs": 24860.767999999895,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24014.631,
"heapDeltaBytes": -15983624,
"heapUsedBytes": 266269508,
"domNodes": -3482,
"jsHeapTotalBytes": 9945088,
"scriptDurationMs": 341.92,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.065857885615245,
"p95FrameDurationMs": 83.5
},
{
"name": "vue-large-graph-pan",
"durationMs": 29761.41100000001,
"styleRecalcs": 181,
"styleRecalcDurationMs": 21.468999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 29448.191000000003,
"heapDeltaBytes": -6426072,
"heapUsedBytes": 276208680,
"domNodes": -3482,
"jsHeapTotalBytes": 10473472,
"scriptDurationMs": 946.055,
"eventListeners": -659,
"totalBlockingTimeMs": 12,
"frameDurationMs": 56.990229885057474,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 29208.789000000026,
"styleRecalcs": 181,
"styleRecalcDurationMs": 18.99300000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28891.473,
"heapDeltaBytes": -8720912,
"heapUsedBytes": 274032300,
"domNodes": -3482,
"jsHeapTotalBytes": 9687040,
"scriptDurationMs": 889.2339999999999,
"eventListeners": -659,
"totalBlockingTimeMs": 5,
"frameDurationMs": 54.172170686456404,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 8857.011,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.81999999999998,
"layouts": 20,
"layoutDurationMs": 29.695,
"taskDurationMs": 8736.992,
"heapDeltaBytes": -45793416,
"heapUsedBytes": 251038476,
"domNodes": -3482,
"jsHeapTotalBytes": 11259904,
"scriptDurationMs": 136.26700000000002,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 49.25722222222222,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8815.687000000025,
"styleRecalcs": 20,
"styleRecalcDurationMs": 62.613,
"layouts": 20,
"layoutDurationMs": 22.02599999999999,
"taskDurationMs": 8667.839999999998,
"heapDeltaBytes": -4681000,
"heapUsedBytes": 285281212,
"domNodes": -3482,
"jsHeapTotalBytes": 17022976,
"scriptDurationMs": 124.07900000000001,
"eventListeners": -661,
"totalBlockingTimeMs": 12,
"frameDurationMs": 50.09318181818182,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-zoom-out-idle",
"durationMs": 12352.530000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11940.784999999998,
"heapDeltaBytes": 3133580,
"heapUsedBytes": 259356300,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 174.28900000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.293150684931504,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 12459.16699999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11915.877999999999,
"heapDeltaBytes": -4420556,
"heapUsedBytes": 259750264,
"domNodes": 0,
"jsHeapTotalBytes": -524288,
"scriptDurationMs": 168.23899999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.98689655172414,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "workflow-execution",
"durationMs": 162.19099999995024,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.764000000000001,
"layouts": 9,
"layoutDurationMs": 4.535000000000001,
"taskDurationMs": 121.592,
"heapDeltaBytes": 5306480,
"heapUsedBytes": 71381296,
"domNodes": 134,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 18.346999999999998,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.75,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "workflow-execution",
"durationMs": 498.1849999999213,
"styleRecalcs": 20,
"styleRecalcDurationMs": 11.191,
"layouts": 11,
"layoutDurationMs": 4.132000000000001,
"taskDurationMs": 135.988,
"heapDeltaBytes": -9301532,
"heapUsedBytes": 65242404,
"domNodes": 133,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 12.250999999999998,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 552.1420000000035,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.6679999999999999,
"layouts": 76,
"layoutDurationMs": 15.639,
"taskDurationMs": 509.57399999999996,
"heapDeltaBytes": -150528,
"heapUsedBytes": 47224120,
"domNodes": 4,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 254.08599999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 529.327999999964,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.635,
"layouts": 76,
"layoutDurationMs": 14.557,
"taskDurationMs": 488.33,
"heapDeltaBytes": -3217780,
"heapUsedBytes": 42631052,
"domNodes": 4,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 241.534,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 550.2290000000585,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.739,
"layouts": 76,
"layoutDurationMs": 13.968,
"taskDurationMs": 516.7819999999999,
"heapDeltaBytes": 696916,
"heapUsedBytes": 105967664,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 210.088,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.17272727272727,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 559.1239999999971,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.5870000000000002,
"layouts": 76,
"layoutDurationMs": 15.001999999999999,
"taskDurationMs": 517.891,
"heapDeltaBytes": -3711652,
"heapUsedBytes": 79619640,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 212.643,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E Coverage: 🟡 59.3% of linesCoverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3217 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure
Findings and check detailsExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Full docs: scripts/registry-census/README.md Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
🌾 Fallow: ✅ PassedFindings and check detailsFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (22 changed files).
Pre-existing findings are baselined in Full docs: ADR-DEVEX-LINT-0015 Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 0ed5cbfee06345165372814387d369049e15e8f8
🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (356)
Full docs: Frontend domain catalog Reproduce locallypnpm architecture:check |
…ross its three surfaces Moves the served-availability branches (hidden, disabled, aria-describedby, reason line) into AddCreditsButton and AddCreditsRefusalReason so the popover, Credits tile and Billing tab credits card templates stay under the fallow complexity gate on the 1.60 line.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.60 #22798 +/- ##
=============================================
Coverage ? 87.48%
=============================================
Files ? 2886
Lines ? 159220
Branches ? 42652
=============================================
Hits ? 139293
Misses ? 19163
Partials ? 764
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…gma (#22392) (#22856) ## Why The auto backport of #22392 to `cloud/1.60` conflicted. This keeps only the app-side style change, with no billing SDK code. ## Root cause The #22392 squash touches SDK files under `packages/account-ui` and sits on main code from #22711, #22746 and #22759 that 1.60 does not have. ## How Cherry-pick (`-x`) of the #22392 squash, then: - Taken: `src/` Billing tab components (`BillingTab.vue`, credits card, plan cell, auto top-up card, plan row), the new `BillingInfoTip.vue` and its test, the banner radius/stroke changes, `src/locales/en/main.json` copy, and the matching test updates. - Dropped: everything under `packages/` (`packages/account-ui/src/billing/tab/*`, restored to `origin/cloud/1.60`) and `BillingCreditsCard.parity.test.ts`, which does not exist on 1.60. - Conflicts: - `BillingCreditsCard.vue`: main uses `AddCreditsAction` (#22711). Kept 1.60's `AddCreditsButton` + `AddCreditsRefusalReason` markup (from #22797/#22798) and moved it into #22392's new top-up row, so Add credits centers on the Top-up label and value with "In use" below. Imports keep `@/platform/billing/components/billingTab/creditsCard`. - `BillingCreditsPlanCell.vue`: took `BillingInfoTip`; kept 1.60's `PlanCreditsState` import from `billingTab/creditsCard` instead of `@comfyorg/account-core/billing`. - Both files are identical on `core/1.60` and `cloud/1.60`, so the resolution matches the core backport. Everything else, including the auto top-up card and `BillingStatusBanner.vue`, applied cleanly. Verification on `cloud/1.60`: - `pnpm vitest run src/platform/billing src/platform/account`: 156 files, 4103 tests pass - `pnpm typecheck:app`: pass - `pnpm fallow:audit --base origin/cloud/1.60`: exit 0 - `pnpm architecture:check`: exit 0 AS IS / TO BE: same look as #22392; screenshots are in #22392. - Backport of #22392
…ma (#22392) (#22855) ## Why The auto backport of #22392 to `core/1.60` conflicted. This keeps only the app-side style change, with no billing SDK code. ## Root cause The #22392 squash touches SDK files under `packages/account-ui` and sits on main code from #22711, #22746 and #22759 that 1.60 does not have. ## How Cherry-pick (`-x`) of the #22392 squash, then: - Taken: `src/` Billing tab components (`BillingTab.vue`, credits card, plan cell, auto top-up card, plan row), the new `BillingInfoTip.vue` and its test, the banner radius/stroke changes, `src/locales/en/main.json` copy, and the matching test updates. - Dropped: everything under `packages/` (`packages/account-ui/src/billing/tab/*`, restored to `origin/core/1.60`) and `BillingCreditsCard.parity.test.ts`, which does not exist on 1.60. - Conflicts: - `BillingCreditsCard.vue`: main uses `AddCreditsAction` (#22711). Kept 1.60's `AddCreditsButton` + `AddCreditsRefusalReason` markup (from #22797/#22798) and moved it into #22392's new top-up row, so Add credits centers on the Top-up label and value with "In use" below. Imports keep `@/platform/billing/components/billingTab/creditsCard`. - `BillingCreditsPlanCell.vue`: took `BillingInfoTip`; kept 1.60's `PlanCreditsState` import from `billingTab/creditsCard` instead of `@comfyorg/account-core/billing`. - Everything else, including the auto top-up card, applied cleanly. Verification on `core/1.60`: - `pnpm vitest run src/platform/billing src/platform/account`: 156 files, 4111 tests pass - `pnpm typecheck:app`: pass - `pnpm fallow:audit --base origin/core/1.60`: exit 0 - `pnpm architecture:check`: exit 0 AS IS / TO BE: same look as #22392; screenshots are in #22392. - Backport of #22392
Why
The automatic
cloud/1.60backport of #22711 failed with conflicts: the merged change is built on #22746, which moved the Billing tab rules into the billing SDK and is After M4, so it must not go to 1.60.How
Cherry-picked the pre-SDK version of the change (e924b2e) instead of the merged squash, which depends on the After-M4 billing SDK refactor #22746. Conflicts were import-only in CreditsTile.vue and its test, resolved by keeping both sides; no packages/ files are touched.
The pre-SDK change put the availability branches inline in three templates, which pushed them over the fallow complexity gate (on main that logic lives in the SDK). A second commit moves the button and refusal line into
AddCreditsButtonandAddCreditsRefusalReason; behaviour is unchanged.Verified on this branch: billing, settings and workspace unit tests pass, and
pnpm typecheck:appis clean.AS IS / TO BE: same behaviour as #22711; screenshots are in #22711.