Repository navigation
[backport cloud/1.60] fix(billing): Billing tab style pass against Figma (#22392) - #22856
Conversation
Style pass of the ComfyUI Billing tab against [Figma](https://www.figma.com/design/C1fxz3akrW7Pl22zM2b301/?node-id=2017-24062). M4 fast follow-up, main only (1.60). - 48px from the workspace header to the first section (was 20), 24px from the handoff card to the footer (was 48), 24px below the footer. - Plan row and auto top-up buttons are centered in their cards; Add credits is centered on the Top-up label and value. - Buttons that leave the app use the up-right arrow and no underline: Turn on, Update payment, Contact sales, View usage, Open billing, Partner Nodes pricing. - Info tooltips use a help cursor and no hover fill (new `BillingInfoTip`), with the focus ring kept. - Tooltip copy follows Figma for Credits, Plan and Top-up. The credits-to-USD rate is removed. - "Refills credits when your balance runs low." gets its period. - Status dots: On, On hold, Limit reached and Turned off used classes missing from the theme, so the dots were invisible. They now use `bg-success`, `bg-warning` and `bg-destructive`. - The `platform.comfy.org` link and its underline turn white on hover. - The auto top-up loading skeleton is two unequal lines, matching an Off card's height. Cards with two lines under the title grow about 24px on load. - All Billing tab banners use a 12px radius and the same stroke as the cards; three were 16px, and all were at 60% opacity. The plan lifecycle banner also shows on Members. **Token styling is a follow-up.** Cards and banners share `border-border` with no card fill, so the blocks stand out without a design-system deviation. Figma shows a fainter stroke and a 2% fill; both wait on the charcoal scale and tokens change. - `pnpm exec vitest run src/platform/billing src/platform/account`; new `BillingInfoTip` test. - Human QA: local Cloud build against testcloud, Settings > Billing, measured against the Figma frame in Chrome. Checked the active-plan owner state only. - English strings only; the release pipeline retranslates the changed copy. --------- Co-authored-by: dante01yoon <bunggl@naver.com> (cherry picked from commit f4848d1)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 8 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-03T22:35:28.673Z",
"gitSha": "dfcfdff3a92d615b6d31ab9611d443e5d507ca0e",
"branch": "backport-22392-to-cloud-1.60",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2039.1120000000171,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.325,
"layouts": 9,
"layoutDurationMs": 2.3029999999999995,
"taskDurationMs": 568.511,
"heapDeltaBytes": -22775860,
"heapUsedBytes": 51171936,
"domNodes": -178,
"jsHeapTotalBytes": 12058624,
"scriptDurationMs": 8.498000000000003,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-idle",
"durationMs": 2024.946,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.5820000000000007,
"layouts": 10,
"layoutDurationMs": 2.685,
"taskDurationMs": 572.5819999999999,
"heapDeltaBytes": -5507456,
"heapUsedBytes": 68336016,
"domNodes": -178,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 7.7090000000000005,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1801.7509999999959,
"styleRecalcs": 76,
"styleRecalcDurationMs": 11.522,
"layouts": 8,
"layoutDurationMs": 2.108,
"taskDurationMs": 872.784,
"heapDeltaBytes": 23743660,
"heapUsedBytes": 84418496,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 159.308,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666666,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1768.150999999989,
"styleRecalcs": 74,
"styleRecalcDurationMs": 11.407,
"layouts": 10,
"layoutDurationMs": 2.7329999999999997,
"taskDurationMs": 863.11,
"heapDeltaBytes": 8807520,
"heapUsedBytes": 69260904,
"domNodes": -178,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 150.68900000000002,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666037735849056,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.764000000027,
"styleRecalcs": 20,
"styleRecalcDurationMs": 5.368000000000001,
"layouts": 11,
"layoutDurationMs": 3.149,
"taskDurationMs": 416.95300000000003,
"heapDeltaBytes": 10778108,
"heapUsedBytes": 83814500,
"domNodes": 57,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 11.161000000000001,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1714.2109999999775,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.253000000000001,
"layouts": 10,
"layoutDurationMs": 2.4530000000000003,
"taskDurationMs": 399.26599999999996,
"heapDeltaBytes": 25365996,
"heapUsedBytes": 85995536,
"domNodes": 57,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 9.365000000000002,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 644.486999999998,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.907,
"layouts": 10,
"layoutDurationMs": 2.739,
"taskDurationMs": 494.22700000000003,
"heapDeltaBytes": 3739528,
"heapUsedBytes": 65359648,
"domNodes": 0,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 174.013,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 678.5029999999779,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.6100000000000003,
"layouts": 9,
"layoutDurationMs": 2.3390000000000004,
"taskDurationMs": 503.904,
"heapDeltaBytes": -11832604,
"heapUsedBytes": 62148192,
"domNodes": 0,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 174.455,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66500000000001,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1179.8510000000135,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 887.442,
"heapDeltaBytes": -5670232,
"heapUsedBytes": 77645100,
"domNodes": -208,
"jsHeapTotalBytes": 15998976,
"scriptDurationMs": 64.755,
"eventListeners": -107,
"totalBlockingTimeMs": 510,
"frameDurationMs": 32.87222222222221,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1153.1219999999962,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 827.4330000000001,
"heapDeltaBytes": 23252336,
"heapUsedBytes": 89014732,
"domNodes": 0,
"jsHeapTotalBytes": 11960320,
"scriptDurationMs": 62.400999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 520,
"frameDurationMs": 33.8235294117647,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 843.9319999999952,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 491.35400000000027,
"heapDeltaBytes": -3247684,
"heapUsedBytes": 72941844,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 156.67000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 219,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 872.540000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 495.20299999999963,
"heapDeltaBytes": -3809720,
"heapUsedBytes": 72671128,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 155.16800000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 227,
"frameDurationMs": 25.488235294117658,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10563.573999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9761.048999999999,
"heapDeltaBytes": 39734544,
"heapUsedBytes": 115836776,
"domNodes": -274,
"jsHeapTotalBytes": 48361472,
"scriptDurationMs": 7748.793,
"eventListeners": -69,
"totalBlockingTimeMs": 1009,
"frameDurationMs": 31.491044776119402,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11647.463999999956,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10800.776999999998,
"heapDeltaBytes": 68928896,
"heapUsedBytes": 163396704,
"domNodes": -274,
"jsHeapTotalBytes": 85585920,
"scriptDurationMs": 8785.793,
"eventListeners": -69,
"totalBlockingTimeMs": 1375,
"frameDurationMs": 31.656521739130437,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11142.540999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10452.268,
"heapDeltaBytes": 99314064,
"heapUsedBytes": 174646640,
"domNodes": -274,
"jsHeapTotalBytes": 80605184,
"scriptDurationMs": 8447.938,
"eventListeners": -69,
"totalBlockingTimeMs": 1268,
"frameDurationMs": 31.407323943661968,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10847.67400000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10090.008,
"heapDeltaBytes": 79511404,
"heapUsedBytes": 154985580,
"domNodes": -274,
"jsHeapTotalBytes": 86372352,
"scriptDurationMs": 8097.128,
"eventListeners": -69,
"totalBlockingTimeMs": 1146,
"frameDurationMs": 31.308959537572253,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "large-combo-open",
"durationMs": 232.39599999999427,
"styleRecalcs": 23,
"styleRecalcDurationMs": 11.235000000000001,
"layouts": 10,
"layoutDurationMs": 2.3120000000000003,
"taskDurationMs": 188.95499999999998,
"heapDeltaBytes": -69020,
"heapUsedBytes": 75447176,
"domNodes": 699,
"jsHeapTotalBytes": -524288,
"scriptDurationMs": 8.776,
"eventListeners": 72,
"totalBlockingTimeMs": 3,
"frameDurationMs": 24.066666666666656,
"p95FrameDurationMs": 83.29999999999973
},
{
"name": "large-combo-open",
"durationMs": 208.6559999999622,
"styleRecalcs": 21,
"styleRecalcDurationMs": 13.037999999999998,
"layouts": 10,
"layoutDurationMs": 2.489,
"taskDurationMs": 159.89000000000001,
"heapDeltaBytes": 14891236,
"heapUsedBytes": 75739352,
"domNodes": 936,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.049,
"eventListeners": 205,
"totalBlockingTimeMs": 4,
"frameDurationMs": 27.075000000000045,
"p95FrameDurationMs": 100
},
{
"name": "large-graph-idle",
"durationMs": 2040.6619999999975,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.2380000000000004,
"layouts": 8,
"layoutDurationMs": 2.006,
"taskDurationMs": 666.6990000000001,
"heapDeltaBytes": -18461400,
"heapUsedBytes": 63640692,
"domNodes": -274,
"jsHeapTotalBytes": 126976,
"scriptDurationMs": 33.515,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406503,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2056.0239999999794,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.3930000000000002,
"layouts": 9,
"layoutDurationMs": 2.282,
"taskDurationMs": 654.943,
"heapDeltaBytes": -18583144,
"heapUsedBytes": 63665440,
"domNodes": -274,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 30.955999999999996,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2593.297000000007,
"styleRecalcs": 69,
"styleRecalcDurationMs": 7.8900000000000015,
"layouts": 7,
"layoutDurationMs": 1.9839999999999995,
"taskDurationMs": 1697.671,
"heapDeltaBytes": 4701792,
"heapUsedBytes": 87851368,
"domNodes": -274,
"jsHeapTotalBytes": 4546560,
"scriptDurationMs": 821.501,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666025641025637,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2481.924000000049,
"styleRecalcs": 69,
"styleRecalcDurationMs": 7.91,
"layouts": 8,
"layoutDurationMs": 1.9259999999999997,
"taskDurationMs": 1681.2199999999998,
"heapDeltaBytes": -296384,
"heapUsedBytes": 82742924,
"domNodes": -274,
"jsHeapTotalBytes": 5070848,
"scriptDurationMs": 825.264,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.779054054054054,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3854.363000000035,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.534999999999998,
"layouts": 65,
"layoutDurationMs": 10.455,
"taskDurationMs": 1809.0980000000002,
"heapDeltaBytes": -4856344,
"heapUsedBytes": 80968752,
"domNodes": -250,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 776.1309999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665800865800865,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3582.3110000000042,
"styleRecalcs": 71,
"styleRecalcDurationMs": 8.612000000000002,
"layouts": 65,
"layoutDurationMs": 9.728,
"taskDurationMs": 1758.9389999999999,
"heapDeltaBytes": -17559156,
"heapUsedBytes": 67522588,
"domNodes": -250,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 775.452,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666511627906978,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3127.949000000001,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.906000000000001,
"layouts": 5,
"layoutDurationMs": 1.4220000000000002,
"taskDurationMs": 2012.397,
"heapDeltaBytes": -4719540,
"heapUsedBytes": 81723844,
"domNodes": 0,
"jsHeapTotalBytes": 7565312,
"scriptDurationMs": 1003.3199999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 11,
"frameDurationMs": 17.025945945945946,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3218.678999999952,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.4830000000000005,
"layouts": 5,
"layoutDurationMs": 1.0109999999999997,
"taskDurationMs": 2077.767,
"heapDeltaBytes": -23185864,
"heapUsedBytes": 71587404,
"domNodes": 0,
"jsHeapTotalBytes": 8290304,
"scriptDurationMs": 1039.5539999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 18,
"frameDurationMs": 17.014659685863876,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3062.027999999998,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.7210000000000003,
"layouts": 7,
"layoutDurationMs": 1.411,
"taskDurationMs": 776.5300000000001,
"heapDeltaBytes": -8385096,
"heapUsedBytes": 68033844,
"domNodes": -274,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 351.472,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666120218579234,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3047.140000000013,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.6190000000000007,
"layouts": 7,
"layoutDurationMs": 1.543,
"taskDurationMs": 748.0640000000001,
"heapDeltaBytes": 3735160,
"heapUsedBytes": 87637200,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 359.06,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666120218579238,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2055.283999999972,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.64,
"layouts": 6,
"layoutDurationMs": 1.395,
"taskDurationMs": 690.2510000000001,
"heapDeltaBytes": 6260968,
"heapUsedBytes": 81750252,
"domNodes": -274,
"jsHeapTotalBytes": 2748416,
"scriptDurationMs": 33.348,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2046.6949999999997,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.7939999999999996,
"layouts": 7,
"layoutDurationMs": 1.7770000000000001,
"taskDurationMs": 639.094,
"heapDeltaBytes": -18600224,
"heapUsedBytes": 67651160,
"domNodes": -274,
"jsHeapTotalBytes": -360448,
"scriptDurationMs": 31.09,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2739.879999999999,
"styleRecalcs": 26,
"styleRecalcDurationMs": 12.14,
"layouts": 7,
"layoutDurationMs": 1.608,
"taskDurationMs": 535.967,
"heapDeltaBytes": 7240796,
"heapUsedBytes": 91889600,
"domNodes": 19,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 177.27100000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2752.8539999999566,
"styleRecalcs": 25,
"styleRecalcDurationMs": 10.965,
"layouts": 6,
"layoutDurationMs": 1.2849999999999997,
"taskDurationMs": 611.5540000000001,
"heapDeltaBytes": -4787548,
"heapUsedBytes": 77787960,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 183.491,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666060606060608,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3242.07100000001,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.4030000000000007,
"layouts": 6,
"layoutDurationMs": 1.262,
"taskDurationMs": 964.6070000000001,
"heapDeltaBytes": -33258900,
"heapUsedBytes": 62134032,
"domNodes": -274,
"jsHeapTotalBytes": 4882432,
"scriptDurationMs": 367.744,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665463917525773,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3305.2749999999946,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.079,
"layouts": 7,
"layoutDurationMs": 2.1409999999999996,
"taskDurationMs": 944.1529999999999,
"heapDeltaBytes": -6850504,
"heapUsedBytes": 77637200,
"domNodes": 0,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 385.08299999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.7507614213198,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 606.2039999999911,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.356,
"layouts": 9,
"layoutDurationMs": 2.4639999999999995,
"taskDurationMs": 426.45199999999994,
"heapDeltaBytes": 24874104,
"heapUsedBytes": 86095796,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 140.18,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 607.7660000000833,
"styleRecalcs": 45,
"styleRecalcDurationMs": 3.9900000000000007,
"layouts": 8,
"layoutDurationMs": 1.991,
"taskDurationMs": 441.58200000000005,
"heapDeltaBytes": -6288,
"heapUsedBytes": 60080572,
"domNodes": 0,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 145.07699999999997,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2055.1630000000214,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.5300000000000002,
"layouts": 9,
"layoutDurationMs": 2.846,
"taskDurationMs": 603.647,
"heapDeltaBytes": -6860252,
"heapUsedBytes": 54720512,
"domNodes": -200,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 8.148000000000001,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2041.6369999999233,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.1529999999999996,
"layouts": 9,
"layoutDurationMs": 2.419,
"taskDurationMs": 564.1480000000001,
"heapDeltaBytes": -1145984,
"heapUsedBytes": 74083436,
"domNodes": -200,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 7.393000000000001,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406507,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1725.4310000000146,
"styleRecalcs": 76,
"styleRecalcDurationMs": 13.677999999999999,
"layouts": 9,
"layoutDurationMs": 2.411,
"taskDurationMs": 878.0989999999999,
"heapDeltaBytes": 1315232,
"heapUsedBytes": 76045592,
"domNodes": -200,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 107.42599999999999,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1773.3009999999467,
"styleRecalcs": 81,
"styleRecalcDurationMs": 12.511000000000001,
"layouts": 10,
"layoutDurationMs": 2.3579999999999997,
"taskDurationMs": 872.875,
"heapDeltaBytes": 10926176,
"heapUsedBytes": 72674068,
"domNodes": -200,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 101.149,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666037735849056,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-transition-enter",
"durationMs": 1591.7059999999879,
"styleRecalcs": 18,
"styleRecalcDurationMs": 26.183000000000003,
"layouts": 5,
"layoutDurationMs": 18.838,
"taskDurationMs": 1331.091,
"heapDeltaBytes": 4390564,
"heapUsedBytes": 83999036,
"domNodes": -1320,
"jsHeapTotalBytes": 15204352,
"scriptDurationMs": 29.837999999999997,
"eventListeners": -262,
"totalBlockingTimeMs": 212,
"frameDurationMs": 20.511538461538468,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9871.951999999965,
"styleRecalcs": 251,
"styleRecalcDurationMs": 26.561999999999998,
"layouts": 8,
"layoutDurationMs": 1.9369999999999996,
"taskDurationMs": 6034.479,
"heapDeltaBytes": -18119804,
"heapUsedBytes": 64207476,
"domNodes": -274,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 2724.71,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6660472972973,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8855.456000000004,
"styleRecalcs": 251,
"styleRecalcDurationMs": 24.788,
"layouts": 8,
"layoutDurationMs": 1.94,
"taskDurationMs": 5853.771999999999,
"heapDeltaBytes": 9595184,
"heapUsedBytes": 83393508,
"domNodes": -274,
"jsHeapTotalBytes": 4022272,
"scriptDurationMs": 2659.983,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666101694915255,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16702.777999999966,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15677.664,
"heapDeltaBytes": -13121012,
"heapUsedBytes": 265628972,
"domNodes": -3482,
"jsHeapTotalBytes": 19906560,
"scriptDurationMs": 263.181,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.400170068027208,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-idle",
"durationMs": 23133.766000000036,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22341.427,
"heapDeltaBytes": -29505848,
"heapUsedBytes": 281058424,
"domNodes": -3482,
"jsHeapTotalBytes": 7061504,
"scriptDurationMs": 300.771,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.67821612349914,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-large-graph-pan",
"durationMs": 28205.21400000001,
"styleRecalcs": 181,
"styleRecalcDurationMs": 18.24999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27859.752999999997,
"heapDeltaBytes": -5497416,
"heapUsedBytes": 276634732,
"domNodes": -3482,
"jsHeapTotalBytes": 14667776,
"scriptDurationMs": 879.776,
"eventListeners": -659,
"totalBlockingTimeMs": 53,
"frameDurationMs": 52.542830540037244,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 27998.309000000063,
"styleRecalcs": 181,
"styleRecalcDurationMs": 16.843999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27645.250000000004,
"heapDeltaBytes": -30726048,
"heapUsedBytes": 271742176,
"domNodes": -3482,
"jsHeapTotalBytes": 15978496,
"scriptDurationMs": 865.516,
"eventListeners": -659,
"totalBlockingTimeMs": 32,
"frameDurationMs": 53.740690978886754,
"p95FrameDurationMs": 116.69999999999709
},
{
"name": "vue-node-resize-workload",
"durationMs": 8396.874999999965,
"styleRecalcs": 20,
"styleRecalcDurationMs": 58.01799999999999,
"layouts": 20,
"layoutDurationMs": 22.209000000000007,
"taskDurationMs": 8297.629,
"heapDeltaBytes": -36751360,
"heapUsedBytes": 253702244,
"domNodes": -3482,
"jsHeapTotalBytes": 13877248,
"scriptDurationMs": 124.073,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 48.2735632183908,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8317.243000000075,
"styleRecalcs": 20,
"styleRecalcDurationMs": 63.416,
"layouts": 20,
"layoutDurationMs": 25.55900000000001,
"taskDurationMs": 8170.833999999999,
"heapDeltaBytes": -41628,
"heapUsedBytes": 284072468,
"domNodes": -3482,
"jsHeapTotalBytes": 17809408,
"scriptDurationMs": 144.45200000000003,
"eventListeners": -661,
"totalBlockingTimeMs": 3,
"frameDurationMs": 47.795402298850576,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11764.534000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11479.435000000001,
"heapDeltaBytes": 5718344,
"heapUsedBytes": 279257496,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 149.38799999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.79722222222223,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11388.033000000065,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11087.826000000001,
"heapDeltaBytes": 5775312,
"heapUsedBytes": 283729248,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 147.29700000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.36524822695036,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "workflow-execution",
"durationMs": 143.95999999999276,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.395000000000001,
"layouts": 9,
"layoutDurationMs": 3.7800000000000002,
"taskDurationMs": 104.74499999999999,
"heapDeltaBytes": -11680412,
"heapUsedBytes": 62946940,
"domNodes": 128,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 8.886999999999999,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662500000000023,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 126.30899999999201,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.045,
"layouts": 9,
"layoutDurationMs": 3.109,
"taskDurationMs": 92.953,
"heapDeltaBytes": -12907908,
"heapUsedBytes": 61239272,
"domNodes": 128,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 6.781000000000001,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.67142857142861,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 447.07899999991696,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.629,
"layouts": 76,
"layoutDurationMs": 13.897,
"taskDurationMs": 409.683,
"heapDeltaBytes": -4169140,
"heapUsedBytes": 41321872,
"domNodes": 4,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 201.12199999999999,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428573,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 454.9890000000687,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.615,
"layouts": 76,
"layoutDurationMs": 13.889000000000001,
"taskDurationMs": 408.039,
"heapDeltaBytes": -4293428,
"heapUsedBytes": 42186024,
"domNodes": 4,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 197.61399999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428573,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 560.4339999999866,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.4829999999999999,
"layouts": 76,
"layoutDurationMs": 14.023000000000001,
"taskDurationMs": 527.118,
"heapDeltaBytes": 957324,
"heapUsedBytes": 103267064,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 227.583,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667647058823523,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 493.4489999999414,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.443,
"layouts": 76,
"layoutDurationMs": 12.942,
"taskDurationMs": 463.944,
"heapDeltaBytes": 733148,
"heapUsedBytes": 101685936,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 193.789,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
}
]
}🎭 Playwright: ✅ 3220 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure
Findings and check detailsExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Full docs: scripts/registry-census/README.md Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
🌾 Fallow: ✅ PassedFindings and check detailsFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Full docs: ADR-DEVEX-LINT-0015 Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 9df30fe0e936875751301415ae66058c4b2535df
🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (356)
Full docs: Frontend domain catalog Reproduce locallypnpm architecture:check |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.60 #22856 +/- ##
=============================================
Coverage ? 87.50%
=============================================
Files ? 2889
Lines ? 159381
Branches ? 40675
=============================================
Hits ? 139466
Misses ? 19150
Partials ? 765
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Why
The auto backport of #22392 to
cloud/1.60conflicted. This keeps only the app-side style change, with no billing SDK code.Root cause
The #22392 squash touches SDK files under
packages/account-uiand sits on main code from #22711, #22746 and #22759 that 1.60 does not have.How
Cherry-pick (
-x) of the #22392 squash, then:src/Billing tab components (BillingTab.vue, credits card, plan cell, auto top-up card, plan row), the newBillingInfoTip.vueand its test, the banner radius/stroke changes,src/locales/en/main.jsoncopy, and the matching test updates.packages/(packages/account-ui/src/billing/tab/*, restored toorigin/cloud/1.60) andBillingCreditsCard.parity.test.ts, which does not exist on 1.60.BillingCreditsCard.vue: main usesAddCreditsAction(M4 feat(billing): show refused Add credits disabled with the served reason #22711). Kept 1.60'sAddCreditsButton+AddCreditsRefusalReasonmarkup (from [backport core/1.60] M4 feat(billing): show refused Add credits disabled with the served reason (#22711) #22797/[backport cloud/1.60] M4 feat(billing): show refused Add credits disabled with the served reason (#22711) #22798) and moved it into fix(billing): Billing tab style pass against Figma #22392's new top-up row, so Add credits centers on the Top-up label and value with "In use" below. Imports keep@/platform/billing/components/billingTab/creditsCard.BillingCreditsPlanCell.vue: tookBillingInfoTip; kept 1.60'sPlanCreditsStateimport frombillingTab/creditsCardinstead of@comfyorg/account-core/billing.core/1.60andcloud/1.60, so the resolution matches the core backport. Everything else, including the auto top-up card andBillingStatusBanner.vue, applied cleanly.Verification on
cloud/1.60:pnpm vitest run src/platform/billing src/platform/account: 156 files, 4103 tests passpnpm typecheck:app: passpnpm fallow:audit --base origin/cloud/1.60: exit 0pnpm architecture:check: exit 0AS IS / TO BE: same look as #22392; screenshots are in #22392.