Repository navigation
[backport core/1.58] fix(billing): report a failed background balance read instead of leaving it unhandled (#22201) - #22316
Conversation
…ead of leaving it unhandled (#22201) Opening the account menu (legacy or workspace) or the Credits settings section starts a balance read that nothing awaits. When it fails, the rejection is unhandled, so Sentry files it as a new high-priority error. Now: - the failure is reported as a `billing` warning (`error_refreshing_balance`), at most once every five minutes, so reopening the menu during an outage does not repeat it; - a workspace balance read that a newer read has replaced settles quietly instead of rejecting, matching the rail path's `SUPERSEDED` handling, so the warning only covers failures the billing state actually kept; - the same applies across a workspace switch. A balance read for the previous workspace could still land after the switch replaced the billing adapter, writing that workspace's balance into the discarded adapter or reporting a warning for a failure the billing state never kept. `fetchStatus` already captured and rechecked the workspace id, so `fetchBalance` now shares that guard rather than carrying a second copy. What the user sees is unchanged. Note that the two popovers still show 0 credits when the read fails; that display bug is tracked separately in https://linear.app/comfyorg/issue/FRONT-3164. Evidence: both events of Sentry `CLOUD-FRONTEND-PROD-2V0` ("AuthStoreError: Failed to fetch balance: Balance temporarily unavailable") are `onunhandledrejection` from `useLegacyBilling.fetchBalance`, right after a 503 from `/customers/balance`. #21322 now retries that 503; this covers the failure left after the retries run out. Linear: https://linear.app/comfyorg/issue/FRONT-3684 - Red before the fix, green after: one test per call site (`CurrentUserPopoverLegacy`, `CurrentUserPopoverWorkspace`, `SettingDialog` Credits section), the helper's five-minute report budget, `useWorkspaceBilling` settling a superseded failed read, and `useWorkspaceBilling` dropping a balance read on both paths once the workspace changed. - `pnpm typecheck`, oxlint, oxfmt and the pre-push fallow audit pass. - After release: `CLOUD-FRONTEND-PROD-2V0` gets no new unhandled events; a persistent balance outage shows up as `error_refreshing_balance` warnings instead.
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-30T00:16:38.699Z",
"gitSha": "c547d04488f7526917b21983c816f401f7a1c42f",
"branch": "backport-22201-to-core-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2026.0429999999872,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.9490000000000003,
"layouts": 9,
"layoutDurationMs": 2.8010000000000006,
"taskDurationMs": 436.071,
"heapDeltaBytes": 2460484,
"heapUsedBytes": 92716944,
"domNodes": -200,
"jsHeapTotalBytes": 851968,
"scriptDurationMs": 9.108999999999998,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2023.1670000000008,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.463,
"layouts": 10,
"layoutDurationMs": 3.2510000000000003,
"taskDurationMs": 552.145,
"heapDeltaBytes": 4146728,
"heapUsedBytes": 104073736,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 10.927000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1808.0590000000143,
"styleRecalcs": 77,
"styleRecalcDurationMs": 13.017999999999999,
"layouts": 9,
"layoutDurationMs": 2.568,
"taskDurationMs": 933.899,
"heapDeltaBytes": -673040,
"heapUsedBytes": 89575120,
"domNodes": -204,
"jsHeapTotalBytes": 1638400,
"scriptDurationMs": 164.436,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665740740740738,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1759.7899999999527,
"styleRecalcs": 73,
"styleRecalcDurationMs": 13.802,
"layouts": 9,
"layoutDurationMs": 2.719,
"taskDurationMs": 847.264,
"heapDeltaBytes": 6167220,
"heapUsedBytes": 96517828,
"domNodes": -180,
"jsHeapTotalBytes": 2949120,
"scriptDurationMs": 173.90800000000002,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666981132075474,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.104999999999,
"styleRecalcs": 19,
"styleRecalcDurationMs": 6.719,
"layouts": 11,
"layoutDurationMs": 3.7439999999999998,
"taskDurationMs": 465.267,
"heapDeltaBytes": 25469476,
"heapUsedBytes": 115665664,
"domNodes": 47,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 14.695000000000004,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.4519999999893,
"styleRecalcs": 19,
"styleRecalcDurationMs": 6.215,
"layouts": 11,
"layoutDurationMs": 3.513,
"taskDurationMs": 463.83399999999995,
"heapDeltaBytes": 25480984,
"heapUsedBytes": 115690296,
"domNodes": 47,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 15.54,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 661.5239999999858,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.993,
"layouts": 9,
"layoutDurationMs": 2.521,
"taskDurationMs": 469.974,
"heapDeltaBytes": 4224724,
"heapUsedBytes": 94481880,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 178.354,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664102564102567,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 629.4040000000223,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.367,
"layouts": 10,
"layoutDurationMs": 2.7360000000000007,
"taskDurationMs": 461.05300000000005,
"heapDeltaBytes": 4161784,
"heapUsedBytes": 94464412,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 178.21499999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66486486486485,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1197.5140000000124,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 854.296,
"heapDeltaBytes": -3577084,
"heapUsedBytes": 102470100,
"domNodes": -230,
"jsHeapTotalBytes": 7229440,
"scriptDurationMs": 72.192,
"eventListeners": -168,
"totalBlockingTimeMs": 523,
"frameDurationMs": 32.432432432432435,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1193.0380000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 902.1250000000001,
"heapDeltaBytes": -14963988,
"heapUsedBytes": 102696468,
"domNodes": -230,
"jsHeapTotalBytes": 15540224,
"scriptDurationMs": 70.918,
"eventListeners": -168,
"totalBlockingTimeMs": 511,
"frameDurationMs": 32.42972972972974,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 844.3359999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 484.38200000000006,
"heapDeltaBytes": -3425668,
"heapUsedBytes": 94661264,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 158.75799999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 212,
"frameDurationMs": 25.00000000000003,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 843.6919999999759,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.23799999999994,
"heapDeltaBytes": -4987124,
"heapUsedBytes": 96963872,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 158.18599999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 220,
"frameDurationMs": 25.00000000000003,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10506.832000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9679.539,
"heapDeltaBytes": 46191088,
"heapUsedBytes": 150102208,
"domNodes": -296,
"jsHeapTotalBytes": 24969216,
"scriptDurationMs": 8021.422,
"eventListeners": -130,
"totalBlockingTimeMs": 1322,
"frameDurationMs": 33.17373417721519,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9551.126000000011,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8698.563,
"heapDeltaBytes": 44444088,
"heapUsedBytes": 132121748,
"domNodes": -276,
"jsHeapTotalBytes": 37224448,
"scriptDurationMs": 7200.923000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 705,
"frameDurationMs": 32.0973063973064,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10850.060999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10043.339000000002,
"heapDeltaBytes": 36495444,
"heapUsedBytes": 158301992,
"domNodes": -296,
"jsHeapTotalBytes": 37318656,
"scriptDurationMs": 8077.785000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 980,
"frameDurationMs": 31.72368421052631,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11581.70100000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10644.835,
"heapDeltaBytes": 63258668,
"heapUsedBytes": 167203712,
"domNodes": -276,
"jsHeapTotalBytes": 63242240,
"scriptDurationMs": 8999.348000000002,
"eventListeners": -130,
"totalBlockingTimeMs": 1859,
"frameDurationMs": 34.21952662721894,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "large-combo-open",
"durationMs": 232.76999999998793,
"styleRecalcs": 23,
"styleRecalcDurationMs": 13.886,
"layouts": 10,
"layoutDurationMs": 3.053,
"taskDurationMs": 181.78499999999997,
"heapDeltaBytes": 13236904,
"heapUsedBytes": 121461548,
"domNodes": 917,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 8.349000000000002,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.209090909090925,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 225.6720000000314,
"styleRecalcs": 24,
"styleRecalcDurationMs": 14.043,
"layouts": 11,
"layoutDurationMs": 3.175,
"taskDurationMs": 167.83100000000002,
"heapDeltaBytes": 13159452,
"heapUsedBytes": 121558960,
"domNodes": 917,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.54,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.199999999999985,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2024.503999999979,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.680999999999999,
"layouts": 8,
"layoutDurationMs": 2.1879999999999997,
"taskDurationMs": 492.864,
"heapDeltaBytes": -26974436,
"heapUsedBytes": 94293984,
"domNodes": -297,
"jsHeapTotalBytes": -2965504,
"scriptDurationMs": 34.41,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66557377049181,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2055.7529999999815,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.798,
"layouts": 8,
"layoutDurationMs": 2.4499999999999997,
"taskDurationMs": 752.818,
"heapDeltaBytes": -25799976,
"heapUsedBytes": 86671948,
"domNodes": -306,
"jsHeapTotalBytes": -2355200,
"scriptDurationMs": 42.479,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2401.1580000000095,
"styleRecalcs": 67,
"styleRecalcDurationMs": 8.827,
"layouts": 6,
"layoutDurationMs": 1.8609999999999998,
"taskDurationMs": 1619.976,
"heapDeltaBytes": -2712816,
"heapUsedBytes": 108500088,
"domNodes": -296,
"jsHeapTotalBytes": 290816,
"scriptDurationMs": 859.777,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.783098591549294,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2292.549000000008,
"styleRecalcs": 67,
"styleRecalcDurationMs": 8.856,
"layouts": 6,
"layoutDurationMs": 1.8899999999999997,
"taskDurationMs": 1636.8039999999996,
"heapDeltaBytes": 2121064,
"heapUsedBytes": 113349156,
"domNodes": -276,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 859.508,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.03955223880597,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3606.7429999999945,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.446,
"layouts": 64,
"layoutDurationMs": 10.525,
"taskDurationMs": 1689.87,
"heapDeltaBytes": -22193292,
"heapUsedBytes": 91212208,
"domNodes": -272,
"jsHeapTotalBytes": -589824,
"scriptDurationMs": 796.24,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.743720930232556,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3624.680999999896,
"styleRecalcs": 72,
"styleRecalcDurationMs": 10.948000000000002,
"layouts": 65,
"layoutDurationMs": 11.597,
"taskDurationMs": 1682.6950000000002,
"heapDeltaBytes": 7177052,
"heapUsedBytes": 119939484,
"domNodes": 24,
"jsHeapTotalBytes": 4460544,
"scriptDurationMs": 815.1089999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635944700461,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3321.82499999999,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.619,
"layouts": 5,
"layoutDurationMs": 1.6079999999999997,
"taskDurationMs": 2161.937,
"heapDeltaBytes": -1926056,
"heapUsedBytes": 112449448,
"domNodes": -276,
"jsHeapTotalBytes": 614400,
"scriptDurationMs": 1007.5290000000001,
"eventListeners": -121,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.92091836734694,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3176.2480000001005,
"styleRecalcs": 42,
"styleRecalcDurationMs": 5.084999999999999,
"layouts": 3,
"layoutDurationMs": 0.9890000000000003,
"taskDurationMs": 2081.137,
"heapDeltaBytes": -16043684,
"heapUsedBytes": 91711188,
"domNodes": 0,
"jsHeapTotalBytes": -36864,
"scriptDurationMs": 1019.736,
"eventListeners": 182,
"totalBlockingTimeMs": 26,
"frameDurationMs": 17.203763440860214,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2047.6899999999887,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.4739999999999998,
"layouts": 7,
"layoutDurationMs": 2.183,
"taskDurationMs": 609.3980000000001,
"heapDeltaBytes": 498704,
"heapUsedBytes": 112907324,
"domNodes": -276,
"jsHeapTotalBytes": -720896,
"scriptDurationMs": 39.44,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2046.5370000000576,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.653999999999999,
"layouts": 7,
"layoutDurationMs": 2.7209999999999996,
"taskDurationMs": 606.642,
"heapDeltaBytes": -298860,
"heapUsedBytes": 112891572,
"domNodes": -296,
"jsHeapTotalBytes": -983040,
"scriptDurationMs": 39.971,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 606.5199999999891,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.117999999999999,
"layouts": 8,
"layoutDurationMs": 2.652,
"taskDurationMs": 402.46500000000003,
"heapDeltaBytes": -636864,
"heapUsedBytes": 90701328,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 152.70499999999998,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663888888888877,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 659.4310000000405,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.095,
"layouts": 8,
"layoutDurationMs": 2.436,
"taskDurationMs": 471.46999999999997,
"heapDeltaBytes": -976200,
"heapUsedBytes": 89445780,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 149.345,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2042.096000000015,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.94,
"layouts": 10,
"layoutDurationMs": 2.745,
"taskDurationMs": 427.105,
"heapDeltaBytes": 10469316,
"heapUsedBytes": 101433584,
"domNodes": -198,
"jsHeapTotalBytes": 851968,
"scriptDurationMs": 9.583,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406507,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2056.7859999999882,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.3369999999999997,
"layouts": 9,
"layoutDurationMs": 3.028,
"taskDurationMs": 625.8280000000001,
"heapDeltaBytes": -1903188,
"heapUsedBytes": 89429388,
"domNodes": -218,
"jsHeapTotalBytes": 2949120,
"scriptDurationMs": 11.697000000000003,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406507,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1995.1499999999953,
"styleRecalcs": 87,
"styleRecalcDurationMs": 15.327,
"layouts": 9,
"layoutDurationMs": 2.534,
"taskDurationMs": 990.651,
"heapDeltaBytes": -1929640,
"heapUsedBytes": 89088976,
"domNodes": -210,
"jsHeapTotalBytes": 2424832,
"scriptDurationMs": 118.73599999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 2025.9119999999484,
"styleRecalcs": 90,
"styleRecalcDurationMs": 16.44,
"layouts": 9,
"layoutDurationMs": 2.866,
"taskDurationMs": 1166.32,
"heapDeltaBytes": 2337988,
"heapUsedBytes": 93251796,
"domNodes": -190,
"jsHeapTotalBytes": 2162688,
"scriptDurationMs": 119.821,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1000.3110000000106,
"styleRecalcs": 18,
"styleRecalcDurationMs": 26.346000000000007,
"layouts": 5,
"layoutDurationMs": 16.503999999999998,
"taskDurationMs": 790.6850000000001,
"heapDeltaBytes": 35534596,
"heapUsedBytes": 135876856,
"domNodes": 16030,
"jsHeapTotalBytes": 16654336,
"scriptDurationMs": 26.379,
"eventListeners": 3244,
"totalBlockingTimeMs": 165,
"frameDurationMs": 21.73913043478261,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8369.516000000032,
"styleRecalcs": 251,
"styleRecalcDurationMs": 30.179000000000002,
"layouts": 8,
"layoutDurationMs": 2.0989999999999998,
"taskDurationMs": 5381.111,
"heapDeltaBytes": -1600488,
"heapUsedBytes": 108644116,
"domNodes": -296,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 2740.8540000000003,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66613545816733,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 10607.297000000017,
"styleRecalcs": 250,
"styleRecalcDurationMs": 30.819999999999997,
"layouts": 8,
"layoutDurationMs": 2.605,
"taskDurationMs": 6363.084,
"heapDeltaBytes": -22185528,
"heapUsedBytes": 102592696,
"domNodes": -297,
"jsHeapTotalBytes": -647168,
"scriptDurationMs": 2791.14,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69228346456693,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 22804.231000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22201.537,
"heapDeltaBytes": -30099764,
"heapUsedBytes": 294082536,
"domNodes": -3344,
"jsHeapTotalBytes": 12832768,
"scriptDurationMs": 308.612,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.82885304659498,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-large-graph-idle",
"durationMs": 16357.267999999976,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15569.945,
"heapDeltaBytes": -44877704,
"heapUsedBytes": 288737736,
"domNodes": -3344,
"jsHeapTotalBytes": 17813504,
"scriptDurationMs": 248.663,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.225178571428568,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-pan",
"durationMs": 28600.464999999986,
"styleRecalcs": 181,
"styleRecalcDurationMs": 23.036,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28254.166,
"heapDeltaBytes": -17471288,
"heapUsedBytes": 289359372,
"domNodes": -3344,
"jsHeapTotalBytes": -4538368,
"scriptDurationMs": 947.6399999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 11,
"frameDurationMs": 53.85856873822975,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 19116.719999999987,
"styleRecalcs": 145,
"styleRecalcDurationMs": 13.969000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18686.422,
"heapDeltaBytes": -12107460,
"heapUsedBytes": 298260960,
"domNodes": -3344,
"jsHeapTotalBytes": 20959232,
"scriptDurationMs": 783.684,
"eventListeners": -651,
"totalBlockingTimeMs": 18,
"frameDurationMs": 35.139338235294126,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 8396.781000000032,
"styleRecalcs": 20,
"styleRecalcDurationMs": 90.203,
"layouts": 20,
"layoutDurationMs": 25.53799999999999,
"taskDurationMs": 8302.583999999999,
"heapDeltaBytes": -39159076,
"heapUsedBytes": 266056324,
"domNodes": -3344,
"jsHeapTotalBytes": 5754880,
"scriptDurationMs": 127.66,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 49.311176470588244,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8269.964999999956,
"styleRecalcs": 20,
"styleRecalcDurationMs": 65.22900000000001,
"layouts": 20,
"layoutDurationMs": 21.82200000000001,
"taskDurationMs": 8177.871,
"heapDeltaBytes": -4001304,
"heapUsedBytes": 301239408,
"domNodes": -3344,
"jsHeapTotalBytes": 14405632,
"scriptDurationMs": 115.957,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 48.0593023255814,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11403.64999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11104.358000000002,
"heapDeltaBytes": -1013492,
"heapUsedBytes": 271385756,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 159.478,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.17353951890034,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8093.124999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7504.4710000000005,
"heapDeltaBytes": 54028,
"heapUsedBytes": 297531896,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 117.52600000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.399661016949146,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "workflow-execution",
"durationMs": 488.1749999999556,
"styleRecalcs": 23,
"styleRecalcDurationMs": 11.543000000000001,
"layouts": 10,
"layoutDurationMs": 4.686,
"taskDurationMs": 137.86700000000002,
"heapDeltaBytes": 7200052,
"heapUsedBytes": 97775848,
"domNodes": 124,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.374999999999998,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 114.29899999995996,
"styleRecalcs": 7,
"styleRecalcDurationMs": 8.054,
"layouts": 7,
"layoutDurationMs": 3.3,
"taskDurationMs": 83.62299999999999,
"heapDeltaBytes": 4662916,
"heapUsedBytes": 95384056,
"domNodes": 116,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.538999999999999,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.44999999999997,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 500.4000000000133,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.691,
"layouts": 76,
"layoutDurationMs": 15.715,
"taskDurationMs": 460.545,
"heapDeltaBytes": -14283788,
"heapUsedBytes": 79226296,
"domNodes": 4,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 227.166,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66451612903227,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 465.56199999997716,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.8260000000000001,
"layouts": 76,
"layoutDurationMs": 14.411999999999999,
"taskDurationMs": 422.519,
"heapDeltaBytes": -14244284,
"heapUsedBytes": 79415048,
"domNodes": 4,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 202.345,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 551.8429999999626,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.9040000000000001,
"layouts": 76,
"layoutDurationMs": 14.589,
"taskDurationMs": 514.8240000000001,
"heapDeltaBytes": 822336,
"heapUsedBytes": 115847660,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 212.016,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.172727272727293,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 527.6360000000295,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.591,
"layouts": 76,
"layoutDurationMs": 13.991,
"taskDurationMs": 495.99,
"heapDeltaBytes": 576796,
"heapUsedBytes": 112896804,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 200.428,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageLine coverage: 59.9% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2984 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since e9f2858862c0a5c2f915fdd55d44a888882cdcd6
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (133)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
dante01yoon
left a comment
There was a problem hiding this comment.
Reviewed 53a9ab6 against the merged parent and the 1.59 backports. The 1.58 directory/import adaptations preserve the same background failure handling, workspace/request ownership checks and warning budget while retaining workspaceApi. Own isolated-checkout validation: 186 tests across all five affected suites, application type check and scoped lint/format PASS. Independently reverting each of the three call-site handlers, dropping stale-rejection suppression or dropping the five-minute report budget each fails retained regressions; the restored 186-test run passes. No remaining code blocker.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.58 #22316 +/- ##
=============================================
- Coverage 84.02% 84.02% -0.01%
=============================================
Files 3175 3176 +1
Lines 165818 165831 +13
Branches 39558 39539 -19
=============================================
+ Hits 139336 139340 +4
- Misses 26090 26099 +9
Partials 392 392
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 14 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Manual backport of #22201 (
44cf08fb7b) tocore/1.58. The auto-backport failed on conflicts.What
Opening the account menu or the Credits settings section starts a balance read nobody awaits. When it fails, the rejection is unhandled and Sentry files a new error. With this change it is reported as one
billingwarning at most every 5 minutes, and a balance read replaced by a newer read (or by a workspace switch) settles quietly.Conflict resolution for 1.58
1.58 predates the billing directory move, so the change lands at the 1.58 paths:
src/platform/workspace/refreshBalanceInBackground.ts(main:src/platform/billing/), importing@/platform/telemetry/reportError(1.58 has no@comfyorg/telemetrypackage).useWorkspaceBilling.ts(undersrc/platform/workspace/composables/) took the sharedisStaleBillingReadguard cleanly; reads still go throughworkspaceApi.SettingDialog.vueand their tests: kept the 1.58 imports (@/composables/billing/*) and added only the helper andreportErrorimports.reportErrormock, so the four new tests mock it withvi.mock(import('@/platform/telemetry/reportError')).Verification
pnpm typecheck:app, oxfmt and oxlint pass.Linear: https://linear.app/comfyorg/issue/FRONT-3684