Repository navigation
[backport core/1.58] feat(telemetry): record requests the shared status retry retried and how they ended (#22204) - #22325
Conversation
…etried and how they ended (#22204) nothing records that a retry happened, so a backend that fails often but recovers on retry looks healthy. This records one `app:fetch_status_retry` event per request that hit a retryable status: a Datadog RUM action and a Sentry breadcrumb with transport, method, host, route group, attempts, last status and outcome (`recovered`, `exhausted`, `retry_after_too_long`, `timeout_budget`, `failed`). Retry behaviour is unchanged. Design calls worth a look: - One pure classifier (`classifyStatusRetry`) decides the outcome from how each transport's loop ended. A retry that ends on a 500/404 or with no response is `failed`, not `recovered`. The request timeout (`TimeoutError` abort on fetch, `ECONNABORTED`/`ETIMEDOUT` on axios) is told apart from a caller cancel, which records nothing. - Routes reuse the allowlisted route groups of `app:fetch_timeout` (`getFetchRouteTemplate`, moved from `api.ts` to `src/utils/fetchRouteTemplate.ts`, now also `billing`, `customers`, `workspaces`), so user-chosen names never leave the client and the two events join on `route`. Side effect: `app:fetch_timeout` for those three groups now reports the group instead of `/other`. - At most 20 events per host/route/outcome per minute, so an outage cannot flood RUM while a long-lived tab keeps reporting. Hosts outside `comfy.org` and the page's own host report as `other`. - Recording can never throw into a request. - `retryDelayMs` is replaced by `nextRetry`, which also says why it stopped. Linear: https://linear.app/comfyorg/issue/FRONT-3683 - New cases red against the first cut of this change, green now: per-outcome tables for both transports, timeout vs cancel, route redaction, the per-key cap, telemetry throwing, opt-out reads; plus a classifier table and provider tests (Datadog action, Sentry breadcrumb level). - 2,200+ tests in `src/utils`, `src/scripts`, auth, workspace API, settings and telemetry providers pass. `pnpm typecheck`, knip, oxlint, oxfmt and the pre-push fallow audit pass. - An independent adversarial review (Skeptic, Architect, Minimalist; fresh Claude reviewers, since the cross-model CLI is unavailable on this host) ran on the first cut; its findings (mislabelled `recovered`, timeout classification, duplicated mapping, weak route scrubbing, unbounded volume, telemetry inside the request `try`) are fixed here. Panel, CodeRabbit and review findings on 0531273 are fixed in 37b5a87 and the per-minute cap commit. - After release: in Datadog RUM, `@action.name:app:fetch_status_retry` grouped by `@context.route` and `@context.outcome`.
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-30T01:00:08.377Z",
"gitSha": "e3e41f1444307fd4726989e0aee8db2cd1fa07c4",
"branch": "backport-22204-to-core-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2026.8410000000188,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.239,
"layouts": 9,
"layoutDurationMs": 2.255,
"taskDurationMs": 338.52500000000003,
"heapDeltaBytes": 7526464,
"heapUsedBytes": 97635328,
"domNodes": -180,
"jsHeapTotalBytes": 2949120,
"scriptDurationMs": 7.908999999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-idle",
"durationMs": 2041.8569999999931,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.7960000000000003,
"layouts": 10,
"layoutDurationMs": 2.799,
"taskDurationMs": 351.541,
"heapDeltaBytes": 3582520,
"heapUsedBytes": 93997424,
"domNodes": -200,
"jsHeapTotalBytes": 1638400,
"scriptDurationMs": 9.486999999999998,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1694.0559999999891,
"styleRecalcs": 72,
"styleRecalcDurationMs": 11.436,
"layouts": 9,
"layoutDurationMs": 1.9500000000000002,
"taskDurationMs": 680.356,
"heapDeltaBytes": 23200472,
"heapUsedBytes": 115702524,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 117.76700000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1994.9040000000196,
"styleRecalcs": 83,
"styleRecalcDurationMs": 13.228,
"layouts": 9,
"layoutDurationMs": 2.2630000000000003,
"taskDurationMs": 975.24,
"heapDeltaBytes": -4916452,
"heapUsedBytes": 85491128,
"domNodes": -200,
"jsHeapTotalBytes": 851968,
"scriptDurationMs": 129.78300000000002,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66583333333333,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1710.2480000000355,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.4830000000000005,
"layouts": 11,
"layoutDurationMs": 2.4200000000000004,
"taskDurationMs": 233.48499999999999,
"heapDeltaBytes": 25273204,
"heapUsedBytes": 115753716,
"domNodes": 47,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 9.491,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1732.8019999999924,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.757000000000001,
"layouts": 11,
"layoutDurationMs": 2.7419999999999995,
"taskDurationMs": 340.305,
"heapDeltaBytes": 21555380,
"heapUsedBytes": 110559844,
"domNodes": 47,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 11.253,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 597.9370000000017,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.6999999999999997,
"layouts": 10,
"layoutDurationMs": 2.445,
"taskDurationMs": 389.877,
"heapDeltaBytes": 3687652,
"heapUsedBytes": 94039220,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 135.39100000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.140000000000004,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 616.8549999999868,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.994,
"layouts": 10,
"layoutDurationMs": 2.545,
"taskDurationMs": 447.781,
"heapDeltaBytes": 4430148,
"heapUsedBytes": 104294780,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 133.06,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864875,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1072.4189999999965,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 693.5199999999999,
"heapDeltaBytes": -16539180,
"heapUsedBytes": 102471216,
"domNodes": -230,
"jsHeapTotalBytes": 14491648,
"scriptDurationMs": 51.26500000000001,
"eventListeners": -168,
"totalBlockingTimeMs": 396,
"frameDurationMs": 29.27837837837837,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1054.5720000000074,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 669.1410000000001,
"heapDeltaBytes": -14812936,
"heapUsedBytes": 102827020,
"domNodes": -231,
"jsHeapTotalBytes": 16064512,
"scriptDurationMs": 51.172999999999995,
"eventListeners": -168,
"totalBlockingTimeMs": 378,
"frameDurationMs": 29.166666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 782.5140000000204,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 400.493,
"heapDeltaBytes": -4032984,
"heapUsedBytes": 97341628,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 119.91200000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 161,
"frameDurationMs": 23.03823529411765,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 782.1469999999522,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.57399999999967,
"heapDeltaBytes": -4902920,
"heapUsedBytes": 96863336,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 111.792,
"eventListeners": 0,
"totalBlockingTimeMs": 156,
"frameDurationMs": 23.03823529411765,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7047.636999999981,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6263.81,
"heapDeltaBytes": 36596764,
"heapUsedBytes": 124735928,
"domNodes": -276,
"jsHeapTotalBytes": 29884416,
"scriptDurationMs": 5020.073,
"eventListeners": -130,
"totalBlockingTimeMs": 128,
"frameDurationMs": 25.02811387900356,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7357.379000000037,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.6819999999999995,
"layouts": 2,
"layoutDurationMs": 0.5240000000000001,
"taskDurationMs": 6512.902,
"heapDeltaBytes": 24780828,
"heapUsedBytes": 134987628,
"domNodes": -282,
"jsHeapTotalBytes": 22347776,
"scriptDurationMs": 5005.406000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 70,
"frameDurationMs": 24.09737704918033,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7240.345999999989,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.7769999999999999,
"layouts": 3,
"layoutDurationMs": 0.7509999999999999,
"taskDurationMs": 6391.188,
"heapDeltaBytes": -3311688,
"heapUsedBytes": 118958084,
"domNodes": -296,
"jsHeapTotalBytes": 21590016,
"scriptDurationMs": 4894.655000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 104,
"frameDurationMs": 24.272147651006712,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7513.729000000012,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8450000000000003,
"layouts": 3,
"layoutDurationMs": 0.677,
"taskDurationMs": 6663.162,
"heapDeltaBytes": -11237056,
"heapUsedBytes": 108858164,
"domNodes": -276,
"jsHeapTotalBytes": -3002368,
"scriptDurationMs": 5207.3640000000005,
"eventListeners": -130,
"totalBlockingTimeMs": 35,
"frameDurationMs": 24.090705128205126,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "large-combo-open",
"durationMs": 168.58399999998142,
"styleRecalcs": 22,
"styleRecalcDurationMs": 12.316,
"layouts": 11,
"layoutDurationMs": 2.8489999999999998,
"taskDurationMs": 130.835,
"heapDeltaBytes": 13317916,
"heapUsedBytes": 119412628,
"domNodes": 917,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 6.719000000000001,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.36666666666669,
"p95FrameDurationMs": 49.90000000000009
},
{
"name": "large-combo-open",
"durationMs": 247.62399999997342,
"styleRecalcs": 26,
"styleRecalcDurationMs": 15.555,
"layouts": 11,
"layoutDurationMs": 3.368,
"taskDurationMs": 204.24000000000004,
"heapDeltaBytes": 13348444,
"heapUsedBytes": 118421744,
"domNodes": 917,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 8.358,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.833333333333332,
"p95FrameDurationMs": 66.59999999999991
},
{
"name": "large-graph-idle",
"durationMs": 2024.5559999999898,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.0429999999999997,
"layouts": 8,
"layoutDurationMs": 1.8760000000000001,
"taskDurationMs": 532.229,
"heapDeltaBytes": -764912,
"heapUsedBytes": 110089468,
"domNodes": -296,
"jsHeapTotalBytes": -2031616,
"scriptDurationMs": 27.904,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2042.4300000000244,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.3079999999999994,
"layouts": 9,
"layoutDurationMs": 2.0599999999999996,
"taskDurationMs": 555.827,
"heapDeltaBytes": -645620,
"heapUsedBytes": 102040740,
"domNodes": -296,
"jsHeapTotalBytes": -2789376,
"scriptDurationMs": 34.754,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2251.42900000003,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.989,
"layouts": 7,
"layoutDurationMs": 1.589,
"taskDurationMs": 1350.5249999999999,
"heapDeltaBytes": -10021912,
"heapUsedBytes": 107724796,
"domNodes": -297,
"jsHeapTotalBytes": -2478080,
"scriptDurationMs": 642.309,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2705.6249999999977,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.020999999999999,
"layouts": 7,
"layoutDurationMs": 1.707,
"taskDurationMs": 1480.5900000000001,
"heapDeltaBytes": -1887088,
"heapUsedBytes": 110183012,
"domNodes": -296,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 696.5029999999999,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.76894409937888,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3389.9580000000356,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.756,
"layouts": 65,
"layoutDurationMs": 10.004,
"taskDurationMs": 1480.154,
"heapDeltaBytes": 831764,
"heapUsedBytes": 104707188,
"domNodes": -272,
"jsHeapTotalBytes": -1871872,
"scriptDurationMs": 632.8309999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379312,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3334.7140000000195,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.936,
"layouts": 64,
"layoutDurationMs": 10.286999999999999,
"taskDurationMs": 1472.054,
"heapDeltaBytes": -1463088,
"heapUsedBytes": 104684308,
"domNodes": -272,
"jsHeapTotalBytes": -1085440,
"scriptDurationMs": 630.465,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2464.157,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.488,
"layouts": 7,
"layoutDurationMs": 1.438,
"taskDurationMs": 1564.14,
"heapDeltaBytes": -12356516,
"heapUsedBytes": 103166516,
"domNodes": 0,
"jsHeapTotalBytes": 7081984,
"scriptDurationMs": 754.984,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.894520547945202,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2466.6199999999776,
"styleRecalcs": 49,
"styleRecalcDurationMs": 5.949999999999999,
"layouts": 7,
"layoutDurationMs": 1.75,
"taskDurationMs": 1589.243,
"heapDeltaBytes": -14632956,
"heapUsedBytes": 105834380,
"domNodes": 0,
"jsHeapTotalBytes": 7118848,
"scriptDurationMs": 771.88,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.779591836734692,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2054.1670000000067,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.7610000000000006,
"layouts": 9,
"layoutDurationMs": 2.28,
"taskDurationMs": 405.386,
"heapDeltaBytes": -25870984,
"heapUsedBytes": 86771668,
"domNodes": -296,
"jsHeapTotalBytes": -458752,
"scriptDurationMs": 31.253000000000004,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406507,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2036.636000000044,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.192,
"layouts": 8,
"layoutDurationMs": 1.975,
"taskDurationMs": 444.4450000000001,
"heapDeltaBytes": 68960,
"heapUsedBytes": 113017768,
"domNodes": -296,
"jsHeapTotalBytes": -720896,
"scriptDurationMs": 30.471999999999998,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 596.4799999999855,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.842,
"layouts": 9,
"layoutDurationMs": 2.355,
"taskDurationMs": 392.40500000000003,
"heapDeltaBytes": -103072,
"heapUsedBytes": 100596480,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 116.91000000000001,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 562.8250000000321,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.021,
"layouts": 11,
"layoutDurationMs": 2.5849999999999995,
"taskDurationMs": 357.768,
"heapDeltaBytes": 895548,
"heapUsedBytes": 102778388,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 119.24900000000001,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667647058823523,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2007.4130000000139,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.1649999999999996,
"layouts": 10,
"layoutDurationMs": 2.052,
"taskDurationMs": 421.65200000000004,
"heapDeltaBytes": 5612124,
"heapUsedBytes": 106330004,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 7.5,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2025.4410000000007,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.616,
"layouts": 9,
"layoutDurationMs": 2.502,
"taskDurationMs": 485.092,
"heapDeltaBytes": -13279852,
"heapUsedBytes": 79468704,
"domNodes": -198,
"jsHeapTotalBytes": 1359872,
"scriptDurationMs": 8.802999999999999,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1993.2879999999784,
"styleRecalcs": 86,
"styleRecalcDurationMs": 13.448,
"layouts": 10,
"layoutDurationMs": 2.2059999999999995,
"taskDurationMs": 938.9519999999999,
"heapDeltaBytes": -2710924,
"heapUsedBytes": 88554256,
"domNodes": -210,
"jsHeapTotalBytes": 1900544,
"scriptDurationMs": 90.452,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1942.543999999998,
"styleRecalcs": 85,
"styleRecalcDurationMs": 14.68,
"layouts": 11,
"layoutDurationMs": 2.7159999999999997,
"taskDurationMs": 919.1529999999999,
"heapDeltaBytes": -7215980,
"heapUsedBytes": 94663632,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 94.381,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66581196581196,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1320.682999999974,
"styleRecalcs": 18,
"styleRecalcDurationMs": 19.712000000000003,
"layouts": 5,
"layoutDurationMs": 12.036,
"taskDurationMs": 884.1049999999997,
"heapDeltaBytes": 16365012,
"heapUsedBytes": 137127392,
"domNodes": 16030,
"jsHeapTotalBytes": 16654336,
"scriptDurationMs": 25.668999999999997,
"eventListeners": 3244,
"totalBlockingTimeMs": 97,
"frameDurationMs": 19.048571428571424,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8176.007000000027,
"styleRecalcs": 250,
"styleRecalcDurationMs": 30.674999999999997,
"layouts": 9,
"layoutDurationMs": 2.151,
"taskDurationMs": 4177.344,
"heapDeltaBytes": 3929412,
"heapUsedBytes": 113506584,
"domNodes": -276,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 2108.2039999999997,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.700204498977502,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8776.766000000009,
"styleRecalcs": 250,
"styleRecalcDurationMs": 30.624,
"layouts": 8,
"layoutDurationMs": 1.921,
"taskDurationMs": 4834.616000000001,
"heapDeltaBytes": -6641960,
"heapUsedBytes": 104122720,
"domNodes": -306,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 2155.711,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666034155597725,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 19720.370000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18944.234,
"heapDeltaBytes": -52379756,
"heapUsedBytes": 277210288,
"domNodes": -3344,
"jsHeapTotalBytes": 17813504,
"scriptDurationMs": 278.13,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.77231040564374,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-idle",
"durationMs": 19840.61299999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18969.944000000003,
"heapDeltaBytes": -29956748,
"heapUsedBytes": 300388408,
"domNodes": -3344,
"jsHeapTotalBytes": 20434944,
"scriptDurationMs": 262.61699999999996,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.58272251308901,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 16743.605000000003,
"styleRecalcs": 119,
"styleRecalcDurationMs": 12.27399999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16349.533000000001,
"heapDeltaBytes": -30819388,
"heapUsedBytes": 298421424,
"domNodes": -3344,
"jsHeapTotalBytes": 9424896,
"scriptDurationMs": 662.5609999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 2,
"frameDurationMs": 30.676373626373625,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-large-graph-pan",
"durationMs": 17132.428000000004,
"styleRecalcs": 123,
"styleRecalcDurationMs": 13.076000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16688.489,
"heapDeltaBytes": 8724920,
"heapUsedBytes": 313856432,
"domNodes": -3348,
"jsHeapTotalBytes": 13549568,
"scriptDurationMs": 666.223,
"eventListeners": -651,
"totalBlockingTimeMs": 6,
"frameDurationMs": 31.845167286245353,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5097.37100000001,
"styleRecalcs": 20,
"styleRecalcDurationMs": 58.43700000000002,
"layouts": 20,
"layoutDurationMs": 27.106999999999992,
"taskDurationMs": 5000.684999999999,
"heapDeltaBytes": -25233012,
"heapUsedBytes": 284857768,
"domNodes": -3344,
"jsHeapTotalBytes": 24629248,
"scriptDurationMs": 79.78099999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.095731707317068,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-node-resize-workload",
"durationMs": 6972.789000000034,
"styleRecalcs": 20,
"styleRecalcDurationMs": 47.67399999999999,
"layouts": 20,
"layoutDurationMs": 20.994,
"taskDurationMs": 6917.639,
"heapDeltaBytes": -47099324,
"heapUsedBytes": 282177064,
"domNodes": -3344,
"jsHeapTotalBytes": 21221376,
"scriptDurationMs": 104.51500000000001,
"eventListeners": -657,
"totalBlockingTimeMs": 13,
"frameDurationMs": 41.46666666666666,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7042.852000000039,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6635.047000000002,
"heapDeltaBytes": 19093816,
"heapUsedBytes": 308123160,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 92.887,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.563763066202096,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7126.77199999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6728.401000000002,
"heapDeltaBytes": -14446996,
"heapUsedBytes": 277971816,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 97.53299999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.854006968641123,
"p95FrameDurationMs": 50
},
{
"name": "workflow-execution",
"durationMs": 454.2119999999841,
"styleRecalcs": 20,
"styleRecalcDurationMs": 10.157,
"layouts": 12,
"layoutDurationMs": 3.9730000000000008,
"taskDurationMs": 127.95100000000001,
"heapDeltaBytes": 7244732,
"heapUsedBytes": 97724900,
"domNodes": 126,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.014999999999999,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66296296296295,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 450.7300000000214,
"styleRecalcs": 13,
"styleRecalcDurationMs": 7.101000000000001,
"layouts": 12,
"layoutDurationMs": 2.9759999999999995,
"taskDurationMs": 115.627,
"heapDeltaBytes": -13110580,
"heapUsedBytes": 89375164,
"domNodes": 95,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 8.797999999999998,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 301.42000000000735,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.618,
"layouts": 76,
"layoutDurationMs": 11.839,
"taskDurationMs": 258.994,
"heapDeltaBytes": 10481588,
"heapUsedBytes": 100005840,
"domNodes": 4,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 124.822,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 285.77199999995173,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.622,
"layouts": 76,
"layoutDurationMs": 12.01,
"taskDurationMs": 245.739,
"heapDeltaBytes": 10263220,
"heapUsedBytes": 99250616,
"domNodes": 4,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 115.47,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352926,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 316.8799999999692,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.845,
"layouts": 76,
"layoutDurationMs": 10.082,
"taskDurationMs": 283.665,
"heapDeltaBytes": -1625972,
"heapUsedBytes": 115410980,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 95.76799999999999,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663157894736862,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 388.8279999999895,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.682,
"layouts": 76,
"layoutDurationMs": 10.956999999999999,
"taskDurationMs": 351.24,
"heapDeltaBytes": -959816,
"heapUsedBytes": 116498032,
"domNodes": 4,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 143.937,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageLine coverage: 59.9% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2988 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 459e7df11182b634216f5eb77f9ef3b046103a99
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (134)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
This comment has been minimized.
This comment has been minimized.
dante01yoon
left a comment
There was a problem hiding this comment.
Reviewed 756c9a1 against merged #22204 and the complete parent discussions. The import conflict preserves this branch's NodeExecutionId path, and retry logic matches the merged implementation after the telemetry package-path adaptation. Outcome classification, caller cancellation, route/host redaction, per-minute budget and both provider sinks retain their intended behavior. The added metadata is client telemetry, not a server API contract. Own isolated frozen-install validation: 170 tests across six suites, app typecheck and scoped lint/format PASS. Independently accepting redirects as recovery, removing host redaction, disabling the minute reset or allowing response-body cleanup failure to escape each fails its retained regression; restored source passes. No remaining code blocker.
…ispatcher type for fallow useTelemetry() returns the registry typed as TelemetryDispatcher, so fallow cannot see the call in statusRetryTelemetry.ts. Same suppression the other dispatcher-only members in this file carry.
dante01yoon
left a comment
There was a problem hiding this comment.
Re-reviewed 45b81d2: the sole change is a one-line Fallow machine directive on the dispatcher implementation. I ran the owning audit without it: the only introduced finding is trackFetchStatusRetry as an unused class member, with incomplete-import-graph caveat. A private test using the real TelemetryRegistry, setTelemetryRegistry and trackStatusRetry reaches the registered provider; 63 registry/classifier/probe tests PASS. Restoring the directive makes the new-only audit PASS with zero introduced findings; app typecheck and scoped Oxlint/Oxfmt also PASS. The actual runtime caller and authoritative TelemetryDispatcher type confirm this is a verified analyzer limitation, not dead code. The repository explicitly permits scoped tool directives; behavior and previously reviewed retry coverage are unchanged. One nonblocking documentation note is inline. CI completion is not claimed.
| this.dispatch((provider) => provider.trackFetchTimeout?.(metadata)) | ||
| } | ||
|
|
||
| // fallow-ignore-next-line unused-class-member |
There was a problem hiding this comment.
nit-pick (non-blocking): Please copy the external-tool constraint from commit 45b81d2 into the PR description: Fallow cannot credit this concrete method through useTelemetry()’s TelemetryDispatcher return type, while the real registry/provider path is reachable. AGENTS.md asks that a justified rare suppression’s constraint be recorded there. Keep the machine directive itself free of prose as it is now.
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## core/1.58 #22325 +/- ##
===========================================
Coverage 84.02% 84.03%
===========================================
Files 3175 3175
Lines 165818 165918 +100
Branches 39558 39592 +34
===========================================
+ Hits 139336 139435 +99
- Misses 26090 26091 +1
Partials 392 392
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 26 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Manual backport of #22204 (
8cee1d7a92) tocore/1.58. The auto-backport failed on a conflict insrc/scripts/api.ts.What
Each request that the shared 429/502/503/504 retry touched records one
app:fetch_status_retryDatadog action and one Sentry breadcrumb: route group, attempts, last status and outcome (recovered, exhausted, Retry-After too long, timed out, failed). Capped at 20 per route and outcome per minute. Route groups and hosts are allowlisted, so nothing user-chosen is recorded. Shows whether retries are hiding a real backend problem.Conflict resolution
api.ts: import-only conflict. Kept this branch'sNodeExecutionIdimport path and added thegetFetchRouteTemplateimport; the moved route-group helper applied cleanly.@comfyorg/telemetrypackage, so the new and changedsrc/utilsfiles import@/platform/telemetryand@/platform/telemetry/types. The telemetry type and provider changes landed insrc/platform/telemetry/by rename detection.Verification
src/utils,src/scriptsand the cloud telemetry provider tests pass locally.pnpm typecheck:app, oxfmt and oxlint pass.Linear: https://linear.app/comfyorg/issue/FRONT-3683