Skip to content

[backport cloud/1.58] fix(agent): make the coach-tour hold on the first send visible and always releasable (#21285) - #22225

Merged
comfy-pr-bot merged 4 commits into
cloud/1.58from
backport-21285-to-cloud-1.58
Oct 29, 2026
Merged

comfy-pr-bot merged 4 commits into
cloud/1.58from
backport-21285-to-cloud-1.58

Conversation

@christian-byrne

@christian-byrne christian-byrne commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Manual backport of #21285 to cloud/1.58. The auto-backport hit a conflict in AgentPanelRoot.vue.

Why

A new user's first agent message waits behind the intro tour with no notice, so it looks like the agent never answered (about 5% of first sends; QA reproduced it on a Desktop release candidate). #21285 is on main and in v1.60.0; this line still has the silent hold.

What differs from the original

Same two commits as #22223 (core/1.58), cherry-picked cleanly. Cloud production currently serves a cloud/1.58 build, so this is the line that reaches cloud users.

  • AgentPanelRoot.vue conflict: main's version sits on top of consent checks from feat: complete Desktop Agent consent and locked panel startup #21532, which is not on this line. The cherry-pick keeps them: the hold is skipped when consent or the onboarding key already changed, and the send needs the coach release plus a still-accepted consent.
  • Extra commit (review finding): the hold now also releases when consent is cleared or the consent identity changes, and the release rechecks that identity, as main does. Without it a send held for one account could go out under another account's consent after a sign-in switch without reload, and a consent clear with the panel open left the send waiting until unmount. Two new tests cover both and failed before the fix.
  • AgentPanelRoot.test.ts: one existing test's withConsent mock now marks consent accepted before onAccept, as the real withConsent does and as main's copy of the test does. Without it the recheck rejects the mocked accept.
  • Everything else is byte-identical to the merged commit.

Verification

  • Agent code on this line matches core/1.58 except crdt/docOpMinter, which this change does not touch. Touched suites verified on core/1.58 (514/514); CI runs them here.
  • Browser case agentActivationConsent.spec.ts (hold notice) runs in CI.

Tracking: https://linear.app/comfyorg/issue/BE-21344

mattmillerai and others added 2 commits October 29, 2026 09:43
…st send visible and always releasable (#21285)

The first message a new user sends waits until they finish or skip the
agent's intro tour. Until now that wait was silent, could last forever
if a tour step failed to appear, and closing the panel threw the message
away. Now the tour card says the message is waiting, a broken tour step
lets the message go, and closing the panel puts the message back in the
box.

The first send after consent still waits for the coach (ordering from
exit either sends once or restores the draft:

- `OnboardingCoach`: new `holdNotice` prop rendered under the card body
and included in the dialog's `aria-describedby`; new `stalled` emit,
fired at most once per instance when a step's target is still missing
after the existing 8s grace period. `stalled` does not call `finish()`,
so the tour is not marked seen.
- `AgentPanelRoot`: `sendHeldByCoach` ref set only around the coach
wait; passes the notice string while held; releases waiters on
`@stalled`. On teardown during a coach hold, the consent-held submission
is no longer invalidated; teardown releases any still-pending coach
wait. If App Mode or another tour defers the coach and the panel stays
visible, the release lets the send through. Switching to App Mode can
unmount the graph-hosted panel before the panel's own deferral watcher
runs, so the send has to be let through here, at teardown. Otherwise the
wait is abandoned: the continuation returns `false`,
`settleSubmission(id, false)` marks it failed and
`recoverFailedSubmission` restores text and attachments on the next
mount. The consent-dialog-phase invalidation (late accept after
teardown) is unchanged.
- New string `agent.coachHoldNotice` in `en/main.json` only. No
timer-based auto-send.

Judgment calls:
- E2E: the coach's full-screen scrim and focus trap block pointer and
keyboard access to the panel toggle, so the new spec closes the panel
with `openButton.dispatchEvent('click')`. On reopen the coach shows
again over the composer, so the spec skips the tour before re-sending
instead of sending first (the ticket's order isn't reachable through the
UI).

- Unit: `pnpm vitest run
src/workbench/extensions/agent/AgentPanelRoot.test.ts
src/workbench/extensions/agent/components/agent/OnboardingCoach.test.ts`:
518/518 pass on the branch merged with current `main` (conflict in
`AgentPanelRoot.vue` resolved by keeping both this PR's coach-release
result and main's post-wait consent/identity recheck). New cases: notice
shown while held, no notice on a "Take the tour" replay, exactly one
POST when a step stalls (fake timers past the grace period, tour not
marked seen), exactly one POST when App Mode unmounts the visible panel,
both before and after the panel's deferral watcher releases the hold,
zero POSTs + `settleSubmission(id, false)` + draft restored after
close/unmount, zero POSTs + draft restored when consent clears before
App Mode releases the hold, `stalled` emitted once across two missing
steps, notice rendered and announced only when set.
- Mutation: reverting the `AgentPanelRoot.vue` change makes the
held-send tests fail; the unmount-before-watcher App Mode case fails
against both earlier teardown versions of this PR, which is what broke
the `@cloud` E2E "resumes the held send when App Mode defers the active
tour", and passes on main and on the current head.
- Existing "does not resume a consent-held send after closing in App
Mode" and the onboarding deferral tests pass unchanged.
- `pnpm typecheck` clean; oxlint/oxfmt/stylelint/eslint clean
(pre-commit hooks).
- Doc-drift sweep: flagged identifiers are generic test/DOM API names
(`toHaveLength`, `dispatchEvent`); the new identifiers
`coachHoldNotice`, `agent-coach-hold-notice`, `holdNotice`, `stalled`
have no doc references. 0 updated.

- The `@cloud` Playwright cases in
`browser_tests/tests/agent/agentActivationConsent.spec.ts` (the new
hold-notice case and the existing finish/skip/App Mode cases) were not
run locally (no cloud-mode backend on this host); they ran in CI, where
the cloud and chromium Playwright shards pass on the current head.
- The hold notice copy names only finish/skip; the stall release is a
failure fallback the user cannot trigger, so it is not mentioned.
- Because the scrim blocks the panel toggle, a user can't actually close
the panel while the coach card is up; the restore-on-close path only
matters when the panel is torn down some other way. Whether the scrim
should leave the panel toggle reachable is a separate design question
and is left alone here.
- Non-English locales get `agent.coachHoldNotice` from the i18n
pipeline; not hand-edited.

- **Authored by:** agent-work loop
- **Verified:**
- Current `main` merged in; the `AgentPanelRoot.vue` conflict resolved
so a held send needs the coach release and a still-matching consent
identity
- Unit tests on the current head: all green (2 files, 518 tests),
including the new hold, stall, close and App Mode cases; App Mode test
now always stops its watcher
- Consent cleared during the hold checked red/green: the held draft
comes back and nothing posts, and the test fails without the post-wait
consent/identity recheck
- App Mode teardown checked red/green: unmounting before the watcher
fails on the previous head and passes on main and the current head
  - Typecheck / lint / format: clean on the current head
- Playwright `@cloud` spec (new + existing cases): not run locally; all
CI checks, including the cloud and chromium Playwright shards, pass on
the current head
- **Deviations:**
- E2E closes the panel with a dispatched click and skips the tour before
re-sending, because the coach overlay blocks the UI path the ticket
described
  - Hold notice copy does not mention the stall fallback

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Christian Byrne <cbyrne@comfy.org>
The backported recheck requires consent to still be accepted when the
coach releases the send. The real withConsent only calls onAccept after
the store is accepted; this mock now does the same, matching main.
@christian-byrne christian-byrne added the backport Backporting a PR onto a release candidate label Oct 29, 2026
@christian-byrne
christian-byrne requested review from a team as code owners October 29, 2026 09:59
@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords: 2
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

❌ 8 scenarios below the ≥52 P5 FPS target. Expand the scenario timings below and profile the affected scenarios before merging.

Scenario timings

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.1 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.8 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 100.4 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.8 MB heap
dom-widget-order-dense-n200-w200-i120: · 35.7 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 340ms TBT · 97.7 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 45.3 avg FPS · 39.8 P5 FPS ❌ (target: ≥52) · 121ms TBT · 104.9 MB heap
extension-clean-combined-draw: · 42.1 avg FPS · 29.9 P5 FPS ❌ (target: ≥52) · 78ms TBT · 131.0 MB heap
extension-rgthree-prototype-draw: · 41.2 avg FPS · 29.9 P5 FPS ❌ (target: ≥52) · 80ms TBT · 115.3 MB heap
large-combo-open: · 46.9 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 111.8 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 101.2 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 91.8 MB heap
large-graph-zoom: · 59.8 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 88.4 MB heap
legacy-node-drag: · 59.3 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 105.0 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 88.7 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 108.4 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.2 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 90.5 MB heap
subgraph-transition-enter: · 47.5 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 116ms TBT · 133.4 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 99.2 MB heap
vue-large-graph-idle: · 39.1 avg FPS · 23.9 P5 FPS ❌ (target: ≥52) · 0ms TBT · 277.1 MB heap
vue-large-graph-pan: · 27.5 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 3ms TBT · 279.4 MB heap
vue-node-resize-workload: · 30.8 avg FPS · 13.3 P5 FPS ❌ (target: ≥52) · 0ms TBT · 287.1 MB heap
vue-zoom-out-idle: · 33.5 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 272.6 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 100.3 MB heap
agent-composer-empty-conversation-typing: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 96.9 MB heap
agent-composer-long-conversation-typing: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 111.3 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 3ms
canvas-idle: style recalc duration 3ms
canvas-idle: layout count 10
canvas-idle: style recalc count 10
canvas-idle: task duration 523ms
canvas-idle: script duration 14ms
canvas-idle: TBT 0ms
canvas-idle: heap used 82.1 MB
canvas-idle: DOM nodes -201
canvas-idle: event listeners -130
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 3ms
canvas-mouse-sweep: style recalc duration 15ms
canvas-mouse-sweep: layout count 10
canvas-mouse-sweep: style recalc count 72
canvas-mouse-sweep: task duration 727ms
canvas-mouse-sweep: script duration 132ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 84.8 MB
canvas-mouse-sweep: DOM nodes -190
canvas-mouse-sweep: event listeners -130
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 3ms
canvas-zoom-sweep: style recalc duration 6ms
canvas-zoom-sweep: layout count 11
canvas-zoom-sweep: style recalc count 18
canvas-zoom-sweep: task duration 362ms
canvas-zoom-sweep: script duration 16ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 100.4 MB
canvas-zoom-sweep: DOM nodes 47
canvas-zoom-sweep: event listeners 37
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 3ms
dom-widget-clipping: style recalc duration 3ms
dom-widget-clipping: layout count 10
dom-widget-clipping: style recalc count 14
dom-widget-clipping: task duration 404ms
dom-widget-clipping: script duration 127ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 85.8 MB
dom-widget-clipping: DOM nodes 0
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 28ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 688ms
dom-widget-order-dense-n200-w200-i120: script duration 45ms
dom-widget-order-dense-n200-w200-i120: TBT 340ms
dom-widget-order-dense-n200-w200-i120: heap used 97.7 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes -230
dom-widget-order-dense-n200-w200-i120: event listeners -168
dom-widget-order-sparse-n1000-w20-i120: avg frame time 22ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 25ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 375ms
dom-widget-order-sparse-n1000-w20-i120: script duration 110ms
dom-widget-order-sparse-n1000-w20-i120: TBT 121ms
dom-widget-order-sparse-n1000-w20-i120: heap used 104.9 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes -115
dom-widget-order-sparse-n1000-w20-i120: event listeners -84
extension-clean-combined-draw: avg frame time 24ms
extension-clean-combined-draw: p95 frame time 33ms
extension-clean-combined-draw: layout duration 1ms
extension-clean-combined-draw: style recalc duration 3ms
extension-clean-combined-draw: layout count 3
extension-clean-combined-draw: style recalc count 3
extension-clean-combined-draw: task duration 6340ms
extension-clean-combined-draw: script duration 4787ms
extension-clean-combined-draw: TBT 78ms
extension-clean-combined-draw: heap used 131.0 MB
extension-clean-combined-draw: DOM nodes -286
extension-clean-combined-draw: event listeners -130
extension-rgthree-prototype-draw: avg frame time 24ms
extension-rgthree-prototype-draw: p95 frame time 33ms
extension-rgthree-prototype-draw: layout duration 1ms
extension-rgthree-prototype-draw: style recalc duration 1ms
extension-rgthree-prototype-draw: layout count 3
extension-rgthree-prototype-draw: style recalc count 4
extension-rgthree-prototype-draw: task duration 5804ms
extension-rgthree-prototype-draw: script duration 4339ms
extension-rgthree-prototype-draw: TBT 80ms
extension-rgthree-prototype-draw: heap used 115.3 MB
extension-rgthree-prototype-draw: DOM nodes -287
extension-rgthree-prototype-draw: event listeners -130
large-combo-open: avg frame time 21ms
large-combo-open: p95 frame time 50ms
large-combo-open: layout duration 3ms
large-combo-open: style recalc duration 15ms
large-combo-open: layout count 11
large-combo-open: style recalc count 23
large-combo-open: task duration 139ms
large-combo-open: script duration 8ms
large-combo-open: TBT 0ms
large-combo-open: heap used 111.8 MB
large-combo-open: DOM nodes 917
large-combo-open: event listeners 196
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 5ms
large-graph-idle: style recalc duration 4ms
large-graph-idle: layout count 8
large-graph-idle: style recalc count 9
large-graph-idle: task duration 575ms
large-graph-idle: script duration 35ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 101.2 MB
large-graph-idle: DOM nodes -286
large-graph-idle: event listeners -130
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 2ms
large-graph-pan: style recalc duration 12ms
large-graph-pan: layout count 8
large-graph-pan: style recalc count 70
large-graph-pan: task duration 1463ms
large-graph-pan: script duration 652ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 91.8 MB
large-graph-pan: DOM nodes -287
large-graph-pan: event listeners -128
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 13ms
large-graph-zoom: style recalc duration 14ms
large-graph-zoom: layout count 66
large-graph-zoom: style recalc count 72
large-graph-zoom: task duration 1574ms
large-graph-zoom: script duration 641ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 88.4 MB
large-graph-zoom: DOM nodes -263
large-graph-zoom: event listeners -130
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 2ms
legacy-node-drag: style recalc duration 7ms
legacy-node-drag: layout count 6
legacy-node-drag: style recalc count 46
legacy-node-drag: task duration 1665ms
legacy-node-drag: script duration 841ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 105.0 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 182
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 3ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 8
minimap-idle: style recalc count 8
minimap-idle: task duration 644ms
minimap-idle: script duration 40ms
minimap-idle: TBT 0ms
minimap-idle: heap used 88.7 MB
minimap-idle: DOM nodes -296
minimap-idle: event listeners -130
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 3ms
subgraph-dom-widget-clipping: style recalc duration 7ms
subgraph-dom-widget-clipping: layout count 9
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 357ms
subgraph-dom-widget-clipping: script duration 117ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 108.4 MB
subgraph-dom-widget-clipping: DOM nodes 0
subgraph-dom-widget-clipping: event listeners 46
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 4ms
subgraph-idle: style recalc duration 4ms
subgraph-idle: layout count 12
subgraph-idle: style recalc count 12
subgraph-idle: task duration 543ms
subgraph-idle: script duration 13ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 81.2 MB
subgraph-idle: DOM nodes -208
subgraph-idle: event listeners -176
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 3ms
subgraph-mouse-sweep: style recalc duration 18ms
subgraph-mouse-sweep: layout count 10
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 735ms
subgraph-mouse-sweep: script duration 107ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 90.5 MB
subgraph-mouse-sweep: DOM nodes -105
subgraph-mouse-sweep: event listeners -84
subgraph-transition-enter: avg frame time 21ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 12ms
subgraph-transition-enter: style recalc duration 20ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 726ms
subgraph-transition-enter: script duration 25ms
subgraph-transition-enter: TBT 116ms
subgraph-transition-enter: heap used 133.4 MB
subgraph-transition-enter: DOM nodes 16030
subgraph-transition-enter: event listeners 3244
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 2ms
viewport-pan-sweep: style recalc duration 41ms
viewport-pan-sweep: layout count 8
viewport-pan-sweep: style recalc count 250
viewport-pan-sweep: task duration 4934ms
viewport-pan-sweep: script duration 2238ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 99.2 MB
viewport-pan-sweep: DOM nodes -299
viewport-pan-sweep: event listeners -128
vue-large-graph-idle: avg frame time 26ms
vue-large-graph-idle: p95 frame time 42ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 14301ms
vue-large-graph-idle: script duration 215ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 277.1 MB
vue-large-graph-idle: DOM nodes -3344
vue-large-graph-idle: event listeners -653
vue-large-graph-pan: avg frame time 36ms
vue-large-graph-pan: p95 frame time 67ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 24ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 148
vue-large-graph-pan: task duration 19104ms
vue-large-graph-pan: script duration 738ms
vue-large-graph-pan: TBT 3ms
vue-large-graph-pan: heap used 279.4 MB
vue-large-graph-pan: DOM nodes -3344
vue-large-graph-pan: event listeners -651
vue-node-resize-workload: avg frame time 32ms
vue-node-resize-workload: p95 frame time 75ms
vue-node-resize-workload: layout duration 26ms
vue-node-resize-workload: style recalc duration 48ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 5571ms
vue-node-resize-workload: script duration 96ms
vue-node-resize-workload: TBT 0ms
vue-node-resize-workload: heap used 287.1 MB
vue-node-resize-workload: DOM nodes -3344
vue-node-resize-workload: event listeners -653
vue-zoom-out-idle: avg frame time 30ms
vue-zoom-out-idle: p95 frame time 67ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8284ms
vue-zoom-out-idle: script duration 116ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 272.6 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners 0
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 3ms
workflow-execution: style recalc duration 9ms
workflow-execution: layout count 8
workflow-execution: style recalc count 8
workflow-execution: task duration 71ms
workflow-execution: script duration 7ms
workflow-execution: TBT 0ms
workflow-execution: heap used 100.3 MB
workflow-execution: DOM nodes 119
workflow-execution: event listeners 1
agent-composer-empty-conversation-typing: avg frame time 17ms
agent-composer-empty-conversation-typing: p95 frame time 17ms
agent-composer-empty-conversation-typing: layout duration 19ms
agent-composer-empty-conversation-typing: style recalc duration 1ms
agent-composer-empty-conversation-typing: layout count 76
agent-composer-empty-conversation-typing: style recalc count 5
agent-composer-empty-conversation-typing: task duration 325ms
agent-composer-empty-conversation-typing: script duration 148ms
agent-composer-empty-conversation-typing: TBT 0ms
agent-composer-empty-conversation-typing: heap used 96.9 MB
agent-composer-empty-conversation-typing: DOM nodes 4
agent-composer-empty-conversation-typing: event listeners 292
agent-composer-long-conversation-typing: avg frame time 17ms
agent-composer-long-conversation-typing: p95 frame time 17ms
agent-composer-long-conversation-typing: layout duration 18ms
agent-composer-long-conversation-typing: style recalc duration 3ms
agent-composer-long-conversation-typing: layout count 76
agent-composer-long-conversation-typing: style recalc count 5
agent-composer-long-conversation-typing: task duration 364ms
agent-composer-long-conversation-typing: script duration 135ms
agent-composer-long-conversation-typing: TBT 0ms
agent-composer-long-conversation-typing: heap used 111.3 MB
agent-composer-long-conversation-typing: DOM nodes 4
agent-composer-long-conversation-typing: event listeners 292
Raw data
{
  "timestamp": "2026-10-29T10:40:14.816Z",
  "gitSha": "a2c2440d7b10546f85df1b64e049696b2291d592",
  "branch": "backport-21285-to-cloud-1.58",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2025.9080000000154,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 3.2960000000000003,
      "layouts": 10,
      "layoutDurationMs": 3.065,
      "taskDurationMs": 486.815,
      "heapDeltaBytes": -3199452,
      "heapUsedBytes": 85624092,
      "domNodes": -201,
      "jsHeapTotalBytes": -3342336,
      "scriptDurationMs": 12.435,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6655737704918,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2026.2800000000425,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 3.2709999999999995,
      "layouts": 9,
      "layoutDurationMs": 2.8569999999999998,
      "taskDurationMs": 558.399,
      "heapDeltaBytes": -2512376,
      "heapUsedBytes": 86528760,
      "domNodes": -201,
      "jsHeapTotalBytes": 851968,
      "scriptDurationMs": 14.874000000000002,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6655737704918,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1726.7850000000067,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 14.461,
      "layouts": 9,
      "layoutDurationMs": 2.548,
      "taskDurationMs": 757.2489999999999,
      "heapDeltaBytes": -3189052,
      "heapUsedBytes": 85267948,
      "domNodes": -200,
      "jsHeapTotalBytes": 1638400,
      "scriptDurationMs": 130.425,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666346153846153,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1725.3150000000232,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 15.652,
      "layouts": 10,
      "layoutDurationMs": 2.945,
      "taskDurationMs": 697.483,
      "heapDeltaBytes": 4716052,
      "heapUsedBytes": 92629136,
      "domNodes": -180,
      "jsHeapTotalBytes": -1769472,
      "scriptDurationMs": 134.37,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665384615384614,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1723.9440000000172,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 5.953000000000001,
      "layouts": 11,
      "layoutDurationMs": 3.364,
      "taskDurationMs": 384.188,
      "heapDeltaBytes": -3564220,
      "heapUsedBytes": 98808248,
      "domNodes": 47,
      "jsHeapTotalBytes": 3670016,
      "scriptDurationMs": 16.519,
      "eventListeners": 37,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666346153846153,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1725.904000000014,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 5.7620000000000005,
      "layouts": 11,
      "layoutDurationMs": 3.2670000000000003,
      "taskDurationMs": 339.92300000000006,
      "heapDeltaBytes": 23176216,
      "heapUsedBytes": 111724180,
      "domNodes": 47,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 15.299999999999999,
      "eventListeners": 37,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665384615384617,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 563.980000000015,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 3.6790000000000007,
      "layouts": 10,
      "layoutDurationMs": 2.9899999999999998,
      "taskDurationMs": 398.04200000000003,
      "heapDeltaBytes": -168444,
      "heapUsedBytes": 87557024,
      "domNodes": 0,
      "jsHeapTotalBytes": 3670016,
      "scriptDurationMs": 124.34200000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.667647058823537,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 575.7089999999607,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 3.217000000000001,
      "layouts": 9,
      "layoutDurationMs": 2.8360000000000003,
      "taskDurationMs": 410.15299999999996,
      "heapDeltaBytes": 3265260,
      "heapUsedBytes": 92340912,
      "domNodes": 0,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 130.014,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66571428571429,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 990.0829999999985,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 651.5759999999999,
      "heapDeltaBytes": -15255520,
      "heapUsedBytes": 102139744,
      "domNodes": -230,
      "jsHeapTotalBytes": 16064512,
      "scriptDurationMs": 45.105,
      "eventListeners": -168,
      "totalBlockingTimeMs": 321,
      "frameDurationMs": 27.313888888888894,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1026.9289999999955,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 723.729,
      "heapDeltaBytes": -16952152,
      "heapUsedBytes": 102647504,
      "domNodes": -230,
      "jsHeapTotalBytes": 14073856,
      "scriptDurationMs": 45.02199999999999,
      "eventListeners": -168,
      "totalBlockingTimeMs": 358,
      "frameDurationMs": 28.702777777777783,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 718.5020000000009,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 344.66200000000003,
      "heapDeltaBytes": 24226292,
      "heapUsedBytes": 115307244,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 113.24999999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 103,
      "frameDurationMs": 21.076470588235306,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 777.0060000000285,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 404.80200000000013,
      "heapDeltaBytes": -22486056,
      "heapUsedBytes": 104592348,
      "domNodes": -230,
      "jsHeapTotalBytes": -3497984,
      "scriptDurationMs": 106.91500000000003,
      "eventListeners": -168,
      "totalBlockingTimeMs": 138,
      "frameDurationMs": 23.03823529411765,
      "p95FrameDurationMs": 33.399999999999636
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 7087.047999999982,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 6.308,
      "layouts": 4,
      "layoutDurationMs": 1.271,
      "taskDurationMs": 6033.424,
      "heapDeltaBytes": 23670704,
      "heapUsedBytes": 125980864,
      "domNodes": -296,
      "jsHeapTotalBytes": 22085632,
      "scriptDurationMs": 4527.366,
      "eventListeners": -130,
      "totalBlockingTimeMs": 49,
      "frameDurationMs": 22.92265372168285,
      "p95FrameDurationMs": 33.400000000000546
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 7550.787000000014,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 0.3930000000000001,
      "layouts": 2,
      "layoutDurationMs": 0.578,
      "taskDurationMs": 6646.848,
      "heapDeltaBytes": 44344456,
      "heapUsedBytes": 148763252,
      "domNodes": -276,
      "jsHeapTotalBytes": 25571328,
      "scriptDurationMs": 5046.841,
      "eventListeners": -130,
      "totalBlockingTimeMs": 106,
      "frameDurationMs": 24.591856677524433,
      "p95FrameDurationMs": 33.400000000000546
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 6467.629999999986,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 1.2849999999999997,
      "layouts": 3,
      "layoutDurationMs": 1.9129999999999998,
      "taskDurationMs": 5628.244000000001,
      "heapDeltaBytes": 21734132,
      "heapUsedBytes": 123998988,
      "domNodes": -297,
      "jsHeapTotalBytes": 21561344,
      "scriptDurationMs": 4289.239,
      "eventListeners": -130,
      "totalBlockingTimeMs": 91,
      "frameDurationMs": 23.73837638376384,
      "p95FrameDurationMs": 33.400000000000546
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 6726.796000000036,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 1.111,
      "layouts": 3,
      "layoutDurationMs": 0.9150000000000005,
      "taskDurationMs": 5980.555,
      "heapDeltaBytes": -4064536,
      "heapUsedBytes": 117705220,
      "domNodes": -276,
      "jsHeapTotalBytes": 22085632,
      "scriptDurationMs": 4387.893,
      "eventListeners": -130,
      "totalBlockingTimeMs": 68,
      "frameDurationMs": 24.783763837638375,
      "p95FrameDurationMs": 33.400000000000546
    },
    {
      "name": "large-combo-open",
      "durationMs": 186.8390000000204,
      "styleRecalcs": 23,
      "styleRecalcDurationMs": 14.404,
      "layouts": 11,
      "layoutDurationMs": 3.296,
      "taskDurationMs": 143.09699999999998,
      "heapDeltaBytes": 15535292,
      "heapUsedBytes": 118023596,
      "domNodes": 917,
      "jsHeapTotalBytes": 1310720,
      "scriptDurationMs": 7.558000000000001,
      "eventListeners": 196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 20.377777777777737,
      "p95FrameDurationMs": 50.09999999999991
    },
    {
      "name": "large-combo-open",
      "durationMs": 184.30000000000746,
      "styleRecalcs": 22,
      "styleRecalcDurationMs": 14.758000000000001,
      "layouts": 11,
      "layoutDurationMs": 3.383,
      "taskDurationMs": 134.7,
      "heapDeltaBytes": 13330728,
      "heapUsedBytes": 116384440,
      "domNodes": 917,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 7.6819999999999995,
      "eventListeners": 196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 22.22222222222222,
      "p95FrameDurationMs": 50.09999999999991
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2042.2089999999855,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 2.713,
      "layouts": 8,
      "layoutDurationMs": 2.3109999999999995,
      "taskDurationMs": 584.6629999999999,
      "heapDeltaBytes": 4159784,
      "heapUsedBytes": 105232472,
      "domNodes": -276,
      "jsHeapTotalBytes": -6488064,
      "scriptDurationMs": 31.345,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665040650406507,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2095.431000000019,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 4.6160000000000005,
      "layouts": 8,
      "layoutDurationMs": 6.877,
      "taskDurationMs": 565.611,
      "heapDeltaBytes": 871480,
      "heapUsedBytes": 107092272,
      "domNodes": -296,
      "jsHeapTotalBytes": -1245184,
      "scriptDurationMs": 39.478,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6656,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 3055.528000000038,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 11.791999999999998,
      "layouts": 7,
      "layoutDurationMs": 1.987,
      "taskDurationMs": 1478.57,
      "heapDeltaBytes": -2550896,
      "heapUsedBytes": 104755244,
      "domNodes": -276,
      "jsHeapTotalBytes": 5124096,
      "scriptDurationMs": 658.481,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666120218579234,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 3027.3789999999963,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 12.014000000000001,
      "layouts": 8,
      "layoutDurationMs": 2.2560000000000002,
      "taskDurationMs": 1446.572,
      "heapDeltaBytes": -33461900,
      "heapUsedBytes": 87845284,
      "domNodes": -297,
      "jsHeapTotalBytes": -655360,
      "scriptDurationMs": 644.9619999999999,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666483516483517,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 4112.000000000024,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 14.078,
      "layouts": 65,
      "layoutDurationMs": 13.745999999999999,
      "taskDurationMs": 1632.4639999999997,
      "heapDeltaBytes": -12070124,
      "heapUsedBytes": 97057132,
      "domNodes": -252,
      "jsHeapTotalBytes": -1114112,
      "scriptDurationMs": 669.8810000000001,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.734146341463415,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3976.976000000036,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 13.192,
      "layouts": 66,
      "layoutDurationMs": 13.248,
      "taskDurationMs": 1515.625,
      "heapDeltaBytes": -20829916,
      "heapUsedBytes": 88230716,
      "domNodes": -273,
      "jsHeapTotalBytes": -1638400,
      "scriptDurationMs": 611.408,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.736134453781514,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2785.517000000027,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 7.004,
      "layouts": 6,
      "layoutDurationMs": 1.581,
      "taskDurationMs": 1612.847,
      "heapDeltaBytes": 20771884,
      "heapUsedBytes": 126868436,
      "domNodes": 0,
      "jsHeapTotalBytes": 6451200,
      "scriptDurationMs": 837.329,
      "eventListeners": 182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.766867469879518,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3148.1899999999996,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 6.8,
      "layouts": 6,
      "layoutDurationMs": 1.687,
      "taskDurationMs": 1717.0789999999997,
      "heapDeltaBytes": -16815620,
      "heapUsedBytes": 93435740,
      "domNodes": 0,
      "jsHeapTotalBytes": 2293760,
      "scriptDurationMs": 844.572,
      "eventListeners": 182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.933689839572192,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2045.799000000045,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 2.3819999999999997,
      "layouts": 7,
      "layoutDurationMs": 2.028,
      "taskDurationMs": 602.6560000000001,
      "heapDeltaBytes": -22207596,
      "heapUsedBytes": 85768196,
      "domNodes": -296,
      "jsHeapTotalBytes": -2449408,
      "scriptDurationMs": 33.847,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665853658536584,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2115.4539999999997,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 4.369000000000001,
      "layouts": 9,
      "layoutDurationMs": 3.797,
      "taskDurationMs": 684.7930000000001,
      "heapDeltaBytes": 183504,
      "heapUsedBytes": 100221332,
      "domNodes": -296,
      "jsHeapTotalBytes": -2527232,
      "scriptDurationMs": 45.747,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666141732283464,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 546.4000000000055,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 7.541999999999999,
      "layouts": 9,
      "layoutDurationMs": 2.6780000000000004,
      "taskDurationMs": 358.033,
      "heapDeltaBytes": 25238048,
      "heapUsedBytes": 114706004,
      "domNodes": 0,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 121.877,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663636363636368,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 559.0030000000752,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 6.497,
      "layouts": 9,
      "layoutDurationMs": 2.5989999999999998,
      "taskDurationMs": 355.79900000000004,
      "heapDeltaBytes": 22983904,
      "heapUsedBytes": 112682480,
      "domNodes": 0,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 111.894,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.667647058823537,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2042.8650000000061,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 3.922,
      "layouts": 11,
      "layoutDurationMs": 3.5160000000000005,
      "taskDurationMs": 521.0279999999999,
      "heapDeltaBytes": -22302984,
      "heapUsedBytes": 82522300,
      "domNodes": -218,
      "jsHeapTotalBytes": -3051520,
      "scriptDurationMs": 12.749000000000002,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665853658536584,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2044.6119999999723,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 3.8989999999999996,
      "layouts": 12,
      "layoutDurationMs": 3.5790000000000006,
      "taskDurationMs": 564.1999999999999,
      "heapDeltaBytes": -16721500,
      "heapUsedBytes": 87726632,
      "domNodes": -198,
      "jsHeapTotalBytes": -3051520,
      "scriptDurationMs": 13.094999999999999,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665853658536587,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1742.996000000005,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 19.547,
      "layouts": 10,
      "layoutDurationMs": 3.6900000000000004,
      "taskDurationMs": 716.715,
      "heapDeltaBytes": 14942308,
      "heapUsedBytes": 106934616,
      "domNodes": 0,
      "jsHeapTotalBytes": 3145728,
      "scriptDurationMs": 106.188,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665714285714284,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1727.7589999999918,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 16.521,
      "layouts": 10,
      "layoutDurationMs": 2.6279999999999997,
      "taskDurationMs": 753.794,
      "heapDeltaBytes": -7215684,
      "heapUsedBytes": 82953720,
      "domNodes": -210,
      "jsHeapTotalBytes": 2424832,
      "scriptDurationMs": 108.11,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666346153846153,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 892.989,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 19.973,
      "layouts": 5,
      "layoutDurationMs": 11.548,
      "taskDurationMs": 726.3030000000001,
      "heapDeltaBytes": 35779128,
      "heapUsedBytes": 139889408,
      "domNodes": 16030,
      "jsHeapTotalBytes": 16654336,
      "scriptDurationMs": 25.427999999999994,
      "eventListeners": 3244,
      "totalBlockingTimeMs": 116,
      "frameDurationMs": 21.030952380952385,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 10646.274000000005,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 41.696999999999996,
      "layouts": 8,
      "layoutDurationMs": 2.354,
      "taskDurationMs": 4849.36,
      "heapDeltaBytes": 2711720,
      "heapUsedBytes": 109187400,
      "domNodes": -302,
      "jsHeapTotalBytes": -4096,
      "scriptDurationMs": 2265.12,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666197183098593,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 11325.641000000018,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 40.946,
      "layouts": 8,
      "layoutDurationMs": 2.319,
      "taskDurationMs": 5018.192,
      "heapDeltaBytes": -21065676,
      "heapUsedBytes": 98925028,
      "domNodes": -296,
      "jsHeapTotalBytes": -200704,
      "scriptDurationMs": 2210.197,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666029411764708,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16760.333000000002,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16270.013999999996,
      "heapDeltaBytes": -10725096,
      "heapUsedBytes": 294191120,
      "domNodes": -3344,
      "jsHeapTotalBytes": 17813504,
      "scriptDurationMs": 233.23100000000002,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 28.95699481865285,
      "p95FrameDurationMs": 50.10000000000218
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12884.529000000042,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12331.713,
      "heapDeltaBytes": -14261404,
      "heapUsedBytes": 286989696,
      "domNodes": -3344,
      "jsHeapTotalBytes": 27512832,
      "scriptDurationMs": 197.43000000000004,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 22.173493975903618,
      "p95FrameDurationMs": 33.5
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 19513.27200000003,
      "styleRecalcs": 151,
      "styleRecalcDurationMs": 23.596000000000007,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 19137.531,
      "heapDeltaBytes": -27060380,
      "heapUsedBytes": 292547108,
      "domNodes": -3344,
      "jsHeapTotalBytes": 17027072,
      "scriptDurationMs": 745.0150000000001,
      "eventListeners": -651,
      "totalBlockingTimeMs": 3,
      "frameDurationMs": 36.44141791044776,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 19374.742999999966,
      "styleRecalcs": 145,
      "styleRecalcDurationMs": 23.506,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 19070.826999999997,
      "heapDeltaBytes": -37162312,
      "heapUsedBytes": 293403660,
      "domNodes": -3344,
      "jsHeapTotalBytes": 16764928,
      "scriptDurationMs": 731.4359999999999,
      "eventListeners": -651,
      "totalBlockingTimeMs": 2,
      "frameDurationMs": 36.370676691729315,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5073.117000000025,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 47.10500000000001,
      "layouts": 20,
      "layoutDurationMs": 26.117,
      "taskDurationMs": 4947.122,
      "heapDeltaBytes": -4659072,
      "heapUsedBytes": 308243116,
      "domNodes": -3344,
      "jsHeapTotalBytes": 23842816,
      "scriptDurationMs": 91.477,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 27.991712707182327,
      "p95FrameDurationMs": 66.59999999999854
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6305.0479999999425,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 48.05899999999999,
      "layouts": 20,
      "layoutDurationMs": 25.521,
      "taskDurationMs": 6195.791,
      "heapDeltaBytes": -17069296,
      "heapUsedBytes": 293779648,
      "domNodes": -3344,
      "jsHeapTotalBytes": 23056384,
      "scriptDurationMs": 100.474,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 36.84093567251462,
      "p95FrameDurationMs": 83.29999999999927
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8605.794000000004,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8372.036,
      "heapDeltaBytes": -10040912,
      "heapUsedBytes": 279794060,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 120.44100000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 29.507876712328766,
      "p95FrameDurationMs": 66.69999999999709
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8391.492000000086,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8196.662999999999,
      "heapDeltaBytes": -6324040,
      "heapUsedBytes": 291869920,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 111.286,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 30.10645161290322,
      "p95FrameDurationMs": 66.59999999999854
    },
    {
      "name": "workflow-execution",
      "durationMs": 122.27200000000948,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.349000000000002,
      "layouts": 9,
      "layoutDurationMs": 3.7239999999999998,
      "taskDurationMs": 77.886,
      "heapDeltaBytes": 4838428,
      "heapUsedBytes": 105461240,
      "domNodes": 120,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 8.498999999999999,
      "eventListeners": 1,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.67142857142861,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "workflow-execution",
      "durationMs": 91.01299999997536,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 8.743999999999998,
      "layouts": 7,
      "layoutDurationMs": 2.432,
      "taskDurationMs": 64.21600000000001,
      "heapDeltaBytes": 4664452,
      "heapUsedBytes": 104833372,
      "domNodes": 117,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 5.420000000000001,
      "eventListeners": 1,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 344.6079999999938,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 0.753,
      "layouts": 76,
      "layoutDurationMs": 18.203,
      "taskDurationMs": 300.908,
      "heapDeltaBytes": 11120144,
      "heapUsedBytes": 101391632,
      "domNodes": 4,
      "jsHeapTotalBytes": 11534336,
      "scriptDurationMs": 134.58999999999997,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666647,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 400.38700000002336,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 0.766,
      "layouts": 76,
      "layoutDurationMs": 20.548000000000002,
      "taskDurationMs": 348.288,
      "heapDeltaBytes": 11706044,
      "heapUsedBytes": 101756288,
      "domNodes": 4,
      "jsHeapTotalBytes": 12320768,
      "scriptDurationMs": 160.99099999999999,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 411.82000000003427,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 2.917,
      "layouts": 76,
      "layoutDurationMs": 19.316,
      "taskDurationMs": 368.33099999999996,
      "heapDeltaBytes": -116604,
      "heapUsedBytes": 116761412,
      "domNodes": 4,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 136.44699999999997,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663999999999977,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 411.6749999999456,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 3.04,
      "layouts": 76,
      "layoutDurationMs": 17.416,
      "taskDurationMs": 359.63599999999997,
      "heapDeltaBytes": -368004,
      "heapUsedBytes": 116569084,
      "domNodes": 4,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 134.233,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.664000000000016,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage

Line coverage: 63.7%

Coverage totals
Metric Covered Total Pct
Lines 57393 90102 63.7% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 66.5% 1168
src/LGraphNode.ts 70.6% 388
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/components/TopUpCreditsDialogContentWorkspace.vue 0.9% 314
src/platform/workspace/stores/billingOperationStore.ts 8.2% 313
src/workbench/extensions/agent/crdt/docOpMinter.ts 0.6% 312
src/core/billing/operationLifecycle.ts 1.3% 303
src/LGraph.ts 78.9% 274
src/platform/workspace/stores/teamWorkspaceStore.ts 46.9% 252
src/core/webSessionIdentity.ts 3.3% 231

🎭 Playwright: ✅ 2988 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 2289 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • cloud: View Report (✅ 670 / ❌ 0 / ⚠️ 2 / ⏭️ 0)
  • desktop: View Report (✅ 4 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 19 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-safari: View Report (✅ 3 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/29/2026, 10:31:29 AM UTC

Links

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

No verdict is available. Open the workflow run to confirm the check was intentionally skipped, or fix the collection failure and re-run it.

Findings and check details

The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

Findings and check details

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 68533adf1505709ed0c31fe0747e4c76fe8b1695

Full docs: ADR-DEVEX-LINT-0015

🏛️ Architecture: ✅ Passed

Findings and check details

Warnings (132)

  • src/components/graph/selectionToolbox/LinkSelectionActions.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/searchbox/v2/filterChip.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.stories.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardFooter.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardHeader.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardTitle.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/card.variants.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/billing/useSubscriptionPaywall.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/billing/useSubscriptionPaywall.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/graph/menuOption.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useLiveGraphNode.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useLiveGraphNode.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/litegraphServiceAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/nodeDef/ComfyNodeDefImpl.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/selection/selectionIntent.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/cameraInfo.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dInstances.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/slotDefaults.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/i18n.literalMessages.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/canvasClassAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkSelection.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkSelection.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/authStoreAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/currentUserAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/sessionCookieAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/sessionRevokedError.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/webSessionFetch.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/sso/ssoRequiredContext.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/missingModel/releaseModelOptions.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/missingModel/releaseModelOptions.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/telemetry/billingActionNames.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/telemetry/billingActionNames.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/telemetry/extensionLoadTelemetry.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/__fixtures__/deploymentListing.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/api/deploymentListingTimeouts.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/api/workspaceApi.webSessionRetry.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/billingRefresh.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/billingRefresh.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/billingTab.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/billingTab.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/topupCheckoutReturnUrl.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • …and 82 more
Reproduce locally
pnpm architecture:check

Full docs: Frontend domain catalog

@github-actions
github-actions Bot requested a review from thedatalife October 29, 2026 10:00

@dante01yoon dante01yoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport of #21285 (merged). Approving the backport; CI was still running at review time with no failures so far — please merge once it's green.

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 29, 2026
@codecov

codecov Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.87234% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/workbench/extensions/agent/AgentPanelRoot.vue 97.14% 1 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.58   #22225   +/-   ##
=============================================
  Coverage              ?   84.50%           
=============================================
  Files                 ?     3102           
  Lines                 ?   163039           
  Branches              ?    41432           
=============================================
  Hits                  ?   137778           
  Misses                ?    24870           
  Partials              ?      391           
Flag Coverage Δ
e2e 63.83% <ø> (?)
unit 85.99% <97.87%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ensions/agent/components/agent/OnboardingCoach.vue 100.00% <100.00%> (ø)
src/workbench/extensions/agent/AgentPanelRoot.vue 95.61% <97.14%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…r the account changes

Without a release on these transitions the held send waits until the
panel unmounts, and an account switch without reload can send the first
account's draft under the second account's consent.
…ntity changes

Ports the release condition and the consent-identity recheck that main
already has, so the held send restores the draft instead of waiting or
going out under another account's consent.
@christian-byrne

Copy link
Copy Markdown
Contributor Author

@dante01yoon two commits landed after your approval (head a4d6b49259), please take a look:

  • Hold now also ends when consent is cleared or the account changes.
  • Release checks the consent identity, same as main.
  • Two new tests, red before the fix.
Full context for agent readers

Review of the core/1.58 backport found that, without these, a send held for one account could go out under another account's consent after a sign-in switch without reload, and a consent clear with the panel open left the send waiting until unmount. Main already has both via #21532. Commits: test(agent): a coach-held send is not sent after consent is cleared or the account changes and fix(agent): release the coach hold when consent is cleared or its identity changes. AgentPanelRoot + OnboardingCoach suites on this branch: 514/514. The other three lines get the same two commits in separate follow-ups because their backports merged first.

comfy-pr-bot pushed a commit that referenced this pull request Oct 29, 2026
…is cleared or its identity changes (#22233)

Follow-up to the backport of
#21285 on this line
(#22226). That PR
merged before these two commits were pushed to its branch.

## What

The coach-tour hold on the first send now also ends when consent is
cleared or the consent identity changes, and the release checks that the
identity still matches the one that accepted. Main already has both
(they came with
#21532, which is not
on this line).

## Why

Found in review of the backport:

- After a sign-out and sign-in as another user without a reload, a send
held for the first account could go out under the second account's
consent once the second account's tour finished or stalled.
- Clearing consent with the panel open left the send waiting, with no
tour card, until the panel was closed.

## Tests

Two new `AgentPanelRoot.test.ts` cases, written first and failing before
the fix:

- puts the draft back when consent is cleared while the panel stays open
- puts the draft back when the consent identity changes during the hold

`vitest run AgentPanelRoot.test.ts OnboardingCoach.test.ts` on this
line: 478/478. Typecheck, oxlint, eslint and oxfmt clean (pre-commit).

The same two commits are already on the cloud/1.58 backport:
#22225

Tracking: https://linear.app/comfyorg/issue/BE-21344
comfy-pr-bot pushed a commit that referenced this pull request Oct 29, 2026
… is cleared or its identity changes (#22234)

Follow-up to the backport of
#21285 on this line
(#22227). That PR
merged before these two commits were pushed to its branch.

## What

The coach-tour hold on the first send now also ends when consent is
cleared or the consent identity changes, and the release checks that the
identity still matches the one that accepted. Main already has both
(they came with
#21532, which is not
on this line).

## Why

Found in review of the backport:

- After a sign-out and sign-in as another user without a reload, a send
held for the first account could go out under the second account's
consent once the second account's tour finished or stalled.
- Clearing consent with the panel open left the send waiting, with no
tour card, until the panel was closed.

## Tests

Two new `AgentPanelRoot.test.ts` cases, written first and failing before
the fix:

- puts the draft back when consent is cleared while the panel stays open
- puts the draft back when the consent identity changes during the hold

`vitest run AgentPanelRoot.test.ts OnboardingCoach.test.ts` on this
line: 476/476. Typecheck, oxlint, eslint and oxfmt clean (pre-commit).

The same two commits are already on the cloud/1.58 backport:
#22225

Tracking: https://linear.app/comfyorg/issue/BE-21344
@comfy-pr-bot
comfy-pr-bot merged commit fe7bcc9 into cloud/1.58 Oct 29, 2026
118 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-21285-to-cloud-1.58 branch October 29, 2026 11:05
comfy-pr-bot pushed a commit that referenced this pull request Oct 29, 2026
…is cleared or its identity changes (#22232)

Follow-up to the backport of
#21285 on this line
(#22223). That PR
merged before these two commits were pushed to its branch.

## What

The coach-tour hold on the first send now also ends when consent is
cleared or the consent identity changes, and the release checks that the
identity still matches the one that accepted. Main already has both
(they came with
#21532, which is not
on this line).

## Why

Found in review of the backport:

- After a sign-out and sign-in as another user without a reload, a send
held for the first account could go out under the second account's
consent once the second account's tour finished or stalled.
- Clearing consent with the panel open left the send waiting, with no
tour card, until the panel was closed.

## Tests

Two new `AgentPanelRoot.test.ts` cases, written first and failing before
the fix:

- puts the draft back when consent is cleared while the panel stays open
- puts the draft back when the consent identity changes during the hold

`vitest run AgentPanelRoot.test.ts OnboardingCoach.test.ts` on this
line: 514/514. Typecheck, oxlint, eslint and oxfmt clean (pre-commit).

The same two commits are already on the cloud/1.58 backport:
#22225

Tracking: https://linear.app/comfyorg/issue/BE-21344
nina-mir pushed a commit to nina-mir/ComfyUI_frontend that referenced this pull request Oct 30, 2026
…her tab (Comfy-Org#22238)

## Summary

A new user's first message waits behind the intro tour (Comfy-Org#21285). If the
tour is finished in another tab, the card here went away without telling
the panel, so the held message waited until the panel was closed. Now it
sends.

## Change

`OnboardingCoach` emits `finished` when the tour completes outside this
card (another tab, or any other write to the onboarding flag). Skip and
Done still emit once; an emptied step list does not count as completion.

This matters more once
Comfy-Org#21857 stores tour
completion in a synced setting, because the flag can then flip from
outside the card while a message is held.

## Tests (written first)

- `AgentPanelRoot.test.ts`: sends once when another tab finishes the
tour during the hold (failed before the fix).
- `OnboardingCoach.test.ts`: reports the tour finished when another tab
completes it (failed before the fix); reports finished once on Skip and
on Done; reports a later completion in another tab after a replay.
- AgentPanelRoot + OnboardingCoach suites: 598/598. Typecheck clean.

## Review findings from the core/1.58 backport (Comfy-Org#22223), and why the
rest are not here

- Consent cleared or account switched during the hold: already handled
on main (consent-identity recheck from Comfy-Org#21532); ported to the release
lines in Comfy-Org#22225, Comfy-Org#22232, Comfy-Org#22233, Comfy-Org#22234.
- Stall reported only once per coach: not reachable for the held send.
The coach mounts when consent is accepted, and the hold only applies to
a send made before consent, so a stall always happens during the hold
and releases it.
- Release and close in the same flush: clearing the held flag at release
breaks draft restore on a plain close (existing test), so it is left as
is and tracked in https://linear.app/comfyorg/issue/BE-24366.
- Notice copy omits the automatic stall release: kept, the user cannot
trigger it (https://linear.app/comfyorg/issue/BE-23265).

Tracking: https://linear.app/comfyorg/issue/BE-21344
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants