Repository navigation
[backport cloud/1.57] fix(agent): release the coach hold when consent is cleared or its identity changes - #22234
Conversation
…r the account changes Without a release on these transitions the held send waits until the panel unmounts, and an account switch without reload can send the first account's draft under the second account's consent.
…ntity changes Ports the release condition and the consent-identity recheck that main already has, so the held send restores the draft instead of waiting or going out under another account's consent.
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-29T10:55:59.848Z",
"gitSha": "e9e19c7e704302e42a91e8dc43c5b6b2ff58a9cc",
"branch": "consent-identity-hold-cloud-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2021.959000000038,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.195,
"layouts": 10,
"layoutDurationMs": 3.0979999999999994,
"taskDurationMs": 518.8969999999999,
"heapDeltaBytes": 21641704,
"heapUsedBytes": 87880916,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 10.145999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2007.158000000004,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.9970000000000003,
"layouts": 10,
"layoutDurationMs": 2.95,
"taskDurationMs": 507.671,
"heapDeltaBytes": 3394060,
"heapUsedBytes": 77450660,
"domNodes": 0,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 9.502,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1752.900000000011,
"styleRecalcs": 74,
"styleRecalcDurationMs": 15.864000000000003,
"layouts": 8,
"layoutDurationMs": 2.466,
"taskDurationMs": 753.554,
"heapDeltaBytes": 15571116,
"heapUsedBytes": 81077872,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 168.11,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664761904761903,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1723.0240000000094,
"styleRecalcs": 73,
"styleRecalcDurationMs": 14.814,
"layouts": 10,
"layoutDurationMs": 2.824,
"taskDurationMs": 723.3539999999999,
"heapDeltaBytes": 15615808,
"heapUsedBytes": 81945008,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 162.163,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.8670000000175,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.452999999999999,
"layouts": 11,
"layoutDurationMs": 3.0429999999999997,
"taskDurationMs": 391.719,
"heapDeltaBytes": -4537036,
"heapUsedBytes": 71287772,
"domNodes": 47,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 11.117000000000003,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1789.3100000000004,
"styleRecalcs": 19,
"styleRecalcDurationMs": 6.238,
"layouts": 12,
"layoutDurationMs": 3.3009999999999997,
"taskDurationMs": 459.4989999999999,
"heapDeltaBytes": -4524892,
"heapUsedBytes": 70948996,
"domNodes": 47,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 13.537999999999998,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665420560747663,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 693.8499999999976,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.967,
"layouts": 9,
"layoutDurationMs": 2.4360000000000004,
"taskDurationMs": 491.88300000000004,
"heapDeltaBytes": 25186352,
"heapUsedBytes": 91852736,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 172.924,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664285714285718,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 712.6969999999346,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.254,
"layouts": 10,
"layoutDurationMs": 2.594,
"taskDurationMs": 500.282,
"heapDeltaBytes": 3468600,
"heapUsedBytes": 79380068,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 171.62800000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.05952380952381,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1257.3970000000259,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 955.264,
"heapDeltaBytes": 484652,
"heapUsedBytes": 81112584,
"domNodes": -212,
"jsHeapTotalBytes": 13901824,
"scriptDurationMs": 73.56400000000001,
"eventListeners": -106,
"totalBlockingTimeMs": 569,
"frameDurationMs": 33.78378378378378,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1204.4409999999743,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 856.492,
"heapDeltaBytes": -11731636,
"heapUsedBytes": 81197504,
"domNodes": -192,
"jsHeapTotalBytes": 20979712,
"scriptDurationMs": 77.77999999999999,
"eventListeners": -106,
"totalBlockingTimeMs": 532,
"frameDurationMs": 33.33055555555555,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 842.0200000000477,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 498.1900000000001,
"heapDeltaBytes": -4536864,
"heapUsedBytes": 76673708,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 160.962,
"eventListeners": 0,
"totalBlockingTimeMs": 219,
"frameDurationMs": 25.00000000000003,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 864.6029999999882,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.77100000000024,
"heapDeltaBytes": -4767400,
"heapUsedBytes": 76197704,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 160.84899999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 230,
"frameDurationMs": 25.48823529411763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11016.342000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10076.144,
"heapDeltaBytes": -23613532,
"heapUsedBytes": 70717296,
"domNodes": -258,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 8137.347,
"eventListeners": -68,
"totalBlockingTimeMs": 1314,
"frameDurationMs": 31.517191977077363,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9815.530999999964,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9026.988,
"heapDeltaBytes": -11882912,
"heapUsedBytes": 84206588,
"domNodes": -258,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 7303.631,
"eventListeners": -68,
"totalBlockingTimeMs": 657,
"frameDurationMs": 31.767637540453077,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9076.449999999966,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.3259999999999999,
"layouts": 1,
"layoutDurationMs": 0.3180000000000001,
"taskDurationMs": 8280.534,
"heapDeltaBytes": -8503572,
"heapUsedBytes": 91462036,
"domNodes": -258,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 6958.585,
"eventListeners": -68,
"totalBlockingTimeMs": 778,
"frameDurationMs": 32.90942028985507,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9784.356000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8978.368,
"heapDeltaBytes": 2748496,
"heapUsedBytes": 96897924,
"domNodes": -258,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 7240.267,
"eventListeners": -68,
"totalBlockingTimeMs": 692,
"frameDurationMs": 31.456270096463022,
"p95FrameDurationMs": 50.099999999999454
},
{
"name": "large-combo-open",
"durationMs": 232.91499999999132,
"styleRecalcs": 25,
"styleRecalcDurationMs": 15.167,
"layouts": 12,
"layoutDurationMs": 3.6899999999999995,
"taskDurationMs": 170.779,
"heapDeltaBytes": -8107816,
"heapUsedBytes": 79885008,
"domNodes": 917,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 8.945000000000002,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.209090909090843,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 230.2559999999403,
"styleRecalcs": 23,
"styleRecalcDurationMs": 14.979999999999999,
"layouts": 10,
"layoutDurationMs": 2.794,
"taskDurationMs": 167.87199999999999,
"heapDeltaBytes": -8155564,
"heapUsedBytes": 79720788,
"domNodes": 917,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 8.344000000000001,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.209090909090925,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-graph-idle",
"durationMs": 2041.0759999999755,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.1780000000000013,
"layouts": 6,
"layoutDurationMs": 2.4869999999999997,
"taskDurationMs": 499.08299999999997,
"heapDeltaBytes": -3381372,
"heapUsedBytes": 76046952,
"domNodes": -258,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 33.934,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2051.894999999945,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.1329999999999996,
"layouts": 7,
"layoutDurationMs": 2.1139999999999994,
"taskDurationMs": 658.1669999999999,
"heapDeltaBytes": -18021596,
"heapUsedBytes": 78796656,
"domNodes": -258,
"jsHeapTotalBytes": 3047424,
"scriptDurationMs": 39.198,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2474.1640000000302,
"styleRecalcs": 69,
"styleRecalcDurationMs": 6.779,
"layouts": 8,
"layoutDurationMs": 2.281,
"taskDurationMs": 1709.0449999999998,
"heapDeltaBytes": -29798980,
"heapUsedBytes": 68760332,
"domNodes": -278,
"jsHeapTotalBytes": 6193152,
"scriptDurationMs": 832.284,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.779591836734696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2308.3460000000287,
"styleRecalcs": 67,
"styleRecalcDurationMs": 5.856,
"layouts": 5,
"layoutDurationMs": 1.4390000000000003,
"taskDurationMs": 1538.0849999999998,
"heapDeltaBytes": -11843628,
"heapUsedBytes": 68252160,
"domNodes": -258,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 828.356,
"eventListeners": -65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.0362962962963,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3695.970999999986,
"styleRecalcs": 71,
"styleRecalcDurationMs": 7.542,
"layouts": 64,
"layoutDurationMs": 10.482,
"taskDurationMs": 1772.496,
"heapDeltaBytes": -4911264,
"heapUsedBytes": 72288304,
"domNodes": -234,
"jsHeapTotalBytes": 1961984,
"scriptDurationMs": 782.1669999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.741818181818182,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3605.179000000021,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.026,
"layouts": 64,
"layoutDurationMs": 11.081000000000001,
"taskDurationMs": 1651.4560000000001,
"heapDeltaBytes": -11392540,
"heapUsedBytes": 70677052,
"domNodes": -254,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 810.63,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.74325581395349,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3084.781000000021,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.979000000000001,
"layouts": 5,
"layoutDurationMs": 1.3329999999999995,
"taskDurationMs": 1970.0030000000002,
"heapDeltaBytes": 36047920,
"heapUsedBytes": 114798768,
"domNodes": 0,
"jsHeapTotalBytes": 5136384,
"scriptDurationMs": 978.9920000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.120765027322403,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3095.6939999999804,
"styleRecalcs": 42,
"styleRecalcDurationMs": 4.371999999999999,
"layouts": 3,
"layoutDurationMs": 0.8859999999999997,
"taskDurationMs": 1970.1500000000003,
"heapDeltaBytes": 4796552,
"heapUsedBytes": 83025868,
"domNodes": 0,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 965.3720000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.028260869565216,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2043.5520000000338,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.763,
"layouts": 6,
"layoutDurationMs": 1.824,
"taskDurationMs": 632.804,
"heapDeltaBytes": -1797540,
"heapUsedBytes": 79545272,
"domNodes": -258,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 32.572,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2043.0039999999963,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.377,
"layouts": 7,
"layoutDurationMs": 2.232,
"taskDurationMs": 647.7729999999999,
"heapDeltaBytes": -5619800,
"heapUsedBytes": 76687312,
"domNodes": -278,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 33.852999999999994,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 641.8940000000362,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.229,
"layouts": 8,
"layoutDurationMs": 2.318,
"taskDurationMs": 455.28999999999996,
"heapDeltaBytes": 21596440,
"heapUsedBytes": 89360824,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 146.672,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 565.1749999999538,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.332,
"layouts": 11,
"layoutDurationMs": 3.4339999999999997,
"taskDurationMs": 385.24399999999997,
"heapDeltaBytes": 19887864,
"heapUsedBytes": 87359516,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 151.309,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2008.4870000000024,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.5129999999999995,
"layouts": 9,
"layoutDurationMs": 3.1079999999999997,
"taskDurationMs": 555.916,
"heapDeltaBytes": -227756,
"heapUsedBytes": 77116136,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 10.559000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2008.375000000001,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.835999999999999,
"layouts": 10,
"layoutDurationMs": 3.0100000000000007,
"taskDurationMs": 360.56899999999996,
"heapDeltaBytes": 22346608,
"heapUsedBytes": 90404996,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 8.522999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1757.267000000013,
"styleRecalcs": 78,
"styleRecalcDurationMs": 17.68,
"layouts": 9,
"layoutDurationMs": 2.9080000000000004,
"taskDurationMs": 932.8939999999999,
"heapDeltaBytes": -10459564,
"heapUsedBytes": 66066004,
"domNodes": -172,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 120.85799999999999,
"eventListeners": -112,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.316000000058,
"styleRecalcs": 77,
"styleRecalcDurationMs": 15.261999999999997,
"layouts": 9,
"layoutDurationMs": 2.5289999999999995,
"taskDurationMs": 806.397,
"heapDeltaBytes": -6777232,
"heapUsedBytes": 70237060,
"domNodes": 0,
"jsHeapTotalBytes": 12320768,
"scriptDurationMs": 108.837,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262135,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1435.3399999999965,
"styleRecalcs": 18,
"styleRecalcDurationMs": 27.234,
"layouts": 5,
"layoutDurationMs": 16.276,
"taskDurationMs": 1033.748,
"heapDeltaBytes": 7274840,
"heapUsedBytes": 103186136,
"domNodes": 15953,
"jsHeapTotalBytes": 16650240,
"scriptDurationMs": 30.886999999999997,
"eventListeners": 3244,
"totalBlockingTimeMs": 165,
"frameDurationMs": 19.861643835616444,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8959.577000000025,
"styleRecalcs": 250,
"styleRecalcDurationMs": 18.819000000000003,
"layouts": 7,
"layoutDurationMs": 1.938,
"taskDurationMs": 5851.03,
"heapDeltaBytes": 4009072,
"heapUsedBytes": 83098284,
"domNodes": -258,
"jsHeapTotalBytes": 5070848,
"scriptDurationMs": 2677.77,
"eventListeners": -65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.728358208955225,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8285.438999999997,
"styleRecalcs": 248,
"styleRecalcDurationMs": 18.866,
"layouts": 6,
"layoutDurationMs": 1.605,
"taskDurationMs": 5099.543000000001,
"heapDeltaBytes": 5316264,
"heapUsedBytes": 84293668,
"domNodes": -258,
"jsHeapTotalBytes": 4284416,
"scriptDurationMs": 2702.444,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.733333333333334,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16406.634999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15515.770999999999,
"heapDeltaBytes": -18544560,
"heapUsedBytes": 271504432,
"domNodes": -3330,
"jsHeapTotalBytes": 20963328,
"scriptDurationMs": 266.64300000000003,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.157804459691253,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-idle",
"durationMs": 23171.030000000086,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22609.644,
"heapDeltaBytes": -20672596,
"heapUsedBytes": 280400052,
"domNodes": -3334,
"jsHeapTotalBytes": 9687040,
"scriptDurationMs": 319.26699999999994,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.940862068965515,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-large-graph-pan",
"durationMs": 28257.42299999996,
"styleRecalcs": 181,
"styleRecalcDurationMs": 16.026000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27884.427,
"heapDeltaBytes": -41207268,
"heapUsedBytes": 254404252,
"domNodes": -3330,
"jsHeapTotalBytes": 6541312,
"scriptDurationMs": 912.52,
"eventListeners": -651,
"totalBlockingTimeMs": 40,
"frameDurationMs": 52.605027932960894,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 19730.81400000001,
"styleRecalcs": 154,
"styleRecalcDurationMs": 13.034999999999991,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19345.858,
"heapDeltaBytes": 720728,
"heapUsedBytes": 291322188,
"domNodes": -3330,
"jsHeapTotalBytes": 12242944,
"scriptDurationMs": 854.7529999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.37053406998159,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 8240.46500000003,
"styleRecalcs": 20,
"styleRecalcDurationMs": 72.93000000000002,
"layouts": 20,
"layoutDurationMs": 22.363999999999994,
"taskDurationMs": 8076.167000000001,
"heapDeltaBytes": -29292724,
"heapUsedBytes": 271082132,
"domNodes": -3330,
"jsHeapTotalBytes": 20963328,
"scriptDurationMs": 125.027,
"eventListeners": -653,
"totalBlockingTimeMs": 8,
"frameDurationMs": 45.48618784530387,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 8355.545000000006,
"styleRecalcs": 20,
"styleRecalcDurationMs": 75.067,
"layouts": 20,
"layoutDurationMs": 22.536000000000016,
"taskDurationMs": 8246.188999999998,
"heapDeltaBytes": 200516,
"heapUsedBytes": 276777868,
"domNodes": -3330,
"jsHeapTotalBytes": 20172800,
"scriptDurationMs": 128.429,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.34659090909092,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11471.931999999924,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11198.340999999999,
"heapDeltaBytes": 4749048,
"heapUsedBytes": 282879684,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 167.481,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.374295774647884,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11578.634999999962,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11337.046999999999,
"heapDeltaBytes": 9092708,
"heapUsedBytes": 269933776,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 163.79399999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.88344827586207,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "workflow-execution",
"durationMs": 480.0510000000031,
"styleRecalcs": 12,
"styleRecalcDurationMs": 11.198,
"layouts": 11,
"layoutDurationMs": 6.385999999999999,
"taskDurationMs": 146.11200000000002,
"heapDeltaBytes": -12927316,
"heapUsedBytes": 70071252,
"domNodes": 98,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 15.873999999999999,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379302,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 480.7710000000043,
"styleRecalcs": 22,
"styleRecalcDurationMs": 16.681,
"layouts": 13,
"layoutDurationMs": 4.554,
"taskDurationMs": 135.256,
"heapDeltaBytes": -8498628,
"heapUsedBytes": 71457320,
"domNodes": 121,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 11.708000000000002,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379302,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 505.64300000007734,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.035,
"layouts": 76,
"layoutDurationMs": 15.512,
"taskDurationMs": 453.091,
"heapDeltaBytes": 11537976,
"heapUsedBytes": 83915384,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 218.73999999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 532.1109999999862,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.267,
"layouts": 76,
"layoutDurationMs": 15.443999999999999,
"taskDurationMs": 487.04600000000005,
"heapDeltaBytes": 12379664,
"heapUsedBytes": 83806516,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 242.249,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 599.7089999999616,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.435,
"layouts": 76,
"layoutDurationMs": 15.498,
"taskDurationMs": 563.812,
"heapDeltaBytes": 973644,
"heapUsedBytes": 120898936,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 236.69899999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.127777777777762,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 525.2829999999449,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.839,
"layouts": 76,
"layoutDurationMs": 14.524000000000001,
"taskDurationMs": 493.315,
"heapDeltaBytes": 317304,
"heapUsedBytes": 123181244,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 203.99499999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.1875,
"p95FrameDurationMs": 16.800000000000182
}
]
}🎭 Playwright: ✅ 2282 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since ff668baafa30cd123108fed5d979cf1ba2f28a88
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.57 #22234 +/- ##
=============================================
Coverage ? 85.23%
=============================================
Files ? 2526
Lines ? 133301
Branches ? 38410
=============================================
Hits ? 113616
Misses ? 19269
Partials ? 416
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Backport LGTM — same two commits (test + fix for releasing the coach hold on consent clear/identity change) cleanly applied to this release line.
…her tab (Comfy-Org#22238) ## Summary A new user's first message waits behind the intro tour (Comfy-Org#21285). If the tour is finished in another tab, the card here went away without telling the panel, so the held message waited until the panel was closed. Now it sends. ## Change `OnboardingCoach` emits `finished` when the tour completes outside this card (another tab, or any other write to the onboarding flag). Skip and Done still emit once; an emptied step list does not count as completion. This matters more once Comfy-Org#21857 stores tour completion in a synced setting, because the flag can then flip from outside the card while a message is held. ## Tests (written first) - `AgentPanelRoot.test.ts`: sends once when another tab finishes the tour during the hold (failed before the fix). - `OnboardingCoach.test.ts`: reports the tour finished when another tab completes it (failed before the fix); reports finished once on Skip and on Done; reports a later completion in another tab after a replay. - AgentPanelRoot + OnboardingCoach suites: 598/598. Typecheck clean. ## Review findings from the core/1.58 backport (Comfy-Org#22223), and why the rest are not here - Consent cleared or account switched during the hold: already handled on main (consent-identity recheck from Comfy-Org#21532); ported to the release lines in Comfy-Org#22225, Comfy-Org#22232, Comfy-Org#22233, Comfy-Org#22234. - Stall reported only once per coach: not reachable for the held send. The coach mounts when consent is accepted, and the hold only applies to a send made before consent, so a stall always happens during the hold and releases it. - Release and close in the same flush: clearing the held flag at release breaks draft restore on a plain close (existing test), so it is left as is and tracked in https://linear.app/comfyorg/issue/BE-24366. - Notice copy omits the automatic stall release: kept, the user cannot trigger it (https://linear.app/comfyorg/issue/BE-23265). Tracking: https://linear.app/comfyorg/issue/BE-21344
Follow-up to the backport of #21285 on this line (#22227). That PR merged before these two commits were pushed to its branch.
What
The coach-tour hold on the first send now also ends when consent is cleared or the consent identity changes, and the release checks that the identity still matches the one that accepted. Main already has both (they came with #21532, which is not on this line).
Why
Found in review of the backport:
Tests
Two new
AgentPanelRoot.test.tscases, written first and failing before the fix:vitest run AgentPanelRoot.test.ts OnboardingCoach.test.tson this line: 476/476. Typecheck, oxlint, eslint and oxfmt clean (pre-commit).The same two commits are already on the cloud/1.58 backport: #22225
Tracking: https://linear.app/comfyorg/issue/BE-21344