Repository navigation
[backport core/1.58] fix(agent): release the coach hold when consent is cleared or its identity changes - #22232
Conversation
…r the account changes Without a release on these transitions the held send waits until the panel unmounts, and an account switch without reload can send the first account's draft under the second account's consent.
…ntity changes Ports the release condition and the consent-identity recheck that main already has, so the held send restores the draft instead of waiting or going out under another account's consent.
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-29T10:55:24.812Z",
"gitSha": "e1d1fb5eebc0d29e2620b083434e6a1fdcbeacbc",
"branch": "consent-identity-hold-core-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2072.657000000021,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.2710000000000004,
"layouts": 10,
"layoutDurationMs": 3.4779999999999998,
"taskDurationMs": 722.2570000000001,
"heapDeltaBytes": -27180248,
"heapUsedBytes": 77818412,
"domNodes": -206,
"jsHeapTotalBytes": 2715648,
"scriptDurationMs": 15.801000000000002,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258066,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2024.0049999999883,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.2830000000000004,
"layouts": 9,
"layoutDurationMs": 2.4949999999999997,
"taskDurationMs": 424.851,
"heapDeltaBytes": 3344572,
"heapUsedBytes": 93617860,
"domNodes": -200,
"jsHeapTotalBytes": 1900544,
"scriptDurationMs": 9.036999999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66557377049181,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1757.6119999999946,
"styleRecalcs": 77,
"styleRecalcDurationMs": 14.996,
"layouts": 11,
"layoutDurationMs": 3.2390000000000008,
"taskDurationMs": 831.455,
"heapDeltaBytes": -3318572,
"heapUsedBytes": 96966056,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 179.159,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714284,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1889.9759999999333,
"styleRecalcs": 76,
"styleRecalcDurationMs": 13.509999999999998,
"layouts": 10,
"layoutDurationMs": 3.1740000000000004,
"taskDurationMs": 961.646,
"heapDeltaBytes": -1593448,
"heapUsedBytes": 90651896,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 174.48599999999996,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665486725663715,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1705.7209999999827,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.599000000000001,
"layouts": 11,
"layoutDurationMs": 3.2849999999999997,
"taskDurationMs": 362.9870000000001,
"heapDeltaBytes": -1759612,
"heapUsedBytes": 89051888,
"domNodes": 47,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 15.872,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1704.0390000000798,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.768000000000001,
"layouts": 11,
"layoutDurationMs": 3.529,
"taskDurationMs": 362.25399999999996,
"heapDeltaBytes": 25399016,
"heapUsedBytes": 115741244,
"domNodes": 47,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 15.018999999999998,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 759.2929999999853,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.0539999999999994,
"layouts": 9,
"layoutDurationMs": 2.7990000000000004,
"taskDurationMs": 518.729,
"heapDeltaBytes": 4082640,
"heapUsedBytes": 94414528,
"domNodes": 0,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 173.564,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 676.2039999999843,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.8199999999999994,
"layouts": 9,
"layoutDurationMs": 2.456,
"taskDurationMs": 491.389,
"heapDeltaBytes": 6944152,
"heapUsedBytes": 111671804,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 169.415,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664999999999985,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1239.485000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 966.812,
"heapDeltaBytes": -16879588,
"heapUsedBytes": 102497616,
"domNodes": -236,
"jsHeapTotalBytes": 16064512,
"scriptDurationMs": 71.801,
"eventListeners": -168,
"totalBlockingTimeMs": 528,
"frameDurationMs": 32.45526315789472,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1219.4810000000302,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 858.0510000000002,
"heapDeltaBytes": -15584096,
"heapUsedBytes": 102401208,
"domNodes": -230,
"jsHeapTotalBytes": 15802368,
"scriptDurationMs": 76.03500000000001,
"eventListeners": -168,
"totalBlockingTimeMs": 534,
"frameDurationMs": 32.87837837837838,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 847.4999999999966,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.5319999999993,
"heapDeltaBytes": -2539072,
"heapUsedBytes": 97737436,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 164.19700000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 218,
"frameDurationMs": 24.9970588235294,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 847.3380000000361,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.7509999999997,
"heapDeltaBytes": -2911396,
"heapUsedBytes": 97510484,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 165.65099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 218,
"frameDurationMs": 24.99705882352943,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 12026.392000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11205.551,
"heapDeltaBytes": 11096152,
"heapUsedBytes": 133602164,
"domNodes": -276,
"jsHeapTotalBytes": 22425600,
"scriptDurationMs": 9366.024,
"eventListeners": -130,
"totalBlockingTimeMs": 2069,
"frameDurationMs": 34.62881844380403,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10295.184000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9538.186,
"heapDeltaBytes": 43087820,
"heapUsedBytes": 146940340,
"domNodes": -276,
"jsHeapTotalBytes": 33619968,
"scriptDurationMs": 7587.592000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 810,
"frameDurationMs": 31.16030303030303,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10790.336999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9989.524,
"heapDeltaBytes": 58989040,
"heapUsedBytes": 163406276,
"domNodes": -296,
"jsHeapTotalBytes": 35979264,
"scriptDurationMs": 8284.877999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 1364,
"frameDurationMs": 32.13791044776119,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9465.24199999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8736.789,
"heapDeltaBytes": 28880060,
"heapUsedBytes": 132382684,
"domNodes": -296,
"jsHeapTotalBytes": 29687808,
"scriptDurationMs": 7190.575,
"eventListeners": -130,
"totalBlockingTimeMs": 712,
"frameDurationMs": 32.141496598639456,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 275.72000000000685,
"styleRecalcs": 25,
"styleRecalcDurationMs": 16.223000000000003,
"layouts": 11,
"layoutDurationMs": 3.73,
"taskDurationMs": 215.43400000000003,
"heapDeltaBytes": 13277508,
"heapUsedBytes": 118279316,
"domNodes": 917,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 12.411,
"eventListeners": 196,
"totalBlockingTimeMs": 2,
"frameDurationMs": 24.25454545454547,
"p95FrameDurationMs": 100.10000000000036
},
{
"name": "large-combo-open",
"durationMs": 232.74100000003273,
"styleRecalcs": 24,
"styleRecalcDurationMs": 13.478999999999997,
"layouts": 11,
"layoutDurationMs": 3.076,
"taskDurationMs": 178.124,
"heapDeltaBytes": 13251424,
"heapUsedBytes": 121511416,
"domNodes": 917,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 8.192,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.209090909090925,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "large-graph-idle",
"durationMs": 2041.4610000000266,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.0739999999999994,
"layouts": 9,
"layoutDurationMs": 3.0109999999999997,
"taskDurationMs": 543.037,
"heapDeltaBytes": 1214272,
"heapUsedBytes": 111520556,
"domNodes": -296,
"jsHeapTotalBytes": -720896,
"scriptDurationMs": 36.692,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2041.5729999999712,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.4090000000000007,
"layouts": 8,
"layoutDurationMs": 2.2179999999999995,
"taskDurationMs": 490.93699999999995,
"heapDeltaBytes": 927996,
"heapUsedBytes": 111563876,
"domNodes": -296,
"jsHeapTotalBytes": -720896,
"scriptDurationMs": 39.02700000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2311.7259999999646,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.006,
"layouts": 8,
"layoutDurationMs": 2.106,
"taskDurationMs": 1612.1720000000003,
"heapDeltaBytes": -9962900,
"heapUsedBytes": 113313928,
"domNodes": -296,
"jsHeapTotalBytes": 405504,
"scriptDurationMs": 875.331,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.78759124087591,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2569.614999999999,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.136000000000001,
"layouts": 9,
"layoutDurationMs": 2.45,
"taskDurationMs": 1753.818,
"heapDeltaBytes": -2662432,
"heapUsedBytes": 108707072,
"domNodes": -296,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 832.4549999999999,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.774509803921568,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3934.7360000000435,
"styleRecalcs": 69,
"styleRecalcDurationMs": 10.104999999999999,
"layouts": 63,
"layoutDurationMs": 10.925,
"taskDurationMs": 1914.3850000000002,
"heapDeltaBytes": 3716900,
"heapUsedBytes": 110509288,
"domNodes": -276,
"jsHeapTotalBytes": -1699840,
"scriptDurationMs": 814.519,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665677966101693,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3862.76799999996,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.179,
"layouts": 64,
"layoutDurationMs": 11.023,
"taskDurationMs": 1793.0860000000002,
"heapDeltaBytes": 7672436,
"heapUsedBytes": 120733004,
"domNodes": 24,
"jsHeapTotalBytes": 5246976,
"scriptDurationMs": 797.4050000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66594827586207,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2872.2009999999614,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.4510000000000005,
"layouts": 5,
"layoutDurationMs": 1.561,
"taskDurationMs": 1836.7060000000001,
"heapDeltaBytes": -11795456,
"heapUsedBytes": 102843920,
"domNodes": 0,
"jsHeapTotalBytes": 6819840,
"scriptDurationMs": 990.8510000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.96094674556213,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2817.924000000062,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.251,
"layouts": 5,
"layoutDurationMs": 1.2100000000000002,
"taskDurationMs": 1810.154,
"heapDeltaBytes": -11106036,
"heapUsedBytes": 103707648,
"domNodes": 0,
"jsHeapTotalBytes": 7081984,
"scriptDurationMs": 980.11,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.86586826347305,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2061.984999999993,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.521999999999999,
"layouts": 7,
"layoutDurationMs": 2.111,
"taskDurationMs": 609.2559999999999,
"heapDeltaBytes": -247968,
"heapUsedBytes": 112687404,
"domNodes": -306,
"jsHeapTotalBytes": -983040,
"scriptDurationMs": 34.521,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258066,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2048.394999999914,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.3830000000000005,
"layouts": 7,
"layoutDurationMs": 2.0490000000000004,
"taskDurationMs": 554.6790000000001,
"heapDeltaBytes": -30163556,
"heapUsedBytes": 89165172,
"domNodes": -296,
"jsHeapTotalBytes": -1470464,
"scriptDurationMs": 38.23100000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 721.7400000000112,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.819999999999999,
"layouts": 9,
"layoutDurationMs": 2.862,
"taskDurationMs": 509.61199999999997,
"heapDeltaBytes": 831068,
"heapUsedBytes": 102389976,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 153.878,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66744186046511,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 576.7309999999952,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.5329999999999995,
"layouts": 10,
"layoutDurationMs": 3.4720000000000004,
"taskDurationMs": 401.568,
"heapDeltaBytes": -676688,
"heapUsedBytes": 90892236,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 149.763,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714266,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2025.6979999999771,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.443999999999999,
"layouts": 9,
"layoutDurationMs": 3.406,
"taskDurationMs": 523.269,
"heapDeltaBytes": 2783564,
"heapUsedBytes": 94255060,
"domNodes": -218,
"jsHeapTotalBytes": 2686976,
"scriptDurationMs": 13.569999999999999,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2073.6950000000434,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.6319999999999997,
"layouts": 10,
"layoutDurationMs": 2.738,
"taskDurationMs": 613.413,
"heapDeltaBytes": -19261868,
"heapUsedBytes": 82036800,
"domNodes": -218,
"jsHeapTotalBytes": 1191936,
"scriptDurationMs": 9.23,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258066,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1993.516999999997,
"styleRecalcs": 86,
"styleRecalcDurationMs": 17.727,
"layouts": 10,
"layoutDurationMs": 3.562,
"taskDurationMs": 1067.82,
"heapDeltaBytes": -836752,
"heapUsedBytes": 90462676,
"domNodes": -210,
"jsHeapTotalBytes": 2162688,
"scriptDurationMs": 130.632,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 2003.4060000000409,
"styleRecalcs": 86,
"styleRecalcDurationMs": 15.460999999999999,
"layouts": 8,
"layoutDurationMs": 2.417,
"taskDurationMs": 1156.212,
"heapDeltaBytes": -1023332,
"heapUsedBytes": 89997232,
"domNodes": -210,
"jsHeapTotalBytes": 2424832,
"scriptDurationMs": 121.36999999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66583333333333,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1466.8550000000096,
"styleRecalcs": 18,
"styleRecalcDurationMs": 26.156999999999993,
"layouts": 5,
"layoutDurationMs": 16.813999999999997,
"taskDurationMs": 1063.8759999999997,
"heapDeltaBytes": 35594952,
"heapUsedBytes": 134790400,
"domNodes": 16030,
"jsHeapTotalBytes": 16654336,
"scriptDurationMs": 30.899000000000004,
"eventListeners": 3244,
"totalBlockingTimeMs": 164,
"frameDurationMs": 19.775999999999996,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8509.844999999985,
"styleRecalcs": 250,
"styleRecalcDurationMs": 30.849999999999998,
"layouts": 7,
"layoutDurationMs": 2.055,
"taskDurationMs": 5825.549,
"heapDeltaBytes": 4494276,
"heapUsedBytes": 114943856,
"domNodes": -296,
"jsHeapTotalBytes": -528384,
"scriptDurationMs": 2922.3529999999996,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.764497041420118,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8546.554000000015,
"styleRecalcs": 249,
"styleRecalcDurationMs": 30.938,
"layouts": 6,
"layoutDurationMs": 2.018,
"taskDurationMs": 5721.774,
"heapDeltaBytes": 2344456,
"heapUsedBytes": 112208004,
"domNodes": -276,
"jsHeapTotalBytes": -528384,
"scriptDurationMs": 2850.7129999999997,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.82992125984252,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16437.78800000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15504.956000000002,
"heapDeltaBytes": 2493140,
"heapUsedBytes": 303585464,
"domNodes": -3344,
"jsHeapTotalBytes": 8114176,
"scriptDurationMs": 297.682,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.20618556701031,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-idle",
"durationMs": 16662.214999999946,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15818.962,
"heapDeltaBytes": -35843956,
"heapUsedBytes": 288095556,
"domNodes": -3344,
"jsHeapTotalBytes": 4968448,
"scriptDurationMs": 257.919,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.165625000000002,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-large-graph-pan",
"durationMs": 28125.01000000003,
"styleRecalcs": 181,
"styleRecalcDurationMs": 21.65600000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27771.947,
"heapDeltaBytes": -29527568,
"heapUsedBytes": 275597276,
"domNodes": -3344,
"jsHeapTotalBytes": 14405632,
"scriptDurationMs": 906.0160000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 7,
"frameDurationMs": 51.90442804428044,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 19654.08500000001,
"styleRecalcs": 155,
"styleRecalcDurationMs": 17.461000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19207.017,
"heapDeltaBytes": -13468876,
"heapUsedBytes": 296986080,
"domNodes": -3344,
"jsHeapTotalBytes": 12570624,
"scriptDurationMs": 813.533,
"eventListeners": -651,
"totalBlockingTimeMs": 25,
"frameDurationMs": 36.314575645756456,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5950.656999999978,
"styleRecalcs": 20,
"styleRecalcDurationMs": 64.31699999999998,
"layouts": 20,
"layoutDurationMs": 23.80299999999999,
"taskDurationMs": 5794.25,
"heapDeltaBytes": -39423900,
"heapUsedBytes": 285369644,
"domNodes": -3344,
"jsHeapTotalBytes": 6803456,
"scriptDurationMs": 98.123,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.42528089887641,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 8665.506999999934,
"styleRecalcs": 20,
"styleRecalcDurationMs": 66.89299999999999,
"layouts": 20,
"layoutDurationMs": 26.491,
"taskDurationMs": 8562.555,
"heapDeltaBytes": -49513920,
"heapUsedBytes": 270002396,
"domNodes": -3344,
"jsHeapTotalBytes": 5492736,
"scriptDurationMs": 123.75699999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 50.77836257309941,
"p95FrameDurationMs": 100.09999999999854
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7987.398999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7460.426,
"heapDeltaBytes": -27665424,
"heapUsedBytes": 262349708,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 118.75599999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.622837370242216,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11663.33999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11397.676000000001,
"heapDeltaBytes": -11304992,
"heapUsedBytes": 269555392,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 158.408,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.62380952380953,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "workflow-execution",
"durationMs": 471.1819999999989,
"styleRecalcs": 22,
"styleRecalcDurationMs": 14.029,
"layouts": 12,
"layoutDurationMs": 4.986000000000001,
"taskDurationMs": 130.52400000000003,
"heapDeltaBytes": 7238012,
"heapUsedBytes": 97388968,
"domNodes": 126,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.966,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668965517241368,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 485.58300000001964,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.504999999999999,
"layouts": 10,
"layoutDurationMs": 3.324,
"taskDurationMs": 117.711,
"heapDeltaBytes": 6905916,
"heapUsedBytes": 97565608,
"domNodes": 95,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.539999999999997,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379284,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 727.9539999999542,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.718,
"layouts": 76,
"layoutDurationMs": 19.147000000000002,
"taskDurationMs": 662.3110000000001,
"heapDeltaBytes": 14339892,
"heapUsedBytes": 83864192,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 333.099,
"eventListeners": 296,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668181818181832,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 569.3519999999808,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.823,
"layouts": 76,
"layoutDurationMs": 18.037000000000003,
"taskDurationMs": 525.7010000000001,
"heapDeltaBytes": -13172836,
"heapUsedBytes": 81001288,
"domNodes": 4,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 252.39499999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 625.5789999999024,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.83,
"layouts": 76,
"layoutDurationMs": 15.127,
"taskDurationMs": 587.193,
"heapDeltaBytes": 1279236,
"heapUsedBytes": 119809112,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 240.391,
"eventListeners": 296,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663157894736838,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 634.9319999999352,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.535,
"layouts": 76,
"layoutDurationMs": 15.758000000000001,
"taskDurationMs": 600.038,
"heapDeltaBytes": 1198376,
"heapUsedBytes": 118919680,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 242.35899999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.105263157894736,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 63.7% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2981 passed, 0 failed · 4 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 57fef49341e3d41a1ca05a885c415d13395cd4a8
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (128)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.58 #22232 +/- ##
=============================================
- Coverage 84.49% 84.49% -0.01%
=============================================
Files 3101 3101
Lines 162980 162992 +12
Branches 39472 39459 -13
=============================================
+ Hits 137710 137716 +6
- Misses 24878 24884 +6
Partials 392 392
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 12 files with indirect coverage changes 🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Backport LGTM — same two commits (test + fix for releasing the coach hold on consent clear/identity change) cleanly applied to this release line.
…her tab (Comfy-Org#22238) ## Summary A new user's first message waits behind the intro tour (Comfy-Org#21285). If the tour is finished in another tab, the card here went away without telling the panel, so the held message waited until the panel was closed. Now it sends. ## Change `OnboardingCoach` emits `finished` when the tour completes outside this card (another tab, or any other write to the onboarding flag). Skip and Done still emit once; an emptied step list does not count as completion. This matters more once Comfy-Org#21857 stores tour completion in a synced setting, because the flag can then flip from outside the card while a message is held. ## Tests (written first) - `AgentPanelRoot.test.ts`: sends once when another tab finishes the tour during the hold (failed before the fix). - `OnboardingCoach.test.ts`: reports the tour finished when another tab completes it (failed before the fix); reports finished once on Skip and on Done; reports a later completion in another tab after a replay. - AgentPanelRoot + OnboardingCoach suites: 598/598. Typecheck clean. ## Review findings from the core/1.58 backport (Comfy-Org#22223), and why the rest are not here - Consent cleared or account switched during the hold: already handled on main (consent-identity recheck from Comfy-Org#21532); ported to the release lines in Comfy-Org#22225, Comfy-Org#22232, Comfy-Org#22233, Comfy-Org#22234. - Stall reported only once per coach: not reachable for the held send. The coach mounts when consent is accepted, and the hold only applies to a send made before consent, so a stall always happens during the hold and releases it. - Release and close in the same flush: clearing the held flag at release breaks draft restore on a plain close (existing test), so it is left as is and tracked in https://linear.app/comfyorg/issue/BE-24366. - Notice copy omits the automatic stall release: kept, the user cannot trigger it (https://linear.app/comfyorg/issue/BE-23265). Tracking: https://linear.app/comfyorg/issue/BE-21344
…22241) ## Summary The backport bot skips a release branch once its own backport PR merged (Comfy-Org#21994). A backport someone made by hand, from a branch the bot did not create, was not seen, so the bot retried that branch. This counts a merged PR to the target as done when: - its title starts with `[backport <target>]` or `[<target>]`, and - it is not a revert and not the bot's backport of another PR (`backport-<M>-to-*`), and - it says it carries the source PR: the title ends with `(#N)`, the head branch has `N` next to `backport` (`backport-N...`, `.../N-backport...`), or a body line starts with `Backport of #N` / `Backport of https://github.com/Comfy-Org/ComfyUI_frontend/pull/N`, and - it is not from a fork. A body or title that only mentions the PR ("Not included: #N", "follow-up to the backport of #N", a PR in another repo) does not count, and neither does a ticket number in a branch name (`be-22010-...` is not FE PR 22010). A false match would skip a needed backport and drop `needs-backport`, so the rule leans toward missing a hand-made backport (old behaviour: retry) over a false skip. Candidates come from listing up to 300 merged PRs on the target (core/1.58 has 64 today), not the search API, so a PR named only in its branch is found and there is no index lag. The target name is compared case-insensitively. The run log shows it as `core/1.58 (merged PR Comfy-Org#21580, made by hand)`. `force_rerun` still retries everything. Fixes FRONT-3651 ## Testing - `scripts/cicd/pr-backport-filter.test.ts`: the match cases were red before the workflow change, and the three mention-only cases were red against the first, broader rule. 28/28 green now; each tightening was red against the commit before it. - Ran the query against real merged PRs. Correct matches: Comfy-Org#21579 to Comfy-Org#21580 and Comfy-Org#21694 to Comfy-Org#21799 (both made by hand, core/1.58), Comfy-Org#21708 to Comfy-Org#21798, Comfy-Org#21285 to Comfy-Org#22223, Comfy-Org#21686 to Comfy-Org#21782. Correctly no match: Comfy-Org#21841 on core/1.57 (Comfy-Org#22051 says "Not included: Comfy-Org#21841") and Comfy-Org#21532 on core/1.58 (Comfy-Org#22232 says it is not on that line), and Comfy-Org#22010 on core/1.58 (Comfy-Org#21580's branch `be-22010-...` is a ticket key). - The existing skip of bot backports was re-checked live: https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/40871266552 skipped all four targets of Comfy-Org#21829. ## Known limit A hand-made backport whose title has no target prefix, or that does not name the source PR, is still not detected. The bot then retries it as before, and the cherry-pick either conflicts or finds the commit already present.
Follow-up to the backport of #21285 on this line (#22223). That PR merged before these two commits were pushed to its branch.
What
The coach-tour hold on the first send now also ends when consent is cleared or the consent identity changes, and the release checks that the identity still matches the one that accepted. Main already has both (they came with #21532, which is not on this line).
Why
Found in review of the backport:
Tests
Two new
AgentPanelRoot.test.tscases, written first and failing before the fix:vitest run AgentPanelRoot.test.ts OnboardingCoach.test.tson this line: 514/514. Typecheck, oxlint, eslint and oxfmt clean (pre-commit).The same two commits are already on the cloud/1.58 backport: #22225
Tracking: https://linear.app/comfyorg/issue/BE-21344