Repository navigation
[cloud/1.59] fix: invalidate ESLint cache when i18n catalogs change - #22160
Conversation
ESLint --cache keys on file content and resolved config, not on the locale catalogs read by @intlify/vue-i18n/no-missing-keys. A lint run on cloud/1.59 cached a missing-key error for Load3DViewerButton.vue; the CI lint cache is saved with if: always(), so after #22130 restored the key every later run replayed the stale error. Hash the catalog contents into the per-tree settings so cached results are dropped whenever a catalog changes.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-28T19:29:05.673Z",
"gitSha": "0cecd47ac4ba182c19c77b3e84439abaeedad9ce",
"branch": "glary/fix-cloud-1.59-lint",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2024.9000000000024,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.1009999999999995,
"layouts": 11,
"layoutDurationMs": 2.9419999999999993,
"taskDurationMs": 352.329,
"heapDeltaBytes": 24336912,
"heapUsedBytes": 84595556,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 7.96,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-idle",
"durationMs": 2006.1910000000012,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.2740000000000005,
"layouts": 11,
"layoutDurationMs": 2.1069999999999998,
"taskDurationMs": 312.44899999999996,
"heapDeltaBytes": 2075072,
"heapUsedBytes": 63187184,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 7.176,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1712.1320000000253,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.822999999999999,
"layouts": 9,
"layoutDurationMs": 1.9990000000000003,
"taskDurationMs": 555.783,
"heapDeltaBytes": -2889928,
"heapUsedBytes": 66736484,
"domNodes": 0,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 104.345,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1678.6969999999997,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.984,
"layouts": 9,
"layoutDurationMs": 1.893,
"taskDurationMs": 521.856,
"heapDeltaBytes": 17387220,
"heapUsedBytes": 77686280,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 99.34400000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.4489999999976,
"styleRecalcs": 18,
"styleRecalcDurationMs": 3.9640000000000004,
"layouts": 10,
"layoutDurationMs": 2.312,
"taskDurationMs": 225.213,
"heapDeltaBytes": 19670500,
"heapUsedBytes": 80992836,
"domNodes": 56,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 7.947000000000001,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.6869999999699,
"styleRecalcs": 19,
"styleRecalcDurationMs": 3.7520000000000002,
"layouts": 11,
"layoutDurationMs": 2.1479999999999997,
"taskDurationMs": 236.651,
"heapDeltaBytes": -3766496,
"heapUsedBytes": 75281044,
"domNodes": 56,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 8.432,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384617,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 444.84700000001,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.156,
"layouts": 10,
"layoutDurationMs": 2.3770000000000002,
"taskDurationMs": 303.596,
"heapDeltaBytes": 3633060,
"heapUsedBytes": 64950848,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 104.96,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670370370370367,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 547.2929999999678,
"styleRecalcs": 14,
"styleRecalcDurationMs": 4.162000000000001,
"layouts": 10,
"layoutDurationMs": 3.3049999999999997,
"taskDurationMs": 348.426,
"heapDeltaBytes": 6206348,
"heapUsedBytes": 75444016,
"domNodes": 0,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 115.947,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666675,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 909.3479999999943,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 535.242,
"heapDeltaBytes": -13484760,
"heapUsedBytes": 75536436,
"domNodes": -191,
"jsHeapTotalBytes": 20193280,
"scriptDurationMs": 38.186,
"eventListeners": -106,
"totalBlockingTimeMs": 268,
"frameDurationMs": 25.461111111111123,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 894.8700000000258,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 495.429,
"heapDeltaBytes": 124988,
"heapUsedBytes": 75563336,
"domNodes": -191,
"jsHeapTotalBytes": 13639680,
"scriptDurationMs": 32.45799999999999,
"eventListeners": -106,
"totalBlockingTimeMs": 244,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 719.3379999999934,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 310.20099999999974,
"heapDeltaBytes": -22237860,
"heapUsedBytes": 66432940,
"domNodes": -191,
"jsHeapTotalBytes": 3014656,
"scriptDurationMs": 84.123,
"eventListeners": -106,
"totalBlockingTimeMs": 86,
"frameDurationMs": 20.477142857142876,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 717.3309999999447,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 310.4149999999999,
"heapDeltaBytes": -26757060,
"heapUsedBytes": 66450496,
"domNodes": -191,
"jsHeapTotalBytes": 2752512,
"scriptDurationMs": 89.19399999999999,
"eventListeners": -106,
"totalBlockingTimeMs": 83,
"frameDurationMs": 20.474285714285724,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6909.839000000005,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.947,
"layouts": 3,
"layoutDurationMs": 0.8319999999999999,
"taskDurationMs": 5933.349,
"heapDeltaBytes": 56269496,
"heapUsedBytes": 129340092,
"domNodes": -257,
"jsHeapTotalBytes": 63827968,
"scriptDurationMs": 4455.363,
"eventListeners": -68,
"totalBlockingTimeMs": 43,
"frameDurationMs": 21.215950920245394,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 5976.288000000011,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.7929999999999995,
"layouts": 3,
"layoutDurationMs": 0.7360000000000001,
"taskDurationMs": 5068.500999999999,
"heapDeltaBytes": 50626328,
"heapUsedBytes": 123928740,
"domNodes": -287,
"jsHeapTotalBytes": 57798656,
"scriptDurationMs": 3825.3749999999995,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.185714285714283,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6407.779000000005,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.0220000000000002,
"layouts": 4,
"layoutDurationMs": 0.9060000000000001,
"taskDurationMs": 5383.780000000001,
"heapDeltaBytes": 56262832,
"heapUsedBytes": 128155520,
"domNodes": -257,
"jsHeapTotalBytes": 61730816,
"scriptDurationMs": 4073.4440000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 25,
"frameDurationMs": 18.93402366863905,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6200.228999999979,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.9960000000000003,
"layouts": 4,
"layoutDurationMs": 0.8739999999999998,
"taskDurationMs": 5106.243,
"heapDeltaBytes": -8540040,
"heapUsedBytes": 80184788,
"domNodes": -257,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 3908.845,
"eventListeners": -68,
"totalBlockingTimeMs": 6,
"frameDurationMs": 19.07630769230769,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "large-combo-open",
"durationMs": 134.4310000000064,
"styleRecalcs": 21,
"styleRecalcDurationMs": 11.893,
"layouts": 12,
"layoutDurationMs": 3.087,
"taskDurationMs": 98.718,
"heapDeltaBytes": 14400532,
"heapUsedBytes": 90933984,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.908,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.04285714285717,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "large-combo-open",
"durationMs": 147.65299999999115,
"styleRecalcs": 22,
"styleRecalcDurationMs": 10.802000000000001,
"layouts": 13,
"layoutDurationMs": 2.9549999999999996,
"taskDurationMs": 98.31,
"heapDeltaBytes": 14470236,
"heapUsedBytes": 91091688,
"domNodes": 936,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 5.242999999999999,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.04285714285717,
"p95FrameDurationMs": 33.29999999999973
},
{
"name": "large-graph-idle",
"durationMs": 2009.192000000013,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.9920000000000002,
"layouts": 9,
"layoutDurationMs": 1.772,
"taskDurationMs": 343.09799999999996,
"heapDeltaBytes": -8512700,
"heapUsedBytes": 65441252,
"domNodes": -257,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 17.36,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-idle",
"durationMs": 2009.144000000049,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.2680000000000002,
"layouts": 9,
"layoutDurationMs": 1.957,
"taskDurationMs": 365.95,
"heapDeltaBytes": -27848244,
"heapUsedBytes": 63728772,
"domNodes": -257,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 24.548000000000002,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-pan",
"durationMs": 2166.739000000007,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.009,
"layouts": 10,
"layoutDurationMs": 2.1009999999999995,
"taskDurationMs": 1079.553,
"heapDeltaBytes": -7038676,
"heapUsedBytes": 85656660,
"domNodes": -257,
"jsHeapTotalBytes": 6418432,
"scriptDurationMs": 555.8140000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384617,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-pan",
"durationMs": 2167.318000000023,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.684,
"layouts": 9,
"layoutDurationMs": 1.967,
"taskDurationMs": 1068.986,
"heapDeltaBytes": -29985880,
"heapUsedBytes": 61762312,
"domNodes": -257,
"jsHeapTotalBytes": 4882432,
"scriptDurationMs": 541.1320000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665891472868218,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3139.201000000014,
"styleRecalcs": 74,
"styleRecalcDurationMs": 10.024999999999999,
"layouts": 68,
"layoutDurationMs": 10.703000000000001,
"taskDurationMs": 1093.616,
"heapDeltaBytes": -11568384,
"heapUsedBytes": 63776404,
"domNodes": -233,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 483.025,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665608465608464,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3238.650000000007,
"styleRecalcs": 74,
"styleRecalcDurationMs": 10.184999999999999,
"layouts": 67,
"layoutDurationMs": 10.631000000000002,
"taskDurationMs": 1135.939,
"heapDeltaBytes": -3925804,
"heapUsedBytes": 73060544,
"domNodes": -233,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 499.412,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666153846153847,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2241.1409999999987,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.974,
"layouts": 7,
"layoutDurationMs": 1.582,
"taskDurationMs": 1267.452,
"heapDeltaBytes": 11642844,
"heapUsedBytes": 89902836,
"domNodes": 0,
"jsHeapTotalBytes": 5922816,
"scriptDurationMs": 655.1020000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665671641791043,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2150.8079999999836,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.351,
"layouts": 6,
"layoutDurationMs": 1.281,
"taskDurationMs": 1158.1619999999998,
"heapDeltaBytes": 10281348,
"heapUsedBytes": 88539176,
"domNodes": 0,
"jsHeapTotalBytes": 6184960,
"scriptDurationMs": 591.7779999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66589147286822,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2789.7749999999915,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.817,
"layouts": 8,
"layoutDurationMs": 1.815,
"taskDurationMs": 477.226,
"heapDeltaBytes": 4927348,
"heapUsedBytes": 81284248,
"domNodes": -257,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 223.498,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666467065868265,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2760.556999999949,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.2199999999999998,
"layouts": 8,
"layoutDurationMs": 1.873,
"taskDurationMs": 476.59100000000007,
"heapDeltaBytes": -31722644,
"heapUsedBytes": 60069560,
"domNodes": -257,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 220.16100000000003,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666060606060608,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "minimap-idle",
"durationMs": 2021.00200000001,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.2520000000000007,
"layouts": 9,
"layoutDurationMs": 1.9760000000000004,
"taskDurationMs": 366.397,
"heapDeltaBytes": -3852316,
"heapUsedBytes": 84167468,
"domNodes": -257,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 23.483,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-idle",
"durationMs": 2004.4549999999504,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.6749999999999994,
"layouts": 9,
"layoutDurationMs": 2.341,
"taskDurationMs": 376.01599999999996,
"heapDeltaBytes": -9345352,
"heapUsedBytes": 67354276,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 23.399000000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2680.0029999999992,
"styleRecalcs": 28,
"styleRecalcDurationMs": 10.741999999999999,
"layouts": 8,
"layoutDurationMs": 1.718,
"taskDurationMs": 410.84,
"heapDeltaBytes": -8840772,
"heapUsedBytes": 67513548,
"domNodes": -255,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 139.32699999999997,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666459627329193,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2679.8559999999725,
"styleRecalcs": 27,
"styleRecalcDurationMs": 9.688,
"layouts": 8,
"layoutDurationMs": 1.451,
"taskDurationMs": 369.32099999999997,
"heapDeltaBytes": -5720920,
"heapUsedBytes": 68727288,
"domNodes": -254,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 117.43500000000002,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665838509316767,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 2890.008999999992,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.5500000000000003,
"layouts": 7,
"layoutDurationMs": 1.432,
"taskDurationMs": 576.7659999999998,
"heapDeltaBytes": 9250352,
"heapUsedBytes": 85252428,
"domNodes": -257,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 219.54999999999998,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665317919075147,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "minimap-topology-cadence",
"durationMs": 2939.885000000004,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.9269999999999998,
"layouts": 8,
"layoutDurationMs": 1.589,
"taskDurationMs": 607.422,
"heapDeltaBytes": 12168164,
"heapUsedBytes": 86668012,
"domNodes": -257,
"jsHeapTotalBytes": 5894144,
"scriptDurationMs": 236.78399999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66590909090909,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 431.4999999999998,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.6530000000000005,
"layouts": 10,
"layoutDurationMs": 2.376,
"taskDurationMs": 286.29499999999996,
"heapDeltaBytes": 1346412,
"heapUsedBytes": 73599956,
"domNodes": 0,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 95.18799999999999,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66538461538462,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 413.5230000000547,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.324000000000001,
"layouts": 10,
"layoutDurationMs": 2.3999999999999995,
"taskDurationMs": 289.706,
"heapDeltaBytes": 1370820,
"heapUsedBytes": 72554956,
"domNodes": 0,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 94.6,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664000000000005,
"p95FrameDurationMs": 16.799999999999955
},
{
"name": "subgraph-idle",
"durationMs": 2008.9120000000094,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.286,
"layouts": 10,
"layoutDurationMs": 2.028,
"taskDurationMs": 279.04100000000005,
"heapDeltaBytes": 3412572,
"heapUsedBytes": 66293292,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 4.632000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2010.1960000000076,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.8010000000000006,
"layouts": 11,
"layoutDurationMs": 2.4099999999999997,
"taskDurationMs": 301.99399999999997,
"heapDeltaBytes": 24338448,
"heapUsedBytes": 85897000,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 6.135,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1678.5550000000171,
"styleRecalcs": 75,
"styleRecalcDurationMs": 10.979,
"layouts": 10,
"layoutDurationMs": 2.004,
"taskDurationMs": 472.736,
"heapDeltaBytes": 13207924,
"heapUsedBytes": 74872744,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 69.759,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66534653465347,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1678.4109999999828,
"styleRecalcs": 76,
"styleRecalcDurationMs": 12.611999999999998,
"layouts": 9,
"layoutDurationMs": 2.102,
"taskDurationMs": 538.73,
"heapDeltaBytes": 16760212,
"heapUsedBytes": 78465356,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 80.91999999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 900.812999999971,
"styleRecalcs": 19,
"styleRecalcDurationMs": 14.900999999999998,
"layouts": 5,
"layoutDurationMs": 9.896,
"taskDurationMs": 692.712,
"heapDeltaBytes": 9712108,
"heapUsedBytes": 86454788,
"domNodes": 16030,
"jsHeapTotalBytes": 17440768,
"scriptDurationMs": 21.199999999999996,
"eventListeners": 3246,
"totalBlockingTimeMs": 83,
"frameDurationMs": 19.56521739130436,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8406.543,
"styleRecalcs": 250,
"styleRecalcDurationMs": 34.367,
"layouts": 9,
"layoutDurationMs": 2.655,
"taskDurationMs": 3868.3610000000003,
"heapDeltaBytes": -11618376,
"heapUsedBytes": 61400476,
"domNodes": -257,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 1855.963,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665940594059403,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8258.839000000024,
"styleRecalcs": 250,
"styleRecalcDurationMs": 32.402,
"layouts": 9,
"layoutDurationMs": 1.7810000000000001,
"taskDurationMs": 3720.918,
"heapDeltaBytes": -2793964,
"heapUsedBytes": 71952320,
"domNodes": -257,
"jsHeapTotalBytes": 4022272,
"scriptDurationMs": 1772.765,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665927419354837,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "vue-large-graph-idle",
"durationMs": 15179.08700000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14382.048,
"heapDeltaBytes": 10624524,
"heapUsedBytes": 288128136,
"domNodes": -3343,
"jsHeapTotalBytes": 38264832,
"scriptDurationMs": 182.26500000000001,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.042367066895366,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-large-graph-idle",
"durationMs": 14449.56400000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13366.306999999999,
"heapDeltaBytes": -16480528,
"heapUsedBytes": 281042620,
"domNodes": -3343,
"jsHeapTotalBytes": 35381248,
"scriptDurationMs": 177.94199999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.162876254180606,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 18010.319999999978,
"styleRecalcs": 142,
"styleRecalcDurationMs": 14.581999999999983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17636.002,
"heapDeltaBytes": -16476992,
"heapUsedBytes": 265566188,
"domNodes": -3343,
"jsHeapTotalBytes": 15720448,
"scriptDurationMs": 611.911,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.518029739776956,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 17722.822000000007,
"styleRecalcs": 141,
"styleRecalcDurationMs": 15.004000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17335.129,
"heapDeltaBytes": -21202392,
"heapUsedBytes": 271170776,
"domNodes": -3343,
"jsHeapTotalBytes": 10739712,
"scriptDurationMs": 588.9159999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.83796296296296,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5170.067000000017,
"styleRecalcs": 20,
"styleRecalcDurationMs": 37.971999999999994,
"layouts": 20,
"layoutDurationMs": 17.762,
"taskDurationMs": 5014.861999999999,
"heapDeltaBytes": -31142328,
"heapUsedBytes": 266024868,
"domNodes": -307,
"jsHeapTotalBytes": 30134272,
"scriptDurationMs": 70.06199999999998,
"eventListeners": -7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.39117647058823,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-node-resize-workload",
"durationMs": 5110.747000000003,
"styleRecalcs": 20,
"styleRecalcDurationMs": 40.93699999999999,
"layouts": 20,
"layoutDurationMs": 17.89700000000001,
"taskDurationMs": 5015.472,
"heapDeltaBytes": -34840148,
"heapUsedBytes": 262527544,
"domNodes": -3343,
"jsHeapTotalBytes": 35643392,
"scriptDurationMs": 87.803,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.822289156626507,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7519.861999999989,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7049.050999999999,
"heapDeltaBytes": -4404276,
"heapUsedBytes": 280283080,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 87.76899999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.280067567567574,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6982.583000000033,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6459.641999999999,
"heapDeltaBytes": 18634184,
"heapUsedBytes": 285445136,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 72.42199999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.6724025974026,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "workflow-execution",
"durationMs": 87.92599999998174,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.5360000000000005,
"layouts": 6,
"layoutDurationMs": 1.6620000000000001,
"taskDurationMs": 60.993000000000016,
"heapDeltaBytes": 4728004,
"heapUsedBytes": 64830816,
"domNodes": 101,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 6.534,
"eventListeners": 3,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.68333333333332,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 73.61500000001797,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.763000000000001,
"layouts": 4,
"layoutDurationMs": 1.1269999999999998,
"taskDurationMs": 46.575,
"heapDeltaBytes": 4580324,
"heapUsedBytes": 65743772,
"domNodes": 98,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 4.111999999999999,
"eventListeners": 3,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.680000000000017,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 190.20399999999427,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.563,
"layouts": 77,
"layoutDurationMs": 9.643,
"taskDurationMs": 153.892,
"heapDeltaBytes": 9278044,
"heapUsedBytes": 45999572,
"domNodes": 36,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 60.455,
"eventListeners": 293,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.658333333333342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 204.13300000006984,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.545,
"layouts": 76,
"layoutDurationMs": 10.07,
"taskDurationMs": 155.30100000000002,
"heapDeltaBytes": 9398468,
"heapUsedBytes": 46293108,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 66.43499999999999,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 222.1439999999575,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.218,
"layouts": 76,
"layoutDurationMs": 8.971,
"taskDurationMs": 181.814,
"heapDeltaBytes": -2183704,
"heapUsedBytes": 87509480,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 56.505,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.661538461538456,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 265.71000000001277,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.3719999999999999,
"layouts": 76,
"layoutDurationMs": 11.221,
"taskDurationMs": 228.523,
"heapDeltaBytes": -1823600,
"heapUsedBytes": 88035896,
"domNodes": 4,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 73.719,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662499999999994,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E CoverageLine coverage: 60.4% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3115 passed, 0 failed · 6 flaky📊 Browser Reports
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since dad2af2a336a6ebb1b144d8d2fcaa0c3a4d69f14
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (217)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.59 #22160 +/- ##
=============================================
Coverage ? 87.49%
=============================================
Files ? 2945
Lines ? 155929
Branches ? 42151
=============================================
Hits ? 136425
Misses ? 18829
Partials ? 675
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
benceruleanlu
left a comment
There was a problem hiding this comment.
This review was performed agentically. Ben will be notified to review manually soon.
Recommendation: merge. I found nothing that needs fixing.
Review details
The PR adds a SHA-256 of each tree's English catalogs to that tree's ESLint settings under comfy/i18nCatalogHash. ESLint's cache key covers each file's resolved config, so any catalog edit now drops the cached results for that tree. Before this, a missing-key error that was cached once kept coming back after the key was restored.
The hash covers the right files. coreCatalogs lists main.json and scripts/i18n/eslint-generated-messages.js, which are the two localeDir entries in settings. It also lists commands.json, nodeDefs.json and settings.json, which that .js file imports. That's every file the rule reads, and billing-web's single main.json matches billingWebI18nSettings. With --concurrency auto, each worker loads the config and computes the same hash, so cache keys stay stable from run to run.
Blocking
None.
Optional
eslint.config.ts:520-523: the hash sits in the per-file config, so any change to one of these catalogs invalidates the wholesrc/**ESLint cache. That covers every rule, not justno-missing-keys, including the slowbetter-tailwindcss/enforce-canonical-classescheck. Edits tosrc/locales/en/main.jsonare common, so PRs that touch it will run a cold ESLint pass in CI. Keeping it correct is worth that cost, but it should be a known trade-off. A note in the comment the PR deleted at the old line ~172 would help the next person who wonders why lint got slower on locale PRs.
Reviewed head: 1c31e0f
|
Thanks for the review. On the optional note about cold-cache cost: I agree it's a trade-off people should know about. This repo's AGENTS.md doesn't allow code comments and says rationale belongs in the commit message, PR description, or an ADR, so I didn't bring back the deleted comment in |
…sh entry (Comfy-Org#22576) ## Summary Locale collection rewrites `src/locales/en/commands.json` from the commands the running app has registered, so a command whose extension had not loaded is pruned. Nothing fails at that moment, because ESLint caches on file content and config rather than on catalog content — so the prune reaches a release branch and only surfaces later as an `@intlify/vue-i18n/no-missing-keys` error in an unrelated pull request. `Comfy.3DViewer.Open3DViewer` has been through that cycle three times: pruned by the 1.59.2 bump, restored by Comfy-Org#22130, pruned again by the 1.59.3 bump (`342a87f0d9`), and fixed at the source for the lazy 3D extension by Comfy-Org#22168. **The third prune is still live on `cloud/1.59` and is currently failing `lint-pr / lint` on six open carriers (Comfy-Org#22534–Comfy-Org#22539)** — which is how it was found. Comfy-Org#22168 fixed collection for that one extension; nothing fails when it happens to the next one. This adds the missing mechanical check. `scripts/check-command-locales.ts` reads command ids out of the source tree with the TypeScript AST — `commands: [...]` on a `ComfyExtension` and `const commands = [...]` as `useCoreCommands` declares them — and requires each one to keep a `commands.<normalized id>.label` string. It needs neither a browser nor a regeneration run, so it works on any branch. Two wiring points, for two different failure moments: - **`i18n-update-core.yaml`, right after `pnpm collect-i18n`** — fails the regeneration before the pruned catalog is translated and committed. This is the step that prunes, so failing here also avoids spending OpenAI tokens on a catalog that is about to be rejected. - **`repo-checks`** — catches an already-pruned branch on any pull request. `locale:check` compares the non-English catalogs against the English ones, so it cannot see a key missing from the English catalog itself. Non-obvious decisions: - A computed id (`id: \`Comfy.${suffix}\``) cannot be resolved statically. Those are counted and reported in the pass line rather than ignored silently or failed on. - The reverse direction is deliberately not checked. The catalog carries 122 entries against 113 statically declared ids, because some commands are registered only at runtime, so flagging catalog entries with no declaration would be false-positive-prone. - Comfy-Org#22168's one-key output assertion in `collect-i18n-general.ts` is left in place. This guard subsumes it, but removing it is a separate call for that file's author. ## Verification Red on the real broken states, green on the real repaired ones — not only on fixtures. | state | result | | --- | --- | | `main` at `ac70ad8a8c` | **pass** — 113 declared commands across 1661 files | | `origin/cloud/1.59` at `122b615f36` (live) | **fail**, exit 1 — `src/extensions/core/load3d/load3d.ts:60 command 'Comfy.3DViewer.Open3DViewer' has no commands.Comfy_3DViewer_Open3DViewer entry` | | same tree, with the 3-line entry restored | **pass** — 113 declared commands | | `342a87f0d9` (the 1.59.3 bump that pruned it) | **fail**, exit 1, same single finding | | `e05ecb7577` (Comfy-Org#22130's restore) | **pass** | So the guard would have failed the version-bump PR that reintroduced the defect, and fails the release branch that still carries it, naming the declaration site rather than a downstream call site. - Tests: `scripts/check-command-locales.test.ts`, 13 cases, hermetic (temp-directory trees, no network, no browser). Covers the AST cases — extension array, `const commands`, `as const` / `satisfies` unwrapping, a `menuCommands` reference array that must *not* count as a declaration, a computed id — and the catalog cases: missing entry, restored entry, absent/blank/`tooltip`-only label, duplicate declaration reported once, and test/`__tests__` files skipped so a fixture command needs no locale entry. `vitest run scripts/check-command-locales.test.ts` → 13 passed. - `pnpm typecheck:scripts` → exit 0. `pnpm knip` → exit 0. `pnpm format:check` → all 6469 files correct. `pnpm deps:audit`, `pnpm knip` and `pnpm fallow:audit` all pass via the `pre-push` hook, not bypassed. Both edited YAML files re-parsed and their step order asserted. - No manual repair is pushed to `cloud/1.59` or to Comfy-Org#22534–Comfy-Org#22539 here; that is the release owner's call and is tracked separately. ## Related - Comfy-Org#22168 (FE-3637) fixed collection for the lazy 3D extension; this adds the check that fails when the same thing happens to another extension. - Comfy-Org#22130 restored the entry the second time. Comfy-Org#22160 is complementary and independent: it makes the ESLint cache honest on `cloud/1.59` so the prune is *visible* sooner, while this makes the regeneration refuse to produce it.
|
Whoops, so sorry. I think I was pretty late on this one. Unfortunately, we're on 1.60 QA right now, tragically. |
|
@benceruleanlu No problem. Since The fix is one commit ( |
|
Thanks for the approval. This review had no comments, so I haven't changed anything. The open question from my earlier comment still stands: whether to close this PR or move the ESLint-cache fix ( |
…23073) **Why:** `cloud/1.59` lint has been red since #22160 (ESLint cache now invalidates when i18n catalogs change). The uncached run surfaces `commands.Comfy_3DViewer_Open3DViewer` used by `Load3DViewerButton.vue` but missing from `src/locales/en/commands.json` on this branch. Every PR into `cloud/1.59` now fails `lint-pr / lint` (e.g. #23066, #23068). **Root cause:** `Load3DViewerButton.vue` reached `cloud/1.59` without its command label; `core/1.59` and `main` have it. **How:** add the entry exactly as it is on `core/1.59` (label "Open 3D Viewer (Beta) for Selected Node"). AS IS / TO BE: no UI change on a translated locale; the en tooltip/aria-label now resolve to the label instead of the raw key.
PR Created by the Glary-Bot Agent
Summary
Fixes the post-merge
CI: Lint Formatfailure oncloud/1.59(run 40735633141, dad2af2). The failure came from a poisoned ESLint cache. The flaky-test and infra explanations don't fit, and dad2af2 itself is not the cause.Failure:
Verify ESLintreports'commands.Comfy_3DViewer_Open3DViewer' does not exist in localization message resourcesinLoad3DViewerButton.vue. The key does exist at HEAD; #22130 restored it.Root cause:
eslint --cachekeys each cache entry on the file's content plus its resolved config. It never looks at the locale catalogs that@intlify/vue-i18n/no-missing-keysreads.Save lint cachesruns withif: always(), so that cache was saved anyway.Load3DViewerButton.vuehasn't changed, so ESLint replayed the stale error. That includes the run for fix: add missing 3D viewer command locale key #22130 itself, and all six pushes from c8a9443 onward fail with exactly this annotation.Fix: hash the contents of each tree's catalogs into that tree's ESLint
settings(comfy/i18nCatalogHash). ESLint's per-file config hash then changes whenever a catalog changes, which drops the stale entries. This works both in CI, even when the cache is restored through a fallback key, and in local runs.Verification
--cache --cache-strategy contentonLoad3DViewerButton.vue:commands.json: exit 1.commands.jsonand lint again on the warm cache. With the original config it still exits 1, which matches the CI failure. With this change it exits 0.eslint --concurrency auto,oxfmt --checkandoxlintall pass.Main has the same latent issue, so this may also be worth forward-porting.
Known trade-off: cold lint on catalog edits
The catalog hash lives in the per-file ESLint config, so editing any hashed catalog (
src/locales/en/{main,commands,nodeDefs,settings}.json,scripts/i18n/eslint-generated-messages.js, or billing-web'smain.json) invalidates the ESLint cache for that whole tree, for every rule. That includes slow ones likebetter-tailwindcss/enforce-canonical-classes. PRs that touchsrc/locales/en/main.jsonwill run a coldsrc/**ESLint pass. We accept that cost because otherwise cachedno-missing-keysresults go stale.