Repository navigation
[backport cloud/1.59] FRONT-2049 fix(billing): open the platform Plans page wherever the pricing table opened - #23068
Conversation
…icing table opened (#23046) **Why:** A customer whose initial Creator signup payment was declined opened Subscribe to Run and got the old pricing table, which held every plan as "available again shortly". It never would be: the invoice was waiting on her. The platform Plans page is the designed surface for plan state (DES-974), and it now explains this case (Comfy-Org/platform#1595). Design asked to stop sending anyone to the old table and to backport the change (Alex, #proj-billing). **Root cause:** Every Cloud entry point to choosing a plan still opens the old in-app pricing table through `showPricingTable` in `useSubscriptionDialog.ts`. Only the Billing tab's Manage link goes to the platform Plans page. The old table has no way to show customer-action states like an unpaid signup invoice. **How:** `showPricingTable` now does what Manage does. It opens `/profile/billing/plans` on platform for the active workspace in a new tab, using the same `platformLink` and `platform_handoff` (`target: 'plans'`) event. One change covers every caller: - top bar Subscribe / Upgrade - Subscribe to Run and the Run refusal - profile menu Plans & pricing - refused Add credits - free-runs quota, Subscribe button and model upload upsell - member invite upsell - comfy.org pricing links - the signup redirect Two behaviors are unchanged on purpose: - The read-only member dialog still opens first for members who can't manage the plan. - If the browser blocks the new tab (for example a call that isn't from a click), the old table opens as before, so the click never does nothing. Not covered here, for design to decide: - comfy.org pricing links carry a chosen plan. This opens the Plans page without it. - Removing the old table code once this has shipped for a release. - Refs FRONT-2049 - Related: Comfy-Org/platform#1595, #23045 - `useSubscriptionDialog.test.ts`: - opens the Plans page path instead of the table - reports `platform_handoff` with the link's `correlation_id` - keeps the member dialog first - falls back to the table when the tab is blocked - opens nothing off Cloud - The existing table tests now run as the blocked-tab fallback. - All 25 test files that reach `showPricingTable` pass (611 tests). - Pre-commit lint and typecheck pass. AS IS: Subscribe to Run (owner, no plan) on `main` opens the in-app "Choose a Plan" dialog.  TO BE: the same click opens a new tab at `/profile/billing/plans?correlation_id=…&workspace=ws-personal` and no dialog opens in the app. The tab is served by a local Playwright stub that prints its own URL (top); the platform page was not loaded.  (cherry picked from commit c1a8647)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 7 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-06T15:19:40.319Z",
"gitSha": "39153ce61af6cd640292765eaf70647e982fa9ab",
"branch": "backport-23046-to-cloud-1.59",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2008.8450000000648,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.907,
"layouts": 10,
"layoutDurationMs": 2.8089999999999997,
"taskDurationMs": 512.932,
"heapDeltaBytes": 1475748,
"heapUsedBytes": 63094080,
"domNodes": 0,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 10.536999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-idle",
"durationMs": 2022.8200000000243,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.9630000000000005,
"layouts": 10,
"layoutDurationMs": 3.0759999999999996,
"taskDurationMs": 547.048,
"heapDeltaBytes": 3324240,
"heapUsedBytes": 64837616,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 11.957999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1720.9569999999985,
"styleRecalcs": 72,
"styleRecalcDurationMs": 11.610000000000003,
"layouts": 10,
"layoutDurationMs": 2.4029999999999996,
"taskDurationMs": 756.058,
"heapDeltaBytes": 22045776,
"heapUsedBytes": 83636708,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 128.061,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665048543689323,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1757.156000000009,
"styleRecalcs": 73,
"styleRecalcDurationMs": 13.296000000000003,
"layouts": 9,
"layoutDurationMs": 2.3640000000000003,
"taskDurationMs": 847.122,
"heapDeltaBytes": -7197504,
"heapUsedBytes": 55453544,
"domNodes": -161,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 137.813,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664761904761907,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.0180000000382,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.475999999999999,
"layouts": 11,
"layoutDurationMs": 3.3369999999999997,
"taskDurationMs": 335.17900000000003,
"heapDeltaBytes": 604900,
"heapUsedBytes": 78544276,
"domNodes": 56,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 14.493,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262135,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.3709999999955,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.282000000000001,
"layouts": 10,
"layoutDurationMs": 2.837,
"taskDurationMs": 435.575,
"heapDeltaBytes": -227016,
"heapUsedBytes": 62862688,
"domNodes": 56,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 15.08,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 560.9100000000353,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.822,
"layouts": 9,
"layoutDurationMs": 2.5100000000000002,
"taskDurationMs": 420.52,
"heapDeltaBytes": 6843420,
"heapUsedBytes": 77471752,
"domNodes": 0,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 137.586,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66176470588235,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 599.7509999999693,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.2580000000000005,
"layouts": 10,
"layoutDurationMs": 2.651,
"taskDurationMs": 448.875,
"heapDeltaBytes": 6013164,
"heapUsedBytes": 67536044,
"domNodes": 0,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 149.087,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663888888888877,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1177.110999999968,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 889.5860000000001,
"heapDeltaBytes": -12849636,
"heapUsedBytes": 74835948,
"domNodes": -191,
"jsHeapTotalBytes": 23076864,
"scriptDurationMs": 57.40999999999999,
"eventListeners": -107,
"totalBlockingTimeMs": 510,
"frameDurationMs": 32.87222222222221,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1045.362999999952,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 751.42,
"heapDeltaBytes": 14564740,
"heapUsedBytes": 84920000,
"domNodes": 0,
"jsHeapTotalBytes": 12222464,
"scriptDurationMs": 52.922999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 422,
"frameDurationMs": 30.879411764705885,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 814.8290000000316,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.99499999999983,
"heapDeltaBytes": -27436792,
"heapUsedBytes": 67499484,
"domNodes": -191,
"jsHeapTotalBytes": 4587520,
"scriptDurationMs": 121.73700000000001,
"eventListeners": -107,
"totalBlockingTimeMs": 160,
"frameDurationMs": 22.686111111111106,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 802.5870000000168,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 427.08400000000023,
"heapDeltaBytes": -4513928,
"heapUsedBytes": 70478624,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 118.43500000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 160,
"frameDurationMs": 23.03823529411765,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8774.87000000002,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.5869999999999999,
"layouts": 2,
"layoutDurationMs": 0.438,
"taskDurationMs": 7881.57,
"heapDeltaBytes": 80046432,
"heapUsedBytes": 154310332,
"domNodes": -257,
"jsHeapTotalBytes": 71430144,
"scriptDurationMs": 6167.804999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 109,
"frameDurationMs": 24.975213675213674,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7886.899999999969,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.6509999999999997,
"layouts": 2,
"layoutDurationMs": 0.5519999999999999,
"taskDurationMs": 7025.701,
"heapDeltaBytes": 60019608,
"heapUsedBytes": 134920020,
"domNodes": -257,
"jsHeapTotalBytes": 54390784,
"scriptDurationMs": 5402.249000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 58,
"frameDurationMs": 23.88787878787879,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7398.052000000007,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.7810000000000005,
"layouts": 3,
"layoutDurationMs": 0.7130000000000001,
"taskDurationMs": 6613.965,
"heapDeltaBytes": -21291592,
"heapUsedBytes": 68188812,
"domNodes": -257,
"jsHeapTotalBytes": 7204864,
"scriptDurationMs": 5071.434,
"eventListeners": -69,
"totalBlockingTimeMs": 54,
"frameDurationMs": 23.641533546325878,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7657.285000000002,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.9769999999999995,
"layouts": 3,
"layoutDurationMs": 0.8869999999999998,
"taskDurationMs": 6809.821,
"heapDeltaBytes": 61383024,
"heapUsedBytes": 134369472,
"domNodes": -257,
"jsHeapTotalBytes": 54915072,
"scriptDurationMs": 5185.4439999999995,
"eventListeners": -69,
"totalBlockingTimeMs": 55,
"frameDurationMs": 23.980564263322883,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "large-combo-open",
"durationMs": 231.5749999999639,
"styleRecalcs": 24,
"styleRecalcDurationMs": 12.424000000000001,
"layouts": 13,
"layoutDurationMs": 3.3009999999999997,
"taskDurationMs": 184.92600000000002,
"heapDeltaBytes": -15391748,
"heapUsedBytes": 69049012,
"domNodes": -2315,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.187999999999999,
"eventListeners": -574,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.65999999999999,
"p95FrameDurationMs": 66.70000000000027
},
{
"name": "large-combo-open",
"durationMs": 233.84599999997135,
"styleRecalcs": 25,
"styleRecalcDurationMs": 14.338999999999999,
"layouts": 11,
"layoutDurationMs": 3.4250000000000003,
"taskDurationMs": 184.99300000000002,
"heapDeltaBytes": 14469944,
"heapUsedBytes": 90289956,
"domNodes": 936,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 8.039,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.218181818181826,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2024.7339999999667,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.341,
"layouts": 8,
"layoutDurationMs": 2.032,
"taskDurationMs": 586.3510000000001,
"heapDeltaBytes": -14783652,
"heapUsedBytes": 60605092,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 31.558000000000003,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2056.523000000084,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.437,
"layouts": 8,
"layoutDurationMs": 2.449,
"taskDurationMs": 665.9290000000001,
"heapDeltaBytes": -17051844,
"heapUsedBytes": 73304264,
"domNodes": -257,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 35.619,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-pan",
"durationMs": 2667.9510000000164,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.37,
"layouts": 8,
"layoutDurationMs": 1.9269999999999998,
"taskDurationMs": 1460.741,
"heapDeltaBytes": -14151192,
"heapUsedBytes": 62238696,
"domNodes": -257,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 690.628,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666249999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2703.785000000039,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.487,
"layouts": 7,
"layoutDurationMs": 1.7820000000000003,
"taskDurationMs": 1500.553,
"heapDeltaBytes": -123192,
"heapUsedBytes": 76084776,
"domNodes": -257,
"jsHeapTotalBytes": 3760128,
"scriptDurationMs": 705.314,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666257668711655,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-zoom",
"durationMs": 3250.315999999998,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.084,
"layouts": 64,
"layoutDurationMs": 10.611,
"taskDurationMs": 1414.238,
"heapDeltaBytes": -9167728,
"heapUsedBytes": 73741756,
"domNodes": -233,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 661.493,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66615384615385,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3792.159999999967,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.298,
"layouts": 64,
"layoutDurationMs": 10.485000000000001,
"taskDurationMs": 1631.761,
"heapDeltaBytes": 1147540,
"heapUsedBytes": 84078036,
"domNodes": -233,
"jsHeapTotalBytes": 389120,
"scriptDurationMs": 690.375,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.73982300884956,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2542.6559999999654,
"styleRecalcs": 43,
"styleRecalcDurationMs": 4.7170000000000005,
"layouts": 3,
"layoutDurationMs": 0.7130000000000001,
"taskDurationMs": 1541.3169999999998,
"heapDeltaBytes": 5617580,
"heapUsedBytes": 68245432,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 845.293,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.776158940397348,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3009.3189999998913,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.694999999999999,
"layouts": 6,
"layoutDurationMs": 1.509,
"taskDurationMs": 1787.4430000000002,
"heapDeltaBytes": 18435072,
"heapUsedBytes": 92461904,
"domNodes": 0,
"jsHeapTotalBytes": 2777088,
"scriptDurationMs": 871.985,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75888888888889,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2943.697000000043,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.9290000000000003,
"layouts": 7,
"layoutDurationMs": 1.6200000000000003,
"taskDurationMs": 646.2310000000001,
"heapDeltaBytes": -7527108,
"heapUsedBytes": 69193064,
"domNodes": -257,
"jsHeapTotalBytes": 913408,
"scriptDurationMs": 298.20599999999996,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666101694915252,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3051.1240000000726,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.1780000000000004,
"layouts": 7,
"layoutDurationMs": 1.8370000000000002,
"taskDurationMs": 711.4830000000001,
"heapDeltaBytes": 2397532,
"heapUsedBytes": 79319620,
"domNodes": -257,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 309.09000000000003,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666120218579238,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2051.472999999987,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.105,
"layouts": 7,
"layoutDurationMs": 1.94,
"taskDurationMs": 636.352,
"heapDeltaBytes": -15754612,
"heapUsedBytes": 60524404,
"domNodes": -257,
"jsHeapTotalBytes": 913408,
"scriptDurationMs": 33.98,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2033.235999999988,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.1279999999999997,
"layouts": 7,
"layoutDurationMs": 2.2050000000000005,
"taskDurationMs": 543.6429999999999,
"heapDeltaBytes": 7307844,
"heapUsedBytes": 85867896,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 36.757000000000005,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2706.478999999945,
"styleRecalcs": 29,
"styleRecalcDurationMs": 12.393,
"layouts": 10,
"layoutDurationMs": 2.13,
"taskDurationMs": 504.62900000000013,
"heapDeltaBytes": -7387400,
"heapUsedBytes": 69914268,
"domNodes": -254,
"jsHeapTotalBytes": 5894144,
"scriptDurationMs": 156.715,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66625766871166,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2886.0449999999673,
"styleRecalcs": 25,
"styleRecalcDurationMs": 11.248,
"layouts": 5,
"layoutDurationMs": 1.6849999999999998,
"taskDurationMs": 567.1769999999999,
"heapDeltaBytes": -30246868,
"heapUsedBytes": 62728344,
"domNodes": -242,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 171.547,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666473988439307,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-topology-cadence",
"durationMs": 3113.5550000000194,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.1149999999999998,
"layouts": 4,
"layoutDurationMs": 1.0019999999999998,
"taskDurationMs": 757.1560000000001,
"heapDeltaBytes": 8186248,
"heapUsedBytes": 69314276,
"domNodes": -257,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 301.21400000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258066,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-topology-cadence",
"durationMs": 3113.835999999992,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.9949999999999994,
"layouts": 7,
"layoutDurationMs": 1.7899999999999996,
"taskDurationMs": 799.6450000000001,
"heapDeltaBytes": 15346068,
"heapUsedBytes": 88519104,
"domNodes": -257,
"jsHeapTotalBytes": -135168,
"scriptDurationMs": 304.99399999999997,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258066,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 549.0009999999756,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.137999999999999,
"layouts": 10,
"layoutDurationMs": 2.451,
"taskDurationMs": 376.973,
"heapDeltaBytes": -1412680,
"heapUsedBytes": 61018088,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 122.04400000000001,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 609.9120000000084,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.987000000000001,
"layouts": 10,
"layoutDurationMs": 2.8520000000000003,
"taskDurationMs": 445.72999999999996,
"heapDeltaBytes": 1207908,
"heapUsedBytes": 74241344,
"domNodes": 0,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 137.509,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567573,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2039.0290000000277,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.325999999999999,
"layouts": 10,
"layoutDurationMs": 2.9960000000000004,
"taskDurationMs": 531.9780000000001,
"heapDeltaBytes": -9798452,
"heapUsedBytes": 52981384,
"domNodes": -183,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 10.872000000000002,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2030.9119999999439,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.7539999999999996,
"layouts": 9,
"layoutDurationMs": 2.4179999999999997,
"taskDurationMs": 570.088,
"heapDeltaBytes": -7968248,
"heapUsedBytes": 54384844,
"domNodes": -183,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 11.944,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.5180000000164,
"styleRecalcs": 75,
"styleRecalcDurationMs": 14.259999999999998,
"layouts": 10,
"layoutDurationMs": 3.1550000000000002,
"taskDurationMs": 757.6729999999999,
"heapDeltaBytes": -7713760,
"heapUsedBytes": 64231616,
"domNodes": -175,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 98.45599999999999,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1710.3409999999712,
"styleRecalcs": 76,
"styleRecalcDurationMs": 13.613,
"layouts": 10,
"layoutDurationMs": 2.3169999999999997,
"taskDurationMs": 776.913,
"heapDeltaBytes": -9028272,
"heapUsedBytes": 55133316,
"domNodes": -183,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 97.81700000000001,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665048543689323,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.7949999999928,
"styleRecalcs": 21,
"styleRecalcDurationMs": 18.818999999999996,
"layouts": 5,
"layoutDurationMs": 10.893,
"taskDurationMs": 1002.1030000000002,
"heapDeltaBytes": 38016240,
"heapUsedBytes": 114143780,
"domNodes": 16030,
"jsHeapTotalBytes": 15601664,
"scriptDurationMs": 32.175,
"eventListeners": 3246,
"totalBlockingTimeMs": 139,
"frameDurationMs": 19.144594594594594,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9277.533999999945,
"styleRecalcs": 250,
"styleRecalcDurationMs": 30.792000000000005,
"layouts": 8,
"layoutDurationMs": 2.077,
"taskDurationMs": 5014.203,
"heapDeltaBytes": -28854144,
"heapUsedBytes": 62140600,
"domNodes": -257,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 2256.021,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66606822262118,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 10902.975999999966,
"styleRecalcs": 248,
"styleRecalcDurationMs": 31.626,
"layouts": 6,
"layoutDurationMs": 1.607,
"taskDurationMs": 5378.652,
"heapDeltaBytes": 3158004,
"heapUsedBytes": 76735788,
"domNodes": -257,
"jsHeapTotalBytes": 1630208,
"scriptDurationMs": 2403.3250000000003,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66595419847328,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 20537.194999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19971.263,
"heapDeltaBytes": -13875536,
"heapUsedBytes": 279218300,
"domNodes": -3343,
"jsHeapTotalBytes": 13094912,
"scriptDurationMs": 283.797,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.129294755877034,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-large-graph-idle",
"durationMs": 20541.192000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20132.676,
"heapDeltaBytes": -15380304,
"heapUsedBytes": 277149608,
"domNodes": -3343,
"jsHeapTotalBytes": 10211328,
"scriptDurationMs": 285.717,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.70477064220184,
"p95FrameDurationMs": 66.80000000000109
},
{
"name": "vue-large-graph-pan",
"durationMs": 24664.033000000018,
"styleRecalcs": 181,
"styleRecalcDurationMs": 23.971999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24410.643,
"heapDeltaBytes": 3375180,
"heapUsedBytes": 268180372,
"domNodes": -3343,
"jsHeapTotalBytes": -9175040,
"scriptDurationMs": 776.8629999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 14,
"frameDurationMs": 47.161950286806885,
"p95FrameDurationMs": 100
},
{
"name": "vue-large-graph-pan",
"durationMs": 24923.666000000027,
"styleRecalcs": 181,
"styleRecalcDurationMs": 25.066000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24675.495,
"heapDeltaBytes": -37710852,
"heapUsedBytes": 265047696,
"domNodes": -3343,
"jsHeapTotalBytes": 13094912,
"scriptDurationMs": 819.136,
"eventListeners": -651,
"totalBlockingTimeMs": 39,
"frameDurationMs": 47.617374517374515,
"p95FrameDurationMs": 99.89999999999964
},
{
"name": "vue-node-resize-workload",
"durationMs": 7346.843999999919,
"styleRecalcs": 20,
"styleRecalcDurationMs": 62.35600000000002,
"layouts": 20,
"layoutDurationMs": 30.590000000000007,
"taskDurationMs": 7257.941999999999,
"heapDeltaBytes": -6206256,
"heapUsedBytes": 271515040,
"domNodes": -3343,
"jsHeapTotalBytes": 18075648,
"scriptDurationMs": 135.93,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 44.712804878048786,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-node-resize-workload",
"durationMs": 7412.74599999997,
"styleRecalcs": 20,
"styleRecalcDurationMs": 49.38099999999998,
"layouts": 20,
"layoutDurationMs": 24.645,
"taskDurationMs": 7361.377000000001,
"heapDeltaBytes": -23194464,
"heapUsedBytes": 274609796,
"domNodes": -3343,
"jsHeapTotalBytes": 21221376,
"scriptDurationMs": 117.011,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.370760233918126,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10216.867999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9893.91,
"heapDeltaBytes": 9148548,
"heapUsedBytes": 264577372,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 135.091,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.882310469314085,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10246.074000000022,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9952.906,
"heapDeltaBytes": 18724996,
"heapUsedBytes": 273229076,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 139.409,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.28576642335767,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "workflow-execution",
"durationMs": 482.42100000004484,
"styleRecalcs": 14,
"styleRecalcDurationMs": 9.184000000000001,
"layouts": 12,
"layoutDurationMs": 3.7449999999999997,
"taskDurationMs": 111.861,
"heapDeltaBytes": 6901376,
"heapUsedBytes": 74430876,
"domNodes": 102,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.882999999999997,
"eventListeners": 3,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379302,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 99.87300000000232,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.736999999999999,
"layouts": 8,
"layoutDurationMs": 2.7790000000000004,
"taskDurationMs": 69.12,
"heapDeltaBytes": 4578528,
"heapUsedBytes": 65593300,
"domNodes": 124,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.226999999999999,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.67142857142861,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 376.9790000000057,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.726,
"layouts": 76,
"layoutDurationMs": 13.399,
"taskDurationMs": 337.52,
"heapDeltaBytes": -4756712,
"heapUsedBytes": 38103068,
"domNodes": 4,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 154.696,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66818181818181,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 376.85799999997016,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.6719999999999999,
"layouts": 76,
"layoutDurationMs": 13.412,
"taskDurationMs": 336.916,
"heapDeltaBytes": -4710572,
"heapUsedBytes": 38146476,
"domNodes": 4,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 152.15200000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665217391304356,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 384.5610000000761,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.0959999999999996,
"layouts": 76,
"layoutDurationMs": 12.291,
"taskDurationMs": 358.61199999999997,
"heapDeltaBytes": -100464,
"heapUsedBytes": 98649912,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 127.497,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665217391304356,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 408.4530000000086,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.238,
"layouts": 76,
"layoutDurationMs": 13.294,
"taskDurationMs": 387.976,
"heapDeltaBytes": -758300,
"heapUsedBytes": 93758988,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 140.35399999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.332000000000008,
"p95FrameDurationMs": 16.699999999999818
}
]
}🎭 Playwright: ✅ 3146 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 4d1cbb3a3ee9a7ab8d4b2c15bc0cc3afc02e288c
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (285)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
This comment has been minimized.
This comment has been minimized.
…23073) **Why:** `cloud/1.59` lint has been red since #22160 (ESLint cache now invalidates when i18n catalogs change). The uncached run surfaces `commands.Comfy_3DViewer_Open3DViewer` used by `Load3DViewerButton.vue` but missing from `src/locales/en/commands.json` on this branch. Every PR into `cloud/1.59` now fails `lint-pr / lint` (e.g. #23066, #23068). **Root cause:** `Load3DViewerButton.vue` reached `cloud/1.59` without its command label; `core/1.59` and `main` have it. **How:** add the entry exactly as it is on `core/1.59` (label "Open 3D Viewer (Beta) for Selected Node"). AS IS / TO BE: no UI change on a translated locale; the en tooltip/aria-label now resolve to the label instead of the raw key.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.59 #23068 +/- ##
=============================================
Coverage ? 86.73%
=============================================
Files ? 2707
Lines ? 140316
Branches ? 40541
=============================================
Hits ? 121703
Misses ? 17795
Partials ? 818
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Manual backport of #23046 to
cloud/1.59. The backport bot hit a conflict.Why / Root cause / How: see #23046.
showPricingTableopens the platform/profile/billing/planspage for the active workspace in a new tab via the existingplatformLink+platform_handoff(target: 'plans'), the same as the Billing tab's Manage link (BillingPlanRow.vueon 1.59). The read-only member dialog still opens first; a blocked tab falls back to the in-app table; a failed-checkout resume keeps the table.Conflict resolution
useSubscriptionDialog.ts: kept 1.59'suseWorkspaceUIimport andlegacyPricingDialogPropsname; inserted the Plans hand-off at the same point as main (after the member-dialog check, before the table).resumingCheckout: trueadded to the failed-checkout resume.openPlatformPlans.ts:useTelemetryimported from@/platform/telemetry(1.59 has no@comfyorg/telemetry). Otherwise identical.useSubscriptionDialog.test.ts: kept 1.59's three team-upgrade resume tests alongside the new failed-checkout resume test; the member test usesuseWorkspaceUI().permissions...canManageSubscription = false(1.59 has nouseBillingUI/receiveServerFactthere).useSubscriptionDialog.loading.test.ts,composables/types.ts: applied cleanly.cloudCreditsLockedRefusal.spec.ts: both blocks exist on cloud/1.59 and were updated as on main (refused run and ended-plan Subscribe to Run open the Plans page); 1.59'sLEGACY_PERSONAL_BILLING_STATUSand/customers/balancemocks kept. Its snapshotcredits-locked-subscribe-dialog-cloud-linux.pngdeleted, as on main, since the screenshot test is gone.agentPaywallSubscribe.spec.ts: took the Plans-page assertion; dropped main'sCREATOR_YEARLY_PLAN/ plans route, which 1.59 never had.billingFacadeConsumers.spec.ts: kept 1.59's two legacy-rail tests; renamed and updated the subscribe-to-run test as on main.subscription.spec.ts: took main's Plans-page version of the stale-state test (return-to-tab refresh instead of dialog close + pending checkout).keepPricingTableInApp/expectPlatformPlansOpenedupdates as on main. No unrelated features pulled.Verification
pnpm test:unit src/platform/billing/subscription/composables/useSubscriptionDialog.test.ts src/platform/billing/subscription/composables/useSubscriptionDialog.loading.test.ts: 72 passed.showPricingTable/useSubscriptionDialog: 639 passed.pnpm typecheck:browser: pass.AS IS / TO BE
Same as #23046.