Repository navigation
[backport cloud/1.59] FRONT-2049 fix(billing): offer to pay an unpaid signup invoice from the pricing table - #23066
Conversation
…he pricing table (#23045) **Why:** A customer's initial Creator signup payment was declined while a separate credit top-up succeeded. The pricing table held every plan with "A billing change is in progress. This plan will be available again shortly." It never would be: the plan invoice was waiting on the customer. Support had to settle the invoice by hand. Seven workspaces showed the same overlap in the trailing 7 days (FRONT-2049 sizing). **Root cause:** `GET /billing/plans` exempts only `awaiting_payment_method` from the running-operation lock, so an initial signup in `awaiting_invoice_payment` is served as `billing_operation_in_progress` on every plan. Capabilities treat the same state as recoverable. The client had no served fact for "the customer owes this invoice", and `/billing/ops/{id}` returns `checkout_state=null` once a payment was attempted, so the existing checkout banner could not cover it either. The backend fix is cloud#18290 (BE-25501): it adds `subscription_payment_recovery: { billing_op_id, reason: "payment_required" }` to plans and keeps plan actions held. **How:** Render that fact as received. - Pricing table footer, per the [Figma notice](https://www.figma.com/design/C1fxz3akrW7Pl22zM2b301/Unified-Settings---Billing?node-id=3223-13071): "Your {Plan} payment didn't go through. Finish paying to start your plan." with **Contact support** and **Finish payment**. It takes the place of the past-due notice and the fine print. {Plan} comes from the bound op's served display field `plan.tier`; without it the title reads "Your plan payment didn't go through." - **Finish payment** reserves a tab during the click, reads the bound op's served `action_url` from the existing authorized op-status endpoint, and re-reads plans, status and capabilities when the customer returns. With no `action_url`, or a failed read, it closes the tab, shows an error toast and re-reads billing. - Held plans drop the "available again shortly" line while the recovery fact is served; buttons stay disabled as served. - The SDK plans reader drops an unrecognized `subscription_payment_recovery` instead of rejecting the whole catalog. - No client-side combining of `authentication_state`, `decline_reason` or phase (ADR-0042). The types come from the regular ingest-types sync (#23044, merged). - Fixes FRONT-2049 - Depends on Comfy-Org/cloud#18290 (BE-25501) - `UnifiedPricingTable.test.ts`: the notice names the served plan (or falls back), Finish payment and Contact support render when the fact is served; the in-progress line is dropped; unchanged without the fact; takes precedence over the past-due notice; hidden off Cloud. - `useSubscriptionPaymentRecovery.test.ts`: names the bound op's plan, leaves it unnamed on a failed read, opens the served invoice URL for the bound op, re-reads billing on return, handles a missing URL, a failed read, a blocked popup, and no served fact. - `plans.test.ts`: recognized recovery kept; unknown reason dropped without rejecting the catalog; absent stays absent. - Pre-commit lint, server-facts lint and typecheck pass. AS IS:  TO BE:  (cherry picked from commit 779fba7)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 7 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-06T15:21:49.172Z",
"gitSha": "f5ecaaf8ec1c42096d63c64a12aca050386bc5ee",
"branch": "backport-23045-to-cloud-1.59",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2020.799000000011,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.9970000000000003,
"layouts": 9,
"layoutDurationMs": 2.996,
"taskDurationMs": 567.9060000000001,
"heapDeltaBytes": 3725200,
"heapUsedBytes": 65128024,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 10.319999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2022.6149999999734,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.7459999999999996,
"layouts": 9,
"layoutDurationMs": 3.3840000000000003,
"taskDurationMs": 709.595,
"heapDeltaBytes": 3261172,
"heapUsedBytes": 64836720,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 16.155,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1858.192000000031,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.502,
"layouts": 10,
"layoutDurationMs": 3.2760000000000002,
"taskDurationMs": 963.939,
"heapDeltaBytes": 21711320,
"heapUsedBytes": 83439440,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 171.51500000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665765765765762,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1924.1499999999405,
"styleRecalcs": 81,
"styleRecalcDurationMs": 15.937,
"layouts": 10,
"layoutDurationMs": 3.1950000000000003,
"taskDurationMs": 1016.2920000000001,
"heapDeltaBytes": -14548976,
"heapUsedBytes": 57697648,
"domNodes": -161,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 173.66500000000002,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665217391304353,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1736.1590000000433,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.9079999999999995,
"layouts": 10,
"layoutDurationMs": 3.359,
"taskDurationMs": 576.662,
"heapDeltaBytes": 3553272,
"heapUsedBytes": 79469340,
"domNodes": 56,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 18.605999999999998,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.4950000000708,
"styleRecalcs": 20,
"styleRecalcDurationMs": 6.65,
"layouts": 11,
"layoutDurationMs": 4.288,
"taskDurationMs": 496.35299999999995,
"heapDeltaBytes": 2425932,
"heapUsedBytes": 78737328,
"domNodes": 56,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 14.757999999999997,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 727.9959999999619,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.269,
"layouts": 9,
"layoutDurationMs": 2.7860000000000005,
"taskDurationMs": 532.98,
"heapDeltaBytes": 6511532,
"heapUsedBytes": 68052912,
"domNodes": 0,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 179.376,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909086,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 741.7050000000245,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.8069999999999995,
"layouts": 8,
"layoutDurationMs": 2.699,
"taskDurationMs": 526.528,
"heapDeltaBytes": 7486420,
"heapUsedBytes": 69980276,
"domNodes": 0,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 175.669,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909096,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1240.285,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 977.901,
"heapDeltaBytes": -12980420,
"heapUsedBytes": 75760268,
"domNodes": -191,
"jsHeapTotalBytes": 20455424,
"scriptDurationMs": 73.51000000000002,
"eventListeners": -107,
"totalBlockingTimeMs": 548,
"frameDurationMs": 33.33513513513514,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1444.80800000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1190.565,
"heapDeltaBytes": -12961256,
"heapUsedBytes": 75799508,
"domNodes": -191,
"jsHeapTotalBytes": 20979712,
"scriptDurationMs": 73.91600000000001,
"eventListeners": -107,
"totalBlockingTimeMs": 703,
"frameDurationMs": 36.74871794871795,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 957.1219999999698,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 618.6179999999997,
"heapDeltaBytes": -27577924,
"heapUsedBytes": 66890172,
"domNodes": -191,
"jsHeapTotalBytes": 3538944,
"scriptDurationMs": 182.48400000000004,
"eventListeners": -107,
"totalBlockingTimeMs": 238,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 873.3760000000075,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 535.9259999999999,
"heapDeltaBytes": -4995496,
"heapUsedBytes": 69790648,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 175.82400000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 226,
"frameDurationMs": 25.488235294117658,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10932.944000000021,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10094.178000000002,
"heapDeltaBytes": 73909368,
"heapUsedBytes": 148907716,
"domNodes": -257,
"jsHeapTotalBytes": 69070848,
"scriptDurationMs": 8006.456999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 1070,
"frameDurationMs": 31.32636103151863,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11618.529000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10771.041000000001,
"heapDeltaBytes": 68941908,
"heapUsedBytes": 144216100,
"domNodes": -257,
"jsHeapTotalBytes": 77721600,
"scriptDurationMs": 8628.055,
"eventListeners": -69,
"totalBlockingTimeMs": 1316,
"frameDurationMs": 31.825479452054793,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11987.088,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11216.658000000001,
"heapDeltaBytes": -8417116,
"heapUsedBytes": 81086144,
"domNodes": -257,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 9148.428,
"eventListeners": -69,
"totalBlockingTimeMs": 1697,
"frameDurationMs": 32.56195652173913,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11965.242999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11168.324,
"heapDeltaBytes": -7795440,
"heapUsedBytes": 66800968,
"domNodes": -257,
"jsHeapTotalBytes": 19525632,
"scriptDurationMs": 9056.353000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 1584,
"frameDurationMs": 32.51684782608696,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "large-combo-open",
"durationMs": 313.8020000000097,
"styleRecalcs": 25,
"styleRecalcDurationMs": 20.862,
"layouts": 12,
"layoutDurationMs": 4.398000000000001,
"taskDurationMs": 272.805,
"heapDeltaBytes": -13831512,
"heapUsedBytes": 69560884,
"domNodes": 721,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 11.235999999999999,
"eventListeners": 69,
"totalBlockingTimeMs": 39,
"frameDurationMs": 27.281818181818213,
"p95FrameDurationMs": 133.20000000000027
},
{
"name": "large-combo-open",
"durationMs": 286.30999999995765,
"styleRecalcs": 23,
"styleRecalcDurationMs": 15.187000000000001,
"layouts": 8,
"layoutDurationMs": 2.7089999999999996,
"taskDurationMs": 250.45899999999997,
"heapDeltaBytes": -333852,
"heapUsedBytes": 68621224,
"domNodes": -2315,
"jsHeapTotalBytes": -524288,
"scriptDurationMs": 9.799000000000001,
"eventListeners": -574,
"totalBlockingTimeMs": 4,
"frameDurationMs": 21.792307692307705,
"p95FrameDurationMs": 83.40000000000055
},
{
"name": "large-graph-idle",
"durationMs": 2054.326000000003,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.5520000000000005,
"layouts": 7,
"layoutDurationMs": 2.301,
"taskDurationMs": 770.3069999999999,
"heapDeltaBytes": -32323792,
"heapUsedBytes": 59676260,
"domNodes": -257,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 38.623000000000005,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2052.385999999956,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.409,
"layouts": 6,
"layoutDurationMs": 2.204,
"taskDurationMs": 816.4899999999999,
"heapDeltaBytes": -7501676,
"heapUsedBytes": 84399624,
"domNodes": -257,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 41.385000000000005,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 3077.8029999999603,
"styleRecalcs": 67,
"styleRecalcDurationMs": 10.471000000000002,
"layouts": 6,
"layoutDurationMs": 1.7759999999999998,
"taskDurationMs": 2002.0640000000003,
"heapDeltaBytes": -2599776,
"heapUsedBytes": 77133972,
"domNodes": -257,
"jsHeapTotalBytes": 5070848,
"scriptDurationMs": 954.751,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666120218579234,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2580.3710000000137,
"styleRecalcs": 67,
"styleRecalcDurationMs": 9.654,
"layouts": 5,
"layoutDurationMs": 1.598,
"taskDurationMs": 1816.333,
"heapDeltaBytes": -3347816,
"heapUsedBytes": 73457108,
"domNodes": -257,
"jsHeapTotalBytes": 5332992,
"scriptDurationMs": 870.7479999999999,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6658064516129,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3935.8289999999556,
"styleRecalcs": 66,
"styleRecalcDurationMs": 9.781000000000002,
"layouts": 60,
"layoutDurationMs": 10.724,
"taskDurationMs": 1933.421,
"heapDeltaBytes": 3290204,
"heapUsedBytes": 66201352,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 858.13,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665677966101697,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3923.0440000000044,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.221,
"layouts": 64,
"layoutDurationMs": 10.998999999999999,
"taskDurationMs": 1923.219,
"heapDeltaBytes": 2661524,
"heapUsedBytes": 84333440,
"domNodes": -233,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 831.731,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66595744680851,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3452.245000000005,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.971000000000001,
"layouts": 4,
"layoutDurationMs": 1.6350000000000002,
"taskDurationMs": 2303.359,
"heapDeltaBytes": 24874256,
"heapUsedBytes": 104028160,
"domNodes": 0,
"jsHeapTotalBytes": 5922816,
"scriptDurationMs": 1133.7820000000002,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.90873786407767,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3152.9649999999947,
"styleRecalcs": 44,
"styleRecalcDurationMs": 6.438,
"layouts": 4,
"layoutDurationMs": 1.48,
"taskDurationMs": 2101.651,
"heapDeltaBytes": 20425100,
"heapUsedBytes": 93597972,
"domNodes": 0,
"jsHeapTotalBytes": 3563520,
"scriptDurationMs": 1025.4350000000002,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.844385026737967,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3267.803000000015,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.3169999999999997,
"layouts": 7,
"layoutDurationMs": 2.3240000000000003,
"taskDurationMs": 941.2959999999999,
"heapDeltaBytes": -19733076,
"heapUsedBytes": 73962848,
"domNodes": -257,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 417.07099999999997,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665306122448982,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3100.5010000000084,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.1009999999999995,
"layouts": 4,
"layoutDurationMs": 1.1849999999999998,
"taskDurationMs": 837.605,
"heapDeltaBytes": 8084416,
"heapUsedBytes": 80743720,
"domNodes": -257,
"jsHeapTotalBytes": 1699840,
"scriptDurationMs": 380.637,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.756216216216213,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2057.514000000026,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.836,
"layouts": 7,
"layoutDurationMs": 2.836,
"taskDurationMs": 875.1889999999999,
"heapDeltaBytes": -13540004,
"heapUsedBytes": 65472848,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 50.611000000000004,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2044.3239999999605,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.746,
"layouts": 7,
"layoutDurationMs": 2.5720000000000005,
"taskDurationMs": 765.024,
"heapDeltaBytes": -31387952,
"heapUsedBytes": 61045420,
"domNodes": -257,
"jsHeapTotalBytes": 1474560,
"scriptDurationMs": 42.693000000000005,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2892.1270000000163,
"styleRecalcs": 25,
"styleRecalcDurationMs": 12.696000000000002,
"layouts": 6,
"layoutDurationMs": 2.0479999999999996,
"taskDurationMs": 711.4670000000001,
"heapDeltaBytes": -28484700,
"heapUsedBytes": 65586392,
"domNodes": -255,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 227.14299999999997,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665895953757225,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 3059.8229999999376,
"styleRecalcs": 26,
"styleRecalcDurationMs": 14.076,
"layouts": 7,
"layoutDurationMs": 2.3110000000000004,
"taskDurationMs": 766.5470000000001,
"heapDeltaBytes": -15692428,
"heapUsedBytes": 60952112,
"domNodes": -256,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 238.373,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66576086956522,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-topology-cadence",
"durationMs": 3367.2699999999904,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.6109999999999995,
"layouts": 5,
"layoutDurationMs": 1.6119999999999997,
"taskDurationMs": 1071.959,
"heapDeltaBytes": 7921972,
"heapUsedBytes": 86454356,
"domNodes": -257,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 404.71000000000004,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.748258706467663,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-topology-cadence",
"durationMs": 3372.4030000000766,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.025,
"layouts": 6,
"layoutDurationMs": 1.9489999999999998,
"taskDurationMs": 1035.917,
"heapDeltaBytes": -22495368,
"heapUsedBytes": 71030960,
"domNodes": -257,
"jsHeapTotalBytes": 6455296,
"scriptDurationMs": 409.45,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.74925373134328,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 649.5270000000346,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.942,
"layouts": 9,
"layoutDurationMs": 2.931,
"taskDurationMs": 473.48999999999995,
"heapDeltaBytes": 2777288,
"heapUsedBytes": 73741664,
"domNodes": 0,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 151.113,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667500000000008,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 738.3949999999686,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.473,
"layouts": 8,
"layoutDurationMs": 3.0689999999999995,
"taskDurationMs": 531.299,
"heapDeltaBytes": 1887588,
"heapUsedBytes": 64124380,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 167.42399999999998,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909096,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2024.548999999979,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.306,
"layouts": 9,
"layoutDurationMs": 2.9090000000000007,
"taskDurationMs": 646.0310000000001,
"heapDeltaBytes": 1872804,
"heapUsedBytes": 64254388,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 12.361,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2041.0440000000563,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.8810000000000007,
"layouts": 8,
"layoutDurationMs": 2.744,
"taskDurationMs": 642.8399999999999,
"heapDeltaBytes": 13991144,
"heapUsedBytes": 75771656,
"domNodes": -183,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 10.862,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1757.4619999999754,
"styleRecalcs": 78,
"styleRecalcDurationMs": 14.769999999999998,
"layouts": 8,
"layoutDurationMs": 2.723,
"taskDurationMs": 942.196,
"heapDeltaBytes": 14145152,
"heapUsedBytes": 77020760,
"domNodes": -183,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 120.741,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1742.5100000000384,
"styleRecalcs": 79,
"styleRecalcDurationMs": 15.637000000000002,
"layouts": 9,
"layoutDurationMs": 2.7500000000000004,
"taskDurationMs": 905.563,
"heapDeltaBytes": -5425400,
"heapUsedBytes": 67370108,
"domNodes": 0,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 119.54200000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384617,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 1471.4050000000043,
"styleRecalcs": 19,
"styleRecalcDurationMs": 23.696999999999996,
"layouts": 5,
"layoutDurationMs": 14.736000000000002,
"taskDurationMs": 1215.8749999999998,
"heapDeltaBytes": 11548844,
"heapUsedBytes": 113569256,
"domNodes": 16030,
"jsHeapTotalBytes": 10358784,
"scriptDurationMs": 33.865,
"eventListeners": 3246,
"totalBlockingTimeMs": 162,
"frameDurationMs": 19.517105263157898,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 10178.275999999983,
"styleRecalcs": 250,
"styleRecalcDurationMs": 34.037,
"layouts": 7,
"layoutDurationMs": 2.3370000000000006,
"taskDurationMs": 6344.942,
"heapDeltaBytes": 3242824,
"heapUsedBytes": 75252772,
"domNodes": -257,
"jsHeapTotalBytes": 57344,
"scriptDurationMs": 2807.162,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69343185550082,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 10520.853000000101,
"styleRecalcs": 250,
"styleRecalcDurationMs": 34.132,
"layouts": 8,
"layoutDurationMs": 2.4340000000000006,
"taskDurationMs": 6654.631,
"heapDeltaBytes": -2292720,
"heapUsedBytes": 72695528,
"domNodes": -257,
"jsHeapTotalBytes": 4775936,
"scriptDurationMs": 2994.793,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69253968253968,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 24424.198999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23942.074,
"heapDeltaBytes": -969684,
"heapUsedBytes": 276254116,
"domNodes": -3343,
"jsHeapTotalBytes": 17813504,
"scriptDurationMs": 380.73400000000004,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 44.07166064981949,
"p95FrameDurationMs": 99.90000000000146
},
{
"name": "vue-large-graph-idle",
"durationMs": 24801.847000000067,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24247.397,
"heapDeltaBytes": 2454220,
"heapUsedBytes": 279985852,
"domNodes": -3343,
"jsHeapTotalBytes": 12836864,
"scriptDurationMs": 390.019,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 44.175222816399284,
"p95FrameDurationMs": 100
},
{
"name": "vue-large-graph-pan",
"durationMs": 29664.34700000002,
"styleRecalcs": 181,
"styleRecalcDurationMs": 25.82200000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 29429.202000000005,
"heapDeltaBytes": 1895576,
"heapUsedBytes": 252209512,
"domNodes": -3343,
"jsHeapTotalBytes": 12058624,
"scriptDurationMs": 994.519,
"eventListeners": -651,
"totalBlockingTimeMs": 4,
"frameDurationMs": 57.34758220502901,
"p95FrameDurationMs": 116.69999999999709
},
{
"name": "vue-large-graph-pan",
"durationMs": 29134.326999999983,
"styleRecalcs": 181,
"styleRecalcDurationMs": 22.394,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28865.453999999998,
"heapDeltaBytes": -9244804,
"heapUsedBytes": 273481672,
"domNodes": -3343,
"jsHeapTotalBytes": 12570624,
"scriptDurationMs": 926.805,
"eventListeners": -651,
"totalBlockingTimeMs": 57,
"frameDurationMs": 54.79116541353384,
"p95FrameDurationMs": 116.60000000000218
},
{
"name": "vue-node-resize-workload",
"durationMs": 8541.418000000021,
"styleRecalcs": 20,
"styleRecalcDurationMs": 67.13799999999998,
"layouts": 20,
"layoutDurationMs": 25.149000000000004,
"taskDurationMs": 8412.965,
"heapDeltaBytes": 6571176,
"heapUsedBytes": 254992736,
"domNodes": -3343,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 133.602,
"eventListeners": 0,
"totalBlockingTimeMs": 23,
"frameDurationMs": 51.71454545454545,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8437.734000000091,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.21400000000001,
"layouts": 20,
"layoutDurationMs": 28.550000000000004,
"taskDurationMs": 8337.550000000001,
"heapDeltaBytes": -19414788,
"heapUsedBytes": 253572072,
"domNodes": -3343,
"jsHeapTotalBytes": 17555456,
"scriptDurationMs": 129.128,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 48.187999999999995,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 13026.572999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12745.088,
"heapDeltaBytes": 3149436,
"heapUsedBytes": 252507108,
"domNodes": 0,
"jsHeapTotalBytes": -3932160,
"scriptDurationMs": 234.88799999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 45.99328621908128,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11799.720000000092,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11533.576000000001,
"heapDeltaBytes": 18933824,
"heapUsedBytes": 275199716,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 165.659,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.14142857142858,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "workflow-execution",
"durationMs": 145.66200000001572,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.745,
"layouts": 9,
"layoutDurationMs": 4.077000000000001,
"taskDurationMs": 106.77900000000001,
"heapDeltaBytes": 4873620,
"heapUsedBytes": 72855652,
"domNodes": 105,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.126,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662499999999966,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 556.6189999999551,
"styleRecalcs": 17,
"styleRecalcDurationMs": 14.737999999999998,
"layouts": 11,
"layoutDurationMs": 5.57,
"taskDurationMs": 186.46099999999998,
"heapDeltaBytes": -10643808,
"heapUsedBytes": 64234224,
"domNodes": 133,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 15.855,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 626.7930000000206,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.8180000000000001,
"layouts": 76,
"layoutDurationMs": 17.265,
"taskDurationMs": 587.0849999999999,
"heapDeltaBytes": -2585212,
"heapUsedBytes": 43444204,
"domNodes": 4,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 275.296,
"eventListeners": 296,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684193,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 582.3340000000599,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.66,
"layouts": 76,
"layoutDurationMs": 16.389999999999997,
"taskDurationMs": 550.964,
"heapDeltaBytes": 146608,
"heapUsedBytes": 47660388,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 262.591,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663888888888906,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1147.9519999999184,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.406,
"layouts": 76,
"layoutDurationMs": 23.661,
"taskDurationMs": 1127.7299999999998,
"heapDeltaBytes": 6750224,
"heapUsedBytes": 110323684,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 483.722,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.164179104477626,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 691.7160000000422,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.3649999999999998,
"layouts": 76,
"layoutDurationMs": 16.486,
"taskDurationMs": 662.495,
"heapDeltaBytes": -24122132,
"heapUsedBytes": 79320044,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 277.54599999999994,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664285714285704,
"p95FrameDurationMs": 16.700000000000728
}
]
}🎭 Playwright: ✅ 3144 passed, 0 failed · 4 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 4d1cbb3a3ee9a7ab8d4b2c15bc0cc3afc02e288c
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (286)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## cloud/1.59 #23066 +/- ##
=============================================
Coverage ? 86.86%
=============================================
Files ? 2815
Lines ? 143765
Branches ? 44249
=============================================
Hits ? 124881
Misses ? 17900
Partials ? 984
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
…23073) **Why:** `cloud/1.59` lint has been red since #22160 (ESLint cache now invalidates when i18n catalogs change). The uncached run surfaces `commands.Comfy_3DViewer_Open3DViewer` used by `Load3DViewerButton.vue` but missing from `src/locales/en/commands.json` on this branch. Every PR into `cloud/1.59` now fails `lint-pr / lint` (e.g. #23066, #23068). **Root cause:** `Load3DViewerButton.vue` reached `cloud/1.59` without its command label; `core/1.59` and `main` have it. **How:** add the entry exactly as it is on `core/1.59` (label "Open 3D Viewer (Beta) for Selected Node"). AS IS / TO BE: no UI change on a translated locale; the en tooltip/aria-label now resolve to the label instead of the raw key.
Manual backport of #23045 to
cloud/1.59: the backport bot hit a merge conflict.Why/Root cause/How: see #23045.
Conflict resolution
src/platform/billing/composables/types.ts: kept the 1.59SubscriptionStateimport and addedSubscriptionPaymentRecovery. DroppedPeriodCreditGrant(a later main feature, unused on 1.59).src/platform/billing/subscription/composables/useBillingPlans.ts: kept the 1.59 imports (workspaceApi,@/platform/telemetry/reportError, types fromworkspaceApi) and added theSubscriptionPaymentRecoverytype andzSubscriptionPaymentRecoveryimports. Dropped main's@comfyorg/billing-core/billingApi/@comfyorg/telemetryimports (later refactor). Adoption logic unchanged from FRONT-2049 fix(billing): offer to pay an unpaid signup invoice from the pricing table #23045.src/platform/billing/components/UnifiedPricingTable.test.ts: kept the 1.59Plan/BillingSubscriptionStatusimport fromworkspaceApiand added theuseSubscriptionPaymentRecovery,SubscriptionPaymentRecoveryandSubscriptionTiertype imports. Dropped the@comfyorg/billing-coreimport. New tests unchanged.Adaptations outside the conflicted files, required for 1.59:
packages/ingest-types: 1.59 lacks the type from the [chore] Update Ingest API types from cloud@bee7b64c #23044 sync. Added onlySubscriptionPaymentRecovery/zSubscriptionPaymentRecoveryand the optionalsubscription_payment_recoveryfield onBillingPlansResponse/zBillingPlansResponse, copied verbatim from main. No other ingest churn.useSubscriptionPaymentRecovery.ts(+ test):billingApi.getBillingOpStatus->workspaceApi.getBillingOpStatus,@comfyorg/telemetry/reportError->@/platform/telemetry/reportError(the 1.59 locations of the same calls).useBillingPlans.test.ts: the new case mocksworkspaceApi.getBillingPlansinstead ofbillingApi.getBillingPlans.useBillingContext.ts: readssubscriptionPaymentRecoveryfromcheckoutContext, the context 1.59 already uses forplans/teamCreditStops/fetchPlans(main has a single context), so the fact comes from the same/billing/plansread that drives the pricing table.useLegacyBilling.ts:subscriptionPaymentRecovery = computed(() => null)to satisfyBillingState, mirroring itsteamCreditStops(legacy never reads/billing/plans; main has no legacy context).Verification
pnpm test:unit src/platform/billing/components/UnifiedPricingTable.test.ts src/platform/billing/composables/useSubscriptionPaymentRecovery.test.ts src/platform/billing/subscription/composables/useBillingPlans.test.ts: 3 files, 113 passed (69 / 10 / 34).pnpm test:unit src/platform/billing/composables/useBillingContext.test.ts src/platform/billing/composables/useLegacyBilling.test.ts: 2 files, 97 passed (65 / 32).cd packages/account-core && pnpm vitest run src/core/billing/plans.test.ts: 1 file, 6 passed.typecheck:app,typecheck:account-core) passed.AS IS / TO BE: same as #23045.
Refs FRONT-2049