Repository navigation
[backport cloud/1.59] feat: retry idempotent requests on 429/502/503/504 in the shared fetch layer (#21322) - #22087
Conversation
…504 in the shared fetch layer (#21322) Backport of #21322 (5823317) to cloud/1.59. Conflicts resolved for the 1.59 layout: workspace requests still go through the axios workspaceApi client and workspaceApiUrl, so its read options and the web-session retry test mirror the 1.58 backport, and billingSdkStore keeps workspaceApiUrl while taking fetchWithRetry.
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-27T22:10:38.062Z",
"gitSha": "94bb63a2d53f4793802374b569fb6885f42e7731",
"branch": "backport-21322-to-cloud-1.59",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2023.9859999999794,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.9309999999999996,
"layouts": 9,
"layoutDurationMs": 2.6830000000000003,
"taskDurationMs": 576.773,
"heapDeltaBytes": 3597620,
"heapUsedBytes": 64646436,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 11.318999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760334,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2023.6830000000054,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.5189999999999997,
"layouts": 9,
"layoutDurationMs": 2.8049999999999993,
"taskDurationMs": 503.336,
"heapDeltaBytes": 4587244,
"heapUsedBytes": 74776560,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 8.262000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1842.7730000000224,
"styleRecalcs": 77,
"styleRecalcDurationMs": 13.527000000000001,
"layouts": 8,
"layoutDurationMs": 2.388,
"taskDurationMs": 917.3349999999999,
"heapDeltaBytes": 22698548,
"heapUsedBytes": 83939928,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 174.069,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665454545454544,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1807.058999999981,
"styleRecalcs": 76,
"styleRecalcDurationMs": 12.611999999999998,
"layouts": 9,
"layoutDurationMs": 2.7270000000000003,
"taskDurationMs": 868.202,
"heapDeltaBytes": 21795428,
"heapUsedBytes": 82416888,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 162.312,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66574074074074,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.696999999992,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.547,
"layouts": 10,
"layoutDurationMs": 3.467,
"taskDurationMs": 492.343,
"heapDeltaBytes": -1530488,
"heapUsedBytes": 59868728,
"domNodes": 56,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 14.157,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.9950000000217,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.664000000000001,
"layouts": 11,
"layoutDurationMs": 3.0889999999999995,
"taskDurationMs": 394.825,
"heapDeltaBytes": 610920,
"heapUsedBytes": 71447168,
"domNodes": 56,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 10.099,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 714.0089999999759,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.7550000000000003,
"layouts": 9,
"layoutDurationMs": 2.4879999999999995,
"taskDurationMs": 543.701,
"heapDeltaBytes": 3150832,
"heapUsedBytes": 64362304,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 196.38,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66744186046512,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 708.2870000000412,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.8459999999999996,
"layouts": 10,
"layoutDurationMs": 2.6429999999999993,
"taskDurationMs": 486.53400000000005,
"heapDeltaBytes": 5278840,
"heapUsedBytes": 66644352,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 171.488,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1236.8250000000103,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 956.682,
"heapDeltaBytes": -1404024,
"heapUsedBytes": 74678248,
"domNodes": -191,
"jsHeapTotalBytes": 12853248,
"scriptDurationMs": 73.18200000000002,
"eventListeners": -106,
"totalBlockingTimeMs": 548,
"frameDurationMs": 33.33243243243244,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1243.2019999999966,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 982.1209999999999,
"heapDeltaBytes": -12285404,
"heapUsedBytes": 75077292,
"domNodes": -191,
"jsHeapTotalBytes": 19931136,
"scriptDurationMs": 78.146,
"eventListeners": -106,
"totalBlockingTimeMs": 563,
"frameDurationMs": 33.78378378378378,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 892.5760000000196,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 572.8169999999997,
"heapDeltaBytes": -15778864,
"heapUsedBytes": 65381940,
"domNodes": -191,
"jsHeapTotalBytes": 1179648,
"scriptDurationMs": 174.541,
"eventListeners": -106,
"totalBlockingTimeMs": 226,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 895.1749999999947,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 572.4260000000002,
"heapDeltaBytes": -27476412,
"heapUsedBytes": 65638312,
"domNodes": -191,
"jsHeapTotalBytes": 3801088,
"scriptDurationMs": 181.317,
"eventListeners": -106,
"totalBlockingTimeMs": 239,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11863.699999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10979.755,
"heapDeltaBytes": 71145716,
"heapUsedBytes": 144673924,
"domNodes": -257,
"jsHeapTotalBytes": 77459456,
"scriptDurationMs": 8863.771,
"eventListeners": -68,
"totalBlockingTimeMs": 1772,
"frameDurationMs": 32.287193460490464,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10712.887000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9909.161000000002,
"heapDeltaBytes": 70791708,
"heapUsedBytes": 144491712,
"domNodes": -263,
"jsHeapTotalBytes": 65400832,
"scriptDurationMs": 7959.843999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 1114,
"frameDurationMs": 31.103488372093025,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 12362.066999999968,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11623.020999999999,
"heapDeltaBytes": -11311664,
"heapUsedBytes": 71141244,
"domNodes": -257,
"jsHeapTotalBytes": 23195648,
"scriptDurationMs": 9520.4,
"eventListeners": -68,
"totalBlockingTimeMs": 2207,
"frameDurationMs": 33.60353260869566,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10672.801999999934,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9843.263,
"heapDeltaBytes": 86688300,
"heapUsedBytes": 160698140,
"domNodes": -257,
"jsHeapTotalBytes": 70643712,
"scriptDurationMs": 7891.177000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 997,
"frameDurationMs": 31.096793002915454,
"p95FrameDurationMs": 50.099999999999454
},
{
"name": "large-combo-open",
"durationMs": 284.58499999999276,
"styleRecalcs": 24,
"styleRecalcDurationMs": 16.234,
"layouts": 11,
"layoutDurationMs": 3.4819999999999998,
"taskDurationMs": 243.53799999999998,
"heapDeltaBytes": -16838660,
"heapUsedBytes": 58745460,
"domNodes": 936,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 9.122000000000002,
"eventListeners": 205,
"totalBlockingTimeMs": 3,
"frameDurationMs": 25.75454545454547,
"p95FrameDurationMs": 100
},
{
"name": "large-combo-open",
"durationMs": 248.57199999996737,
"styleRecalcs": 23,
"styleRecalcDurationMs": 13.69,
"layouts": 10,
"layoutDurationMs": 4.195999999999999,
"taskDurationMs": 213.81900000000005,
"heapDeltaBytes": -1324988,
"heapUsedBytes": 68043340,
"domNodes": -2315,
"jsHeapTotalBytes": -262144,
"scriptDurationMs": 9.298,
"eventListeners": -573,
"totalBlockingTimeMs": 6,
"frameDurationMs": 22.718181818181826,
"p95FrameDurationMs": 83.29999999999973
},
{
"name": "large-graph-idle",
"durationMs": 2055.907999999988,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.808,
"layouts": 8,
"layoutDurationMs": 2.721,
"taskDurationMs": 690.3059999999998,
"heapDeltaBytes": -1190988,
"heapUsedBytes": 75274208,
"domNodes": -257,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 35.67400000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2055.6460000000243,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.078,
"layouts": 8,
"layoutDurationMs": 2.264,
"taskDurationMs": 622.614,
"heapDeltaBytes": -8995760,
"heapUsedBytes": 65471032,
"domNodes": -257,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 30.674,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2646.9490000000064,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.056,
"layouts": 7,
"layoutDurationMs": 2.1420000000000003,
"taskDurationMs": 1782.0090000000002,
"heapDeltaBytes": -17366564,
"heapUsedBytes": 60560680,
"domNodes": -257,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 859.627,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.770886075949367,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2599.4889999999486,
"styleRecalcs": 67,
"styleRecalcDurationMs": 8.125,
"layouts": 6,
"layoutDurationMs": 1.5630000000000002,
"taskDurationMs": 1737.39,
"heapDeltaBytes": -16979456,
"heapUsedBytes": 61501748,
"domNodes": -257,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 867.2059999999999,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.773548387096778,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-zoom",
"durationMs": 3920.4110000000014,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.841000000000003,
"layouts": 64,
"layoutDurationMs": 10.793000000000001,
"taskDurationMs": 1873.993,
"heapDeltaBytes": -9622836,
"heapUsedBytes": 84114460,
"domNodes": -233,
"jsHeapTotalBytes": 5668864,
"scriptDurationMs": 815.6519999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666101694915252,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3751.1870000000727,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.964,
"layouts": 64,
"layoutDurationMs": 10.633999999999999,
"taskDurationMs": 1798.9339999999997,
"heapDeltaBytes": 2686744,
"heapUsedBytes": 74810436,
"domNodes": -233,
"jsHeapTotalBytes": 1961984,
"scriptDurationMs": 787.78,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66622222222222,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "legacy-node-drag",
"durationMs": 3163.4519999999497,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.369000000000001,
"layouts": 5,
"layoutDurationMs": 1.4009999999999998,
"taskDurationMs": 2017.591,
"heapDeltaBytes": -7280228,
"heapUsedBytes": 72891604,
"domNodes": 0,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 996.4520000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.84385026737968,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2973.504000000048,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.014,
"layouts": 5,
"layoutDurationMs": 1.1880000000000002,
"taskDurationMs": 1938.36,
"heapDeltaBytes": 9957716,
"heapUsedBytes": 82343680,
"domNodes": 0,
"jsHeapTotalBytes": 3108864,
"scriptDurationMs": 983.2599999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.854237288135593,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3088.307000000043,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.4490000000000007,
"layouts": 5,
"layoutDurationMs": 1.4060000000000001,
"taskDurationMs": 828.1200000000001,
"heapDeltaBytes": -5446908,
"heapUsedBytes": 73660032,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 372.82099999999997,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665945945945946,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3115.9470000000056,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.8019999999999998,
"layouts": 6,
"layoutDurationMs": 1.5499999999999998,
"taskDurationMs": 830.252,
"heapDeltaBytes": -19522980,
"heapUsedBytes": 60923716,
"domNodes": -257,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 379.542,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665775401069517,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2046.2870000000066,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.287,
"layouts": 7,
"layoutDurationMs": 2.0140000000000002,
"taskDurationMs": 699.309,
"heapDeltaBytes": -13224144,
"heapUsedBytes": 67317288,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 35.752,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2046.3529999999537,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.5019999999999998,
"layouts": 7,
"layoutDurationMs": 1.85,
"taskDurationMs": 620.776,
"heapDeltaBytes": -11705720,
"heapUsedBytes": 65275196,
"domNodes": -257,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 30.114999999999995,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2819.005000000004,
"styleRecalcs": 25,
"styleRecalcDurationMs": 12.636999999999999,
"layouts": 6,
"layoutDurationMs": 1.6620000000000004,
"taskDurationMs": 656.4709999999999,
"heapDeltaBytes": -31037304,
"heapUsedBytes": 62067952,
"domNodes": -250,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 204.099,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.765476190476186,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2836.3709999999855,
"styleRecalcs": 26,
"styleRecalcDurationMs": 12.23,
"layouts": 6,
"layoutDurationMs": 1.3709999999999998,
"taskDurationMs": 640.5909999999999,
"heapDeltaBytes": -3723580,
"heapUsedBytes": 76064240,
"domNodes": -246,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 206.626,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665882352941175,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3343.399999999974,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.8310000000000002,
"layouts": 7,
"layoutDurationMs": 1.8639999999999999,
"taskDurationMs": 999.0360000000001,
"heapDeltaBytes": 3167468,
"heapUsedBytes": 79229580,
"domNodes": -257,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 404.721,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.749748743718595,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-topology-cadence",
"durationMs": 3318.055999999956,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.4479999999999997,
"layouts": 5,
"layoutDurationMs": 1.497,
"taskDurationMs": 993.139,
"heapDeltaBytes": -17336060,
"heapUsedBytes": 62513964,
"domNodes": -257,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 394.21500000000003,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.749999999999996,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 617.6739999999654,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.956,
"layouts": 8,
"layoutDurationMs": 2.245,
"taskDurationMs": 457.42800000000005,
"heapDeltaBytes": -1241888,
"heapUsedBytes": 61192236,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 152.192,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668421052631583,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 606.8129999999883,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.822,
"layouts": 10,
"layoutDurationMs": 2.9520000000000004,
"taskDurationMs": 428.01200000000006,
"heapDeltaBytes": -804296,
"heapUsedBytes": 61492780,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 147.31900000000002,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66388888888889,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2021.803000000034,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.987,
"layouts": 9,
"layoutDurationMs": 2.751,
"taskDurationMs": 571.276,
"heapDeltaBytes": 4617188,
"heapUsedBytes": 76972188,
"domNodes": 0,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 10.24,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2020.2940000000353,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.838,
"layouts": 9,
"layoutDurationMs": 2.8569999999999998,
"taskDurationMs": 538.2800000000001,
"heapDeltaBytes": 5531856,
"heapUsedBytes": 77194556,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 8.903999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1710.361999999975,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.419,
"layouts": 9,
"layoutDurationMs": 2.5089999999999995,
"taskDurationMs": 885.764,
"heapDeltaBytes": 19732212,
"heapUsedBytes": 80953352,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 118.50799999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262138,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.5849999999336,
"styleRecalcs": 77,
"styleRecalcDurationMs": 13.962,
"layouts": 9,
"layoutDurationMs": 2.071,
"taskDurationMs": 840.981,
"heapDeltaBytes": 18678300,
"heapUsedBytes": 80935464,
"domNodes": 0,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 111.36900000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1469.1229999999678,
"styleRecalcs": 18,
"styleRecalcDurationMs": 22.521,
"layouts": 5,
"layoutDurationMs": 16.906000000000006,
"taskDurationMs": 1165.732,
"heapDeltaBytes": 9568364,
"heapUsedBytes": 99975660,
"domNodes": 16030,
"jsHeapTotalBytes": 16650240,
"scriptDurationMs": 32.913,
"eventListeners": 3246,
"totalBlockingTimeMs": 173,
"frameDurationMs": 20.04324324324324,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8341.925999999945,
"styleRecalcs": 250,
"styleRecalcDurationMs": 30.021,
"layouts": 8,
"layoutDurationMs": 2.2500000000000004,
"taskDurationMs": 5396.756,
"heapDeltaBytes": 2813348,
"heapUsedBytes": 77380928,
"domNodes": -257,
"jsHeapTotalBytes": 3235840,
"scriptDurationMs": 2771.309,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665999999999997,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9339.87300000001,
"styleRecalcs": 251,
"styleRecalcDurationMs": 27.488000000000003,
"layouts": 8,
"layoutDurationMs": 2.0030000000000006,
"taskDurationMs": 5947.535999999999,
"heapDeltaBytes": -2700216,
"heapUsedBytes": 71218984,
"domNodes": -257,
"jsHeapTotalBytes": 5038080,
"scriptDurationMs": 2729.734,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665892857142858,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 23903.51099999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23356.701,
"heapDeltaBytes": -14594704,
"heapUsedBytes": 286089908,
"domNodes": -3343,
"jsHeapTotalBytes": 13623296,
"scriptDurationMs": 362.261,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.046478873239444,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-idle",
"durationMs": 23279.02100000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22795.954999999998,
"heapDeltaBytes": -16607944,
"heapUsedBytes": 279754524,
"domNodes": -3343,
"jsHeapTotalBytes": 16244736,
"scriptDurationMs": 337.88,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.66354344122657,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 28454.251,
"styleRecalcs": 181,
"styleRecalcDurationMs": 19.772999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28070.620000000003,
"heapDeltaBytes": -39878528,
"heapUsedBytes": 251648392,
"domNodes": -3373,
"jsHeapTotalBytes": 9691136,
"scriptDurationMs": 885.5200000000001,
"eventListeners": -667,
"totalBlockingTimeMs": 2,
"frameDurationMs": 53.175514018691594,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 27932.378999999968,
"styleRecalcs": 181,
"styleRecalcDurationMs": 22.414999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27565.592,
"heapDeltaBytes": -4628536,
"heapUsedBytes": 272053960,
"domNodes": -3343,
"jsHeapTotalBytes": -339968,
"scriptDurationMs": 867.254,
"eventListeners": -651,
"totalBlockingTimeMs": 13,
"frameDurationMs": 51.25174311926606,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-node-resize-workload",
"durationMs": 8432.51500000008,
"styleRecalcs": 20,
"styleRecalcDurationMs": 66.27900000000001,
"layouts": 20,
"layoutDurationMs": 22.653000000000006,
"taskDurationMs": 8299.973000000002,
"heapDeltaBytes": -4443064,
"heapUsedBytes": 271896620,
"domNodes": -3343,
"jsHeapTotalBytes": 17555456,
"scriptDurationMs": 124.072,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.591160220994475,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8232.852999999977,
"styleRecalcs": 20,
"styleRecalcDurationMs": 64.663,
"layouts": 20,
"layoutDurationMs": 21.153000000000006,
"taskDurationMs": 8130.217999999999,
"heapDeltaBytes": 2826400,
"heapUsedBytes": 279077628,
"domNodes": -3343,
"jsHeapTotalBytes": 21225472,
"scriptDurationMs": 128.574,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.607909604519776,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11671.158000000105,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11467.425000000003,
"heapDeltaBytes": 75052,
"heapUsedBytes": 271059100,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 162.975,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.50763888888889,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11381.992999999966,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11143.560000000001,
"heapDeltaBytes": 70796,
"heapUsedBytes": 277264220,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 157.62300000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.305673758865254,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "workflow-execution",
"durationMs": 139.32299999999032,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.193,
"layouts": 10,
"layoutDurationMs": 3.885,
"taskDurationMs": 95.58199999999998,
"heapDeltaBytes": 4740340,
"heapUsedBytes": 72795868,
"domNodes": 101,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.852,
"eventListeners": 3,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662499999999966,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 464.7109999999657,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.671,
"layouts": 10,
"layoutDurationMs": 2.9559999999999995,
"taskDurationMs": 108.23399999999998,
"heapDeltaBytes": 6602924,
"heapUsedBytes": 66900640,
"domNodes": 99,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.531999999999998,
"eventListeners": 3,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667857142857137,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 464.43699999997534,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.6669999999999999,
"layouts": 76,
"layoutDurationMs": 15.304,
"taskDurationMs": 420.074,
"heapDeltaBytes": -4650892,
"heapUsedBytes": 39453808,
"domNodes": 4,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 199.682,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664285714285693,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 467.9069999999683,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.65,
"layouts": 76,
"layoutDurationMs": 14.709,
"taskDurationMs": 421.076,
"heapDeltaBytes": -4505168,
"heapUsedBytes": 40930580,
"domNodes": 4,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 199.63,
"eventListeners": 296,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428573,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 580.139000000031,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.84,
"layouts": 76,
"layoutDurationMs": 14.352,
"taskDurationMs": 542.065,
"heapDeltaBytes": 858896,
"heapUsedBytes": 94722520,
"domNodes": 4,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 221.008,
"eventListeners": 296,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 544.8939999999993,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.778,
"layouts": 76,
"layoutDurationMs": 14.984,
"taskDurationMs": 508.54599999999994,
"heapDeltaBytes": 1532992,
"heapUsedBytes": 95602792,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 201.743,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageLine coverage: 60.4% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3119 passed, 0 failed · 4 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since f9c06fae1f15ef93b6afc18c5432b328cd194860
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (217)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.59 #22087 +/- ##
=============================================
Coverage ? 87.51%
=============================================
Files ? 2948
Lines ? 156016
Branches ? 42143
=============================================
Hits ? 136537
Misses ? 18804
Partials ? 675
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Approved at exact head 8c14d4f99230b5faa603e3aeab4be94fc2b42721: this is a faithful cloud/1.59 frontend backport of merged PR 21322.
Full context for agent readers
Both fidelity checks pass after accounting for the release branch’s workspace URL and store layout. The shared retry-policy files match the merged source, no package manifest is edited, all checks are settled with no executed failure, and there are no review threads.
<!-- claude-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0A4XMHANP3/p1793144276531189?thread_ts=1793144276.531189&cid=C0A4XMHANP3)_ **Before:** `lint-pr / lint` fails on `cloud/1.59` with `'commands.Comfy_3DViewer_Open3DViewer' does not exist in localization message resources` in `Load3DViewerButton.vue`, which also blocks #22120. **After:** `src/locales/en/commands.json` has the `Comfy_3DViewer_Open3DViewer` entry again (identical to `main`), so the lint error is gone. **Cause:** the key was missing from the locale files on `cloud/1.59` (dropped by a locale regeneration in the 1.59.2 release bump), and the failure surfaced after the #22087 backport. **How:** restored the 3-line entry in `src/locales/en/commands.json` from `main`. Verified with eslint on `Load3DViewerButton.vue` (2 errors before, clean after), `pnpm format:check`, and `pnpm typecheck`. --- _Generated by [Claude Code](https://claude.ai/code/session_01MUqgfmFn3gGxD33FeHpnKn)_ Co-authored-by: Claude <noreply@anthropic.com>
Manual backport of #21322 (
58233176b0) tocloud/1.59. The auto-backport failed on conflicts.Why
fetchBalancethrowsAuthStoreError: Balance temporarily unavailableon the first 503 in prod (Sentry CLOUD-FRONTEND-PROD-2V0).Root cause
The shared fetch paths (plain fetch, billing SDK, workspace axios client) never retried a retryable status. A transient 503 with
Retry-Aftersurfaced as an error on the first attempt.How
Same change as #21322: one shared retry for idempotent requests on 429/502/503/504, honoring a capped
Retry-After, with one timeout budget across attempts. Reads that already retry on their own opt out. Conflicts resolved for 1.59, which still uses the 1.58 workspace client layout:workspaceApi.ts: 1.59 sends workspace requests through the axios client withworkspaceApiUrl; the read options match the 1.58 backport ([backport core/1.58] feat: retry idempotent requests on 429/502/503/504 in the shared fetch layer (#21322) #22065 / [backport cloud/1.58] feat: retry idempotent requests on 429/502/503/504 in the shared fetch layer (#21322) #22066).billingSdkStore.ts: keptresolveUrl: workspaceApiUrland addedfetchImpl: fetchWithRetry.workspaceApi.webSessionRetry.test.ts: mock path points atworkspaceApiUrl.AS IS / TO BE
No UI change. AS IS: a 503 on a balance or workspace read fails on the first attempt. TO BE: it retries up to 3 attempts before failing. Covered by the unit tests below rather than screenshots.
Verified
The touched test files pass on the core/1.59 base (40 files, 931 tests). Pre-commit lint, format and typecheck pass.