Skip to content

fix: add missing 3D viewer command locale key - #22130

Merged
christian-byrne merged 1 commit into
cloud/1.59from
fix/cloud-1.59-3d-viewer-locale
Oct 28, 2026
Merged

christian-byrne merged 1 commit into
cloud/1.59from
fix/cloud-1.59-3d-viewer-locale

Conversation

@claude

@claude claude Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Requested by Christian Byrne · Slack thread

Before: lint-pr / lint fails on cloud/1.59 with 'commands.Comfy_3DViewer_Open3DViewer' does not exist in localization message resources in Load3DViewerButton.vue, which also blocks #22120.

After: src/locales/en/commands.json has the Comfy_3DViewer_Open3DViewer entry again (identical to main), so the lint error is gone.

Cause: the key was missing from the locale files on cloud/1.59 (dropped by a locale regeneration in the 1.59.2 release bump), and the failure surfaced after the #22087 backport.

How: restored the 3-line entry in src/locales/en/commands.json from main. Verified with eslint on Load3DViewerButton.vue (2 errors before, clean after), pnpm format:check, and pnpm typecheck.


Generated by Claude Code

The 1.59.2 release bump regenerated locales without the
Comfy_3DViewer_Open3DViewer command label, which Load3DViewerButton.vue
still references. Restore it to match main.
@claude
claude Bot requested a review from a team as a code owner October 28, 2026 05:30
@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

❌ 7 scenarios below the ≥52 P5 FPS target. Expand the scenario timings below and profile the affected scenarios before merging.

Scenario timings

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.5 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.8 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.5 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.3 MB heap
dom-widget-order-dense-n200-w200-i120: · 30.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 532ms TBT · 71.7 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 40.6 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 229ms TBT · 63.3 MB heap
extension-clean-combined-draw: · 31.8 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 809ms TBT · 125.2 MB heap
extension-rgthree-prototype-draw: · 31.5 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 876ms TBT · 137.9 MB heap
large-combo-open: · 41.4 avg FPS · 10.9 P5 FPS ❌ (target: ≥52) · 3ms TBT · 75.1 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.8 MB heap
large-graph-pan: · 59.8 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.8 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.5 MB heap
legacy-node-drag: · 59.5 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.8 MB heap
minimap-geometry-cadence: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.8 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.9 MB heap
minimap-progress-execution-cadence: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.4 MB heap
minimap-topology-cadence: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.0 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.0 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.8 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.3 MB heap
subgraph-transition-enter: · 51.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 159ms TBT · 99.4 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.4 MB heap
vue-large-graph-idle: · 25.4 avg FPS · 12.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 251.9 MB heap
vue-large-graph-pan: · 19.3 avg FPS · 8.6 P5 FPS ❌ (target: ≥52) · 27ms TBT · 244.7 MB heap
vue-node-resize-workload: · 21.4 avg FPS · 10.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 251.1 MB heap
vue-zoom-out-idle: · 26.7 avg FPS · 12.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 260.5 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.4 MB heap
agent-composer-empty-conversation-typing: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 38.5 MB heap
agent-composer-long-conversation-typing: · 58.4 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 95.6 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 3ms
canvas-idle: style recalc duration 3ms
canvas-idle: layout count 10
canvas-idle: style recalc count 11
canvas-idle: task duration 568ms
canvas-idle: script duration 10ms
canvas-idle: TBT 0ms
canvas-idle: heap used 71.5 MB
canvas-idle: DOM nodes 0
canvas-idle: event listeners 0
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 3ms
canvas-mouse-sweep: style recalc duration 13ms
canvas-mouse-sweep: layout count 10
canvas-mouse-sweep: style recalc count 76
canvas-mouse-sweep: task duration 870ms
canvas-mouse-sweep: script duration 158ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 78.8 MB
canvas-mouse-sweep: DOM nodes 0
canvas-mouse-sweep: event listeners 6
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 3ms
canvas-zoom-sweep: style recalc duration 5ms
canvas-zoom-sweep: layout count 10
canvas-zoom-sweep: style recalc count 19
canvas-zoom-sweep: task duration 421ms
canvas-zoom-sweep: script duration 12ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 81.5 MB
canvas-zoom-sweep: DOM nodes 56
canvas-zoom-sweep: event listeners 43
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 3ms
dom-widget-clipping: style recalc duration 3ms
dom-widget-clipping: layout count 10
dom-widget-clipping: style recalc count 14
dom-widget-clipping: task duration 498ms
dom-widget-clipping: script duration 170ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 68.3 MB
dom-widget-clipping: DOM nodes 0
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 33ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 922ms
dom-widget-order-dense-n200-w200-i120: script duration 68ms
dom-widget-order-dense-n200-w200-i120: TBT 532ms
dom-widget-order-dense-n200-w200-i120: heap used 71.7 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes -191
dom-widget-order-dense-n200-w200-i120: event listeners -106
dom-widget-order-sparse-n1000-w20-i120: avg frame time 25ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 567ms
dom-widget-order-sparse-n1000-w20-i120: script duration 168ms
dom-widget-order-sparse-n1000-w20-i120: TBT 229ms
dom-widget-order-sparse-n1000-w20-i120: heap used 63.3 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes -191
dom-widget-order-sparse-n1000-w20-i120: event listeners -106
extension-clean-combined-draw: avg frame time 31ms
extension-clean-combined-draw: p95 frame time 50ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 0ms
extension-clean-combined-draw: layout count 0
extension-clean-combined-draw: style recalc count 0
extension-clean-combined-draw: task duration 9425ms
extension-clean-combined-draw: script duration 7486ms
extension-clean-combined-draw: TBT 809ms
extension-clean-combined-draw: heap used 125.2 MB
extension-clean-combined-draw: DOM nodes -257
extension-clean-combined-draw: event listeners -68
extension-rgthree-prototype-draw: avg frame time 32ms
extension-rgthree-prototype-draw: p95 frame time 50ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 0ms
extension-rgthree-prototype-draw: layout count 0
extension-rgthree-prototype-draw: style recalc count 0
extension-rgthree-prototype-draw: task duration 9465ms
extension-rgthree-prototype-draw: script duration 7630ms
extension-rgthree-prototype-draw: TBT 876ms
extension-rgthree-prototype-draw: heap used 137.9 MB
extension-rgthree-prototype-draw: DOM nodes -257
extension-rgthree-prototype-draw: event listeners -68
large-combo-open: avg frame time 24ms
large-combo-open: p95 frame time 92ms
large-combo-open: layout duration 3ms
large-combo-open: style recalc duration 14ms
large-combo-open: layout count 12
large-combo-open: style recalc count 25
large-combo-open: task duration 215ms
large-combo-open: script duration 10ms
large-combo-open: TBT 3ms
large-combo-open: heap used 75.1 MB
large-combo-open: DOM nodes -690
large-combo-open: event listeners -184
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 2ms
large-graph-idle: style recalc duration 2ms
large-graph-idle: layout count 9
large-graph-idle: style recalc count 9
large-graph-idle: task duration 665ms
large-graph-idle: script duration 34ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 63.8 MB
large-graph-idle: DOM nodes -262
large-graph-idle: event listeners -68
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 2ms
large-graph-pan: style recalc duration 8ms
large-graph-pan: layout count 7
large-graph-pan: style recalc count 69
large-graph-pan: task duration 1734ms
large-graph-pan: script duration 847ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 77.8 MB
large-graph-pan: DOM nodes -257
large-graph-pan: event listeners -66
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 11ms
large-graph-zoom: style recalc duration 9ms
large-graph-zoom: layout count 65
large-graph-zoom: style recalc count 71
large-graph-zoom: task duration 1803ms
large-graph-zoom: script duration 788ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 69.5 MB
large-graph-zoom: DOM nodes -233
large-graph-zoom: event listeners -68
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 1ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 5
legacy-node-drag: style recalc count 45
legacy-node-drag: task duration 2032ms
legacy-node-drag: script duration 995ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 83.8 MB
legacy-node-drag: DOM nodes -129
legacy-node-drag: event listeners 60
minimap-geometry-cadence: avg frame time 17ms
minimap-geometry-cadence: p95 frame time 17ms
minimap-geometry-cadence: layout duration 2ms
minimap-geometry-cadence: style recalc duration 2ms
minimap-geometry-cadence: layout count 7
minimap-geometry-cadence: style recalc count 7
minimap-geometry-cadence: task duration 797ms
minimap-geometry-cadence: script duration 382ms
minimap-geometry-cadence: TBT 0ms
minimap-geometry-cadence: heap used 77.8 MB
minimap-geometry-cadence: DOM nodes -257
minimap-geometry-cadence: event listeners -68
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 2ms
minimap-idle: style recalc duration 2ms
minimap-idle: layout count 7
minimap-idle: style recalc count 8
minimap-idle: task duration 662ms
minimap-idle: script duration 33ms
minimap-idle: TBT 0ms
minimap-idle: heap used 59.9 MB
minimap-idle: DOM nodes -257
minimap-idle: event listeners -68
minimap-progress-execution-cadence: avg frame time 17ms
minimap-progress-execution-cadence: p95 frame time 17ms
minimap-progress-execution-cadence: layout duration 2ms
minimap-progress-execution-cadence: style recalc duration 12ms
minimap-progress-execution-cadence: layout count 7
minimap-progress-execution-cadence: style recalc count 27
minimap-progress-execution-cadence: task duration 592ms
minimap-progress-execution-cadence: script duration 191ms
minimap-progress-execution-cadence: TBT 0ms
minimap-progress-execution-cadence: heap used 69.4 MB
minimap-progress-execution-cadence: DOM nodes -250
minimap-progress-execution-cadence: event listeners -68
minimap-topology-cadence: avg frame time 17ms
minimap-topology-cadence: p95 frame time 17ms
minimap-topology-cadence: layout duration 2ms
minimap-topology-cadence: style recalc duration 2ms
minimap-topology-cadence: layout count 8
minimap-topology-cadence: style recalc count 8
minimap-topology-cadence: task duration 948ms
minimap-topology-cadence: script duration 384ms
minimap-topology-cadence: TBT 0ms
minimap-topology-cadence: heap used 75.0 MB
minimap-topology-cadence: DOM nodes -257
minimap-topology-cadence: event listeners -68
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 2ms
subgraph-dom-widget-clipping: style recalc duration 5ms
subgraph-dom-widget-clipping: layout count 8
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 445ms
subgraph-dom-widget-clipping: script duration 147ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 60.0 MB
subgraph-dom-widget-clipping: DOM nodes 0
subgraph-dom-widget-clipping: event listeners 46
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 3ms
subgraph-idle: style recalc duration 2ms
subgraph-idle: layout count 9
subgraph-idle: style recalc count 9
subgraph-idle: task duration 540ms
subgraph-idle: script duration 9ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 66.8 MB
subgraph-idle: DOM nodes 0
subgraph-idle: event listeners 0
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 2ms
subgraph-mouse-sweep: style recalc duration 13ms
subgraph-mouse-sweep: layout count 9
subgraph-mouse-sweep: style recalc count 76
subgraph-mouse-sweep: task duration 825ms
subgraph-mouse-sweep: script duration 108ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 76.3 MB
subgraph-mouse-sweep: DOM nodes 0
subgraph-mouse-sweep: event listeners 6
subgraph-transition-enter: avg frame time 20ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 17ms
subgraph-transition-enter: style recalc duration 23ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 1038ms
subgraph-transition-enter: script duration 28ms
subgraph-transition-enter: TBT 159ms
subgraph-transition-enter: heap used 99.4 MB
subgraph-transition-enter: DOM nodes 16030
subgraph-transition-enter: event listeners 3246
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 2ms
viewport-pan-sweep: style recalc duration 28ms
viewport-pan-sweep: layout count 9
viewport-pan-sweep: style recalc count 251
viewport-pan-sweep: task duration 6080ms
viewport-pan-sweep: script duration 2780ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 65.4 MB
viewport-pan-sweep: DOM nodes -257
viewport-pan-sweep: event listeners -66
vue-large-graph-idle: avg frame time 39ms
vue-large-graph-idle: p95 frame time 83ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 22136ms
vue-large-graph-idle: script duration 303ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 251.9 MB
vue-large-graph-idle: DOM nodes -3343
vue-large-graph-idle: event listeners -653
vue-large-graph-pan: avg frame time 52ms
vue-large-graph-pan: p95 frame time 117ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 19ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 181
vue-large-graph-pan: task duration 27292ms
vue-large-graph-pan: script duration 893ms
vue-large-graph-pan: TBT 27ms
vue-large-graph-pan: heap used 244.7 MB
vue-large-graph-pan: DOM nodes -3343
vue-large-graph-pan: event listeners -651
vue-node-resize-workload: avg frame time 47ms
vue-node-resize-workload: p95 frame time 100ms
vue-node-resize-workload: layout duration 25ms
vue-node-resize-workload: style recalc duration 71ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 8023ms
vue-node-resize-workload: script duration 130ms
vue-node-resize-workload: TBT 0ms
vue-node-resize-workload: heap used 251.1 MB
vue-node-resize-workload: DOM nodes -1825
vue-node-resize-workload: event listeners -330
vue-zoom-out-idle: avg frame time 38ms
vue-zoom-out-idle: p95 frame time 83ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 10854ms
vue-zoom-out-idle: script duration 144ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 260.5 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners 0
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 4ms
workflow-execution: style recalc duration 9ms
workflow-execution: layout count 9
workflow-execution: style recalc count 9
workflow-execution: task duration 103ms
workflow-execution: script duration 9ms
workflow-execution: TBT 0ms
workflow-execution: heap used 59.4 MB
workflow-execution: DOM nodes 104
workflow-execution: event listeners 5
agent-composer-empty-conversation-typing: avg frame time 17ms
agent-composer-empty-conversation-typing: p95 frame time 17ms
agent-composer-empty-conversation-typing: layout duration 15ms
agent-composer-empty-conversation-typing: style recalc duration 1ms
agent-composer-empty-conversation-typing: layout count 76
agent-composer-empty-conversation-typing: style recalc count 5
agent-composer-empty-conversation-typing: task duration 442ms
agent-composer-empty-conversation-typing: script duration 214ms
agent-composer-empty-conversation-typing: TBT 0ms
agent-composer-empty-conversation-typing: heap used 38.5 MB
agent-composer-empty-conversation-typing: DOM nodes 4
agent-composer-empty-conversation-typing: event listeners 292
agent-composer-long-conversation-typing: avg frame time 17ms
agent-composer-long-conversation-typing: p95 frame time 17ms
agent-composer-long-conversation-typing: layout duration 16ms
agent-composer-long-conversation-typing: style recalc duration 3ms
agent-composer-long-conversation-typing: layout count 76
agent-composer-long-conversation-typing: style recalc count 5
agent-composer-long-conversation-typing: task duration 585ms
agent-composer-long-conversation-typing: script duration 240ms
agent-composer-long-conversation-typing: TBT 0ms
agent-composer-long-conversation-typing: heap used 95.6 MB
agent-composer-long-conversation-typing: DOM nodes 4
agent-composer-long-conversation-typing: event listeners 292
Raw data
{
  "timestamp": "2026-10-28T05:43:28.572Z",
  "gitSha": "96ec6df6ec8502caa6b17dd5101f416886ce7588",
  "branch": "fix/cloud-1.59-3d-viewer-locale",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2006.6630000000032,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 2.4099999999999997,
      "layouts": 10,
      "layoutDurationMs": 2.641,
      "taskDurationMs": 498.951,
      "heapDeltaBytes": 5216480,
      "heapUsedBytes": 75411576,
      "domNodes": 0,
      "jsHeapTotalBytes": 10223616,
      "scriptDurationMs": 7.441,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "canvas-idle",
      "durationMs": 2024.3900000000394,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 2.962,
      "layouts": 10,
      "layoutDurationMs": 2.9710000000000005,
      "taskDurationMs": 637.423,
      "heapDeltaBytes": 4567804,
      "heapUsedBytes": 74580316,
      "domNodes": 0,
      "jsHeapTotalBytes": 9437184,
      "scriptDurationMs": 11.562000000000003,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666393442622947,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1724.8219999999606,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 11.096,
      "layouts": 10,
      "layoutDurationMs": 2.5840000000000005,
      "taskDurationMs": 816.8499999999999,
      "heapDeltaBytes": 21365644,
      "heapUsedBytes": 82520880,
      "domNodes": 0,
      "jsHeapTotalBytes": 7602176,
      "scriptDurationMs": 149.35899999999998,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666346153846153,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1839.337999999998,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 14.391000000000002,
      "layouts": 10,
      "layoutDurationMs": 3.6609999999999996,
      "taskDurationMs": 922.989,
      "heapDeltaBytes": 21830036,
      "heapUsedBytes": 82715904,
      "domNodes": 0,
      "jsHeapTotalBytes": 8126464,
      "scriptDurationMs": 167.345,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.667272727272724,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1701.306000000045,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 4.4799999999999995,
      "layouts": 9,
      "layoutDurationMs": 2.8249999999999997,
      "taskDurationMs": 392.89900000000006,
      "heapDeltaBytes": 24108476,
      "heapUsedBytes": 84760232,
      "domNodes": 56,
      "jsHeapTotalBytes": 7340032,
      "scriptDurationMs": 9.215000000000002,
      "eventListeners": 43,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1707.71400000001,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 5.625,
      "layouts": 11,
      "layoutDurationMs": 3.9450000000000007,
      "taskDurationMs": 448.85,
      "heapDeltaBytes": 24789788,
      "heapUsedBytes": 86167620,
      "domNodes": 56,
      "jsHeapTotalBytes": 7602176,
      "scriptDurationMs": 14.261,
      "eventListeners": 43,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6656862745098,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 691.44,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 2.36,
      "layouts": 9,
      "layoutDurationMs": 2.174,
      "taskDurationMs": 479.297,
      "heapDeltaBytes": 5522548,
      "heapUsedBytes": 66365008,
      "domNodes": 0,
      "jsHeapTotalBytes": 9437184,
      "scriptDurationMs": 169.14600000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66585365853658,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 724.3510000000697,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 3.345,
      "layouts": 10,
      "layoutDurationMs": 3.2670000000000003,
      "taskDurationMs": 515.86,
      "heapDeltaBytes": 5943548,
      "heapUsedBytes": 76935040,
      "domNodes": 0,
      "jsHeapTotalBytes": 10485760,
      "scriptDurationMs": 171.41699999999997,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66744186046511,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1210.9399999999937,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 899.156,
      "heapDeltaBytes": -11826180,
      "heapUsedBytes": 75357452,
      "domNodes": -191,
      "jsHeapTotalBytes": 19931136,
      "scriptDurationMs": 67.17599999999999,
      "eventListeners": -106,
      "totalBlockingTimeMs": 530,
      "frameDurationMs": 32.88108108108109,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1223.971000000006,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 945.308,
      "heapDeltaBytes": -12426572,
      "heapUsedBytes": 75067132,
      "domNodes": -191,
      "jsHeapTotalBytes": 20979712,
      "scriptDurationMs": 68.20400000000001,
      "eventListeners": -106,
      "totalBlockingTimeMs": 533,
      "frameDurationMs": 32.88378378378378,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 877.3580000000152,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 551.7540000000002,
      "heapDeltaBytes": -28484980,
      "heapUsedBytes": 65880328,
      "domNodes": -191,
      "jsHeapTotalBytes": 3801088,
      "scriptDurationMs": 167.91299999999998,
      "eventListeners": -106,
      "totalBlockingTimeMs": 222,
      "frameDurationMs": 24.53611111111109,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 908.8050000000294,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 582.9350000000004,
      "heapDeltaBytes": -27395120,
      "heapUsedBytes": 66909572,
      "domNodes": -191,
      "jsHeapTotalBytes": 3538944,
      "scriptDurationMs": 168.78799999999998,
      "eventListeners": -106,
      "totalBlockingTimeMs": 235,
      "frameDurationMs": 24.772972972972983,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 10079.779000000002,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9296.077000000001,
      "heapDeltaBytes": 55273356,
      "heapUsedBytes": 128468968,
      "domNodes": -257,
      "jsHeapTotalBytes": 62517248,
      "scriptDurationMs": 7367.7029999999995,
      "eventListeners": -68,
      "totalBlockingTimeMs": 812,
      "frameDurationMs": 31.70754716981132,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 10355.710000000045,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9554.114,
      "heapDeltaBytes": 60034684,
      "heapUsedBytes": 134186244,
      "domNodes": -257,
      "jsHeapTotalBytes": 66973696,
      "scriptDurationMs": 7605.068,
      "eventListeners": -68,
      "totalBlockingTimeMs": 805,
      "frameDurationMs": 31.173493975903614,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 9566.27500000002,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8781.409,
      "heapDeltaBytes": 62284544,
      "heapUsedBytes": 135235668,
      "domNodes": -257,
      "jsHeapTotalBytes": 55439360,
      "scriptDurationMs": 7014.42,
      "eventListeners": -68,
      "totalBlockingTimeMs": 608,
      "frameDurationMs": 31.99397993311037,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 10881.695000000036,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10149.319,
      "heapDeltaBytes": 79774476,
      "heapUsedBytes": 153931964,
      "domNodes": -257,
      "jsHeapTotalBytes": 74051584,
      "scriptDurationMs": 8245.637,
      "eventListeners": -68,
      "totalBlockingTimeMs": 1143,
      "frameDurationMs": 31.54463768115942,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "large-combo-open",
      "durationMs": 260.38600000003953,
      "styleRecalcs": 25,
      "styleRecalcDurationMs": 13.152,
      "layouts": 12,
      "layoutDurationMs": 3.2729999999999997,
      "taskDurationMs": 227.401,
      "heapDeltaBytes": -7505520,
      "heapUsedBytes": 67771696,
      "domNodes": -2315,
      "jsHeapTotalBytes": -262144,
      "scriptDurationMs": 11.349000000000002,
      "eventListeners": -573,
      "totalBlockingTimeMs": 4,
      "frameDurationMs": 23.329999999999973,
      "p95FrameDurationMs": 83.30000000000018
    },
    {
      "name": "large-combo-open",
      "durationMs": 254.93199999993976,
      "styleRecalcs": 24,
      "styleRecalcDurationMs": 14.280000000000001,
      "layouts": 12,
      "layoutDurationMs": 3.415,
      "taskDurationMs": 203.185,
      "heapDeltaBytes": 14421632,
      "heapUsedBytes": 89809512,
      "domNodes": 936,
      "jsHeapTotalBytes": 1835008,
      "scriptDurationMs": 8.787999999999998,
      "eventListeners": 205,
      "totalBlockingTimeMs": 2,
      "frameDurationMs": 25,
      "p95FrameDurationMs": 100
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2041.0610000000133,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 2.364,
      "layouts": 10,
      "layoutDurationMs": 2.391,
      "taskDurationMs": 621.8229999999999,
      "heapDeltaBytes": -20348540,
      "heapUsedBytes": 70417424,
      "domNodes": -257,
      "jsHeapTotalBytes": 4358144,
      "scriptDurationMs": 30.718999999999998,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665853658536587,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2057.7029999999468,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 2.5249999999999995,
      "layouts": 8,
      "layoutDurationMs": 2.578,
      "taskDurationMs": 707.4820000000001,
      "heapDeltaBytes": -12008400,
      "heapUsedBytes": 63364896,
      "domNodes": -267,
      "jsHeapTotalBytes": 3534848,
      "scriptDurationMs": 37.299,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66585365853659,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2479.677000000038,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 7.666,
      "layouts": 7,
      "layoutDurationMs": 1.5770000000000002,
      "taskDurationMs": 1691.363,
      "heapDeltaBytes": 4346064,
      "heapUsedBytes": 81732636,
      "domNodes": -257,
      "jsHeapTotalBytes": 5070848,
      "scriptDurationMs": 824.8409999999999,
      "eventListeners": -66,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66577181208054,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2573.5260000000153,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 8.848999999999998,
      "layouts": 7,
      "layoutDurationMs": 2.0989999999999998,
      "taskDurationMs": 1775.9099999999996,
      "heapDeltaBytes": 5807740,
      "heapUsedBytes": 81344572,
      "domNodes": -257,
      "jsHeapTotalBytes": 5857280,
      "scriptDurationMs": 868.817,
      "eventListeners": -66,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.774025974025975,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3600.5369999999743,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 9.117,
      "layouts": 65,
      "layoutDurationMs": 10.47,
      "taskDurationMs": 1754.25,
      "heapDeltaBytes": -5221268,
      "heapUsedBytes": 66239356,
      "domNodes": -233,
      "jsHeapTotalBytes": 1961984,
      "scriptDurationMs": 768.413,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666203703703705,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3847.5089999999454,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 9.690999999999999,
      "layouts": 65,
      "layoutDurationMs": 10.753,
      "taskDurationMs": 1852.688,
      "heapDeltaBytes": 8147404,
      "heapUsedBytes": 79511712,
      "domNodes": -233,
      "jsHeapTotalBytes": 1961984,
      "scriptDurationMs": 807.536,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666233766233766,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3035.9469999999646,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 4.861,
      "layouts": 5,
      "layoutDurationMs": 1.0499999999999998,
      "taskDurationMs": 1959.5259999999998,
      "heapDeltaBytes": 16454624,
      "heapUsedBytes": 94647580,
      "domNodes": 0,
      "jsHeapTotalBytes": 5660672,
      "scriptDurationMs": 968.872,
      "eventListeners": 182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.758563535911602,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3246.242999999936,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 5.33,
      "layouts": 5,
      "layoutDurationMs": 1.3209999999999997,
      "taskDurationMs": 2103.7340000000004,
      "heapDeltaBytes": 1693928,
      "heapUsedBytes": 81033916,
      "domNodes": -257,
      "jsHeapTotalBytes": 5001216,
      "scriptDurationMs": 1021.709,
      "eventListeners": -63,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.838860103626942,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-geometry-cadence",
      "durationMs": 3091.9529999999895,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 1.53,
      "layouts": 7,
      "layoutDurationMs": 1.5900000000000003,
      "taskDurationMs": 778.3729999999999,
      "heapDeltaBytes": -11351356,
      "heapUsedBytes": 81921756,
      "domNodes": -257,
      "jsHeapTotalBytes": 6717440,
      "scriptDurationMs": 374.66900000000004,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665591397849465,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-geometry-cadence",
      "durationMs": 3139.5710000000463,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 1.8019999999999998,
      "layouts": 6,
      "layoutDurationMs": 1.7930000000000004,
      "taskDurationMs": 816.597,
      "heapDeltaBytes": 4888136,
      "heapUsedBytes": 81270376,
      "domNodes": -257,
      "jsHeapTotalBytes": 5632000,
      "scriptDurationMs": 389.151,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665425531914895,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2033.5230000000024,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 1.7240000000000006,
      "layouts": 7,
      "layoutDurationMs": 1.754,
      "taskDurationMs": 615.7719999999999,
      "heapDeltaBytes": -29734048,
      "heapUsedBytes": 63193072,
      "domNodes": -257,
      "jsHeapTotalBytes": 4620288,
      "scriptDurationMs": 29.499000000000006,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6655737704918,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2044.2829999999503,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 2.3379999999999996,
      "layouts": 7,
      "layoutDurationMs": 2.1380000000000003,
      "taskDurationMs": 709.0400000000001,
      "heapDeltaBytes": -12856388,
      "heapUsedBytes": 62521356,
      "domNodes": -257,
      "jsHeapTotalBytes": 4321280,
      "scriptDurationMs": 37.12500000000001,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666664,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-progress-execution-cadence",
      "durationMs": 2990.2329999999893,
      "styleRecalcs": 27,
      "styleRecalcDurationMs": 11.234,
      "layouts": 8,
      "layoutDurationMs": 1.8760000000000003,
      "taskDurationMs": 584.7139999999999,
      "heapDeltaBytes": -1042944,
      "heapUsedBytes": 75881108,
      "domNodes": -253,
      "jsHeapTotalBytes": 4321280,
      "scriptDurationMs": 184.066,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665921787709497,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-progress-execution-cadence",
      "durationMs": 2754.6459999999797,
      "styleRecalcs": 26,
      "styleRecalcDurationMs": 11.780000000000003,
      "layouts": 6,
      "layoutDurationMs": 1.219,
      "taskDurationMs": 598.4609999999999,
      "heapDeltaBytes": -9820332,
      "heapUsedBytes": 69687296,
      "domNodes": -247,
      "jsHeapTotalBytes": 4321280,
      "scriptDurationMs": 196.963,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665454545454544,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-topology-cadence",
      "durationMs": 3197.971999999993,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 1.587,
      "layouts": 8,
      "layoutDurationMs": 1.682,
      "taskDurationMs": 892.735,
      "heapDeltaBytes": 6609580,
      "heapUsedBytes": 86820764,
      "domNodes": -257,
      "jsHeapTotalBytes": 4059136,
      "scriptDurationMs": 354.67400000000004,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665968586387432,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-topology-cadence",
      "durationMs": 3352.995999999962,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 2.176,
      "layouts": 7,
      "layoutDurationMs": 2.054,
      "taskDurationMs": 1003.6450000000001,
      "heapDeltaBytes": -22805272,
      "heapUsedBytes": 70500384,
      "domNodes": -257,
      "jsHeapTotalBytes": 6717440,
      "scriptDurationMs": 413.22600000000006,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666169154228854,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 564.0539999999987,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 4.594999999999999,
      "layouts": 8,
      "layoutDurationMs": 2.0770000000000004,
      "taskDurationMs": 426.94300000000004,
      "heapDeltaBytes": 922148,
      "heapUsedBytes": 62867616,
      "domNodes": 0,
      "jsHeapTotalBytes": 9699328,
      "scriptDurationMs": 145.468,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.664705882352937,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 657.9619999999977,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 4.925,
      "layouts": 8,
      "layoutDurationMs": 2.5359999999999996,
      "taskDurationMs": 462.167,
      "heapDeltaBytes": 883680,
      "heapUsedBytes": 62962580,
      "domNodes": 0,
      "jsHeapTotalBytes": 9437184,
      "scriptDurationMs": 148.90699999999998,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66500000000001,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2018.2759999999575,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 1.9920000000000007,
      "layouts": 9,
      "layoutDurationMs": 2.2680000000000007,
      "taskDurationMs": 502.683,
      "heapDeltaBytes": 338828,
      "heapUsedBytes": 61997252,
      "domNodes": 0,
      "jsHeapTotalBytes": 7077888,
      "scriptDurationMs": 6.944999999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2021.9959999999446,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 2.8579999999999997,
      "layouts": 9,
      "layoutDurationMs": 2.9640000000000004,
      "taskDurationMs": 577.49,
      "heapDeltaBytes": 5013460,
      "heapUsedBytes": 78085056,
      "domNodes": 0,
      "jsHeapTotalBytes": 10223616,
      "scriptDurationMs": 10.690999999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66611570247934,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1692.2420000000216,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 11.776000000000002,
      "layouts": 9,
      "layoutDurationMs": 2.2049999999999996,
      "taskDurationMs": 782.2610000000001,
      "heapDeltaBytes": 17119120,
      "heapUsedBytes": 79522508,
      "domNodes": 0,
      "jsHeapTotalBytes": 7602176,
      "scriptDurationMs": 100.8,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1709.2979999999898,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 14.182,
      "layouts": 8,
      "layoutDurationMs": 2.5069999999999997,
      "taskDurationMs": 867.1669999999999,
      "heapDeltaBytes": 18636800,
      "heapUsedBytes": 80588136,
      "domNodes": 0,
      "jsHeapTotalBytes": 8650752,
      "scriptDurationMs": 115.17500000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666990291262135,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1435.8970000000113,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 22.552000000000003,
      "layouts": 5,
      "layoutDurationMs": 16.706000000000003,
      "taskDurationMs": 1037.5520000000001,
      "heapDeltaBytes": 9265704,
      "heapUsedBytes": 104218484,
      "domNodes": 16030,
      "jsHeapTotalBytes": 18747392,
      "scriptDurationMs": 28.325000000000003,
      "eventListeners": 3246,
      "totalBlockingTimeMs": 159,
      "frameDurationMs": 19.59324324324324,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8921.357,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 27.346000000000004,
      "layouts": 9,
      "layoutDurationMs": 2.435,
      "taskDurationMs": 5904.536,
      "heapDeltaBytes": -29545732,
      "heapUsedBytes": 61067676,
      "domNodes": -257,
      "jsHeapTotalBytes": 4620288,
      "scriptDurationMs": 2709.688,
      "eventListeners": -66,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66610486891386,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9691.000000000031,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 29.383,
      "layouts": 8,
      "layoutDurationMs": 2.1229999999999993,
      "taskDurationMs": 6255.356,
      "heapDeltaBytes": -15002024,
      "heapUsedBytes": 76129576,
      "domNodes": -257,
      "jsHeapTotalBytes": 5861376,
      "scriptDurationMs": 2850.9120000000003,
      "eventListeners": -66,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.69448275862069,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 22703.30700000005,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21671.143,
      "heapDeltaBytes": -27348664,
      "heapUsedBytes": 269062580,
      "domNodes": -3343,
      "jsHeapTotalBytes": 8638464,
      "scriptDurationMs": 294.705,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 38.47305084745763,
      "p95FrameDurationMs": 83.30000000000291
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 23053.23099999998,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22600.786,
      "heapDeltaBytes": -36926548,
      "heapUsedBytes": 259117624,
      "domNodes": -3343,
      "jsHeapTotalBytes": 15982592,
      "scriptDurationMs": 310.344,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 40.22530541012217,
      "p95FrameDurationMs": 83.29999999999927
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 27227.195999999993,
      "styleRecalcs": 181,
      "styleRecalcDurationMs": 17.03400000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 26787.635,
      "heapDeltaBytes": -29465720,
      "heapUsedBytes": 261769968,
      "domNodes": -3343,
      "jsHeapTotalBytes": 11001856,
      "scriptDurationMs": 860.7810000000001,
      "eventListeners": -651,
      "totalBlockingTimeMs": 4,
      "frameDurationMs": 50.58661710037175,
      "p95FrameDurationMs": 116.59999999999854
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 28103.41100000005,
      "styleRecalcs": 181,
      "styleRecalcDurationMs": 21.232,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 27795.395000000004,
      "heapDeltaBytes": -39997856,
      "heapUsedBytes": 251489152,
      "domNodes": -3343,
      "jsHeapTotalBytes": 8118272,
      "scriptDurationMs": 924.856,
      "eventListeners": -651,
      "totalBlockingTimeMs": 50,
      "frameDurationMs": 53.14839319470699,
      "p95FrameDurationMs": 116.59999999999854
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 8006.942999999978,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 64.03200000000001,
      "layouts": 20,
      "layoutDurationMs": 21.58600000000001,
      "taskDurationMs": 7860.601000000001,
      "heapDeltaBytes": -1517556,
      "heapUsedBytes": 280561952,
      "domNodes": -307,
      "jsHeapTotalBytes": 24104960,
      "scriptDurationMs": 111.457,
      "eventListeners": -7,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 47.05705882352942,
      "p95FrameDurationMs": 99.89999999999782
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 8309.945999999967,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 78.91999999999999,
      "layouts": 20,
      "layoutDurationMs": 29.135999999999996,
      "taskDurationMs": 8185.755999999999,
      "heapDeltaBytes": -26436704,
      "heapUsedBytes": 246034780,
      "domNodes": -3343,
      "jsHeapTotalBytes": 16506880,
      "scriptDurationMs": 148.00900000000001,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 46.460335195530725,
      "p95FrameDurationMs": 100
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 10996.215000000007,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10561.919,
      "heapDeltaBytes": 323964,
      "heapUsedBytes": 281684120,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 135.30900000000003,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 36.720666666666666,
      "p95FrameDurationMs": 83.29999999999927
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 11387.30799999996,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11145.118999999997,
      "heapDeltaBytes": -18624952,
      "heapUsedBytes": 264634316,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 152.03499999999997,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 38.32592592592592,
      "p95FrameDurationMs": 83.29999999999927
    },
    {
      "name": "workflow-execution",
      "durationMs": 148.63900000000285,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.244,
      "layouts": 9,
      "layoutDurationMs": 3.546,
      "taskDurationMs": 115.10000000000001,
      "heapDeltaBytes": -13110500,
      "heapUsedBytes": 60506920,
      "domNodes": 101,
      "jsHeapTotalBytes": 7602176,
      "scriptDurationMs": 10.038,
      "eventListeners": 3,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "workflow-execution",
      "durationMs": 123.0639999999994,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.188,
      "layouts": 9,
      "layoutDurationMs": 4.758,
      "taskDurationMs": 90.813,
      "heapDeltaBytes": 4620228,
      "heapUsedBytes": 64027564,
      "domNodes": 106,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 7.521999999999999,
      "eventListeners": 7,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.671428571428546,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 499.7769999999946,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 0.671,
      "layouts": 76,
      "layoutDurationMs": 15.405000000000001,
      "taskDurationMs": 461.86299999999994,
      "heapDeltaBytes": -4021688,
      "heapUsedBytes": 40913936,
      "domNodes": 4,
      "jsHeapTotalBytes": 2883584,
      "scriptDurationMs": 223.79,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66451612903227,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 472.69699999992554,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 0.644,
      "layouts": 76,
      "layoutDurationMs": 14.947999999999999,
      "taskDurationMs": 422.1,
      "heapDeltaBytes": -4358148,
      "heapUsedBytes": 39778056,
      "domNodes": 4,
      "jsHeapTotalBytes": 3407872,
      "scriptDurationMs": 204.51,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665517241379316,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 549.6100000000297,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 3.281,
      "layouts": 76,
      "layoutDurationMs": 15.155,
      "taskDurationMs": 515.432,
      "heapDeltaBytes": 1226060,
      "heapUsedBytes": 99402644,
      "domNodes": 4,
      "jsHeapTotalBytes": 266240,
      "scriptDurationMs": 201.60999999999999,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.169696969696982,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 684.6580000000131,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 2.181,
      "layouts": 76,
      "layoutDurationMs": 16.605999999999998,
      "taskDurationMs": 653.774,
      "heapDeltaBytes": 2926500,
      "heapUsedBytes": 101098812,
      "domNodes": 4,
      "jsHeapTotalBytes": 790528,
      "scriptDurationMs": 277.423,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.073170731707318,
      "p95FrameDurationMs": 16.699999999999818
    }
  ]
}

🎭 Playwright: ✅ 3121 passed, 0 failed · 3 flaky

📊 Browser Reports
  • chromium: View Report (✅ 2319 / ❌ 0 / ⚠️ 3 / ⏭️ 0)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • cloud: View Report (✅ 771 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • desktop: View Report (✅ 6 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 19 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-safari: View Report (✅ 3 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/28/2026, 05:32:19 AM UTC

Links

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

No verdict is available. Open the workflow run to confirm the check was intentionally skipped, or fix the collection failure and re-run it.

Findings and check details

The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

Findings and check details

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since c8a9443a0c1f38f88ebfeec48898fe816005df94

Full docs: ADR-DEVEX-LINT-0015

🏛️ Architecture: ✅ Passed

Findings and check details

Warnings (217)

  • workspace path matches no source files: src/platform/workspace/fixtures/**. Remove or update it in docs/architecture/domains/records/workspace.domain.json.
  • src/components/graph/selectionToolbox/LinkSelectionActions.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/searchbox/v2/filterChip.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/Popover.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.stories.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardFooter.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardHeader.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/card.variants.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/graph/menuOption.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useLiveGraphNode.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useLiveGraphNode.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/litegraphServiceAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/nodeDef/ComfyNodeDefImpl.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupEnforcementBoundary.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/legacyUI/attachLegacyUI.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/selection/selectionIntent.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/agentPanel.historyIdentity.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/cloudBadges.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/dynamicPrompts.serializeValue.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/electronAdapter.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/index.cloud.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/index.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/cameraInfo.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/findNumericWidget.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dHost.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dHost.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dInstances.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dLazy.retry.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dSettings.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dWidgets.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dWidgets.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/reportLoadModelOutcome.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/reportLoadModelOutcome.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/slotDefaults.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/touchCanvasAccess.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/touchCanvasAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/touchPointerGuards.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/i18n.literalMessages.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/ContextMenu.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/LGraphCanvas.startRendering.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/LiteGraphGlobal.cloneObject.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • …and 167 more
Reproduce locally
pnpm architecture:check

Full docs: Frontend domain catalog

@christian-byrne
christian-byrne enabled auto-merge (squash) October 28, 2026 05:40
@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 28, 2026
@codecov

codecov Bot commented Oct 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.59   #22130   +/-   ##
=============================================
  Coverage              ?   87.63%           
=============================================
  Files                 ?     2787           
  Lines                 ?   154957           
  Branches              ?    42143           
=============================================
  Hits                  ?   135798           
  Misses                ?    18485           
  Partials              ?      674           
Flag Coverage Δ
unit 86.38% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne
christian-byrne merged commit e05ecb7 into cloud/1.59 Oct 28, 2026
111 checks passed
@christian-byrne
christian-byrne deleted the fix/cloud-1.59-3d-viewer-locale branch October 28, 2026 05:48
christian-byrne added a commit that referenced this pull request Nov 1, 2026
…59.3 bump

`lint-pr / lint` fails on this carrier with

    'commands.Comfy_3DViewer_Open3DViewer' does not exist in localization
    message resources  @intlify/vue-i18n/no-missing-keys

in `src/components/graph/selectionToolbox/Load3DViewerButton.vue`, which
fails `preflight` and so reports `lint-and-format`, `test` and `e2e-status`
as failures without any of them running.

The failure is inherited, not introduced here: the component, the catalog and
the ESLint config are byte-identical to `cloud/1.59`, and the sibling carrier
#22538 fails on the same two lines. The key was restored on `cloud/1.59` by
#22130 and the 1.59.3 version bump (#22137) regenerated the locale JSON and
dropped it again.

Restores the same three lines, so `src/locales/en/commands.json` is now
byte-identical (blob 412dbd0) to the tree #22130 merged. No product
behavior changes.
christian-byrne added a commit to hphproton/ComfyUI_frontend that referenced this pull request Nov 1, 2026
…sh entry (Comfy-Org#22576)

## Summary

Locale collection rewrites `src/locales/en/commands.json` from the
commands the running app has
registered, so a command whose extension had not loaded is pruned.
Nothing fails at that moment,
because ESLint caches on file content and config rather than on catalog
content — so the prune
reaches a release branch and only surfaces later as an
`@intlify/vue-i18n/no-missing-keys` error in
an unrelated pull request.

`Comfy.3DViewer.Open3DViewer` has been through that cycle three times:
pruned by the 1.59.2 bump,
restored by Comfy-Org#22130, pruned again by the 1.59.3 bump (`342a87f0d9`), and
fixed at the source for the
lazy 3D extension by Comfy-Org#22168. **The third prune is still live on
`cloud/1.59` and is currently
failing `lint-pr / lint` on six open carriers (Comfy-Org#22534–Comfy-Org#22539)** — which
is how it was found. Comfy-Org#22168
fixed collection for that one extension; nothing fails when it happens
to the next one.

This adds the missing mechanical check.
`scripts/check-command-locales.ts` reads command ids out of
the source tree with the TypeScript AST — `commands: [...]` on a
`ComfyExtension` and
`const commands = [...]` as `useCoreCommands` declares them — and
requires each one to keep a
`commands.<normalized id>.label` string. It needs neither a browser nor
a regeneration run, so it
works on any branch.

Two wiring points, for two different failure moments:

- **`i18n-update-core.yaml`, right after `pnpm collect-i18n`** — fails
the regeneration before the
pruned catalog is translated and committed. This is the step that
prunes, so failing here also
avoids spending OpenAI tokens on a catalog that is about to be rejected.
- **`repo-checks`** — catches an already-pruned branch on any pull
request. `locale:check` compares
the non-English catalogs against the English ones, so it cannot see a
key missing from the English
  catalog itself.

Non-obvious decisions:

- A computed id (`id: \`Comfy.${suffix}\``) cannot be resolved
statically. Those are counted and
  reported in the pass line rather than ignored silently or failed on.
- The reverse direction is deliberately not checked. The catalog carries
122 entries against 113
statically declared ids, because some commands are registered only at
runtime, so flagging
  catalog entries with no declaration would be false-positive-prone.
- Comfy-Org#22168's one-key output assertion in `collect-i18n-general.ts` is left
in place. This guard
subsumes it, but removing it is a separate call for that file's author.

## Verification

Red on the real broken states, green on the real repaired ones — not
only on fixtures.

| state | result |
| --- | --- |
| `main` at `ac70ad8a8c` | **pass** — 113 declared commands across 1661
files |
| `origin/cloud/1.59` at `122b615f36` (live) | **fail**, exit 1 —
`src/extensions/core/load3d/load3d.ts:60 command
'Comfy.3DViewer.Open3DViewer' has no
commands.Comfy_3DViewer_Open3DViewer entry` |
| same tree, with the 3-line entry restored | **pass** — 113 declared
commands |
| `342a87f0d9` (the 1.59.3 bump that pruned it) | **fail**, exit 1, same
single finding |
| `e05ecb7577` (Comfy-Org#22130's restore) | **pass** |

So the guard would have failed the version-bump PR that reintroduced the
defect, and fails the
release branch that still carries it, naming the declaration site rather
than a downstream call
site.

- Tests: `scripts/check-command-locales.test.ts`, 13 cases, hermetic
(temp-directory trees, no
network, no browser). Covers the AST cases — extension array, `const
commands`, `as const` /
`satisfies` unwrapping, a `menuCommands` reference array that must *not*
count as a declaration,
a computed id — and the catalog cases: missing entry, restored entry,
absent/blank/`tooltip`-only
label, duplicate declaration reported once, and test/`__tests__` files
skipped so a fixture
command needs no locale entry. `vitest run
scripts/check-command-locales.test.ts` → 13 passed.
- `pnpm typecheck:scripts` → exit 0. `pnpm knip` → exit 0. `pnpm
format:check` → all 6469 files
correct. `pnpm deps:audit`, `pnpm knip` and `pnpm fallow:audit` all pass
via the `pre-push` hook,
not bypassed. Both edited YAML files re-parsed and their step order
asserted.
- No manual repair is pushed to `cloud/1.59` or to Comfy-Org#22534–Comfy-Org#22539 here;
that is the release owner's
  call and is tracked separately.

## Related

- Comfy-Org#22168 (FE-3637) fixed collection for the lazy 3D extension; this adds
the check that fails when
  the same thing happens to another extension.
- Comfy-Org#22130 restored the entry the second time. Comfy-Org#22160 is complementary and
independent: it makes the
ESLint cache honest on `cloud/1.59` so the prune is *visible* sooner,
while this makes the
  regeneration refuse to produce it.
benceruleanlu pushed a commit that referenced this pull request Nov 2, 2026
…59.3 bump

`lint-pr / lint` fails on this carrier with

    'commands.Comfy_3DViewer_Open3DViewer' does not exist in localization
    message resources  @intlify/vue-i18n/no-missing-keys

in `src/components/graph/selectionToolbox/Load3DViewerButton.vue`, which
fails `preflight` and so reports `lint-and-format`, `test` and `e2e-status`
as failures without any of them running.

The failure is inherited, not introduced here: the component, the catalog and
the ESLint config are byte-identical to `cloud/1.59`, and the sibling carrier
#22538 fails on the same two lines. The key was restored on `cloud/1.59` by
#22130 and the 1.59.3 version bump (#22137) regenerated the locale JSON and
dropped it again.

Restores the same three lines, so `src/locales/en/commands.json` is now
byte-identical (blob 412dbd0) to the tree #22130 merged. No product
behavior changes.

(cherry picked from commit a358582)
benceruleanlu pushed a commit that referenced this pull request Nov 2, 2026
…59.3 bump

`lint-pr / lint` fails on this carrier with

    'commands.Comfy_3DViewer_Open3DViewer' does not exist in localization
    message resources  @intlify/vue-i18n/no-missing-keys

in `src/components/graph/selectionToolbox/Load3DViewerButton.vue`, which
fails `preflight` and so reports `lint-and-format`, `test` and `e2e-status`
as failures without any of them running.

The failure is inherited, not introduced here: the component, the catalog and
the ESLint config are byte-identical to `cloud/1.59`, and the sibling carrier
#22538 fails on the same two lines. The key was restored on `cloud/1.59` by
#22130 and the 1.59.3 version bump (#22137) regenerated the locale JSON and
dropped it again.

Restores the same three lines, so `src/locales/en/commands.json` is now
byte-identical (blob 412dbd0) to the tree #22130 merged. No product
behavior changes.

(cherry picked from commit a358582)
benceruleanlu pushed a commit that referenced this pull request Nov 2, 2026
…59.3 bump

`lint-pr / lint` fails on this carrier with

    'commands.Comfy_3DViewer_Open3DViewer' does not exist in localization
    message resources  @intlify/vue-i18n/no-missing-keys

in `src/components/graph/selectionToolbox/Load3DViewerButton.vue`, which
fails `preflight` and so reports `lint-and-format`, `test` and `e2e-status`
as failures without any of them running.

The failure is inherited, not introduced here: the component, the catalog and
the ESLint config are byte-identical to `cloud/1.59`, and the sibling carrier
#22538 fails on the same two lines. The key was restored on `cloud/1.59` by
#22130 and the 1.59.3 version bump (#22137) regenerated the locale JSON and
dropped it again.

Restores the same three lines, so `src/locales/en/commands.json` is now
byte-identical (blob 412dbd0) to the tree #22130 merged. No product
behavior changes.

(cherry picked from commit a358582)
benceruleanlu pushed a commit that referenced this pull request Nov 2, 2026
…59.3 bump

`lint-pr / lint` fails on this carrier with

    'commands.Comfy_3DViewer_Open3DViewer' does not exist in localization
    message resources  @intlify/vue-i18n/no-missing-keys

in `src/components/graph/selectionToolbox/Load3DViewerButton.vue`, which
fails `preflight` and so reports `lint-and-format`, `test` and `e2e-status`
as failures without any of them running.

The failure is inherited, not introduced here: the component, the catalog and
the ESLint config are byte-identical to `cloud/1.59`, and the sibling carrier
#22538 fails on the same two lines. The key was restored on `cloud/1.59` by
#22130 and the 1.59.3 version bump (#22137) regenerated the locale JSON and
dropped it again.

Restores the same three lines, so `src/locales/en/commands.json` is now
byte-identical (blob 412dbd0) to the tree #22130 merged. No product
behavior changes.

(cherry picked from commit a358582)
benceruleanlu pushed a commit that referenced this pull request Nov 2, 2026
…59.3 bump

`lint-pr / lint` fails on this carrier with

    'commands.Comfy_3DViewer_Open3DViewer' does not exist in localization
    message resources  @intlify/vue-i18n/no-missing-keys

in `src/components/graph/selectionToolbox/Load3DViewerButton.vue`, which
fails `preflight` and so reports `lint-and-format`, `test` and `e2e-status`
as failures without any of them running.

The failure is inherited, not introduced here: the component, the catalog and
the ESLint config are byte-identical to `cloud/1.59`, and the sibling carrier
#22538 fails on the same two lines. The key was restored on `cloud/1.59` by
#22130 and the 1.59.3 version bump (#22137) regenerated the locale JSON and
dropped it again.

Restores the same three lines, so `src/locales/en/commands.json` is now
byte-identical (blob 412dbd0) to the tree #22130 merged. No product
behavior changes.

(cherry picked from commit a358582)
benceruleanlu pushed a commit that referenced this pull request Nov 2, 2026
…59.3 bump

`lint-pr / lint` fails on this carrier with

    'commands.Comfy_3DViewer_Open3DViewer' does not exist in localization
    message resources  @intlify/vue-i18n/no-missing-keys

in `src/components/graph/selectionToolbox/Load3DViewerButton.vue`, which
fails `preflight` and so reports `lint-and-format`, `test` and `e2e-status`
as failures without any of them running.

The failure is inherited, not introduced here: the component, the catalog and
the ESLint config are byte-identical to `cloud/1.59`, and the sibling carrier
#22538 fails on the same two lines. The key was restored on `cloud/1.59` by
#22130 and the 1.59.3 version bump (#22137) regenerated the locale JSON and
dropped it again.

Restores the same three lines, so `src/locales/en/commands.json` is now
byte-identical (blob 412dbd0) to the tree #22130 merged. No product
behavior changes.

(cherry picked from commit a358582)
benceruleanlu pushed a commit that referenced this pull request Nov 2, 2026
…59.3 bump

`lint-pr / lint` fails on this carrier with

    'commands.Comfy_3DViewer_Open3DViewer' does not exist in localization
    message resources  @intlify/vue-i18n/no-missing-keys

in `src/components/graph/selectionToolbox/Load3DViewerButton.vue`, which
fails `preflight` and so reports `lint-and-format`, `test` and `e2e-status`
as failures without any of them running.

The failure is inherited, not introduced here: the component, the catalog and
the ESLint config are byte-identical to `cloud/1.59`, and the sibling carrier
#22538 fails on the same two lines. The key was restored on `cloud/1.59` by
#22130 and the 1.59.3 version bump (#22137) regenerated the locale JSON and
dropped it again.

Restores the same three lines, so `src/locales/en/commands.json` is now
byte-identical (blob 412dbd0) to the tree #22130 merged. No product
behavior changes.

(cherry picked from commit a358582)
benceruleanlu pushed a commit that referenced this pull request Nov 2, 2026
…59.3 bump

`lint-pr / lint` fails on this carrier with

    'commands.Comfy_3DViewer_Open3DViewer' does not exist in localization
    message resources  @intlify/vue-i18n/no-missing-keys

in `src/components/graph/selectionToolbox/Load3DViewerButton.vue`, which
fails `preflight` and so reports `lint-and-format`, `test` and `e2e-status`
as failures without any of them running.

The failure is inherited, not introduced here: the component, the catalog and
the ESLint config are byte-identical to `cloud/1.59`, and the sibling carrier
#22538 fails on the same two lines. The key was restored on `cloud/1.59` by
#22130 and the 1.59.3 version bump (#22137) regenerated the locale JSON and
dropped it again.

Restores the same three lines, so `src/locales/en/commands.json` is now
byte-identical (blob 412dbd0) to the tree #22130 merged. No product
behavior changes.

(cherry picked from commit a358582)
benceruleanlu pushed a commit that referenced this pull request Nov 2, 2026
…59.3 bump

`lint-pr / lint` fails on this carrier with

    'commands.Comfy_3DViewer_Open3DViewer' does not exist in localization
    message resources  @intlify/vue-i18n/no-missing-keys

in `src/components/graph/selectionToolbox/Load3DViewerButton.vue`, which
fails `preflight` and so reports `lint-and-format`, `test` and `e2e-status`
as failures without any of them running.

The failure is inherited, not introduced here: the component, the catalog and
the ESLint config are byte-identical to `cloud/1.59`, and the sibling carrier
#22538 fails on the same two lines. The key was restored on `cloud/1.59` by
#22130 and the 1.59.3 version bump (#22137) regenerated the locale JSON and
dropped it again.

Restores the same three lines, so `src/locales/en/commands.json` is now
byte-identical (blob 412dbd0) to the tree #22130 merged. No product
behavior changes.

(cherry picked from commit a358582)
christian-byrne added a commit that referenced this pull request Nov 6, 2026
…22160)

*PR Created by the Glary-Bot Agent*

---

## Summary
Fixes the post-merge `CI: Lint Format` failure on `cloud/1.59` ([run
40735633141](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/40735633141),
dad2af2). The failure came from a poisoned ESLint cache. The flaky-test
and infra explanations don't fit, and dad2af2 itself is not the cause.

**Failure:** `Verify ESLint` reports
`'commands.Comfy_3DViewer_Open3DViewer' does not exist in localization
message resources` in `Load3DViewerButton.vue`. The key does exist at
HEAD; #22130 restored it.

**Root cause:**
- `eslint --cache` keys each cache entry on the file's content plus its
resolved config. It never looks at the locale catalogs that
`@intlify/vue-i18n/no-missing-keys` reads.
- The c8a9443 run linted while the key was missing and cached the
error. `Save lint caches` runs with `if: always()`, so that cache was
saved anyway.
- Every run since then restored the cache. `Load3DViewerButton.vue`
hasn't changed, so ESLint replayed the stale error. That includes the
run for #22130 itself, and all six pushes from c8a9443 onward fail
with exactly this annotation.

**Fix:** hash the contents of each tree's catalogs into that tree's
ESLint `settings` (`comfy/i18nCatalogHash`). ESLint's per-file config
hash then changes whenever a catalog changes, which drops the stale
entries. This works both in CI, even when the cache is restored through
a fallback key, and in local runs.

## Verification
- **Reproduced locally** with `--cache --cache-strategy content` on
`Load3DViewerButton.vue`:
  1. Lint with c8a9443's `commands.json`: exit 1.
2. Restore HEAD's `commands.json` and lint again on the warm cache. With
the original config it still exits 1, which matches the CI failure. With
this change it exits 0.
- Full `eslint --concurrency auto`, `oxfmt --check` and `oxlint` all
pass.

Main has the same latent issue, so this may also be worth
forward-porting.

### Known trade-off: cold lint on catalog edits

The catalog hash lives in the per-file ESLint config, so editing any
hashed catalog (`src/locales/en/{main,commands,nodeDefs,settings}.json`,
`scripts/i18n/eslint-generated-messages.js`, or billing-web's
`main.json`) invalidates the ESLint cache for that whole tree, for every
rule. That includes slow ones like
`better-tailwindcss/enforce-canonical-classes`. PRs that touch
`src/locales/en/main.json` will run a cold `src/**` ESLint pass. We
accept that cost because otherwise cached `no-missing-keys` results go
stale.

Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants