Repository navigation
[backport cloud/1.57] fix: return values from vue-router navigation guards instead of calling next() - #23129
[backport cloud/1.57] fix: return values from vue-router navigation guards instead of calling next()#23129mattmillerai wants to merge 1 commit into
Conversation
…ng next() Backport of #21738 (guard half only). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 7 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-08T07:02:40.941Z",
"gitSha": "fe0802860325ec78250eb6abae796286c92c6253",
"branch": "matt/be-23756-backport-router-next-guards",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2009.9129999999832,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.1049999999999995,
"layouts": 11,
"layoutDurationMs": 1.941,
"taskDurationMs": 280.906,
"heapDeltaBytes": 22065420,
"heapUsedBytes": 87849148,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 5.953999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-idle",
"durationMs": 2010.089999999991,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.3560000000000003,
"layouts": 10,
"layoutDurationMs": 2.098,
"taskDurationMs": 279.77200000000005,
"heapDeltaBytes": 21995052,
"heapUsedBytes": 88831320,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 5.433999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1678.9170000000126,
"styleRecalcs": 71,
"styleRecalcDurationMs": 11.399,
"layouts": 10,
"layoutDurationMs": 2.0550000000000006,
"taskDurationMs": 488.128,
"heapDeltaBytes": -8244420,
"heapUsedBytes": 66694980,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 90.41300000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665346534653462,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1677.8860000000009,
"styleRecalcs": 71,
"styleRecalcDurationMs": 12.217000000000002,
"layouts": 10,
"layoutDurationMs": 2.2009999999999996,
"taskDurationMs": 490.25499999999994,
"heapDeltaBytes": 15151984,
"heapUsedBytes": 81618652,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 91.679,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665346534653462,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.7920000000167,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.316,
"layouts": 12,
"layoutDurationMs": 2.4299999999999997,
"taskDurationMs": 214.00500000000002,
"heapDeltaBytes": 19039320,
"heapUsedBytes": 85378200,
"domNodes": 47,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 7.187999999999998,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1710.6330000000298,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.213000000000001,
"layouts": 12,
"layoutDurationMs": 2.2720000000000002,
"taskDurationMs": 201.675,
"heapDeltaBytes": 18617796,
"heapUsedBytes": 84970668,
"domNodes": 47,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 6.185,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 432.25000000001046,
"styleRecalcs": 15,
"styleRecalcDurationMs": 2.793,
"layouts": 10,
"layoutDurationMs": 2.3569999999999998,
"taskDurationMs": 301.527,
"heapDeltaBytes": 1585580,
"heapUsedBytes": 76489816,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 103.321,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66538461538462,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 448.20299999997815,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.8979999999999997,
"layouts": 10,
"layoutDurationMs": 2.4869999999999997,
"taskDurationMs": 299.875,
"heapDeltaBytes": 25195564,
"heapUsedBytes": 91585616,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 105.262,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 894.9369999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 498.967,
"heapDeltaBytes": -3005056,
"heapUsedBytes": 81372024,
"domNodes": -192,
"jsHeapTotalBytes": 13115392,
"scriptDurationMs": 35.248,
"eventListeners": -105,
"totalBlockingTimeMs": 249,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 897.6160000000277,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 494.585,
"heapDeltaBytes": -12498732,
"heapUsedBytes": 81649604,
"domNodes": -192,
"jsHeapTotalBytes": 20455424,
"scriptDurationMs": 36.125,
"eventListeners": -106,
"totalBlockingTimeMs": 255,
"frameDurationMs": 25.714285714285715,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 702.4409999999932,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 256.4280000000001,
"heapDeltaBytes": -4312976,
"heapUsedBytes": 75522780,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 84.895,
"eventListeners": 0,
"totalBlockingTimeMs": 80,
"frameDurationMs": 20.58823529411765,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 702.7879999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 264.96299999999985,
"heapDeltaBytes": -4879924,
"heapUsedBytes": 76556392,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 83.74000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 86,
"frameDurationMs": 20.585294117647074,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 5321.139999999986,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.1549999999999998,
"layouts": 5,
"layoutDurationMs": 1.2550000000000001,
"taskDurationMs": 4405.582,
"heapDeltaBytes": -10857584,
"heapUsedBytes": 88219520,
"domNodes": -258,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 3612.031,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.956565656565655,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "extension-clean-combined-draw",
"durationMs": 5863.500000000045,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.6410000000000001,
"layouts": 3,
"layoutDurationMs": 0.5999999999999999,
"taskDurationMs": 4842.41,
"heapDeltaBytes": -2591628,
"heapUsedBytes": 96222052,
"domNodes": -258,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 3799.048,
"eventListeners": -67,
"totalBlockingTimeMs": 14,
"frameDurationMs": 18.166770186335405,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 5324.215000000009,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.1159999999999999,
"layouts": 4,
"layoutDurationMs": 0.899,
"taskDurationMs": 4440.698,
"heapDeltaBytes": 876416,
"heapUsedBytes": 100082124,
"domNodes": -258,
"jsHeapTotalBytes": 6418432,
"scriptDurationMs": 3494.326,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.147909967845656,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6511.366000000009,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8450000000000003,
"layouts": 3,
"layoutDurationMs": 0.7360000000000001,
"taskDurationMs": 5122.972,
"heapDeltaBytes": 10306424,
"heapUsedBytes": 104761548,
"domNodes": -278,
"jsHeapTotalBytes": 8777728,
"scriptDurationMs": 4081.849,
"eventListeners": -68,
"totalBlockingTimeMs": 24,
"frameDurationMs": 20.32941176470588,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "large-combo-open",
"durationMs": 137.03799999998978,
"styleRecalcs": 21,
"styleRecalcDurationMs": 11.282,
"layouts": 12,
"layoutDurationMs": 2.6109999999999998,
"taskDurationMs": 102.54899999999999,
"heapDeltaBytes": -8267156,
"heapUsedBytes": 79137556,
"domNodes": 917,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 5.858999999999999,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.76249999999999,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "large-combo-open",
"durationMs": 138.37100000000646,
"styleRecalcs": 22,
"styleRecalcDurationMs": 11.654000000000002,
"layouts": 13,
"layoutDurationMs": 3.0180000000000007,
"taskDurationMs": 103.32200000000002,
"heapDeltaBytes": -8965548,
"heapUsedBytes": 79214296,
"domNodes": 917,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 5.863000000000001,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.75,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "large-graph-idle",
"durationMs": 2025.845000000004,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.882,
"layouts": 10,
"layoutDurationMs": 1.8969999999999998,
"taskDurationMs": 358.84,
"heapDeltaBytes": -1514864,
"heapUsedBytes": 77006828,
"domNodes": -258,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 17.284999999999997,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2025.4489999999805,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.5519999999999996,
"layouts": 9,
"layoutDurationMs": 2.287,
"taskDurationMs": 425.872,
"heapDeltaBytes": -2022612,
"heapUsedBytes": 77884176,
"domNodes": -258,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 28.141999999999992,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2081.405000000018,
"styleRecalcs": 69,
"styleRecalcDurationMs": 6.993,
"layouts": 10,
"layoutDurationMs": 2.161,
"taskDurationMs": 914.8880000000001,
"heapDeltaBytes": -12864684,
"heapUsedBytes": 67524972,
"domNodes": -258,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 512.515,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665599999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2182.3330000000283,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.394,
"layouts": 9,
"layoutDurationMs": 2.149,
"taskDurationMs": 1080.355,
"heapDeltaBytes": -13055580,
"heapUsedBytes": 67539368,
"domNodes": -258,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 540.086,
"eventListeners": -65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666412213740458,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-zoom",
"durationMs": 3122.3030000000163,
"styleRecalcs": 72,
"styleRecalcDurationMs": 7.803,
"layouts": 66,
"layoutDurationMs": 10.543000000000001,
"taskDurationMs": 1086.338,
"heapDeltaBytes": -11381244,
"heapUsedBytes": 70097568,
"domNodes": -234,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 486.502,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66542553191489,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-zoom",
"durationMs": 3237.062999999978,
"styleRecalcs": 73,
"styleRecalcDurationMs": 7.941999999999999,
"layouts": 67,
"layoutDurationMs": 10.988,
"taskDurationMs": 1170.021,
"heapDeltaBytes": -7245376,
"heapUsedBytes": 74611228,
"domNodes": -234,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 525.777,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6659793814433,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2165.5350000000053,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.05,
"layouts": 6,
"layoutDurationMs": 1.4430000000000003,
"taskDurationMs": 1155.701,
"heapDeltaBytes": 10624764,
"heapUsedBytes": 93387832,
"domNodes": 0,
"jsHeapTotalBytes": 5398528,
"scriptDurationMs": 597.7470000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666153846153847,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2184.304999999995,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.411,
"layouts": 7,
"layoutDurationMs": 1.626,
"taskDurationMs": 1171.319,
"heapDeltaBytes": -1944488,
"heapUsedBytes": 81509680,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 604.9449999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665648854961834,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-idle",
"durationMs": 2005.687000000023,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.8149999999999997,
"layouts": 9,
"layoutDurationMs": 1.642,
"taskDurationMs": 360.86400000000003,
"heapDeltaBytes": -1899296,
"heapUsedBytes": 79071520,
"domNodes": -258,
"jsHeapTotalBytes": 1961984,
"scriptDurationMs": 18.424000000000003,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2005.0410000000056,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.0230000000000006,
"layouts": 10,
"layoutDurationMs": 1.766,
"taskDurationMs": 342.156,
"heapDeltaBytes": -3014436,
"heapUsedBytes": 78314272,
"domNodes": -258,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 17.461000000000002,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 398.0060000000094,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.702000000000001,
"layouts": 10,
"layoutDurationMs": 2.3510000000000004,
"taskDurationMs": 267.174,
"heapDeltaBytes": -1053156,
"heapUsedBytes": 75822416,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 92.059,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 431.2290000000303,
"styleRecalcs": 48,
"styleRecalcDurationMs": 4.711999999999999,
"layouts": 10,
"layoutDurationMs": 2.334,
"taskDurationMs": 278.897,
"heapDeltaBytes": 21569308,
"heapUsedBytes": 88625616,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 97.313,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669230769230772,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2009.7039999999993,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.0689999999999995,
"layouts": 10,
"layoutDurationMs": 1.9979999999999998,
"taskDurationMs": 272.822,
"heapDeltaBytes": 22436252,
"heapUsedBytes": 89230364,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 5.155,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2010.5769999999552,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.1260000000000003,
"layouts": 10,
"layoutDurationMs": 1.954,
"taskDurationMs": 278.58399999999995,
"heapDeltaBytes": -216704,
"heapUsedBytes": 76734424,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 4.909999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.1750000000054,
"styleRecalcs": 75,
"styleRecalcDurationMs": 12.168000000000001,
"layouts": 10,
"layoutDurationMs": 1.946,
"taskDurationMs": 468.75499999999994,
"heapDeltaBytes": 11262544,
"heapUsedBytes": 78494992,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 69.688,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.1809999999618,
"styleRecalcs": 75,
"styleRecalcDurationMs": 13.727,
"layouts": 9,
"layoutDurationMs": 2.019,
"taskDurationMs": 540.354,
"heapDeltaBytes": 11262120,
"heapUsedBytes": 78244548,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 82.332,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66534653465347,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 834.2369999999732,
"styleRecalcs": 19,
"styleRecalcDurationMs": 16.846000000000004,
"layouts": 5,
"layoutDurationMs": 9.985999999999999,
"taskDurationMs": 610.426,
"heapDeltaBytes": 7106036,
"heapUsedBytes": 105490132,
"domNodes": 15953,
"jsHeapTotalBytes": 17436672,
"scriptDurationMs": 18.197000000000003,
"eventListeners": 3244,
"totalBlockingTimeMs": 78,
"frameDurationMs": 19.379069767441866,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8238.35200000002,
"styleRecalcs": 251,
"styleRecalcDurationMs": 20.108,
"layouts": 9,
"layoutDurationMs": 1.9500000000000002,
"taskDurationMs": 3511.087,
"heapDeltaBytes": -16163056,
"heapUsedBytes": 80110332,
"domNodes": -258,
"jsHeapTotalBytes": 5894144,
"scriptDurationMs": 1752.011,
"eventListeners": -65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684207,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8133.60300000005,
"styleRecalcs": 250,
"styleRecalcDurationMs": 20.51,
"layouts": 9,
"layoutDurationMs": 1.91,
"taskDurationMs": 3430.422,
"heapDeltaBytes": 9801612,
"heapUsedBytes": 88276388,
"domNodes": -258,
"jsHeapTotalBytes": 4284416,
"scriptDurationMs": 1712.517,
"eventListeners": -65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66598360655738,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14439.853000000028,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13369.387999999999,
"heapDeltaBytes": 27038644,
"heapUsedBytes": 308807568,
"domNodes": -3330,
"jsHeapTotalBytes": 45604864,
"scriptDurationMs": 165.11599999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.67368421052631,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-idle",
"durationMs": 14451.371999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13311.315999999999,
"heapDeltaBytes": 2225400,
"heapUsedBytes": 293189136,
"domNodes": -3330,
"jsHeapTotalBytes": 14671872,
"scriptDurationMs": 173.101,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.325589225589226,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 14286.508999999967,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.2770000000000055,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13673.098999999998,
"heapDeltaBytes": -14052532,
"heapUsedBytes": 277381124,
"domNodes": -3330,
"jsHeapTotalBytes": 21225472,
"scriptDurationMs": 559.155,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.74820143884892,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 16834.902,
"styleRecalcs": 118,
"styleRecalcDurationMs": 9.997000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16411.127999999997,
"heapDeltaBytes": -13439824,
"heapUsedBytes": 268568300,
"domNodes": -3330,
"jsHeapTotalBytes": 9428992,
"scriptDurationMs": 548.76,
"eventListeners": -651,
"totalBlockingTimeMs": 4,
"frameDurationMs": 30.885688073394498,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "vue-node-resize-workload",
"durationMs": 5198.59299999996,
"styleRecalcs": 20,
"styleRecalcDurationMs": 46.35899999999998,
"layouts": 20,
"layoutDurationMs": 18.166,
"taskDurationMs": 5095.963,
"heapDeltaBytes": 13987860,
"heapUsedBytes": 286369376,
"domNodes": -3330,
"jsHeapTotalBytes": 31973376,
"scriptDurationMs": 69.88400000000001,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.866863905325438,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "vue-node-resize-workload",
"durationMs": 4973.264000000028,
"styleRecalcs": 20,
"styleRecalcDurationMs": 43.92,
"layouts": 20,
"layoutDurationMs": 17.148999999999997,
"taskDurationMs": 4856.762999999999,
"heapDeltaBytes": -11032948,
"heapUsedBytes": 286461968,
"domNodes": -3330,
"jsHeapTotalBytes": 34070528,
"scriptDurationMs": 63.877,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.200606060606063,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7156.252999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6541.1140000000005,
"heapDeltaBytes": 6743540,
"heapUsedBytes": 279060148,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 77.148,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 23.912040133779268,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6711.4500000000135,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6406.491000000001,
"heapDeltaBytes": -14653616,
"heapUsedBytes": 273647108,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 72.95800000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.313621262458476,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "workflow-execution",
"durationMs": 436.6380000000163,
"styleRecalcs": 17,
"styleRecalcDurationMs": 10.508,
"layouts": 12,
"layoutDurationMs": 3.4850000000000003,
"taskDurationMs": 88.088,
"heapDeltaBytes": 6901900,
"heapUsedBytes": 78676200,
"domNodes": 124,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 7.752,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384603,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 74.6359999999413,
"styleRecalcs": 5,
"styleRecalcDurationMs": 7.4559999999999995,
"layouts": 4,
"layoutDurationMs": 1.72,
"taskDurationMs": 55.628,
"heapDeltaBytes": -15373220,
"heapUsedBytes": 68528396,
"domNodes": 120,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 4.386,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.639999999999965,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 162.40800000002764,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.8009999999999999,
"layouts": 76,
"layoutDurationMs": 8.831,
"taskDurationMs": 129.327,
"heapDeltaBytes": 8403444,
"heapUsedBytes": 85812964,
"domNodes": 4,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 54.483999999999995,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000036,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 178.43199999992976,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.821,
"layouts": 76,
"layoutDurationMs": 9.193,
"taskDurationMs": 141.437,
"heapDeltaBytes": 8630796,
"heapUsedBytes": 100100228,
"domNodes": 4,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 60.697,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636382,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 231.35600000000522,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.388,
"layouts": 76,
"layoutDurationMs": 9.318,
"taskDurationMs": 189.29299999999998,
"heapDeltaBytes": -7462340,
"heapUsedBytes": 110016576,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 62.705999999999996,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428546,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 221.03299999992032,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.4020000000000001,
"layouts": 76,
"layoutDurationMs": 8.999,
"taskDurationMs": 190.085,
"heapDeltaBytes": -7480716,
"heapUsedBytes": 110574236,
"domNodes": 4,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 61.775000000000006,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428578,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage: 🟡 64.5% of linesCoverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2288 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 030cd36e7e50851196d421a23191f87825638fbd
Full docs: ADR-DEVEX-LINT-0015 |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @mattmillerai.
✅ No high-signal findings.
Panel: 6/6 reviewers contributed findings.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.57 #23129 +/- ##
=============================================
Coverage ? 83.78%
=============================================
Files ? 3076
Lines ? 162006
Branches ? 40846
=============================================
Hits ? 135736
Misses ? 25880
Partials ? 390
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
STACKED — merging lands on cloud/1.57 (release branch, no base-PR owner), NOT main
ELI5
A test file on the cloud 1.57 release branch printed hundreds of "this is deprecated" warnings on every run. Sometimes the test runner was still delivering them when it shut down, and it marked the whole job failed even though every test passed. This change makes the app's page-navigation checks use the current style (already the style on main), so the warnings, and the flaky failures they caused, go away.
Summary
Backport of the navigation-guard half of #21738 to
cloud/1.57. Each guard insrc/router.ts,preservedQueryTracker.tsandonboardingCloudRoutes.tsnow returns its result instead of calling the deprecatednext()callback:next()→return,next(false)→return false,next(location)→return location,next(await x)→return x. vue-router handles both forms the same way. The two guard test files are updated the same way #21738 updated them. The patch was applied by hand becausegit applyof #21738 fails on this branch (router.tshas drifted). The resulting hunks match #21738 line for line.DesktopCloudNotificationControllerparts of fix: silence self-inflicted startup console warnings #21738.Unified login mint failedconsole warning inworkspaceAuthStore.ts. That change is not repeated here.EnvironmentTeardownError: Closing rpc while "onUserConsoleLog" was pendingfailure this fixes was seen on [backport cloud/1.57] fix(agent): report a free-text-only answer that won elsewhere #21988.Merge Danger
Door: two-way
Blast Radius: routing (same as #21738).
mainalready runs this code.Verification
git grep -n -E '\bnext\(' -- src/router.ts src/platform/navigation/preservedQueryTracker.ts src/platform/cloud/onboarding/onboardingCloudRoutes.tsreturns nothing.VUE_ROUTER_R0025console logs, unchangedcloud/1.57→ this branch, counted with vitest--reporter=bloband a flatted walk overtasks[].logs:webSessionFlagOn.test.ts: 480 → 0 (the 2 logs left are the unrelatedUnified login mint failedand legacy-queue-menu warnings)preservedQueryTracker.test.ts: 36 → 0onboardingCloudRoutes.test.ts: 3 → 0vitest run src/router src/platform/auth src/platform/navigation src/platform/cloud/onboarding: 907/908 pass. The one failure (ssoRequiredInline.test.ts› "falls back to the dialog once the page is gone", 5s timeout) also fails on unmodifiedcloud/1.57.webSessionFlagOn.test.ts --sequence.shuffle --silent=false, 10 runs: noUnhandled Errorsblock and no R0025 in any run. Some shuffle orders fail on order-dependent SSO-hint assertions (the hint › an SSO session leaves its emailand siblings). Seeds 3 and 6 fail identically on unmodifiedcloud/1.57, so those failures come from the base branch, not this change.typecheck:app.isCloud,userStore,/user-select,/cloud, testbeforeEach). No doc describes thenext()guard style.Residual
pnpm test:unitrun reported 16 failing files that were never attributed. On this head, CI's unit shards (unit / test-shards,unit / test) all pass, so those local failures did not reproduce in CI.cloud/1.57, not fixed here:webSessionFlagOn.test.tsSSO-hint tests leak state between tests under--sequence.shuffle(seeds 3 and 6).ssoRequiredInline.test.ts› "falls back to the dialog once the page is gone" times out at 5s.Closing rpc while "onUserConsoleLog" was pendingrace was not reproduced directly. The fix was verified through the deterministic log count, as the ticket specified.Provenance
webSessionFlagOn.test.ts: 480 → 0 (blob reporter)lint-and-format,test,e2e-status) and all unit shards passpnpm test:unit -- <dirs>ran the full suite, so the green check usedvitest run <dirs>instead. The ticket asks to cite an internal tracker id; it is omitted because this repo is public.return next(await x)becamereturn x(the async guard returns the promise), exactly as fix: silence self-inflicted startup console warnings #21738 did, instead ofreturn await x.🤖 Generated with Claude Code