Repository navigation
[backport core/1.57] fix: harden workflow load against null initial state and report occurrences - #21974
Conversation
…rences (#21326) Tolerate a missing initial state or change tracker when activating a workflow, refuse to load stored content that is not a JSON object, refuse to save a workflow with no active state, and report each guard hit so the real trigger can be identified. (cherry picked from commit b31319c)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-26T16:59:06.859Z",
"gitSha": "cefd642a97ee47c12fd56cc3b4e228459ad16c30",
"branch": "backport-21326-to-core-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2008.9780000000133,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.01,
"layouts": 9,
"layoutDurationMs": 3.181,
"taskDurationMs": 369.082,
"heapDeltaBytes": 22152480,
"heapUsedBytes": 88017632,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 9.716,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2008.2140000000663,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.902999999999999,
"layouts": 9,
"layoutDurationMs": 2.9859999999999998,
"taskDurationMs": 374.444,
"heapDeltaBytes": 22172068,
"heapUsedBytes": 88060740,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 10.001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1781.8619999999896,
"styleRecalcs": 76,
"styleRecalcDurationMs": 15.546000000000001,
"layouts": 8,
"layoutDurationMs": 2.158,
"taskDurationMs": 874.7620000000001,
"heapDeltaBytes": 15636984,
"heapUsedBytes": 81007924,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 166.579,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666355140186912,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1994.0450000000283,
"styleRecalcs": 84,
"styleRecalcDurationMs": 16.309,
"layouts": 9,
"layoutDurationMs": 2.6830000000000003,
"taskDurationMs": 1104.835,
"heapDeltaBytes": -7802640,
"heapUsedBytes": 67033552,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 174.279,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665833333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.7820000000283,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.337000000000001,
"layouts": 11,
"layoutDurationMs": 2.9250000000000007,
"taskDurationMs": 399.124,
"heapDeltaBytes": -4534528,
"heapUsedBytes": 70859196,
"domNodes": 47,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 12.409,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1758.4170000000086,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.548000000000001,
"layouts": 12,
"layoutDurationMs": 2.9709999999999996,
"taskDurationMs": 299.67199999999997,
"heapDeltaBytes": 18699472,
"heapUsedBytes": 85024864,
"domNodes": 47,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 11.956000000000001,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666037735849056,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 693.3270000000107,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.1479999999999997,
"layouts": 10,
"layoutDurationMs": 2.9659999999999997,
"taskDurationMs": 504.696,
"heapDeltaBytes": 25634308,
"heapUsedBytes": 91954160,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 176.421,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853658,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 719.0970000000334,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.8269999999999995,
"layouts": 9,
"layoutDurationMs": 2.8690000000000007,
"taskDurationMs": 509.189,
"heapDeltaBytes": 25597308,
"heapUsedBytes": 91929740,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 176.655,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665116279069775,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1291.8160000000398,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 972.14,
"heapDeltaBytes": -11851220,
"heapUsedBytes": 81089180,
"domNodes": -192,
"jsHeapTotalBytes": 20193280,
"scriptDurationMs": 70.277,
"eventListeners": -106,
"totalBlockingTimeMs": 591,
"frameDurationMs": 34.68378378378377,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1196.454000000017,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 862.3009999999999,
"heapDeltaBytes": -11455824,
"heapUsedBytes": 81284860,
"domNodes": -192,
"jsHeapTotalBytes": 19144704,
"scriptDurationMs": 68.01899999999999,
"eventListeners": -106,
"totalBlockingTimeMs": 529,
"frameDurationMs": 33.333333333333336,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 843.7549999999874,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 493.74800000000005,
"heapDeltaBytes": -4334896,
"heapUsedBytes": 76540920,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 159.04800000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 216,
"frameDurationMs": 24.9970588235294,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 878.6589999999705,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 492.7130000000002,
"heapDeltaBytes": -4425088,
"heapUsedBytes": 75463332,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 161.407,
"eventListeners": 0,
"totalBlockingTimeMs": 218,
"frameDurationMs": 24.53611111111114,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11104.028000000028,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.3259999999999999,
"layouts": 1,
"layoutDurationMs": 0.38999999999999974,
"taskDurationMs": 10254.145999999999,
"heapDeltaBytes": 3520644,
"heapUsedBytes": 97440020,
"domNodes": -258,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 8343.045999999998,
"eventListeners": -68,
"totalBlockingTimeMs": 1244,
"frameDurationMs": 31.987031700288185,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9882.121999999981,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9032.067,
"heapDeltaBytes": -2643968,
"heapUsedBytes": 96894564,
"domNodes": -258,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 7247.056,
"eventListeners": -68,
"totalBlockingTimeMs": 757,
"frameDurationMs": 31.07861635220126,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10951.401999999973,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10192.553,
"heapDeltaBytes": 3078132,
"heapUsedBytes": 96998404,
"domNodes": -258,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 8359.935,
"eventListeners": -68,
"totalBlockingTimeMs": 1324,
"frameDurationMs": 31.555043227665706,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10097.645000000057,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9307.731,
"heapDeltaBytes": -11328860,
"heapUsedBytes": 83263788,
"domNodes": -258,
"jsHeapTotalBytes": 2486272,
"scriptDurationMs": 7525.299999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 902,
"frameDurationMs": 31.075692307692307,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 219.4650000000138,
"styleRecalcs": 22,
"styleRecalcDurationMs": 15.161,
"layouts": 11,
"layoutDurationMs": 3.166,
"taskDurationMs": 167.39000000000001,
"heapDeltaBytes": -7528972,
"heapUsedBytes": 80402284,
"domNodes": 917,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 8.719,
"eventListeners": 195,
"totalBlockingTimeMs": 3,
"frameDurationMs": 25.922222222222242,
"p95FrameDurationMs": 100
},
{
"name": "large-combo-open",
"durationMs": 236.28000000007887,
"styleRecalcs": 24,
"styleRecalcDurationMs": 15.591999999999999,
"layouts": 11,
"layoutDurationMs": 3.431,
"taskDurationMs": 175.716,
"heapDeltaBytes": -8157768,
"heapUsedBytes": 79741412,
"domNodes": 917,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 8.732,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 23.33000000000002,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "large-graph-idle",
"durationMs": 2055.432000000053,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.9290000000000003,
"layouts": 8,
"layoutDurationMs": 2.8840000000000003,
"taskDurationMs": 711.0880000000001,
"heapDeltaBytes": -25455968,
"heapUsedBytes": 72317340,
"domNodes": -258,
"jsHeapTotalBytes": 5931008,
"scriptDurationMs": 37.382999999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2056.2479999999823,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.68,
"layouts": 8,
"layoutDurationMs": 2.5869999999999997,
"taskDurationMs": 659.832,
"heapDeltaBytes": -2865704,
"heapUsedBytes": 77455668,
"domNodes": -278,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 35.172000000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2572.954999999979,
"styleRecalcs": 69,
"styleRecalcDurationMs": 6.466,
"layouts": 7,
"layoutDurationMs": 1.8629999999999995,
"taskDurationMs": 1736.5000000000002,
"heapDeltaBytes": 12146612,
"heapUsedBytes": 92204496,
"domNodes": -278,
"jsHeapTotalBytes": 4284416,
"scriptDurationMs": 840.9100000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601307189542,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2504.444000000035,
"styleRecalcs": 67,
"styleRecalcDurationMs": 5.929,
"layouts": 5,
"layoutDurationMs": 1.2199999999999998,
"taskDurationMs": 1760.9260000000002,
"heapDeltaBytes": -6550884,
"heapUsedBytes": 91462740,
"domNodes": -278,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 858.254,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.891216216216215,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3688.6610000000246,
"styleRecalcs": 71,
"styleRecalcDurationMs": 7.752999999999999,
"layouts": 64,
"layoutDurationMs": 10.651000000000002,
"taskDurationMs": 1804.033,
"heapDeltaBytes": -9872816,
"heapUsedBytes": 72254040,
"domNodes": -254,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 796.848,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.741818181818182,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3554.758000000106,
"styleRecalcs": 69,
"styleRecalcDurationMs": 7.747,
"layouts": 63,
"layoutDurationMs": 10.773,
"taskDurationMs": 1558.953,
"heapDeltaBytes": 1467756,
"heapUsedBytes": 82971968,
"domNodes": 24,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 783.815,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666197183098593,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3073.5579999999914,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.492999999999999,
"layouts": 7,
"layoutDurationMs": 1.9030000000000007,
"taskDurationMs": 1992.57,
"heapDeltaBytes": 4693584,
"heapUsedBytes": 82752744,
"domNodes": 0,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 979.076,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.849450549450548,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3252.3700000000417,
"styleRecalcs": 43,
"styleRecalcDurationMs": 4.964000000000001,
"layouts": 4,
"layoutDurationMs": 1.199,
"taskDurationMs": 2101.0809999999997,
"heapDeltaBytes": 8372624,
"heapUsedBytes": 87311524,
"domNodes": -278,
"jsHeapTotalBytes": 4476928,
"scriptDurationMs": 1010.3279999999999,
"eventListeners": -63,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.752331606217616,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2056.081000000006,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.077000000000001,
"layouts": 7,
"layoutDurationMs": 1.886,
"taskDurationMs": 669.683,
"heapDeltaBytes": -21005664,
"heapUsedBytes": 77337344,
"domNodes": -258,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 36.303999999999995,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2043.472999999949,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.309,
"layouts": 7,
"layoutDurationMs": 2.3630000000000004,
"taskDurationMs": 687.884,
"heapDeltaBytes": -2479320,
"heapUsedBytes": 79699000,
"domNodes": -258,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 40.842,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 662.3890000000188,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.398,
"layouts": 9,
"layoutDurationMs": 2.5460000000000003,
"taskDurationMs": 487.002,
"heapDeltaBytes": -1079416,
"heapUsedBytes": 75985136,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 148.95,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 560.7539999999744,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.897,
"layouts": 9,
"layoutDurationMs": 2.6010000000000004,
"taskDurationMs": 386.374,
"heapDeltaBytes": 20302564,
"heapUsedBytes": 87308924,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 155.074,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2006.8539999999757,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.053,
"layouts": 9,
"layoutDurationMs": 2.91,
"taskDurationMs": 540.351,
"heapDeltaBytes": -262344,
"heapUsedBytes": 76833192,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 10.402999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2023.6730000000307,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.744999999999999,
"layouts": 9,
"layoutDurationMs": 2.823,
"taskDurationMs": 532.117,
"heapDeltaBytes": 22416616,
"heapUsedBytes": 90167800,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 9.136,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1966.2800000000402,
"styleRecalcs": 86,
"styleRecalcDurationMs": 17.342,
"layouts": 10,
"layoutDurationMs": 2.705,
"taskDurationMs": 1056.0510000000002,
"heapDeltaBytes": 15283416,
"heapUsedBytes": 92231808,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 117.21699999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666101694915252,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.4159999999665,
"styleRecalcs": 77,
"styleRecalcDurationMs": 15.928,
"layouts": 9,
"layoutDurationMs": 2.742,
"taskDurationMs": 864.027,
"heapDeltaBytes": -7340908,
"heapUsedBytes": 69744112,
"domNodes": 0,
"jsHeapTotalBytes": 12058624,
"scriptDurationMs": 116.782,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1066.8099999999185,
"styleRecalcs": 19,
"styleRecalcDurationMs": 27.644999999999996,
"layouts": 5,
"layoutDurationMs": 14.322999999999999,
"taskDurationMs": 826.0850000000002,
"heapDeltaBytes": 9291508,
"heapUsedBytes": 117133772,
"domNodes": 15953,
"jsHeapTotalBytes": 19795968,
"scriptDurationMs": 27.516000000000005,
"eventListeners": 3244,
"totalBlockingTimeMs": 161,
"frameDurationMs": 21.332000000000008,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8360.443000000032,
"styleRecalcs": 249,
"styleRecalcDurationMs": 18.87,
"layouts": 6,
"layoutDurationMs": 1.823,
"taskDurationMs": 5312.394,
"heapDeltaBytes": 603552,
"heapUsedBytes": 79660168,
"domNodes": -258,
"jsHeapTotalBytes": 4546560,
"scriptDurationMs": 2815.951,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.79979919678715,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9054.511999999932,
"styleRecalcs": 249,
"styleRecalcDurationMs": 19.535,
"layouts": 7,
"layoutDurationMs": 2.0010000000000003,
"taskDurationMs": 5973.968,
"heapDeltaBytes": -10901404,
"heapUsedBytes": 68566492,
"domNodes": -278,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 2733.046,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69686346863469,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 24229.007000000023,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23472.364,
"heapDeltaBytes": -25231608,
"heapUsedBytes": 265742636,
"domNodes": -3330,
"jsHeapTotalBytes": 13094912,
"scriptDurationMs": 361.194,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.60756013745704,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-idle",
"durationMs": 23237.919000000034,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22832.701,
"heapDeltaBytes": 8954680,
"heapUsedBytes": 290487084,
"domNodes": -3330,
"jsHeapTotalBytes": 16502784,
"scriptDurationMs": 343.277,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.986919104991394,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-large-graph-pan",
"durationMs": 28710.217999999997,
"styleRecalcs": 181,
"styleRecalcDurationMs": 18.16999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28359.513,
"heapDeltaBytes": -34890092,
"heapUsedBytes": 265708644,
"domNodes": -3330,
"jsHeapTotalBytes": 10473472,
"scriptDurationMs": 930.216,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 53.17666666666666,
"p95FrameDurationMs": 100.10000000000582
},
{
"name": "vue-large-graph-pan",
"durationMs": 28112.847999999984,
"styleRecalcs": 181,
"styleRecalcDurationMs": 15.649999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27716.934,
"heapDeltaBytes": -11976440,
"heapUsedBytes": 264537224,
"domNodes": -3330,
"jsHeapTotalBytes": 7852032,
"scriptDurationMs": 898.197,
"eventListeners": -651,
"totalBlockingTimeMs": 21,
"frameDurationMs": 51.87361623616237,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-node-resize-workload",
"durationMs": 6140.29800000003,
"styleRecalcs": 20,
"styleRecalcDurationMs": 71.82,
"layouts": 20,
"layoutDurationMs": 22.360000000000007,
"taskDurationMs": 5982.181,
"heapDeltaBytes": -17720956,
"heapUsedBytes": 277908208,
"domNodes": -3330,
"jsHeapTotalBytes": 22269952,
"scriptDurationMs": 107.31000000000002,
"eventListeners": -653,
"totalBlockingTimeMs": 16,
"frameDurationMs": 33.88397790055249,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6249.770000000012,
"styleRecalcs": 20,
"styleRecalcDurationMs": 75.33300000000001,
"layouts": 20,
"layoutDurationMs": 24.06399999999999,
"taskDurationMs": 6141.463000000001,
"heapDeltaBytes": -61139368,
"heapUsedBytes": 240376004,
"domNodes": -3330,
"jsHeapTotalBytes": 4706304,
"scriptDurationMs": 95.99999999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 18,
"frameDurationMs": 35.309604519774005,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11710.847000000058,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11458.415,
"heapDeltaBytes": -11358448,
"heapUsedBytes": 250282900,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 163.47299999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.06712328767123,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11467.006999999967,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11285.208,
"heapDeltaBytes": 8532264,
"heapUsedBytes": 258946256,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 159.77700000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.95071428571429,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "workflow-execution",
"durationMs": 144.34899999992012,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.443,
"layouts": 8,
"layoutDurationMs": 2.9290000000000003,
"taskDurationMs": 105.392,
"heapDeltaBytes": 4602476,
"heapUsedBytes": 77357720,
"domNodes": 97,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.457000000000003,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.23333333333335,
"p95FrameDurationMs": 50
},
{
"name": "workflow-execution",
"durationMs": 486.76800000009735,
"styleRecalcs": 19,
"styleRecalcDurationMs": 18.189,
"layouts": 13,
"layoutDurationMs": 5.200000000000001,
"taskDurationMs": 144.496,
"heapDeltaBytes": 6765300,
"heapUsedBytes": 79474660,
"domNodes": 121,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.814000000000002,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.241379310344843,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 628.9869999999382,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.388,
"layouts": 76,
"layoutDurationMs": 17.543,
"taskDurationMs": 584.722,
"heapDeltaBytes": -19713228,
"heapUsedBytes": 74433156,
"domNodes": 4,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 283.874,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 569.6699999999737,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.088,
"layouts": 76,
"layoutDurationMs": 17.369,
"taskDurationMs": 519.96,
"heapDeltaBytes": -20552124,
"heapUsedBytes": 71376672,
"domNodes": 4,
"jsHeapTotalBytes": 12845056,
"scriptDurationMs": 250.22,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 517.9970000000367,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.4,
"layouts": 76,
"layoutDurationMs": 13.696,
"taskDurationMs": 473.89599999999996,
"heapDeltaBytes": -284164,
"heapUsedBytes": 118402168,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 186.525,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.206451612903216,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 591.7590000000246,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.091,
"layouts": 76,
"layoutDurationMs": 15.368,
"taskDurationMs": 551.809,
"heapDeltaBytes": 374048,
"heapUsedBytes": 131831568,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 227.76000000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 64.7% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2283 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 8d7bb487c2740a3a771d65faff19fcfc30147fab
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.57 #21974 +/- ##
==========================================
Coverage 84.13% 84.14%
==========================================
Files 2842 2842
Lines 158223 158280 +57
Branches 40674 40692 +18
==========================================
+ Hits 133116 133177 +61
+ Misses 24718 24714 -4
Partials 389 389
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Independent review at 040637ebc720: faithful backport, red-to-green proven on core/1.57, no findings.
- Changed lines byte-identical to #21326 (
b31319ca5c); only offsets and the absentlateCustomNodescontext differ. - New e2e spec: red on the
core/1.57tip build with the production errors, green 3/3 on this head. Hosted run green too. - Not approving or merging: this is shared workflow code, outside the program's Agent-only backport grant. Needs a release-owner approval and merge.
Full context for agent readers
Exact state reviewed
- Head
040637ebc7203ff20def9c6d24eeffd1e42cfd65, basecore/1.57@8d7bb487c2740a3a771d65faff19fcfc30147fab(ancestor of head, 1 commit ahead). - Program gate
check-merge-ready.sh --target-branch core/1.57: MERGE READY. 140 checks completed with success/neutral/skipped only; requiredlint-and-format,test,e2e-statuspass; no review threads.
Backport fidelity
diffof the+/-lines ofgit diff b31319ca^ b31319caagainstgit diff 040637eb^ 040637eb: identical, 9 files, +969/-58 on both.- The only hunk-level difference is the
vi.mockblock inworkflowService.test.ts: the two@/platform/lateCustomNodes/*mocks were context lines onmain, not lines the source added, and that module does not exist oncore/1.57. Nothing the source added was dropped.
Black-box proof on this release line (local, CI-style: VITE_USE_LEGACY_DEFAULT_GRAPH=true production build served by comfyui-ci-container:0.0.27 --front-end-root, chromium project, --retries=0)
core/1.57tip with the four source files reverted to base:workflowNullStoredContent.spec.tsfails 2/2, page errorsCannot read properties of null (reading 'nodes')and(reading 'extra')- the CLOUD-FRONTEND-PROD-2Z2/-2Z3 signatures.- This head: passes 3/3 (
--repeat-each=3). - Hosted:
playwright-video-new-testsran the spec on this head, 1 passed (14.8 s); chromium/cloud sharded suites green. - Unit:
vitest run src/platform/workflow src/scripts/changeTracker.test.tsat this head, 64 files, 1238 passed, 1 expected fail.
Diff review (fail-closed constraint)
ComfyWorkflow.load()refuses stored content that is not a JSON object; the stored file is not rewritten. The spec asserts the stored text staysnulland the draft survives.save()/saveAs()throw before writing when there is no active state, soJSON.stringify(null)cannot be persisted.closeWorkflowclearsisModifiedonly on the persisted branch afterunload(); nothing recoverable is lost.openWorkflowloads an active-but-unloaded instance instead of returning it as loaded.- Telemetry context is booleans/enums only; dedupe key uses the path without sending it.
- Known tradeoff carried from the source:
assertthrows in DEV builds, so the guards surface rather than recover in dev. Production builds recover, which is what the spec runs against. - No other code on
core/1.57matches the replaced error strings.
Not done
- No approval: the reviewing identity is
christian-byrne, and approving under it from an agent would manufacture a human approval. - No merge: the program's release-backport grant covers Agent-related sources or proved prerequisites; #21326 is shared workflow-load code.
cursor-reviewnot applied (account currently returns empty panels).
Requested via Slack thread
Before: if a workflow became the active one without its change tracker ever loading, activating it threw
Cannot read properties of null (reading 'extra')(and a siblingreading 'nodes'of null inChangeTracker.graphEqual). A save from that state could also writenullover the stored workflow file.After: the missing state is tolerated where it is read, an unloaded workflow is loaded instead of being returned as loaded, a save from an unloaded workflow is refused, and each guard hit is reported with enough structure to identify the real trigger.
Manual backport of #21326 (the automatic backport hit conflicts).
Conflict resolved:
src/platform/workflow/core/services/workflowService.test.tsonly, in thevi.mockblock near the top. Kept the new@/base/assertmock and dropped the twolateCustomNodesmocks, since that module does not exist on this branch. The cherry-pick commit message was reworded; no code changes beyond the original PR.Local checks: typecheck (app and browser), oxfmt, oxlint and eslint on touched files, and vitest for
src/platform/workflowandsrc/scripts/changeTracker(64 files, 1238 passed). The new Playwright specbrowser_tests/tests/workflowNullStoredContent.spec.tsis included but was only typechecked locally, not run.Generated by Claude Code