Repository navigation
[backport cloud/1.57] refactor(workflow): report user-initiated tab activations - #21921
christian-byrne wants to merge 1 commit into
Conversation
Extracted from #21512 so the shared workflow and topbar paths can be reviewed without the 6,400-line Agent feature attached. **Nothing user-visible changes in this PR.** Two related changes to the workflow service: 1. **An explicit `initiator: 'user'` option** on `openWorkflow`, `loadNextOpenedWorkflow`, `loadPreviousOpenedWorkflow` and the new `closeWorkflows`, plus a `workflowStore.onUserActivation` event hook that fires only for those calls. The nine call sites that are genuinely a user clicking a tab, a menu item or a keybinding now pass it. Programmatic activations — including the page-hash restore on first load, which is retargeted from `'route'` to a new `'restore'` intent source — deliberately do not. **Nothing subscribes to the hook yet**, so it is inert until #21512 lands on top. 2. **`workflowService.closeWorkflows()`**, which absorbs the close-many loop that `WorkflowTabs.vue` and `BaseWorkflowsSidebarTab.vue` each reimplemented (break on the first close that returns false). Doing it in the service is what makes the batch report *at most one* user activation: `closeWorkflow` reports the replacement tab it opened through a new `onReplacementOpened` callback, and `closeWorkflows` reports only the replacement still active once the whole batch settles. The `closeWorkflows` consolidation is not a drive-by tidy-up. A per-tab close loop in the caller cannot tell "the user closed four tabs and landed on tab five" from "the user activated five tabs in a row", because each intermediate `closeWorkflow` opens a replacement. Moving the loop into the service is the only place that sees the whole batch, so the activation semantics and the consolidation have to land together. - `workflowService.ts` — the `closeWorkflows` `try`/`finally`, specifically that the `initiator === 'user' && workflowStore.isActive(replacement)` guard is what suppresses the superseded intermediate replacements. - `subgraphNavigationStore.ts` — the `'route'` → `'restore'` split on the initial-load intent. This is the one behavioural judgement call here: a restored page hash opens a workflow, and that is not a user activation. Explanatory comments in `workflowService.ts` and `subgraphNavigationStore.ts` that #21512 dropped are preserved here. - **Unit tests:** 235 passing across the 5 changed suites, including a new `describe('user activations')` block in `workflowService.test.ts` (+177) covering: a user-initiated open reports; a failed load does not report; a batch close reports once; a tab something else activated mid-close does not report; a superseded replacement does not report; and an earlier close's tab is still reported when a later close throws. New `subgraphNavigationStore` case asserts a restored page hash opens the workflow *without* `initiator: 'user'`. - **No-regression sweep:** 1,291 further tests passing across the 24 other suites that exercise `openWorkflow`/`closeWorkflow`, including the Agent suites (`AgentPanelRoot.test.ts`, 647 tests) that mock the service. - **Commit gates:** app typecheck, scoped type-aware oxlint, eslint, stylelint, oxfmt, server-facts — all clean. Push gates: Fallow changed-line audit clean on all 15 files. - Base at verification: `479cecf9ac9c98ad65b6aca186775793a7d30bc6`. - **#21512 is the dependent.** It carries the Agent tab→chat follow feature (PM-1270, PM-1257) that consumes `onUserActivation`. These hunks will drop out of its diff when it rebases after this merges. - No new user-facing strings, no i18n change, no Agent paths touched. --------- Co-authored-by: christian-byrne <chrbyrne96@gmail.com>
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-24T22:48:38.975Z",
"gitSha": "f8267a33c4eb28b6938f1d0a57604ee07a03dad5",
"branch": "backport-21791-to-cloud-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2009.0120000000127,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.111999999999999,
"layouts": 10,
"layoutDurationMs": 2.817,
"taskDurationMs": 386.982,
"heapDeltaBytes": 3226244,
"heapUsedBytes": 78568320,
"domNodes": 0,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 11.100999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-idle",
"durationMs": 2008.7360000000558,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.8869999999999998,
"layouts": 9,
"layoutDurationMs": 1.819,
"taskDurationMs": 280.51599999999996,
"heapDeltaBytes": 22130216,
"heapUsedBytes": 88416768,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 5.925,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1678.5819999999774,
"styleRecalcs": 71,
"styleRecalcDurationMs": 14.324000000000002,
"layouts": 10,
"layoutDurationMs": 2.469,
"taskDurationMs": 588.483,
"heapDeltaBytes": -3327584,
"heapUsedBytes": 71659480,
"domNodes": 0,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 114.361,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1943.5550000000035,
"styleRecalcs": 81,
"styleRecalcDurationMs": 13.397,
"layouts": 11,
"layoutDurationMs": 2.294,
"taskDurationMs": 738.213,
"heapDeltaBytes": 15561924,
"heapUsedBytes": 81867088,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 102.31099999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66581196581197,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.8169999999868,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.706999999999999,
"layouts": 10,
"layoutDurationMs": 3.0820000000000003,
"taskDurationMs": 280.309,
"heapDeltaBytes": 18758052,
"heapUsedBytes": 84527876,
"domNodes": 47,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 11.652,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.524999999985,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.439,
"layouts": 11,
"layoutDurationMs": 2.432,
"taskDurationMs": 236.51200000000003,
"heapDeltaBytes": 19093864,
"heapUsedBytes": 85421656,
"domNodes": 47,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 8.344,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665048543689323,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 526.6979999999819,
"styleRecalcs": 16,
"styleRecalcDurationMs": 3.4000000000000004,
"layouts": 12,
"layoutDurationMs": 3.3809999999999993,
"taskDurationMs": 347.55199999999996,
"heapDeltaBytes": 3485504,
"heapUsedBytes": 78987096,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 113.41999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66562499999999,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 449.4900000000257,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.8489999999999998,
"layouts": 10,
"layoutDurationMs": 2.357,
"taskDurationMs": 299.736,
"heapDeltaBytes": -1034676,
"heapUsedBytes": 65214088,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 104.40299999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1022.4609999999927,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 670.608,
"heapDeltaBytes": -2004588,
"heapUsedBytes": 81362964,
"domNodes": -192,
"jsHeapTotalBytes": 14426112,
"scriptDurationMs": 39.619,
"eventListeners": -106,
"totalBlockingTimeMs": 353,
"frameDurationMs": 28.238888888888898,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 940.5459999999835,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 572.1480000000001,
"heapDeltaBytes": -12733788,
"heapUsedBytes": 81439256,
"domNodes": -192,
"jsHeapTotalBytes": 19931136,
"scriptDurationMs": 44.087999999999994,
"eventListeners": -105,
"totalBlockingTimeMs": 291,
"frameDurationMs": 26.386111111111113,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 715.3219999999862,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 305.1139999999997,
"heapDeltaBytes": -4735256,
"heapUsedBytes": 76173316,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 97.69199999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 98,
"frameDurationMs": 21.079411764705878,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 702.3639999999887,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 269.54800000000034,
"heapDeltaBytes": -5233944,
"heapUsedBytes": 75760484,
"domNodes": 0,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 87.58399999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 87,
"frameDurationMs": 20.58823529411765,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6725.480000000005,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.784,
"layouts": 3,
"layoutDurationMs": 0.7659999999999998,
"taskDurationMs": 5494.706,
"heapDeltaBytes": -14321616,
"heapUsedBytes": 85661524,
"domNodes": -258,
"jsHeapTotalBytes": 8253440,
"scriptDurationMs": 4346.302,
"eventListeners": -68,
"totalBlockingTimeMs": 18,
"frameDurationMs": 21.860714285714288,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-clean-combined-draw",
"durationMs": 5989.395000000002,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.8789999999999996,
"layouts": 3,
"layoutDurationMs": 0.755,
"taskDurationMs": 4900.8769999999995,
"heapDeltaBytes": -20314008,
"heapUsedBytes": 74294332,
"domNodes": -258,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 3850.044,
"eventListeners": -68,
"totalBlockingTimeMs": 19,
"frameDurationMs": 19.168690095846646,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6129.173000000009,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.351999999999999,
"layouts": 2,
"layoutDurationMs": 0.9990000000000003,
"taskDurationMs": 4765.382,
"heapDeltaBytes": 23350640,
"heapUsedBytes": 101017880,
"domNodes": -258,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 3800.185,
"eventListeners": -68,
"totalBlockingTimeMs": 16,
"frameDurationMs": 20.524832214765098,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6293.948999999998,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.0409999999999995,
"layouts": 4,
"layoutDurationMs": 1.0579999999999998,
"taskDurationMs": 5163.437999999999,
"heapDeltaBytes": -25951200,
"heapUsedBytes": 73110388,
"domNodes": -258,
"jsHeapTotalBytes": 7467008,
"scriptDurationMs": 4008.964000000001,
"eventListeners": -67,
"totalBlockingTimeMs": 14,
"frameDurationMs": 19.148328267477204,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "large-combo-open",
"durationMs": 161.79800000000455,
"styleRecalcs": 22,
"styleRecalcDurationMs": 13.366999999999999,
"layouts": 12,
"layoutDurationMs": 3.176,
"taskDurationMs": 117.021,
"heapDeltaBytes": -9296860,
"heapUsedBytes": 79237388,
"domNodes": 917,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 6.394,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.44285714285713,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "large-combo-open",
"durationMs": 136.43799999999828,
"styleRecalcs": 21,
"styleRecalcDurationMs": 11.601999999999999,
"layouts": 12,
"layoutDurationMs": 2.7230000000000003,
"taskDurationMs": 101.14999999999999,
"heapDeltaBytes": -8176372,
"heapUsedBytes": 79110188,
"domNodes": 917,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 5.975000000000001,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.75,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "large-graph-idle",
"durationMs": 2025.7839999999874,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.4420000000000006,
"layouts": 8,
"layoutDurationMs": 2.1399999999999997,
"taskDurationMs": 404.55500000000006,
"heapDeltaBytes": -2376400,
"heapUsedBytes": 76537872,
"domNodes": -258,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 26.173000000000002,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66475409836065,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2026.3029999999844,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.712,
"layouts": 9,
"layoutDurationMs": 1.6610000000000003,
"taskDurationMs": 368.24300000000005,
"heapDeltaBytes": -2238952,
"heapUsedBytes": 77537556,
"domNodes": -258,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 23.156999999999996,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-pan",
"durationMs": 2547.7730000000065,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.205,
"layouts": 8,
"layoutDurationMs": 2.197,
"taskDurationMs": 1248.704,
"heapDeltaBytes": -11773348,
"heapUsedBytes": 68158392,
"domNodes": -258,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 573.745,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666013071895424,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-pan",
"durationMs": 2182.132000000024,
"styleRecalcs": 69,
"styleRecalcDurationMs": 7.501999999999999,
"layouts": 8,
"layoutDurationMs": 1.986,
"taskDurationMs": 1139.113,
"heapDeltaBytes": -12142332,
"heapUsedBytes": 68164636,
"domNodes": -258,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 558.292,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666923076923077,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3736.8060000000014,
"styleRecalcs": 74,
"styleRecalcDurationMs": 9.386999999999999,
"layouts": 67,
"layoutDurationMs": 12.255,
"taskDurationMs": 1370.511,
"heapDeltaBytes": -17843520,
"heapUsedBytes": 80987068,
"domNodes": -234,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 574.477,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666367713004483,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3139.1199999999913,
"styleRecalcs": 74,
"styleRecalcDurationMs": 8.366000000000001,
"layouts": 68,
"layoutDurationMs": 11.135,
"taskDurationMs": 1159.844,
"heapDeltaBytes": -10967592,
"heapUsedBytes": 70591660,
"domNodes": -234,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 509.4289999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666137566137564,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2575.212000000022,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.903,
"layouts": 6,
"layoutDurationMs": 1.5250000000000004,
"taskDurationMs": 1453.4699999999998,
"heapDeltaBytes": 2181072,
"heapUsedBytes": 80185904,
"domNodes": 0,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 722.361,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.77467532467532,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "legacy-node-drag",
"durationMs": 2366.6430000000105,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.896000000000001,
"layouts": 7,
"layoutDurationMs": 1.7149999999999999,
"taskDurationMs": 1333.1360000000002,
"heapDeltaBytes": 2327564,
"heapUsedBytes": 79845792,
"domNodes": 0,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 656.131,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665957446808513,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-idle",
"durationMs": 2051.1620000000335,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.7990000000000004,
"layouts": 8,
"layoutDurationMs": 2.4229999999999996,
"taskDurationMs": 463.299,
"heapDeltaBytes": -2232044,
"heapUsedBytes": 79759772,
"domNodes": -258,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 30.711000000000002,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406507,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2031.3669999999888,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.915,
"layouts": 9,
"layoutDurationMs": 1.841,
"taskDurationMs": 385.40200000000004,
"heapDeltaBytes": -2678344,
"heapUsedBytes": 75795776,
"domNodes": -258,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 22.744,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 530.1220000000058,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.5200000000000005,
"layouts": 10,
"layoutDurationMs": 2.688,
"taskDurationMs": 313.455,
"heapDeltaBytes": 3598620,
"heapUsedBytes": 81028884,
"domNodes": 0,
"jsHeapTotalBytes": 12320768,
"scriptDurationMs": 103.962,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 393.4639999999945,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.009000000000001,
"layouts": 8,
"layoutDurationMs": 2.1769999999999996,
"taskDurationMs": 255.739,
"heapDeltaBytes": 19777612,
"heapUsedBytes": 86888096,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 96.893,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2009.6770000000106,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.224,
"layouts": 10,
"layoutDurationMs": 2.8330000000000006,
"taskDurationMs": 341.472,
"heapDeltaBytes": 22423504,
"heapUsedBytes": 89306840,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 8.705,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2016.17200000004,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.5789999999999997,
"layouts": 8,
"layoutDurationMs": 1.522,
"taskDurationMs": 281.03900000000004,
"heapDeltaBytes": 22459364,
"heapUsedBytes": 89345956,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 5.37,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.3579999999981,
"styleRecalcs": 75,
"styleRecalcDurationMs": 15.917,
"layouts": 9,
"layoutDurationMs": 2.3200000000000003,
"taskDurationMs": 617.8999999999999,
"heapDeltaBytes": 11271344,
"heapUsedBytes": 78251960,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 95.90499999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66534653465347,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1678.1449999999722,
"styleRecalcs": 76,
"styleRecalcDurationMs": 12.899999999999999,
"layouts": 10,
"layoutDurationMs": 2.222,
"taskDurationMs": 492.63199999999995,
"heapDeltaBytes": 11641156,
"heapUsedBytes": 78735040,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 74.209,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 850.6489999999758,
"styleRecalcs": 20,
"styleRecalcDurationMs": 16.234,
"layouts": 5,
"layoutDurationMs": 9.321000000000002,
"taskDurationMs": 622.3570000000001,
"heapDeltaBytes": 5302532,
"heapUsedBytes": 100662528,
"domNodes": 15953,
"jsHeapTotalBytes": 18751488,
"scriptDurationMs": 17.431999999999995,
"eventListeners": 3244,
"totalBlockingTimeMs": 75,
"frameDurationMs": 18.88888888888889,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9225.259999999991,
"styleRecalcs": 250,
"styleRecalcDurationMs": 24.71,
"layouts": 8,
"layoutDurationMs": 2.2190000000000003,
"taskDurationMs": 4377.892,
"heapDeltaBytes": 12597764,
"heapUsedBytes": 91607560,
"domNodes": -258,
"jsHeapTotalBytes": 4022272,
"scriptDurationMs": 1990.755,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666064981949457,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8227.062999999987,
"styleRecalcs": 250,
"styleRecalcDurationMs": 22.144000000000002,
"layouts": 10,
"layoutDurationMs": 2.3109999999999995,
"taskDurationMs": 3793.5130000000004,
"heapDeltaBytes": -12107800,
"heapUsedBytes": 68468340,
"domNodes": -278,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 1937.9270000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.73373983739837,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17176.05199999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16515.916,
"heapDeltaBytes": -4002332,
"heapUsedBytes": 272479700,
"domNodes": -307,
"jsHeapTotalBytes": 19128320,
"scriptDurationMs": 246.594,
"eventListeners": -7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.802256944444448,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-large-graph-idle",
"durationMs": 16493.041000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15534.027999999998,
"heapDeltaBytes": -12401804,
"heapUsedBytes": 264608656,
"domNodes": -3330,
"jsHeapTotalBytes": 16506880,
"scriptDurationMs": 210.552,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.127303754266208,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-pan",
"durationMs": 15443.370999999956,
"styleRecalcs": 76,
"styleRecalcDurationMs": 10.355000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15005.991000000002,
"heapDeltaBytes": -17893092,
"heapUsedBytes": 277535444,
"domNodes": -3330,
"jsHeapTotalBytes": 24109056,
"scriptDurationMs": 658.5909999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.868521739130433,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 18373.20199999999,
"styleRecalcs": 141,
"styleRecalcDurationMs": 13.038000000000022,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18030.168,
"heapDeltaBytes": -20530068,
"heapUsedBytes": 275106044,
"domNodes": -3330,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 617.6389999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 31,
"frameDurationMs": 34.52236842105263,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 4995.9319999999825,
"styleRecalcs": 20,
"styleRecalcDurationMs": 50.41799999999999,
"layouts": 20,
"layoutDurationMs": 25.121999999999993,
"taskDurationMs": 4849.468,
"heapDeltaBytes": 10118628,
"heapUsedBytes": 291707748,
"domNodes": -3330,
"jsHeapTotalBytes": 39313408,
"scriptDurationMs": 82.733,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.471428571428568,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-node-resize-workload",
"durationMs": 5955.309000000057,
"styleRecalcs": 20,
"styleRecalcDurationMs": 48.491999999999976,
"layouts": 20,
"layoutDurationMs": 21.038999999999987,
"taskDurationMs": 5855.424999999999,
"heapDeltaBytes": 1800388,
"heapUsedBytes": 293288300,
"domNodes": -3330,
"jsHeapTotalBytes": 30396416,
"scriptDurationMs": 89.91300000000001,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.4878612716763,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8507.181000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8112.910000000001,
"heapDeltaBytes": -4426084,
"heapUsedBytes": 272299464,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 109.933,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.91054421768707,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7476.503999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7145.531,
"heapDeltaBytes": 23195656,
"heapUsedBytes": 285854352,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 89.47899999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.6573883161512,
"p95FrameDurationMs": 50
},
{
"name": "workflow-execution",
"durationMs": 79.81100000000652,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.557,
"layouts": 5,
"layoutDurationMs": 1.946,
"taskDurationMs": 52.956,
"heapDeltaBytes": 4576936,
"heapUsedBytes": 77675940,
"domNodes": 120,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.135000000000001,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000036,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 76.40100000003258,
"styleRecalcs": 6,
"styleRecalcDurationMs": 7.6129999999999995,
"layouts": 5,
"layoutDurationMs": 1.7059999999999997,
"taskDurationMs": 48.377,
"heapDeltaBytes": 4387472,
"heapUsedBytes": 77239512,
"domNodes": 116,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 3.347,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000036,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 314.6270000000868,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.313,
"layouts": 76,
"layoutDurationMs": 14.82,
"taskDurationMs": 286.012,
"heapDeltaBytes": -20997924,
"heapUsedBytes": 70623096,
"domNodes": 4,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 126.473,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663157894736862,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 192.8930000000264,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.8720000000000001,
"layouts": 76,
"layoutDurationMs": 10.305,
"taskDurationMs": 159.054,
"heapDeltaBytes": 8791596,
"heapUsedBytes": 85126976,
"domNodes": 4,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 67.54400000000001,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 243.19600000001174,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.451,
"layouts": 76,
"layoutDurationMs": 9.654,
"taskDurationMs": 205.603,
"heapDeltaBytes": 25854356,
"heapUsedBytes": 139906560,
"domNodes": 4,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 67.976,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.673333333333357,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 329.0380000000823,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.598,
"layouts": 76,
"layoutDurationMs": 12.074,
"taskDurationMs": 291.51,
"heapDeltaBytes": -6452356,
"heapUsedBytes": 111646748,
"domNodes": 4,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 105.286,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E Coverage
🎭 Playwright: ✅ 2285 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (21 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 7aebefb8863f5bb2f1fec9222979301a5269839b
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## cloud/1.57 #21921 +/- ##
=============================================
Coverage ? 85.20%
=============================================
Files ? 2522
Lines ? 132975
Branches ? 38270
=============================================
Hits ? 113303
Misses ? 19256
Partials ? 416
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
Closing: cloud.comfy.org now serves cloud/1.58, so cloud/1.57 won't be redeployed. |
Pull request was closed
…) with its CNV06 fix (#22792) (#22865) Backport of workflow chat-follow (#21791 + #21512) to `core/1.58`, **together with the FRONT-3804 fix (#22792)** for the regression chat-follow introduced (agent edits to a background tab only appeared after a reload, frontend 1.60 QA check CNV06). Shipping one without the other would put that regression on the stable line, so this PR carries the whole chain. Decision (2026-11-05): take option 2 from the earlier draft, the full stack, because ComfyUI now pins 1.58.5, so `core/1.58` is the line Core and Desktop users get, and the release owner asked for the backport. The stack turned out smaller than estimated: #21686 is not needed (see below). ## Why `core/1.58` and not the lines the original ask named The ask was "backport chat-follow to 1.58/1.59 so cloud and desktop users get it". Measured against branch ancestry and the live distribution surfaces on 2026-11-03: | Surface | What serves it | Chat-follow (#21791 + #21512) | |---|---|---| | Cloud production | `cloud/1.59` (`frontend-version.json` `releaseBranch`, rotated 2026-10-31); serves commit `072c3c1140` | **already present**, but that commit predates the CNV06 fix (#22813) | | Cloud testcloud | `cloud/1.60` (`testcloudBranch`, rotated 2026-11-03) | **already present** | | Core / Desktop pin | `core/1.58`: `ComfyUI` master pins `comfyui-frontend-package==1.58.5` since Comfy-Org/ComfyUI#17442 merged 2026-11-04 | absent before this PR | | `core/1.59`, `core/1.60` | tagged `v1.59.0` / `v1.60.0` on GitHub; PyPI has only `.dev` builds of these lines, and ComfyUI does not pin them | already present | So **cloud users already have chat-follow**; the gap is Core/Desktop only. `core/1.58` is the line chosen here because it is the newest stable package line and the one the open `ComfyUI` pin bump targets. Retired lines were excluded on the release owner's own stated grounds: `thedatalife` closed #21922/#21923 with "the 1.56 release line is finished and won't get another patch" and #21921 with "cloud.comfy.org now serves cloud/1.58, so cloud/1.57 won't be redeployed" — by the same rule `cloud/1.58` is now superseded by `cloud/1.59`. ## What is carried, in dependency order All four are `cherry-pick -x` from `main`, original authorship preserved. 1. **#20827** — `fix(agent): load every page of Chat history` (41 files, +1197/−434). Required: `core/1.58` forked from `main` on 2026-10-19 and lacks `useAgentChatHistoryRefresh`, `agentThreadList` and the paged `/api/agent/threads?*` client that #21512 modifies. Three conflicts, all incidental: two spec files took the landed `core/1.59` content for the files whose only 1.58→1.59 delta is this PR, and one import union in `agentRestClient.test.ts` aligned to the `@/workbench/...` form 1.59 uses. 2. **#21147** — `fix(agent-crdt): bind the session to the workflow a reload restored (FE-1969)` (9 files, +688/−36). Required: #21512 calls `onWorkflowRestoredAndBound`, and `hasUnsyncedHumanOps` is the guard the follow bind reuses. One conflict, a declaration-order union in `useAgentWorkflowSelection.ts` resolved to the order `core/1.59` landed. 3. **#21791** — `refactor(workflow): report user-initiated tab activations` (17 files, +473/−84, byte-identical stat to `main`). One conflict: `openWorkflow`'s options object, where 1.58 has `keepSavedBaseline` and this PR adds `initiator`. Both kept. 4. **#21512** — `feat(agent): carry workflow chat follow onto current main` (49 files). Seven conflicts; each resolution is stated below. ### #21512 conflict resolutions - `agentConversationStore.ts` (5) — 1.58 carries the snapshot-turn work (`unreconciledSnapshotTurns`, `snapshotTurnSettled`, `publishSnapshotMessage`) that `main` has since renamed. Declarations and the exported surface are unions in `core/1.59`'s order; `replacedSlot` is adopted alongside `unreconciledSnapshotTurns.clear()`; and the transport publish callback **keeps 1.58's `publishSnapshotMessage`**, which does `replaceActive` *plus* announcing a reconcilable snapshot turn, rather than narrowing to `publishMessage`. - `useAgentSession.ts` (1) — took #21512's `openThread`/`outlivedItsNavigation` rewrite with `boundWorkflowId.value = null; rememberedWorkflowId = null` replaced by 1.58's `forgetBinding()` helper (from #22518/#22697). The result is byte-identical to `core/1.59`'s `loadThread`. - `AgentPanelRoot.vue` (2) — import superset, and the `custom-title` fallback through `historyGroups.current`. - `RunNoticeBanner.vue` (2) — **narrow adaptation.** Added the `followFailed` context and the `liveness`/`contextAction` computeds, but **not** `genericNoticeReady` or the `visible` computed: those belong to a different PR that is not on this train, and 1.58's template already gates on `context || !dismissed`. Nothing chat-follow needs is dropped. - `AgentPanel.ts` fixture (2) — added only `historyButton`; `loadFailedMessage`/`loadRetryButton` appeared in the conflict as context from a PR not on this train and are unused here, so they are not introduced. `userMessageBubbles` **was** added (same reason, but the carried specs do use it). - `agentConversationFixture.ts` (1) — took the canvas-relative `canvasOps.click`; `comfyPage.canvas` and `comfyPage.canvasOps` both exist on this train. - `AgentPanelRoot.tabActivity.test.ts` — **path adaptation only.** 1.58 predates the billing module move: `@/platform/billing/composables/useBillingCapabilities` → `@/platform/workspace/composables/useBillingCapabilities`, `@/platform/billing/composables/useBillingContext` → `@/composables/billing/useBillingContext`, `@/platform/billing/subscription/composables/useAccountPreconditionDialog` → `@/platform/cloud/subscription/composables/useAccountPreconditionDialog`. Same three modules `AgentPanelRoot.vue` already imports on this branch. - Seven assertions in `AgentPanelRoot.test.ts` and `useAgentWorkflowSelection.test.ts` were updated to the behaviour the carried commits define, matching `core/1.59` exactly: four `expect(await restoration).toBe(true)` sites became `WorkflowRestoration`-shaped (#21147 changed that return type), and three chat-title tests now expect the server-assigned title (`'build a duck'`, `'my masterpiece'`) rather than `agent.newChatTitle`, which is #21512's own PM-2098 change. These are #21512's and #21147's own test updates; they failed to apply because the surrounding file differs on this train. ### Added on 2026-11-05: the FRONT-3804 chain 5. **#21497** `test: pin agent wire identity across a /ws reconnect` (test harness only). One conflict in `agentFollowerHostSocket.ts`: took #21497's per-connection `sid` and doc comment; 1.58 already had the `comfyConnections` counter from its PM-2123 backport. 6. **#21964** `test(agent): prove a document reset keeps other workflows' mint cursors` (test harness only). Applied clean. 7. **#22596** `fix(agent-crdt): track unconfirmed bind targets as unsynced (FRONT-3581)`. Three conflicts, all from `retrySubscription` and the dynamic-combo test scenario, neither on this train: added only `noteUnboundLocalIntent` to the follower surface; kept 1.58's `workflowByUnsettledOpId` settle bookkeeping and renamed `workflowsWithLostOps` to `workflowsWithUnsyncedOps` as #22596 does; in `docOpMinter.test.ts` added only the `unboundLocalIntents` counter. The new tests do not use the dynamic-combo scenario, so **#21686 is not carried**. 8. **#22792** `fix(agent): bind the workflow a followed chat opens (FRONT-3804)`. One conflict (`retrySubscription` again, dropped). `AgentPanelRoot.vue`, `docOpMinter.ts`, the fixture and the new spec applied clean. 9. `test(agent): import the workflow schema from its core/1.58 path`: the new fixture imported `@comfyorg/graph-model/workflowSchema`, a package 1.58 predates; it now uses `@/platform/workflow/validation/schemas/workflowSchema` like the other 1.58 fixtures. 10. **Rebased 2026-11-05 onto `core/1.58` after #22943** (empty composer on New Chat / draft across refresh). Two conflicts, both resolved to `main`'s and `core/1.59`'s shape: `onNewChat` keeps `retireFollow()` first and then the `history_back` branch, and `agentComposerStore.test.ts` keeps both the "draft presence" and "draft persistence" blocks in `main`'s order. One follow-up commit drops a duplicate `hasDraft` key in the composer store's returned object (both PRs added it; `main` has one). ## Verification - Before the rebase, at `928aaa2bc7`: `pnpm typecheck` and `pnpm typecheck:browser` pass (Node 26). - Vitest, 701 tests in 7 files, all pass: `AgentPanelRoot`, `docOpMinter`, `unsyncedHumanOps`, `followerProductGate`, `crossWorkflowPending`, `agentFollowerHostSocket`, `useAgentWorkflowChatFollow`. - The earlier four commits' 1945-test focused run (27 files) passed at `c10dbfe073`, before the chain was added. - Black-box: `browser_tests/tests/agent/agentBackgroundTabEditsLand.spec.ts` (CNV06 step 5) plus the chat-follow specs `agentTabActivationFollowsChat` and `agentTabChatTransitions` run in this PR's `@cloud` e2e shards. On `main` the CNV06 spec was red at the regressing commit 1a6324c and green with #22792 (see #22792). ## Delivery - **Core / Desktop:** the 1.58.6 release PR (#22908) is open on `core/1.58`. This PR merges first so 1.58.6 carries it; Core and Desktop get it when ComfyUI's pin moves to 1.58.6. - **Cloud:** chat-follow is already on `cloud/1.59` and `cloud/1.60`. The CNV06 fix is merged on both (#22813, #22806) but cloud production still serves `072c3c1140`, which predates it. The open production canary (Comfy-Org/cloud#17917) starts from a `cloud/1.59` tip that includes #22813. Testcloud builds `cloud/1.60` on every push, so it already carries #22806. Known limit, unchanged by this PR: an edit made by hand while a tab is not bound keeps that tab's follow bind refused until a reload plus a turn (the #22596 marker lifecycle). The owner decision is recorded on #22792; the in-session recovery design is #22801. --------- Co-authored-by: Ryan Di <ryan.weihao.di@gmail.com> Co-authored-by: christian-byrne <chrbyrne96@gmail.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: mrseek-reviews[bot] <337131926+mrseek-reviews[bot]@users.noreply.github.com>
Backport of #21791 to
cloud/1.57.The automated cherry-pick conflicted only in
subgraphNavigationStore.ts. This repair preserves the release branch’s direct workflow-service access and applies #21791’s activation-source contract: route navigation reports user intent, initial restoration does not, and workflow opens receive the matching initiator.Validation: 250 focused tests pass across subgraph navigation, workflow service, workflow tabs, and workflow actions; formatting and app typecheck pass.