Repository navigation
feat(workspace): only a ready deployment can be picked in the Run on menu (DES-1279) - #21858
Conversation
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Derive readiness and notes src/platform/workspace/composables/useDeploymentRows.ts, src/locales/en/main.json, src/platform/workspace/components/DeploymentSwitcher.test.ts |
Rows expose whether a deployment is pickable and combine status explanations with compatibility details. Only ready deployments are pickable. Tests cover status notes and selection behavior. |
Render row notes and state src/platform/workspace/components/DeploymentSwitcherList.vue, src/platform/workspace/components/DeploymentSwitcherRow.vue, src/platform/workspace/components/DeploymentSwitcherRow.stories.ts, src/platform/workspace/components/DeploymentSwitcher.test.ts |
The list passes row-specific notes and disabled or muted state to each row. Rows use notes for accessible descriptions and tooltips. Stories and tests cover row presentation and state. |
Priority:
Estimated code review effort: 3 (Moderate) | ~20 minutes
Change: Feature
Possibly related PRs
- Comfy-Org/ComfyUI_frontend#21836: Introduces
useDeploymentRowsand deployment-row data extended by this change. - Comfy-Org/ComfyUI_frontend#21148: Introduces the
DeploymentSwitcherselection flow updated by this change. - Comfy-Org/ComfyUI_frontend#22080: Changes the row and composable contracts for deployment details and compatibility notes.
Suggested reviewers: christian-byrne, deepme987
Merge Risk: 
Low · up to 95a25
-
The deployment behavior is guarded at runtime, but broader readiness-state tests should be added to prevent regressions.
Pre-merge checks: 
5 · 
1
-
Failed checks: 1 warning Passed checks: 5 passed-
Full details: Adr Compliance For Entity/Litegraph Changes
-
Explanation
The changed files are under
src/locales/en/andsrc/platform/workspace/components/andsrc/platform/workspace/composables/. None are undersrc/lib/litegraph/,src/ecs/, or related graph-entity paths. The ADR check does not apply.
Full details: Description check
-
Explanation
The pull request description follows the required Summary and Verification sections. It clearly explains the behavior change, design decisions, testing results, browser verification, known scope, and screenshots. The optional issue-reference line is not required.
-
Full details: End-To-End Test Suggestion For User-Facing Changes
-
Explanation
Suggestion, not a merge requirement. The PR changes the user-facing deployment picker under
src/: only ready deployments can be selected, and non-ready rows show status reasons. The changed files include no spec underbrowser_tests/for this feature.Resolution
Add or extend a spec under
browser_tests/: - Open the Run on deployment menu. - Verify that a ready deployment can be selected. - Verify that a non-ready deployment is disabled. - Verify that selecting a non-ready deployment does not switch deployments. - Verify that the non-ready row shows its status reason.
-
Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
📦 Bundle: 11.9 MB gzip 🔴 +264 BDetailsSummary
Category Glance App Entry Points — 6.66 kB (baseline 6.66 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 2.57 MB (baseline 2.57 MB) • 🔴 +1.66 kBGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 149 kB (baseline 149 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 12 added / 12 removed / 6 unchanged Panels & Settings — 872 kB (baseline 872 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 14 added / 14 removed / 21 unchanged User & Accounts — 154 kB (baseline 154 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 10 added / 10 removed / 7 unchanged Editors & Dialogs — 502 kB (baseline 502 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 11 added / 11 removed / 6 unchanged UI Components — 343 kB (baseline 343 kB) • ⚪ 0 BReusable component library chunks
Status: 8 added / 8 removed / 22 unchanged Data & Services — 1.83 MB (baseline 1.83 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 35 added / 35 removed / 6 unchanged Utilities & Hooks — 2.44 MB (baseline 2.44 MB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 50 added / 50 removed / 35 unchanged Vendor & Third-Party — 9.69 MB (baseline 9.69 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 34.8 MB (baseline 34.8 MB) • 🔴 +415 BBundles that do not match a named category
Status: 114 added / 114 removed / 630 unchanged ⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-29T02:42:54.676Z",
"gitSha": "d826c093d8d1888c1a3e37a000b49933e52c5c7a",
"branch": "willie/des-1279-comfyui_frontend-only-ready-deployments-can-be-picked",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2007.364999999993,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.4420000000000006,
"layouts": 8,
"layoutDurationMs": 2.234,
"taskDurationMs": 530.745,
"heapDeltaBytes": 1431976,
"heapUsedBytes": 62624940,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 7.812000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2023.7539999999399,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.077,
"layouts": 10,
"layoutDurationMs": 3.057000000000001,
"taskDurationMs": 554.106,
"heapDeltaBytes": 1457224,
"heapUsedBytes": 62755132,
"domNodes": 0,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 8.86,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1791.0200000000032,
"styleRecalcs": 77,
"styleRecalcDurationMs": 12.753,
"layouts": 9,
"layoutDurationMs": 2.4050000000000002,
"taskDurationMs": 861.465,
"heapDeltaBytes": 22276324,
"heapUsedBytes": 83719816,
"domNodes": 0,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 158.143,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666355140186912,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1808.0569999999625,
"styleRecalcs": 76,
"styleRecalcDurationMs": 13.111999999999998,
"layouts": 8,
"layoutDurationMs": 2.548,
"taskDurationMs": 894.795,
"heapDeltaBytes": 21410616,
"heapUsedBytes": 82639640,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 164.714,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666666,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1690.870000000018,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.563000000000001,
"layouts": 10,
"layoutDurationMs": 2.52,
"taskDurationMs": 411.847,
"heapDeltaBytes": -1848000,
"heapUsedBytes": 59681112,
"domNodes": 57,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 10.745000000000001,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.6430000000146,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.907000000000001,
"layouts": 11,
"layoutDurationMs": 2.8609999999999998,
"taskDurationMs": 423.153,
"heapDeltaBytes": 358916,
"heapUsedBytes": 70802780,
"domNodes": 57,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 10.242999999999999,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 678.0369999999607,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.7439999999999998,
"layouts": 9,
"layoutDurationMs": 2.4879999999999995,
"taskDurationMs": 498.02599999999995,
"heapDeltaBytes": 6552608,
"heapUsedBytes": 77006476,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 171.99,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66500000000001,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 710.1820000000316,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.02,
"layouts": 9,
"layoutDurationMs": 2.359,
"taskDurationMs": 486.532,
"heapDeltaBytes": 3866000,
"heapUsedBytes": 65204092,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 164.204,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664285714285718,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1195.921999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 907.596,
"heapDeltaBytes": -14322408,
"heapUsedBytes": 74799188,
"domNodes": -203,
"jsHeapTotalBytes": 20193280,
"scriptDurationMs": 69.569,
"eventListeners": -106,
"totalBlockingTimeMs": 521,
"frameDurationMs": 33.333333333333336,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1242.5880000000689,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 943.4830000000001,
"heapDeltaBytes": -12344596,
"heapUsedBytes": 75052500,
"domNodes": -203,
"jsHeapTotalBytes": 20455424,
"scriptDurationMs": 71.087,
"eventListeners": -106,
"totalBlockingTimeMs": 549,
"frameDurationMs": 33.33243243243243,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 894.0939999999955,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 568.0909999999999,
"heapDeltaBytes": -30063808,
"heapUsedBytes": 65508120,
"domNodes": -203,
"jsHeapTotalBytes": 3538944,
"scriptDurationMs": 172.275,
"eventListeners": -106,
"totalBlockingTimeMs": 227,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 928.0580000000782,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 584.4300000000002,
"heapDeltaBytes": -27117992,
"heapUsedBytes": 66649084,
"domNodes": -203,
"jsHeapTotalBytes": 3801088,
"scriptDurationMs": 184.35999999999996,
"eventListeners": -106,
"totalBlockingTimeMs": 223,
"frameDurationMs": 23.93076923076921,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11794.281000000012,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10964.371,
"heapDeltaBytes": 70354008,
"heapUsedBytes": 151043976,
"domNodes": -269,
"jsHeapTotalBytes": 73003008,
"scriptDurationMs": 8884.679,
"eventListeners": -68,
"totalBlockingTimeMs": 1550,
"frameDurationMs": 32.370604395604396,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10480.022999999961,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9651.323,
"heapDeltaBytes": 64651640,
"heapUsedBytes": 144714116,
"domNodes": -269,
"jsHeapTotalBytes": 66711552,
"scriptDurationMs": 7743.5509999999995,
"eventListeners": -68,
"totalBlockingTimeMs": 931,
"frameDurationMs": 31.19910714285714,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10670.203999999956,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9888.409000000001,
"heapDeltaBytes": -7390076,
"heapUsedBytes": 66205540,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 8013.322,
"eventListeners": 0,
"totalBlockingTimeMs": 1161,
"frameDurationMs": 31.006395348837213,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10615.634,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9853.321000000002,
"heapDeltaBytes": 53303820,
"heapUsedBytes": 132895056,
"domNodes": -269,
"jsHeapTotalBytes": 68022272,
"scriptDurationMs": 7929.990999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 1139,
"frameDurationMs": 31.132844574780062,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 319.77399999999534,
"styleRecalcs": 25,
"styleRecalcDurationMs": 15.712,
"layouts": 10,
"layoutDurationMs": 3.4079999999999995,
"taskDurationMs": 281.207,
"heapDeltaBytes": -15914192,
"heapUsedBytes": 59658276,
"domNodes": -1557,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 10.615,
"eventListeners": -640,
"totalBlockingTimeMs": 11,
"frameDurationMs": 25.64615384615382,
"p95FrameDurationMs": 116.60000000000036
},
{
"name": "large-combo-open",
"durationMs": 272.5760000000719,
"styleRecalcs": 24,
"styleRecalcDurationMs": 14.479,
"layouts": 12,
"layoutDurationMs": 4.12,
"taskDurationMs": 249.59,
"heapDeltaBytes": -10042032,
"heapUsedBytes": 66145412,
"domNodes": -2323,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 9.877,
"eventListeners": -573,
"totalBlockingTimeMs": 43,
"frameDurationMs": 23.60833333333335,
"p95FrameDurationMs": 100
},
{
"name": "large-graph-idle",
"durationMs": 2040.3370000000223,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.490999999999999,
"layouts": 8,
"layoutDurationMs": 2.451,
"taskDurationMs": 665.851,
"heapDeltaBytes": 12732584,
"heapUsedBytes": 86454848,
"domNodes": -269,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 32.93600000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2056.66999999994,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.033,
"layouts": 7,
"layoutDurationMs": 1.9169999999999998,
"taskDurationMs": 657.5300000000001,
"heapDeltaBytes": -13719008,
"heapUsedBytes": 60626732,
"domNodes": -269,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 36.075,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2416.8020000000183,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.607,
"layouts": 7,
"layoutDurationMs": 1.7939999999999996,
"taskDurationMs": 1726.807,
"heapDeltaBytes": -14445088,
"heapUsedBytes": 77286688,
"domNodes": -269,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 848.8710000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66551724137931,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2694.067000000018,
"styleRecalcs": 66,
"styleRecalcDurationMs": 8.203,
"layouts": 4,
"layoutDurationMs": 1.01,
"taskDurationMs": 1758.334,
"heapDeltaBytes": -18232056,
"heapUsedBytes": 71522396,
"domNodes": -269,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 872.0740000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.77,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3726.6389999999774,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.519,
"layouts": 64,
"layoutDurationMs": 10.668000000000001,
"taskDurationMs": 1836.8540000000003,
"heapDeltaBytes": -15445920,
"heapUsedBytes": 74225680,
"domNodes": -245,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 818.369,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66607142857143,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3757.6289999999517,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.758000000000003,
"layouts": 64,
"layoutDurationMs": 11.023,
"taskDurationMs": 1809.815,
"heapDeltaBytes": -20273260,
"heapUsedBytes": 72990884,
"domNodes": 24,
"jsHeapTotalBytes": 5017600,
"scriptDurationMs": 826.955,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66592920353982,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3193.062999999995,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.542999999999999,
"layouts": 6,
"layoutDurationMs": 1.735,
"taskDurationMs": 2013.7830000000001,
"heapDeltaBytes": -10280940,
"heapUsedBytes": 67748916,
"domNodes": 0,
"jsHeapTotalBytes": 6418432,
"scriptDurationMs": 1008.1349999999998,
"eventListeners": 182,
"totalBlockingTimeMs": 13,
"frameDurationMs": 16.929473684210524,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3169.091000000094,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.7250000000000005,
"layouts": 5,
"layoutDurationMs": 1.4320000000000002,
"taskDurationMs": 2065.1870000000004,
"heapDeltaBytes": -21685540,
"heapUsedBytes": 69907208,
"domNodes": 0,
"jsHeapTotalBytes": 6156288,
"scriptDurationMs": 1030.8029999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 33,
"frameDurationMs": 17.022994652406418,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3156.0249999999996,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.4370000000000007,
"layouts": 5,
"layoutDurationMs": 1.2200000000000002,
"taskDurationMs": 845.2749999999999,
"heapDeltaBytes": -8475148,
"heapUsedBytes": 80833240,
"domNodes": -269,
"jsHeapTotalBytes": 4882432,
"scriptDurationMs": 414.144,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666137566137568,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3091.109999999958,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.254,
"layouts": 7,
"layoutDurationMs": 1.9680000000000002,
"taskDurationMs": 824.1480000000001,
"heapDeltaBytes": -8772616,
"heapUsedBytes": 66058644,
"domNodes": -269,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 378.382,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665945945945946,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2048.3920000000353,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.309,
"layouts": 7,
"layoutDurationMs": 1.8619999999999999,
"taskDurationMs": 651.3189999999998,
"heapDeltaBytes": -29864304,
"heapUsedBytes": 62006472,
"domNodes": -269,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 31.801999999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2058.035000000018,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.8919999999999997,
"layouts": 6,
"layoutDurationMs": 1.739,
"taskDurationMs": 689.908,
"heapDeltaBytes": 828544,
"heapUsedBytes": 77340672,
"domNodes": -269,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 35.36599999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2759.1320000000223,
"styleRecalcs": 26,
"styleRecalcDurationMs": 12.632000000000001,
"layouts": 6,
"layoutDurationMs": 1.4659999999999997,
"taskDurationMs": 638.028,
"heapDeltaBytes": -24290044,
"heapUsedBytes": 64291484,
"domNodes": -267,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 208.73100000000002,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666060606060604,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2788.6819999999943,
"styleRecalcs": 27,
"styleRecalcDurationMs": 12.604000000000001,
"layouts": 7,
"layoutDurationMs": 2.035,
"taskDurationMs": 654.723,
"heapDeltaBytes": -11858924,
"heapUsedBytes": 80608008,
"domNodes": -257,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 215.30299999999997,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66586826347305,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-topology-cadence",
"durationMs": 3357.0159999999873,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.4019999999999997,
"layouts": 5,
"layoutDurationMs": 1.389,
"taskDurationMs": 991.2120000000001,
"heapDeltaBytes": -4847840,
"heapUsedBytes": 70906224,
"domNodes": -269,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 411.144,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.83366834170854,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-topology-cadence",
"durationMs": 3359.352999999942,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.8849999999999996,
"layouts": 6,
"layoutDurationMs": 1.803,
"taskDurationMs": 998.936,
"heapDeltaBytes": -17174404,
"heapUsedBytes": 71915676,
"domNodes": -269,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 391.185,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.749000000000002,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 592.6830000000223,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.841000000000001,
"layouts": 9,
"layoutDurationMs": 2.4729999999999994,
"taskDurationMs": 440.91999999999996,
"heapDeltaBytes": 740576,
"heapUsedBytes": 62102056,
"domNodes": 0,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 148.41899999999998,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663888888888877,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 557.6569999999492,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.8740000000000006,
"layouts": 9,
"layoutDurationMs": 2.5460000000000003,
"taskDurationMs": 398.613,
"heapDeltaBytes": -516780,
"heapUsedBytes": 61628512,
"domNodes": 0,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 152.85199999999998,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352937,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2008.262000000002,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.7319999999999993,
"layouts": 9,
"layoutDurationMs": 2.759,
"taskDurationMs": 528.77,
"heapDeltaBytes": 1387920,
"heapUsedBytes": 63313880,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 7.497,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2023.5849999999118,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.808,
"layouts": 9,
"layoutDurationMs": 2.6639999999999997,
"taskDurationMs": 553.6030000000001,
"heapDeltaBytes": 1380776,
"heapUsedBytes": 62679568,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 8.322,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760334,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1743.7199999999962,
"styleRecalcs": 77,
"styleRecalcDurationMs": 15.123000000000001,
"layouts": 9,
"layoutDurationMs": 2.615,
"taskDurationMs": 876.236,
"heapDeltaBytes": 2149360,
"heapUsedBytes": 65178168,
"domNodes": -195,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 110.73299999999999,
"eventListeners": -115,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.9759999999833,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.984999999999998,
"layouts": 8,
"layoutDurationMs": 2.8040000000000003,
"taskDurationMs": 872.2220000000001,
"heapDeltaBytes": 17462004,
"heapUsedBytes": 79863088,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 115.625,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 1435.7370000000174,
"styleRecalcs": 19,
"styleRecalcDurationMs": 22.004,
"layouts": 5,
"layoutDurationMs": 14.058000000000002,
"taskDurationMs": 1036.7269999999996,
"heapDeltaBytes": 38048432,
"heapUsedBytes": 115205668,
"domNodes": 16029,
"jsHeapTotalBytes": 6426624,
"scriptDurationMs": 43.516,
"eventListeners": 3246,
"totalBlockingTimeMs": 151,
"frameDurationMs": 19.594594594594593,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9553.133000000002,
"styleRecalcs": 251,
"styleRecalcDurationMs": 29.730000000000004,
"layouts": 8,
"layoutDurationMs": 2.0429999999999997,
"taskDurationMs": 6242.464,
"heapDeltaBytes": -27911140,
"heapUsedBytes": 61618348,
"domNodes": -269,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 2895.9860000000003,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665968586387432,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9725.777999999991,
"styleRecalcs": 250,
"styleRecalcDurationMs": 30.394000000000005,
"layouts": 8,
"layoutDurationMs": 2.1310000000000002,
"taskDurationMs": 6331.919,
"heapDeltaBytes": 490184,
"heapUsedBytes": 87541200,
"domNodes": -269,
"jsHeapTotalBytes": 4550656,
"scriptDurationMs": 2947.8720000000003,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6946735395189,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 23712.144999999964,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23142.775999999998,
"heapDeltaBytes": -28571976,
"heapUsedBytes": 254440176,
"domNodes": -3343,
"jsHeapTotalBytes": 12836864,
"scriptDurationMs": 337.07,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.93108808290156,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-idle",
"durationMs": 23651.68599999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23106.753999999997,
"heapDeltaBytes": -20175824,
"heapUsedBytes": 262568780,
"domNodes": -3343,
"jsHeapTotalBytes": 12312576,
"scriptDurationMs": 328.382,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.12869565217392,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-large-graph-pan",
"durationMs": 20615.210000000046,
"styleRecalcs": 165,
"styleRecalcDurationMs": 15.734000000000027,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20231.131999999998,
"heapDeltaBytes": -24296,
"heapUsedBytes": 281959400,
"domNodes": -3343,
"jsHeapTotalBytes": 21749760,
"scriptDurationMs": 869.918,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.14685185185185,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 28929.33699999992,
"styleRecalcs": 181,
"styleRecalcDurationMs": 18.768000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28595.078999999998,
"heapDeltaBytes": -22974740,
"heapUsedBytes": 269015752,
"domNodes": -3343,
"jsHeapTotalBytes": 12836864,
"scriptDurationMs": 914.42,
"eventListeners": -651,
"totalBlockingTimeMs": 17,
"frameDurationMs": 53.479112754158976,
"p95FrameDurationMs": 116.60000000000218
},
{
"name": "vue-node-resize-workload",
"durationMs": 8619.523000000072,
"styleRecalcs": 20,
"styleRecalcDurationMs": 87.57999999999998,
"layouts": 20,
"layoutDurationMs": 30.04000000000001,
"taskDurationMs": 8515.111,
"heapDeltaBytes": -25277768,
"heapUsedBytes": 266835944,
"domNodes": -3343,
"jsHeapTotalBytes": 10739712,
"scriptDurationMs": 124.27799999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 49.80462427745664,
"p95FrameDurationMs": 100.09999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 8743.149000000016,
"styleRecalcs": 20,
"styleRecalcDurationMs": 91.58800000000004,
"layouts": 20,
"layoutDurationMs": 30.431999999999988,
"taskDurationMs": 8608.863,
"heapDeltaBytes": -56166804,
"heapUsedBytes": 245421316,
"domNodes": -3343,
"jsHeapTotalBytes": 13885440,
"scriptDurationMs": 134.394,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 49.619318181818194,
"p95FrameDurationMs": 100.10000000000036
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11744.466999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11501.428999999998,
"heapDeltaBytes": 9110484,
"heapUsedBytes": 281929668,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 168.663,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.313028169014075,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-zoom-out-idle",
"durationMs": 12294.895999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11753.510000000002,
"heapDeltaBytes": 14078820,
"heapUsedBytes": 274942864,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 173.83400000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.855749128919854,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "workflow-execution",
"durationMs": 135.68799999995917,
"styleRecalcs": 11,
"styleRecalcDurationMs": 11.581000000000001,
"layouts": 10,
"layoutDurationMs": 4.93,
"taskDurationMs": 101.81599999999999,
"heapDeltaBytes": 4717312,
"heapUsedBytes": 72440268,
"domNodes": 128,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.655,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 481.4920000000029,
"styleRecalcs": 15,
"styleRecalcDurationMs": 9.068999999999999,
"layouts": 12,
"layoutDurationMs": 5.223,
"taskDurationMs": 121.74499999999999,
"heapDeltaBytes": -10652056,
"heapUsedBytes": 65147532,
"domNodes": 99,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 10.318,
"eventListeners": 3,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428571,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 500.754000000029,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.704,
"layouts": 76,
"layoutDurationMs": 14.765,
"taskDurationMs": 461.60699999999997,
"heapDeltaBytes": -3790084,
"heapUsedBytes": 39959828,
"domNodes": 4,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 226.54,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66451612903227,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 477.37599999993563,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.757,
"layouts": 76,
"layoutDurationMs": 15.214,
"taskDurationMs": 434.477,
"heapDeltaBytes": -4438076,
"heapUsedBytes": 39307616,
"domNodes": 4,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 205.397,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 593.0609999999206,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.6720000000000002,
"layouts": 76,
"layoutDurationMs": 15.466000000000001,
"taskDurationMs": 553.626,
"heapDeltaBytes": 640924,
"heapUsedBytes": 91292556,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 222.828,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.140000000000015,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 607.5349999999844,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.547,
"layouts": 76,
"layoutDurationMs": 15.911999999999999,
"taskDurationMs": 572.889,
"heapDeltaBytes": 1301684,
"heapUsedBytes": 103964360,
"domNodes": 4,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 234.954,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66216216216216,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageLine coverage: 60.2% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3158 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 4e21c13a4e1db9b812dea7dd09768fab432106f9
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (271)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @shrimbly.
Found 6 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 2 |
| 🟢 Low | 3 |
| ⚪ Nit | 1 |
Panel: 6/6 reviewers contributed findings.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #21858 +/- ##
==========================================
- Coverage 87.55% 87.35% -0.21%
==========================================
Files 2922 2815 -107
Lines 158828 155189 -3639
Branches 41707 40491 -1216
==========================================
- Hits 139069 135570 -3499
+ Misses 18883 18864 -19
+ Partials 876 755 -121
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 265 files with indirect coverage changes 🚀 New features to boost your workflow:
|
f185f5a to
f91d8ef
Compare
f91d8ef to
65dea3f
Compare
b86dc80 to
beac9df
Compare
beac9df to
515463a
Compare
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @shrimbly.
Round 2 — ledger: 6 prior finding(s) across 1 round(s) (6 never answered).
Found 6 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 2 |
| 🟢 Low | 2 |
| ⚪ Nit | 2 |
Panel: 6/6 reviewers contributed findings.
515463a to
d00c4c3
Compare
…workflow (DES-1280) (Comfy-Org#21836) ## Summary The Run on menu in the Run bar, and its Workspace default submenu, keep one width and one row layout, so long Build names and mixed statuses no longer make them lopsided. With `deployment_compatibility_marks_enabled` on, the Run on menu also groups its rows by whether they can run the open workflow, using the compatibility check from Comfy-Org#20372. Closes DES-1280. **Layout (everyone)** - Both menus are 336 px wide, and never wider than the space Reka reports for them (`--reka-dropdown-menu-content-available-width`). - Each row has four columns: the Build name (takes the free space and truncates first), the deployment name (64 px), the Release version when ready or else the status, and the check. - A row whose text is cut off shows its full label in a tooltip to the left, on hover or keyboard focus. - Failed reads Failed with an orange dot, in the menu and on the Run bar button. Stopping reads Stopping. Queued reads Starting. - The row this browser runs on comes first. - Footer link: Manage deployments with deployments, Create a custom deployment without; both open Platform's Builds page (`/profile/builds`) in a new tab. Before, it opened the Builds section of the Deploy page. - Both menus build their rows from one helper, `deploymentRowLabels`. **Grouping (behind `deployment_compatibility_marks_enabled`)** - The inline marks ("Runs this workflow", "Missing N nodes", "Not checked") are gone. A row that cannot run the open workflow names the missing nodes on hover and in its accessible description. A row the check could not read says "Could not check whether X can run this workflow." - When the check answers, the current row sits alone under "Running on". The rows that run the workflow follow under "Compatible environments", and all other rows under "Incompatible environments". A group whose only row was the current one is left out. Comfy Cloud goes in whichever group it belongs to. A deployment the check could not read goes under "Incompatible environments". - The menu stays one "Run on" list while the flag is off, if the check fails, if every row is in one group, or until the check has answered for every listed row. - When the answer regroups the open menu, keyboard focus stays on the same row, and arrow keys keep moving through the menu. Design: the "Deployment menu" canvas, https://claude.ai/artifact/MGGME6U7xjXtberxNaoNUy (boards R2 to R11 for the rows, F1 for the groups). ## Review focus - `sectionRows` in `useDeploymentRows.ts` is a pure function that decides the groups, tested as a table in `useDeploymentRows.test.ts`. Each group is its own radio group, labelled by its header, with the same picked value. - `useKeepRowFocus.ts`: the groups are keyed by name, so regrouping re-creates every row and focus fell to the page. It notes the focused row's `data-focus-row` before the re-render and focuses the same row after, also when a listing refresh only moves the row, since a moved element loses focus. It does not keep stale answers, so Comfy-Org#21897 stands. - Rows show their checked state with `aria-checked` styles, not `data-state=checked`: the tooltip wrapper puts its own `data-state` on the row. - Current row on top: a "Running on" group of one above the two groups, over moving the current row's group first or putting the row first in its own group. Trade-off: when the current deployment cannot run the workflow, its row does not sit under "Incompatible environments"; only its tooltip and description say so. - Group names: Eric Sun asked for "Compatible/incompatible environments" in the Homestead dogfooding thread. "Environments" covers Comfy Cloud as well as deployments. - DES-1279 is split in two, stacked on this PR: Comfy-Org#21858 (only a ready deployment can be picked), and Comfy-Org#21839 (start a stopped deployment) on Comfy-Org#21858. ## Known follow-ups - When the answer arrives with the menu open, the rows still move under the pointer; a click during the move can land on a different row. Opening the menu reloads the listing, and a changed status re-runs the check, so this happens on ordinary opens. ## Verification - Unit: `DeploymentSwitcher.test.ts`, `useDeploymentRows.test.ts`, `useDeploymentLabels.test.ts`, `ComfyActionbar.test.ts` and `CurrentUserButton.test.ts` pass (122). The focus tests fail without `useKeepRowFocus`, and the moved-row one without its check that the row still has focus; the Build name tooltip test fails without measuring the Build name; the Workspace default column test fails without the detail binding. - Browser: the screenshots are from earlier heads of this PR (local Cloud dev build, mocked listing and compatibility answer, 1440 px). Since then the Comfy Cloud row renders an empty deployment column (seen in a local Storybook with the switcher forced on), the width cap uses Reka's available width, and focus is kept through regrouping; the last two were not re-checked in a browser. | State | Before (main) | After | | --- | --- | --- | | Several deployments, on Comfy Cloud | <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/e599d96cfd09ffaea718534e6aba2fbf535cc78a/DES-1280-v3-02-open-several-before.png"> | <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/e599d96cfd09ffaea718534e6aba2fbf535cc78a/DES-1280-v3-02-open-several-after.png"> | | On a deployment | <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/e599d96cfd09ffaea718534e6aba2fbf535cc78a/DES-1280-v3-03b-open-active-before.png"> | <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/e01a8ab6a84908a148b550448ecd3cc3edc0b2bd/DES-1280-v5-03b-open-active-after.png"> | | Long Build and deployment names | <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/e599d96cfd09ffaea718534e6aba2fbf535cc78a/DES-1280-v3-04-long-names-before.png"> | <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/e01a8ab6a84908a148b550448ecd3cc3edc0b2bd/DES-1280-v5-04-long-names-after.png"> | | No deployments | <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/e599d96cfd09ffaea718534e6aba2fbf535cc78a/DES-1280-v3-05-empty-before.png"> | <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/e599d96cfd09ffaea718534e6aba2fbf535cc78a/DES-1280-v3-05-empty-after.png"> | | Every status | <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/e599d96cfd09ffaea718534e6aba2fbf535cc78a/DES-1280-v3-06-statuses-before.png"> | <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/e599d96cfd09ffaea718534e6aba2fbf535cc78a/DES-1280-v3-06-statuses-after.png"> | | Owner, Workspace default | <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/e599d96cfd09ffaea718534e6aba2fbf535cc78a/DES-1280-v3-08-default-submenu-before.png"> | <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/e01a8ab6a84908a148b550448ecd3cc3edc0b2bd/DES-1280-v5-08-default-submenu-after.png"> | | Mixed states | <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/e599d96cfd09ffaea718534e6aba2fbf535cc78a/DES-1280-v3-11-mixed-before.png"> | <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/e01a8ab6a84908a148b550448ecd3cc3edc0b2bd/DES-1280-v5-11-mixed-after.png"> | | Compatibility check on | <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/e599d96cfd09ffaea718534e6aba2fbf535cc78a/DES-1280-v3-compat-before.png"> | <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/ea2c3f3a6cb2b105385e4e50c719108c3d09b1af/DES-1280-v6-compat-after.png"> | The current deployment cannot run the workflow: <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/ea2c3f3a6cb2b105385e4e50c719108c3d09b1af/DES-1280-v6-current-incompatible.png"> A cut-off row on hover, and a row that cannot run the workflow: <img width="700" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/e01a8ab6a84908a148b550448ecd3cc3edc0b2bd/DES-1280-v5-12-mixed-tooltip.png"> <img width="700" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/ea2c3f3a6cb2b105385e4e50c719108c3d09b1af/DES-1280-v6-s2-sections-missing-tooltip.png"> --------- Co-authored-by: Benjamin Lu <benjaminlu1107@gmail.com>
I generally disagree. Willie/shrimbly here is the designer and he explicitly wanted this UX. The API contract says that they are all pickable, yes, in terms of capability, not whether we should.
Also, we both agree that it's documented literally as deployment.status === 'ready'` means runnable, which is the UX we're aiming for.
I think blocking based on a potential future change from cloud who don't then update the very API they are breaking would be a bit excessive.
Everything else (no blockers) was approved/passed by three people so I will just continue to push this through. Feel free to disagree and I will see if I can shove the cloud change needed to fix this fast.
|
Even though the deadline is close I want to hear your reply to see if you agree |
dante01yoon
left a comment
There was a problem hiding this comment.
Re-review at 06c0cd5db9. Since my last review at d46506fb66, this head is a rebase onto main and the feature patches are unchanged. My earlier review was dismissed by the rebase, not resolved.
Still blocking: pickable is a server fact derived in the frontend. I checked again at this head:
packages/ingest-types/src/types.gen.ts:129still documentsWorkspaceDeployment.statusas "Any of them may be picked; a job is taken only while it is ready", andstatusis still an openstring.useDeploymentRows.ts:155still setspickabletostatus === 'ready', with no backend field and nopendingServerFactbridge (ADR API-SERVER-FACTS-0042).
The original thread (comment) has no reply yet. @benceruleanlu also asked for one before merge. vqt123's round-3 review independently marks this as a Must.
Any one of these would unblock me:
- The backend confirms the contract is now "only ready may be picked". Then the generated doc gets regenerated and this line renders the contract.
- A
BE-xxxxticket for a server-owned pick capability, withpendingServerFact('BE-xxxx', deployment.status === 'ready')used in the meantime. - Invert the default: disable only recognised non-runnable statuses and leave unknown statuses pickable, as they are on main.
The stopping copy and the duplicated status-literal lists from my last round are still open and non-blocking. I'm not repeating them inline.
Checks: CI unit / test, lint-pr / typecheck and lint-and-format pass at this head. The Playwright shards are red, and I could not get their logs to tell whether they are related. I did not run tests locally because this workspace has no installed dependencies.
| deploymentFullLabel(deployment) | ||
| ) | ||
| note: note(mark, deployment), | ||
| pickable: deployment === null || deployment.status === 'ready' |
There was a problem hiding this comment.
issue: This is unchanged at 06c0cd5db9, and it still contradicts the generated contract (types.gen.ts:129: "Any of them may be picked"). Concrete failure: say the backend reports a runnable deployment under a status other than the literal ready, which it may do because status is an open string. That row becomes aria-disabled, arrow keys skip it, and the user can't select it until a frontend release. On main the same row stays pickable.
Could we either get the backend to confirm the new rule (and regenerate the doc), or wrap this in pendingServerFact('BE-xxxx', ...) with a tracking ticket? Details are in my earlier thread: #21858 (comment)
dante01yoon
left a comment
There was a problem hiding this comment.
Approving at 95a25c5682. pickable is now bridged as pendingServerFact('BE-24332', deployment.status === 'ready'), with the backend ticket tracking the server-side field. Behavior is unchanged, and the server-fact blocker is resolved. Thanks for turning this around quickly.
|
Reviewed at 95a25c5 (since 06c0cd5): added the tracked server-fact bridge. Approving; no Must remains. Fixed: pickability now uses Still open:
Clean: Correctness, Resilience, Access, Words, Contract, Vendor and Rollout within the delta. ~472k effective tokens for this review (2.2M raw; cache reads weighted 0.1x, cache writes 1.25-2x) |
…-1279) (Comfy-Org#21839) ## Summary In the Run bar's deployment menu, a deployment the listing says can start (`can_start`) can be started from its row. - While the `deployment_start_enabled` flag is off, such a row shows Start with an arrow. Choosing it opens the deployment's page on the Developer Platform (`/profile/deployments/{id}`) in a new tab, where it can be started. Production shows this until the flag is on. - While the flag is on, choosing Start calls the start route. The row reads Starting until the listing asked for after the server took it lands, then shows the listing's status. The open menu refreshes the listing every 5 s while a row is on its way up. When the deployment is ready, the row shows its version and can be picked. The editor does not switch to it. - If the server refuses the Start, the row says that it did not start, shows the server's own message when there is one, and says how to fix it, keyed on the server's code. Retry starts it again. The reason is also the row's accessible description. - If the deployment fails after the server took the Start, the next listing shows it as Failed, with Start again. - If the server answers 403 (an API-key session, or the rollout flag is off), the row falls back to the Developer Platform link and offers no Retry. - If this browser runs on a stopped or failed deployment, the menu opens with a notice that says which, and the picked row has Start. Run does not change. Closes DES-1279 Builds on Comfy-Org#21858, now on `main`, which makes only a ready deployment pickable. This branch is rebased onto `main`. Uses `can_start` and the listing's `started_deployment_id` from Comfy-Org/cloud#16947, now merged and regenerated into `@comfyorg/ingest-types` by Comfy-Org#22216. This PR has no edits to `packages/ingest-types`. The regeneration narrows `status` to the statuses ingest serves, so the last commit types the Start test fixtures with `WorkspaceDeployment['status']`. Design: the "Deployment menu" canvas, https://claude.ai/artifact/MGGME6U7xjXtberxNaoNUy (boards J1 to J6). ## The start route Ingest's `POST /api/workspaces/{id}/deployments/{deployment_id}/start` landed in Comfy-Org/cloud#15759 (BE-23058). On 27 Oct it answered on testcloud and staging, but not on production: cloud.comfy.org returned 404. It takes no body and answers 202 with `deployment_id` and `status` (`StartWorkspaceDeploymentResult`, parsed with its zod schema). It refuses with 400, 402, 409 or 429 and passes on comfy-deploy's code and message. comfy-deploy's start is idempotent: a deployment that is already up comes back unchanged, so a second Start does no harm. Comfy-Org/cloud#16947 fixes two things the listing did: - It kept each caller's listing for 30 s on each of several ingest servers, with no sticky routing, so the refresh after a Start could still say stopped. A listing now names each deployment this browser started (`started_deployment_id`, repeated), and a server whose cached listing still offers Start on one lists it again. A listing with a deployment on the move is kept for 5 s. - It did not say which rows Start brings back. `can_start` is true while a deployment is stopped or failed, the statuses comfy-deploy's start re-runs. Turn `deployment_start_enabled` on in an environment once its ingest serves the route and `can_start`. On an older ingest no row offers Start or the link. ## Decisions to review - The menu renders the listing's status and `can_start` as received (ADR-API-SERVER-FACTS-0042). Picking a ready row keeps Comfy-Org#21858's `pendingServerFact('BE-24332', …)`, now in `deploymentRowAction`. This page remembers only two things of its own: a Start in flight, and the server's refusal. It no longer works out from listing snapshots whether a Start failed. - A Start in flight lasts until the listing asked for after the server took it lands. A refusal lasts while the listing says the deployment can still start, so it is dropped when the deployment is started or stopped elsewhere. - After the server takes a Start, every listing names that deployment until one asked for after the Start offers Start on it again or no longer lists it. It reads `can_start`, not a status list, and a listing already in flight when the Start was taken never drops it. Names the listing does not offer Start on cost ingest nothing. - A refusal's fix follows the server's code: `PAYMENT_REQUIRED` and `CONCURRENCY_LIMIT` have their own copy, and any other refusal reads as a generic failure. A 403, 404, 405 or 501 falls back to the Developer Platform link. A message is shown only when the server sent a code with it. - A Start the server did not answer (no status, a timeout, a 5xx, or a failure that is not an API error) is reported as `error_starting_deployment`. - With the flag off, a row that can start links to its deployment's page instead of doing nothing. That page has its own Start. The link reuses the Start label with an arrow, so the row reads the same with the flag on or off. - On a stopped deployment that this browser runs on, Run does not change. The engine button's tooltip and the menu's notice say to start the deployment. - Start, Retry and link rows stay reachable by keyboard. Their accessible names are "Start Flux Studio · staging", "Retry starting Flux Studio · staging" and "Start Flux Studio · staging on the Developer Platform". - Copy: 16 new strings. English only: the release workflow translates the other catalogs. ## Follow-ups - comfy-deploy has a sentence for the customer saying why a deployment failed (`error`) on its single read, not on its list rows. Passing it on in the listing needs a comfy-deploy change, so a failed row shows only Failed for now. - `can_pick` from the review of Comfy-Org#21858 is not part of this stack. ## Verification - Unit: `src/platform/workspace`, `TopMenuSection`, and the other files whose fixtures gained `can_start` (now in Comfy-Org#22216), 49 files and 1,242 tests, pass at this head. - `deploymentPickStore.test.ts`: a started deployment stays named after a listing that shows it queued or ready, is dropped after one that offers Start on it again or no longer lists it, and is kept when a listing asked for before its Start says it can start. - `workspaceApi.webSessionRetry.test.ts`: the listing URL carries one `started_deployment_id` per started deployment, through real axios and the web-session adapter. - `deploymentStartState.test.ts`: every Start event, and the action and reason of each row, against the listing's `can_start`. - `DeploymentSwitcher.test.ts`: the listing after a Start names the started deployment; Start only where the listing says it can start; Starting until the listing after the Start lands, whatever an older listing says; a Start that later fails shows Failed with Start; a refused Start and Retry, with the reason as the row's description; 429s told apart by code, including `RATE_LIMITED`; which failures are reported; the link after a 403 and with the flag off; the 5 s refresh skipped while the last is pending; the notice and tooltip on a stopped or failed deployment this browser runs on. - `workspaceApi.test.ts`: `startDeployment` sends POST to the encoded start path with no body and a 30 s timeout, rejects an answer without a status, and turns a refusal into a `WorkspaceApiError` with its code. - Pre-commit (oxfmt, stylelint, oxlint, eslint, the server-facts check) and pre-push (knip, fallow) pass. `typecheck:app` is clean. - Not run: the browser against a backend with Comfy-Org/cloud#16947. The screenshots below are from the earlier build with a mocked listing and were not retaken. ## Screenshots | State | After | | --- | --- | | Flag off: stopped and failed rows link to their page. The reason shows on hover. | <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/65e63736e8f7fbbc4a7652019c15e5ceff1a27c8/DES-1279-f-j2-08-link-hovered.png"> | | Flag on, with the compatibility check: a stopped row that cannot run the workflow offers Start under Incompatible environments | <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/ea2c3f3a6cb2b105385e4e50c719108c3d09b1af/DES-1279-g-s5-sections-start.png"> | | Flag on: stopped rows offer Start. The reason shows on hover. | <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/a642ac95f63b3b7825d2086ded1d460d28b25cd2/DES-1279-e-j2-01-start.png"> | | Starting, after Start | <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/a642ac95f63b3b7825d2086ded1d460d28b25cd2/DES-1279-e-j2-02-starting.png"> | | Ready after the refresh, and can be picked | <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/a642ac95f63b3b7825d2086ded1d460d28b25cd2/DES-1279-e-j2-04-ready.png"> | | The server refused the Start (402) | <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/a642ac95f63b3b7825d2086ded1d460d28b25cd2/DES-1279-e-j2-03-failed.png"> | | The server answered 403: the row falls back to the link | <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/65e63736e8f7fbbc4a7652019c15e5ceff1a27c8/DES-1279-f-j2-05-not-allowed.png"> | | On a stopped deployment: engine button tooltip | <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/65e63736e8f7fbbc4a7652019c15e5ceff1a27c8/DES-1279-f-j2-06a-active-stopped-tooltip.png"> | | On a stopped deployment: the menu | <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/65e63736e8f7fbbc4a7652019c15e5ceff1a27c8/DES-1279-f-j2-06b-active-stopped-open.png"> | --------- Co-authored-by: Benjamin Lu <benjaminlu1107@gmail.com>
Comfy-Org#22395) ## Why ADR-API-SERVER-FACTS-0042 is still `Proposed`, and its rule 1 is ambiguous in a way that already caused a wrong block. On Comfy-Org#21858, `deployment.status === 'ready'` was blocked as a derived server fact, although the spec defines `ready` as the only status that takes jobs. The PR ended up wrapped in `pendingServerFact('BE-24332', …)`. The cause was the rule's wording, not the code. This PR removes the ambiguity and proposes moving the ADR to `Accepted`. ## Root cause Rule 1 forbids combining a fact "through `&&`, `||`, `??`, a ternary, arithmetic, a comparison or a helper" and adds that a gate "does not choose which fact answers the question". It doesn't say what either clause applies to: - "a comparison" was read as any comparison, including one field compared with the value its own spec defines; - "choose which fact answers" didn't separate a field the API documents as the answer from a proxy (`role === 'owner'`); - narrowing an action the server permits (hide or disable) wasn't covered, so a UX narrowing that contradicted a spec line ("any status may be picked") read as a violation. The lint gate (`comfy/no-server-fact-literals`, `comfy/no-capability-recombination`) does not draw the same line: it keys on field names, not documentation. It flags tier and billing/subscription-status literals even when the spec documents the value, and it can't see a proxy on any other field. The ADR now says so and says the lint wins on conflict. ## How - Rule 1: the forbidden comparison is one between server facts. - New rule 2, "as received means as the API documents it": comparing one field with a value its API documentation defines as the answer is rendering. A field the API doesn't document as the answer is a proxy. An open `string` compared with a documented literal gets an enum request to the backend, not a block. - Rule 2 also says where a documented-value comparison lives: in the fact provider, minted with `receiveServerFact` for that field. A field with no documentation is a proxy. - New rule 3: narrowing an action the server permits follows rule 2 for the narrower question. The documentation exists before merge; a contradicting spec changes first. - Rule 7 (BE review of field choice): documentation counts as the review only when it names the UI question itself. Reading a doc sentence as the answer to a different question still needs the owning team. - New "Classifying a gate" table built from real cases (Comfy-Org#15675, Comfy-Org#18662, Comfy-Org#21858, `canSetDefault`), plus a requirement that the author cites the documentation that makes the field the answer; a reviewer may block on a missing or mismatched citation. - "Enforcement" section: lists what is in place (lint, hooks, `pendingServerFact` expiry, `ServerFact<Field>`) and what is open (orthogonality tests), and states that the lint wins where it is narrower or broader than rule 2. - Renumbering only for the other rules; no rule removed. - `scripts/hooks/server-fact-hook.ts` agent guidance: names arithmetic, and tells an agent blocked on a tier or status literal to ask the backend or change the lint, not to disable it. - Status `Proposed` → `Accepted`. Open to discussion if anyone wants it kept as Proposed. ## AS IS / TO BE Docs and hook-message change only; no UI. | | Text | |---|---| | AS IS | "…through `&&`, `||`, `??`, a ternary, arithmetic, a comparison or a helper. It also does not choose which fact answers the question." | | TO BE | "…a comparison between them, or a helper." plus rule 2: "Comparing one field with a value its API documentation defines as the answer to this question is rendering, not deriving." | ## Checks - `pnpm adr:check` passes - `vitest run scripts/hooks/`: 51/51 pass
…menu (DES-1279) (#21858) ## Summary In the Run bar's deployment menu, only a ready deployment can be picked. Today a stopped deployment can be picked, and then Run does nothing. - A row whose deployment is not ready is disabled. Choosing it does nothing, and arrow keys skip it. - Its names are dimmed. Its status keeps full contrast. - Hovering the row says why in a tooltip to the left of the menu. It says that the deployment is starting, that it is not running (start it on the Developer Platform, then pick it), or that it is not ready. The row's accessible description says the same. The row this browser already runs on gives no reason, because the notice and the engine button already cover it. - If the row also cannot run the open workflow, the tooltip gives the reason first, then the missing nodes. Part of DES-1279. Starting a deployment from the menu is #21839, stacked on this PR. Base: `willie/des-1280-comfyui_frontend-refine-the-layout-of-the-run-bars` (#21836). After #21836 merges I will rebase this branch onto `main` and retarget it. ## Review focus - Rebased on the new #21836, which groups the rows by whether they run the workflow and keeps the current deployment at the top, and on main past #20373 and #21897. `useDeploymentRows.ts` adds `pickable` and the reason to each row. `pickable` is the listing's `status === 'ready'`, wrapped as `pendingServerFact('BE-24332', …)` until the listing says which deployments may be picked (BE-24332 asks for a `can_pick` field). Comfy Cloud is always pickable. - The row's `missingNodes` prop becomes `note`, because it now carries the reason, the missing nodes, or both. - The row uses reka's `disabled`, which sets `aria-disabled` and blocks select. reka also fades a disabled item to 50% opacity. That would fail contrast on the status text, so a disabled row keeps full opacity and dims only its names. While a switch is in flight, these rows fade with the rest. - Copy: three reason strings and one follow-on sentence for the missing nodes. English only: the release workflow translates the other catalogs. ## Verification - Unit: `src/platform/workspace` passes at this head, 1,410 tests. New tests: only a ready row switches, the reason each status gives, no reason on the current row, and the reason followed by the missing nodes. Two existing tests change because a stopped row is no longer pickable. - Pre-commit hooks, `fallow audit` and `typecheck:app` pass. - Browser: a local Cloud dev build with a mocked listing and a mocked compatibility answer, Nodes 2.0, 1440 px. ## Screenshots | Groups, a starting row hovered | A stopped row | A starting row | | --- | --- | --- | | <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/ea2c3f3a6cb2b105385e4e50c719108c3d09b1af/DES-1279r-v5-s2-sections-missing-tooltip.png"> | <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/a642ac95f63b3b7825d2086ded1d460d28b25cd2/DES-1279r-v4-ra-01-stopped-reason.png"> | <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/a642ac95f63b3b7825d2086ded1d460d28b25cd2/DES-1279r-v4-ra-02-starting-reason.png"> | --------- Co-authored-by: Benjamin Lu <benjaminlu1107@gmail.com> (cherry picked from commit 985ff8e)
…22535) ## Summary Backport of #21858 to `cloud/1.59`. Stopped and starting deployments cannot be selected from the Run on menu; their rows explain why. Part 3 of 9 in the Cloud workflow deployment backport stack. Applies on the preceding menu backport; the Start action is supplied by part 8. ## Verification - 74 focused tests passed on this individual stack layer. - Rebuilt on `cloud/1.59` at `7482c071`; application typecheck passes on every layer. The expanded stack, including deployment Start/Retry, passes 23,186 of 23,187 affected tests across 1,269 files; the one failure, in `SignUpForm.test.ts`, is intermittent and also fails on `cloud/1.59` without this stack. Formatting, affected-file lint, dependency audit and pre-push checks pass. - The original feature was exercised against test cloud at `cc9bd948`, including a successful job after switching deployments. Browser QA has not been repeated on this release-branch build. Co-authored-by: Willie <falloon.willie@gmail.com>
… nodes (Comfy-Org#22772) ## Summary When a workflow is missing nodes, the issues card and the Issues panel offer the deployments that can run it. They also listed stopped, failed and starting deployments, so **Switch** could reload the editor onto a deployment where jobs won't run. The Run on menu already refuses this (Comfy-Org#21858). They now list only ready deployments; when only a deployment that isn't ready can run the workflow, the card stays as it was and the menu's **Start** remains the way forward. Reachable only with `deployment_compatibility_marks_enabled` on. Not changed here: switching from an already-open dialog after its deployment stops (known, listed on Comfy-Org#22539), and picking a deployment from a link (`pickFromLink`). ## Verification - The 5 new tests fail without the fix. With it, `ErrorOverlayDeploymentOffer`, `MissingNodeDeploymentOffer` and `MissingNodeCard` pass (55 tests). - Cherry-picked locally onto `cloud/1.59` (`3e870e6f8`) and `cloud/1.60` (`e87613972`): the two changed suites pass (34 tests), application typecheck clean on both. Backports: Comfy-Org#22774 (`cloud/1.59`), Comfy-Org#22775 (`cloud/1.60`). - Not run in a browser. The bug was found in QA on staging at `3e870e6f8`, and confirmed by reading the code.
Summary
In the Run bar's deployment menu, only a ready deployment can be picked. Today a stopped deployment can be picked, and then Run does nothing.
Part of DES-1279. Starting a deployment from the menu is #21839, stacked on this PR.
Base:
willie/des-1280-comfyui_frontend-refine-the-layout-of-the-run-bars(#21836). After #21836 merges I will rebase this branch ontomainand retarget it.Review focus
useDeploymentRows.tsaddspickableand the reason to each row.pickableis the listing'sstatus === 'ready', wrapped aspendingServerFact('BE-24332', …)until the listing says which deployments may be picked (BE-24332 asks for acan_pickfield). Comfy Cloud is always pickable.missingNodesprop becomesnote, because it now carries the reason, the missing nodes, or both.disabled, which setsaria-disabledand blocks select. reka also fades a disabled item to 50% opacity. That would fail contrast on the status text, so a disabled row keeps full opacity and dims only its names. While a switch is in flight, these rows fade with the rest.Verification
src/platform/workspacepasses at this head, 1,410 tests. New tests: only a ready row switches, the reason each status gives, no reason on the current row, and the reason followed by the missing nodes. Two existing tests change because a stopped row is no longer pickable.fallow auditandtypecheck:apppass.Screenshots