Repository navigation
[backport cloud/1.59] allow picking only ready deployments (#21858) - #22535
benceruleanlu merged 1 commit into
Conversation
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 8 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-03T00:19:37.612Z",
"gitSha": "ea40992ba2d0aad14cc8ccb7afa084a84289e33c",
"branch": "bl/cloud-1.59-deployment-readiness",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2021.9029999999805,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.706,
"layouts": 9,
"layoutDurationMs": 2.9690000000000003,
"taskDurationMs": 527.701,
"heapDeltaBytes": 4171236,
"heapUsedBytes": 65159240,
"domNodes": 0,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 9.462000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-idle",
"durationMs": 2052.681000000007,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.5329999999999995,
"layouts": 8,
"layoutDurationMs": 2.3809999999999993,
"taskDurationMs": 630.6890000000001,
"heapDeltaBytes": -4393004,
"heapUsedBytes": 58041296,
"domNodes": -161,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 11.978,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666664,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1826.0679999999923,
"styleRecalcs": 77,
"styleRecalcDurationMs": 13.226999999999999,
"layouts": 9,
"layoutDurationMs": 2.536,
"taskDurationMs": 888.3520000000001,
"heapDeltaBytes": 21498916,
"heapUsedBytes": 83390972,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 150.106,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666972477064224,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1859.5300000000066,
"styleRecalcs": 77,
"styleRecalcDurationMs": 13.405999999999997,
"layouts": 9,
"layoutDurationMs": 2.887,
"taskDurationMs": 931.445,
"heapDeltaBytes": 21674888,
"heapUsedBytes": 83352756,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 156.915,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665178571428573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1706.837999999948,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.2620000000000005,
"layouts": 10,
"layoutDurationMs": 2.908,
"taskDurationMs": 440.09200000000004,
"heapDeltaBytes": 24440272,
"heapUsedBytes": 86255588,
"domNodes": 56,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 13.591,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1706.5450000000055,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.302000000000001,
"layouts": 10,
"layoutDurationMs": 2.901,
"taskDurationMs": 424.301,
"heapDeltaBytes": 94632,
"heapUsedBytes": 70478820,
"domNodes": 56,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 12.136000000000001,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66764705882353,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 704.0449999999794,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.3079999999999994,
"layouts": 8,
"layoutDurationMs": 2.2540000000000004,
"taskDurationMs": 507.81699999999995,
"heapDeltaBytes": 5725696,
"heapUsedBytes": 68082756,
"domNodes": 0,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 164.872,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664285714285718,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 760.1199999999722,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.0010000000000003,
"layouts": 9,
"layoutDurationMs": 3.1000000000000005,
"taskDurationMs": 552.162,
"heapDeltaBytes": 3800192,
"heapUsedBytes": 65455860,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 173.25400000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664444444444445,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1197.7600000000166,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 887.023,
"heapDeltaBytes": -13250544,
"heapUsedBytes": 75490052,
"domNodes": -191,
"jsHeapTotalBytes": 20455424,
"scriptDurationMs": 62.315999999999995,
"eventListeners": -107,
"totalBlockingTimeMs": 502,
"frameDurationMs": 31.576315789473686,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1211.891000000037,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 912.7749999999999,
"heapDeltaBytes": -11024332,
"heapUsedBytes": 75939344,
"domNodes": -191,
"jsHeapTotalBytes": 21504000,
"scriptDurationMs": 60.18,
"eventListeners": -107,
"totalBlockingTimeMs": 523,
"frameDurationMs": 32.88378378378378,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 808.8070000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 455.78599999999983,
"heapDeltaBytes": -4164204,
"heapUsedBytes": 64259088,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 138.17200000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 182,
"frameDurationMs": 24.020588235294113,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 808.7900000000445,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 467.75299999999964,
"heapDeltaBytes": -4290308,
"heapUsedBytes": 70673848,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 136.062,
"eventListeners": 0,
"totalBlockingTimeMs": 183,
"frameDurationMs": 24.017647058823542,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9642.491000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8864.134,
"heapDeltaBytes": 59960076,
"heapUsedBytes": 133467344,
"domNodes": -257,
"jsHeapTotalBytes": 67497984,
"scriptDurationMs": 6863.601999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 325,
"frameDurationMs": 30.00903426791277,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9825.582999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9007.744999999999,
"heapDeltaBytes": 51745584,
"heapUsedBytes": 125847604,
"domNodes": -257,
"jsHeapTotalBytes": 59109376,
"scriptDurationMs": 6979.536,
"eventListeners": -69,
"totalBlockingTimeMs": 469,
"frameDurationMs": 31.563344051446943,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9422.368000000006,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.08099999999999948,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8641.203,
"heapDeltaBytes": 58754008,
"heapUsedBytes": 140027900,
"domNodes": -257,
"jsHeapTotalBytes": 62517248,
"scriptDurationMs": 6673.349999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 319,
"frameDurationMs": 29.243167701863353,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9639.617000000044,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.19800000000000026,
"layouts": 1,
"layoutDurationMs": 0.19799999999999982,
"taskDurationMs": 8839.867,
"heapDeltaBytes": 64315344,
"heapUsedBytes": 139026124,
"domNodes": -257,
"jsHeapTotalBytes": 59633664,
"scriptDurationMs": 6808.432,
"eventListeners": -69,
"totalBlockingTimeMs": 385,
"frameDurationMs": 31.480065359477123,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 288.3080000000007,
"styleRecalcs": 25,
"styleRecalcDurationMs": 14.556000000000001,
"layouts": 11,
"layoutDurationMs": 3.8510000000000004,
"taskDurationMs": 244.87000000000003,
"heapDeltaBytes": -16810464,
"heapUsedBytes": 59061976,
"domNodes": 936,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 13.179,
"eventListeners": 205,
"totalBlockingTimeMs": 1,
"frameDurationMs": 23.616666666666674,
"p95FrameDurationMs": 100
},
{
"name": "large-combo-open",
"durationMs": 269.1560000000095,
"styleRecalcs": 24,
"styleRecalcDurationMs": 14.928000000000003,
"layouts": 12,
"layoutDurationMs": 4.361000000000001,
"taskDurationMs": 222.73100000000005,
"heapDeltaBytes": 14490600,
"heapUsedBytes": 90841888,
"domNodes": 936,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 10.809,
"eventListeners": 205,
"totalBlockingTimeMs": 3,
"frameDurationMs": 26.670000000000027,
"p95FrameDurationMs": 100
},
{
"name": "large-graph-idle",
"durationMs": 2054.6359999999877,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.1390000000000002,
"layouts": 9,
"layoutDurationMs": 2.1870000000000003,
"taskDurationMs": 641.7729999999999,
"heapDeltaBytes": -4891384,
"heapUsedBytes": 71551600,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 32.077,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2057.194999999979,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.3750000000000004,
"layouts": 7,
"layoutDurationMs": 2.396,
"taskDurationMs": 720.184,
"heapDeltaBytes": -13055424,
"heapUsedBytes": 61713808,
"domNodes": -257,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 35.313,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-pan",
"durationMs": 2314.4229999999766,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.27,
"layouts": 7,
"layoutDurationMs": 1.9099999999999997,
"taskDurationMs": 1678.8690000000001,
"heapDeltaBytes": -19709124,
"heapUsedBytes": 60642704,
"domNodes": -257,
"jsHeapTotalBytes": 1699840,
"scriptDurationMs": 786.8810000000001,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.786956521739132,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2551.4369999999644,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.412,
"layouts": 7,
"layoutDurationMs": 2.2399999999999998,
"taskDurationMs": 1811.6950000000002,
"heapDeltaBytes": -11466204,
"heapUsedBytes": 80984504,
"domNodes": -257,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 844.9440000000001,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.775,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3506.9129999999973,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.224,
"layouts": 62,
"layoutDurationMs": 9.706,
"taskDurationMs": 1691.7410000000002,
"heapDeltaBytes": 3667196,
"heapUsedBytes": 66459888,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 741.9549999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635071090047,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3623.728999999912,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.443,
"layouts": 64,
"layoutDurationMs": 10.458,
"taskDurationMs": 1844.0510000000002,
"heapDeltaBytes": -10818116,
"heapUsedBytes": 66183568,
"domNodes": -233,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 766.6489999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666055045871563,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3202.641999999997,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.561,
"layouts": 5,
"layoutDurationMs": 1.2349999999999997,
"taskDurationMs": 2053.38,
"heapDeltaBytes": 5291400,
"heapUsedBytes": 76560084,
"domNodes": 0,
"jsHeapTotalBytes": 3166208,
"scriptDurationMs": 967.63,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.841052631578947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3217.396000000008,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.34,
"layouts": 5,
"layoutDurationMs": 1.366,
"taskDurationMs": 2108.626,
"heapDeltaBytes": -8092440,
"heapUsedBytes": 70425676,
"domNodes": 0,
"jsHeapTotalBytes": 6942720,
"scriptDurationMs": 1008.7550000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 16,
"frameDurationMs": 17.014659685863872,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3119.162000000017,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.6159999999999994,
"layouts": 6,
"layoutDurationMs": 1.591,
"taskDurationMs": 824.9900000000001,
"heapDeltaBytes": -4938860,
"heapUsedBytes": 78168084,
"domNodes": -257,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 382.357,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66524064171123,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3141.763000000026,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.9979999999999998,
"layouts": 7,
"layoutDurationMs": 2.321,
"taskDurationMs": 845.769,
"heapDeltaBytes": -18121636,
"heapUsedBytes": 74964672,
"domNodes": -257,
"jsHeapTotalBytes": 6193152,
"scriptDurationMs": 382.355,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66595744680851,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2047.4389999999971,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.818,
"layouts": 6,
"layoutDurationMs": 1.578,
"taskDurationMs": 662.464,
"heapDeltaBytes": -13422912,
"heapUsedBytes": 63068072,
"domNodes": -257,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 36.14400000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2044.9649999999338,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.9789999999999999,
"layouts": 7,
"layoutDurationMs": 2.0540000000000003,
"taskDurationMs": 668.5589999999999,
"heapDeltaBytes": 8859076,
"heapUsedBytes": 84996080,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 32.089999999999996,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2781.4649999999974,
"styleRecalcs": 24,
"styleRecalcDurationMs": 10.411000000000001,
"layouts": 4,
"layoutDurationMs": 1.586,
"taskDurationMs": 557.456,
"heapDeltaBytes": 27167036,
"heapUsedBytes": 87164472,
"domNodes": -238,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 171.42200000000003,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66586826347305,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2816.464999999994,
"styleRecalcs": 26,
"styleRecalcDurationMs": 11.315999999999999,
"layouts": 6,
"layoutDurationMs": 1.5530000000000006,
"taskDurationMs": 635.427,
"heapDeltaBytes": -15044696,
"heapUsedBytes": 61359776,
"domNodes": -256,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 188.87300000000002,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568047337278,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3306.363000000005,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.798,
"layouts": 7,
"layoutDurationMs": 1.8670000000000002,
"taskDurationMs": 994.985,
"heapDeltaBytes": -15217228,
"heapUsedBytes": 62431628,
"domNodes": -257,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 376.26599999999996,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666161616161617,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-topology-cadence",
"durationMs": 3346.896999999956,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.4629999999999999,
"layouts": 5,
"layoutDurationMs": 1.3900000000000001,
"taskDurationMs": 1028.633,
"heapDeltaBytes": -11317900,
"heapUsedBytes": 66297740,
"domNodes": -257,
"jsHeapTotalBytes": 6156288,
"scriptDurationMs": 390.72200000000004,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.749,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 599.9060000000327,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.952000000000001,
"layouts": 8,
"layoutDurationMs": 2.2169999999999996,
"taskDurationMs": 434.264,
"heapDeltaBytes": 21330036,
"heapUsedBytes": 82430428,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 142.047,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66944444444444,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 615.1320000000169,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.253,
"layouts": 9,
"layoutDurationMs": 2.5220000000000002,
"taskDurationMs": 449.00199999999995,
"heapDeltaBytes": -1586780,
"heapUsedBytes": 60143980,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 142.62,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66388888888889,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2020.5029999999908,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.763999999999999,
"layouts": 9,
"layoutDurationMs": 2.7990000000000004,
"taskDurationMs": 522.345,
"heapDeltaBytes": 3923684,
"heapUsedBytes": 65954672,
"domNodes": 0,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 9.192,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2024.278000000038,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.5370000000000004,
"layouts": 8,
"layoutDurationMs": 2.498,
"taskDurationMs": 576.4039999999999,
"heapDeltaBytes": 4816508,
"heapUsedBytes": 68072148,
"domNodes": 0,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 11.403999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1725.1799999999946,
"styleRecalcs": 78,
"styleRecalcDurationMs": 13.041,
"layouts": 9,
"layoutDurationMs": 2.3729999999999998,
"taskDurationMs": 830.14,
"heapDeltaBytes": 20123088,
"heapUsedBytes": 82603312,
"domNodes": 0,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 100.876,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384617,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1757.7549999999746,
"styleRecalcs": 79,
"styleRecalcDurationMs": 15.527000000000001,
"layouts": 10,
"layoutDurationMs": 3.814,
"taskDurationMs": 929.4749999999999,
"heapDeltaBytes": 17465800,
"heapUsedBytes": 79739876,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 114.84899999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1436.4029999999843,
"styleRecalcs": 20,
"styleRecalcDurationMs": 20.189,
"layouts": 5,
"layoutDurationMs": 12.316999999999998,
"taskDurationMs": 1049.205,
"heapDeltaBytes": 38002992,
"heapUsedBytes": 114044196,
"domNodes": 16030,
"jsHeapTotalBytes": 13766656,
"scriptDurationMs": 31.391000000000002,
"eventListeners": 3246,
"totalBlockingTimeMs": 164,
"frameDurationMs": 19.59324324324325,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8475.897999999972,
"styleRecalcs": 251,
"styleRecalcDurationMs": 28.330000000000002,
"layouts": 9,
"layoutDurationMs": 2.423,
"taskDurationMs": 6145.518,
"heapDeltaBytes": -327524,
"heapUsedBytes": 81875664,
"domNodes": -257,
"jsHeapTotalBytes": 5070848,
"scriptDurationMs": 2753.101,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66594488188976,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8742.220999999972,
"styleRecalcs": 250,
"styleRecalcDurationMs": 28.169,
"layouts": 8,
"layoutDurationMs": 2.2120000000000006,
"taskDurationMs": 6203.966,
"heapDeltaBytes": -2049848,
"heapUsedBytes": 73126728,
"domNodes": -257,
"jsHeapTotalBytes": 5332992,
"scriptDurationMs": 2784.962,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.697896749521988,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 20551.38900000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20022.187,
"heapDeltaBytes": -22792200,
"heapUsedBytes": 278348600,
"domNodes": -3343,
"jsHeapTotalBytes": 14147584,
"scriptDurationMs": 306.218,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.122382671480146,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-idle",
"durationMs": 20842.912999999953,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20333.407000000003,
"heapDeltaBytes": -23287176,
"heapUsedBytes": 278609912,
"domNodes": -3343,
"jsHeapTotalBytes": 7589888,
"scriptDurationMs": 314.37199999999996,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.334229390681,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 25260.603000000003,
"styleRecalcs": 180,
"styleRecalcDurationMs": 19.958000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24934.3,
"heapDeltaBytes": -36569972,
"heapUsedBytes": 254914624,
"domNodes": -3343,
"jsHeapTotalBytes": 16502784,
"scriptDurationMs": 860.5619999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 17,
"frameDurationMs": 47.25663551401869,
"p95FrameDurationMs": 100
},
{
"name": "vue-large-graph-pan",
"durationMs": 25627.349999999977,
"styleRecalcs": 181,
"styleRecalcDurationMs": 22.028999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 25338.264000000003,
"heapDeltaBytes": -21731720,
"heapUsedBytes": 251488072,
"domNodes": -3343,
"jsHeapTotalBytes": 12308480,
"scriptDurationMs": 856.754,
"eventListeners": -651,
"totalBlockingTimeMs": 3,
"frameDurationMs": 48.60645161290323,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 7454.690000000028,
"styleRecalcs": 20,
"styleRecalcDurationMs": 60.43899999999999,
"layouts": 20,
"layoutDurationMs": 23.485999999999994,
"taskDurationMs": 7373.817,
"heapDeltaBytes": -24633600,
"heapUsedBytes": 271478020,
"domNodes": -3343,
"jsHeapTotalBytes": 18599936,
"scriptDurationMs": 117.429,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.31220930232558,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-node-resize-workload",
"durationMs": 7587.451999999985,
"styleRecalcs": 20,
"styleRecalcDurationMs": 83.85799999999999,
"layouts": 20,
"layoutDurationMs": 25.286,
"taskDurationMs": 7495.897999999999,
"heapDeltaBytes": -33026480,
"heapUsedBytes": 259000316,
"domNodes": -3343,
"jsHeapTotalBytes": 18862080,
"scriptDurationMs": 117.966,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.580459770114956,
"p95FrameDurationMs": 99.90000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10451.478000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10248.657000000001,
"heapDeltaBytes": 14427332,
"heapUsedBytes": 283105468,
"domNodes": 0,
"jsHeapTotalBytes": 21233664,
"scriptDurationMs": 147.08299999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.58812949640288,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10329.373999999916,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10027.151000000002,
"heapDeltaBytes": 9161748,
"heapUsedBytes": 258653356,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 137.59500000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.98823529411764,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "workflow-execution",
"durationMs": 127.95699999998078,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.753,
"layouts": 9,
"layoutDurationMs": 4.566,
"taskDurationMs": 93.82300000000001,
"heapDeltaBytes": 4789996,
"heapUsedBytes": 72374884,
"domNodes": 128,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.824,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662500000000023,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 507.5410000000602,
"styleRecalcs": 21,
"styleRecalcDurationMs": 13.162,
"layouts": 11,
"layoutDurationMs": 4.801,
"taskDurationMs": 143.71100000000004,
"heapDeltaBytes": 6945904,
"heapUsedBytes": 72003764,
"domNodes": 133,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.723,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 523.9729999999554,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.614,
"layouts": 76,
"layoutDurationMs": 15.988999999999999,
"taskDurationMs": 473.92500000000007,
"heapDeltaBytes": -3477444,
"heapUsedBytes": 39197280,
"domNodes": 4,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 226.877,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 545.6870000000436,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.6769999999999999,
"layouts": 76,
"layoutDurationMs": 16.662,
"taskDurationMs": 491.049,
"heapDeltaBytes": -2548888,
"heapUsedBytes": 41226144,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 228.266,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636353,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 583.4209999999302,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.946,
"layouts": 76,
"layoutDurationMs": 15.394,
"taskDurationMs": 551.944,
"heapDeltaBytes": 1328960,
"heapUsedBytes": 99653764,
"domNodes": 4,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 218.46500000000003,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.142857142857142,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 586.689999999976,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.133,
"layouts": 76,
"layoutDurationMs": 16.694,
"taskDurationMs": 544.5219999999999,
"heapDeltaBytes": 1056308,
"heapUsedBytes": 102742876,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 212.673,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.13999999999999,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage: 🟡 59.9% of linesCoverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3130 passed, 0 failed · 4 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 9fba378ca9581d64762730d1616e0009a28e7ef9
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (246)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 5 Pipeline jobs failed
Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: 39aed79 | Docs | View more details | Give us feedback! |
dante01yoon
left a comment
There was a problem hiding this comment.
Backport approval: LGTM.
…menu (DES-1279) (#21858) ## Summary In the Run bar's deployment menu, only a ready deployment can be picked. Today a stopped deployment can be picked, and then Run does nothing. - A row whose deployment is not ready is disabled. Choosing it does nothing, and arrow keys skip it. - Its names are dimmed. Its status keeps full contrast. - Hovering the row says why in a tooltip to the left of the menu. It says that the deployment is starting, that it is not running (start it on the Developer Platform, then pick it), or that it is not ready. The row's accessible description says the same. The row this browser already runs on gives no reason, because the notice and the engine button already cover it. - If the row also cannot run the open workflow, the tooltip gives the reason first, then the missing nodes. Part of DES-1279. Starting a deployment from the menu is #21839, stacked on this PR. Base: `willie/des-1280-comfyui_frontend-refine-the-layout-of-the-run-bars` (#21836). After #21836 merges I will rebase this branch onto `main` and retarget it. ## Review focus - Rebased on the new #21836, which groups the rows by whether they run the workflow and keeps the current deployment at the top, and on main past #20373 and #21897. `useDeploymentRows.ts` adds `pickable` and the reason to each row. `pickable` is the listing's `status === 'ready'`, wrapped as `pendingServerFact('BE-24332', …)` until the listing says which deployments may be picked (BE-24332 asks for a `can_pick` field). Comfy Cloud is always pickable. - The row's `missingNodes` prop becomes `note`, because it now carries the reason, the missing nodes, or both. - The row uses reka's `disabled`, which sets `aria-disabled` and blocks select. reka also fades a disabled item to 50% opacity. That would fail contrast on the status text, so a disabled row keeps full opacity and dims only its names. While a switch is in flight, these rows fade with the rest. - Copy: three reason strings and one follow-on sentence for the missing nodes. English only: the release workflow translates the other catalogs. ## Verification - Unit: `src/platform/workspace` passes at this head, 1,410 tests. New tests: only a ready row switches, the reason each status gives, no reason on the current row, and the reason followed by the missing nodes. Two existing tests change because a stopped row is no longer pickable. - Pre-commit hooks, `fallow audit` and `typecheck:app` pass. - Browser: a local Cloud dev build with a mocked listing and a mocked compatibility answer, Nodes 2.0, 1440 px. ## Screenshots | Groups, a starting row hovered | A stopped row | A starting row | | --- | --- | --- | | <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/ea2c3f3a6cb2b105385e4e50c719108c3d09b1af/DES-1279r-v5-s2-sections-missing-tooltip.png"> | <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/a642ac95f63b3b7825d2086ded1d460d28b25cd2/DES-1279r-v4-ra-01-stopped-reason.png"> | <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/a642ac95f63b3b7825d2086ded1d460d28b25cd2/DES-1279r-v4-ra-02-starting-reason.png"> | --------- Co-authored-by: Benjamin Lu <benjaminlu1107@gmail.com> (cherry picked from commit 985ff8e)
e2b2258 to
39aed79
Compare
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## bl/cloud-1.59-deployment-menu #22535 +/- ##
=================================================================
- Coverage 87.25% 87.24% -0.01%
=================================================================
Files 3040 3040
Lines 159862 159899 +37
Branches 40154 42672 +2518
=================================================================
+ Hits 139484 139511 +27
- Misses 19699 19709 +10
Partials 679 679
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Summary
Backport of #21858 to
cloud/1.59. Stopped and starting deployments cannot be selected from the Run on menu; their rows explain why.Part 3 of 9 in the Cloud workflow deployment backport stack. Applies on the preceding menu backport; the Start action is supplied by part 8.
Verification
cloud/1.59at7482c071; application typecheck passes on every layer. The expanded stack, including deployment Start/Retry, passes 23,186 of 23,187 affected tests across 1,269 files; the one failure, inSignUpForm.test.ts, is intermittent and also fails oncloud/1.59without this stack. Formatting, affected-file lint, dependency audit and pre-push checks pass.cc9bd948, including a successful job after switching deployments. Browser QA has not been repeated on this release-branch build.