Repository navigation
fix(workspace): read a deployment's readiness from the typed status, drop the BE-24332 bridge - #22334
Conversation
…he BE-24332 bridge
📦 Bundle: 12 MB gzip 🟢 -29 BDetailsSummary
Category Glance App Entry Points — 6.71 kB (baseline 6.71 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 2.59 MB (baseline 2.59 MB) • 🟢 -31 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed / 2 unchanged Views & Navigation — 148 kB (baseline 148 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 873 kB (baseline 873 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 2 added / 2 removed / 33 unchanged User & Accounts — 159 kB (baseline 159 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 18 unchanged Editors & Dialogs — 502 kB (baseline 502 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 17 unchanged UI Components — 359 kB (baseline 359 kB) • ⚪ 0 BReusable component library chunks Status: 31 unchanged Data & Services — 1.91 MB (baseline 1.91 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 1 added / 1 removed / 41 unchanged Utilities & Hooks — 2.43 MB (baseline 2.43 MB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 84 unchanged Vendor & Third-Party — 9.69 MB (baseline 9.69 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 34.8 MB (baseline 34.8 MB) • ⚪ 0 BBundles that do not match a named category
Status: 2 added / 2 removed / 746 unchanged ⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-30T01:31:35.958Z",
"gitSha": "3df4e0abffb24d15d4ea4016996b1bbb5288b5d4",
"branch": "vinh/be-24332-drop-pending-fact",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2023.9550000000008,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.997,
"layouts": 11,
"layoutDurationMs": 3.08,
"taskDurationMs": 561.476,
"heapDeltaBytes": -12825008,
"heapUsedBytes": 63860520,
"domNodes": -173,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 8.052,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-idle",
"durationMs": 2008.2830000000058,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.3519999999999994,
"layouts": 9,
"layoutDurationMs": 2.419,
"taskDurationMs": 515.743,
"heapDeltaBytes": 4666064,
"heapUsedBytes": 74638392,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 8.003999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1777.9199999999946,
"styleRecalcs": 75,
"styleRecalcDurationMs": 11.692999999999998,
"layouts": 8,
"layoutDurationMs": 2.118,
"taskDurationMs": 872.9899999999999,
"heapDeltaBytes": 21577348,
"heapUsedBytes": 83631812,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 159.905,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665420560747663,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1788.447999999903,
"styleRecalcs": 76,
"styleRecalcDurationMs": 12.402000000000001,
"layouts": 11,
"layoutDurationMs": 2.8369999999999997,
"taskDurationMs": 912.767,
"heapDeltaBytes": 5111592,
"heapUsedBytes": 75146252,
"domNodes": -173,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 155.54000000000002,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665420560747663,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1698.9709999999718,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.132000000000001,
"layouts": 11,
"layoutDurationMs": 2.717,
"taskDurationMs": 388.1329999999999,
"heapDeltaBytes": 20279156,
"heapUsedBytes": 79587472,
"domNodes": 57,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 9.597000000000001,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.5719999999665,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.603000000000001,
"layouts": 12,
"layoutDurationMs": 2.9369999999999994,
"taskDurationMs": 388.177,
"heapDeltaBytes": 851572,
"heapUsedBytes": 71424836,
"domNodes": 57,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 9.128999999999998,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 667.1390000000201,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.0300000000000002,
"layouts": 8,
"layoutDurationMs": 1.809,
"taskDurationMs": 489.77000000000004,
"heapDeltaBytes": 6227456,
"heapUsedBytes": 67741320,
"domNodes": 0,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 166.897,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669230769230754,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 642.3490000000811,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.333,
"layouts": 9,
"layoutDurationMs": 2.3590000000000004,
"taskDurationMs": 482.719,
"heapDeltaBytes": 6303396,
"heapUsedBytes": 75130396,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 166.88,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1212.3060000000123,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 906.0970000000001,
"heapDeltaBytes": -13591564,
"heapUsedBytes": 74685248,
"domNodes": -203,
"jsHeapTotalBytes": 21241856,
"scriptDurationMs": 67.287,
"eventListeners": -106,
"totalBlockingTimeMs": 531,
"frameDurationMs": 32.87837837837838,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1144.5509999999786,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 837.997,
"heapDeltaBytes": 14675380,
"heapUsedBytes": 83469660,
"domNodes": 0,
"jsHeapTotalBytes": 10649600,
"scriptDurationMs": 64.58500000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 524,
"frameDurationMs": 33.8235294117647,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 894.0099999999802,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 560.2369999999999,
"heapDeltaBytes": -14864484,
"heapUsedBytes": 65681740,
"domNodes": -203,
"jsHeapTotalBytes": 1441792,
"scriptDurationMs": 170.80499999999998,
"eventListeners": -106,
"totalBlockingTimeMs": 239,
"frameDurationMs": 24.997222222222213,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 907.8059999999368,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 548.3469999999998,
"heapDeltaBytes": -27868848,
"heapUsedBytes": 67136488,
"domNodes": -203,
"jsHeapTotalBytes": 3801088,
"scriptDurationMs": 166.55599999999998,
"eventListeners": -106,
"totalBlockingTimeMs": 222,
"frameDurationMs": 24.321621621621638,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11896.897999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11107.973,
"heapDeltaBytes": 82720156,
"heapUsedBytes": 165072416,
"domNodes": -269,
"jsHeapTotalBytes": 91877376,
"scriptDurationMs": 9122.810999999998,
"eventListeners": -68,
"totalBlockingTimeMs": 1835,
"frameDurationMs": 32.87154696132597,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9785.981999999989,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9023.302,
"heapDeltaBytes": 36350484,
"heapUsedBytes": 129248200,
"domNodes": -269,
"jsHeapTotalBytes": 66973696,
"scriptDurationMs": 7181.0070000000005,
"eventListeners": -68,
"totalBlockingTimeMs": 681,
"frameDurationMs": 31.35544871794872,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10719.303000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9922.76,
"heapDeltaBytes": 46838004,
"heapUsedBytes": 141496560,
"domNodes": -269,
"jsHeapTotalBytes": 77983744,
"scriptDurationMs": 8011.489000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 977,
"frameDurationMs": 31.334210526315793,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10897.816000000035,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.0430000000000005,
"layouts": 1,
"layoutDurationMs": 0.2069999999999997,
"taskDurationMs": 10148.79,
"heapDeltaBytes": 50681732,
"heapUsedBytes": 145994236,
"domNodes": -269,
"jsHeapTotalBytes": 80605184,
"scriptDurationMs": 8313.139,
"eventListeners": -68,
"totalBlockingTimeMs": 1344,
"frameDurationMs": 31.963636363636358,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-combo-open",
"durationMs": 304.2570000000069,
"styleRecalcs": 26,
"styleRecalcDurationMs": 13.455000000000002,
"layouts": 12,
"layoutDurationMs": 3.2540000000000004,
"taskDurationMs": 253.55099999999996,
"heapDeltaBytes": -21035428,
"heapUsedBytes": 62246988,
"domNodes": 936,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 9.075000000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 3,
"frameDurationMs": 23.076923076923077,
"p95FrameDurationMs": 100
},
{
"name": "large-combo-open",
"durationMs": 267.81000000005406,
"styleRecalcs": 25,
"styleRecalcDurationMs": 16.756,
"layouts": 14,
"layoutDurationMs": 4.7860000000000005,
"taskDurationMs": 250.654,
"heapDeltaBytes": 2529336,
"heapUsedBytes": 70826680,
"domNodes": 713,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 16.413,
"eventListeners": 73,
"totalBlockingTimeMs": 7,
"frameDurationMs": 26.670000000000027,
"p95FrameDurationMs": 116.80000000000018
},
{
"name": "large-graph-idle",
"durationMs": 2039.6309999999858,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.809,
"layouts": 8,
"layoutDurationMs": 2.1270000000000002,
"taskDurationMs": 640.8140000000001,
"heapDeltaBytes": 111664,
"heapUsedBytes": 73562608,
"domNodes": -269,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 30.704999999999995,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2054.8860000000104,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.0610000000000004,
"layouts": 8,
"layoutDurationMs": 1.9689999999999999,
"taskDurationMs": 629.8159999999999,
"heapDeltaBytes": -22773816,
"heapUsedBytes": 70460140,
"domNodes": -269,
"jsHeapTotalBytes": 4882432,
"scriptDurationMs": 31.46,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2392.066,
"styleRecalcs": 68,
"styleRecalcDurationMs": 7.814999999999999,
"layouts": 6,
"layoutDurationMs": 1.6449999999999998,
"taskDurationMs": 1672.7,
"heapDeltaBytes": 11309104,
"heapUsedBytes": 85888672,
"domNodes": -269,
"jsHeapTotalBytes": 4808704,
"scriptDurationMs": 821.708,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665734265734265,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2566.9860000000426,
"styleRecalcs": 69,
"styleRecalcDurationMs": 7.744999999999999,
"layouts": 8,
"layoutDurationMs": 2.0039999999999996,
"taskDurationMs": 1727.9630000000002,
"heapDeltaBytes": -10322668,
"heapUsedBytes": 81661484,
"domNodes": -269,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 847.6539999999999,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.77516339869281,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3666.6589999999815,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.258,
"layouts": 65,
"layoutDurationMs": 10.205,
"taskDurationMs": 1769.082,
"heapDeltaBytes": -20739820,
"heapUsedBytes": 71175856,
"domNodes": -245,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 764.9169999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66590909090909,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3894.1519999999628,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.745,
"layouts": 64,
"layoutDurationMs": 9.809000000000001,
"taskDurationMs": 1837.1430000000003,
"heapDeltaBytes": 12127804,
"heapUsedBytes": 84116308,
"domNodes": -245,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 785.454,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665811965811965,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3068.052000000023,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.6770000000000005,
"layouts": 6,
"layoutDurationMs": 1.431,
"taskDurationMs": 1946.178,
"heapDeltaBytes": 21621332,
"heapUsedBytes": 99969160,
"domNodes": 0,
"jsHeapTotalBytes": 6447104,
"scriptDurationMs": 966.6740000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.84728260869565,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2959.985999999958,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.537999999999999,
"layouts": 5,
"layoutDurationMs": 1.1720000000000004,
"taskDurationMs": 1935.205,
"heapDeltaBytes": 22470832,
"heapUsedBytes": 95235044,
"domNodes": 0,
"jsHeapTotalBytes": 4087808,
"scriptDurationMs": 948.028,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.760451977401125,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3095.956000000001,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.2319999999999998,
"layouts": 8,
"layoutDurationMs": 2.351,
"taskDurationMs": 772.771,
"heapDeltaBytes": -24136916,
"heapUsedBytes": 67598880,
"domNodes": -269,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 366.787,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666486486486487,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3072.2339999999804,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.5649999999999995,
"layouts": 6,
"layoutDurationMs": 1.5629999999999997,
"taskDurationMs": 770.518,
"heapDeltaBytes": -8402328,
"heapUsedBytes": 86079272,
"domNodes": -269,
"jsHeapTotalBytes": -622592,
"scriptDurationMs": 355.741,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66576086956522,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2046.9930000000431,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.908,
"layouts": 7,
"layoutDurationMs": 1.9420000000000002,
"taskDurationMs": 624.35,
"heapDeltaBytes": -20237672,
"heapUsedBytes": 72114564,
"domNodes": -269,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 31.758999999999997,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406507,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2047.916999999984,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.9770000000000005,
"layouts": 7,
"layoutDurationMs": 2.102,
"taskDurationMs": 633.559,
"heapDeltaBytes": -22182008,
"heapUsedBytes": 70839812,
"domNodes": -269,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 32.061,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2718.357000000026,
"styleRecalcs": 21,
"styleRecalcDurationMs": 9.449000000000002,
"layouts": 2,
"layoutDurationMs": 0.42099999999999993,
"taskDurationMs": 552.696,
"heapDeltaBytes": 565432,
"heapUsedBytes": 62463908,
"domNodes": 19,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 191.024,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66625766871166,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2762.6530000000002,
"styleRecalcs": 27,
"styleRecalcDurationMs": 12.277999999999999,
"layouts": 8,
"layoutDurationMs": 1.9329999999999998,
"taskDurationMs": 596.8389999999999,
"heapDeltaBytes": -3536372,
"heapUsedBytes": 72088104,
"domNodes": -266,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 190.658,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665454545454548,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3227.13200000004,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.151,
"layouts": 5,
"layoutDurationMs": 1.1160000000000003,
"taskDurationMs": 916.649,
"heapDeltaBytes": 4342760,
"heapUsedBytes": 79396800,
"domNodes": -269,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 365.40299999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66580310880829,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-topology-cadence",
"durationMs": 3282.29500000009,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.7470000000000003,
"layouts": 7,
"layoutDurationMs": 1.738,
"taskDurationMs": 927.209,
"heapDeltaBytes": -4894524,
"heapUsedBytes": 70280740,
"domNodes": -269,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 361.827,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665816326530614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 607.4879999999894,
"styleRecalcs": 46,
"styleRecalcDurationMs": 3.9180000000000006,
"layouts": 8,
"layoutDurationMs": 1.687,
"taskDurationMs": 418.8109999999999,
"heapDeltaBytes": 21771820,
"heapUsedBytes": 83576652,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 142.31199999999998,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663888888888877,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 597.8890000000092,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.113,
"layouts": 8,
"layoutDurationMs": 2.1910000000000003,
"taskDurationMs": 436.829,
"heapDeltaBytes": -1777764,
"heapUsedBytes": 61081724,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 146.257,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2021.6570000000047,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.087,
"layouts": 8,
"layoutDurationMs": 2.112,
"taskDurationMs": 511.0809999999999,
"heapDeltaBytes": 1814192,
"heapUsedBytes": 64215432,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 7.49,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2007.9600000000255,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.135,
"layouts": 9,
"layoutDurationMs": 2.4759999999999995,
"taskDurationMs": 508.57400000000007,
"heapDeltaBytes": 2964980,
"heapUsedBytes": 65276764,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 7.487000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.150000000036,
"styleRecalcs": 76,
"styleRecalcDurationMs": 11.625,
"layouts": 8,
"layoutDurationMs": 2.032,
"taskDurationMs": 769.318,
"heapDeltaBytes": 18523576,
"heapUsedBytes": 81682716,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 100.62199999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.3859999999286,
"styleRecalcs": 77,
"styleRecalcDurationMs": 12.732999999999997,
"layouts": 9,
"layoutDurationMs": 2.3339999999999996,
"taskDurationMs": 804.336,
"heapDeltaBytes": -5447972,
"heapUsedBytes": 66556088,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 102.143,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666666,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1435.3039999999737,
"styleRecalcs": 18,
"styleRecalcDurationMs": 22.177999999999997,
"layouts": 5,
"layoutDurationMs": 16.475,
"taskDurationMs": 1030.2079999999999,
"heapDeltaBytes": 13977480,
"heapUsedBytes": 114469412,
"domNodes": 16029,
"jsHeapTotalBytes": 15863808,
"scriptDurationMs": 30.663000000000004,
"eventListeners": 3246,
"totalBlockingTimeMs": 151,
"frameDurationMs": 19.594594594594593,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8635.373000000016,
"styleRecalcs": 247,
"styleRecalcDurationMs": 25.31,
"layouts": 5,
"layoutDurationMs": 1.186,
"taskDurationMs": 5816.747,
"heapDeltaBytes": 6305144,
"heapUsedBytes": 85250952,
"domNodes": -269,
"jsHeapTotalBytes": 90112,
"scriptDurationMs": 2665.824,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66595744680851,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8644.041000000016,
"styleRecalcs": 251,
"styleRecalcDurationMs": 25.615,
"layouts": 8,
"layoutDurationMs": 1.7510000000000001,
"taskDurationMs": 6125.553,
"heapDeltaBytes": -22303304,
"heapUsedBytes": 67538596,
"domNodes": -269,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 2930.158,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69825918762089,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 23057.22800000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22194.17,
"heapDeltaBytes": -41172404,
"heapUsedBytes": 261066128,
"domNodes": -3343,
"jsHeapTotalBytes": 9949184,
"scriptDurationMs": 330.52000000000004,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.012455516014235,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-large-graph-idle",
"durationMs": 23047.95300000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22262.63,
"heapDeltaBytes": -41105768,
"heapUsedBytes": 260364620,
"domNodes": -3343,
"jsHeapTotalBytes": 8904704,
"scriptDurationMs": 303.586,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.67125645438898,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 27617.683999999997,
"styleRecalcs": 181,
"styleRecalcDurationMs": 17.235,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27223.439,
"heapDeltaBytes": -4454276,
"heapUsedBytes": 272236808,
"domNodes": -3343,
"jsHeapTotalBytes": 17293312,
"scriptDurationMs": 851.875,
"eventListeners": -651,
"totalBlockingTimeMs": 43,
"frameDurationMs": 50.67082568807339,
"p95FrameDurationMs": 116.69999999999709
},
{
"name": "vue-large-graph-pan",
"durationMs": 27479.240000000005,
"styleRecalcs": 181,
"styleRecalcDurationMs": 17.573000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27099.536999999997,
"heapDeltaBytes": 29644732,
"heapUsedBytes": 287279884,
"domNodes": -3036,
"jsHeapTotalBytes": 9629696,
"scriptDurationMs": 855.37,
"eventListeners": -644,
"totalBlockingTimeMs": 31,
"frameDurationMs": 50.61178637200737,
"p95FrameDurationMs": 100.10000000000036
},
{
"name": "vue-node-resize-workload",
"durationMs": 8143.842000000006,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.04299999999998,
"layouts": 20,
"layoutDurationMs": 33.35399999999999,
"taskDurationMs": 8058.049000000001,
"heapDeltaBytes": -44041424,
"heapUsedBytes": 258246108,
"domNodes": -3343,
"jsHeapTotalBytes": 17289216,
"scriptDurationMs": 130.41000000000003,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.10809248554913,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 8274.799999999914,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.99600000000001,
"layouts": 20,
"layoutDurationMs": 33.77799999999999,
"taskDurationMs": 8124.057000000001,
"heapDeltaBytes": -24812172,
"heapUsedBytes": 253247308,
"domNodes": -3343,
"jsHeapTotalBytes": 17817600,
"scriptDurationMs": 139.73499999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.968181818181826,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11377.072999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10955.616999999998,
"heapDeltaBytes": -15439516,
"heapUsedBytes": 263862720,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 148.43100000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.84914675767918,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11385.23100000009,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10997.705,
"heapDeltaBytes": -5044940,
"heapUsedBytes": 271977920,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 143.19700000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.71734693877551,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "workflow-execution",
"durationMs": 165.90800000005856,
"styleRecalcs": 10,
"styleRecalcDurationMs": 12.341999999999999,
"layouts": 8,
"layoutDurationMs": 4.395,
"taskDurationMs": 122.99,
"heapDeltaBytes": 4836236,
"heapUsedBytes": 65549704,
"domNodes": 128,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.904,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.5222222222222,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "workflow-execution",
"durationMs": 124.00000000002365,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.02,
"layouts": 10,
"layoutDurationMs": 2.733,
"taskDurationMs": 78.91699999999999,
"heapDeltaBytes": 4606768,
"heapUsedBytes": 72452600,
"domNodes": 98,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.04,
"eventListeners": 3,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428546,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 526.7479999999978,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.611,
"layouts": 76,
"layoutDurationMs": 14.741999999999999,
"taskDurationMs": 470.32099999999997,
"heapDeltaBytes": -3678324,
"heapUsedBytes": 41315160,
"domNodes": 4,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 230.613,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 503.125999999952,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.6130000000000001,
"layouts": 76,
"layoutDurationMs": 14.865,
"taskDurationMs": 451.433,
"heapDeltaBytes": -4035044,
"heapUsedBytes": 39466544,
"domNodes": 4,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 218.527,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 525.8190000000695,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.516,
"layouts": 76,
"layoutDurationMs": 13.991999999999999,
"taskDurationMs": 489.15099999999995,
"heapDeltaBytes": 1209636,
"heapUsedBytes": 102744452,
"domNodes": 4,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 201.27499999999998,
"eventListeners": 296,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 491.6329999999789,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.686,
"layouts": 76,
"layoutDurationMs": 14.293,
"taskDurationMs": 454.20200000000006,
"heapDeltaBytes": 329116,
"heapUsedBytes": 102703816,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 177.94099999999997,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.237931034482745,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 60.0% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3173 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since c60607150258f31a8e8c21cc22cb5ff8920e78c5
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (260)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Walkthrough
Merge Risk:
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #22334 +/- ##
==========================================
- Coverage 87.51% 87.41% -0.10%
==========================================
Files 2939 2831 -108
Lines 159592 156203 -3389
Branches 41750 40577 -1173
==========================================
- Hits 139673 136551 -3122
+ Misses 18998 18897 -101
+ Partials 921 755 -166
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 118 files with indirect coverage changes 🚀 New features to boost your workflow:
|
james00012
left a comment
There was a problem hiding this comment.
Approve.
I read this as: the Run on menu's ready check sat behind an identity bridge until the API typed status; it now reads status === 'ready' from the generated nine-value type, with no change a user sees. Reviewed at cf076c0.
Checked: the generated WorkspaceDeployment.status on main already carries the nine values from cloud#16954, and the existing test pins a ready row as picked.
dante01yoon
left a comment
There was a problem hiding this comment.
LGTM. This change doesn't alter behavior: pendingServerFact(id, expr) only returns expr, so deploymentRowAction behaves exactly as before.
I checked the server-facts gate against the contract. In @comfyorg/ingest-types, WorkspaceDeployment.status is now an enum of comfy-deploy's values, documented as "a job is taken only while it is ready". So status === 'ready' reads a server fact directly and doesn't derive one, which makes dropping the BE-24332 bridge correct per ADR-0042. The existing 'pick' cases in deploymentStartState.test.ts still cover the branch.
I agree that the still-red scheduled check (BE-20674 canSetDefault in deploymentPickStore.ts) is out of scope here.
Checks: pnpm exec vitest run src/platform/workspace/deploymentStartState.test.ts passes; CI is green. I did not run Playwright locally.
|
Thanks for checking it against the ingest-types contract. Nothing to change: you confirmed behaviour is the same and the |
…drop the BE-24332 bridge (#22334) The Run on menu lets a user pick a deployment only while it is ready. Until now the menu worked that out behind a `pendingServerFact('BE-24332', ...)` bridge, waiting for the server to say which deployments take a job. **Why** The menu's check sat behind `pendingServerFact('BE-24332', ...)` because the server's listing typed `status` as a plain string, so nothing said which value takes a job. Comfy-Org/cloud#16954 (in production) types it as comfy-deploy's nine values and documents `ready` as the only one that does. So the menu reads `deployment.status === 'ready'` straight from the typed field, and the bridge goes. With BE-24332 Done, the scheduled pending-server-facts check flags this bridge. The check stays red after this merges: BE-20674 is Canceled and still bridges `canSetDefault` in `src/platform/workspace/stores/deploymentPickStore.ts`, which this PR leaves as it is. **What a user sees:** nothing changes. A ready deployment can be picked; a stopped or starting one cannot, as before. ## What changed - `src/platform/workspace/deploymentStartState.ts`: `deploymentRowAction` checks `deployment.status === 'ready'` directly; the `pendingServerFact` import goes. ## Tests - `vitest run src/platform/workspace/`: 42 files, 999 tests pass. - `vue-tsc --noEmit` and `eslint` on the file pass. Not run: the browser test `browser_tests/tests/workspaceSwitcher.spec.ts`; CI runs it. Ref BE-24332 (cherry picked from commit 1faef98)
#22544) ## Summary Backport of #22334 to `cloud/1.59`, part 9 of 9 in the Homestead Cloud stack. Removes the obsolete BE-24332 bridge now that #22027 provides the deployment-status enum on `cloud/1.59`. Ready-only selection is unchanged. ## Verification - Applied without conflicts. The expanded stack passes 23,186 of 23,187 affected tests across 1,269 files, including deployment row decisions and Start/Retry behavior; the one failure, in `SignUpForm.test.ts`, also fails on `cloud/1.59` without this stack. - Normal push checks pass. Remote CI and browser QA on the expanded release-branch build remain pending. Co-authored-by: Vinh <vqt123@gmail.com>
The Run on menu lets a user pick a deployment only while it is ready. Until now the menu worked that out behind a
pendingServerFact('BE-24332', ...)bridge, waiting for the server to say which deployments take a job.Why
The menu's check sat behind
pendingServerFact('BE-24332', ...)because the server's listing typedstatusas a plain string, so nothing said which value takes a job. Comfy-Org/cloud#16954 (in production) types it as comfy-deploy's nine values and documentsreadyas the only one that does. So the menu readsdeployment.status === 'ready'straight from the typed field, and the bridge goes.With BE-24332 Done, the scheduled pending-server-facts check flags this bridge. The check stays red after this merges: BE-20674 is Canceled and still bridges
canSetDefaultinsrc/platform/workspace/stores/deploymentPickStore.ts, which this PR leaves as it is.What a user sees: nothing changes. A ready deployment can be picked; a stopped or starting one cannot, as before.
What changed
src/platform/workspace/deploymentStartState.ts:deploymentRowActionchecksdeployment.status === 'ready'directly; thependingServerFactimport goes.Tests
vitest run src/platform/workspace/: 42 files, 999 tests pass.vue-tsc --noEmitandeslinton the file pass.Not run: the browser test
browser_tests/tests/workspaceSwitcher.spec.ts; CI runs it.Ref BE-24332