Repository navigation
feat(extensions): identify agent-created additions - #21787
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Extension identity and persistence src/types/*, src/platform/settings/settingStore.ts, src/stores/extensionStore.ts |
Extension and settings types support provenance, disabled packs, boot-time state, queued writes, rollback, and explicit write outcomes. |
Discovery and toast actions src/services/extensionLoader.ts, src/components/ui/toast/*, src/types/toastOptions.ts |
The loader filters disabled packs, announces unseen agent-created extensions, and offers Manage and Disable actions. Toasts render and announce each action. |
Settings navigation and deep links src/platform/settings/composables/*, src/platform/settings/components/SettingDialog.vue, src/platform/navigation/preservedQueryDefinitions.ts |
Settings navigation carries a panel, optional extension filter, and request ID. URL handling maps filter=agent to the agentCreated filter. |
Extension settings and disable controls src/platform/settings/agentExtensionService.ts, src/platform/settings/components/*, src/locales/en/main.json, browser_tests/tests/settings/* |
The settings panel displays provenance and pack details, supports agent-created filtering and disabling, and reports failed saves. |
Sidebar controls src/components/sidebar/* |
Agent-created sidebar tabs show an AI badge and offer Manage and Disable context-menu actions. |
Priority:
Estimated code review effort: 4 (Complex) | ~45 minutes
Change: Feature
Sequence Diagram(s)
sequenceDiagram
participant ExtensionLoader
participant extensionStore
participant Toast
participant User
participant SettingsPanel
ExtensionLoader->>extensionStore: Load agent extensions and disabled pack paths
ExtensionLoader->>Toast: Show Manage and Disable actions
User->>Toast: Select an action
Toast->>SettingsPanel: Open filtered settings or start disabling extensions
SettingsPanel->>extensionStore: Persist disabled names and pack paths
extensionStore-->>SettingsPanel: Return write result
Possibly related PRs
- Comfy-Org/ComfyUI_frontend#21673: Changes
loadExtensions()and the core-extension registration flow used before agent-extension discovery. - Comfy-Org/ComfyUI_frontend#21786: Adds the disabled-pack setting, serialized saves, rollback-aware writes, and the pre-import pack gate used here.
- Comfy-Org/ComfyUI_frontend#21908: Changes the toast contract to
actions, which this change also uses for agent-extension notifications.
Merge Risk: 
Minimal · up to e4ff9
-
The change adds rollback-aware settings writes with explicit outcomes. Callers serialize their writes, so the reported local/saved divergence does not occur. No merge-blocking risk remains from this review.
Pre-merge checks: 
7
-
Full details: End-To-End Test Suggestion For User-Facing Changes
-
Explanation
The PR changes user-facing extension provenance, agent-created filtering, bulk disable, and extension-pack behavior under src/. It also adds browser_tests/tests/settings/agentExtensionProvenance.spec.ts, extensionPackGate.spec.ts, extensionPackSaveFailure.spec.ts, and extensionDisableSaveFailure.spec.ts to exercise these features and failure paths. This check therefore passes.
Full details: Adr Compliance For Entity/Litegraph Changes
-
Explanation
PASS. The changed-file list contains no files under
src/lib/litegraph/orsrc/ecs/, and no files that modify graph entities such as nodes, links, widgets, slots, reroutes, groups, or subgraphs.src/components/graph/GraphCanvas.test.tsonly updates a toast-action test and does not change graph entities. The ADR checks do not apply.
Full details: Description check
-
Explanation
The description provides a detailed Summary and a comprehensive Test plan covering automated tests, browser verification, negative controls, CI results, warnings, and known ownership decisions. It uses “## Test plan” instead of the template’s “## Verification” heading, but the required verification information is present.
-
Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
CI annotation context is incomplete: annotation collection unavailable or limited
Comment @coderabbitai help to get the list of available commands.
📦 Bundle: 12 MB gzip 🔴 +2.35 kBDetailsSummary
Category Glance App Entry Points — 6.71 kB (baseline 6.71 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 2.59 MB (baseline 2.59 MB) • 🔴 +5.74 kBGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 148 kB (baseline 148 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 878 kB (baseline 878 kB) • 🔴 +90 BConfiguration panels, inspectors, and settings screens
Status: 14 added / 14 removed / 21 unchanged User & Accounts — 159 kB (baseline 159 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 11 added / 11 removed / 7 unchanged Editors & Dialogs — 502 kB (baseline 502 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 11 added / 11 removed / 6 unchanged UI Components — 359 kB (baseline 359 kB) • ⚪ 0 BReusable component library chunks
Status: 10 added / 10 removed / 21 unchanged Data & Services — 1.92 MB (baseline 1.92 MB) • 🔴 +1.13 kBStores, services, APIs, and repositories
Status: 38 added / 38 removed / 4 unchanged Utilities & Hooks — 2.43 MB (baseline 2.43 MB) • 🔴 +1.9 kBHelpers, composables, and utility bundles
Status: 49 added / 49 removed / 34 unchanged Vendor & Third-Party — 9.69 MB (baseline 9.69 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 34.8 MB (baseline 34.8 MB) • 🔴 +2.95 kBBundles that do not match a named category
Status: 118 added / 118 removed / 632 unchanged ⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-30T02:35:54.170Z",
"gitSha": "f784f89c19f47087061700f255e2568bd64ff522",
"branch": "agent/oploop-919b-fe3475",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2014.4229999999652,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.5319999999999996,
"layouts": 9,
"layoutDurationMs": 2.4240000000000004,
"taskDurationMs": 559.953,
"heapDeltaBytes": 4612252,
"heapUsedBytes": 64448068,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 8.647000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198342,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-idle",
"durationMs": 2023.51299999998,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.617,
"layouts": 10,
"layoutDurationMs": 2.9909999999999997,
"taskDurationMs": 564.808,
"heapDeltaBytes": 8387520,
"heapUsedBytes": 69331308,
"domNodes": -178,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 8.132999999999997,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66475409836066,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1746.0510000000227,
"styleRecalcs": 74,
"styleRecalcDurationMs": 12.463000000000001,
"layouts": 8,
"layoutDurationMs": 2.027,
"taskDurationMs": 880.1849999999998,
"heapDeltaBytes": 1943864,
"heapUsedBytes": 63423080,
"domNodes": 0,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 158.488,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714287,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1750.868999999966,
"styleRecalcs": 74,
"styleRecalcDurationMs": 12.065000000000003,
"layouts": 8,
"layoutDurationMs": 1.95,
"taskDurationMs": 853.991,
"heapDeltaBytes": 23744736,
"heapUsedBytes": 84025472,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 157.75499999999997,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714284,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1690.8650000000307,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.505999999999999,
"layouts": 10,
"layoutDurationMs": 2.666,
"taskDurationMs": 406.651,
"heapDeltaBytes": -912012,
"heapUsedBytes": 59373992,
"domNodes": 57,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 9.770999999999999,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.7390000000096,
"styleRecalcs": 20,
"styleRecalcDurationMs": 4.702,
"layouts": 12,
"layoutDurationMs": 2.757,
"taskDurationMs": 407.806,
"heapDeltaBytes": 7099632,
"heapUsedBytes": 79354536,
"domNodes": 57,
"jsHeapTotalBytes": 14942208,
"scriptDurationMs": 9.812999999999999,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 685.1060000000189,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.7270000000000003,
"layouts": 9,
"layoutDurationMs": 2.531,
"taskDurationMs": 506.69100000000003,
"heapDeltaBytes": -16011340,
"heapUsedBytes": 60574224,
"domNodes": 0,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 170.196,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 637.1380000000499,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.0389999999999997,
"layouts": 8,
"layoutDurationMs": 2.202,
"taskDurationMs": 480.46299999999997,
"heapDeltaBytes": 2371760,
"heapUsedBytes": 61984952,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 168.069,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684203,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1210.8789999999772,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 903.7040000000001,
"heapDeltaBytes": -10325224,
"heapUsedBytes": 77980016,
"domNodes": -208,
"jsHeapTotalBytes": 20979712,
"scriptDurationMs": 76.833,
"eventListeners": -106,
"totalBlockingTimeMs": 523,
"frameDurationMs": 32.87837837837838,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1196.4249999999765,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 893.845,
"heapDeltaBytes": -11019388,
"heapUsedBytes": 77135472,
"domNodes": -208,
"jsHeapTotalBytes": 22552576,
"scriptDurationMs": 66.712,
"eventListeners": -106,
"totalBlockingTimeMs": 508,
"frameDurationMs": 32.42972972972972,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 883.0509999999663,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 550.5560000000003,
"heapDeltaBytes": -1706408,
"heapUsedBytes": 85395524,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 171.23099999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 239,
"frameDurationMs": 25.237142857142864,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 923.2180000000199,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 576.6099999999997,
"heapDeltaBytes": -22288284,
"heapUsedBytes": 68917344,
"domNodes": -208,
"jsHeapTotalBytes": 3538944,
"scriptDurationMs": 173.25400000000002,
"eventListeners": -106,
"totalBlockingTimeMs": 244,
"frameDurationMs": 25.463888888888885,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11849.278999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10960.398,
"heapDeltaBytes": 84968428,
"heapUsedBytes": 166889104,
"domNodes": -274,
"jsHeapTotalBytes": 87420928,
"scriptDurationMs": 8927.302,
"eventListeners": -68,
"totalBlockingTimeMs": 1674,
"frameDurationMs": 32.06720867208672,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10199.501000000055,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9391.47,
"heapDeltaBytes": 51671656,
"heapUsedBytes": 133388688,
"domNodes": -274,
"jsHeapTotalBytes": 67497984,
"scriptDurationMs": 7484.3730000000005,
"eventListeners": -68,
"totalBlockingTimeMs": 802,
"frameDurationMs": 31.002127659574466,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10193.603999999994,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.035999999999999574,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9396.996,
"heapDeltaBytes": 75218364,
"heapUsedBytes": 152660064,
"domNodes": -274,
"jsHeapTotalBytes": 67760128,
"scriptDurationMs": 7495.732999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 797,
"frameDurationMs": 31.1914373088685,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10428.208999999924,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9652.483,
"heapDeltaBytes": 55783732,
"heapUsedBytes": 131729096,
"domNodes": -274,
"jsHeapTotalBytes": 66187264,
"scriptDurationMs": 7691.383,
"eventListeners": -68,
"totalBlockingTimeMs": 854,
"frameDurationMs": 31.143283582089552,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 309.42199999998365,
"styleRecalcs": 27,
"styleRecalcDurationMs": 14.247,
"layouts": 11,
"layoutDurationMs": 3.619,
"taskDurationMs": 257.28200000000004,
"heapDeltaBytes": -15995560,
"heapUsedBytes": 59583532,
"domNodes": 936,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 10.246,
"eventListeners": 201,
"totalBlockingTimeMs": 2,
"frameDurationMs": 23.076923076923077,
"p95FrameDurationMs": 100
},
{
"name": "large-combo-open",
"durationMs": 228.9020000000619,
"styleRecalcs": 22,
"styleRecalcDurationMs": 12.755,
"layouts": 9,
"layoutDurationMs": 2.8469999999999986,
"taskDurationMs": 173.624,
"heapDeltaBytes": 14850924,
"heapUsedBytes": 74188244,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.732000000000001,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 23.33000000000002,
"p95FrameDurationMs": 83.20000000000027
},
{
"name": "large-graph-idle",
"durationMs": 2040.8610000000067,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.261,
"layouts": 8,
"layoutDurationMs": 2.023,
"taskDurationMs": 642.97,
"heapDeltaBytes": -2643468,
"heapUsedBytes": 86342920,
"domNodes": -274,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 34.418,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2055.7870000000094,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.229,
"layouts": 9,
"layoutDurationMs": 2.27,
"taskDurationMs": 645.516,
"heapDeltaBytes": -13492000,
"heapUsedBytes": 68489372,
"domNodes": -274,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 31.522000000000002,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406507,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2538.168999999982,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.052,
"layouts": 7,
"layoutDurationMs": 1.597,
"taskDurationMs": 1737.1799999999998,
"heapDeltaBytes": -7027456,
"heapUsedBytes": 73078796,
"domNodes": -274,
"jsHeapTotalBytes": 4022272,
"scriptDurationMs": 840.209,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665562913907284,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2655.5649999999105,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.562,
"layouts": 8,
"layoutDurationMs": 2.0730000000000004,
"taskDurationMs": 1716.0129999999997,
"heapDeltaBytes": -9292288,
"heapUsedBytes": 72478272,
"domNodes": -274,
"jsHeapTotalBytes": 3760128,
"scriptDurationMs": 822.035,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666249999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3810.8609999999885,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.596,
"layouts": 65,
"layoutDurationMs": 10.746,
"taskDurationMs": 1780.4119999999998,
"heapDeltaBytes": 11113472,
"heapUsedBytes": 95675632,
"domNodes": 24,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 788.832,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665938864628824,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3590.339999999969,
"styleRecalcs": 71,
"styleRecalcDurationMs": 8.759,
"layouts": 65,
"layoutDurationMs": 9.867999999999999,
"taskDurationMs": 1751.877,
"heapDeltaBytes": -18054948,
"heapUsedBytes": 67243840,
"domNodes": -250,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 772.7610000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666046511627908,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3156.6719999999577,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.656,
"layouts": 5,
"layoutDurationMs": 1.2980000000000005,
"taskDurationMs": 2044.7520000000004,
"heapDeltaBytes": -17778400,
"heapUsedBytes": 71448044,
"domNodes": 0,
"jsHeapTotalBytes": 6942720,
"scriptDurationMs": 1054.1490000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 38,
"frameDurationMs": 17.022994652406414,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3017.0419999999467,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.098999999999999,
"layouts": 5,
"layoutDurationMs": 1.141,
"taskDurationMs": 1939.3789999999997,
"heapDeltaBytes": -5663896,
"heapUsedBytes": 80421996,
"domNodes": 0,
"jsHeapTotalBytes": 5730304,
"scriptDurationMs": 959.2720000000002,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.852513966480448,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3073.429000000033,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.914,
"layouts": 8,
"layoutDurationMs": 2.061,
"taskDurationMs": 745.1499999999999,
"heapDeltaBytes": 2544612,
"heapUsedBytes": 87474424,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 362.735,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665217391304346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3123.0279999999766,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.9560000000000002,
"layouts": 7,
"layoutDurationMs": 1.7400000000000002,
"taskDurationMs": 781.1909999999999,
"heapDeltaBytes": 1972772,
"heapUsedBytes": 85985956,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 382.87800000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66524064171123,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2064.563000000021,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.084999999999999,
"layouts": 7,
"layoutDurationMs": 2.1879999999999997,
"taskDurationMs": 658.263,
"heapDeltaBytes": -1861664,
"heapUsedBytes": 72527492,
"domNodes": -274,
"jsHeapTotalBytes": -135168,
"scriptDurationMs": 33.214,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258063,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2044.891000000007,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.0429999999999997,
"layouts": 7,
"layoutDurationMs": 1.8230000000000004,
"taskDurationMs": 643.3500000000001,
"heapDeltaBytes": -8533820,
"heapUsedBytes": 71878408,
"domNodes": -274,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 29.949000000000005,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2876.11899999996,
"styleRecalcs": 25,
"styleRecalcDurationMs": 12.329,
"layouts": 6,
"layoutDurationMs": 2.323,
"taskDurationMs": 582.364,
"heapDeltaBytes": 8907272,
"heapUsedBytes": 92342280,
"domNodes": 19,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 182.794,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666279069767437,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2853.4129999999323,
"styleRecalcs": 26,
"styleRecalcDurationMs": 12.426000000000002,
"layouts": 7,
"layoutDurationMs": 1.768,
"taskDurationMs": 626.088,
"heapDeltaBytes": -18491628,
"heapUsedBytes": 66613816,
"domNodes": -266,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 199.382,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666081871345032,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-topology-cadence",
"durationMs": 3312.2769999999946,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.8600000000000005,
"layouts": 8,
"layoutDurationMs": 1.575,
"taskDurationMs": 950.275,
"heapDeltaBytes": -15093636,
"heapUsedBytes": 70028020,
"domNodes": -274,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 371.416,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666161616161617,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3277.671000000055,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1,
"layouts": 4,
"layoutDurationMs": 0.8849999999999999,
"taskDurationMs": 951.153,
"heapDeltaBytes": -13835468,
"heapUsedBytes": 70675020,
"domNodes": -274,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 379.099,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.751020408163264,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 620.2389999999696,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.353999999999999,
"layouts": 8,
"layoutDurationMs": 1.9220000000000006,
"taskDurationMs": 441.032,
"heapDeltaBytes": 24782648,
"heapUsedBytes": 86434748,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 144.565,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567563,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 631.5409999999702,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.671,
"layouts": 10,
"layoutDurationMs": 2.3790000000000004,
"taskDurationMs": 435.79400000000004,
"heapDeltaBytes": 1327356,
"heapUsedBytes": 62608764,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 143.65,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567573,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2024.4070000000534,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.195,
"layouts": 9,
"layoutDurationMs": 2.272,
"taskDurationMs": 562.996,
"heapDeltaBytes": -2663040,
"heapUsedBytes": 58560612,
"domNodes": -200,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 7.213000000000001,
"eventListeners": -115,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2007.64300000003,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.2249999999999996,
"layouts": 9,
"layoutDurationMs": 2.3379999999999996,
"taskDurationMs": 521.251,
"heapDeltaBytes": -12533992,
"heapUsedBytes": 61644780,
"domNodes": 0,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 7.577999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1773.587999999961,
"styleRecalcs": 78,
"styleRecalcDurationMs": 13.692,
"layouts": 7,
"layoutDurationMs": 1.898,
"taskDurationMs": 918.225,
"heapDeltaBytes": 15677620,
"heapUsedBytes": 77240696,
"domNodes": -200,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 113.43199999999999,
"eventListeners": -115,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66603773584906,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1740.0609999999688,
"styleRecalcs": 78,
"styleRecalcDurationMs": 13.448,
"layouts": 9,
"layoutDurationMs": 2.51,
"taskDurationMs": 892.6299999999999,
"heapDeltaBytes": -4997820,
"heapUsedBytes": 59098764,
"domNodes": -200,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 109.955,
"eventListeners": -115,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-transition-enter",
"durationMs": 1451.404000000025,
"styleRecalcs": 18,
"styleRecalcDurationMs": 21.511999999999997,
"layouts": 5,
"layoutDurationMs": 16.37,
"taskDurationMs": 1028.272,
"heapDeltaBytes": 8619800,
"heapUsedBytes": 94822280,
"domNodes": 16029,
"jsHeapTotalBytes": 17178624,
"scriptDurationMs": 30.944,
"eventListeners": 3246,
"totalBlockingTimeMs": 167,
"frameDurationMs": 19.820270270270267,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9337.188000000026,
"styleRecalcs": 251,
"styleRecalcDurationMs": 27.747999999999994,
"layouts": 9,
"layoutDurationMs": 2.242,
"taskDurationMs": 6046.246,
"heapDeltaBytes": 5490572,
"heapUsedBytes": 87385484,
"domNodes": -274,
"jsHeapTotalBytes": 4513792,
"scriptDurationMs": 2751.8599999999997,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66625,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9451.547000000006,
"styleRecalcs": 251,
"styleRecalcDurationMs": 27.089,
"layouts": 10,
"layoutDurationMs": 2.3379999999999996,
"taskDurationMs": 6001.457,
"heapDeltaBytes": 5796848,
"heapUsedBytes": 87107064,
"domNodes": -274,
"jsHeapTotalBytes": 3989504,
"scriptDurationMs": 2711.319,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665961199294532,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 22861.87000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21901.995,
"heapDeltaBytes": -14940596,
"heapUsedBytes": 282751492,
"domNodes": -3343,
"jsHeapTotalBytes": 11522048,
"scriptDurationMs": 318.663,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.02013651877134,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-idle",
"durationMs": 22617.99199999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21815.744,
"heapDeltaBytes": -21449116,
"heapUsedBytes": 282886460,
"domNodes": -3343,
"jsHeapTotalBytes": 9158656,
"scriptDurationMs": 314.642,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.128368794326235,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-large-graph-pan",
"durationMs": 28044.14400000002,
"styleRecalcs": 181,
"styleRecalcDurationMs": 17.673999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27604.686999999998,
"heapDeltaBytes": -34714108,
"heapUsedBytes": 258953096,
"domNodes": -3343,
"jsHeapTotalBytes": 10469376,
"scriptDurationMs": 861.746,
"eventListeners": -651,
"totalBlockingTimeMs": 24,
"frameDurationMs": 51.8463955637708,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 27822.64500000008,
"styleRecalcs": 181,
"styleRecalcDurationMs": 17.826000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27474.608000000004,
"heapDeltaBytes": -13598132,
"heapUsedBytes": 270760520,
"domNodes": -3343,
"jsHeapTotalBytes": 13619200,
"scriptDurationMs": 867.857,
"eventListeners": -651,
"totalBlockingTimeMs": 17,
"frameDurationMs": 51.510370370370374,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-node-resize-workload",
"durationMs": 8222.285,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.672,
"layouts": 20,
"layoutDurationMs": 27.298000000000016,
"taskDurationMs": 8057.719000000001,
"heapDeltaBytes": -16012852,
"heapUsedBytes": 277226140,
"domNodes": -3343,
"jsHeapTotalBytes": 17551360,
"scriptDurationMs": 146.739,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 44.71639344262295,
"p95FrameDurationMs": 99.90000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 8190.236000000027,
"styleRecalcs": 20,
"styleRecalcDurationMs": 64.91,
"layouts": 20,
"layoutDurationMs": 22.63100000000001,
"taskDurationMs": 8064.246000000001,
"heapDeltaBytes": -41949596,
"heapUsedBytes": 251636668,
"domNodes": -3343,
"jsHeapTotalBytes": 14409728,
"scriptDurationMs": 122.896,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.30057803468209,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11599.192999999957,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11251.399,
"heapDeltaBytes": 15104272,
"heapUsedBytes": 271482964,
"domNodes": 0,
"jsHeapTotalBytes": -10223616,
"scriptDurationMs": 146.15900000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.84330985915493,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11441.761999999926,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11083.98,
"heapDeltaBytes": 13719236,
"heapUsedBytes": 281312268,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 152.96200000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.54219858156029,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "workflow-execution",
"durationMs": 133.44900000004145,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.583,
"layouts": 9,
"layoutDurationMs": 4.221000000000001,
"taskDurationMs": 116.132,
"heapDeltaBytes": -13535564,
"heapUsedBytes": 60665260,
"domNodes": 128,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 12.562999999999999,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662499999999966,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 142.98200000007455,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.949,
"layouts": 10,
"layoutDurationMs": 3.7279999999999998,
"taskDurationMs": 103.056,
"heapDeltaBytes": -11322236,
"heapUsedBytes": 59565200,
"domNodes": 125,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 7.592000000000001,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662500000000023,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 545.8429999999908,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.634,
"layouts": 76,
"layoutDurationMs": 14.912999999999998,
"taskDurationMs": 495.08599999999996,
"heapDeltaBytes": -3300724,
"heapUsedBytes": 42581444,
"domNodes": 4,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 246.995,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 519.9630000000752,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.622,
"layouts": 76,
"layoutDurationMs": 14.839,
"taskDurationMs": 474.30499999999995,
"heapDeltaBytes": -3647296,
"heapUsedBytes": 42052164,
"domNodes": 4,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 233.421,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 583.2809999999427,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.59,
"layouts": 76,
"layoutDurationMs": 14.894,
"taskDurationMs": 538.1709999999999,
"heapDeltaBytes": 796092,
"heapUsedBytes": 103856716,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 224.549,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 607.7470000000176,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.52,
"layouts": 76,
"layoutDurationMs": 15.504,
"taskDurationMs": 580.7629999999999,
"heapDeltaBytes": 1210356,
"heapUsedBytes": 104214264,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 245.51700000000002,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66486486486485,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 59.8% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3177 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since fdada2962c3aec62fe3f79a745b190a57dd8d9c3
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (267)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog 🌐 Website E2ETip All tests passed. Test results
|
# Conflicts: # src/platform/settings/components/ExtensionPanel.vue # src/services/extensionLoader.test.ts
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 2 |
| 🟡 Medium | 1 |
| 🟢 Low | 6 |
| ⚪ Nit | 1 |
Panel: 6/6 reviewers contributed findings.
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #21787 +/- ##
==========================================
- Coverage 87.52% 87.42% -0.10%
==========================================
Files 2943 2839 -104
Lines 160287 157051 -3236
Branches 43981 40844 -3137
==========================================
- Hits 140287 137301 -2986
+ Misses 19079 18995 -84
+ Partials 921 755 -166
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 116 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Swarmhost agentic reviewThe detailed evaluation is available to employees in the internal Slack review thread. Evaluation budget remaining for this pull request: 70 automatic and 99 manual. Updated by Swarmhost's agentic review process. |
shouldLoadExtension returns true for an entry whose URL cannot be parsed: getExtensionPackPath swallows the URL constructor throw and returns undefined, and an undefined pack path is never in disabledPackPaths. The previous expect(...).not.toThrow() passed for any return value, so it could not catch an unintended filtering change. Asserting toBe(true) subsumes the no-throw contract (a throw fails the assertion) and is non-vacuous: inverting the packPath predicate in extensionLoader.ts turns this test red, where the not.toThrow() form stayed green. Addresses the one unresolved review thread on #21786.
comfy-greenlight-bot
left a comment
There was a problem hiding this comment.
This pull request at head commit b9dac85 has been reviewed and approved by Swarmhost's agentic review process.
The detailed evaluation is available to employees in the internal Slack review thread.
|
Keep this as the second PR in the stack rather than folding it into #21786. The root is already queued for ownership review as a focused 13-file disabled-pack gate. Folding this feature into it would roughly double that review surface and mix the separate extension-attribution contract discussions into the P0 fix. After #21786 lands, rebase this PR onto |
There was a problem hiding this comment.
Verdict: request changes. Bulk Disable can fail silently, Manage does not navigate an already-open Settings dialog, and login drops the agent filter.
I reviewed this against its actual stacked base, agent/oploop-919b, not main. The name-prefix/provenance display contract and optional sidebar source metadata match FE-3475. Those are not security attestations.
The inline comments cover the reproduced failures, their regression-test gaps, dependency contracts, and non-blocking maintainability items. Most test requests strengthen existing cases rather than adding new browser runs. Two mutation checks exposed false confidence: awaiting the seen-write still passed its startup test, and reversing the toast callbacks still passed both action tests.
Findings without an applicable diff anchor
- [P2] Integration with #21240. That open PR deletes
Toaster.vueand moves rendering intoAppToaster.vue, whose current patch renders only singularitem.action. This PR emits plural-onlyactionsfor agent notifications. When resolving the relocation, carry both the multi-action rendering and announcement behavior, and exercise the existing action cases against the renderer that ships. This is an integration warning, not a claim that either isolated head fails. The fix spans the other PR's moved consumer. - [P3] Nit: remove the internal comment above
inactiveDisabledExtensionNamesinsrc/stores/extensionStore.ts. It remains inside the modified setup callback, contrary to the modified-function rule. Preserve inactive settings. This range is outside the current diff hunks, so GitHub cannot offer an applicable inline deletion. - [P3] Nit: remove the private JSDoc above
coreExtensionNamesinsrc/stores/extensionStore.ts. It is not an exported API contract and remains in the modified setup callback. Preserve the core snapshot. This range is also outside the diff; the two anchorable internal blocks have separate deletion suggestions.
Existing findings checked at this head
- Startup blocked by seen-set persistence. Addressed in production.
loadExtensionslaunches notification without awaiting it and reports its rejection. Contrary to the author's reply, the test covers an immediate rejection, not a pending write. Awaiting with a catch still passes it; the inline test finding provides that missing falsifier. - [P2] Pack ownership inferred from the name. Partly intentional, partly unresolved. Name-based attribution is the ticket contract, so I do not require a new authenticated ownership model. There is still no source-URL fallback, and the mapper compares an encoded URL basename with a literal name segment. My store probe maps
/extensions/my%20pack/andagent.my pack.toolbarto no pack, so Disable falls back to a name entry and the module still imports. If agent pack names exclude spaces/non-ASCII, please identify that enforced restriction; I could not verify one here. Otherwise, decode the basename for matching while retaining the original path for persistence. Source fallback needs a loader/registration change across files, so I am not giving a line-local replacement for that contract. - Two disable strategies and non-atomic persistence. Addressed for strategy selection and request batching.
getAgentExtensionDisableSettingsskips read-only names and chooses a pack or name entry; the panel submits both settings withsetMany. Failure handling needs its own correction. - [P2] Unhandled Disable failures and repeated clicks. Addressed for the toast/sidebar helper. It catches, reports, shows an error toast, and guards identical in-flight requests. The panel bulk command bypasses that handling.
- Unbounded first-seen toast stack. Addressed. Multiple unseen extensions now produce one summary toast; the focused test checks the rendered notification data.
- Native context menu suppressed on ordinary tabs. Addressed.
SidebarIcononly emits the event;SideToolbarprevents its default only after resolving an installed agent extension. - [P2] Sticky filter and Manage on an open panel. Partly addressed. The request is reactive and one-shot when Extensions is already mounted, and the URL loader strips both recognized parameters. I reproduced that Manage leaves an already-open About dialog on About; this remaining case is inline. A query-dropping login redirect also loses the filter before the loader runs, which is a separate boundary failure.
- Self-declared attribution as a trust signal. Contested as a defect in this PR. I read FE-3475 directly; it explicitly requires the
agent.<pack>.convention and optional provenance. This UI identifies the stated source and does not claim to authenticate it. - Sidebar source can be absent or name an uninstalled extension. Addressed for the crash and missing-target cases. The current lookup checks an optional name against installed extensions before badge/menu/disable use. Making registration metadata authoritative would change the ticket's optional-source contract; it is not part of this fix.
- Duplicate toast action keys and legacy action loss. Addressed. Legacy and plural actions are concatenated, and the key includes the index. Both cases have focused coverage.
New dependency edges from the scoped Fallow audit
These warnings share the entry-point/ownership finding anchored on the new service. Each row is an introduced edge reported by the audit, not inherited baseline noise. The correction spans domain contracts and consumers.
| Importer | Imported module |
|---|---|
SideToolbar.test.ts |
stores/extensionStore.ts |
SideToolbar.vue |
ui/menu/Menu.vue |
SideToolbar.vue |
ui/menu/types.ts |
SideToolbar.vue |
ui/menu/usePointMenu.ts |
SideToolbar.vue |
stores/extensionStore.ts |
SideToolbar.vue |
settings/agentExtensionService.ts |
agentExtensionService.test.ts |
telemetry/reportError.ts |
agentExtensionService.test.ts |
ui/toast/toastStore.ts |
agentExtensionService.test.ts |
stores/extensionStore.ts |
agentExtensionService.test.ts |
telemetry/__mocks__/reportError.ts |
agentExtensionService.ts |
i18n.ts |
agentExtensionService.ts |
telemetry/reportError.ts |
agentExtensionService.ts |
ui/toast/toastStore.ts |
agentExtensionService.ts |
stores/extensionStore.ts |
agentExtensionService.ts |
types/comfy.ts |
extensionLoader.test.ts |
settings/settingStore.ts |
extensionLoader.test.ts |
ui/toast/toastStore.ts |
extensionLoader.ts |
i18n.ts |
extensionLoader.ts |
ui/toast/toastStore.ts |
extensionLoader.ts |
settings/agentExtensionService.ts |
Unverified concurrency candidate
[P2, unverified at the browser boundary] Two differently keyed disableAgentExtensions calls in the same turn lost the first pack in a real-store probe, because both write complete shared arrays while the guard deduplicates only identical batches. This alone does not establish a reachable user interaction: separate browser clicks normally flush microtasks between them. To settle it, defer the first settings POST, invoke Disable for a different sourced tab while it is pending, and inspect the saved arrays before reload. If reachable, one owner must serialize or refuse all writes to these shared lists, including the panel path. I have not called this a reproduced UI defect or supplied a speculative fix.
Checked and cleared
Fallow's five newly attributed style warnings are unchanged code on the base: the sidebar badge's leading-[14px] and min-w-[16px], its label's calculated width, the sidebar :root:has selector, and the icon !important rule. I am not requesting unrelated style edits. Its other inherited warnings are outside this diff.
I rejected moving the one-case extension registration into a separate beforeEach. The testing principles keep scenario-defining state beside its scenario and take precedence over the browser mechanics; this case also checks public registration-to-panel composition. I did not request the optional screenshot golden because the candidate supplied only a generic clipping risk, without a concrete wrong implementation or observed visual defect. Neither rejection removes the current browser composition test.
Coverage and verification
Reviewed head b9dac85. Standard-depth correctness, maintainability, and tests lanes covered the full diff.
- Standard lane specialists ran, including regression history, boundary/lifecycle checks, no-comments, type discipline, test-value/mocking, and Playwright conventions. No applicable standard specialist was unavailable. No separate documentation lane was needed because the current lane model assigns factual claims to correctness and code idiom to maintainability.
- The focused
pnpm test:unitrun passed all 99 tests across the seven changed unit files. pnpm exec playwright test --list browser_tests/tests/settings/agentExtensionProvenance.spec.tsdiscovered the new Chromium test. I used completed CI for execution evidence rather than starting another backend.- CI at this head reports successful lint, typecheck, unit, E2E, and Fallow checks. Skipped jobs are not counted as passes.
- Local diff-scoped Fallow analyzed the 24-file change and exited 0 with a warning verdict. No complexity or duplication findings; new dependency-boundary warnings remain.
- A run using the actual preserved-query definitions, tracker, manager, and Vue memory router captured and restored only
{"settings":"extension"}after visiting?settings=extension&filter=agentand simulating login. The agent filter was lost. - Real-store probes retained About after Manage and observed the bulk command's rejected write escaping its menu caller. These are command/store reproductions, not full browser recordings.
- Transform-only mutations left the startup rejection case passing after adding an await, and both action cases passing after swapping callbacks. Production files on disk stayed unchanged.
- The overlap search enumerated open PRs and inspected file lists for the newest 200, including direct consumers and dependencies. Older open PR file lists were not exhaustively inspected. No pending checks were treated as proof.
- No added/changed comment blocks were found. The modified-store rule produced four existing-comment deletions, two inline and two outside the diff. Other unchanged comment sites were excluded as not introduced or modified.
git diff --checkpassed. No tracked files were changed.
`api.fetchApi` resolves for any status it got a response for, so an HTTP 500 from `storeSetting` was indistinguishable from a saved value: `set` reported success and every consumer kept a value the backend refused. Adds `setOrRevert`, for the case where the stored value is the only record of a control the user just operated — it returns the key to the value it held before and reports the failure as data, so a refusal and an unreachable backend are one branch for the caller. `set` keeps its exact behaviour. The two writes are separate functions rather than one flag because the distinction is real: dismissing the partner-nodes education card deliberately keeps its optimistic value for the session even when the write fails, and that is covered by `PartnerNodesEducationCard.test.ts`. Addresses the save-lifecycle verdict's third reproduced defect, "a rejected save restores only the component map ... an HTTP 500 response is treated as success": #21786 (review) Returned rather than thrown per docs/guidance/error-handling.md, which names this exact case: "`fetch` and `api.fetchApi` resolve on HTTP error statuses, so check `response.ok` and return the failure value".
The loader's own filter made boot survive a corrupt `DisabledPacks`
value, but the Extensions panel still spread it straight into `new Set`,
so opening the panel with the setting saved as `{}` threw
`TypeError: object is not iterable`. Safe mode did not repair it.
Normalized once at `addSetting`, which already runs
`migrateDeprecatedValue` over saved data, so the loader and the panel
receive the same string array. This follows the existing setting
migration contract instead of adding a second component-only parser,
as the reviewer's inline suggestion asked.
Addresses:
#21786 (comment)
#21786 (comment)
Covered by the panel case "opens with a corrupt saved pack list instead
of throwing", which reproduces the reviewer's exact TypeError without it.
Two reproduced defects came from the panel treating a whole-array setting as if it owned a draft of it. Overlapping saves could be acknowledged in the opposite order to the clicks that produced them, leaving "only the first pack disabled while both switches are off". Saves are now chained: each one reads the value the previous one persisted and adds or removes exactly the toggled path. That also preserves the paths of packs absent from this install with no separate merge of an "inactive disabled" list, so `inactiveDisabledExtensionPackPaths` is gone. A refused save now reverts at the setting owner via `setOrRevert`, so the stored value and anything projecting from it agree. `isSavingExtensionPacks` exposes an unacknowledged save, because a reload issued while one is outstanding re-reads the list the server still holds. `extensionPackName` moves here as the one pack-name display policy, so the table text, its accessible label and the pending-change banner cannot drift apart. Addresses the verdict's first two reproduced defects and its duplicated-current-state and duplicated-display-policy findings: #21786 (review) #21786 (comment) #21786 (comment) The boot-time snapshot stays for the reload comparison, as that first finding asked; only the current state is derived from the setting.
…etting The panel kept `editingEnabledExtensionPacks` beside the setting it was already writing on every toggle. On a refused save its catch restored only that map, so reopening the panel read the failed disable back out of the setting store and showed a different answer. The switches now project from the stored value, and the toggle delegates to the extension store. Reload is disabled while a save is unacknowledged: it was actionable mid-flight and "can reload from the old persisted list". Both pack-name copies are replaced by the shared `extensionPackName`. The tests drive these from `api.storeSetting` with deferred and refused responses, leaving the setting-store update real, rather than stubbing the store setter — the ordering and failure handling between the panel and the setting owner is the whole subject, so a stubbed setter would prove none of it. Includes the reviewer's own remount case, which reverting pack initialization to the boot snapshot still fails. Addresses the verdict's reload and rollback defects plus its remount coverage finding: #21786 (review) #21786 (comment) #21786 (comment) #21786 (comment)
The browser gate read back the array its own settings GET mock supplied, so it passed whether or not the import gate honoured that array. The surviving module-request and body-opacity assertions are what detect a gate regression. The GET mock itself stays. Addresses: #21786 (comment)
|
@mrseek-reviews review Head is 93dcb3e. The explicit-refusal path is now acknowledgement-aware for both new Disable entry points; HTTP 403 preserves the page and setting, reports telemetry, and shows an error toast. The settings-ready history merge, canonical toast actions, real setup-to-store attribution test, live-region assertion, behavioral geometry coverage, and named browser phases are also in this head. Focused unit evidence is 596 passed with 1 skipped; the full provenance Chromium spec passes 4 of 4. All actionable automated threads are answered and resolved; the human refusal thread is answered and deliberately left unresolved. |
dante01yoon
left a comment
There was a problem hiding this comment.
Re-reviewed 93dcb3e0d182a66f7dc0d99dfb2f1a92c8dab4a1, including the author's replies and resolved/outdated conversations. My explicit-refusal blocker is addressed: both new Disable entry points use the shared acknowledgement-aware action, preserve the setting on HTTP403, report the failure, show the error toast, and do not reload. The settings-ready persisted-history merge and canonical stored toast actions also have meaningful regression coverage.
Own isolated exact-head frozen install PASS; the nine changed unit-test files report 596 PASS / 1 SKIPPED, and the additional related eight-file run reports 314 PASS / 1 SKIPPED (overlapping suites, not additive). App/browser typechecks, production bundle, scoped Oxlint/ESLint/Oxfmt and Knip PASS. All four committed Chromium provenance cases PASS against my isolated CPU backend, including normal/small badge geometry and the refused sidebar Disable. Removing the response-ok guard makes the committed refusal regression fail (1 FAIL / 3 PASS); removing the persisted-history merge makes two cases fail; restored source passes all four notice tests. Checkout clean, mutations restored, backend stopped.
COMMENT rather than approval while the owner questions in the latest changes-requested review remain unanswered: the already-open Settings navigation behavior, already-admitted Disable ordering, and the generated-extension registrar contract need their recorded owner dispositions. Those are existing concerns, not new reproductions claimed by this review; I am not duplicating their inline requests or approving the separate #21786/#21934 contracts. Please record those dispositions before treating this carrier as ready. Hosted E2E is still in progress, not counted as PASS. No review thread was resolved.
dante01yoon
left a comment
There was a problem hiding this comment.
Code-only reassessment of 93dcb3e0d182a66f7dc0d99dfb2f1a92c8dab4a1. The HTTP403 Disable blocker remains fixed. I am requesting changes for a directly reproduced navigation defect in the new Manage action, rather than continuing a general owner/environment hold.
An isolated two-row probe executes the production notice composable, its actual Manage callback, real Pinia setting/dialog stores and the registered dialog seam. With Settings initially closed, Manage selects Extensions: PASS. With the real dialog already opened on About, the same action leaves its effective defaultPanel at about: FAIL (expected extension). dialogStore.showDialog reuses an existing key without applying the new content props. This independently confirms the earlier live-navigation concern in the existing review discussion; no separate settings-mailbox or persistence redesign is requested. The inline is anchored to the new caller that exposes the failure.
The earlier same-head code evidence remains recorded: 596 changed-file unit tests PASS / 1 SKIPPED, related overlapping suite, app/browser types, bundle, scoped statics/Knip, and refusal/history mutation controls. Those checks are not claimed as rerun in this pass. The new private probe was removed, source is clean, current main and all discussions were refreshed, and no browser, live account/backend, deployment or review-thread resolution was performed. Other unresolved general rollout/owner questions alone are not approval blockers under the updated user policy.
| actions: [ | ||
| { | ||
| label: t('g.manageExtensions'), | ||
| onClick: () => settingsDialog.show('extension') |
There was a problem hiding this comment.
issue: [P2] Make Manage navigate an already-open Settings dialog. If Settings is already on About, this new callback calls show('extension'), but dialogStore.showDialog finds the existing global-settings key and only raises it; its contentProps remain defaultPanel: 'about'. My exact-head production-collaborator probe passes the initially-closed row and fails the already-open About row with expected 'extension', received 'about'. Thus Manage extensions does not take the user to the extension controls in that state. Route the existing dialog to Extensions (or safely reopen it on the requested panel) and retain a regression covering both states. This is independent confirmation of the earlier navigation concern, not an environment or rollout prerequisite.
There was a problem hiding this comment.
Fixed in 2aad5ee, and confirmed with your two states.
Both halves were needed. useSettingsDialog.show() now pushes the requested panel into the live instance via dialogStore.updateDialog before raising it, so contentProps.defaultPanel is no longer the opening panel. That alone is not enough to move the user: activeCategoryKey is seeded once from defaultCategory.value?.key at mount, and defaultPanel is passed by value into useSettingUI, so the mounted dialog ignored a changed prop. SettingDialog now watches defaultPanel and navigates when it resolves to a real nav item or panel, clearing an active search first. Nothing reopens or remounts, so search, scroll and billing state survive.
Regressions cover both of your rows and the case I could otherwise have broken:
useSettingsDialog.navigation.test.ts, against the realdialogStore: closed -> opens onextension; already open onabout-> single stack entry,defaultPanelbecomesextension; setting id forwarded to an open dialog;show()with no panel leaves the current one. Red before the fix on 2 of 4.SettingDialog.test.ts:defaultPanelchanging on the mounted dialog swaps the rendered panel, and a panel absent from the current navigation is ignored. Red before the fix on the first.browser_tests/tests/settings/agentExtensionProvenance.spec.ts, Chromium: open Settings, go to About, register an agent extension, click Manage extensions in the notice, assert the extension switch is visible and.about-containeris gone. Red before the fix with exactly your symptom (switch never appears), green after. 5/5 in that file.
Adjacent coverage for the shared change: dialogStore, useSettingUI, useSettingsUrlLoader, useManagerDialog, useCoreCommands and the billing/account dialog consumers pass (542 unit cases), and the settingsDialog/useSettingSearch/extensionAPI/settingsIsolation browser specs pass 45/45.
There was a problem hiding this comment.
Verdict: changes requested; the refusal and seen-history fixes are addressed, but Manage still leaves an already-open Settings dialog on the wrong panel.
Reviewed 93dcb3e. I confirm Dante's current navigation finding rather than duplicating it inline. Settings on About stays on About because the reused global-settings dialog only raises its existing instance. Both new Manage callers still use that initial-panel API. This is a concrete navigation defect, not a general rollout or environment hold.
Listed activity dispositions
- Disable-failure commit 93dcb3e: addressed for explicit refusal and startup history. The shared action checks response.ok before mutating the local setting or reloading. The notice watcher waits for settings readiness and merges persisted history.
- Author's refusal-thread reply, under the original finding: confirmed addressed at 93dcb3e. Both new entry points call the same action. The notice unit test supplies a real Response403, and the browser case exercises the real sidebar Disable with a refused POST.
- Author's re-review request: confirmed for the implemented refusal, history, action normalization and test repairs. The claim that actionable automated threads are answered matches the fetched replies. It does not dispose of the live-navigation defect.
- Dante's COMMENT review: confirmed for the refusal/history fixes and attributed test evidence. The listed general ownership questions are recorded individually below; they do not substitute for a demonstrated code defect.
- Dante's later changes-requested review and navigation inline: confirmed. The review reports a real-production-collaborator probe passing when Settings is closed and failing when About is already open. My confirmation is a current source trace; I did not rerun that private probe.
Earlier inline findings addressed at this commit
- R22-M2: addressed at 93dcb3e. Stored Toast.action removed; legacy public input normalizes first into actions and stored-toast test consumers use the canonical array. Author reply.
- R22-C1: addressed at 93dcb3e. Watch waits for settings readiness and merges persisted seen names before filtering, preserving absent names. Author reply.
- R22-T1: addressed at 93dcb3e. Two copied class-token rows deleted; browser rectangle coverage retained. Author reply.
- R22-T2: addressed at 93dcb3e. Setup dispatcher now uses the real workspace/sidebar manager and asserts stored attribution. Author reply.
- R22-T3: addressed at 93dcb3e. Conditional getter mock removed; real settings load/state is used. Author reply.
- R22-T4: addressed at 93dcb3e. Plural-action case checks the live-region text. Author reply.
- R22-T5: addressed at 93dcb3e. Browser size/menu/refusal phases now have named steps. Author reply.
Every addressed inline from my previous review already has an author reply, so the requested acknowledgement loop is complete without additional replies. Threads remain untouched.
Remaining questions and escalated domains
- C2 / R22-C3, P2: live Settings navigation remains open and is now independently raised in Dante's linked thread. This previously fixed domain stays escalated to the owner; no duplicate inline or settings-mailbox redesign is requested.
- R3-C2 / R22-C5, P2: the already-admitted Disable/reload ordering concern remains in its previously escalated domain. A serialized queue is present now, but reload remains inside each individual operation. This is source-traced; browser/backend cancellation effects are unverified. No new inline patch request in this domain.
- R3-C1 / R23-C7, P2: the historical shared-writer snapshot concern is open again and escalated to the owner. No new inline rewrite request.
- T5 / R23-T2, P2: same-name retry/rejection coverage is open again after the action rewrite and escalated to the owner. No duplicate inline test request.
- R22-C4: the generated-extension registrar contract remains unverified. Scoped top-level registration is attributed; imported/global and nested registrar bypasses were reproduced in the preceding round, and that proxy is unchanged. Inspect a real generated extension or document the supported registration contract to settle the question. This is not asserted as a broken installed pack or an approval blocker by itself.
- R22-T6, P3 optional: the author declined new screenshot baselines to keep the fix focused. Accessible-name/live-region assertions and real rectangle checks remain. The pixel-baseline suggestion is nonblocking; no unreadable-pixel defect was reproduced.
- Pack/source identity remains in #21934, and general persistence outcomes remain in #21786. Their policies are not accepted by removal from this carrier.
Current lane findings and evidence
- R23-C6, P2: the new inline distinguishes a saved desired disable from an active extension awaiting Reload. The production-action probe returns false with no request or reload for saved disabled[A]; ExtensionPanel and extensionStore source establish the reachable pending-reload state. A full browser replay was not run.
- R23-C3 is covered by the existing navigation finding. The unchanged, qualified registrar-contract question covers R23-C4. R23-C5 and R23-C7 remain in the escalated shared-disable domain.
- R23-M1, P2: successful writes skip the canonical settings-change publication. The actual-source real-store control emits one event and callback; the agent action emits neither. The existing GraphCanvas-to-legacy-settings bridge is the concrete event consumer. This is a separate local publication contract from the escalated snapshot/concurrency policy.
- The shared-disable and T5 retry-coverage escalations cover R23-T1 and R23-T2 respectively.
- R23-T3, P2: cover settings readiness independently from the late-import hold. R23-T4, P2 Nit: use the existing context-menu readiness helper. R23-T5, P3 Nit: use the runner's fixed-argument matching API. These three are carried inline, with deterministic suggestions for the two local replacements.
Verification and scope
This follow-up reopens whole-current-PR lanes at deep depth because the delta exceeds the follow-up threshold. Correctness, maintainability and tests run separately. The parent reconciles activity/history, checks the current contracts and refreshes open-PR overlap. No installation inputs changed, so the existing clean PR worktree and dependencies are reused.
Current-head CI reports 92 successful and 28 skipped checks, with no failure or pending record. The E2E aggregate is successful. Dante separately reports 596 changed-file unit cases passing with one skipped, an overlapping related-suite run, four Chromium cases passing, and red/green mutation controls for refusal and seen history. Those are attributed results, not suites rerun by this orb. This round does not start a backend or broad build.
The requested Playwright discovery command, pnpm exec playwright test --list browser_tests/tests/settings/agentExtensionProvenance.spec.ts --project=chromium, exits 0 and discovers four Chromium cases in one file. Its launcher automatically runs package preparation; it does not execute the browser tests. The tracked worktree stays clean.
Open-PR overlap was refreshed against the existing inventory plus new PRs since the last round. New #22246 touches extension registration and enabled-contribution policy, but does not replace this carrier's setup attribution or new action acknowledgement. #21786 and #21934 still overlap settings/extension contracts. No combined stack is executed or approved here.
The source tree is unchanged by this review. No push, merge, approval, close, thread resolution, CI trigger, watcher, or other-thread message is performed. After this single batched review, only the prescribed assignee hand-back is run. No new owner-only skill gap was identified.
| async function disableExtensionNow(extension: ComfyExtension) { | ||
| const disabled = | ||
| settingStore.settingValues['Comfy.Extension.Disabled'] ?? [] | ||
| if (disabled.includes(extension.name)) return false |
There was a problem hiding this comment.
[P2] Do not treat a saved disable as an already-applied runtime disable. Toggle A off in Extensions, let its save succeed, then close Settings without pressing Reload. A's setup and sidebar tab are still active, but this new immediate Disable action finds A in settingValues and silently returns false, so it never applies that saved change to the running document. The panel intentionally persists desired state separately from the runtime disabled-name snapshot. A focused production-action probe with saved disabled[A] returns false without a request or reload; the UI sequence is source-traced rather than browser-replayed. Distinguish runtime-disabled from saved-but-not-applied state and preserve the acknowledged-write requirement without appending a duplicate name. The fix needs that runtime-state decision as well as the request plan, so a single guard replacement would be incomplete.
There was a problem hiding this comment.
Fixed in 2aad5ee. The guard was reading desired state and calling it runtime state. It now keys off extensionStore.isExtensionEnabled(name), which reads the load-time disabledExtensionNames snapshot, so only a genuinely runtime-disabled extension is a no-op. A name already present in the saved setting skips the write — no duplicate name — and still applies, i.e. reloads. The acknowledged-write requirement is unchanged for the write path.
useAgentExtensionActions.test.ts covers the three states directly against the real stores: fresh disable writes once, publishes locally and reloads; saved-but-unapplied reloads with storeSetting never called; runtime-disabled returns false with no request and no reload. The first two are red against the previous implementation.
| return false | ||
| } | ||
|
|
||
| settingStore.settingValues['Comfy.Extension.Disabled'] = nextDisabled |
There was a problem hiding this comment.
[P2] Apply the acknowledged value through the settings owner's local-change operation. Assigning settingValues directly skips onSettingChanged and registered onChange callbacks. The actual-source probe with real Pinia/Vue/VueUse records one event and callback through settingStore.set, but zero of either through this successful agent action. GraphCanvas forwards the canonical event to the extension-facing <id>.change bridge, so these new controls silently omit that existing contract. Preserve the response.ok/refusal handling, but reuse the store's local application after acknowledgment and before reload, without issuing a second server write. Exposing that existing local operation and changing this caller are coordinated edits, so a one-range suggestion would not compile on its own.
There was a problem hiding this comment.
Fixed in 2aad5ee. settingStore.applySettingLocally is now exposed — the same local path set() takes — and the agent action calls it after the write is acknowledged and before the reload. Its JSDoc states that it does not persist and that callers without an acknowledged write want set() instead. No second server write is issued; storeSetting is asserted called exactly once per fresh disable.
The test subscribes to settingStore.onSettingChanged and asserts a change for Comfy.Extension.Disabled reaches it, which is the event GraphCanvas forwards to the extension-facing <id>.change bridge. It is red against the previous direct settingValues assignment.
| summary: 'Adds a tools sidebar' | ||
| } | ||
| }) | ||
| await settingStore.load() |
There was a problem hiding this comment.
[P2] Exercise the settings-ready guard independently of the late-registration hold. This case keeps pending=true until after settings load, while the other cases load settings before mounting, so removing only !settingsReady still passes every input. Add one case with no late-import hold: mount/register a persisted-seen extension before settings arrive, verify it is not announced, then load its persisted history and verify it remains unannounced. Keep this existing pending-registration/history-union case. The independent timing scenario needs its own setup and final observation, so replacing these load lines would trade away the other guard's coverage.
There was a problem hiding this comment.
Added in 2aad5ee. The new case has no late-registration hold at all: register a persisted-seen extension, mount, assert nothing is announced before settings arrive, then await settingStore.load() and assert it is still unannounced. Your mutation is the proof — deleting only !settingsReady from the watcher now fails this case and nothing else in the file. The existing pending-registration/history-union case is untouched.
| ? route.fulfill({ status: 403 }) | ||
| : route.fallback() | ||
| ) | ||
| await tab.click({ button: 'right' }) |
There was a problem hiding this comment.
[P2] Nit: reuse ContextMenu.openFor(tab), which already owns this exact right-click and menu-readiness sequence. Keep the following item assertions for the actual extension-menu contents. This also corrects my preceding round's helper inventory, which missed the arbitrary-locator helper.
| await tab.click({ button: 'right' }) | |
| await comfyPage.contextMenu.openFor(tab) |
There was a problem hiding this comment.
Taken in 2aad5ee — the step now calls comfyPage.contextMenu.openFor(tab) and keeps the item assertions for the extension-menu contents. Spec still 5/5 in Chromium.
| vi.mocked(api.storeSetting).mockImplementation((id) => | ||
| Promise.resolve( | ||
| id === 'Comfy.Extension.Disabled' | ||
| ? new Response(null, { status: 403, statusText: 'Forbidden' }) | ||
| : new Response() | ||
| ) | ||
| ) |
There was a problem hiding this comment.
[P3] Nit: use the installed runner's argument matcher for this fixed response instead of hand-programming dispatch by setting ID. The repository already uses vi.when(...).calledWith(...).thenResolve(...).
| vi.mocked(api.storeSetting).mockImplementation((id) => | |
| Promise.resolve( | |
| id === 'Comfy.Extension.Disabled' | |
| ? new Response(null, { status: 403, statusText: 'Forbidden' }) | |
| : new Response() | |
| ) | |
| ) | |
| vi.mocked(api.storeSetting).mockResolvedValue(new Response()) | |
| vi.when(api.storeSetting) | |
| .calledWith('Comfy.Extension.Disabled', expect.anything()) | |
| .thenResolve(new Response(null, { status: 403, statusText: 'Forbidden' })) |
There was a problem hiding this comment.
Taken in 2aad5ee, as suggested — mockResolvedValue(new Response()) plus vi.when(api.storeSetting).calledWith("Comfy.Extension.Disabled", expect.anything()).thenResolve(...) for the 403. The refusal case still passes and is still red when the response.ok check is removed.
main moved the extension store and service under src/platform/extensions and renamed the late-registration API, so the agent provenance code follows: - extensionService.test.ts: keep main's store path, keep this branch's real workspace-store import for the setup-dispatcher attribution test - useExtensionStore now imports from @/platform/extensions/stores/extensionStore - areLateExtensionsPending/holdNewExtensions/finishLateExtensions are now areLateCustomNodesPending/holdNewCustomNodes/finishLateCustomNodes
Manage extensions left an already-open Settings dialog on whatever panel it
was opened on. The settings dialog is keyed, so `show('extension')` finds the
existing `global-settings` instance and only raises it; its contentProps kept
`defaultPanel: 'about'`, and `activeCategoryKey` is seeded once at mount.
`show()` now pushes the requested panel into the live instance through
`dialogStore.updateDialog`, and SettingDialog follows a `defaultPanel` change
it can resolve, clearing an active search first. Nothing reopens or remounts,
so dialog state survives. Both regressions cover the closed and already-open
states, plus a panel the current navigation does not offer.
Also, for the agent Disable action:
- A saved disable is not an applied one. The runtime disabled set is
snapshotted at load, so a name saved in Extensions without a reload leaves
the extension running; Disable then found the name and silently no-opped.
It now keys off the runtime state and applies a saved-but-unapplied name
without writing a duplicate.
- The acknowledged value is published through the setting owner's local apply
instead of assigning `settingValues` directly, so `onSettingChanged` and
registered `onChange` handlers — including the extension-facing
`<id>.change` bridge — see it. No second server write is issued.
Tests: an independent settings-readiness case that no longer passes when only
the `!settingsReady` guard is removed, the runner's argument matcher for the
refusal response, and the shared right-click helper in the browser spec.
dante01yoon
left a comment
There was a problem hiding this comment.
Reviewed 2aad5ee with the updated disable flow, settings notification path, readiness guard, navigation changes, and the full discussion. The initial open-About -> Manage Extensions case is fixed, and the saved-but-unapplied disable path now reloads without repeating persistence. One remaining navigation regression is reproduced below.
Own validation in an isolated checkout with its own frozen dependency install: PASS — 115 tests across eight relevant suites, application and browser-test type checks, scoped lint and formatting. All six negative controls failed as expected when the corresponding navigation/disable/readiness protections were removed; the restored 115-test run passed. A separate mounted-component regression probe passed the different-destination control but failed Extension -> click About -> show('extension') again. This probe exercised the production settings component, public settings composable and real Pinia dialog store, with the existing component-test dependency seams. Temporary probes and mutations were restored.
This is a code-only review; no runtime or deployment acceptance is being used as an approval gate.
| // settings dialog is keyed, so `show(panel)` raises this instance rather than | ||
| // creating one. Follow the request instead of staying on the opening panel. | ||
| watch( | ||
| () => defaultPanel, |
There was a problem hiding this comment.
[P2] Deliver repeated requests for the same settings panel
The watcher only runs when defaultPanel changes, while clicking a navigation item changes activeCategoryKey without changing that prop. Open Extensions through Manage Extensions, click About inside the same dialog, then invoke Manage Extensions again: show('extension') writes the existing 'extension' prop value, so this watcher never runs and the dialog stays on About. I reproduced this with the production component/composable and real dialog store: the different-destination control passes, but this repeated-destination case fails. Please make each explicit navigation request observable even when its destination matches the previous request, and retain a regression test for this sequence. The newly added tests cover a changed prop and the store's prop value, so they currently miss the stale rendered panel.
There was a problem hiding this comment.
Fixed in c5d2815. show() now mints a navigationRequestId on every explicit request, and the dialog watches that alongside defaultPanel, so a repeat of the current destination is a distinct request rather than an unchanged value.
Your sequence is covered at two levels: a mounted-component case (Extensions -> click Allowlist in-dialog -> repeat the Extensions request with a bumped id, asserting the rendered panel moves back) and a browser step in agentExtensionProvenance.spec.ts that navigates to About and then takes a second Manage Extensions route. Restoring the value-only watcher fails the mounted case and passes everything else.
There was a problem hiding this comment.
Verdict: changes requested; the previous Disable and test findings are addressed, but repeated Manage requests still leave Settings on the wrong panel.
Reviewed 2aad5ee. I confirm Dante's repeated-destination finding without duplicating it inline. His mounted-component probe is external evidence; my confirmation traces the current component, composable and real dialog store.
Listed activity dispositions
- The new commit addresses the initial About-to-Extensions route:
show()updates the existing dialog's props, andSettingDialogfollows a changeddefaultPanel. It also fixes the saved-but-unapplied Disable no-op and publishes fresh acknowledged writes through the settings owner's local application. - The author's reply in the initial navigation thread: confirmed addressed at 2aad5ee for the two originally specified states. Its broader navigation claim is incomplete for repeated requests.
- Dante's current review: confirmed for the repaired initial route and Disable behavior. His reported 115-test run, scoped checks and six mutation controls are attributed results, not checks rerun by this orb.
- Dante's new inline: confirmed. An explicit request for Extensions sets
defaultPaneltoextension. Internal navigation to About changesactiveCategoryKeyonly. A second explicit Extensions request sets the same prop value, so the watcher does not run and the rendered panel stays on About. This remains in the already-escalated navigation domain.
Previous inline findings addressed
- R23-C6: the new guard reads runtime-disabled state. A saved-but-unapplied name reloads without another persistence request. Author reply.
- R23-M1: fresh acknowledged values pass through
applySettingLocally, including canonical change notification, without a second server write. Author reply. - R23-T3: a settings-only readiness case now runs without the independent late-registration hold. Author reply.
- R23-T4: the browser case uses the existing context-menu readiness helper. Author reply.
- R23-T5: fixed response matching uses
vi.when. Author reply.
All five are addressed at 2aad5ee. Each already has an author reply, so there are no acknowledgement-only replies to add.
Existing open questions and escalations
- C2 and its later navigation rows remain owner-escalated, now covered by Dante's repeated-destination thread. The initial open-About case is addressed; the user-facing navigation contract is not fully repaired.
- R3-C1/R3-C2, R22-C5 and R23-C5/R23-C7 remain in the previously escalated shared Disable snapshot/reload domain. No new inline rewrite request.
- T5/R23-T2 remains in the previously escalated same-name retry/rejection-coverage domain. No duplicate inline test request.
- R3-T19/R24-T2: the previously fixed authoritative-setting-fixture concern recurs in the new action test and is escalated to the owner. No duplicate inline fixture rewrite request.
- R22-E4412004636/R24-C8: the previously fixed Disable acknowledgement contract is open again and escalated. Fresh-value refusal handling remains fixed; the optimistic-predecessor case is not cleared. No duplicate inline rewrite request.
- R22-C4 remains unverified. Scoped top-level setup registration is attributed, but the supported registrar contract for real generated extensions is still unsettled. Inspect an actual generated extension to establish whether the bypass paths matter. No installed-pack failure is claimed.
- R22-T6 remains an optional, nonblocking pixel-baseline suggestion, declined by the author. Existing live-region and geometry assertions remain.
Test coverage and comment-policy cleanup
R24-T1, P2: extend the existing mounted-navigation case with active-search inputs and a cleared-query outcome. The inline suggestion retains the existing rendered-panel assertions and adds no case or browser load. The current empty-search inputs cannot distinguish a removed query reset.
The maintainability pass found twelve prohibited explanatory comment blocks. Eleven have inline deletion suggestions. Keep the executable fixes and assertions; remove the internal rationale from source and tests.
R24-NC12, P3 Nit: delete the entire modified applySettingLocally docblock. Its implementation narrative and caller tutorial exceed the repository's one-or-two-line exported-contract exception. The full deletion begins outside the available diff hunk, so a committable inline range cannot cover it safely. The newly exported operation itself is the correct owner and should remain.
The one-line public ToastOptions.actions ordering contract is kept. It documents supported legacy-plus-plural action precedence rather than internal rationale. No new structural maintainability finding survives.
Verification and overlap
Whole-current-PR correctness, maintainability and test lanes completed at deep depth. All changed production hunks and sixteen effective changed test paths were covered. The merge from main is separated from the author's effective fix delta. Existing dependencies are reused; installation inputs did not change. No backend or browser execution was started for this code review.
One new exact-head probe executes the production settings store and action with real Pinia, Vue and VueUse, doubling transport, runtime-enabled predicate, toast/telemetry and reload boundaries. After a refused panel-equivalent set, the immediate action returns true with no second request and calls reload. The expected regression assertion exits 1. This evidence belongs to the acknowledgement escalation; it is not a failing committed test or a browser/backend reproduction. The panel callback's use of the same setter is source-traced.
Current-head CI has 92 successful and 24 skipped checks, with no pending or failed record. pnpm exec playwright test --list browser_tests/tests/settings/agentExtensionProvenance.spec.ts --project=chromium exits 0 and discovers five cases. Discovery is not browser execution.
Open-PR overlap was refreshed for settings, extension registration and immediate dependencies. #21786 retains persistence outcomes; #21934 retains pack identity/import policy; #22246 changes enabled contributions. #22186 moves the settings store into a package and must preserve the newly exposed local-application operation when integrated. #22097 changes Members visibility in useSettingUI; #18900 changes a settings header slot. Neither replaces explicit navigation delivery. No combined stack is executed or approved here.
The fetched activity contains no new DrJKL-only comment requiring a skill-gap report. The source tree stays unchanged. This review and the prescribed assignee hand-back are the only GitHub writes; pushes, merges, approvals and thread resolution remain out of scope.
|
|
||
| // The settings dialog is keyed, so a second `show('workspace-allowlist')` | ||
| // raises this instance with new content props instead of remounting. | ||
| await rerender({ onClose, defaultPanel: 'workspace-allowlist' }) |
There was a problem hiding this comment.
[P2] Extend this existing navigation case with an active search. Both current cases start with an empty query, so removing only the new query-reset statement still passes while leaving old search text after an explicit panel request. These inputs and the query outcome exercise that independent behavior without another case or browser load. Keep the rendered-panel assertions below.
| await rerender({ onClose, defaultPanel: 'workspace-allowlist' }) | |
| searchMocks.searchQuery.value = 'workspace' | |
| searchMocks.inSearch.value = true | |
| await rerender({ onClose, defaultPanel: 'workspace-allowlist' }) | |
| expect(searchMocks.searchQuery.value).toBe('') |
There was a problem hiding this comment.
Done in c5d2815, with one change to your snippet: the rerender also needs navigationRequestId now that an explicit request carries one. The case starts in search with searchQuery set to 'allow' and asserts both an empty query afterwards and that the search composable was told to clear. Removing the query-reset statement fails it.
| // Core registers this setting at boot; the change event only fires for a | ||
| // registered setting, which is what the extension-facing bridge consumes. |
There was a problem hiding this comment.
[P3] Nit: remove the fixture commentary. The helper explicitly registers the setting, and repository guidance excludes test comments. Keep the registration and event assertion.
| // Core registers this setting at boot; the change event only fires for a | |
| // registered setting, which is what the extension-facing bridge consumes. |
| // The canonical change event is what the extension-facing `<id>.change` | ||
| // bridge listens to, so a direct store assignment would silently drop it. |
There was a problem hiding this comment.
[P3] Nit: remove this explanation of the event assertion. The scenario title and assertion already protect publication; the rationale belongs in the review or commit.
| // The canonical change event is what the extension-facing `<id>.change` | |
| // bridge listens to, so a direct store assignment would silently drop it. |
There was a problem hiding this comment.
Removed in c5d2815. The reason it is worth asserting is now the assertion's own failure message rather than a comment, which keeps it where a failing run will show it.
| // Saved while the extension kept running: the runtime disabled set is | ||
| // snapshotted at load, so it is still registered and active. |
There was a problem hiding this comment.
[P3] Nit: the scenario title and explicit saved-state/runtime setup already express this precondition. Remove the test commentary.
| // Saved while the extension kept running: the runtime disabled set is | |
| // snapshotted at load, so it is still registered and active. |
| // The runtime disabled set is snapshotted at load, so a disable that was | ||
| // saved without a reload leaves the extension running. Only a runtime | ||
| // disable means there is nothing left to do here. |
There was a problem hiding this comment.
[P3] Nit: remove the internal ownership explanation, retaining the corrected runtime guard. This is change rationale rather than the permitted terse exported-API documentation.
| // The runtime disabled set is snapshotted at load, so a disable that was | |
| // saved without a reload leaves the extension running. Only a runtime | |
| // disable means there is nothing left to do here. |
There was a problem hiding this comment.
Removed in c5d2815; the runtime guard is unchanged.
| // Announcing here would use an empty seen history and re-announce an | ||
| // extension the user has already been told about. |
There was a problem hiding this comment.
[P3] Nit: remove the test narration. The scenario title, persisted-seen fixture and no-toast assertion already state the readiness behavior.
| // Announcing here would use an empty seen history and re-announce an | |
| // extension the user has already been told about. |
There was a problem hiding this comment.
Removed in c5d2815, moved into the assertion's failure message so it appears on a failing run instead of in the source.
| // The settings dialog is keyed, so a second `show('workspace-allowlist')` | ||
| // raises this instance with new content props instead of remounting. |
There was a problem hiding this comment.
[P3] Nit: remove the keyed-dialog explanation from the test body. The already-open scenario and rerender call express the interaction; the repository does not permit test commentary.
| // The settings dialog is keyed, so a second `show('workspace-allowlist')` | |
| // raises this instance with new content props instead of remounting. |
| // A caller can ask for a panel while this dialog is already mounted — the | ||
| // settings dialog is keyed, so `show(panel)` raises this instance rather than | ||
| // creating one. Follow the request instead of staying on the opening panel. |
There was a problem hiding this comment.
[P3] Nit: remove this private watcher's rationale. Keyed-dialog mechanics are internal design choices, not an exported API contract or an external constraint.
| // A caller can ask for a panel while this dialog is already mounted — the | |
| // settings dialog is keyed, so `show(panel)` raises this instance rather than | |
| // creating one. Follow the request instead of staying on the opening panel. |
|
|
||
| const SettingDialogStub = { name: 'SettingDialogStub' } | ||
|
|
||
| /** The panel the live dialog instance is currently told to show. */ |
There was a problem hiding this comment.
[P3] Nit: remove the private test-helper docblock. requestedPanel and the returned defaultPanel field already describe the accessor; the exported-API exception does not apply.
| /** The panel the live dialog instance is currently told to show. */ |
| // `showDialog` only raises an instance that already exists under this key, | ||
| // so a caller asking for a specific panel while Settings is open would | ||
| // otherwise keep whatever panel it was opened on. Push the requested | ||
| // destination into the live instance first; the dialog watches it. |
There was a problem hiding this comment.
[P3] Nit: remove the internal updateDialog/showDialog explanation. Keep both calls; their coordination rationale belongs in the change description rather than a function-body comment.
| // `showDialog` only raises an instance that already exists under this key, | |
| // so a caller asking for a specific panel while Settings is open would | |
| // otherwise keep whatever panel it was opened on. Push the requested | |
| // destination into the live instance first; the dialog watches it. |
There was a problem hiding this comment.
Addressed in c5d2815: the internal updateDialog/showDialog explanation is removed while both calls and live navigation delivery remain.
`show(panel)` carried its destination only in `defaultPanel`, and the dialog watched that prop's value. Clicking a navigation item inside an open dialog moves `activeCategoryKey` without changing the prop, so a second request for the panel the caller asked for first wrote the same value, the watcher never ran, and the dialog stayed where the user had navigated. Open Extensions through Manage Extensions, click About, then invoke Manage Extensions again. Each explicit request now mints `navigationRequestId`, so a repeat is a distinct request rather than an unchanged destination, and the dialog follows the request instead of the value. Regression coverage is added at the composable, mounted-component and browser levels; the mounted case also now starts in search with a query, so a removed query reset is distinguishable. Also removes the explanatory comment blocks this carrier added across source and tests, keeping the executable fixes and assertions, and collapses the newly exported `applySettingLocally` docblock to its contract.
|
@dante01yoon the repeated-destination case is fixed at Two corrections to the description while I was in there. The fix adds an internal The new browser step was not run locally. No ComfyUI backend was reachable on the machine that wrote it, so only CI exercises it. @mrseek-reviews review |
dante01yoon
left a comment
There was a problem hiding this comment.
Re-reviewed c5d2815 and the complete follow-up, including the repeated-destination finding, query-reset request and resolved comment-cleanup discussions. The previous navigation blocker is fixed: every explicit request carries a fresh internal navigationRequestId, and the mounted dialog observes it alongside the destination. My private reproduction now passes through the real useSettingsDialog and dialogStore, forwarding their actual live contentProps to the mounted SettingDialog; both a different destination and Extensions -> About -> Extensions work. Restoring the value-only watcher, freezing the producer request id, or removing search reset each fails the appropriate regression. Restored validation: 632 tests PASS, one unchanged skip, across 15 suites; app/browser typechecks and scoped lint/format PASS. Playwright discovery finds five cases; browser execution is NOT_RUN under the code-only review scope. The internal UI request id adds no server contract or derived server fact. One nonblocking test-fixture simplification is inline. No remaining code blocker.
| searchQuery: null as unknown as Ref<string>, | ||
| searchResultsCategories: null as unknown as Ref<Set<string>> | ||
| searchResultsCategories: null as unknown as Ref<Set<string>>, | ||
| handleSearch: null as unknown as ReturnType<typeof vi.fn> |
There was a problem hiding this comment.
nit-pick (non-blocking): Initialize this callable directly with vi.fn() inside vi.hoisted, rather than asserting null through unknown. Vitest’s mock function is available in the hoisted factory; useSettingsUrlLoader.test.ts already uses that pattern. This keeps the test holder valid from construction and removes an unnecessary double assertion.
There was a problem hiding this comment.
Fixed in 355dd94c79: handleSearch is initialized directly with vi.fn() inside vi.hoisted, so the holder is callable from construction and the unknown double assertion is gone. The focused SettingDialog.test.ts run passes 11/11; the guarded commit also passed type-aware lint and the app typecheck.
|
Follow-up on the note above, which said the new browser step had not run locally. It has now, so CI is not the only thing exercising it. Open Extensions through Manage Extensions, click About, then invoke Manage Extensions again: the dialog lands back on Extensions. All five cases in the provenance browser spec pass against a local ComfyUI backend at |
There was a problem hiding this comment.
Verdict: navigation and query-reset findings addressed; remaining Disable questions stay escalated to DrJKL.
Reviewed c5d2815. The repeated-destination blocker is fixed. This is a COMMENT follow-up for the outstanding owner decisions, not an approval or a request for another persistence rewrite in this carrier.
Listed activity dispositions
- The new commit addresses C2 and Dante's repeated-destination finding. Every explicit destination request gets a fresh internal id; the mounted dialog observes that id alongside the destination. Returning from in-dialog About navigation to the previously requested Extensions panel now triggers navigation.
- The author's reply in that thread and follow-up comment are confirmed for the navigation fix, active-search coverage and comment cleanup. All are addressed at this head. The revised PR body identifies the internal navigation prop and the advisory test-import boundary warning.
- Dante's approval is confirmed for the repaired navigation and query reset. His reported 632 tests, scoped checks and mutation controls are external evidence, not checks executed by this orb. His conclusion does not settle the separately escalated Disable acknowledgement and shared-write questions below.
- Dante's nonblocking mock-initialization nit is confirmed. The callable is initialized as
nullthroughunknownand replaced in setup;vi.fn()is available in the hoisted factory. Keep the existing thread rather than a duplicate inline. - The author's browser follow-up is accepted as reported evidence: five browser cases passed locally, and restoring the old watcher failed the repeated-route step only. This supersedes the earlier statement that the new browser step had not run locally. This orb ran discovery only, not that browser execution.
Previous inline findings addressed
- R24-T1 is addressed. The existing mounted-navigation case now starts with an active nonempty search and checks the cleared query after the explicit request. The rendered-panel assertions remain.
- R24-NC01 through R24-NC11 are addressed. The prohibited explanatory blocks are removed while the executable guards, publication and tests remain.
- R24-NC12 is addressed by narrowing
applySettingLocallydocumentation to its exported contract and return value. - Eleven addressed inlines already have author replies. The remaining unanswered comment-cleanup thread now has an acknowledgement of its fix. The earlier round23 runtime-state, canonical notification, independent readiness, context-menu helper and
vi.whencorrections remain intact.
Existing open findings and owner escalations
- R3-C1/R23-C7/R24-C7 remain in the escalated shared Disable snapshot-ownership domain, unchanged by this comment/navigation delta.
- R3-C2/R22-C5/R23-C5/R24-C5 and R23-T1 remain in the escalated queued Disable/reload domain, unchanged.
- T5/R23-T2 remains the escalated same-name retry and rejected-transport coverage question, unchanged.
- R3-T19/R24-T2 remains the escalated authoritative-setting-fixture concern, unchanged.
- R22-E4412004636/R24-C8 remains the escalated Disable acknowledgement recurrence, unchanged. The prior source probe and its transport/navigation limits still apply; this head does not change that branch.
- R22-C4 and its merged rows remain unverified. Actual generated-extension adoption of the supplied registrar must be checked before treating alternative registrar bypasses as a supported-use defect. This is not an independent approval hold.
- R22-T6 remains an optional, nonblocking pixel-baseline suggestion, declined by the author.
- E2 and R22-E4399333964 remain outside this carrier in #21934. R22-E4399333949 and R3-PERSISTENCE retain their cross-PR policy disposition in #21786. Removing that machinery here is not acceptance of its policy elsewhere. E8 remains contested as a security defect because self-declared provenance is a display contract, not authenticated origin.
No new rewrite request is being posted in these retread domains. DrJKL retains the outstanding ownership decisions.
Verification, coverage and overlap
One standard delta reviewer applied correctness, maintainability and tests briefs across all ten changed files and their immediate contracts. No new correctness blocker was found. The one P3 inline asks for a test-local user-event instance under the documented component-test convention; it is not an observed behavior or isolation defect. The two remaining added or modified comment blocks are terse exported contracts. Settled-search coverage does not establish pending/debounced-search behavior or a general live setting-ID router; those unchanged limitations are not new findings.
The follow-up reuses the clean PR worktree and its dependencies. CI at this exact head has 92 successful and 31 skipped checks, with no pending or failed check in the saved snapshot. Broad suites, typecheck, lint and dead-code checks were not repeated locally. Delta git diff --check exits 0.
pnpm exec playwright test --list browser_tests/tests/settings/agentExtensionProvenance.spec.ts --project=chromium exits 0 and discovers five cases. Discovery does not execute the browser steps. No backend, browser session or CI run was started by this orb.
Open-PR overlap was refreshed for Settings, extensions and their immediate contracts. #21786 retains persistence outcomes; #21934 retains pack/import policy; #22246 changes enabled contributions; #22186 extracts the settings store and must preserve canonical local publication. #21969 contains an older provenance test/UI branch touching the same browser spec and extension-panel behavior, so it must reconcile with this carrier rather than replace the new navigation cases. #18184 touches the Settings browser helper. No combined stack was executed.
The fetched discussion has no new owner-only comment requiring a skill-gap report. Source code stays unchanged. The acknowledgement reply, this review and the prescribed assignee hand-back are the only GitHub writes; pushes, approvals, thread resolutions and other metadata edits remain out of scope.
| }) | ||
| expect(await screen.findByText('workspace panel')).toBeInTheDocument() | ||
|
|
||
| await userEvent.click(screen.getByRole('button', { name: 'Allowlist' })) |
There was a problem hiding this comment.
[P3] Nit: use a test-local user-event instance in this new interactive case, as required by docs/testing/component-testing.md. The direct API works for this one click; this is a convention correction, not a reproduced isolation defect.
| await userEvent.click(screen.getByRole('button', { name: 'Allowlist' })) | |
| const user = userEvent.setup() | |
| await user.click(screen.getByRole('button', { name: 'Allowlist' })) |
There was a problem hiding this comment.
Taken in 355dd94c79, as suggested: the interactive case now creates a test-local userEvent.setup() instance and uses user.click(...). The focused SettingDialog.test.ts run passes 11/11; the guarded commit also passed type-aware lint and the app typecheck.
# Conflicts: # src/platform/extensions/components/ExtensionPanel.vue # src/platform/settings/constants/coreSettings.ts # src/platform/settings/settingStore.ts # src/platform/settings/types.ts
dante01yoon
left a comment
There was a problem hiding this comment.
Re-reviewed 4998497, including both test-convention fixes and the four conflict resolutions after merging main. The hoisted search callable now starts as vi.fn(), and the interactive case uses its own userEvent instance. The merged extension panel retains reactive seeding for late registrations alongside main's separate path controls; both settings keys and the local-update/persistence APIs remain available.
Own isolated validation after a frozen dependency install: 754 tests PASS, one unchanged skip, across 20 relevant suites; application/browser type checks and scoped lint/format PASS. The additional suites cover the merged extension store/loader, custom scripts and settings store/constants. Restoring the value-only dialog watcher or main's mount-only extension seeding independently fails the appropriate retained regression; restored component suites pass all 30 cases. No newly introduced code blocker found. Existing owner-policy discussions retain their documented disposition. Browser execution and operational acceptance are outside this code-only review.
|
@DrJKL post-merge peer review is routed to you under the selective stale-approval exception. Dante approved the substantive head |
Summary
mainand removes the separate extension-pack gate, safe-mode, settings URL mailbox, and shared settings-write machinery from this PRPublic API changes
ToastOptions.actions?: ToastAction[]; legacyactionremains supported and renders firstSettingDialogProps.navigationRequestId, minted byuseSettingsDialog().show()so a repeated destination is a distinct request rather than an unchanged prop value. No extension-facing settings-navigation APISidebarTabExtension, node, or graph APITest plan
pnpm typecheckpnpm typecheck:browserpnpm lint:eslint,oxlint,oxfmt --checkon the changed filesdefaultPanelwatcher fails the new repeated-destination case and nothing else; removing the query reset fails the extended in-search navigation casebrowser_tests/tests/settings/agentExtensionProvenance.spec.ts --project=chromium: 5/5 passed locally at substantive headc5d28158f9; restoring only the previous value-only watcher failed exactly the repeated-route step. At refreshed exact head499849721a, the dedicatedplaywright-video-new-tests (chromium, 1, 1, browser_tests/tests/settings/agentExtensionProvenance...)hosted check passedsrc/platform/extensions/services/extensionService.test.tsimports@/stores/workspaceStore, crossing the extension-runtime to workbench-shell zone boundary. It is the sidebar-attribution test asserting through the real workspace store, it is warn-level, and it predates this headOwner questions kept out of this carrier
Justification: selective stale-approval exception (Christian, 2026-09-28). Dante approved the substantive change at
c5d28158f9in review5706983315. The later delta is limited to clean/main conflict-resolution refreshes (adc2d491bc,499849721a) and the two exact-review test-convention repairs in355dd94c79(one test file, +3/-2, no assertion change). Independent delta review found no semantic expansion or weakened proof: the clean refresh tree matched Git's merge result; the conflict refresh preserved the branch's late-extension watcher and settings contracts beside main's disabled-path work; 97 focused tests, app/browser typechecks, dependency-cruiser, Knip and Fallow completed, and exact-head hosted CI is terminal green (92 success, 18 skipped), including the dedicated provenance/navigation browser-video job. The only three live unresolved threads are addressed and predate Dante's approval; no human finding remains open. The binding guard found the green head four commits behindmain@76d42e6139with ZERO file overlap after two prior refreshes, so the recorded judgment is to merge rather than invalidate the fresh proof again. Post-merge peer review will be routed to DrJKL.