Repository navigation
fix(ci): skip the backport warning's comment lookup on merges with no release label - #22377
Conversation
… release label The warn-missing-needs-backport job read every merged PR's comments before checking whether it had a release label at all. That second call runs on the shared PR token, and on 2026-10-30 four runs (22195, 22125, 22157, 21787) failed with 'API rate limit exceeded' at that step. None of those PRs had a release label, so the job had nothing to warn about and still went red. Exit after the label read when no core/X.Y or cloud/X.Y label is present.
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Release-label check and test .github/workflows/pr-backport.yaml, scripts/cicd/backport-missing-trigger.test.ts |
The workflow checks for a release label before comment lookup. The test records API calls and verifies that the no-release-label path makes only the labels request. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Bug fix
Possibly related PRs
- Comfy-Org/ComfyUI_frontend#21357: Adds the warning job and comment lookup that this change updates.
- Comfy-Org/ComfyUI_frontend#21994: Changes when
needs-backportis removed, affecting label state read by the warning job. - Comfy-Org/ComfyUI_frontend#22241: Can cause
needs-backportremoval, affecting label state evaluated by the warning job.
Suggested reviewers: mattmillerai
Merge Risk: 
Minimal · up to 22b32
-
No actionable merge-blocking risk is identified in the reviewed change.
Pre-merge checks: 
6
-
Full details: Description check
-
Explanation
The description explains the problem, affected workflow, resulting behavior, error context, test coverage, and related issue. It does not use the template's explicit "## Summary" and "## Verification" headings, but it contains the required information and is mostly complete.
Full details: End-To-End Test Suggestion For User-Facing Changes
-
Explanation
The changed files are
.github/workflows/pr-backport.yamlandscripts/cicd/backport-missing-trigger.test.ts. The diff changes CI behavior and its test only. It does not change the main frontend application undersrc/orpackages/, so this check is not applicable.
Full details: Adr Compliance For Entity/Litegraph Changes
-
Explanation
The changed files are
.github/workflows/pr-backport.yamlandscripts/cicd/backport-missing-trigger.test.ts. Neither path is undersrc/lib/litegraph/,src/ecs/, nor related to graph entities. The ADR entity/litegraph check does not apply.
-
Finishing Touches: 💡 1
-
🛠️ Fix failing CI checks: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
📦 Bundle: 12 MB gzip 🔴 +8 BDetailsSummary
Category Glance App Entry Points — 6.71 kB (baseline 6.71 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 2.6 MB (baseline 2.6 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed / 2 unchanged Views & Navigation — 148 kB (baseline 148 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 878 kB (baseline 878 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 2 added / 2 removed / 33 unchanged User & Accounts — 159 kB (baseline 159 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 18 unchanged Editors & Dialogs — 502 kB (baseline 502 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 17 unchanged UI Components — 359 kB (baseline 359 kB) • ⚪ 0 BReusable component library chunks Status: 31 unchanged Data & Services — 1.93 MB (baseline 1.93 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 1 added / 1 removed / 41 unchanged Utilities & Hooks — 2.46 MB (baseline 2.46 MB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 83 unchanged Vendor & Third-Party — 9.69 MB (baseline 9.69 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 34.8 MB (baseline 34.8 MB) • ⚪ 0 BBundles that do not match a named category
Status: 2 added / 2 removed / 748 unchanged ⚡ Performance Report
Scenario timings
✅ No regressions detected. All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-30T12:09:26.041Z",
"gitSha": "01b6a20f8f275319c53b46e6c8906dd79b748d94",
"branch": "ci/backport-warn-skip-api-without-release-labels",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2035.9879999999748,
"styleRecalcs": 11,
"styleRecalcDurationMs": 1.8309999999999997,
"layouts": 10,
"layoutDurationMs": 1.7730000000000001,
"taskDurationMs": 414.18699999999995,
"heapDeltaBytes": -6772160,
"heapUsedBytes": 52945968,
"domNodes": -178,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 8.042,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-idle",
"durationMs": 2025.9029999999711,
"styleRecalcs": 11,
"styleRecalcDurationMs": 1.9030000000000002,
"layouts": 10,
"layoutDurationMs": 1.868,
"taskDurationMs": 378.90999999999997,
"heapDeltaBytes": -13363060,
"heapUsedBytes": 63438292,
"domNodes": 0,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 7.985999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1694.5180000000164,
"styleRecalcs": 72,
"styleRecalcDurationMs": 9.670000000000002,
"layouts": 10,
"layoutDurationMs": 1.5939999999999996,
"taskDurationMs": 624.432,
"heapDeltaBytes": 5157604,
"heapUsedBytes": 81923380,
"domNodes": 0,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 104.602,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352937,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1710.668999999939,
"styleRecalcs": 72,
"styleRecalcDurationMs": 10.386,
"layouts": 10,
"layoutDurationMs": 1.7939999999999998,
"taskDurationMs": 696.3269999999999,
"heapDeltaBytes": -556560,
"heapUsedBytes": 76630296,
"domNodes": -178,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 112.128,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.8819999999796,
"styleRecalcs": 19,
"styleRecalcDurationMs": 3.7140000000000004,
"layouts": 11,
"layoutDurationMs": 1.975,
"taskDurationMs": 282.558,
"heapDeltaBytes": 1608096,
"heapUsedBytes": 63411688,
"domNodes": 57,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 9.308,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1727.9119999999466,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.146,
"layouts": 12,
"layoutDurationMs": 2.301,
"taskDurationMs": 309.046,
"heapDeltaBytes": 4751036,
"heapUsedBytes": 74566864,
"domNodes": 57,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 10.495,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384617,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 531.7120000000273,
"styleRecalcs": 14,
"styleRecalcDurationMs": 1.7609999999999995,
"layouts": 9,
"layoutDurationMs": 1.5859999999999999,
"taskDurationMs": 333.258,
"heapDeltaBytes": 1816564,
"heapUsedBytes": 62685116,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 113.44200000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66562499999999,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 556.8219999998973,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.1979999999999995,
"layouts": 10,
"layoutDurationMs": 1.966,
"taskDurationMs": 364.131,
"heapDeltaBytes": 2745232,
"heapUsedBytes": 63554788,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 120.848,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636368,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1020.9280000000263,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 658.8859999999999,
"heapDeltaBytes": -10358752,
"heapUsedBytes": 77933060,
"domNodes": -208,
"jsHeapTotalBytes": 19931136,
"scriptDurationMs": 40.773,
"eventListeners": -106,
"totalBlockingTimeMs": 346,
"frameDurationMs": 28.238888888888887,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 972.9760000000169,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 625.7869999999999,
"heapDeltaBytes": -5404952,
"heapUsedBytes": 78209628,
"domNodes": -208,
"jsHeapTotalBytes": 16785408,
"scriptDurationMs": 37.580000000000005,
"eventListeners": -106,
"totalBlockingTimeMs": 332,
"frameDurationMs": 28.094285714285718,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 746.1549999999875,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 390.625,
"heapDeltaBytes": -24945048,
"heapUsedBytes": 67560324,
"domNodes": -208,
"jsHeapTotalBytes": 4063232,
"scriptDurationMs": 95.40600000000002,
"eventListeners": -106,
"totalBlockingTimeMs": 114,
"frameDurationMs": 21.425714285714275,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 765.1600000000371,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 377.92199999999985,
"heapDeltaBytes": -21352464,
"heapUsedBytes": 69705980,
"domNodes": -208,
"jsHeapTotalBytes": 3014656,
"scriptDurationMs": 100.78099999999998,
"eventListeners": -106,
"totalBlockingTimeMs": 109,
"frameDurationMs": 21.294444444444455,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6559.44599999998,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.765,
"layouts": 4,
"layoutDurationMs": 0.7490000000000001,
"taskDurationMs": 5657.156000000001,
"heapDeltaBytes": 62384108,
"heapUsedBytes": 138595140,
"domNodes": -274,
"jsHeapTotalBytes": 60944384,
"scriptDurationMs": 4178.9130000000005,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.278231292517006,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6635.982000000013,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.6979999999999998,
"layouts": 3,
"layoutDurationMs": 0.5729999999999997,
"taskDurationMs": 5733.675,
"heapDeltaBytes": 27664304,
"heapUsedBytes": 109917284,
"domNodes": -274,
"jsHeapTotalBytes": 44429312,
"scriptDurationMs": 4269.36,
"eventListeners": -68,
"totalBlockingTimeMs": 22,
"frameDurationMs": 22.40912162162162,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6925.026000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6109.262,
"heapDeltaBytes": 67934988,
"heapUsedBytes": 142654936,
"domNodes": -274,
"jsHeapTotalBytes": 60944384,
"scriptDurationMs": 4540.38,
"eventListeners": -68,
"totalBlockingTimeMs": 101,
"frameDurationMs": 24.52624113475177,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6614.220999999987,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.6979999999999998,
"layouts": 3,
"layoutDurationMs": 0.644,
"taskDurationMs": 5782.0960000000005,
"heapDeltaBytes": 48945300,
"heapUsedBytes": 124456504,
"domNodes": -274,
"jsHeapTotalBytes": 50720768,
"scriptDurationMs": 4258.913,
"eventListeners": -68,
"totalBlockingTimeMs": 45,
"frameDurationMs": 23.134265734265732,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "large-combo-open",
"durationMs": 221.36000000000422,
"styleRecalcs": 25,
"styleRecalcDurationMs": 11.799999999999997,
"layouts": 12,
"layoutDurationMs": 2.901,
"taskDurationMs": 173.58,
"heapDeltaBytes": 92168,
"heapUsedBytes": 74974940,
"domNodes": 708,
"jsHeapTotalBytes": -1310720,
"scriptDurationMs": 8.576,
"eventListeners": 73,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.65999999999999,
"p95FrameDurationMs": 66.70000000000027
},
{
"name": "large-combo-open",
"durationMs": 222.05000000002428,
"styleRecalcs": 24,
"styleRecalcDurationMs": 12.339,
"layouts": 10,
"layoutDurationMs": 2.6090000000000004,
"taskDurationMs": 183.528,
"heapDeltaBytes": -7264236,
"heapUsedBytes": 75156152,
"domNodes": 936,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 8.925,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.209090909090925,
"p95FrameDurationMs": 66.59999999999991
},
{
"name": "large-graph-idle",
"durationMs": 2009.6999999999525,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.4979999999999993,
"layouts": 9,
"layoutDurationMs": 1.494,
"taskDurationMs": 491.03400000000005,
"heapDeltaBytes": -29340136,
"heapUsedBytes": 63945460,
"domNodes": -274,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 29.929,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2024.723999999992,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.6290000000000002,
"layouts": 9,
"layoutDurationMs": 1.596,
"taskDurationMs": 461.177,
"heapDeltaBytes": -16008972,
"heapUsedBytes": 67137820,
"domNodes": -274,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 25.345000000000002,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2171.3399999999865,
"styleRecalcs": 70,
"styleRecalcDurationMs": 6.9319999999999995,
"layouts": 8,
"layoutDurationMs": 1.266,
"taskDurationMs": 1206.867,
"heapDeltaBytes": -20216872,
"heapUsedBytes": 63448024,
"domNodes": -274,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 563.4200000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66615384615385,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2151.4040000000705,
"styleRecalcs": 69,
"styleRecalcDurationMs": 7.57,
"layouts": 8,
"layoutDurationMs": 1.2559999999999998,
"taskDurationMs": 1204.6619999999998,
"heapDeltaBytes": -8467792,
"heapUsedBytes": 82188160,
"domNodes": -274,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 542.169,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3207.7239999999847,
"styleRecalcs": 72,
"styleRecalcDurationMs": 9.728,
"layouts": 65,
"layoutDurationMs": 10.031,
"taskDurationMs": 1351.844,
"heapDeltaBytes": -17438004,
"heapUsedBytes": 69684992,
"domNodes": -250,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 558.9960000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66614583333333,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3114.041000000043,
"styleRecalcs": 73,
"styleRecalcDurationMs": 9.502,
"layouts": 67,
"layoutDurationMs": 10.043,
"taskDurationMs": 1296.7900000000002,
"heapDeltaBytes": -28045600,
"heapUsedBytes": 64442784,
"domNodes": -250,
"jsHeapTotalBytes": 4882432,
"scriptDurationMs": 535.789,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66631016042781,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2172.0829999999864,
"styleRecalcs": 46,
"styleRecalcDurationMs": 3.7920000000000003,
"layouts": 7,
"layoutDurationMs": 1.187,
"taskDurationMs": 1305.0380000000002,
"heapDeltaBytes": -10090520,
"heapUsedBytes": 77041732,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 602.3839999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.794573643410853,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "legacy-node-drag",
"durationMs": 2198.088000000098,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.1579999999999995,
"layouts": 7,
"layoutDurationMs": 1.0710000000000002,
"taskDurationMs": 1332.592,
"heapDeltaBytes": -10963300,
"heapUsedBytes": 80291324,
"domNodes": 0,
"jsHeapTotalBytes": 6520832,
"scriptDurationMs": 614.354,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.793893129770993,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3004.1840000000093,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.595,
"layouts": 7,
"layoutDurationMs": 1.4780000000000002,
"taskDurationMs": 612.193,
"heapDeltaBytes": 1908968,
"heapUsedBytes": 93421292,
"domNodes": 0,
"jsHeapTotalBytes": 4755456,
"scriptDurationMs": 291.993,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665745856353595,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2889.6499999999605,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.4030000000000007,
"layouts": 8,
"layoutDurationMs": 1.298,
"taskDurationMs": 547.5380000000001,
"heapDeltaBytes": 818284,
"heapUsedBytes": 92622624,
"domNodes": 0,
"jsHeapTotalBytes": 4755456,
"scriptDurationMs": 264.49899999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666091954022992,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2036.2430000000131,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.7950000000000006,
"layouts": 9,
"layoutDurationMs": 1.623,
"taskDurationMs": 471.284,
"heapDeltaBytes": 5106684,
"heapUsedBytes": 84950176,
"domNodes": -274,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 26.269000000000002,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2034.3480000000227,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.4940000000000004,
"layouts": 8,
"layoutDurationMs": 1.422,
"taskDurationMs": 482.49899999999997,
"heapDeltaBytes": -26604620,
"heapUsedBytes": 65863036,
"domNodes": -274,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 30.515,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2736.801000000014,
"styleRecalcs": 26,
"styleRecalcDurationMs": 11.863,
"layouts": 7,
"layoutDurationMs": 1.7249999999999999,
"taskDurationMs": 542.561,
"heapDeltaBytes": -7013844,
"heapUsedBytes": 69345372,
"domNodes": -259,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 161.92199999999997,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666463414634148,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2762.1529999999552,
"styleRecalcs": 28,
"styleRecalcDurationMs": 10.38,
"layouts": 8,
"layoutDurationMs": 1.1620000000000001,
"taskDurationMs": 479.292,
"heapDeltaBytes": -8117964,
"heapUsedBytes": 77191980,
"domNodes": -270,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 139.589,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66626506024096,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-topology-cadence",
"durationMs": 3033.131000000026,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.3909999999999998,
"layouts": 9,
"layoutDurationMs": 1.451,
"taskDurationMs": 740.3629999999998,
"heapDeltaBytes": -22893752,
"heapUsedBytes": 61924332,
"domNodes": -274,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 276.37500000000006,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665934065934067,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3012.5889999999913,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.398,
"layouts": 8,
"layoutDurationMs": 1.221,
"taskDurationMs": 682.0710000000001,
"heapDeltaBytes": 11685616,
"heapUsedBytes": 85882048,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 269.516,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666298342541438,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 508.64400000000387,
"styleRecalcs": 48,
"styleRecalcDurationMs": 4.404999999999999,
"layouts": 10,
"layoutDurationMs": 1.7009999999999998,
"taskDurationMs": 309.06999999999994,
"heapDeltaBytes": -3665492,
"heapUsedBytes": 65444932,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 97.609,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66774193548388,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 565.4140000000325,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.1979999999999995,
"layouts": 10,
"layoutDurationMs": 1.7979999999999998,
"taskDurationMs": 331.728,
"heapDeltaBytes": 23974636,
"heapUsedBytes": 85356388,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 106.546,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667647058823537,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2005.9509999999818,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.7359999999999998,
"layouts": 10,
"layoutDurationMs": 1.6769999999999998,
"taskDurationMs": 397.7320000000001,
"heapDeltaBytes": -8392604,
"heapUsedBytes": 54512888,
"domNodes": -200,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 6.481000000000001,
"eventListeners": -115,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760334,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2027.1960000000036,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.8609999999999998,
"layouts": 9,
"layoutDurationMs": 1.7280000000000002,
"taskDurationMs": 430.94,
"heapDeltaBytes": -5285880,
"heapUsedBytes": 73930740,
"domNodes": -200,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 7.637999999999999,
"eventListeners": -115,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1675.723000000005,
"styleRecalcs": 75,
"styleRecalcDurationMs": 10.520999999999999,
"layouts": 10,
"layoutDurationMs": 1.633,
"taskDurationMs": 574.0659999999999,
"heapDeltaBytes": 19581472,
"heapUsedBytes": 81130668,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 68.981,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1678.8049999998975,
"styleRecalcs": 75,
"styleRecalcDurationMs": 10.139000000000001,
"layouts": 9,
"layoutDurationMs": 1.531,
"taskDurationMs": 575.042,
"heapDeltaBytes": 22749980,
"heapUsedBytes": 84750504,
"domNodes": 0,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 68.11,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 916.2959999999885,
"styleRecalcs": 19,
"styleRecalcDurationMs": 15.081000000000001,
"layouts": 5,
"layoutDurationMs": 9.998999999999999,
"taskDurationMs": 731.439,
"heapDeltaBytes": 11001080,
"heapUsedBytes": 101596316,
"domNodes": 15869,
"jsHeapTotalBytes": 16654336,
"scriptDurationMs": 22.14,
"eventListeners": 3246,
"totalBlockingTimeMs": 117,
"frameDurationMs": 20.368888888888875,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8153.201000000025,
"styleRecalcs": 251,
"styleRecalcDurationMs": 20.157,
"layouts": 9,
"layoutDurationMs": 1.641,
"taskDurationMs": 3948.7129999999997,
"heapDeltaBytes": -18727380,
"heapUsedBytes": 63938832,
"domNodes": -274,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 1700.282,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665848670756645,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8177.571999999941,
"styleRecalcs": 250,
"styleRecalcDurationMs": 23.692,
"layouts": 9,
"layoutDurationMs": 1.373,
"taskDurationMs": 4177.619,
"heapDeltaBytes": -18944852,
"heapUsedBytes": 74398600,
"domNodes": -274,
"jsHeapTotalBytes": 5894144,
"scriptDurationMs": 1792.0379999999998,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66598778004073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 15195.292999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14401.706999999999,
"heapDeltaBytes": -15846312,
"heapUsedBytes": 277605696,
"domNodes": -3329,
"jsHeapTotalBytes": 24109056,
"scriptDurationMs": 192.352,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.45979899497487,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-idle",
"durationMs": 16095.298999999955,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15030.367000000002,
"heapDeltaBytes": -52438308,
"heapUsedBytes": 254345348,
"domNodes": -3329,
"jsHeapTotalBytes": 23584768,
"scriptDurationMs": 217.74300000000002,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.6147512864494,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-large-graph-pan",
"durationMs": 17825.336999999992,
"styleRecalcs": 149,
"styleRecalcDurationMs": 16.75900000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17328.057999999997,
"heapDeltaBytes": 3924200,
"heapUsedBytes": 282743504,
"domNodes": -3329,
"jsHeapTotalBytes": 15118336,
"scriptDurationMs": 679.4359999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.305615942028986,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 18514.161999999942,
"styleRecalcs": 147,
"styleRecalcDurationMs": 17.88300000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18063.434,
"heapDeltaBytes": -8462008,
"heapUsedBytes": 290050020,
"domNodes": -3329,
"jsHeapTotalBytes": 20893696,
"scriptDurationMs": 719.164,
"eventListeners": -651,
"totalBlockingTimeMs": 17,
"frameDurationMs": 33.45244122965642,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5683.59300000003,
"styleRecalcs": 20,
"styleRecalcDurationMs": 45.062999999999995,
"layouts": 20,
"layoutDurationMs": 23.066000000000003,
"taskDurationMs": 5540.942,
"heapDeltaBytes": 5324592,
"heapUsedBytes": 289091340,
"domNodes": -3329,
"jsHeapTotalBytes": 31440896,
"scriptDurationMs": 84.943,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.85028901734104,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5758.440999999948,
"styleRecalcs": 20,
"styleRecalcDurationMs": 43.22699999999999,
"layouts": 20,
"layoutDurationMs": 23.418999999999997,
"taskDurationMs": 5640.661,
"heapDeltaBytes": -37258488,
"heapUsedBytes": 257266796,
"domNodes": -3329,
"jsHeapTotalBytes": 16760832,
"scriptDurationMs": 100.401,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.49259259259259,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7463.060000000041,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7043.729000000001,
"heapDeltaBytes": 1832600,
"heapUsedBytes": 265909984,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 88.15,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.998993288590608,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6167.457000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5816.867,
"heapDeltaBytes": 26830452,
"heapUsedBytes": 282795044,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 95.71499999999993,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.04573378839591,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "workflow-execution",
"durationMs": 118.73600000001261,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.729000000000001,
"layouts": 7,
"layoutDurationMs": 3.1410000000000005,
"taskDurationMs": 98.34,
"heapDeltaBytes": -11273448,
"heapUsedBytes": 63746008,
"domNodes": 132,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 10.58,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.67142857142861,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 467.48200000001816,
"styleRecalcs": 18,
"styleRecalcDurationMs": 9.358000000000002,
"layouts": 12,
"layoutDurationMs": 3.608,
"taskDurationMs": 107.54299999999999,
"heapDeltaBytes": 7315772,
"heapUsedBytes": 66534444,
"domNodes": 133,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.629,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66785714285715,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 360.54300000000694,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.651,
"layouts": 76,
"layoutDurationMs": 12.593,
"taskDurationMs": 306.348,
"heapDeltaBytes": -4971328,
"heapUsedBytes": 37803832,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 133.504,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636382,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 303.41999999996005,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.657,
"layouts": 76,
"layoutDurationMs": 11.396999999999998,
"taskDurationMs": 255.40200000000002,
"heapDeltaBytes": -5781608,
"heapUsedBytes": 38431308,
"domNodes": 4,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 112.21900000000001,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666693,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 348.9630000000261,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.833,
"layouts": 76,
"layoutDurationMs": 11.741,
"taskDurationMs": 316.23400000000004,
"heapDeltaBytes": -1637808,
"heapUsedBytes": 92950496,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 109.43700000000001,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.672727272727283,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 361.7899999999281,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.761,
"layouts": 76,
"layoutDurationMs": 11.960999999999999,
"taskDurationMs": 317.99699999999996,
"heapDeltaBytes": -1653216,
"heapUsedBytes": 89474652,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 112.069,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66363636363634,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageLine coverage: 59.6% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3179 passed, 0 failed · 3 flaky📊 Browser Reports
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 84536b2d3f67253e8d69cbaa7028c78b52f1e1dc
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (273)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 1 finding(s).
| Severity | Count |
|---|---|
| ⚪ Nit | 1 |
Panel: 6/6 reviewers contributed findings.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #22377 +/- ##
==========================================
- Coverage 87.56% 87.51% -0.06%
==========================================
Files 2953 2849 -104
Lines 160839 157821 -3018
Branches 43178 42155 -1023
==========================================
- Hits 140842 138116 -2726
+ Misses 19076 18948 -128
+ Partials 921 757 -164
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
…and the target loop
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 5 Pipeline jobs failed
Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: 22b3252 | Docs | View more details | Give us feedback! |
…and stop it warning twice (Comfy-Org#22476) Merged PRs fail `PR Backport` when the shared bot token runs out of quota, even when no warning is needed. Fixed, along with a duplicate-warning bug. - Reads use the job token, so the shared token's limit can't fail a merge - Only the comment uses the shared token (the job token gets HTTP 403 on POST here, see Comfy-Org#22320) - The "already warned" check now accepts comfy-pr-bot, which has posted the comment since Comfy-Org#22320 - Tests model both tokens: red before (4 failed), green after (17/17) Fixes https://linear.app/comfyorg/issue/FRONT-3753 <details><summary>Full context for agent readers</summary> Since Comfy-Org#22377 merged, 11 of the 16 failed `PR Backport` runs failed in this job with `API rate limit exceeded for user ID 172744619` (comfy-pr-bot), for example https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/41181000307. No warning was lost: every affected PR had no release label, or already had needs-backport. Dedupe: the test fake posted as `github-actions[bot]`, which hid the mismatch. It now posts as `comfy-pr-bot`, with tokens resolved from the workflow env. The job-token reads are the same ones that ran before Comfy-Org#22320 (they reached the POST on Comfy-Org#22310 before it was refused). The job's `permissions:` already cover them. No backport: the workflow runs from main. </details> --------- Co-authored-by: GitHub Action <action@github.com>
Merged PRs with no release label no longer read the PR's comments in the backport-warning job. That lookup was the second call on the shared PR token, and on Oct 30 it failed with
API rate limit exceededon four merges (#22195, #22125, #22157, #21787). None had a release label, so the job had nothing to warn about and still went red.Full context for agent readers
warn-missing-needs-backport, added in fix(ci): warn when a merged PR has release labels but no needs-backport #21357. Live check: it warned once on fix: pick up new node types when ComfyUI reconnects after any restart #22138 (release labels, noneeds-backport) and did not repeat, which is what fix(ci): warn when a merged PR has release labels but no needs-backport #21357 promised.^(core|cloud)/[0-9]+\.[0-9]+$(the pattern the loop already uses).scripts/cicd/backport-missing-trigger.test.tsrecords the fakeghcalls and expects only the labels call for a PR labelledbug,risk:medium,core/1.57-rc. Red before the fix (comments call made), green after; 14/14 pass.main.