Repository navigation
[backport cloud/1.60] fix(extensions): mark agent-created sidebar tabs registered through the imported app - #22938
Conversation
…he imported app (#22829) ## Summary The agent-created "AI" badge, accessible name and right-click menu from #21787 only reached a sidebar tab registered through the `app` passed to `setup(app)`. Extensions usually register through the imported module-level `app`, so their tabs were never marked. Frontend 1.60 QA row EXT02 found this ([QA row](https://github.com/Comfy-Org/ideation-sharing/blob/synap5e/docs/fe160-qa-checklist/fe160-qa-checklist/results/part-b/README.md), `shots/EXT02-*`). Fixes [FRONT-3806](https://linear.app/comfyorg/issue/FRONT-3806). <details><summary>Full context</summary> **Cause.** #21787 attributes a tab by wrapping the `setup()` argument in a proxy whose `extensionManager.registerSidebarTab` records the extension name. The imported `app` is the real singleton, so its `registerSidebarTab` records no source, and `useAgentSidebarTabs.isAgentTab` finds no extension for the tab. **Fix.** `sidebarTabStore.attributeRegistrationsTo(name, run)` attributes tabs registered while `run` executes synchronously. The extension service wraps each `setup()` call in it, both for startup (`invokeExtensionsAsync`) and late-loaded extensions (`invokeStartupHook`). The `setup(app)` proxy stays, because it is the only thing that attributes a tab registered through the argument after an `await`. The window closes as soon as `setup()` returns its promise. Setups run concurrently, so keeping the name across the `await` would let a tab registered later through the imported `app` take another extension's name. Such a tab stays unattributed, which is what `main` does today. One unit case covers this. There is no `sidebarTabs` field on `ComfyExtension` (only `bottomPanelTabs`), so `registerSidebarTab` is the only path to cover. </details> ## Verification - Unit: `extensionService.test.ts` covers both references (setup argument and imported `app`) at startup and for late-loaded extensions, plus the concurrent case. The two imported-`app` cases fail on the parent (`expected undefined to be 'agent.tools.sidebar'`) and pass with the fix. If the store kept the name past `setup()`'s synchronous part, only the concurrent case would fail. - Browser: `agentExtensionProvenance.spec.ts` › "tab registered through the imported app" serves a pack that registers its tab like the QA fixture does (`import { app } from '../../scripts/app.js'`). It needs the built `scripts/app.js` shim, so I ran it on a production build served by `vite preview` against a local ComfyUI backend. **Parent:** fails with `Expected: "Imported cushions (Agent-created)" / Received: "Imported cushions"`, the same symptom QA saw. **Fix:** all 6 cases in the file pass.
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 7 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-05T00:58:28.442Z",
"gitSha": "b4f63e6bb4d9f9ad713a610de410f0c9d32d9858",
"branch": "backport-22829-to-cloud-1.60",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2007.569999999987,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.895,
"layouts": 9,
"layoutDurationMs": 2.6000000000000005,
"taskDurationMs": 544.117,
"heapDeltaBytes": 7610852,
"heapUsedBytes": 69207792,
"domNodes": 0,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 12.097,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2025.1199999999585,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.8520000000000003,
"layouts": 9,
"layoutDurationMs": 2.57,
"taskDurationMs": 566.552,
"heapDeltaBytes": -6741088,
"heapUsedBytes": 55723680,
"domNodes": -178,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 11.605999999999998,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1726.7349999999908,
"styleRecalcs": 73,
"styleRecalcDurationMs": 13.118999999999998,
"layouts": 10,
"layoutDurationMs": 2.665000000000001,
"taskDurationMs": 847.726,
"heapDeltaBytes": -6145468,
"heapUsedBytes": 63556244,
"domNodes": -178,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 133.19599999999997,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667307692307688,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1759.9549999999908,
"styleRecalcs": 74,
"styleRecalcDurationMs": 13.224999999999998,
"layouts": 8,
"layoutDurationMs": 2.058,
"taskDurationMs": 844.944,
"heapDeltaBytes": -9691284,
"heapUsedBytes": 58805736,
"domNodes": -178,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 134.15099999999998,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665094339622645,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.800000000016,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.078000000000001,
"layouts": 12,
"layoutDurationMs": 3.0410000000000004,
"taskDurationMs": 400.903,
"heapDeltaBytes": 7695384,
"heapUsedBytes": 83906216,
"domNodes": 57,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 13.763,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384617,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.1410000000078,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.473,
"layouts": 12,
"layoutDurationMs": 2.399,
"taskDurationMs": 389.02000000000004,
"heapDeltaBytes": 7672424,
"heapUsedBytes": 86084376,
"domNodes": 57,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 12.805,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 584.3509999999981,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.0889999999999995,
"layouts": 10,
"layoutDurationMs": 2.5140000000000002,
"taskDurationMs": 430.90799999999996,
"heapDeltaBytes": 3648832,
"heapUsedBytes": 65273984,
"domNodes": 0,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 140.80800000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66857142857142,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 634.839999999997,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.0580000000000003,
"layouts": 10,
"layoutDurationMs": 2.6629999999999994,
"taskDurationMs": 454.22499999999997,
"heapDeltaBytes": -13862500,
"heapUsedBytes": 59801640,
"domNodes": 0,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 146.559,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663157894736838,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1128.5220000000038,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 830.4680000000001,
"heapDeltaBytes": -10881208,
"heapUsedBytes": 78116524,
"domNodes": -208,
"jsHeapTotalBytes": 19931136,
"scriptDurationMs": 53.57500000000001,
"eventListeners": -107,
"totalBlockingTimeMs": 449,
"frameDurationMs": 30.62972972972972,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1066.1680000000047,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 785.0619999999999,
"heapDeltaBytes": -12168600,
"heapUsedBytes": 77962028,
"domNodes": -208,
"jsHeapTotalBytes": 20455424,
"scriptDurationMs": 51.55,
"eventListeners": -107,
"totalBlockingTimeMs": 399,
"frameDurationMs": 29.627777777777776,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 774.7269999999844,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 431.27299999999957,
"heapDeltaBytes": -2532460,
"heapUsedBytes": 73646000,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 116.91199999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 149,
"frameDurationMs": 23.03823529411765,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 806.1289999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 437.103,
"heapDeltaBytes": -4173612,
"heapUsedBytes": 66637588,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 129.105,
"eventListeners": 0,
"totalBlockingTimeMs": 162,
"frameDurationMs": 23.529411764705884,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8056.579999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7153.0779999999995,
"heapDeltaBytes": 79472296,
"heapUsedBytes": 141825044,
"domNodes": -274,
"jsHeapTotalBytes": 68157440,
"scriptDurationMs": 5424.36,
"eventListeners": -69,
"totalBlockingTimeMs": 49,
"frameDurationMs": 24.3930303030303,
"p95FrameDurationMs": 33.5
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8482.916999999987,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.4730000000000003,
"layouts": 2,
"layoutDurationMs": 0.44500000000000006,
"taskDurationMs": 7622.116,
"heapDeltaBytes": 59836400,
"heapUsedBytes": 135777764,
"domNodes": -274,
"jsHeapTotalBytes": 66973696,
"scriptDurationMs": 5919.7480000000005,
"eventListeners": -69,
"totalBlockingTimeMs": 84,
"frameDurationMs": 24.376436781609197,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8875.09700000001,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.35300000000000004,
"layouts": 1,
"layoutDurationMs": 0.2739999999999999,
"taskDurationMs": 8005.706,
"heapDeltaBytes": -20880604,
"heapUsedBytes": 68701564,
"domNodes": -274,
"jsHeapTotalBytes": 15331328,
"scriptDurationMs": 6298.198,
"eventListeners": -69,
"totalBlockingTimeMs": 213,
"frameDurationMs": 24.812849162011172,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8157.300000000021,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.4869999999999996,
"layouts": 2,
"layoutDurationMs": 0.5820000000000001,
"taskDurationMs": 7294.258,
"heapDeltaBytes": 56413912,
"heapUsedBytes": 150663204,
"domNodes": -274,
"jsHeapTotalBytes": 73789440,
"scriptDurationMs": 5710.018,
"eventListeners": -69,
"totalBlockingTimeMs": 99,
"frameDurationMs": 24.450299401197604,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "large-combo-open",
"durationMs": 228.30500000000598,
"styleRecalcs": 25,
"styleRecalcDurationMs": 13.942000000000002,
"layouts": 12,
"layoutDurationMs": 6.649,
"taskDurationMs": 209.25600000000003,
"heapDeltaBytes": -7373268,
"heapUsedBytes": 68301328,
"domNodes": -2427,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 9.052,
"eventListeners": -582,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.209090909090925,
"p95FrameDurationMs": 66.70000000000027
},
{
"name": "large-combo-open",
"durationMs": 215.34000000002607,
"styleRecalcs": 24,
"styleRecalcDurationMs": 12.240999999999998,
"layouts": 12,
"layoutDurationMs": 3.1270000000000002,
"taskDurationMs": 198.98,
"heapDeltaBytes": -7641056,
"heapUsedBytes": 67137264,
"domNodes": -2427,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.086,
"eventListeners": -582,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.65999999999999,
"p95FrameDurationMs": 66.59999999999991
},
{
"name": "large-graph-idle",
"durationMs": 2038.8419999999883,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.508,
"layouts": 8,
"layoutDurationMs": 2.183,
"taskDurationMs": 664.7429999999998,
"heapDeltaBytes": -4415396,
"heapUsedBytes": 77531408,
"domNodes": -274,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 33.533,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2042.870999999991,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.639,
"layouts": 9,
"layoutDurationMs": 2.5169999999999995,
"taskDurationMs": 672.8389999999999,
"heapDeltaBytes": -32265784,
"heapUsedBytes": 59770876,
"domNodes": -274,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 35.230000000000004,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-pan",
"durationMs": 2983.425000000011,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.188,
"layouts": 8,
"layoutDurationMs": 1.9980000000000002,
"taskDurationMs": 1519.5429999999997,
"heapDeltaBytes": -13750504,
"heapUsedBytes": 77793704,
"domNodes": -274,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 704.924,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6659217877095,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2884.0979999999945,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.371999999999998,
"layouts": 8,
"layoutDurationMs": 1.961,
"taskDurationMs": 1487.5919999999999,
"heapDeltaBytes": -2439436,
"heapUsedBytes": 81588612,
"domNodes": -280,
"jsHeapTotalBytes": 3760128,
"scriptDurationMs": 682.304,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665895953757225,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3851.8359999999916,
"styleRecalcs": 73,
"styleRecalcDurationMs": 10.483999999999998,
"layouts": 66,
"layoutDurationMs": 10.662999999999998,
"taskDurationMs": 1600.6939999999997,
"heapDeltaBytes": 398128,
"heapUsedBytes": 85430420,
"domNodes": -250,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 673.687,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665800865800865,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3988.8819999999896,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.376,
"layouts": 64,
"layoutDurationMs": 10.657,
"taskDurationMs": 1643.62,
"heapDeltaBytes": -18186684,
"heapUsedBytes": 66378476,
"domNodes": -250,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 704.536,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610878661088,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "legacy-node-drag",
"durationMs": 2945.464999999956,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.734999999999999,
"layouts": 6,
"layoutDurationMs": 1.5030000000000003,
"taskDurationMs": 1780.2380000000003,
"heapDeltaBytes": -9947200,
"heapUsedBytes": 77195828,
"domNodes": 0,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 860.34,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.761142857142858,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3043.1570000000647,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.550999999999999,
"layouts": 5,
"layoutDurationMs": 1.262,
"taskDurationMs": 1846.415,
"heapDeltaBytes": -3538324,
"heapUsedBytes": 91305780,
"domNodes": 0,
"jsHeapTotalBytes": 6221824,
"scriptDurationMs": 908.347,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.758563535911602,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2984.319999999997,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.9300000000000004,
"layouts": 7,
"layoutDurationMs": 1.7830000000000001,
"taskDurationMs": 643.349,
"heapDeltaBytes": 462836,
"heapUsedBytes": 92813048,
"domNodes": 0,
"jsHeapTotalBytes": 5017600,
"scriptDurationMs": 296.45,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66536312849162,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2993.88399999998,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.8060000000000003,
"layouts": 7,
"layoutDurationMs": 1.6070000000000002,
"taskDurationMs": 634.5549999999998,
"heapDeltaBytes": 2158276,
"heapUsedBytes": 93693860,
"domNodes": 0,
"jsHeapTotalBytes": 4231168,
"scriptDurationMs": 299.122,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611111111111,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2052.2789999999986,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.1609999999999996,
"layouts": 7,
"layoutDurationMs": 1.8850000000000002,
"taskDurationMs": 646.414,
"heapDeltaBytes": 7141792,
"heapUsedBytes": 82438844,
"domNodes": -274,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 32.721000000000004,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2051.836000000094,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.3379999999999996,
"layouts": 7,
"layoutDurationMs": 2.183,
"taskDurationMs": 650.2600000000001,
"heapDeltaBytes": 6619984,
"heapUsedBytes": 82050496,
"domNodes": -274,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 37.018,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2804.076000000009,
"styleRecalcs": 27,
"styleRecalcDurationMs": 11.28,
"layouts": 8,
"layoutDurationMs": 1.924,
"taskDurationMs": 568.289,
"heapDeltaBytes": -6927764,
"heapUsedBytes": 65231580,
"domNodes": -260,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 172.42600000000002,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666071428571428,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2742.664999999988,
"styleRecalcs": 27,
"styleRecalcDurationMs": 10.767000000000001,
"layouts": 7,
"layoutDurationMs": 1.4839999999999998,
"taskDurationMs": 540.321,
"heapDeltaBytes": -6146368,
"heapUsedBytes": 78627932,
"domNodes": -256,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 167.407,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666060606060608,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3212.7099999999873,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.3040000000000003,
"layouts": 9,
"layoutDurationMs": 2.021,
"taskDurationMs": 859.138,
"heapDeltaBytes": -17830680,
"heapUsedBytes": 66429356,
"domNodes": -274,
"jsHeapTotalBytes": 5894144,
"scriptDurationMs": 334.11100000000005,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-topology-cadence",
"durationMs": 3112.842999999998,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.7009999999999994,
"layouts": 6,
"layoutDurationMs": 1.6119999999999999,
"taskDurationMs": 845.1479999999999,
"heapDeltaBytes": -15643352,
"heapUsedBytes": 68935224,
"domNodes": -274,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 310.584,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666310160427805,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 546.5399999999931,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.319,
"layouts": 9,
"layoutDurationMs": 2.3660000000000005,
"taskDurationMs": 384.85100000000006,
"heapDeltaBytes": 23870516,
"heapUsedBytes": 87394948,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 120.77700000000002,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 546.7390000000023,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.205,
"layouts": 10,
"layoutDurationMs": 2.374,
"taskDurationMs": 375.97799999999995,
"heapDeltaBytes": 24293408,
"heapUsedBytes": 87026648,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 123.83,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2048.5009999999875,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.486,
"layouts": 8,
"layoutDurationMs": 2.186,
"taskDurationMs": 621.16,
"heapDeltaBytes": -3169832,
"heapUsedBytes": 60045764,
"domNodes": -200,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 11.553999999999998,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2039.6400000000199,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.8670000000000004,
"layouts": 9,
"layoutDurationMs": 2.451,
"taskDurationMs": 598.2080000000001,
"heapDeltaBytes": -7029756,
"heapUsedBytes": 54671592,
"domNodes": -200,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 11.905000000000001,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1741.0869999999932,
"styleRecalcs": 77,
"styleRecalcDurationMs": 14.264000000000003,
"layouts": 9,
"layoutDurationMs": 2.273,
"taskDurationMs": 794.426,
"heapDeltaBytes": -951280,
"heapUsedBytes": 74789632,
"domNodes": -200,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 96.102,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.2460000000115,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.664,
"layouts": 9,
"layoutDurationMs": 2.182,
"taskDurationMs": 761.8000000000001,
"heapDeltaBytes": 22756052,
"heapUsedBytes": 85534932,
"domNodes": 0,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 100.022,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1454.2940000000044,
"styleRecalcs": 17,
"styleRecalcDurationMs": 22.84,
"layouts": 5,
"layoutDurationMs": 14.024,
"taskDurationMs": 1209.0100000000002,
"heapDeltaBytes": -5230120,
"heapUsedBytes": 102241704,
"domNodes": 19229,
"jsHeapTotalBytes": 14680064,
"scriptDurationMs": 51.565999999999995,
"eventListeners": 3566,
"totalBlockingTimeMs": 152,
"frameDurationMs": 20.0904109589041,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 10997.513000000026,
"styleRecalcs": 251,
"styleRecalcDurationMs": 31.141000000000002,
"layouts": 9,
"layoutDurationMs": 2.179,
"taskDurationMs": 5267.463999999999,
"heapDeltaBytes": -10188624,
"heapUsedBytes": 73220388,
"domNodes": -274,
"jsHeapTotalBytes": 4513792,
"scriptDurationMs": 2357.494,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66590909090909,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 11747.433999999997,
"styleRecalcs": 251,
"styleRecalcDurationMs": 32.345000000000006,
"layouts": 9,
"layoutDurationMs": 2.483,
"taskDurationMs": 5448.966,
"heapDeltaBytes": 4174208,
"heapUsedBytes": 88252964,
"domNodes": -274,
"jsHeapTotalBytes": 3989504,
"scriptDurationMs": 2429.2889999999998,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666051136363635,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 21039.851,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20630.955,
"heapDeltaBytes": -23127404,
"heapUsedBytes": 266443560,
"domNodes": -3482,
"jsHeapTotalBytes": 11517952,
"scriptDurationMs": 282.434,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.58767857142857,
"p95FrameDurationMs": 66.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 20862.578999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20239.745,
"heapDeltaBytes": -16261668,
"heapUsedBytes": 289174832,
"domNodes": -3482,
"jsHeapTotalBytes": 10469376,
"scriptDurationMs": 268.83299999999997,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.976684881602914,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 25497.82099999999,
"styleRecalcs": 180,
"styleRecalcDurationMs": 23.948999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 25208.731,
"heapDeltaBytes": -19637652,
"heapUsedBytes": 273730328,
"domNodes": -3482,
"jsHeapTotalBytes": 16596992,
"scriptDurationMs": 784.106,
"eventListeners": -659,
"totalBlockingTimeMs": 5,
"frameDurationMs": 49.16281310211946,
"p95FrameDurationMs": 100
},
{
"name": "vue-large-graph-pan",
"durationMs": 25206.014999999978,
"styleRecalcs": 181,
"styleRecalcDurationMs": 22.999999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24936.014,
"heapDeltaBytes": -31614748,
"heapUsedBytes": 259240984,
"domNodes": -3482,
"jsHeapTotalBytes": 14925824,
"scriptDurationMs": 809.3789999999999,
"eventListeners": -659,
"totalBlockingTimeMs": 4,
"frameDurationMs": 47.81612903225807,
"p95FrameDurationMs": 99.89999999999782
},
{
"name": "vue-node-resize-workload",
"durationMs": 7450.283999999954,
"styleRecalcs": 20,
"styleRecalcDurationMs": 51.766000000000005,
"layouts": 20,
"layoutDurationMs": 25.028999999999996,
"taskDurationMs": 7350.581999999999,
"heapDeltaBytes": -11094508,
"heapUsedBytes": 279036964,
"domNodes": -3482,
"jsHeapTotalBytes": 20701184,
"scriptDurationMs": 99.838,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.982840236686386,
"p95FrameDurationMs": 99.89999999999964
},
{
"name": "vue-node-resize-workload",
"durationMs": 7319.505000000049,
"styleRecalcs": 20,
"styleRecalcDurationMs": 45.293,
"layouts": 20,
"layoutDurationMs": 20.436999999999998,
"taskDurationMs": 7204.105,
"heapDeltaBytes": -24880152,
"heapUsedBytes": 272825280,
"domNodes": -3482,
"jsHeapTotalBytes": 24633344,
"scriptDurationMs": 100.784,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 44.17530120481928,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10689.575999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10509.140000000001,
"heapDeltaBytes": -1387476,
"heapUsedBytes": 280961576,
"domNodes": -3126,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 141.096,
"eventListeners": -654,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.77509293680298,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10257.558000000017,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10021.096,
"heapDeltaBytes": -6758752,
"heapUsedBytes": 280864328,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 137.913,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.06245487364621,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "workflow-execution",
"durationMs": 98.17400000002863,
"styleRecalcs": 7,
"styleRecalcDurationMs": 8.418,
"layouts": 7,
"layoutDurationMs": 2.865,
"taskDurationMs": 81.003,
"heapDeltaBytes": 4959052,
"heapUsedBytes": 66127448,
"domNodes": 124,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.297,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 95.64999999997781,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.321,
"layouts": 7,
"layoutDurationMs": 2.5180000000000002,
"taskDurationMs": 73.564,
"heapDeltaBytes": -12690340,
"heapUsedBytes": 61635408,
"domNodes": 102,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 4.989999999999999,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 299.9089999999569,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.6040000000000001,
"layouts": 76,
"layoutDurationMs": 11.862,
"taskDurationMs": 261.045,
"heapDeltaBytes": -5521884,
"heapUsedBytes": 38210720,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 121.828,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66111111111109,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 314.8310000000265,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.565,
"layouts": 76,
"layoutDurationMs": 11.473,
"taskDurationMs": 277.805,
"heapDeltaBytes": -5417908,
"heapUsedBytes": 37612184,
"domNodes": 4,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 128.009,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66842105263157,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 346.7090000000326,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.848,
"layouts": 76,
"layoutDurationMs": 11.41,
"taskDurationMs": 311.684,
"heapDeltaBytes": -1468024,
"heapUsedBytes": 100667228,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 111.603,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 347.42400000004636,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.51,
"layouts": 76,
"layoutDurationMs": 11.906,
"taskDurationMs": 324.423,
"heapDeltaBytes": -1074228,
"heapUsedBytes": 101133644,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 124.93599999999999,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66818181818181,
"p95FrameDurationMs": 16.700000000000728
}
]
}🎭 Playwright: ✅ 3222 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure
Findings and check detailsExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Full docs: scripts/registry-census/README.md Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
🌾 Fallow: ✅ PassedFindings and check detailsFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Full docs: ADR-DEVEX-LINT-0015 Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 2dcef6cbca1278c5214b2858aaf02b2700d7de3a
🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (356)
Full docs: Frontend domain catalog Reproduce locallypnpm architecture:check |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.60 #22938 +/- ##
=============================================
Coverage ? 87.50%
=============================================
Files ? 2889
Lines ? 159409
Branches ? 42697
=============================================
Hits ? 139491
Misses ? 19155
Partials ? 763
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #22829 to
cloud/1.60Automatically created by backport workflow.