Repository navigation
[backport cloud/1.58] FE-3587 fix(billing): show the yearly Team price the server bills (#21748) - #21805
Conversation
…1748) ## Summary ### Why On prod, the pricing dialog says a yearly Team plan at the 147.7K stop (team_700) is **$7,560 billed yearly**, but billing.comfy.org checkout and Stripe charge **$7,560.01**. team_1400 and team_2500 are off by 1¢ and 2¢ as well. Users see one price in the app and a different one at payment. Reported in #proj-billing: https://comfy-organization.slack.com/archives/C0BNGQG2LCW/p1792702247172369 Linear: FE-3587 ### Root cause The frontend computed the yearly total itself: `CreditSlider` showed the rounded monthly price × 12, and the checkout summary / success screens showed `monthlyPriceUsd.yearly × 12`, all starting from `yearly.price_cents` (list price minus the discount). The server bills `PerCreditChargeCents` instead: 1,772,400 credits × the Stripe per-credit `unit_amount_decimal` 0.473934¢ = 840,000.6216¢, rounded to 840,001¢, and the 10% coupon leaves 756,000.9¢, rounded to 756,001¢. The two numbers only agree when the per-credit line divides evenly. The FE was deriving a price the server already owns. ### How - cloud#15376 now returns `period_charge_cents` per stop price (one month for `monthly`, one year for `yearly`), the same value checkout quotes. The ingest-types sync is #21746, which this PR stacks on. - `mapApiTeamCreditStops` carries it as `periodChargeUsd { monthly, yearly }`. It flows through the team selection (`UnifiedPricingTable`, `useSubscriptionDialog`, `usePricingTableUrlLoader`) into `CheckoutPlan.yearlyChargeUsd` (`useCheckoutCopy`, billing-web `teamCheckoutPlan`). - The three yearly-total surfaces show that value as is: the slider's "Billed yearly", `CheckoutSubscribeSummary`'s billed line, and `CheckoutSuccess`'s yearly price. - The hardcoded OSS / pre-deploy fallback stops have no server charge, so they keep 12× the monthly price. The per-month figure ($630) is unchanged. ## AS IS / TO BE | AS IS | TO BE | | --- | --- | | <img width="480" src="https://github.com/user-attachments/assets/a34866c9-d536-4fcf-b879-0f78fd0ae24f"> | <img width="480" src="https://github.com/user-attachments/assets/95e047a2-71f2-4461-b704-b155eb97229d"> | Local dev server on this branch against prod cloud.comfy.org, signed in to team workspace `test-team1` (no subscription), real `/api/billing/plans`; For Teams, Yearly, default 147.7K stop. AS IS swaps in `main`'s `CreditSlider.vue` only. ## Verification - New `CreditSlider` test "bills the yearly total the server charges, not 12x the monthly price" fails on the old component ("$7,560 Billed yearly") and passes here ("$7,560.01 Billed yearly"). - `catalog.test.ts` (mapping carries `periodChargeUsd`), `CheckoutSuccess.test.ts` (team stop shows `$7560.01`), billing-web `checkoutRequest.test.ts` (`yearlyChargeUsd: 7560.01` from a 756001¢ charge). - Vitest: app 4 files / 166 tests, account-ui 2 / 19, billing-web 15 / 690 pass. `pnpm typecheck`, `typecheck:billing-web`, `typecheck:account-ui`: 0 errors. ## Where this sits in the plan | Step | Item | Ticket / PR | Status | | --- | --- | --- | --- | | 1 | Plans API returns each stop's period charge | cloud#15376 | Merged | | 2 | Sync ingest types + billing fixtures | #21746 | Open | | 3 | **Show the server's yearly charge in pricing and checkout (this PR)** | FE-3587 | **This PR** | | 4 | Backport to core/cloud 1.58 | needs-backport | After merge | ```mermaid graph LR be["cloud 15376 period_charge_cents (merged)"] --> sync["PR 21746 ingest types sync"] sync --> fe["FE-3587 yearly charge in pricing (this PR)"] fe --> bp["backport core/cloud 1.58"] style fe stroke-width:3px ```
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-23T13:45:55.710Z",
"gitSha": "77c18ea6bc0741e54b23e3e03906ea55b680c141",
"branch": "backport-21748-to-cloud-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2056.020999999987,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.333,
"layouts": 9,
"layoutDurationMs": 3.077,
"taskDurationMs": 644.397,
"heapDeltaBytes": -323236,
"heapUsedBytes": 89896912,
"domNodes": -200,
"jsHeapTotalBytes": 1482752,
"scriptDurationMs": 13.297,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2023.5359999999218,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.682,
"layouts": 10,
"layoutDurationMs": 3.13,
"taskDurationMs": 594.527,
"heapDeltaBytes": 4197096,
"heapUsedBytes": 103993124,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 12.532000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1808.2110000000284,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.665999999999999,
"layouts": 9,
"layoutDurationMs": 2.858,
"taskDurationMs": 861.0559999999999,
"heapDeltaBytes": 1198212,
"heapUsedBytes": 91469296,
"domNodes": -200,
"jsHeapTotalBytes": 3317760,
"scriptDurationMs": 176.07099999999997,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2075.7999999999583,
"styleRecalcs": 84,
"styleRecalcDurationMs": 15.93,
"layouts": 9,
"layoutDurationMs": 2.6489999999999996,
"taskDurationMs": 1177.128,
"heapDeltaBytes": -15657848,
"heapUsedBytes": 83074928,
"domNodes": -180,
"jsHeapTotalBytes": 2596864,
"scriptDurationMs": 171.99,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.80162601626016,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.034999999968,
"styleRecalcs": 19,
"styleRecalcDurationMs": 6.010999999999999,
"layouts": 12,
"layoutDurationMs": 3.6169999999999995,
"taskDurationMs": 459.36299999999994,
"heapDeltaBytes": -499876,
"heapUsedBytes": 98535748,
"domNodes": 47,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 14.724999999999998,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.4200000000565,
"styleRecalcs": 20,
"styleRecalcDurationMs": 6.1080000000000005,
"layouts": 11,
"layoutDurationMs": 3.616,
"taskDurationMs": 451.46500000000003,
"heapDeltaBytes": -1298316,
"heapUsedBytes": 90994440,
"domNodes": 47,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 14.389,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 661.6179999999758,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.818,
"layouts": 8,
"layoutDurationMs": 2.522,
"taskDurationMs": 462.092,
"heapDeltaBytes": 3633612,
"heapUsedBytes": 93933576,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 179.38099999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664102564102567,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 648.6879999999928,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.197,
"layouts": 9,
"layoutDurationMs": 2.777,
"taskDurationMs": 463.69800000000004,
"heapDeltaBytes": 4073596,
"heapUsedBytes": 94842588,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 174.136,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668421052631583,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1256.510999999989,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 989.376,
"heapDeltaBytes": -14637048,
"heapUsedBytes": 102350508,
"domNodes": -210,
"jsHeapTotalBytes": 15646720,
"scriptDurationMs": 74.757,
"eventListeners": -168,
"totalBlockingTimeMs": 565,
"frameDurationMs": 33.7810810810811,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1290.9450000000788,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1005.0029999999998,
"heapDeltaBytes": -14865984,
"heapUsedBytes": 102154452,
"domNodes": -210,
"jsHeapTotalBytes": 15384576,
"scriptDurationMs": 81.44699999999999,
"eventListeners": -168,
"totalBlockingTimeMs": 590,
"frameDurationMs": 33.768421052631574,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 858.0249999999978,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 513.6239999999997,
"heapDeltaBytes": -3578528,
"heapUsedBytes": 97683728,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 158.275,
"eventListeners": 0,
"totalBlockingTimeMs": 212,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 840.8329999999751,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 477.31499999999994,
"heapDeltaBytes": -4053756,
"heapUsedBytes": 97554380,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 168.34499999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 222,
"frameDurationMs": 24.99705882352943,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10353.460000000012,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9443.594000000001,
"heapDeltaBytes": 34213948,
"heapUsedBytes": 137539260,
"domNodes": -296,
"jsHeapTotalBytes": 24289280,
"scriptDurationMs": 7755.342,
"eventListeners": -130,
"totalBlockingTimeMs": 1223,
"frameDurationMs": 31.746932515337424,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11670.946000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10861.705,
"heapDeltaBytes": 68411444,
"heapUsedBytes": 183039472,
"domNodes": -276,
"jsHeapTotalBytes": 59482112,
"scriptDurationMs": 8759.004,
"eventListeners": -130,
"totalBlockingTimeMs": 1470,
"frameDurationMs": 31.27667560321716,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 12171.37599999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11392.403999999999,
"heapDeltaBytes": 57358704,
"heapUsedBytes": 180702984,
"domNodes": -276,
"jsHeapTotalBytes": 57909248,
"scriptDurationMs": 9353.842999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 1833,
"frameDurationMs": 32.70483870967742,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10629.14699999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9813.837999999998,
"heapDeltaBytes": -11981256,
"heapUsedBytes": 107929412,
"domNodes": -276,
"jsHeapTotalBytes": -3956736,
"scriptDurationMs": 7939.147,
"eventListeners": -130,
"totalBlockingTimeMs": 974,
"frameDurationMs": 31.272941176470585,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 221.80099999999925,
"styleRecalcs": 24,
"styleRecalcDurationMs": 15.793000000000001,
"layouts": 11,
"layoutDurationMs": 3.714,
"taskDurationMs": 171.061,
"heapDeltaBytes": 13202548,
"heapUsedBytes": 119894724,
"domNodes": 917,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.129999999999999,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.199999999999985,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-combo-open",
"durationMs": 230.0390000000334,
"styleRecalcs": 25,
"styleRecalcDurationMs": 15.18,
"layouts": 11,
"layoutDurationMs": 3.6180000000000003,
"taskDurationMs": 181.141,
"heapDeltaBytes": 13184100,
"heapUsedBytes": 120659604,
"domNodes": 917,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 9.149999999999999,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.209090909090925,
"p95FrameDurationMs": 66.80000000000018
},
{
"name": "large-graph-idle",
"durationMs": 2041.1209999999755,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.895,
"layouts": 8,
"layoutDurationMs": 2.4990000000000006,
"taskDurationMs": 587.309,
"heapDeltaBytes": 906144,
"heapUsedBytes": 111187640,
"domNodes": -296,
"jsHeapTotalBytes": -614400,
"scriptDurationMs": 36.387,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2023.4140000000025,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.5229999999999992,
"layouts": 10,
"layoutDurationMs": 3.354,
"taskDurationMs": 536.7469999999998,
"heapDeltaBytes": -1014912,
"heapUsedBytes": 109396252,
"domNodes": -296,
"jsHeapTotalBytes": -1662976,
"scriptDurationMs": 33.169000000000004,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2240.932999999984,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.541,
"layouts": 8,
"layoutDurationMs": 2.1849999999999996,
"taskDurationMs": 1600.2150000000001,
"heapDeltaBytes": 1293128,
"heapUsedBytes": 112606696,
"domNodes": -296,
"jsHeapTotalBytes": -389120,
"scriptDurationMs": 841.159,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.79097744360902,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2818.783000000053,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.661,
"layouts": 7,
"layoutDurationMs": 1.753,
"taskDurationMs": 1808.367,
"heapDeltaBytes": -9009200,
"heapUsedBytes": 113627968,
"domNodes": -276,
"jsHeapTotalBytes": -24576,
"scriptDurationMs": 843.1350000000001,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666272189349108,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 4167.3499999999985,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.834,
"layouts": 64,
"layoutDurationMs": 11.039,
"taskDurationMs": 1990.7510000000002,
"heapDeltaBytes": -16196232,
"heapUsedBytes": 97101704,
"domNodes": -272,
"jsHeapTotalBytes": -1007616,
"scriptDurationMs": 852.197,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.73293172690763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3570.4429999999547,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.292999999999997,
"layouts": 64,
"layoutDurationMs": 11.065999999999999,
"taskDurationMs": 1695,
"heapDeltaBytes": -21373976,
"heapUsedBytes": 91606452,
"domNodes": -252,
"jsHeapTotalBytes": -483328,
"scriptDurationMs": 799.0330000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635514018692,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3234.534999999994,
"styleRecalcs": 44,
"styleRecalcDurationMs": 6.159000000000001,
"layouts": 5,
"layoutDurationMs": 1.7359999999999998,
"taskDurationMs": 2146.073,
"heapDeltaBytes": 19633528,
"heapUsedBytes": 121930500,
"domNodes": 0,
"jsHeapTotalBytes": 3305472,
"scriptDurationMs": 1030.739,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.92487046632125,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3217.777999999953,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.114,
"layouts": 3,
"layoutDurationMs": 0.932,
"taskDurationMs": 2071.2990000000004,
"heapDeltaBytes": 19409652,
"heapUsedBytes": 122468296,
"domNodes": 0,
"jsHeapTotalBytes": 3567616,
"scriptDurationMs": 1001.5,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.014659685863876,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2030.2800000000047,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.549,
"layouts": 7,
"layoutDurationMs": 2.641,
"taskDurationMs": 602.6709999999999,
"heapDeltaBytes": -465788,
"heapUsedBytes": 112489968,
"domNodes": -296,
"jsHeapTotalBytes": -876544,
"scriptDurationMs": 39.260000000000005,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2054.9330000000054,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.535,
"layouts": 7,
"layoutDurationMs": 2.167,
"taskDurationMs": 729.0960000000001,
"heapDeltaBytes": -2773044,
"heapUsedBytes": 110256296,
"domNodes": -296,
"jsHeapTotalBytes": -1400832,
"scriptDurationMs": 37.288000000000004,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 722.0290000000205,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.675000000000001,
"layouts": 9,
"layoutDurationMs": 2.527,
"taskDurationMs": 501.255,
"heapDeltaBytes": -201532,
"heapUsedBytes": 90168444,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 152.096,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66744186046511,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 560.0010000000566,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.646999999999999,
"layouts": 10,
"layoutDurationMs": 3.17,
"taskDurationMs": 397.585,
"heapDeltaBytes": -569400,
"heapUsedBytes": 90230932,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 148.33599999999998,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352926,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2033.640000000048,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.396,
"layouts": 10,
"layoutDurationMs": 3.512,
"taskDurationMs": 649.727,
"heapDeltaBytes": -23073920,
"heapUsedBytes": 78251420,
"domNodes": 0,
"jsHeapTotalBytes": 1286144,
"scriptDurationMs": 11.545,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2040.6659999999874,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.1100000000000008,
"layouts": 9,
"layoutDurationMs": 2.9349999999999996,
"taskDurationMs": 452.842,
"heapDeltaBytes": 7061704,
"heapUsedBytes": 97961444,
"domNodes": -218,
"jsHeapTotalBytes": 2007040,
"scriptDurationMs": 10.405999999999999,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 2025.3280000000018,
"styleRecalcs": 88,
"styleRecalcDurationMs": 16.133000000000003,
"layouts": 10,
"layoutDurationMs": 3.225,
"taskDurationMs": 1180.87,
"heapDeltaBytes": 4476356,
"heapUsedBytes": 106945204,
"domNodes": -218,
"jsHeapTotalBytes": 11247616,
"scriptDurationMs": 121.864,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1742.159000000015,
"styleRecalcs": 78,
"styleRecalcDurationMs": 14.696999999999997,
"layouts": 9,
"layoutDurationMs": 2.815,
"taskDurationMs": 894.766,
"heapDeltaBytes": -6285784,
"heapUsedBytes": 96366892,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 113.997,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1453.142000000014,
"styleRecalcs": 18,
"styleRecalcDurationMs": 27.710000000000004,
"layouts": 5,
"layoutDurationMs": 17.179,
"taskDurationMs": 1130.228,
"heapDeltaBytes": 35862336,
"heapUsedBytes": 139883304,
"domNodes": 16030,
"jsHeapTotalBytes": 16392192,
"scriptDurationMs": 32.693,
"eventListeners": 3244,
"totalBlockingTimeMs": 175,
"frameDurationMs": 20.09178082191782,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 11432.969000000014,
"styleRecalcs": 250,
"styleRecalcDurationMs": 31.769000000000005,
"layouts": 8,
"layoutDurationMs": 2.4430000000000005,
"taskDurationMs": 6486.061000000001,
"heapDeltaBytes": -20184528,
"heapUsedBytes": 89679528,
"domNodes": -276,
"jsHeapTotalBytes": -876544,
"scriptDurationMs": 2882.822,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665889212827988,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8392.246,
"styleRecalcs": 251,
"styleRecalcDurationMs": 31.767999999999997,
"layouts": 9,
"layoutDurationMs": 2.8739999999999997,
"taskDurationMs": 5637.577,
"heapDeltaBytes": -30998972,
"heapUsedBytes": 90869440,
"domNodes": -276,
"jsHeapTotalBytes": -249856,
"scriptDurationMs": 2861.7279999999996,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.732470119521913,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16871.658000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16089.526,
"heapDeltaBytes": -15910712,
"heapUsedBytes": 303937456,
"domNodes": -3344,
"jsHeapTotalBytes": 14667776,
"scriptDurationMs": 259.85600000000005,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.158203799654576,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-idle",
"durationMs": 16553.953999999976,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15459.457,
"heapDeltaBytes": -20001664,
"heapUsedBytes": 290201452,
"domNodes": -3373,
"jsHeapTotalBytes": 9424896,
"scriptDurationMs": 242.69800000000004,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.261025641025643,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-large-graph-pan",
"durationMs": 19894.196999999964,
"styleRecalcs": 161,
"styleRecalcDurationMs": 19.041000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19564.175,
"heapDeltaBytes": -5310928,
"heapUsedBytes": 306808512,
"domNodes": -3344,
"jsHeapTotalBytes": 21483520,
"scriptDurationMs": 876.0530000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 32,
"frameDurationMs": 36.74520295202952,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 19558.9829999999,
"styleRecalcs": 162,
"styleRecalcDurationMs": 15.724999999999989,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19094.627,
"heapDeltaBytes": -15231304,
"heapUsedBytes": 285509024,
"domNodes": -3344,
"jsHeapTotalBytes": 13881344,
"scriptDurationMs": 822.151,
"eventListeners": -651,
"totalBlockingTimeMs": 14,
"frameDurationMs": 35.80439560439561,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6186.637000000019,
"styleRecalcs": 20,
"styleRecalcDurationMs": 66.11200000000004,
"layouts": 20,
"layoutDurationMs": 24.115,
"taskDurationMs": 6014.025000000001,
"heapDeltaBytes": -35159504,
"heapUsedBytes": 269614320,
"domNodes": -3344,
"jsHeapTotalBytes": 5754880,
"scriptDurationMs": 107.50599999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.73651685393258,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6022.548999999913,
"styleRecalcs": 20,
"styleRecalcDurationMs": 68.37899999999999,
"layouts": 20,
"layoutDurationMs": 22.722999999999992,
"taskDurationMs": 5861.166,
"heapDeltaBytes": -15270112,
"heapUsedBytes": 294838144,
"domNodes": -3344,
"jsHeapTotalBytes": 18862080,
"scriptDurationMs": 98.831,
"eventListeners": -653,
"totalBlockingTimeMs": 17,
"frameDurationMs": 34.184090909090905,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11589.218000000017,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11360.826000000003,
"heapDeltaBytes": 10372108,
"heapUsedBytes": 280884696,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 169.3429999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.0795847750865,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11948.835000000032,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11651.355,
"heapDeltaBytes": -8672152,
"heapUsedBytes": 532601520,
"domNodes": 0,
"jsHeapTotalBytes": -1310720,
"scriptDurationMs": 163.76200000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.644897959183666,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "workflow-execution",
"durationMs": 483.89200000002575,
"styleRecalcs": 13,
"styleRecalcDurationMs": 10.815999999999999,
"layouts": 11,
"layoutDurationMs": 4.877000000000001,
"taskDurationMs": 134.49899999999997,
"heapDeltaBytes": 7118908,
"heapUsedBytes": 104548340,
"domNodes": 98,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 12.418000000000001,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668965517241396,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 485.51900000006754,
"styleRecalcs": 23,
"styleRecalcDurationMs": 11.373999999999999,
"layouts": 13,
"layoutDurationMs": 4.771999999999999,
"taskDurationMs": 130.08199999999997,
"heapDeltaBytes": 7015720,
"heapUsedBytes": 97309704,
"domNodes": 121,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.810000000000002,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 467.83400000003894,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.694,
"layouts": 76,
"layoutDurationMs": 14.915,
"taskDurationMs": 421.63,
"heapDeltaBytes": -14621064,
"heapUsedBytes": 79053636,
"domNodes": 4,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 199.19899999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667857142857137,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 540.3579999999693,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.643,
"layouts": 76,
"layoutDurationMs": 14.77,
"taskDurationMs": 492.258,
"heapDeltaBytes": -13486640,
"heapUsedBytes": 81914732,
"domNodes": 4,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 240.405,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 598.1709999999794,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.437,
"layouts": 76,
"layoutDurationMs": 15.020999999999999,
"taskDurationMs": 566.106,
"heapDeltaBytes": 997716,
"heapUsedBytes": 118507340,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 235.232,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.127777777777787,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 546.4510000000473,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.22,
"layouts": 76,
"layoutDurationMs": 13.84,
"taskDurationMs": 512.06,
"heapDeltaBytes": 610772,
"heapUsedBytes": 117544516,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 205.245,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 64.0% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2961 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 6585c38d37019ec84a1d0ccd43f85e339939111e
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (118)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog 🌐 Website E2ETip All tests passed. Test results
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.58 #21805 +/- ##
=============================================
Coverage ? 84.04%
=============================================
Files ? 4094
Lines ? 191017
Branches ? 49670
=============================================
Hits ? 160532
Misses ? 28353
Partials ? 2132
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Approved: this backport is mechanically faithful to its merged source. The full exact-head check set is settled, the review thread set is empty, and no package manifest or export map changes.
Full context for agent readers
I compared the sorted additions and deletions with the merged source and inspected the resulting release-line diff. The behavior and verification remain intact.
Why
Backport of #21748 to cloud/1.58. Its prerequisite, the ingest-types sync #21746, landed on this branch via #21781.
How
Cherry-pick of 479cecf onto origin/cloud/1.58.
Conflicts: Clean cherry-pick.
AS IS / TO BE: see #21748.