Repository navigation
[backport core/1.58] FE-3587 fix(billing): show the yearly Team price the server bills (#21748) - #21804
Conversation
…1748) ## Summary ### Why On prod, the pricing dialog says a yearly Team plan at the 147.7K stop (team_700) is **$7,560 billed yearly**, but billing.comfy.org checkout and Stripe charge **$7,560.01**. team_1400 and team_2500 are off by 1¢ and 2¢ as well. Users see one price in the app and a different one at payment. Reported in #proj-billing: https://comfy-organization.slack.com/archives/C0BNGQG2LCW/p1792702247172369 Linear: FE-3587 ### Root cause The frontend computed the yearly total itself: `CreditSlider` showed the rounded monthly price × 12, and the checkout summary / success screens showed `monthlyPriceUsd.yearly × 12`, all starting from `yearly.price_cents` (list price minus the discount). The server bills `PerCreditChargeCents` instead: 1,772,400 credits × the Stripe per-credit `unit_amount_decimal` 0.473934¢ = 840,000.6216¢, rounded to 840,001¢, and the 10% coupon leaves 756,000.9¢, rounded to 756,001¢. The two numbers only agree when the per-credit line divides evenly. The FE was deriving a price the server already owns. ### How - cloud#15376 now returns `period_charge_cents` per stop price (one month for `monthly`, one year for `yearly`), the same value checkout quotes. The ingest-types sync is #21746, which this PR stacks on. - `mapApiTeamCreditStops` carries it as `periodChargeUsd { monthly, yearly }`. It flows through the team selection (`UnifiedPricingTable`, `useSubscriptionDialog`, `usePricingTableUrlLoader`) into `CheckoutPlan.yearlyChargeUsd` (`useCheckoutCopy`, billing-web `teamCheckoutPlan`). - The three yearly-total surfaces show that value as is: the slider's "Billed yearly", `CheckoutSubscribeSummary`'s billed line, and `CheckoutSuccess`'s yearly price. - The hardcoded OSS / pre-deploy fallback stops have no server charge, so they keep 12× the monthly price. The per-month figure ($630) is unchanged. ## AS IS / TO BE | AS IS | TO BE | | --- | --- | | <img width="480" src="https://github.com/user-attachments/assets/a34866c9-d536-4fcf-b879-0f78fd0ae24f"> | <img width="480" src="https://github.com/user-attachments/assets/95e047a2-71f2-4461-b704-b155eb97229d"> | Local dev server on this branch against prod cloud.comfy.org, signed in to team workspace `test-team1` (no subscription), real `/api/billing/plans`; For Teams, Yearly, default 147.7K stop. AS IS swaps in `main`'s `CreditSlider.vue` only. ## Verification - New `CreditSlider` test "bills the yearly total the server charges, not 12x the monthly price" fails on the old component ("$7,560 Billed yearly") and passes here ("$7,560.01 Billed yearly"). - `catalog.test.ts` (mapping carries `periodChargeUsd`), `CheckoutSuccess.test.ts` (team stop shows `$7560.01`), billing-web `checkoutRequest.test.ts` (`yearlyChargeUsd: 7560.01` from a 756001¢ charge). - Vitest: app 4 files / 166 tests, account-ui 2 / 19, billing-web 15 / 690 pass. `pnpm typecheck`, `typecheck:billing-web`, `typecheck:account-ui`: 0 errors. ## Where this sits in the plan | Step | Item | Ticket / PR | Status | | --- | --- | --- | --- | | 1 | Plans API returns each stop's period charge | cloud#15376 | Merged | | 2 | Sync ingest types + billing fixtures | #21746 | Open | | 3 | **Show the server's yearly charge in pricing and checkout (this PR)** | FE-3587 | **This PR** | | 4 | Backport to core/cloud 1.58 | needs-backport | After merge | ```mermaid graph LR be["cloud 15376 period_charge_cents (merged)"] --> sync["PR 21746 ingest types sync"] sync --> fe["FE-3587 yearly charge in pricing (this PR)"] fe --> bp["backport core/cloud 1.58"] style fe stroke-width:3px ```
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-23T13:45:23.557Z",
"gitSha": "364c2f3b2fd8e86a885555616c2aa6de0ef43a9a",
"branch": "backport-21748-to-core-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2023.2760000000098,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.91,
"layouts": 9,
"layoutDurationMs": 2.9179999999999997,
"taskDurationMs": 438.65,
"heapDeltaBytes": 2382276,
"heapUsedBytes": 92590104,
"domNodes": -200,
"jsHeapTotalBytes": 1220608,
"scriptDurationMs": 10.231,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2055.327000000034,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.5140000000000002,
"layouts": 8,
"layoutDurationMs": 2.6279999999999997,
"taskDurationMs": 578.019,
"heapDeltaBytes": -1205752,
"heapUsedBytes": 89043300,
"domNodes": -200,
"jsHeapTotalBytes": 2007040,
"scriptDurationMs": 9.214,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406507,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1859.4919999999888,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.937,
"layouts": 10,
"layoutDurationMs": 2.9389999999999996,
"taskDurationMs": 985.46,
"heapDeltaBytes": -23820844,
"heapUsedBytes": 83206760,
"domNodes": -180,
"jsHeapTotalBytes": 3645440,
"scriptDurationMs": 166.65099999999998,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1889.4149999999854,
"styleRecalcs": 80,
"styleRecalcDurationMs": 13.45,
"layouts": 8,
"layoutDurationMs": 2.6020000000000003,
"taskDurationMs": 939.468,
"heapDeltaBytes": 4274496,
"heapUsedBytes": 94018656,
"domNodes": -180,
"jsHeapTotalBytes": 2793472,
"scriptDurationMs": 164.206,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.81517857142857,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1705.0649999999905,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.878,
"layouts": 11,
"layoutDurationMs": 2.6640000000000006,
"taskDurationMs": 406.44800000000004,
"heapDeltaBytes": 21556052,
"heapUsedBytes": 112394464,
"domNodes": 47,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 11.685,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1704.8989999999549,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.844,
"layouts": 11,
"layoutDurationMs": 2.808,
"taskDurationMs": 405.201,
"heapDeltaBytes": -1404172,
"heapUsedBytes": 89315320,
"domNodes": 47,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 10.971000000000002,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 686.8400000000179,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.753,
"layouts": 8,
"layoutDurationMs": 2.533,
"taskDurationMs": 501.65100000000007,
"heapDeltaBytes": 4210208,
"heapUsedBytes": 94300660,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 168.75400000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 621.0889999999836,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.087,
"layouts": 9,
"layoutDurationMs": 2.703,
"taskDurationMs": 446.84000000000003,
"heapDeltaBytes": 4141236,
"heapUsedBytes": 93943724,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 177.127,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864864,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1195.4089999999837,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 844.2839999999999,
"heapDeltaBytes": -4083612,
"heapUsedBytes": 102256472,
"domNodes": -230,
"jsHeapTotalBytes": 7585792,
"scriptDurationMs": 66.88299999999998,
"eventListeners": -168,
"totalBlockingTimeMs": 510,
"frameDurationMs": 32.432432432432435,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1197.1879999999828,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 854.986,
"heapDeltaBytes": -4377792,
"heapUsedBytes": 102259632,
"domNodes": -210,
"jsHeapTotalBytes": 8372224,
"scriptDurationMs": 79.905,
"eventListeners": -168,
"totalBlockingTimeMs": 523,
"frameDurationMs": 32.42972972972972,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 856.7859999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 498.06699999999984,
"heapDeltaBytes": -3534616,
"heapUsedBytes": 97974292,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 161.138,
"eventListeners": 0,
"totalBlockingTimeMs": 215,
"frameDurationMs": 24.997058823529454,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 861.6650000000163,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.69099999999975,
"heapDeltaBytes": -3558004,
"heapUsedBytes": 97677572,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 157.28300000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 209,
"frameDurationMs": 24.072222222222234,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11649.484999999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10736.014,
"heapDeltaBytes": 56668824,
"heapUsedBytes": 160308520,
"domNodes": -276,
"jsHeapTotalBytes": 45260800,
"scriptDurationMs": 8636.305,
"eventListeners": -130,
"totalBlockingTimeMs": 1446,
"frameDurationMs": 31.783879781420765,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10716.718000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9873.735,
"heapDeltaBytes": 59540460,
"heapUsedBytes": 163544052,
"domNodes": -276,
"jsHeapTotalBytes": 37396480,
"scriptDurationMs": 7929.580000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 985,
"frameDurationMs": 31.152034883720933,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10022.429999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9217.661999999998,
"heapDeltaBytes": 35674608,
"heapUsedBytes": 138656288,
"domNodes": -276,
"jsHeapTotalBytes": 24027136,
"scriptDurationMs": 7658.832,
"eventListeners": -130,
"totalBlockingTimeMs": 1072,
"frameDurationMs": 31.899044585987266,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9290.448999999968,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8484.942000000001,
"heapDeltaBytes": 1224844,
"heapUsedBytes": 121173792,
"domNodes": -296,
"jsHeapTotalBytes": -2383872,
"scriptDurationMs": 7075.563000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 708,
"frameDurationMs": 31.9,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 233.32600000000525,
"styleRecalcs": 22,
"styleRecalcDurationMs": 14.245000000000001,
"layouts": 11,
"layoutDurationMs": 3.266,
"taskDurationMs": 175.98699999999997,
"heapDeltaBytes": -3824428,
"heapUsedBytes": 101621612,
"domNodes": 917,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 8.438,
"eventListeners": 196,
"totalBlockingTimeMs": 3,
"frameDurationMs": 25.922222222222242,
"p95FrameDurationMs": 99.89999999999964
},
{
"name": "large-combo-open",
"durationMs": 211.61699999998973,
"styleRecalcs": 23,
"styleRecalcDurationMs": 15.248000000000001,
"layouts": 11,
"layoutDurationMs": 3.5229999999999997,
"taskDurationMs": 167.344,
"heapDeltaBytes": 13244584,
"heapUsedBytes": 120741004,
"domNodes": 917,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 9.678999999999998,
"eventListeners": 196,
"totalBlockingTimeMs": 2,
"frameDurationMs": 24.066666666666706,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2007.2589999999764,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.2430000000000003,
"layouts": 8,
"layoutDurationMs": 2.0460000000000003,
"taskDurationMs": 481.45899999999995,
"heapDeltaBytes": -20536252,
"heapUsedBytes": 100977240,
"domNodes": -276,
"jsHeapTotalBytes": -2871296,
"scriptDurationMs": 31.659,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2040.4839999999922,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.334,
"layouts": 8,
"layoutDurationMs": 2.095,
"taskDurationMs": 490.83199999999994,
"heapDeltaBytes": 790540,
"heapUsedBytes": 111533848,
"domNodes": -296,
"jsHeapTotalBytes": -1138688,
"scriptDurationMs": 31.313999999999993,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2346.363999999994,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.875000000000002,
"layouts": 8,
"layoutDurationMs": 2.3080000000000003,
"taskDurationMs": 1594.4670000000003,
"heapDeltaBytes": -8111724,
"heapUsedBytes": 114036900,
"domNodes": -296,
"jsHeapTotalBytes": 237568,
"scriptDurationMs": 882.598,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.7863309352518,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2276.034000000095,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.036000000000001,
"layouts": 7,
"layoutDurationMs": 2.1130000000000004,
"taskDurationMs": 1526.8329999999999,
"heapDeltaBytes": -2350940,
"heapUsedBytes": 109035712,
"domNodes": -296,
"jsHeapTotalBytes": 135168,
"scriptDurationMs": 828.246,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.914925373134324,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3901.395999999977,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.202,
"layouts": 64,
"layoutDurationMs": 10.578,
"taskDurationMs": 1866.0449999999998,
"heapDeltaBytes": -15015368,
"heapUsedBytes": 109425176,
"domNodes": -272,
"jsHeapTotalBytes": -643072,
"scriptDurationMs": 810.3389999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.737339055793992,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3599.783000000002,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.852,
"layouts": 64,
"layoutDurationMs": 10.666,
"taskDurationMs": 1632.4129999999998,
"heapDeltaBytes": -21712452,
"heapUsedBytes": 91575136,
"domNodes": -272,
"jsHeapTotalBytes": -483328,
"scriptDurationMs": 787.726,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.74325581395349,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2913.3370000000127,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.558000000000001,
"layouts": 5,
"layoutDurationMs": 1.1320000000000001,
"taskDurationMs": 1839.5159999999996,
"heapDeltaBytes": -11291640,
"heapUsedBytes": 103532392,
"domNodes": 0,
"jsHeapTotalBytes": 6295552,
"scriptDurationMs": 983.5360000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.858959537572257,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3024.7499999999263,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.52,
"layouts": 5,
"layoutDurationMs": 1.4879999999999998,
"taskDurationMs": 1847.733,
"heapDeltaBytes": -11028456,
"heapUsedBytes": 104059328,
"domNodes": 0,
"jsHeapTotalBytes": 6557696,
"scriptDurationMs": 1010.6569999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.852513966480448,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2056.762000000049,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.437,
"layouts": 7,
"layoutDurationMs": 2.286,
"taskDurationMs": 676.1689999999999,
"heapDeltaBytes": 346756,
"heapUsedBytes": 113264652,
"domNodes": -296,
"jsHeapTotalBytes": -614400,
"scriptDurationMs": 30.665000000000006,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2046.897999999942,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.791,
"layouts": 8,
"layoutDurationMs": 2.5500000000000003,
"taskDurationMs": 710.3729999999999,
"heapDeltaBytes": 935508,
"heapUsedBytes": 113366380,
"domNodes": -276,
"jsHeapTotalBytes": -1138688,
"scriptDurationMs": 32.980999999999995,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 583.4659999999872,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.1819999999999995,
"layouts": 9,
"layoutDurationMs": 2.6769999999999996,
"taskDurationMs": 389.62300000000005,
"heapDeltaBytes": 800448,
"heapUsedBytes": 91470320,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 150.621,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714277,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 595.6809999998995,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.491999999999999,
"layouts": 8,
"layoutDurationMs": 2.069,
"taskDurationMs": 438.02,
"heapDeltaBytes": -1046956,
"heapUsedBytes": 89824352,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 143.97199999999998,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2025.5559999999946,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.908,
"layouts": 9,
"layoutDurationMs": 2.448,
"taskDurationMs": 444.09700000000004,
"heapDeltaBytes": 12921760,
"heapUsedBytes": 103193412,
"domNodes": -198,
"jsHeapTotalBytes": 1744896,
"scriptDurationMs": 9.478,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2036.9010000000571,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.788,
"layouts": 9,
"layoutDurationMs": 2.641,
"taskDurationMs": 582.644,
"heapDeltaBytes": 760672,
"heapUsedBytes": 92035520,
"domNodes": -218,
"jsHeapTotalBytes": 1220608,
"scriptDurationMs": 8.079999999999998,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.427999999989,
"styleRecalcs": 77,
"styleRecalcDurationMs": 14.468000000000002,
"layouts": 9,
"layoutDurationMs": 2.621,
"taskDurationMs": 840.7,
"heapDeltaBytes": 19598980,
"heapUsedBytes": 112472928,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 110.764,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1725.3640000000132,
"styleRecalcs": 76,
"styleRecalcDurationMs": 13.647999999999998,
"layouts": 10,
"layoutDurationMs": 2.5120000000000005,
"taskDurationMs": 881.0970000000001,
"heapDeltaBytes": -2271864,
"heapUsedBytes": 88544492,
"domNodes": -210,
"jsHeapTotalBytes": 1744896,
"scriptDurationMs": 109.88099999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 983.4780000000478,
"styleRecalcs": 19,
"styleRecalcDurationMs": 26.533,
"layouts": 5,
"layoutDurationMs": 16.413999999999998,
"taskDurationMs": 806.093,
"heapDeltaBytes": 35401484,
"heapUsedBytes": 138518392,
"domNodes": 16030,
"jsHeapTotalBytes": 16392192,
"scriptDurationMs": 27.252000000000006,
"eventListeners": 3244,
"totalBlockingTimeMs": 165,
"frameDurationMs": 21.373913043478275,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 10751.030000000013,
"styleRecalcs": 249,
"styleRecalcDurationMs": 29.468999999999998,
"layouts": 7,
"layoutDurationMs": 1.8670000000000002,
"taskDurationMs": 6343.228,
"heapDeltaBytes": -19734976,
"heapUsedBytes": 90081096,
"domNodes": -276,
"jsHeapTotalBytes": -352256,
"scriptDurationMs": 2846.17,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.74385692068429,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9868.188999999915,
"styleRecalcs": 250,
"styleRecalcDurationMs": 28.887000000000004,
"layouts": 7,
"layoutDurationMs": 1.8739999999999999,
"taskDurationMs": 6043.045,
"heapDeltaBytes": 78707336,
"heapUsedBytes": 183518432,
"domNodes": -276,
"jsHeapTotalBytes": 63606784,
"scriptDurationMs": 2697.165,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.72258064516129,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16026.55100000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15122.387,
"heapDeltaBytes": -25972040,
"heapUsedBytes": 285008428,
"domNodes": -3344,
"jsHeapTotalBytes": 11784192,
"scriptDurationMs": 255.06099999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.3412265758092,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-large-graph-idle",
"durationMs": 22891.256999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22205.216,
"heapDeltaBytes": -43282120,
"heapUsedBytes": 286287780,
"domNodes": -3344,
"jsHeapTotalBytes": 14929920,
"scriptDurationMs": 335.24,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.38433734939759,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 27996.52100000003,
"styleRecalcs": 181,
"styleRecalcDurationMs": 19.261,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27574.912,
"heapDeltaBytes": -20478476,
"heapUsedBytes": 284103676,
"domNodes": -3344,
"jsHeapTotalBytes": 13619200,
"scriptDurationMs": 870.035,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 52.432397003745315,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 27691.070999999967,
"styleRecalcs": 181,
"styleRecalcDurationMs": 20.199999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27312.753,
"heapDeltaBytes": -30897932,
"heapUsedBytes": 274783748,
"domNodes": -3344,
"jsHeapTotalBytes": 11259904,
"scriptDurationMs": 889.721,
"eventListeners": -651,
"totalBlockingTimeMs": 6,
"frameDurationMs": 51.96791744840525,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 8279.291000000001,
"styleRecalcs": 20,
"styleRecalcDurationMs": 64.441,
"layouts": 20,
"layoutDurationMs": 23.938000000000002,
"taskDurationMs": 8171.154000000001,
"heapDeltaBytes": -33942904,
"heapUsedBytes": 290032784,
"domNodes": -3344,
"jsHeapTotalBytes": 12832768,
"scriptDurationMs": 130.123,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.331428571428575,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8284.344000000034,
"styleRecalcs": 20,
"styleRecalcDurationMs": 68.103,
"layouts": 20,
"layoutDurationMs": 23.517999999999983,
"taskDurationMs": 8140.522000000001,
"heapDeltaBytes": -62086368,
"heapUsedBytes": 261858120,
"domNodes": -3344,
"jsHeapTotalBytes": 7065600,
"scriptDurationMs": 121.366,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.06249999999999,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8010.490000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7514.783000000001,
"heapDeltaBytes": 111088,
"heapUsedBytes": 262182704,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 113.12499999999991,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.834722222222226,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11353.54499999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11013.12,
"heapDeltaBytes": 14842400,
"heapUsedBytes": 291722984,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 153.539,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.10424028268551,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "workflow-execution",
"durationMs": 501.0660000000371,
"styleRecalcs": 23,
"styleRecalcDurationMs": 12.060999999999998,
"layouts": 12,
"layoutDurationMs": 5.037,
"taskDurationMs": 144.58599999999998,
"heapDeltaBytes": 7394800,
"heapUsedBytes": 104817016,
"domNodes": 126,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 16.229,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 491.849000000002,
"styleRecalcs": 22,
"styleRecalcDurationMs": 11.05,
"layouts": 10,
"layoutDurationMs": 4.273,
"taskDurationMs": 132.266,
"heapDeltaBytes": 7009516,
"heapUsedBytes": 97591548,
"domNodes": 121,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.550999999999998,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668965517241396,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 430.8369999999968,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.941,
"layouts": 76,
"layoutDurationMs": 14.759,
"taskDurationMs": 392.72100000000006,
"heapDeltaBytes": -15269956,
"heapUsedBytes": 79122776,
"domNodes": 4,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 183.51500000000001,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 423.20299999994404,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.624,
"layouts": 76,
"layoutDurationMs": 13.668,
"taskDurationMs": 370.817,
"heapDeltaBytes": 11418256,
"heapUsedBytes": 80441912,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 179.347,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664000000000016,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 496.9849999999951,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.6540000000000001,
"layouts": 76,
"layoutDurationMs": 13.972999999999999,
"taskDurationMs": 465.47,
"heapDeltaBytes": 232672,
"heapUsedBytes": 115136256,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 184.32999999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 582.7249999999822,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.169,
"layouts": 76,
"layoutDurationMs": 14.35,
"taskDurationMs": 535.4490000000001,
"heapDeltaBytes": 1149588,
"heapUsedBytes": 121605368,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 225.77800000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E CoverageLine coverage: 64.0% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2954 passed, 0 failed · 4 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 8d34a7c1829f48fa3b8d30b9f3a9a1af86476619
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (114)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog 🌐 Website E2ETip All tests passed. Test results
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.58 #21804 +/- ##
=============================================
- Coverage 84.47% 84.03% -0.44%
=============================================
Files 2928 4091 +1163
Lines 160641 190799 +30158
Branches 39113 47700 +8587
=============================================
+ Hits 135694 160331 +24637
- Misses 24556 28334 +3778
- Partials 391 2134 +1743
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1175 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Approved: this backport is mechanically faithful to its merged source. The full exact-head check set is settled, the review thread set is empty, and no package manifest or export map changes.
Full context for agent readers
I compared the sorted additions and deletions with the merged source and inspected the resulting release-line diff. The behavior and verification remain intact.
Why
Backport of #21748 to core/1.58. Its prerequisite, the ingest-types sync #21746, landed on this branch via #21780.
How
Cherry-pick of 479cecf onto origin/core/1.58.
Conflicts: Clean cherry-pick.
AS IS / TO BE: see #21748.