Repository navigation
[backport core/1.58] feat(deploy): open installation deployment from the run bar - #21566
Conversation
## Summary On local ComfyUI and Desktop, a run-bar rocket opens the existing Deploy to Comfy API dialog in installation mode. Choosing Deploy on Platform uploads the local installation and opens the Platform build wizard with that bundle. The graph-menu entry keeps its existing plain Platform link. Closes DES-1266. Frontend work for [DPLAT-3048](https://linear.app/comfyorg/issue/DPLAT-3048), following the [Deploy to Cloud API contract](https://linear.app/comfyorg/document/api-contract-087dc1c667ee). - The button renders the single server-owned `deploy_to_cloud` capability. It does not combine that flag with another server fact, remote configuration, or a PostHog flag. Until the server supplies it, the button stays hidden. - `POST /api/deploy/bundle` sends the open workflow (UI format, flushed from the canvas at the click) as `workflow`, so the build wizard pre-selects the models it uses; with no workflow open the body is `{}`. If the server answers `too_large` with a workflow attached, the upload is retried once without it, as the contract prescribes. Its request body type, full success-response validator, and error contract come from `@comfyorg/ingest-types`. The UI error mapping is exhaustive against the generated error union. The generated response validator retains the frontend's HTTPS-only destination check; incomplete or malformed responses are reported and open no wizard link. - Credentials follow the existing local-run rule: use the workspace token; use the stored API key only while signed out. Missing credentials open sign-in, and a signed-in account without its workspace token gets the sign-in-again message. - When the upload finishes, Deploy on Platform turns into an Open the build wizard link; the frontend never calls `window.open`. The upload usually outlasts the browser's popup allowance, so an automatic tab was blocked almost every time anyway, and on Desktop the link goes through the same system-browser handler. Following the link (click or middle-click, not right-click) closes the dialog. The upload state belongs to the button, so closing the dialog mid-upload abandons that upload and a reopened dialog offers a fresh one. A credential found for one account is dropped, before and after the upload, if another account is current by then, so no link appears for another account's bundle. If the sign-in prompt itself fails to open, the dialog shows Could not reach Comfy, reports it once, and the next click tries again. Same-account token refresh and signing in from the deployment prompt still work; the owner identity never enters the public state or telemetry. - Known API errors use translated messages and retain the existing reporting policy. A bundle refused by the builder shows the existing upload-rejected message instead of claiming Comfy could not be reached. Unknown response bodies fall back on HTTP status; plain-text 413 responses still mean the bundle is too large. The server's response body remains the reporting cause. - Existing click telemetry records rocket clicks, deployment clicks, and wizard openings. Local frontend events use Desktop v2's host sink when telemetry is enabled; plain pip/portable installs send none. ### Dependencies - Generated-types dependency [#21351](#21351) is merged. It supplies the TypeScript types and Zod validators from Cloud's shared API schema. Native stack #21425 retains that merged parent; this feature now targets `main` and imports the generated output without editing or copying it. - [Core #17203](Comfy-Org/ComfyUI#17203) implements the local deploy endpoints and computes the capability flag. It is still open. This PR does not wait for it: the rocket renders only when the server sends `deploy_to_cloud` (default false), so on any ComfyUI without that change, including the core/1.56-1.58 backport targets, the button stays hidden and `/api/deploy/bundle` is never called. - [Cloud #14034](Comfy-Org/cloud#14034), which stores import bundles and declares the shared API schema, and [Platform #1414](Comfy-Org/platform#1414), which prefills the build wizard, are merged. Their deployment and the complete upload-to-wizard flow have not been verified here. - Disclosure copy is not a merge hold: installation mode keeps the current workflow-oriented copy and summary for now, while the upload also includes the installation's custom-node repositories, pip packages, model filenames, and install name. Installation-wide counts from the generated `GET /api/deploy/summary` contract are a possible follow-up. - ComfyUI currently sends feature flags at WebSocket handshake. If headless use enables deployment mid-session, the button appears after a reload or reconnect. ## Verification - `pnpm test:unit src/platform/workflow/deploy src/components/TopMenuSection.test.ts --retry=0`: **135 tests passed across 6 files**. Covers the server flag, upload credentials and request, the open workflow in the request body (as flushed from the canvas), the retry without it on `too_large` and no retry on other failures, the build wizard link once the bundle is ready, error messages, HTTPS restriction, malformed success-response refusal, credentials and upload results that arrive after an account switch, signing in from the deployment prompt, a sign-in prompt that fails to open, and click, middle-click and right-click on the link. Removing either account check, or taking the owner before the sign-in prompt, fails a test. - The new incomplete-response case failed against the handwritten validator (22 existing cases passed), then passed after adopting the generated validator. A separate regression test first reproduced the misleading builder-rejected message, then passed with the corrected mapping. Success and known-error fixtures are checked against the generated types and use a valid bundle UUID. - `pnpm lint:unstaged:fix` passed. The normal commit hook passed formatting, type-aware lint, server-fact lint, app typecheck, unused-translation checks, and frozen-directory checks. - Normal pre-push dependency analysis, unused-code checks, and changed-file audits passed. - Claude review of `99edf6d4cc` found no blocking code issues. Its one optional error-message correction is included with a regression test; this small mapping fix does not require another review round. Claude review round 2 at `274969b9fd` found no blocking code issues in the account-bound state fix. The generated-types parent is already merged. - Preserved all 14 existing feature commits through base updates, with no manual conflict resolution. The account-bound state fix changes only the deployment composable and its tests. Seven new regression cases failed before the fix and pass afterward; the same-account refresh and sign-in cases also pass. The feature diff contains no generated-package changes; fresh CI must complete on the new head. - A live staging upload passed the UUID/timestamp validators and opened the prefilled wizard (see How to QA). A Desktop session is still unverified. ### How to QA before core #17203 merges Core #17203 does not need to merge for QA; its branch runs as is. 1. Run ComfyUI from `jacob/dplat-3049-3050-deploy-to-cloud` with `--comfy-api-base https://stagingapi.comfy.org`. `/api/features` then sends the staging API and platform URLs and `firebase_env: dev`, so sign-in and the builder both use staging. 2. Run this branch with `VITE_STAGING_CLOUD_BASE_URL=https://stagingcloud.comfy.org pnpm dev` against it. On local ComfyUI the workspace token comes from the cloud base URL, which core's staging override does not set (already true on core master), and a dev build otherwise uses `testcloud.comfy.org`. The upload then lands in a test-cloud workspace that staging Platform does not have, and the wizard asks to switch to a workspace you cannot pick. 3. Queue one prompt without a `client_id`, as a script would, e.g. `EmptyImage` into `SaveImage` via `curl -X POST localhost:8188/api/prompt`. `deploy_to_cloud` turns true and stays true (marker file `user/used_headlessly`). Reload the page; the server only sends flags when the WebSocket connects. 4. Click the run-bar rocket, then Deploy on Platform, sign in with a staging account, and confirm the wizard (or the Open the build wizard link) lands on `stagingplatform.comfy.org/profile/builds/new?step=import&bundle=…` with the bundle prefilled. Close and reopen the rocket: it offers a fresh Deploy on Platform. Checked live on 2026-10-20 (core `7b97412` against the staging builder, this branch at `58cfdc4b7a`, staging sign-in): - The flag is false before the headless prompt and true after; the rocket then appears and opens the dialog in installation mode. - Signed out, Deploy on Platform opens sign-in and uploads nothing. Signing in from that prompt continues the upload. - The staging builder stored the bundle and core returned `{url, bundle_id, workspace_id, expires_at}` (a UUIDv7 id, a `w-…` workspace id, expiry 24 h out). It passed the generated validator and the HTTPS check. - The browser blocked the new tab both times (before c24a77e made the link the only path), so the dialog showed Open the build wizard with the `stagingplatform.comfy.org/profile/builds/new?step=import&bundle=…&workspace=…` URL. Following the link closed the dialog; a reopened dialog offered a fresh upload. - Closing the dialog without following the link, then reopening, showed Deploy on Platform and no old link (the 58cfdc4 fix). - A signed-in upload of this small install took under 5 s. - With the staging cloud base URL, the bundle landed in the same Personal Workspace that staging Platform uses. After Platform's own sign-in (it returned to the wizard URL), the wizard opened with the Desktop snapshot loaded: ComfyUI `v0.42.0` from the snapshot instead of the default latest stable, and 72 Python packages pinned. No build was started. Not checked: a Desktop session, an installation with custom nodes and models, and a staging upload that carries the workflow (the live run above predates it and sent `{}`). ### Risk and rollback Switching accounts during a request silently discards the result; a server-side bundle may still have been created for the original account. A link that is already showing stays if the account changes in another tab while the dialog is open; the builder must still enforce bundle access. Closing the dialog during an upload abandons it; the unused bundle counts toward the builder's limit until it expires. Full generated validation rejects a response with missing or malformed bundle metadata that the previous URL-only validator accepted. That failure is reported and leaves the dialog open; it cannot undo a bundle already stored by the server. Revert this PR to remove the feature; it introduces no migration or persisted setting. ### Decisions made without Ben - Used the generated-types PR as the native stack parent, preserving the bot's ownership of its generated branch. This keeps generation out of the feature's handwritten diff. - Kept the generated full-response validator with the existing HTTPS restriction. A URL-only projection would accept incomplete responses and conceal schema drift. - Reused `authStore.currentUserIdentity()` for the account check rather than adding a global authentication watcher. Identity binding is private, including on the API-key path. This authentication-adjacent change needs Ben's review; it does not change how credentials are minted or selected. | Existing run-bar screenshot | Existing dialog screenshot | | --- | --- | |  |  | --------- Co-authored-by: Benjamin Lu <benjaminlu1107@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Alexander Brown <drjkl@comfy.org>
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-26T18:12:48.146Z",
"gitSha": "1b02b93f15c9140ee89c6782641849bb7db3422a",
"branch": "backport-21202-to-core-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2024.9310000000094,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.2560000000000002,
"layouts": 10,
"layoutDurationMs": 2.033,
"taskDurationMs": 364.99,
"heapDeltaBytes": 31640,
"heapUsedBytes": 90751384,
"domNodes": -200,
"jsHeapTotalBytes": 843776,
"scriptDurationMs": 7.672999999999997,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-idle",
"durationMs": 2026.1849999999981,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.077,
"layouts": 9,
"layoutDurationMs": 2.434,
"taskDurationMs": 427.11999999999995,
"heapDeltaBytes": 602176,
"heapUsedBytes": 90794928,
"domNodes": -200,
"jsHeapTotalBytes": 581632,
"scriptDurationMs": 9.809999999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1695.5070000000205,
"styleRecalcs": 72,
"styleRecalcDurationMs": 12.818000000000001,
"layouts": 9,
"layoutDurationMs": 2.173,
"taskDurationMs": 518.867,
"heapDeltaBytes": 686088,
"heapUsedBytes": 90872060,
"domNodes": -200,
"jsHeapTotalBytes": 2940928,
"scriptDurationMs": 102.822,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1694.1910000000462,
"styleRecalcs": 71,
"styleRecalcDurationMs": 12.407,
"layouts": 9,
"layoutDurationMs": 2.269,
"taskDurationMs": 627.097,
"heapDeltaBytes": -19613252,
"heapUsedBytes": 85078484,
"domNodes": -200,
"jsHeapTotalBytes": 2953216,
"scriptDurationMs": 110.901,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1710.0529999999878,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.693000000000001,
"layouts": 12,
"layoutDurationMs": 2.7019999999999995,
"taskDurationMs": 253.011,
"heapDeltaBytes": 3440940,
"heapUsedBytes": 104081276,
"domNodes": 47,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 8.715999999999998,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.116999999992,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.025999999999999,
"layouts": 12,
"layoutDurationMs": 2.915,
"taskDurationMs": 274.449,
"heapDeltaBytes": 1670880,
"heapUsedBytes": 106560176,
"domNodes": 47,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 11.871,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262138,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 514.7069999999871,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.2279999999999993,
"layouts": 10,
"layoutDurationMs": 2.618,
"taskDurationMs": 335.408,
"heapDeltaBytes": 9335680,
"heapUsedBytes": 113089764,
"domNodes": 0,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 111.003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664516129032254,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 465.0289999999586,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.774,
"layouts": 9,
"layoutDurationMs": 2.255,
"taskDurationMs": 315.86199999999997,
"heapDeltaBytes": 4223748,
"heapUsedBytes": 94479956,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 106.506,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428571,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 925.9059999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 553.6959999999999,
"heapDeltaBytes": -4252836,
"heapUsedBytes": 102342828,
"domNodes": -230,
"jsHeapTotalBytes": 8298496,
"scriptDurationMs": 35.238,
"eventListeners": -168,
"totalBlockingTimeMs": 280,
"frameDurationMs": 25.925000000000004,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 909.5810000000029,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 503.62300000000005,
"heapDeltaBytes": 10344564,
"heapUsedBytes": 129451592,
"domNodes": -170,
"jsHeapTotalBytes": 16736256,
"scriptDurationMs": 33.495999999999995,
"eventListeners": -168,
"totalBlockingTimeMs": 296,
"frameDurationMs": 27.775757575757574,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 701.3929999999959,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 277.1279999999998,
"heapDeltaBytes": -4907980,
"heapUsedBytes": 96651712,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 89.93,
"eventListeners": 0,
"totalBlockingTimeMs": 91,
"frameDurationMs": 20.58823529411765,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 672.9579999999942,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 250.78600000000017,
"heapDeltaBytes": -4478180,
"heapUsedBytes": 96958316,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 87.84400000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 83,
"frameDurationMs": 20.709090909090897,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6846.617000000009,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.647,
"layouts": 3,
"layoutDurationMs": 0.7360000000000001,
"taskDurationMs": 5846.389,
"heapDeltaBytes": 44658328,
"heapUsedBytes": 160095076,
"domNodes": -297,
"jsHeapTotalBytes": 44978176,
"scriptDurationMs": 4386.161,
"eventListeners": -130,
"totalBlockingTimeMs": 55,
"frameDurationMs": 20.96042944785276,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6436.344000000019,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.0040000000000004,
"layouts": 4,
"layoutDurationMs": 0.8939999999999998,
"taskDurationMs": 5331.996,
"heapDeltaBytes": 17587296,
"heapUsedBytes": 125991140,
"domNodes": -297,
"jsHeapTotalBytes": 24698880,
"scriptDurationMs": 3991.981,
"eventListeners": -130,
"totalBlockingTimeMs": 22,
"frameDurationMs": 18.75539358600583,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6472.7060000000165,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8310000000000002,
"layouts": 3,
"layoutDurationMs": 0.7949999999999997,
"taskDurationMs": 5532.702,
"heapDeltaBytes": 7593780,
"heapUsedBytes": 130328932,
"domNodes": -296,
"jsHeapTotalBytes": 32313344,
"scriptDurationMs": 4293.522,
"eventListeners": -130,
"totalBlockingTimeMs": 30,
"frameDurationMs": 22.35551724137931,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6353.4570000000485,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8549999999999999,
"layouts": 3,
"layoutDurationMs": 0.7139999999999997,
"taskDurationMs": 5297.339,
"heapDeltaBytes": 19931344,
"heapUsedBytes": 125470860,
"domNodes": -296,
"jsHeapTotalBytes": 24530944,
"scriptDurationMs": 3947.364,
"eventListeners": -130,
"totalBlockingTimeMs": 47,
"frameDurationMs": 18.786094674556214,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "large-combo-open",
"durationMs": 147.82399999998574,
"styleRecalcs": 22,
"styleRecalcDurationMs": 11.545,
"layouts": 13,
"layoutDurationMs": 3.114,
"taskDurationMs": 101.381,
"heapDeltaBytes": 13276940,
"heapUsedBytes": 120868032,
"domNodes": 917,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 6.285,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.042857142857105,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "large-combo-open",
"durationMs": 135.22499999999127,
"styleRecalcs": 21,
"styleRecalcDurationMs": 11.001999999999999,
"layouts": 12,
"layoutDurationMs": 2.91,
"taskDurationMs": 100.73400000000001,
"heapDeltaBytes": 13313012,
"heapUsedBytes": 118271104,
"domNodes": 917,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.916,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.73750000000001,
"p95FrameDurationMs": 33.29999999999973
},
{
"name": "large-graph-idle",
"durationMs": 2042.5690000000145,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.8590000000000004,
"layouts": 9,
"layoutDurationMs": 1.615,
"taskDurationMs": 407.773,
"heapDeltaBytes": -413316,
"heapUsedBytes": 102174704,
"domNodes": -296,
"jsHeapTotalBytes": -2289664,
"scriptDurationMs": 25.061,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2028.5959999999932,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.8510000000000004,
"layouts": 10,
"layoutDurationMs": 2.5569999999999995,
"taskDurationMs": 347.631,
"heapDeltaBytes": 211472,
"heapUsedBytes": 110294716,
"domNodes": -296,
"jsHeapTotalBytes": -1253376,
"scriptDurationMs": 28.774000000000008,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-pan",
"durationMs": 2134.469999999993,
"styleRecalcs": 70,
"styleRecalcDurationMs": 14.239,
"layouts": 9,
"layoutDurationMs": 2.27,
"taskDurationMs": 1089.7079999999999,
"heapDeltaBytes": 1544180,
"heapUsedBytes": 112708852,
"domNodes": -297,
"jsHeapTotalBytes": -503808,
"scriptDurationMs": 565.48,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666141732283467,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2467.4400000000105,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.789,
"layouts": 8,
"layoutDurationMs": 1.97,
"taskDurationMs": 1201.4769999999999,
"heapDeltaBytes": 1411764,
"heapUsedBytes": 113280184,
"domNodes": -296,
"jsHeapTotalBytes": -503808,
"scriptDurationMs": 578.193,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66554054054054,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3555.878000000007,
"styleRecalcs": 73,
"styleRecalcDurationMs": 11.765,
"layouts": 66,
"layoutDurationMs": 12.114999999999998,
"taskDurationMs": 1316.128,
"heapDeltaBytes": -13982360,
"heapUsedBytes": 91136820,
"domNodes": -272,
"jsHeapTotalBytes": -1634304,
"scriptDurationMs": 555.325,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66588785046729,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3139.361000000008,
"styleRecalcs": 73,
"styleRecalcDurationMs": 11.548,
"layouts": 67,
"layoutDurationMs": 11.777,
"taskDurationMs": 1087.8220000000001,
"heapDeltaBytes": 7100076,
"heapUsedBytes": 119709288,
"domNodes": 24,
"jsHeapTotalBytes": 5509120,
"scriptDurationMs": 517.904,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666137566137564,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2443.7420000000147,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.26,
"layouts": 7,
"layoutDurationMs": 1.6549999999999998,
"taskDurationMs": 1343.9470000000001,
"heapDeltaBytes": 20898980,
"heapUsedBytes": 128066228,
"domNodes": 0,
"jsHeapTotalBytes": 5664768,
"scriptDurationMs": 677.8290000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66598639455782,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "legacy-node-drag",
"durationMs": 2603.609000000006,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.082,
"layouts": 8,
"layoutDurationMs": 1.8219999999999998,
"taskDurationMs": 1330.981,
"heapDeltaBytes": 20509404,
"heapUsedBytes": 127214224,
"domNodes": 0,
"jsHeapTotalBytes": 5664768,
"scriptDurationMs": 644.1569999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666025641025637,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2021.682999999996,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.0359999999999996,
"layouts": 8,
"layoutDurationMs": 1.8179999999999998,
"taskDurationMs": 425.63100000000003,
"heapDeltaBytes": -590376,
"heapUsedBytes": 103864148,
"domNodes": -296,
"jsHeapTotalBytes": -2551808,
"scriptDurationMs": 26.444000000000003,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-idle",
"durationMs": 2038.129999999967,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.79,
"layouts": 9,
"layoutDurationMs": 2.466,
"taskDurationMs": 439.87,
"heapDeltaBytes": -28522152,
"heapUsedBytes": 89539236,
"domNodes": -276,
"jsHeapTotalBytes": -1310720,
"scriptDurationMs": 27.715999999999998,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 414.8020000000088,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.469999999999999,
"layouts": 9,
"layoutDurationMs": 2.253,
"taskDurationMs": 264.783,
"heapDeltaBytes": -1097764,
"heapUsedBytes": 89763404,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 99.356,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.672000000000008,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 445.3399999999874,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.414999999999999,
"layouts": 11,
"layoutDurationMs": 2.7779999999999996,
"taskDurationMs": 304.264,
"heapDeltaBytes": 2756036,
"heapUsedBytes": 109407140,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 96.248,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2026.5100000000018,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.5179999999999993,
"layouts": 11,
"layoutDurationMs": 2.3049999999999997,
"taskDurationMs": 367.703,
"heapDeltaBytes": -15574544,
"heapUsedBytes": 91266068,
"domNodes": -198,
"jsHeapTotalBytes": 2428928,
"scriptDurationMs": 6.697,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2008.3479999999554,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.952000000000001,
"layouts": 10,
"layoutDurationMs": 2.521,
"taskDurationMs": 382.281,
"heapDeltaBytes": -11572068,
"heapUsedBytes": 80177388,
"domNodes": -219,
"jsHeapTotalBytes": -3678208,
"scriptDurationMs": 8.058,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.1659999999908,
"styleRecalcs": 75,
"styleRecalcDurationMs": 12.27,
"layouts": 10,
"layoutDurationMs": 2.1539999999999995,
"taskDurationMs": 519.5260000000001,
"heapDeltaBytes": -1540936,
"heapUsedBytes": 90217784,
"domNodes": -210,
"jsHeapTotalBytes": 3465216,
"scriptDurationMs": 84.733,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.3850000000152,
"styleRecalcs": 76,
"styleRecalcDurationMs": 13.998999999999999,
"layouts": 9,
"layoutDurationMs": 2.114,
"taskDurationMs": 617.824,
"heapDeltaBytes": -4800032,
"heapUsedBytes": 86583600,
"domNodes": -210,
"jsHeapTotalBytes": 2322432,
"scriptDurationMs": 87.986,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-transition-enter",
"durationMs": 851.7650000000003,
"styleRecalcs": 20,
"styleRecalcDurationMs": 15.911999999999995,
"layouts": 5,
"layoutDurationMs": 9.344999999999999,
"taskDurationMs": 642.0310000000001,
"heapDeltaBytes": 16377656,
"heapUsedBytes": 137359248,
"domNodes": 16030,
"jsHeapTotalBytes": 16916480,
"scriptDurationMs": 18.762999999999995,
"eventListeners": 3244,
"totalBlockingTimeMs": 67,
"frameDurationMs": 19.318181818181817,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8152.76799999998,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.941,
"layouts": 9,
"layoutDurationMs": 2.339,
"taskDurationMs": 3684.183,
"heapDeltaBytes": 2978592,
"heapUsedBytes": 113320328,
"domNodes": -296,
"jsHeapTotalBytes": -241664,
"scriptDurationMs": 1875.9139999999998,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666053169734152,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9791.717000000006,
"styleRecalcs": 251,
"styleRecalcDurationMs": 37.649,
"layouts": 10,
"layoutDurationMs": 2.698,
"taskDurationMs": 4593.905000000001,
"heapDeltaBytes": -16800304,
"heapUsedBytes": 100285536,
"domNodes": -297,
"jsHeapTotalBytes": 880640,
"scriptDurationMs": 2190.698,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665986394557823,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16315.228000000046,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15284.568,
"heapDeltaBytes": -25340108,
"heapUsedBytes": 280965632,
"domNodes": -3344,
"jsHeapTotalBytes": 28037120,
"scriptDurationMs": 211.466,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.179620034542317,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-idle",
"durationMs": 12475.782999999978,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11496.506,
"heapDeltaBytes": -37897316,
"heapUsedBytes": 291590768,
"domNodes": -307,
"jsHeapTotalBytes": 29085696,
"scriptDurationMs": 170.68599999999998,
"eventListeners": -7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.23696763202726,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "vue-large-graph-pan",
"durationMs": 18492.502,
"styleRecalcs": 142,
"styleRecalcDurationMs": 16.573000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18081.21,
"heapDeltaBytes": -22689640,
"heapUsedBytes": 288418672,
"domNodes": -3344,
"jsHeapTotalBytes": 15716352,
"scriptDurationMs": 643.995,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.194454713493535,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 14522.203000000047,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.24900000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14027.458,
"heapDeltaBytes": 8045692,
"heapUsedBytes": 309204284,
"domNodes": -3344,
"jsHeapTotalBytes": 14860288,
"scriptDurationMs": 619.4159999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 39,
"frameDurationMs": 25.48242530755712,
"p95FrameDurationMs": 50
},
{
"name": "vue-node-resize-workload",
"durationMs": 5815.741000000003,
"styleRecalcs": 20,
"styleRecalcDurationMs": 41.86100000000001,
"layouts": 20,
"layoutDurationMs": 22.788000000000004,
"taskDurationMs": 5689.090999999999,
"heapDeltaBytes": -25495168,
"heapUsedBytes": 299294472,
"domNodes": -3344,
"jsHeapTotalBytes": 24895488,
"scriptDurationMs": 78.70699999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.01403508771929,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5771.736000000033,
"styleRecalcs": 20,
"styleRecalcDurationMs": 42.551,
"layouts": 20,
"layoutDurationMs": 22.134,
"taskDurationMs": 5685.771000000001,
"heapDeltaBytes": -47437764,
"heapUsedBytes": 285092128,
"domNodes": -3344,
"jsHeapTotalBytes": 25677824,
"scriptDurationMs": 83.611,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.24875,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8196.913999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7691.622,
"heapDeltaBytes": -5705800,
"heapUsedBytes": 275581748,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 106.32199999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.372664359861595,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6139.093000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5688.370000000001,
"heapDeltaBytes": -23054824,
"heapUsedBytes": 287755768,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 79.285,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.719932432432433,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "workflow-execution",
"durationMs": 439.1430000000014,
"styleRecalcs": 17,
"styleRecalcDurationMs": 9.756,
"layouts": 13,
"layoutDurationMs": 3.9569999999999994,
"taskDurationMs": 108.543,
"heapDeltaBytes": -12362748,
"heapUsedBytes": 89417808,
"domNodes": 126,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.623000000000001,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 93.41700000004494,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.376000000000001,
"layouts": 8,
"layoutDurationMs": 2.6819999999999995,
"taskDurationMs": 60.49700000000001,
"heapDeltaBytes": 4677976,
"heapUsedBytes": 101694896,
"domNodes": 117,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 4.727,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.68333333333332,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 207.37500000007003,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.612,
"layouts": 76,
"layoutDurationMs": 10.824,
"taskDurationMs": 173.03199999999998,
"heapDeltaBytes": 9471328,
"heapUsedBytes": 97745236,
"domNodes": 4,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 72.45,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669230769230754,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 241.50799999995343,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.607,
"layouts": 76,
"layoutDurationMs": 10.856,
"taskDurationMs": 199.78,
"heapDeltaBytes": 9742716,
"heapUsedBytes": 97897280,
"domNodes": 4,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 86.27600000000001,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 246.88900000001013,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.385,
"layouts": 76,
"layoutDurationMs": 10.14,
"taskDurationMs": 209.144,
"heapDeltaBytes": -2125968,
"heapUsedBytes": 114547472,
"domNodes": 4,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 68.636,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.67333333333333,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 265.81800000008116,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.4809999999999999,
"layouts": 76,
"layoutDurationMs": 10.741999999999999,
"taskDurationMs": 229.794,
"heapDeltaBytes": -1906960,
"heapUsedBytes": 114899088,
"domNodes": 4,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 75.95299999999999,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.67058823529415,
"p95FrameDurationMs": 16.800000000000182
}
]
}🎭 Playwright: ✅ 2968 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since a5b2f83eda2ee11caa0c5e35879a08fdc5bc3c0f
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (116)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## core/1.58 #21566 +/- ##
============================================
Coverage 84.49% 84.50%
============================================
Files 2931 2934 +3
Lines 160945 161073 +128
Branches 41406 39242 -2164
============================================
+ Hits 135991 136111 +120
- Misses 24563 24571 +8
Partials 391 391
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #21202 to
core/1.58Automatically created by backport workflow.