Repository navigation
fix: use one overlay tier with reopen-aware portal ordering - #21396
Conversation
📦 Bundle: 11.6 MB gzip 🟢 -1.67 kBDetailsSummary
Category Glance App Entry Points — 6.84 kB (baseline 6.91 kB) • 🟢 -73 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 3.41 MB (baseline 3.41 MB) • 🟢 -258 BGraph editor runtime, canvas, workflow orchestration
Status: 3 added / 3 removed / 1 unchanged Views & Navigation — 147 kB (baseline 147 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 16 added / 16 removed / 2 unchanged Panels & Settings — 834 kB (baseline 834 kB) • 🟢 -465 BConfiguration panels, inspectors, and settings screens
Status: 19 added / 19 removed / 16 unchanged User & Accounts — 156 kB (baseline 156 kB) • 🟢 -48 BAuthentication, profile, and account management bundles
Status: 11 added / 11 removed / 6 unchanged Editors & Dialogs — 375 kB (baseline 375 kB) • 🟢 -125 BModals, dialogs, drawers, and in-app editors
Status: 13 added / 13 removed / 1 unchanged UI Components — 223 kB (baseline 224 kB) • 🟢 -755 BReusable component library chunks
Status: 29 added / 29 removed / 1 unchanged Data & Services — 1.21 MB (baseline 1.21 MB) • 🟢 -388 BStores, services, APIs, and repositories
Status: 37 added / 37 removed / 6 unchanged Utilities & Hooks — 1.01 MB (baseline 1.01 MB) • 🟢 -1.58 kBHelpers, composables, and utility bundles
Status: 50 added / 51 removed / 25 unchanged Vendor & Third-Party — 24.7 MB (baseline 24.7 MB) • 🔴 +926 BExternal libraries and shared vendor chunks
Status: 3 added / 3 removed / 14 unchanged Other — 20.6 MB (baseline 20.6 MB) • 🟢 -1.89 kBBundles that do not match a named category
Status: 473 added / 474 removed / 212 unchanged ⚡ Performance
🎭 Playwright: ✅ 2970 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsFallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (97 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 1b12af4350f8652a9b2a43ef4d736bf23991f1c5
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (117)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog 🌐 Website E2ETip All tests passed. Test results
🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-21396.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. Deployment detailsThis commit: https://website-frontend-dmaaqze7l-comfyui.vercel.app Last updated: 2026-10-20T20:55:24Z for |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #21396 +/- ##
==========================================
- Coverage 86.54% 86.44% -0.10%
==========================================
Files 3887 3887
Lines 180737 180068 -669
Branches 49995 49977 -18
==========================================
- Hits 156412 155665 -747
+ Misses 22060 22023 -37
- Partials 2265 2380 +115
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 161 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Keep a stable panel for each tab so Reka registers the correct associations. Query visible tooltip text and notification list items without restoring obsolete roles. Wait for the search modal to unmount before placing nodes, and let Reka own overlay pointer blocking. Amp-Thread-ID: https://ampcode.com/threads/T-01a15660-3f9b-772f-895f-88413d1a549c
dante01yoon
left a comment
There was a problem hiding this comment.
Requesting changes on 5fe3d7f11ad7aee5cb052210df4693f43b01be6f: the newly completed Cloud CI exposed a nested-dialog path missed by my earlier sibling-dialog checks. The exact-head Chromium reproduction below confirms the pointer interception and a child-unmount control restores the click. This supersedes my earlier approval (#21396 (review)). Previous unit/build/type checks and sibling-dialog browser checks do not cover this failure.
| <DialogPortal :key="openCount" v-bind="props"> | ||
| <div | ||
| ref="portalTarget" | ||
| class="pointer-events-none fixed inset-0 z-overlay *:pointer-events-auto" |
There was a problem hiding this comment.
issue: [P1] A closed nested dialog now blocks clicks on its parent. The wrapper is always mounted, and the parent's *:pointer-events-auto rule overrides the nested wrapper's pointer-events-none. Because the closed child has no content/overlay, its empty fullscreen wrapper becomes an invisible hit target above the parent's controls. SecretsPanel always mounts its closed create/edit SecretFormDialogs inside the settings dialog, so even the first Add Secret click cannot get through.
I reproduced this in Chromium with the actual components at 5fe3d7f: an open parent containing a mounted open=false child gets zero button clicks; elementFromPoint returns the empty child wrapper with computed pointer-events: auto. Unmounting only that closed child makes the same button receive the click; remounting it blocks the hit again. This is a controlled component reproduction, not a production-account check. CI independently reports this exact wrapper intercepting Add Secret and Import Model Continue clicks: https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39491152445/job/118868772205 and https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39491152445/job/118868772238.
Please keep empty nested portal wrappers transparent to pointer input and add a real-browser regression for a parent with an initially closed nested dialog, while retaining the exit-animation and reopen-ordering guarantees.
There was a problem hiding this comment.
Fixed in 442e0f4: the portal wrapper now carries empty:hidden, so a closed nested dialog leaves no hit target above its parent. Reopen ordering and the exit animation are unchanged, because the wrapper still has content while a dialog is open or animating out. The existing real-browser specs already cover the nested case: cloudSecrets.spec.ts (closed SecretFormDialogs mounted inside the settings dialog) failed 3/3 locally at 5fe3d7f with this wrapper intercepting Add Secret, and passes 3/3 with the fix, so I did not add a duplicate spec. The Import Model and node search filter failures in the same CI run show the same interception and should clear on the new head.
A closed dialog nested in an open one left an empty fullscreen portal wrapper that inherited pointer-events-auto from the parent wrapper and swallowed clicks on the parent's controls. Hide the wrapper while empty. Amp-Thread-ID: https://ampcode.com/threads/T-8b6a21e8-f50d-402b-aae3-c07a29537981
|
Fixed in 442e0f4: closed nested dialog portals no longer block clicks on the parent dialog (inline thread r4330154719, CHANGES_REQUESTED review). Covers the cloud shard 2/4 and 4/4 and chromium shard 7/16 and 8/16 failures, which all show the empty portal wrapper intercepting pointer events. |
dante01yoon
left a comment
There was a problem hiding this comment.
Verified the nested-portal fix at 442e0f4249d9ff01a59c055231f455e38496be15. empty:hidden removes the empty closed child's hit target while leaving nonempty opening/closing content mounted. My P1 finding (#21396 (comment)) is addressed; no new blocking finding in this one-line delta. The existing Cloud Secrets browser tests already exercise the real nested consumer, so a duplicate spec is unnecessary.
Own exact-head validation:
- PASS: fresh frozen dependency install; 4 DialogPortal tests; app typecheck and production build; touched-component type-aware Oxlint, format and ESLint.
- PASS: all 3 existing
cloudSecrets.spec.tsbrowser tests, including add/list/delete, nested backdrop dismissal and an empty provider allowlist. These ran against the exact-head local Cloud frontend with mocked Cloud endpoints; they are not production-account checks. Initial setup was blocked by the missing local devtools backend; after starting the local backend and verifying its endpoint returned 200, the unchanged suite passed 3/3 in 14.5s. - PASS in Ego Chromium with actual Dialog components: the initially closed nested wrapper computes
display:none, and the parent button receives clicks. Removing onlyempty:hiddenin the disposable DOM restoresdisplay:block,pointer-events:auto, an intercepted hit and no button increment; restoring it restores the click. This is a runtime component mutation, not a full-suite mutation. - PASS: closing nested content stays connected with an active exit animation, then its empty wrapper hides after
animationend; parent clicks continue. A reopened above B has the later DOM position, accepts pointer/text input, and Escape closes A and returns focus to B.
CI is pending (49 passing, 10 pending, 10 skipped at the latest checks snapshot). Import Model, node-search filter suites and the full browser suite were NOT_RUN locally in this focused follow-up; their previously failing CI paths still need to complete. No source changes, CI reruns or review-thread resolution performed.
…ers (Comfy-Org#21411) ## Summary Stacked on Comfy-Org#21396. Replace `ImperativePopover` consumers with declarative Reka popovers and delete the adapter. Preserve hover delays, focus restoration, selection dismissal, and viewport dismissal. A shared viewport-dismiss composable keeps scroll handling out of each consumer. ## Verification - Focused Vitest run: 201 tests passed across the migrated consumers and shared popovers. - Chromium: 51 passed; one toast screenshot differs by five pixels. The same screenshot fails with the same five-pixel difference on unchanged Comfy-Org#21396. - Browser checks covered canvas menu keyboard focus, nested template filters, toast filtering, and workflow previews. Inspected captures of canvas, login, and workflow popovers and an interaction recording. - Added regression coverage for a pending hover timer reopening a workflow preview after a quick click-open/click-close. Risk: popover focus, anchoring, and dismissal across the migrated callers. No data migration; revert this PR to restore the adapter. --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…title (#21449) (#21640) Backport of #21449 to `core/1.58`. Manual backport: the auto-backport hit a conflict in `GlobalDialog.vue`, where this branch still has the `v-reka-z-index` directive on `DialogContent` (removed on main in #21396). Kept the directive and took the new `aria-labelledby` binding. No other changes. Verified: `src/components/dialog` unit tests (256 passed), app and browser typecheck, oxfmt.
… title (#21449) (#21641) Backport of #21449 to `cloud/1.58`. Manual backport: the auto-backport hit a conflict in `GlobalDialog.vue`, where this branch still has the `v-reka-z-index` directive on `DialogContent` (removed on main in #21396). Kept the directive and took the new `aria-labelledby` binding. No other changes. Same resolution as #21640. Verified: `src/components/dialog` unit tests and app typecheck.
|
|
## Summary Move app-independent components, supporting types, recipes, pure stories, and their tests into `@comfyorg/design-system`. App wrappers with stores, translations, or app state remain app-owned. This PR also carries #21499 (components freed by #21396 and #21420) and the root `Popover` freed by #21411. ```text App wrappers → design-system components → shared Vue and Reka peers ``` Workspace imports use Vue source. Published imports use compiled ES modules and ordinary declarations with Bundler resolution; every published component and `lib/*` export has a `default` condition. `clsx` and `tailwind-merge` are declared dependencies and stay external, so consumers share one class-merging runtime. Scoped component CSS is exported separately and is published-only. Reka and its type-helper prerequisite are peers, optional for CSS-only consumers. ```diff @comfyorg/design-system + button, tooltip (TextTooltip, TooltipContent), PopoverContent, HoverCardContent + menu (Menu, ContextMenu, ContextMenuContent, MenuItems, MenuSubmenu, + MenuRadioGroup, MenuItemContent, MenuAction, MenuContent, MenuSubContent) + Badge, Message, Spinner, Pagination, TableSortHead, TreeItem, PasswordInput, InputGroupButton + dialog (DialogClose, DialogMaximize, DialogPanel), toast (ToastClose, ToastDock, ToastViewport) + search-input (SearchInput, SearchAutocomplete, AsyncSearchInput) + select (SelectContent, SingleSelect, SearchableSingleSelect, MultiSelect, MultiSelectContent) + media/ZoomPane, NumberFieldIncrement/Decrement, TagsInputItemDelete, TagRemoveButton + lib: useSelectSearch, useAttrsClass, usePopoverSizing, usePopoverViewportDismiss, menu helpers app - Popover (ui): consumers use Reka PopoverRoot/Trigger with the design-system PopoverContent - Toaster (ui) + AppToaster (wrapper) + AppToaster (one component: queue rendering, announcements, labels) ``` - `MenuContent` and `MenuSubContent` portal their own content, and `MenuSubContent` must be rendered inside `MenuSub`. Context menus use the new `ContextMenuContent`. Keyed menus skip the close animation, as #21396 accepts. - `Dialogue` and `ImageLightbox` are built on the design-system dialog parts. The checkout saved-method picker uses the design-system `SingleSelect`. `DeploymentSwitcherRow` stays in the app. - Component tests, `DialogOrdering` stories, and the component guidance (`AGENTS.md`) move into the package, which runs its own Vitest with happy-dom. - Out of scope: the ColorPicker family (#21480) and CreditSlider (subscription pricing). - The package scans its stories for Tailwind classes because root Storybook depends on them; tests and markdown are excluded. Intended visual changes: - `Dialogue` uses the `sm` dialog size (384px) and the dialog surface. - The lightbox overlay is 70% opaque. - `BillingAutoTopUpCard` uses `destructive`; its previous `destructive-background` token does not exist. - `PopoverContent` defaults `collisionPadding` to 8. ## Verification - A new import guard fails when compiled JS or declarations import an undeclared package. It failed on the bundled class-merging runtime before the fix and passes now. CI and the publish workflow run it. - An isolated, non-hoisted packed consumer, tested with Reka 2.11.0, passes strict type checking, host-provider SSR (including `Button` and a searchable select through `fuse.js`), Tailwind compilation, and scoped-animation checks. CI and the publish workflow run it. - Package Vitest, app/browser/package typechecks, build, lint, Knip, `architecture:check`, affected app unit tests, and the node-search E2E specs pass. - Storybook checks: toasts of every kind, a select listbox and nested menu above an open dialog, `DialogPanel`, and `DialogClose` render correctly. Two-way door. Mostly import-path churn. The main risks are unresolved package imports, duplicate provider contexts, and missing compiled styles or declarations. This PR does not publish a package. --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Summary
Fixes FE-3416. Stacked on #21389 and preserves its repaired lockfile.
Removes the z-index counter and custom portal manager. Dialog and toast owners use CSS stacking contexts and forward inherited Reka configuration. Popup portals use Vue keys derived from existing open state; dialogs unmount on close. Existing owner-model state stays intact. Select portals retain native option registration and exit animations; dialogs and keyed popups close immediately. Getting Started remains below dialogs; notifications, tours and blocking screens keep their named tiers.
Evidence
Merge Danger
Door: Two-way. Frontend-only change.
Blast Radius: Overlays. Close animations change for remounted portals. Arbitrary retained mounted subtrees do not receive last-opened ordering. Explicit portal targets and extension stacking contexts still follow CSS rules.