Repository navigation
[backport core/1.58] [chore] Update Ingest API types from cloud@c5d79c08 - #21483
comfy-pr-bot wants to merge 2 commits into
Conversation
## Automated Ingest API Type Update This PR updates the Ingest API TypeScript types and Zod schemas from the latest cloud OpenAPI specification. - Cloud commit: c5d79c08 - Generated using @hey-api/openapi-ts with Zod plugin These types cover the FE-facing ingest API (workspaces, billing, secrets, assets, tasks, etc.). Cloud's internal / machine-to-machine surface — `x-internal` operations and the `/admin/`, `/api/internal/`, `/api/webhooks/` rails — is stripped before generation (BE-2669), so it is not code-generated into this public package. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
📦 Bundle Size
🎭 Playwright: ✅ 2952 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 0ba4afebae9e5de425405f763ea129a10406c026
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (116)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog 🌐 Website E2ETip All tests passed. Test results
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.58 #21483 +/- ##
=============================================
- Coverage 86.15% 85.42% -0.73%
=============================================
Files 2784 3947 +1163
Lines 154537 184693 +30156
Branches 39162 49876 +10714
=============================================
+ Hits 133142 157781 +24639
- Misses 21005 24779 +3774
- Partials 390 2133 +1743
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1175 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…a8c (#21765) ## Why core/1.58 ingest types stop at cloud@6ac675e5 (PR 21299). The checkout banner (PR 21708, FE-3527) reads `checkout_state` and `latest_subscription_op_id`, which first exist in PR 21508. That backport cannot typecheck on this branch until the generated types include those fields. ## Root cause PR 21508 merged to main with the `core/1.58` label and without `needs-backport`, so the backport bot never opened a release PR. Its parent is not on core/1.58, and the generated types file here is still the PR 21299 blob. A lone cherry-pick of PR 21508 does not apply. The two ingest updates between them, PR 21351 and PR 21450, only touch `packages/ingest-types` and apply first. ## How Cherry-pick onto core/1.58, in order, with no hand edits: 1. PR 21351 (`cloud@c5d79c08`), ingest types only 2. PR 21450 (`cloud@453e791d`), ingest types only 3. PR 21508 (`cloud@2d86ea8c`), generated types plus the fixture updates that shipped with that bump All three applied cleanly. Generated files were not edited by hand. #21483 is the older core slice (PR 21351 only). This PR carries the types through PR 21508, so PR 21483 is superseded by this one. ## AS IS / TO BE No user-visible change. This PR only moves the generated Ingest contract. AS IS: `BillingStatusResponse` has `pending_billing_op_id`. `BillingOpStatusResponse` has no `checkout_state`. TO BE: `latest_subscription_op_id` and `checkout_state` are on the generated types, matching main after PR 21508. The billing panel still does not render the checkout banner. That is the follow-up backport of PR 21708. ## Plan position | Item | Ticket | PR | Status | | --- | --- | --- | --- | | Ingest types through `checkout_state` | | **this PR** (PR 21351, PR 21450, PR 21508) | open | | Older core slice of PR 21351 | | PR 21483 | superseded by this PR | | Checkout banner on the billing panel | FE-3527 | PR 21708 on main | waiting on these types | ```mermaid flowchart LR slice["PR 21483 types slice"] --> types["PR 21508 ingest types"] types --> banner["PR 21708 checkout banner"] style types fill:#9f6,stroke:#333 ``` --------- Co-authored-by: Comfy Org PR Bot <snomiao+comfy-pr@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com>
|
Closing: this backport's diff is empty, so core/1.58 already has these Ingest API types. |
Pull request was closed
Backport of #21351 to
core/1.58Automatically created by backport workflow.