Skip to content

[backport core/1.58] [chore] Update Ingest API types from cloud@c5d79c08 - #21483

Closed
comfy-pr-bot wants to merge 2 commits into
core/1.58from
backport-21351-to-core-1.58
Closed

comfy-pr-bot wants to merge 2 commits into
core/1.58from
backport-21351-to-core-1.58

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #21351 to core/1.58

Automatically created by backport workflow.

## Automated Ingest API Type Update

This PR updates the Ingest API TypeScript types and Zod schemas from the
latest cloud OpenAPI specification.

- Cloud commit: c5d79c08
- Generated using @hey-api/openapi-ts with Zod plugin

These types cover the FE-facing ingest API (workspaces, billing,
secrets, assets, tasks, etc.).
Cloud's internal / machine-to-machine surface — `x-internal` operations
and the
`/admin/`, `/api/internal/`, `/api/webhooks/` rails — is stripped before
generation
(BE-2669), so it is not code-generated into this public package.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Oct 20, 2026
@comfy-pr-bot comfy-pr-bot self-assigned this Oct 20, 2026
@comfy-pr-bot
comfy-pr-bot enabled auto-merge (squash) October 20, 2026 21:10
@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle Size

⏳ Size data collection in progress…

🎭 Playwright: ✅ 2952 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 2273 / ❌ 0 / ⚠️ 1 / ⏭️ 0)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • cloud: View Report (✅ 650 / ❌ 0 / ⚠️ 1 / ⏭️ 0)
  • desktop: View Report (✅ 4 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 19 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-safari: View Report (✅ 3 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/20/2026, 09:12:27 PM UTC

Links

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

No verdict is available. Open the workflow run to confirm the check was intentionally skipped, or fix the collection failure and re-run it.

Findings and check details

The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

Findings and check details

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 0ba4afebae9e5de425405f763ea129a10406c026

Full docs: ADR-DEVEX-LINT-0015

🏛️ Architecture: ✅ Passed

Findings and check details

Warnings (116)

  • src/components/graph/selectionToolbox/LinkSelectionActions.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/searchbox/v2/filterChip.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.stories.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardFooter.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardHeader.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardTitle.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/card.variants.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/billing/useSubscriptionPaywall.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/billing/useSubscriptionPaywall.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/graph/menuOption.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/litegraphServiceAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/nodeDef/ComfyNodeDefImpl.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/selection/selectionIntent.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/cameraInfo.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dInstances.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/i18n.literalMessages.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/canvasClassAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkSelection.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkSelection.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/authStoreAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/currentUserAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/sessionCookieAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/sessionRevokedError.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/webSessionFetch.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/sso/ssoRequiredContext.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/missingModel/releaseModelOptions.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/missingModel/releaseModelOptions.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/telemetry/billingActionNames.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/telemetry/billingActionNames.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/telemetry/extensionLoadTelemetry.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/__fixtures__/deploymentListing.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/api/deploymentListingTimeouts.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/billingRefresh.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/billingRefresh.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/billingTab.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/billingTab.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/topupCheckoutReturnUrl.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/topupCheckoutReturnUrl.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/components/DeploymentSwitcher.stories.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/components/DeploymentSwitcher.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/components/DeploymentSwitcher.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • …and 66 more
Reproduce locally
pnpm architecture:check

Full docs: Frontend domain catalog

🌐 Website E2E

Tip

All tests passed.

View Report

Test results
Status ✅ Passed

@github-actions
github-actions Bot requested a review from thedatalife October 20, 2026 21:11
@codecov

codecov Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##           core/1.58   #21483      +/-   ##
=============================================
- Coverage      86.15%   85.42%   -0.73%     
=============================================
  Files           2784     3947    +1163     
  Lines         154537   184693   +30156     
  Branches       39162    49876   +10714     
=============================================
+ Hits          133142   157781   +24639     
- Misses         21005    24779    +3774     
- Partials         390     2133    +1743     
Flag Coverage Δ
billing-web-unit 92.40% <ø> (?)
e2e 64.12% <100.00%> (-0.02%) ⬇️
unit 85.72% <ø> (-0.01%) ⬇️
website-unit 80.41% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/ingest-types/src/zod.gen.ts 100.00% <100.00%> (ø)

... and 1175 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 20, 2026
comfy-pr-bot added a commit that referenced this pull request Oct 23, 2026
…a8c (#21765)

## Why

core/1.58 ingest types stop at cloud@6ac675e5 (PR 21299). The checkout
banner (PR 21708, FE-3527) reads `checkout_state` and
`latest_subscription_op_id`, which first exist in PR 21508. That
backport cannot typecheck on this branch until the generated types
include those fields.

## Root cause

PR 21508 merged to main with the `core/1.58` label and without
`needs-backport`, so the backport bot never opened a release PR. Its
parent is not on core/1.58, and the generated types file here is still
the PR 21299 blob. A lone cherry-pick of PR 21508 does not apply. The
two ingest updates between them, PR 21351 and PR 21450, only touch
`packages/ingest-types` and apply first.

## How

Cherry-pick onto core/1.58, in order, with no hand edits:

1. PR 21351 (`cloud@c5d79c08`), ingest types only
2. PR 21450 (`cloud@453e791d`), ingest types only
3. PR 21508 (`cloud@2d86ea8c`), generated types plus the fixture updates
that shipped with that bump

All three applied cleanly. Generated files were not edited by hand.

#21483 is the older
core slice (PR 21351 only). This PR carries the types through PR 21508,
so PR 21483 is superseded by this one.

## AS IS / TO BE

No user-visible change. This PR only moves the generated Ingest
contract.

AS IS: `BillingStatusResponse` has `pending_billing_op_id`.
`BillingOpStatusResponse` has no `checkout_state`.

TO BE: `latest_subscription_op_id` and `checkout_state` are on the
generated types, matching main after PR 21508. The billing panel still
does not render the checkout banner. That is the follow-up backport of
PR 21708.

## Plan position

| Item | Ticket | PR | Status |
| --- | --- | --- | --- |
| Ingest types through `checkout_state` | | **this PR** (PR 21351, PR
21450, PR 21508) | open |
| Older core slice of PR 21351 | | PR 21483 | superseded by this PR |
| Checkout banner on the billing panel | FE-3527 | PR 21708 on main |
waiting on these types |

```mermaid
flowchart LR
  slice["PR 21483 types slice"] --> types["PR 21508 ingest types"]
  types --> banner["PR 21708 checkout banner"]
  style types fill:#9f6,stroke:#333
```

---------

Co-authored-by: Comfy Org PR Bot <snomiao+comfy-pr@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: GitHub Action <action@github.com>
@thedatalife

Copy link
Copy Markdown
Contributor

Closing: this backport's diff is empty, so core/1.58 already has these Ingest API types.

auto-merge was automatically disabled October 26, 2026 18:01

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:medium PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants