Repository navigation
feat(website): add Hub creator profile pages - #21457
MaanilVerma wants to merge 5 commits into
Conversation
Move the Load more button out of WorkflowGrid into LoadMoreButton so the creator profile grid can use the same button.
Add /hub/creators/<username>/, one profile page per creator with their avatar, bio, website links, and workflows. Workflow cards and the creators directory now link to these pages in the same tab, with the username lowercased so links and paths always agree. The page sends the first 24 workflow cards with the HTML. The rest come from /hub/creators/<username>.json, which the grid fetches on the first Load more click. This cuts the comfyui page's island props from about 309 KB to about 15 KB. The page is a ProfilePage whose main entity is the creator. The official ComfyUI creator is an Organization that points at the site organization through sameAs, so search engines see one organization. creatorMetaDescription builds the meta description from the summary and the bio, collapsed to one line and cut at a word to 160 characters.
A second click during the fetch started a second request, and the tests waited on timing. The button is now disabled while a load runs, and the tests wait on that state and on the card count.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 194b97ee57ea7b2287bc38ec06c8e752a77f7e09
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (115)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog 🌐 Website E2ETip All tests passed. Test results
🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-21457.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. Deployment detailsThis commit: https://website-frontend-12k54z8zj-comfyui.vercel.app Last updated: 2026-10-21T02:08:21Z for |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## maanil/hub-creators-directory #21457 +/- ##
=================================================================
- Coverage 86.42% 86.40% -0.02%
=================================================================
Files 3768 3775 +7
Lines 177473 177264 -209
Branches 48896 46740 -2156
=================================================================
- Hits 153376 153167 -209
- Misses 21951 21991 +40
+ Partials 2146 2106 -40
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 44 files with indirect coverage changes 🚀 New features to boost your workflow:
|
QA - Found no issues in the PR
11 pass, 0 fail, 0 escalated, 1 inconclusive. 13 screenshots and 3 traces (open them with Not covered here
Context for agents
|
The bio sat under the header at text-lg and read like a second headline. It now shares the column with the name, next to the avatar, at 14px with the same max width.
dante01yoon
left a comment
There was a problem hiding this comment.
Reviewed the profile-page delta against #21456 at b75f619. I found no additional blocking finding in that delta. Approval is deferred until the generated Hub contract issue in the base PR is corrected and propagated here: #21456 (review).
Own verification: PASS for 487 focused tests, website typecheck, normal and indexable builds, and JSON-LD/markdown-alternate/llms.txt/internal-link/hreflang validators on indexable output. A disposable invalid ProfilePage type was rejected by the JSON-LD validator while the original passed. Browser checks on the exact-head local build passed for Purz pagination (24 to 26 cards, one JSON request, button removed), the public workflow destination, the ComfyUI profile at 390px without horizontal overflow, and its trailing-slash canonical. The non-indexable build intentionally has no canonical; llms.txt validation passed after rebuilding with WEBSITE_INDEXABLE=1. Production creator-route deployment and Rich Results Test are NOT_RUN; the documented comfy-router#51 deployment prerequisite still applies.
…profiles-pages Brings in the generated Hub schemas, case-merged usernames and the test cleanups from #21456. The creators.ts import conflict keeps both import sets and the generated label schema. publish_time can now be null, so a profile card dates such a workflow as empty, which the grid already sorts last; a test covers it.
dante01yoon
left a comment
There was a problem hiding this comment.
Re-reviewed exact head e2583f5, including the inherited generated-Hub-contract fix and profile null-date handling. The parent fix is verified in #21456 (review). No additional blocking finding remains in this child.
Own validation PASS: isolated frozen install; 114 focused tests/12 files; website typecheck; indexable production build; JSON-LD, hreflang, internal-link slash, llms.txt and Markdown-alternate validators on actual output; touched-file type-aware lint and formatting. Configuration excludes two test files from ESLint; no coverage is claimed there.
Restoring the old unconditional date slice fails the null-date regression (23 other creator tests pass). Restoring the old non-null publish-time restriction fails both refresh regressions (7 pass). Changing the built profile JSON-LD to an unknown type fails the output validator, and output was restored.
Ego browser on the exact-head local build: the directory links to the local Purz profile; its 24 cards expand to 26 with one JSON fetch and the Load more button disappears. The canonical is https://comfy.org/hub/creators/purz/ and the page has no horizontal overflow at 390px. These checks use committed public snapshot data; no private-account or generation action. Full unrelated app/browser suites NOT_RUN. Hosted CI reports SUCCESS separately from own checks.
MaanilVerma remains assigned; no review-thread resolution or merge performed.
|
Closing this PR. The Hub creator pages now come from CCC data (plan item P2, stacked on #21204), so the snapshot path does not ship. The branch stays, and P2 copies its reusable components and tests. |













Summary
Each Hub creator gets a profile page at
/hub/creators/<username>/, with avatar, bio and their workflows. Creator links on Hub cards now open these pages in the same tab, in place of the old/workflows/<username>/profiles.Changes
Pages:
pages/hub/creators/[username].astrorenders one page per creator from the snapshot. It shows the first 24 workflows. The other workflows load frompages/hub/creators/[username].json.tson the first Load more click, so the comfyui page is 253 KB in place of 547 KB.creatorMetaDescription), a canonical URL with a trailing slash, and the sitemap entry.ProfilePagewithOrganizationfor comfyui andPersonfor everyone else, plus a breadcrumb and the list of workflows. The comfyui creator node points to the site organization withsameAs.Components:
CreatorWorkflowGrid.vueshows the workflow cards and pages through them. Load more is disabled while a load runs, so a second click does not start a second request.LoadMoreButton.vueis shared byWorkflowGridandCreatorWorkflowGrid.Links:
hubCreatorUrlinlib/hub/routes.tsnow returns/hub/creators/<username>/in lowercase. The author link onHubWorkflowCardopens in the same tab./workflows/<id>/pages until the new Hub workflow pages exist.QA Focus
pnpm exec vitest run src/lib/hub src/components/hub scripts/refresh-hub-creators-snapshot.test.ts src/utilsinapps/website. Expected: all pass. Author: tested, 487 pass. The Load more test file passed 8 runs in a row after the fix.pnpm typecheck:website,pnpm knip, eslint and the format check. Expected: all pass. Author: tested, all pass, and the pre-push hook passed..jsonfiles underdist/hub/creators/, and the sitemap lists the directory and the 15 profiles. Author: tested, 1,177 pages built./hub/creators/purz/and click Load more. Expected: more cards load from/hub/creators/purz.jsonwith one request. Author: tested, see the QA comment./hub/creators/comfyui/in the Rich Results Test. Expected: a valid ProfilePage. Author: not tested, because the page is not public yet.Risky areas
hubCreatorUrlchanges for every Hub card. Today the author link shows only on test pages, becauseVfxLandingV2hides the author andHubBrowseis not mounted on a live page./hub/creators/<username>/to the old site, which answers 404.WorkflowGrid.vuenow uses the sharedLoadMoreButton. Its tests pass.PR dependency map
main(base)main)main)Merge the directory PR and deploy the router PR before this PR.