Skip to content

feat(website): add Hub creator profile pages - #21457

Closed
MaanilVerma wants to merge 5 commits into
maanil/hub-creators-directoryfrom
maanil/hub-creator-profiles-pages
Closed

MaanilVerma wants to merge 5 commits into
maanil/hub-creators-directoryfrom
maanil/hub-creator-profiles-pages

Conversation

@MaanilVerma

@MaanilVerma MaanilVerma commented Oct 20, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Each Hub creator gets a profile page at /hub/creators/<username>/, with avatar, bio and their workflows. Creator links on Hub cards now open these pages in the same tab, in place of the old /workflows/<username>/ profiles.

Changes

Pages:

  • pages/hub/creators/[username].astro renders one page per creator from the snapshot. It shows the first 24 workflows. The other workflows load from pages/hub/creators/[username].json.ts on the first Load more click, so the comfyui page is 253 KB in place of 547 KB.
  • Each page has its own title, a meta description of at most 160 characters (creatorMetaDescription), a canonical URL with a trailing slash, and the sitemap entry.
  • The structured data is ProfilePage with Organization for comfyui and Person for everyone else, plus a breadcrumb and the list of workflows. The comfyui creator node points to the site organization with sameAs.

Components:

  • CreatorWorkflowGrid.vue shows the workflow cards and pages through them. Load more is disabled while a load runs, so a second click does not start a second request.
  • LoadMoreButton.vue is shared by WorkflowGrid and CreatorWorkflowGrid.

Links:

  • hubCreatorUrl in lib/hub/routes.ts now returns /hub/creators/<username>/ in lowercase. The author link on HubWorkflowCard opens in the same tab.
  • Workflow cards on a profile still link to the old /workflows/<id>/ pages until the new Hub workflow pages exist.

QA Focus

  • Run pnpm exec vitest run src/lib/hub src/components/hub scripts/refresh-hub-creators-snapshot.test.ts src/utils in apps/website. Expected: all pass. Author: tested, 487 pass. The Load more test file passed 8 runs in a row after the fix.
  • Run pnpm typecheck:website, pnpm knip, eslint and the format check. Expected: all pass. Author: tested, all pass, and the pre-push hook passed.
  • Build the website. Expected: 15 profile pages and 15 .json files under dist/hub/creators/, and the sitemap lists the directory and the 15 profiles. Author: tested, 1,177 pages built.
  • Open /hub/creators/purz/ and click Load more. Expected: more cards load from /hub/creators/purz.json with one request. Author: tested, see the QA comment.
  • Check /hub/creators/comfyui/ in the Rich Results Test. Expected: a valid ProfilePage. Author: not tested, because the page is not public yet.

Risky areas

  • hubCreatorUrl changes for every Hub card. Today the author link shows only on test pages, because VfxLandingV2 hides the author and HubBrowse is not mounted on a live page.
  • WARNING: Do not deploy this before Comfy-Org/comfy-router#51. Without it, comfy-router sends /hub/creators/<username>/ to the old site, which answers 404.
  • WorkflowGrid.vue now uses the shared LoadMoreButton. Its tests pass.

PR dependency map

  1. main (base)
  2. feat(website): add the Hub creators directory #21456 Hub creators directory (open, targets main)
  3. Comfy-Org/comfy-router#51 (draft, targets main)
  4. This PR (draft, targets the directory PR)

Merge the directory PR and deploy the router PR before this PR.

Move the Load more button out of WorkflowGrid into LoadMoreButton so the
creator profile grid can use the same button.
Add /hub/creators/<username>/, one profile page per creator with their
avatar, bio, website links, and workflows. Workflow cards and the
creators directory now link to these pages in the same tab, with the
username lowercased so links and paths always agree.

The page sends the first 24 workflow cards with the HTML. The rest come
from /hub/creators/<username>.json, which the grid fetches on the first
Load more click. This cuts the comfyui page's island props from about
309 KB to about 15 KB.

The page is a ProfilePage whose main entity is the creator. The
official ComfyUI creator is an Organization that points at the site
organization through sameAs, so search engines see one organization.
creatorMetaDescription builds the meta description from the summary
and the bio, collapsed to one line and cut at a word to 160 characters.
A second click during the fetch started a second request, and the tests
waited on timing. The button is now disabled while a load runs, and the
tests wait on that state and on the card count.
@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 8fc1655d-50ea-46cf-bfb5-b57dd9a304bd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle Size

⏳ Size data collection in progress…

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

No verdict is available. Open the workflow run to confirm the check was intentionally skipped, or fix the collection failure and re-run it.

Findings and check details

The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

Findings and check details

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 194b97ee57ea7b2287bc38ec06c8e752a77f7e09

Full docs: ADR-DEVEX-LINT-0015

🏛️ Architecture: ✅ Passed

Findings and check details

Warnings (115)

  • src/components/graph/selectionToolbox/LinkSelectionActions.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/searchbox/v2/filterChip.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.stories.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardFooter.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardHeader.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardTitle.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/card.variants.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/billing/useSubscriptionPaywall.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/billing/useSubscriptionPaywall.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/graph/menuOption.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/litegraphServiceAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/nodeDef/ComfyNodeDefImpl.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/selection/selectionIntent.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/agentPanel.historyIdentity.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/cameraInfo.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dInstances.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/i18n.literalMessages.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/canvasClassAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkSelection.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkSelection.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/authStoreAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/currentUserAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/sessionCookieAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/sessionRevokedError.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/webSessionFetch.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/sso/ssoRequiredContext.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/missingModel/releaseModelOptions.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/missingModel/releaseModelOptions.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/telemetry/billingActionNames.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/telemetry/billingActionNames.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/telemetry/extensionLoadTelemetry.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/__fixtures__/deploymentListing.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/api/deploymentListingTimeouts.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/billingRefresh.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/billingRefresh.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/billingTab.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/billingTab.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/topupCheckoutReturnUrl.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/topupCheckoutReturnUrl.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/components/DeploymentSwitcher.stories.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/components/DeploymentSwitcher.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • …and 65 more
Reproduce locally
pnpm architecture:check

Full docs: Frontend domain catalog

🌐 Website E2E

Tip

All tests passed.

View Report

Test results
Status ✅ Passed

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-21457.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

Deployment details

This commit: https://website-frontend-12k54z8zj-comfyui.vercel.app

Last updated: 2026-10-21T02:08:21Z for e2583f5

@codecov

codecov Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.90909% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../website/src/pages/hub/creators/[username].json.ts 0.00% 3 Missing ⚠️
apps/website/src/config/hub-creators.ts 0.00% 2 Missing ⚠️
...website/src/components/hub/CreatorWorkflowGrid.vue 95.23% 0 Missing and 1 partial ⚠️
@@                        Coverage Diff                        @@
##           maanil/hub-creators-directory   #21457      +/-   ##
=================================================================
- Coverage                          86.42%   86.40%   -0.02%     
=================================================================
  Files                               3768     3775       +7     
  Lines                             177473   177264     -209     
  Branches                           48896    46740    -2156     
=================================================================
- Hits                              153376   153167     -209     
- Misses                             21951    21991      +40     
+ Partials                            2146     2106      -40     
Flag Coverage Δ
website-unit 80.45% <90.90%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...pps/website/src/components/hub/HubWorkflowCard.vue 75.00% <ø> (+12.50%) ⬆️
apps/website/src/components/hub/LoadMoreButton.vue 100.00% <100.00%> (ø)
apps/website/src/components/hub/WorkflowGrid.vue 84.78% <100.00%> (ø)
apps/website/src/lib/hub/creators.ts 98.03% <100.00%> (+3.03%) ⬆️
apps/website/src/lib/hub/routes.ts 100.00% <100.00%> (ø)
...website/src/lib/workshop/model-meta-description.ts 97.56% <ø> (ø)
apps/website/src/utils/jsonLd.ts 96.10% <ø> (ø)
...website/src/components/hub/CreatorWorkflowGrid.vue 95.23% <95.23%> (ø)
apps/website/src/config/hub-creators.ts 0.00% <0.00%> (ø)
.../website/src/pages/hub/creators/[username].json.ts 0.00% <0.00%> (ø)

... and 44 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 20, 2026
@MaanilVerma

MaanilVerma commented Oct 20, 2026 •

Copy link
Copy Markdown
Collaborator Author

QA - Found no issues in the PR

What it checks Proof
/hub/creators/purz/ shows avatar, name, @handle, count, bio and the first 24 workflow cards (desktop) · measured: avatar loaded, "Purz", @purz · 26 workflows, bio present, 24 cards
The purz profile at mobile width · measured: same header values, 24 cards
/hub/creators/comfyui/ shows the same parts (desktop and mobile) · measured: @comfyui · 456 workflows, bio present, 24 cards
On purz, Load more fetches /hub/creators/purz.json one time, and the button is disabled while the request runs · trace · measured: I held the response, the button was disabled, 2 more forced clicks sent no request, requests = [/hub/creators/purz.json], cards 24 to 26, then the button is removed
On comfyui, Load more runs until all 456 cards show, with one request · measured: 18 clicks, cards 24, 48, 72 ... 432, 456, requests = [/hub/creators/comfyui.json], then the button is removed
Page title measured: Purz (@purz): ComfyUI workflows - Comfy and ComfyUI (@comfyui): ComfyUI workflows - Comfy. PASS
Meta description is 160 characters or fewer measured: purz 159, comfyui 120. PASS
Canonical URL has a trailing slash INCONCLUSIVE for the <link rel="canonical"> tag. The local build and the Vercel preview are not indexable, so BaseLayout emits noindex and no canonical tag (emitCanonical: indexableBuild). The same canonicalURL value in og:url is https://comfy.org/hub/creators/purz/ and https://comfy.org/hub/creators/comfyui/
JSON-LD has ProfilePage, with Organization for comfyui (sameAs the site organization) and Person for purz measured: ProfilePage mainEntity = #creator. comfyui #creator is Organization with sameAs: ["https://comfy.org/#organization"]. purz #creator is Person. PASS
Directory cards link to /hub/creators/<username>/ and open in the same tab · trace · measured: 15 of 15 hrefs match, no target, a click on Purz loads /hub/creators/purz/ with 1 tab before and after
An unknown creator returns 404 · trace · measured: /hub/creators/not-a-real-creator/ is 404 on the local build and on the Vercel preview
The header at b75f619d6d: avatar on the left, eyebrow, name, handle, bio and links on the right, top-aligned; bio at 14px · measured: bio font-size 14px at 1440 and 390 wide

11 pass, 0 fail, 0 escalated, 1 inconclusive. 13 screenshots and 3 traces (open them with pnpm exec playwright show-trace), against a local production build of the PR head.

Not covered here
  • The canonical tag itself. Only an indexable build (WEBSITE_INDEXABLE=1) emits it, and this QA used one normal build of the PR.
  • The Rich Results Test. The page is not public yet.
  • comfy.org after deploy. comfy-router sends /hub/creators/<username>/ to the old site until Comfy-Org/comfy-router#51 deploys.
  • The last 2 purz workflows (Chatter Box) show the image placeholder because their snapshot entries have no thumbnails. This is the source data, not a defect in this PR.
  • The comfyui Load more trace (158 MB) is too large for the assets branch. The measured request list above comes from the same run.
Context for agents
  • Commit: 7c055257910276bf8d702782e6ae9a6862bde862 (branch maanil/hub-creator-profiles-pages, stacked on feat(website): add the Hub creators directory #21456).
  • Environment: pnpm --filter @comfyorg/website build (1,177 pages), then astro preview --port 4432 on the dist output. Chromium through Playwright, viewports 1440x900 and 390x844.
  • Vercel preview https://comfy-website-preview-pr-21457.vercel.app answered 200 for /hub/creators/ and 404 for an unknown creator. It also has noindex and no canonical tag.
  • The Load more cards hydrate with client:visible. The spec waits for astro-island[ssr] to go away before the first click.
  • Spec, measured values and traces: temp/qa-evidence/hub-creators/ (spec/qa.spec.ts, measured.json) on the QA machine. Assets: branch assets/pr-21456-21457-qa, folder qa/.

The bio sat under the header at text-lg and read like a second headline.
It now shares the column with the name, next to the avatar, at 14px with
the same max width.
@MaanilVerma
MaanilVerma marked this pull request as ready for review October 20, 2026 15:20
@MaanilVerma
MaanilVerma requested review from a team and dante01yoon as code owners October 20, 2026 15:20
MaanilVerma added a commit that referenced this pull request Oct 20, 2026
MaanilVerma added a commit that referenced this pull request Oct 20, 2026

@dante01yoon dante01yoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the profile-page delta against #21456 at b75f619. I found no additional blocking finding in that delta. Approval is deferred until the generated Hub contract issue in the base PR is corrected and propagated here: #21456 (review).

Own verification: PASS for 487 focused tests, website typecheck, normal and indexable builds, and JSON-LD/markdown-alternate/llms.txt/internal-link/hreflang validators on indexable output. A disposable invalid ProfilePage type was rejected by the JSON-LD validator while the original passed. Browser checks on the exact-head local build passed for Purz pagination (24 to 26 cards, one JSON request, button removed), the public workflow destination, the ComfyUI profile at 390px without horizontal overflow, and its trailing-slash canonical. The non-indexable build intentionally has no canonical; llms.txt validation passed after rebuilding with WEBSITE_INDEXABLE=1. Production creator-route deployment and Rich Results Test are NOT_RUN; the documented comfy-router#51 deployment prerequisite still applies.

…profiles-pages

Brings in the generated Hub schemas, case-merged usernames and the test cleanups from #21456. The creators.ts import conflict keeps both import sets and the generated label schema. publish_time can now be null, so a profile card dates such a workflow as empty, which the grid already sorts last; a test covers it.

@dante01yoon dante01yoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed exact head e2583f5, including the inherited generated-Hub-contract fix and profile null-date handling. The parent fix is verified in #21456 (review). No additional blocking finding remains in this child.

Own validation PASS: isolated frozen install; 114 focused tests/12 files; website typecheck; indexable production build; JSON-LD, hreflang, internal-link slash, llms.txt and Markdown-alternate validators on actual output; touched-file type-aware lint and formatting. Configuration excludes two test files from ESLint; no coverage is claimed there.

Restoring the old unconditional date slice fails the null-date regression (23 other creator tests pass). Restoring the old non-null publish-time restriction fails both refresh regressions (7 pass). Changing the built profile JSON-LD to an unknown type fails the output validator, and output was restored.

Ego browser on the exact-head local build: the directory links to the local Purz profile; its 24 cards expand to 26 with one JSON fetch and the Load more button disappears. The canonical is https://comfy.org/hub/creators/purz/ and the page has no horizontal overflow at 390px. These checks use committed public snapshot data; no private-account or generation action. Full unrelated app/browser suites NOT_RUN. Hosted CI reports SUCCESS separately from own checks.

MaanilVerma remains assigned; no review-thread resolution or merge performed.

@MaanilVerma

Copy link
Copy Markdown
Collaborator Author

Closing this PR. The Hub creator pages now come from CCC data (plan item P2, stacked on #21204), so the snapshot path does not ship. The branch stays, and P2 copies its reusable components and tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants