Skip to content

feat(website): add Hub creator profile pages from the catalog - #21564

Closed
MaanilVerma wants to merge 9 commits into
maanil/ccc-creator-pagesfrom
maanil/ccc-creator-profile
Closed

MaanilVerma wants to merge 9 commits into
maanil/ccc-creator-pagesfrom
maanil/ccc-creator-profile

Conversation

@MaanilVerma

@MaanilVerma MaanilVerma commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

In CMS mode, /hub/creators/<username>/ now shows a creator's profile and their public workflow cards from the content catalog, with Load more for the next pages. The layout is the same as the closed #21457. A mixed-case URL redirects to the lowercase one, an unknown username returns the site 404 page, and a creator with no public workflows is noindex.

Changes

Data:

  • loadCatalogCreator() in lib/cms/catalog-creators.ts reads GET /api/v1/catalog/creators/{username}, returns missing on 404 and unavailable on other errors, keeps only https links, and accepts a bio of up to 5000 characters.
  • A username that isCreatorUsername() rejects (more than 30 characters, or anything other than letters, digits and inner hyphens, such as ..) is missing with no catalog read.
  • loadCreatorPage() returns the 301 target for a mixed-case username before any read.
  • The same loader reads the first page of workflow cards through loadSiteCatalogList() with author=<username>, so the staff Draft preview session applies as on the other Hub lists.
  • cardQuery() in lib/cms/catalog-list.ts now passes an author filter (1 to 30 characters) to the cards endpoint and to /models/catalogue.json.
  • cardQuery() now sends locale=en for a site locale that the cards endpoint does not serve. Before this, every /ja/hub/... card page on feat(website): Comfy Content Catalog Hub CMS (supersedes #20640, #20933) #21204 returned 503, because the request did not pass zListCccWebsiteCardsQuery. The fix is at this shared point, so it also fixes /ja/hub/workflows/ and /ja/hub/apps/.

Page:

  • routes/hub/creators/profile.astro maps the loadCreatorPage() answer to a 301, the pages/404.astro page with status 404, or 503.
  • components/hub/CreatorProfile.astro holds the page layout, and CreatorProfileHeader.vue renders the avatar, name, @username, bio and website links (rel="noopener noreferrer nofollow ugc").
  • CreatorWorkflowGrid.vue shows WorkshopModelCard cards and, on Load more, reads the next cursor page from /models/catalogue.json?section=workflows&format=page&author=.... A failed read keeps the button and shows a status message, a second click during a read does nothing, and a card that a later page repeats shows once.
  • LoadMoreButton.vue is shared with WorkflowGrid.vue, which now uses it with no change in behavior.

Structured data:

QA Focus

  • Run pnpm exec vitest run src/lib/cms/catalog-creators.test.ts src/lib/hub/creators.test.ts src/components/hub/CreatorWorkflowGrid.test.ts src/integrations/workshop-release-gate.test.ts src/lib/cms/catalog-list.test.ts src/components/hub/HubBrowse.test.ts in apps/website. Expected: all pass. Author: tested, 104 pass with CreatorProfileHeader.ssr.test.ts, creator-path.test.ts and the fetchDetail() callers. Before the change, these files did not pass because the modules did not exist. For the review fixes, I reverted each fix and saw 6 tests not pass (bio length, http link, .., ../admin, a 31-character username), and the ja card locale and Load more status tests did not pass before their fixes.
  • Run pnpm typecheck:website, pnpm knip and eslint on the changed files. Expected: no errors. Author: tested, 0 errors.
  • With a mock catalog and astro dev, open /hub/creators/purz/ (30 workflows) and click Load more. Expected: 24 cards, then 30 cards and no button. Author: tested with Playwright, see the QA comment.
  • Open /hub/creators/PurZ/, /hub/creators/ghost/ and a creator with no workflows. Expected: a 301 to /hub/creators/purz/, a 404 page, and a noindex page with an empty message. Author: tested with Playwright.
  • Open the profile against the real cloud feat: add persistent generated asset media tabs #14830 build. Author: not tested, because cloud feat: add persistent generated asset media tabs #14830 is not deployed to an environment this machine can reach.

Risky areas

  • lib/cms/catalog-list.ts is shared by every CCC list. The new author key is optional and is sent only when the request has it.
  • WARNING: A staff session reads /admin/api/site/catalog/cards with author. Cloud feat: add persistent generated asset media tabs #14830 adds the filter to the public cards endpoint only. I did not test the admin endpoint, so a staff preview can show cards by other authors.
  • CreatorProfile.astro uses the first card page for the ItemList, so a creator with more than 24 workflows lists only 24 in JSON-LD.
  • This PR has about 470 non-test lines, over the 300-line guide. Most of them are the copied layout from feat(website): add Hub creator profile pages #21457 and the review fixes. I did not split it again, because the profile route, header and grid do not work alone.

PR dependency map

  1. main (base)
  2. feat(website): Comfy Content Catalog Hub CMS (supersedes #20640, #20933) #21204 feat(website): Comfy Content Catalog Hub CMS (draft, targets main)
  3. feat(website): add the Hub creators directory from the catalog #21561 feat(website): add the Hub creators directory from the catalog (draft, targets feat(website): Comfy Content Catalog Hub CMS (supersedes #20640, #20933) #21204)
  4. this PR, feat(website): add Hub creator profile pages from the catalog (draft, targets feat(website): add the Hub creators directory from the catalog #21561)
  5. feat(website): link CCC workflow authors to their creator page #21570 feat(website): link CCC workflow authors to their creator page (draft, targets this PR)

Contract provider: cloud #14830 (draft) serves the profile read and the author card filter. UI source: the closed #21456 and #21457. #21551 writes the same creator @id on workflow pages. Merge #21204, #21561 and cloud #14830 before this PR.

In CMS mode, /hub/creators/<username>/ shows the creator profile and their public workflow cards, with Load more for the next cursor pages. A mixed-case URL redirects to the lowercase one, an unknown username renders the 404 page, and a creator with no workflows is noindex. The creator JSON-LD id is the English profile URL with #creator, the same id that workflow pages use for their author.
@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle Size

⏳ Size data collection in progress…

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

No verdict is available. Open the workflow run to confirm the check was intentionally skipped, or fix the collection failure and re-run it.

Findings and check details

The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

Findings and check details

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 077e46751808e8452d6a3743776023cac9a5dd11

Full docs: ADR-DEVEX-LINT-0015

🏛️ Architecture: ✅ Passed

Findings and check details

Warnings (132)

  • billing path matches no source files: src/components/dialog/content/credit/**. Remove or update it in docs/architecture/domains/records/billing.domain.json.
  • workspace path matches no source files: src/platform/workspace/fixtures/**. Remove or update it in docs/architecture/domains/records/workspace.domain.json.
  • src/components/graph/selectionToolbox/LinkSelectionActions.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/searchbox/v2/filterChip.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/Popover.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.stories.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardFooter.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardHeader.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/card.variants.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/billing/useSubscriptionPaywall.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/billing/useSubscriptionPaywall.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/graph/menuOption.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/litegraphServiceAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/nodeDef/ComfyNodeDefImpl.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/selection/selectionIntent.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/agentPanel.historyIdentity.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/cameraInfo.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/dynamicPrompts.serializeValue.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dHost.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dHost.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dInstances.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/reportLoadModelOutcome.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/reportLoadModelOutcome.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/i18n.literalMessages.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/LiteGraphGlobal.cloneObject.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/canvasClassAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkHideTransition.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkHideTransition.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkSelection.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkSelection.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkSnapGeometry.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkSnapGeometry.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/authStoreAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/currentUserAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/sessionCookieAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/sessionRevokedError.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/webSessionFetch.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/sso/ssoRequiredContext.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/missingModel/releaseModelOptions.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/missingModel/releaseModelOptions.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/telemetry/billingActionNames.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • …and 82 more
Reproduce locally
pnpm architecture:check

Full docs: Frontend domain catalog

🌐 Website E2E

Tip

All tests passed.

View Report

Test results
Status ✅ Passed

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-21564.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

Deployment details

This commit: https://website-frontend-80o7ym116-comfyui.vercel.app

Last updated: 2026-10-21T19:33:07Z for a7b8399

@MaanilVerma

Copy link
Copy Markdown
Collaborator Author

QA: Hub creator profile pages from the catalog

I ran astro dev in CMS mode (VERCEL_ENV=development) on this branch against a local mock catalog that serves the cloud #14830 contract. The mock has purz with 30 workflows (two card pages), comfyui, a creator with no workflows, and no ghost. Playwright drove the pages at 1440px and 390px.

What it checks Proof
The profile shows the name, @username, bio, a website link and the first 24 workflow cards · unit reads the profile and the first page of its public workflow cards
Load more reads the next cursor page with author=purz, shows 30 cards and removes the button · unit reads the next page of the creator cards on each Load more until none is left
A failed Load more keeps the button, and a click during a read does nothing unit keeps the button after a failed load and ignores clicks while loading
The profile fits a 390px phone with no sideways scroll · Playwright scrollWidth check
/hub/creators/PurZ/ redirects with 301 to /hub/creators/purz/ trace · Playwright redirect check
An unknown username returns status 404 with the site 404 page · unit reports a profile answered with 404 as missing
A creator with no public workflows shows an empty message and noindex, nofollow
The zh-CN profile shows Chinese copy and links to /zh-CN/hub/creators/
The JSON-LD is a ProfilePage whose creator @id is https://comfy.org/hub/creators/purz/#creator, the same id as #21551 Playwright JSON-LD check · unit names $username by the English profile URL

13 pass, 0 fail, 0 escalated, 1 inconclusive. 75 unit tests pass on this branch.

Not covered here: the real cloud #14830 build. It is not deployed to an environment I can reach, so a mock with the same contract served the data (inconclusive).

The merge takes the shared catalog read, the cursor walk and the client-safe creator path from the directory branch. The conflict resolution also carries these review fixes for the profile page:

- bio accepts up to 5000 characters, the cloud limit.
- Card reads map a site locale that the cards endpoint does not serve (ja) to en, so /ja/hub pages no longer return 503.
- Website links are https only.
- The username limit is 30 characters for both the profile read and the author filter, and a username that is not a valid creator name never reaches the catalog URL.
- loadCreatorPage() returns the lowercase redirect, and the route renders the 404 page or 503 from its answer.
- creatorEntityId() lives in creator-path.ts as the one creator id builder, with an encoded lowercase username.
- CreatorProfileHeader.vue holds the header, with rel noopener noreferrer nofollow ugc, and has a server-render test.
- Load more shows a status message when a read does not succeed, and a test covers a repeated card.
- The ja locale has the profile keys.
@datadog-official

datadog-official Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Pipelines

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c9b171c | Docs | View more details | Give us feedback!

@MaanilVerma
MaanilVerma marked this pull request as ready for review October 22, 2026 02:37
@MaanilVerma
MaanilVerma requested review from a team and dante01yoon as code owners October 22, 2026 02:37
@MaanilVerma
MaanilVerma requested review from benjcooley and removed request for a team and dante01yoon October 22, 2026 02:37

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blockers. Two Load more bugs are worth fixing before merge; the rest is minor. I checked the backend side against cloud #14830 (b43904ff).

Severity Count
BLOCKER 0
SHOULD FIX 2
TRIVIAL 3

SHOULD FIX

  • CreatorWorkflowGrid.vue: Load more ignores reset. After the 5-min cursor expiry or a publish, a click silently adds nothing (inline).
  • catalog-creators.ts:150: SSR and Load more send different-case author. The cloud cursor binding is exact-string, so Load more always fails for a mixed-case stored username. This is latent today because the admin writer forces lowercase (inline, one-line suggestion).

TRIVIAL

  • The stale failed message stays visible during a retry (inline).
  • There's no route test for 301/404/503 in profile.astro (inline).
  • The profile and cards reads run one after the other and could run in parallel (catalog-creators.ts:140-153).

Corrections to the PR description

  • The "staff preview can show cards by other authors" WARNING doesn't hold. In cloud #14830, /admin/api/site/catalog/cards goes through the same CCCWebsiteCardsQuery middleware, the same cccWebsiteCardsRequest and the same SQL as the public endpoint, and ingest's openapi declares author on both.
  • Owner question: 30 is the right limit. content_profiles.username is varchar(30), and SaveProfile validates against 30. #21551 should use isCreatorUsername().
  • The noWorkflows/noindex branch is close to unreachable for anonymous visitors, because cloud 404s a creator with no Live public workflow.

FYI, pre-existing and not in this diff: middleware.ts isCatalogBrowseRequest matches /hub/ and /zh-CN/hub/ but not /ja/hub/. On /ja/hub/creators/x/, staff get a public SSR page while Load more uses the staff session. The cursor binding's Staff flag then differs, so Load more fails with a 400. Staff only.

The review was done by reading code against both repos. I ran no tests or tooling.

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review at a0b4882. The only new commit is a merge of maanil/ccc-creator-pages. The PR's own diff is byte-identical to a7b8399 apart from the locale JSON hunk offsets, so none of the four earlier threads are addressed. Each one now has a reply.

Severity Open
BLOCKER 0
SHOULD FIX 2
TRIVIAL 2
  • SHOULD FIX: CreatorWorkflowGrid.vue still ignores pages.workflows.reset, so after the 5-minute cursor expiry or a publish, Load more silently does nothing.
  • SHOULD FIX (latent): catalog-creators.ts:150 still sends a different-case author from the grid. There is a one-line suggestion on the thread.
  • TRIVIAL: the stale failed message, and no route test for profile.astro.

I checked the merged base changes for anything that interacts with this PR and found nothing:

  • The regenerated zListCccWebsiteCardsQuery.locale is still enum().optional().default(), so the CARD_LOCALES unwrap chain still holds.
  • BaseLayout's new ogImages keeps ogImage/ogImageAlt as the fallback.
  • The new redirects don't touch /hub/creators.

If the fixes are on a local branch, they haven't been pushed.

@codecov

codecov Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.59091% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
apps/website/src/lib/cms/catalog-creators.ts 92.30% 0 Missing and 2 partials ⚠️
...website/src/components/hub/CreatorWorkflowGrid.vue 96.29% 0 Missing and 1 partial ⚠️
@@                     Coverage Diff                      @@
##           maanil/ccc-creator-pages   #21564      +/-   ##
============================================================
- Coverage                     86.34%   85.21%   -1.14%     
============================================================
  Files                          3927     3992      +65     
  Lines                        181412   186411    +4999     
  Branches                      47677    47606      -71     
============================================================
+ Hits                         156644   158848    +2204     
- Misses                        22214    25195    +2981     
+ Partials                       2554     2368     -186     
Flag Coverage Δ
website-unit 80.79% <96.59%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ebsite/src/components/hub/CreatorProfileHeader.vue 100.00% <100.00%> (ø)
apps/website/src/components/hub/LoadMoreButton.vue 100.00% <100.00%> (ø)
apps/website/src/components/hub/WorkflowGrid.vue 84.44% <100.00%> (ø)
.../website/src/integrations/workshop-release-gate.ts 96.05% <ø> (ø)
apps/website/src/lib/cms/catalog-list.ts 87.80% <100.00%> (+0.62%) ⬆️
apps/website/src/lib/hub/creator-path.ts 100.00% <100.00%> (ø)
apps/website/src/lib/hub/creators.ts 100.00% <100.00%> (ø)
...website/src/lib/workshop/model-meta-description.ts 97.56% <ø> (ø)
apps/website/src/utils/jsonLd.ts 96.10% <ø> (ø)
...website/src/components/hub/CreatorWorkflowGrid.vue 96.29% <96.29%> (ø)
... and 1 more

... and 850 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MaanilVerma

Copy link
Copy Markdown
Collaborator Author

Replies to the review body. The inline threads have the fixes.

  • Parallel reads: done in b16276841e, together with the one-author fix.
  • Username limit: the code keeps 30 (CREATOR_USERNAME_MAX). Maanil has not confirmed it yet.
  • PR body corrections (the staff-preview WARNING and the noWorkflows/noindex note): I did not edit the PR body. Maanil owns it.
  • /ja/hub/ in isCatalogBrowseRequest: I confirmed it in the code. src/middleware.ts:88 matches ^\/(?:zh-CN\/)?hub\/ only. It is not in this diff, so I did not change it here. I gave it to Maanil as a follow-up.
  • Also in 31963f3c58: the profile page "Hub" breadcrumb now has the locale prefix, the same fix as feat(website): add the Hub creators directory from the catalog #21561.

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review of 83ea045..31963f3. The base merge is clean: no PR lines changed. All four earlier threads are fixed with tests that fail on revert, so I've resolved them.

  • Reset (4d0fac9): the grid replaces its cards, takes the fresh cursor, and sends p from the server's page, as CccModelsPage does.
  • Stale error (4d0fac9): cleared before the fetch, and the test holds the retry open to check it.
  • Author case (b162768): the server render and Load more both send the lowercased username. Cloud's profile lookup and author filter both use lower(), so they resolve the same account and the cursor binding matches.
  • Route test (31963f3): the mapping now lives in creatorPageResponse/creatorPageStatus with table tests. Middleware treats the hand-built 301 the same as Astro.redirect.
  • Breadcrumb: the locale-prefixed /hub/models target is injected for ja and zh-CN.
Severity New
BLOCKER 0
SHOULD FIX 0
TRIVIAL 1

One non-blocking note is inline. This review comes from reading the code against cloud #14830; I didn't run the tests.

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review of c9b171c. The profile read now runs first, and a 404 returns missing with no cards query. author still comes from the lowercased route username, so the cursor-binding fix from b162768 holds. The new test asserts a single fetch for an unknown creator, so it fails if Promise.all returns. A non-404 profile failure now returns 503 without the extra cards read. I've resolved the thread. No new findings. I read the code but didn't run the tests.

@MaanilVerma

Copy link
Copy Markdown
Collaborator Author

Moved to Comfy-Org/comfy-website#28 (the website now lives there). This PR stays open for its review history.

@MaanilVerma

Copy link
Copy Markdown
Collaborator Author

Closing: the website moved; this change lives in Comfy-Org/comfy-website#28.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants