Repository navigation
feat(website): add Hub creator profile pages from the catalog - #21564
MaanilVerma wants to merge 9 commits into
Conversation
In CMS mode, /hub/creators/<username>/ shows the creator profile and their public workflow cards, with Load more for the next cursor pages. A mixed-case URL redirects to the lowercase one, an unknown username renders the 404 page, and a creator with no workflows is noindex. The creator JSON-LD id is the English profile URL with #creator, the same id that workflow pages use for their author.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 077e46751808e8452d6a3743776023cac9a5dd11
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (132)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog 🌐 Website E2ETip All tests passed. Test results
🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-21564.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. Deployment detailsThis commit: https://website-frontend-80o7ym116-comfyui.vercel.app Last updated: 2026-10-21T19:33:07Z for |
QA: Hub creator profile pages from the catalogI ran
13 pass, 0 fail, 0 escalated, 1 inconclusive. 75 unit tests pass on this branch. Not covered here: the real cloud #14830 build. It is not deployed to an environment I can reach, so a mock with the same contract served the data (inconclusive). |
The merge takes the shared catalog read, the cursor walk and the client-safe creator path from the directory branch. The conflict resolution also carries these review fixes for the profile page: - bio accepts up to 5000 characters, the cloud limit. - Card reads map a site locale that the cards endpoint does not serve (ja) to en, so /ja/hub pages no longer return 503. - Website links are https only. - The username limit is 30 characters for both the profile read and the author filter, and a username that is not a valid creator name never reaches the catalog URL. - loadCreatorPage() returns the lowercase redirect, and the route renders the 404 page or 503 from its answer. - creatorEntityId() lives in creator-path.ts as the one creator id builder, with an encoded lowercase username. - CreatorProfileHeader.vue holds the header, with rel noopener noreferrer nofollow ugc, and has a server-render test. - Load more shows a status message when a read does not succeed, and a test covers a repeated card. - The ja locale has the profile keys.
|
🔗 Commit SHA: c9b171c | Docs | View more details | Give us feedback! |
benjcooley
left a comment
There was a problem hiding this comment.
No blockers. Two Load more bugs are worth fixing before merge; the rest is minor. I checked the backend side against cloud #14830 (b43904ff).
| Severity | Count |
|---|---|
| BLOCKER | 0 |
| SHOULD FIX | 2 |
| TRIVIAL | 3 |
SHOULD FIX
CreatorWorkflowGrid.vue: Load more ignoresreset. After the 5-min cursor expiry or a publish, a click silently adds nothing (inline).catalog-creators.ts:150: SSR and Load more send different-caseauthor. The cloud cursor binding is exact-string, so Load more always fails for a mixed-case stored username. This is latent today because the admin writer forces lowercase (inline, one-line suggestion).
TRIVIAL
- The stale
failedmessage stays visible during a retry (inline). - There's no route test for 301/404/503 in
profile.astro(inline). - The profile and cards reads run one after the other and could run in parallel (
catalog-creators.ts:140-153).
Corrections to the PR description
- The "staff preview can show cards by other authors" WARNING doesn't hold. In cloud #14830,
/admin/api/site/catalog/cardsgoes through the sameCCCWebsiteCardsQuerymiddleware, the samecccWebsiteCardsRequestand the same SQL as the public endpoint, and ingest's openapi declaresauthoron both. - Owner question: 30 is the right limit.
content_profiles.usernameisvarchar(30), andSaveProfilevalidates against 30. #21551 should useisCreatorUsername(). - The
noWorkflows/noindexbranch is close to unreachable for anonymous visitors, because cloud 404s a creator with no Live public workflow.
FYI, pre-existing and not in this diff: middleware.ts isCatalogBrowseRequest matches /hub/ and /zh-CN/hub/ but not /ja/hub/. On /ja/hub/creators/x/, staff get a public SSR page while Load more uses the staff session. The cursor binding's Staff flag then differs, so Load more fails with a 400. Staff only.
The review was done by reading code against both repos. I ran no tests or tooling.
benjcooley
left a comment
There was a problem hiding this comment.
Re-review at a0b4882. The only new commit is a merge of maanil/ccc-creator-pages. The PR's own diff is byte-identical to a7b8399 apart from the locale JSON hunk offsets, so none of the four earlier threads are addressed. Each one now has a reply.
| Severity | Open |
|---|---|
| BLOCKER | 0 |
| SHOULD FIX | 2 |
| TRIVIAL | 2 |
- SHOULD FIX:
CreatorWorkflowGrid.vuestill ignorespages.workflows.reset, so after the 5-minute cursor expiry or a publish, Load more silently does nothing. - SHOULD FIX (latent):
catalog-creators.ts:150still sends a different-caseauthorfrom the grid. There is a one-line suggestion on the thread. - TRIVIAL: the stale
failedmessage, and no route test forprofile.astro.
I checked the merged base changes for anything that interacts with this PR and found nothing:
- The regenerated
zListCccWebsiteCardsQuery.localeis stillenum().optional().default(), so theCARD_LOCALESunwrap chain still holds. BaseLayout's newogImageskeepsogImage/ogImageAltas the fallback.- The new redirects don't touch
/hub/creators.
If the fixes are on a local branch, they haven't been pushed.
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## maanil/ccc-creator-pages #21564 +/- ##
============================================================
- Coverage 86.34% 85.21% -1.14%
============================================================
Files 3927 3992 +65
Lines 181412 186411 +4999
Branches 47677 47606 -71
============================================================
+ Hits 156644 158848 +2204
- Misses 22214 25195 +2981
+ Partials 2554 2368 -186
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 850 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…2/ccc-creator-profile
…le error, and sends one author
…e old error before a retry
…wers, and localize its Hub breadcrumb
|
Replies to the review body. The inline threads have the fixes.
|
benjcooley
left a comment
There was a problem hiding this comment.
Re-review of 83ea045..31963f3. The base merge is clean: no PR lines changed. All four earlier threads are fixed with tests that fail on revert, so I've resolved them.
- Reset (
4d0fac9): the grid replaces its cards, takes the fresh cursor, and sendspfrom the server's page, asCccModelsPagedoes. - Stale error (
4d0fac9): cleared before the fetch, and the test holds the retry open to check it. - Author case (
b162768): the server render and Load more both send the lowercased username. Cloud's profile lookup and author filter both uselower(), so they resolve the same account and the cursor binding matches. - Route test (
31963f3): the mapping now lives increatorPageResponse/creatorPageStatuswith table tests. Middleware treats the hand-built 301 the same asAstro.redirect. - Breadcrumb: the locale-prefixed
/hub/modelstarget is injected forjaandzh-CN.
| Severity | New |
|---|---|
| BLOCKER | 0 |
| SHOULD FIX | 0 |
| TRIVIAL | 1 |
One non-blocking note is inline. This review comes from reading the code against cloud #14830; I didn't run the tests.
benjcooley
left a comment
There was a problem hiding this comment.
Re-review of c9b171c. The profile read now runs first, and a 404 returns missing with no cards query. author still comes from the lowercased route username, so the cursor-binding fix from b162768 holds. The new test asserts a single fetch for an unknown creator, so it fails if Promise.all returns. A non-404 profile failure now returns 503 without the extra cards read. I've resolved the thread. No new findings. I read the code but didn't run the tests.
|
Moved to Comfy-Org/comfy-website#28 (the website now lives there). This PR stays open for its review history. |
|
Closing: the website moved; this change lives in Comfy-Org/comfy-website#28. |






Summary
In CMS mode,
/hub/creators/<username>/now shows a creator's profile and their public workflow cards from the content catalog, with Load more for the next pages. The layout is the same as the closed #21457. A mixed-case URL redirects to the lowercase one, an unknown username returns the site 404 page, and a creator with no public workflows isnoindex.Changes
Data:
loadCatalogCreator()inlib/cms/catalog-creators.tsreadsGET /api/v1/catalog/creators/{username}, returnsmissingon 404 andunavailableon other errors, keeps onlyhttpslinks, and accepts a bio of up to 5000 characters.isCreatorUsername()rejects (more than 30 characters, or anything other than letters, digits and inner hyphens, such as..) ismissingwith no catalog read.loadCreatorPage()returns the 301 target for a mixed-case username before any read.loadSiteCatalogList()withauthor=<username>, so the staff Draft preview session applies as on the other Hub lists.cardQuery()inlib/cms/catalog-list.tsnow passes anauthorfilter (1 to 30 characters) to the cards endpoint and to/models/catalogue.json.cardQuery()now sendslocale=enfor a site locale that the cards endpoint does not serve. Before this, every/ja/hub/...card page on feat(website): Comfy Content Catalog Hub CMS (supersedes #20640, #20933) #21204 returned 503, because the request did not passzListCccWebsiteCardsQuery. The fix is at this shared point, so it also fixes/ja/hub/workflows/and/ja/hub/apps/.Page:
routes/hub/creators/profile.astromaps theloadCreatorPage()answer to a 301, thepages/404.astropage with status 404, or 503.components/hub/CreatorProfile.astroholds the page layout, andCreatorProfileHeader.vuerenders the avatar, name,@username, bio and website links (rel="noopener noreferrer nofollow ugc").CreatorWorkflowGrid.vueshowsWorkshopModelCardcards and, on Load more, reads the next cursor page from/models/catalogue.json?section=workflows&format=page&author=.... A failed read keeps the button and shows a status message, a second click during a read does nothing, and a card that a later page repeats shows once.LoadMoreButton.vueis shared withWorkflowGrid.vue, which now uses it with no change in behavior.Structured data:
ProfilePagewith aPersonnode (Organizationforcomfyui), anItemListof the first page of workflows, and breadcrumbs.creatorEntityId()inlib/hub/creator-path.tsnames the creatorhttps://comfy.org/hub/creators/<lowercase username>/#creatoron every locale, the same@idthat feat(website): give CCC workflow pages their own structured data and meta #21551 writes for the workflow author. It encodes the username. Note for feat(website): give CCC workflow pages their own structured data and meta #21551: build the author@idwith this function, and validate withisCreatorUsername()(30 characters, the cloud limit) in place of the 42-charactervalidCreatorUsername(). Owner question: confirm 30 or 42 as the username limit.en,zh-CNandja.QA Focus
pnpm exec vitest run src/lib/cms/catalog-creators.test.ts src/lib/hub/creators.test.ts src/components/hub/CreatorWorkflowGrid.test.ts src/integrations/workshop-release-gate.test.ts src/lib/cms/catalog-list.test.ts src/components/hub/HubBrowse.test.tsinapps/website. Expected: all pass. Author: tested, 104 pass withCreatorProfileHeader.ssr.test.ts,creator-path.test.tsand thefetchDetail()callers. Before the change, these files did not pass because the modules did not exist. For the review fixes, I reverted each fix and saw 6 tests not pass (bio length, http link,..,../admin, a 31-character username), and thejacard locale and Load more status tests did not pass before their fixes.pnpm typecheck:website,pnpm knipand eslint on the changed files. Expected: no errors. Author: tested, 0 errors.astro dev, open/hub/creators/purz/(30 workflows) and click Load more. Expected: 24 cards, then 30 cards and no button. Author: tested with Playwright, see the QA comment./hub/creators/PurZ/,/hub/creators/ghost/and a creator with no workflows. Expected: a 301 to/hub/creators/purz/, a 404 page, and anoindexpage with an empty message. Author: tested with Playwright.Risky areas
lib/cms/catalog-list.tsis shared by every CCC list. The newauthorkey is optional and is sent only when the request has it./admin/api/site/catalog/cardswithauthor. Cloud feat: add persistent generated asset media tabs #14830 adds the filter to the public cards endpoint only. I did not test the admin endpoint, so a staff preview can show cards by other authors.CreatorProfile.astrouses the first card page for theItemList, so a creator with more than 24 workflows lists only 24 in JSON-LD.PR dependency map
main(base)main)Contract provider: cloud #14830 (draft) serves the profile read and the
authorcard filter. UI source: the closed #21456 and #21457. #21551 writes the same creator@idon workflow pages. Merge #21204, #21561 and cloud #14830 before this PR.