Skip to content

feat(website): add the Hub creators directory from the catalog - #21561

Closed
MaanilVerma wants to merge 11 commits into
work/ccc-mar-integration-20261014from
maanil/ccc-creator-pages
Closed

MaanilVerma wants to merge 11 commits into
work/ccc-mar-integration-20261014from
maanil/ccc-creator-pages

Conversation

@MaanilVerma

@MaanilVerma MaanilVerma commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

In CMS mode, /hub/creators/ now lists the creators that have public workflows in the content catalog. It is the directory half of the creator pages. The profile pages come in the next PR of this stack. The UI is the same as the closed #21456, and the data comes from the catalog instead of a snapshot file.

Changes

Data:

  • loadCatalogCreators() in lib/cms/catalog-creators.ts reads GET /api/v1/catalog/creators?limit=100&cursor= page by page (at most 20 pages) and returns 503 on a server error, a body that does not match, a repeated cursor, or the page cap.
  • The loader uses the shared fetchCatalogJson() in lib/cms/catalog.ts (now also used by fetchDetail()) and the shared everyCursorPage() in lib/cms/catalog-list-all.ts (now also used by loadEverySiteCatalogCard()).
  • The loader merges usernames that differ only in case into one lowercase entry, adds their workflow counts, and sorts the busiest creators first.
  • hubAvatarUrl() in lib/hub/creators.ts first applies validAuthorAvatarURL(), the same avatar rule as the workflow author, then keeps only comfy-hub-assets.comfy.org and requests a 400px resize. Other avatars show the initial letter, and CreatorAvatar sends no referrer.

Page and routing:

  • routes/hub/creators/index.astro renders the directory with CreatorAvatar, a CollectionPage breadcrumb and an ItemList JSON-LD node. When no creator has public workflows, it shows a sentence in place of the list.
  • workshop-release-gate.ts injects /hub/creators (and its /zh-CN and /ja twins) as an on-demand route only when cmsEnabled() is true. A production build has no creator route.
  • hubCreatorPath() in lib/hub/creator-path.ts builds /hub/creators/<lowercase, encoded username>/ with the catalog locale prefix. The module imports only the locale prefix, so browser code can use it. I did not change hubCreatorUrl in lib/hub/routes.ts, because R2 changes it on main.
  • config/routes.ts marks /hub/creators as locale-invariant, the same as /hub/workflows, so the sitemap does not list a zh-CN twin.
  • knip.config.ts adds src/routes/hub/creators/*.astro as entries, because the integration registers them and Astro does not discover them.
  • New copy is in en, zh-CN and ja under workshop.hub.creators.

QA Focus

  • Run pnpm exec vitest run src/lib/cms/catalog-creators.test.ts src/lib/hub/creators.test.ts src/integrations/workshop-release-gate.test.ts in apps/website. Expected: all pass. Author: tested, 44 pass in these and the fetchDetail() and loadEverySiteCatalogCard() callers' tests. Before the change, the same files did not pass (modules missing, and the route assertion returned false).
  • Run pnpm typecheck:website, pnpm knip and eslint on the changed files. Expected: no errors. Author: tested, 0 errors.
  • Start a catalog mock with the P1 endpoints, run astro dev with SITE_CATALOG_API_URL set, and open /hub/creators/ at 1440px and 390px. Expected: one card per creator, hellorob and HelloRob show as one card with 2 workflows. Author: tested, see the QA comment.
  • Open /hub/creators/ on a production build. Expected: 404. Author: tested by the release-gate unit test only.
  • Open /hub/creators/ against the real cloud P1 build. Author: not tested, because cloud feat: add persistent generated asset media tabs #14830 is not deployed to an environment this machine can reach.

Risky areas

  • loadCatalogCreators() reads every directory page on each request, so a large catalog means up to 20 sequential calls per page view. Today the catalog has about 15 creators. A paged directory with Load more is the next step if this grows.
  • workshop-release-gate.ts is shared route setup for every Hub page. The change adds one list and touches no existing route.
  • The page depends on the cloud feat: add persistent generated asset media tabs #14830 contract. All field names are in lib/cms/catalog-creators.ts, so a rename changes one file.

PR dependency map

  1. main (base)
  2. feat(website): Comfy Content Catalog Hub CMS (supersedes #20640, #20933) #21204 feat(website): Comfy Content Catalog Hub CMS (draft, targets main)
  3. this PR, feat(website): add the Hub creators directory from the catalog (draft, targets feat(website): Comfy Content Catalog Hub CMS (supersedes #20640, #20933) #21204)
  4. feat(website): add Hub creator profile pages from the catalog #21564 feat(website): add Hub creator profile pages from the catalog (draft, targets this PR)
  5. feat(website): link CCC workflow authors to their creator page #21570 feat(website): link CCC workflow authors to their creator page (draft, targets feat(website): add Hub creator profile pages from the catalog #21564)

Contract provider: cloud #14830 (draft) serves GET /api/v1/catalog/creators. UI source: the closed #21456 and #21457. #21551 writes the matching creator @id on workflow pages. Merge #21204 and cloud #14830 before this PR.

In CMS mode, /hub/creators/ lists the creators that have public workflows. The page reads the catalog creators endpoint page by page, merges usernames that differ only in case, and links each creator to a lowercase profile URL. It keeps only avatars on the Hub assets host.
@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

❌ 8 scenarios below the ≥52 P5 FPS target. Expand the scenario timings below and profile the affected scenarios before merging.

Scenario timings

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 95.7 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 100.1 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 105.5 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 109.6 MB heap
dom-widget-order-dense-n200-w200-i120: · 37.9 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 285ms TBT · 107.4 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 48.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 92ms TBT · 99.8 MB heap
extension-clean-combined-draw: · 46.0 avg FPS · 29.9 P5 FPS ❌ (target: ≥52) · 46ms TBT · 107.0 MB heap
extension-rgthree-prototype-draw: · 46.2 avg FPS · 29.9 P5 FPS ❌ (target: ≥52) · 60ms TBT · 119.7 MB heap
large-combo-open: · 48.0 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 110.5 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 107.8 MB heap
large-graph-pan: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 105.9 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 101.9 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 114.6 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 111.5 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 107.6 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 98.3 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 94.5 MB heap
subgraph-transition-enter: · 50.8 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 84ms TBT · 121.2 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 108.6 MB heap
vue-large-graph-idle: · 33.3 avg FPS · 17.1 P5 FPS ❌ (target: ≥52) · 0ms TBT · 292.0 MB heap
vue-large-graph-pan: · 28.2 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 15ms TBT · 280.8 MB heap
vue-node-resize-workload: · 28.9 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 285.6 MB heap
vue-zoom-out-idle: · 34.4 avg FPS · 17.1 P5 FPS ❌ (target: ≥52) · 0ms TBT · 285.1 MB heap
workflow-execution: · 56.0 avg FPS · 39.9 P5 FPS ❌ (target: ≥52) · 0ms TBT · 107.3 MB heap
agent-composer-empty-conversation-typing: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 96.3 MB heap
agent-composer-long-conversation-typing: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 116.9 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 3ms
canvas-idle: style recalc duration 3ms
canvas-idle: layout count 10
canvas-idle: style recalc count 10
canvas-idle: task duration 363ms
canvas-idle: script duration 9ms
canvas-idle: TBT 0ms
canvas-idle: heap used 95.7 MB
canvas-idle: DOM nodes -182
canvas-idle: event listeners -130
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 2ms
canvas-mouse-sweep: style recalc duration 15ms
canvas-mouse-sweep: layout count 10
canvas-mouse-sweep: style recalc count 78
canvas-mouse-sweep: task duration 827ms
canvas-mouse-sweep: script duration 125ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 100.1 MB
canvas-mouse-sweep: DOM nodes -182
canvas-mouse-sweep: event listeners -130
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 3ms
canvas-zoom-sweep: style recalc duration 5ms
canvas-zoom-sweep: layout count 11
canvas-zoom-sweep: style recalc count 18
canvas-zoom-sweep: task duration 288ms
canvas-zoom-sweep: script duration 12ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 105.5 MB
canvas-zoom-sweep: DOM nodes 56
canvas-zoom-sweep: event listeners 43
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 3ms
dom-widget-clipping: style recalc duration 3ms
dom-widget-clipping: layout count 10
dom-widget-clipping: style recalc count 15
dom-widget-clipping: task duration 338ms
dom-widget-clipping: script duration 114ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 109.6 MB
dom-widget-clipping: DOM nodes 0
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 26ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 547ms
dom-widget-order-dense-n200-w200-i120: script duration 39ms
dom-widget-order-dense-n200-w200-i120: TBT 285ms
dom-widget-order-dense-n200-w200-i120: heap used 107.4 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes -116
dom-widget-order-dense-n200-w200-i120: event listeners -84
dom-widget-order-sparse-n1000-w20-i120: avg frame time 21ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 295ms
dom-widget-order-sparse-n1000-w20-i120: script duration 95ms
dom-widget-order-sparse-n1000-w20-i120: TBT 92ms
dom-widget-order-sparse-n1000-w20-i120: heap used 99.8 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 22ms
extension-clean-combined-draw: p95 frame time 33ms
extension-clean-combined-draw: layout duration 1ms
extension-clean-combined-draw: style recalc duration 1ms
extension-clean-combined-draw: layout count 3
extension-clean-combined-draw: style recalc count 3
extension-clean-combined-draw: task duration 5575ms
extension-clean-combined-draw: script duration 4194ms
extension-clean-combined-draw: TBT 46ms
extension-clean-combined-draw: heap used 107.0 MB
extension-clean-combined-draw: DOM nodes -278
extension-clean-combined-draw: event listeners -130
extension-rgthree-prototype-draw: avg frame time 22ms
extension-rgthree-prototype-draw: p95 frame time 33ms
extension-rgthree-prototype-draw: layout duration 1ms
extension-rgthree-prototype-draw: style recalc duration 1ms
extension-rgthree-prototype-draw: layout count 3
extension-rgthree-prototype-draw: style recalc count 3
extension-rgthree-prototype-draw: task duration 5528ms
extension-rgthree-prototype-draw: script duration 4297ms
extension-rgthree-prototype-draw: TBT 60ms
extension-rgthree-prototype-draw: heap used 119.7 MB
extension-rgthree-prototype-draw: DOM nodes -288
extension-rgthree-prototype-draw: event listeners -130
large-combo-open: avg frame time 21ms
large-combo-open: p95 frame time 50ms
large-combo-open: layout duration 3ms
large-combo-open: style recalc duration 13ms
large-combo-open: layout count 12
large-combo-open: style recalc count 22
large-combo-open: task duration 129ms
large-combo-open: script duration 6ms
large-combo-open: TBT 0ms
large-combo-open: heap used 110.5 MB
large-combo-open: DOM nodes 936
large-combo-open: event listeners 205
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 2ms
large-graph-idle: style recalc duration 2ms
large-graph-idle: layout count 9
large-graph-idle: style recalc count 9
large-graph-idle: task duration 449ms
large-graph-idle: script duration 30ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 107.8 MB
large-graph-idle: DOM nodes -288
large-graph-idle: event listeners -130
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 2ms
large-graph-pan: style recalc duration 11ms
large-graph-pan: layout count 8
large-graph-pan: style recalc count 70
large-graph-pan: task duration 1265ms
large-graph-pan: script duration 596ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 105.9 MB
large-graph-pan: DOM nodes -298
large-graph-pan: event listeners -128
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 14ms
large-graph-zoom: style recalc duration 13ms
large-graph-zoom: layout count 67
large-graph-zoom: style recalc count 73
large-graph-zoom: task duration 1376ms
large-graph-zoom: script duration 574ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 101.9 MB
large-graph-zoom: DOM nodes -264
large-graph-zoom: event listeners -130
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 2ms
legacy-node-drag: style recalc duration 7ms
legacy-node-drag: layout count 7
legacy-node-drag: style recalc count 46
legacy-node-drag: task duration 1471ms
legacy-node-drag: script duration 709ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 114.6 MB
legacy-node-drag: DOM nodes -149
legacy-node-drag: event listeners 116
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 2ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 9
minimap-idle: style recalc count 9
minimap-idle: task duration 457ms
minimap-idle: script duration 32ms
minimap-idle: TBT 0ms
minimap-idle: heap used 111.5 MB
minimap-idle: DOM nodes -288
minimap-idle: event listeners -130
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 3ms
subgraph-dom-widget-clipping: style recalc duration 6ms
subgraph-dom-widget-clipping: layout count 10
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 326ms
subgraph-dom-widget-clipping: script duration 106ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 107.6 MB
subgraph-dom-widget-clipping: DOM nodes 0
subgraph-dom-widget-clipping: event listeners 46
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 3ms
subgraph-idle: style recalc duration 3ms
subgraph-idle: layout count 10
subgraph-idle: style recalc count 11
subgraph-idle: task duration 348ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 98.3 MB
subgraph-idle: DOM nodes -220
subgraph-idle: event listeners -176
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 2ms
subgraph-mouse-sweep: style recalc duration 14ms
subgraph-mouse-sweep: layout count 10
subgraph-mouse-sweep: style recalc count 76
subgraph-mouse-sweep: task duration 664ms
subgraph-mouse-sweep: script duration 91ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 94.5 MB
subgraph-mouse-sweep: DOM nodes -202
subgraph-mouse-sweep: event listeners -174
subgraph-transition-enter: avg frame time 20ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 10ms
subgraph-transition-enter: style recalc duration 17ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 677ms
subgraph-transition-enter: script duration 21ms
subgraph-transition-enter: TBT 84ms
subgraph-transition-enter: heap used 121.2 MB
subgraph-transition-enter: DOM nodes 16030
subgraph-transition-enter: event listeners 3244
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 2ms
viewport-pan-sweep: style recalc duration 39ms
viewport-pan-sweep: layout count 9
viewport-pan-sweep: style recalc count 251
viewport-pan-sweep: task duration 4522ms
viewport-pan-sweep: script duration 2045ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 108.6 MB
viewport-pan-sweep: DOM nodes -278
viewport-pan-sweep: event listeners -128
vue-large-graph-idle: avg frame time 30ms
vue-large-graph-idle: p95 frame time 58ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16396ms
vue-large-graph-idle: script duration 238ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 292.0 MB
vue-large-graph-idle: DOM nodes -3343
vue-large-graph-idle: event listeners -653
vue-large-graph-pan: avg frame time 35ms
vue-large-graph-pan: p95 frame time 67ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 19ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 140
vue-large-graph-pan: task duration 18524ms
vue-large-graph-pan: script duration 687ms
vue-large-graph-pan: TBT 15ms
vue-large-graph-pan: heap used 280.8 MB
vue-large-graph-pan: DOM nodes -3343
vue-large-graph-pan: event listeners -651
vue-node-resize-workload: avg frame time 35ms
vue-node-resize-workload: p95 frame time 67ms
vue-node-resize-workload: layout duration 31ms
vue-node-resize-workload: style recalc duration 51ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 5908ms
vue-node-resize-workload: script duration 91ms
vue-node-resize-workload: TBT 0ms
vue-node-resize-workload: heap used 285.6 MB
vue-node-resize-workload: DOM nodes -3343
vue-node-resize-workload: event listeners -653
vue-zoom-out-idle: avg frame time 29ms
vue-zoom-out-idle: p95 frame time 58ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 7968ms
vue-zoom-out-idle: script duration 110ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 285.1 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners 0
workflow-execution: avg frame time 18ms
workflow-execution: p95 frame time 25ms
workflow-execution: layout duration 3ms
workflow-execution: style recalc duration 10ms
workflow-execution: layout count 7
workflow-execution: style recalc count 9
workflow-execution: task duration 80ms
workflow-execution: script duration 8ms
workflow-execution: TBT 0ms
workflow-execution: heap used 107.3 MB
workflow-execution: DOM nodes 116
workflow-execution: event listeners 6
agent-composer-empty-conversation-typing: avg frame time 17ms
agent-composer-empty-conversation-typing: p95 frame time 17ms
agent-composer-empty-conversation-typing: layout duration 13ms
agent-composer-empty-conversation-typing: style recalc duration 1ms
agent-composer-empty-conversation-typing: layout count 76
agent-composer-empty-conversation-typing: style recalc count 5
agent-composer-empty-conversation-typing: task duration 211ms
agent-composer-empty-conversation-typing: script duration 92ms
agent-composer-empty-conversation-typing: TBT 0ms
agent-composer-empty-conversation-typing: heap used 96.3 MB
agent-composer-empty-conversation-typing: DOM nodes 4
agent-composer-empty-conversation-typing: event listeners 292
agent-composer-long-conversation-typing: avg frame time 17ms
agent-composer-long-conversation-typing: p95 frame time 17ms
agent-composer-long-conversation-typing: layout duration 13ms
agent-composer-long-conversation-typing: style recalc duration 2ms
agent-composer-long-conversation-typing: layout count 76
agent-composer-long-conversation-typing: style recalc count 5
agent-composer-long-conversation-typing: task duration 271ms
agent-composer-long-conversation-typing: script duration 93ms
agent-composer-long-conversation-typing: TBT 0ms
agent-composer-long-conversation-typing: heap used 116.9 MB
agent-composer-long-conversation-typing: DOM nodes 4
agent-composer-long-conversation-typing: event listeners 292
Raw data
{
  "timestamp": "2026-10-22T06:19:55.366Z",
  "gitSha": "7d82cf9a975b244bdf3514e35e7cba6b09de27ae",
  "branch": "maanil/ccc-creator-pages",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2008.4159999999827,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 3.391,
      "layouts": 10,
      "layoutDurationMs": 2.974999999999999,
      "taskDurationMs": 337.13000000000005,
      "heapDeltaBytes": -4893708,
      "heapUsedBytes": 105823312,
      "domNodes": -182,
      "jsHeapTotalBytes": 2629632,
      "scriptDurationMs": 10.033999999999999,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66611570247934,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2008.1570000000397,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 3.3030000000000004,
      "layouts": 10,
      "layoutDurationMs": 2.895,
      "taskDurationMs": 389.536,
      "heapDeltaBytes": -15320028,
      "heapUsedBytes": 94977028,
      "domNodes": -182,
      "jsHeapTotalBytes": 2551808,
      "scriptDurationMs": 8.584999999999999,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66528925619835,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1728.3739999999739,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 14.052999999999999,
      "layouts": 9,
      "layoutDurationMs": 2.191,
      "taskDurationMs": 700.225,
      "heapDeltaBytes": -8128648,
      "heapUsedBytes": 100807256,
      "domNodes": -182,
      "jsHeapTotalBytes": 1368064,
      "scriptDurationMs": 120.95400000000001,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665384615384617,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2011.6620000000012,
      "styleRecalcs": 84,
      "styleRecalcDurationMs": 15.264999999999999,
      "layouts": 10,
      "layoutDurationMs": 2.7150000000000003,
      "taskDurationMs": 953.152,
      "heapDeltaBytes": 2016624,
      "heapUsedBytes": 109068124,
      "domNodes": -182,
      "jsHeapTotalBytes": 2678784,
      "scriptDurationMs": 129.576,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66611570247934,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1725.7089999999948,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 5.423000000000001,
      "layouts": 11,
      "layoutDurationMs": 3.267,
      "taskDurationMs": 319.832,
      "heapDeltaBytes": 546708,
      "heapUsedBytes": 108829676,
      "domNodes": 56,
      "jsHeapTotalBytes": 9437184,
      "scriptDurationMs": 14.076,
      "eventListeners": 43,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666346153846156,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1709.416000000033,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 4.957,
      "layouts": 11,
      "layoutDurationMs": 2.895,
      "taskDurationMs": 256.284,
      "heapDeltaBytes": 2509568,
      "heapUsedBytes": 112331164,
      "domNodes": 56,
      "jsHeapTotalBytes": 10485760,
      "scriptDurationMs": 9.571,
      "eventListeners": 43,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666019417475727,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 532.4430000000007,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 3.6740000000000004,
      "layouts": 10,
      "layoutDurationMs": 2.6390000000000007,
      "taskDurationMs": 342.05,
      "heapDeltaBytes": 4064952,
      "heapUsedBytes": 114867648,
      "domNodes": 0,
      "jsHeapTotalBytes": 8388608,
      "scriptDurationMs": 113.019,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66250000000001,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 500.37100000002965,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 3.2750000000000004,
      "layouts": 10,
      "layoutDurationMs": 2.653,
      "taskDurationMs": 333.24399999999997,
      "heapDeltaBytes": 5081604,
      "heapUsedBytes": 114936744,
      "domNodes": 0,
      "jsHeapTotalBytes": 7864320,
      "scriptDurationMs": 114.39,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 967.3970000000054,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 621.058,
      "heapDeltaBytes": -6401020,
      "heapUsedBytes": 109393948,
      "domNodes": -232,
      "jsHeapTotalBytes": 7405568,
      "scriptDurationMs": 39.888000000000005,
      "eventListeners": -168,
      "totalBlockingTimeMs": 306,
      "frameDurationMs": 26.85000000000001,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 877.9059999999959,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 473.27000000000004,
      "heapDeltaBytes": 18278560,
      "heapUsedBytes": 115804288,
      "domNodes": 0,
      "jsHeapTotalBytes": 8552448,
      "scriptDurationMs": 38.934,
      "eventListeners": 0,
      "totalBlockingTimeMs": 263,
      "frameDurationMs": 25.979411764705873,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 718.4979999999825,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 301.7669999999999,
      "heapDeltaBytes": -3088280,
      "heapUsedBytes": 104764372,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 98.25,
      "eventListeners": 0,
      "totalBlockingTimeMs": 95,
      "frameDurationMs": 21.076470588235306,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 702.5580000000105,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 287.56100000000015,
      "heapDeltaBytes": -3246884,
      "heapUsedBytes": 104460584,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 90.98600000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 88,
      "frameDurationMs": 20.58823529411765,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 6783.765999999986,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 0.6899999999999996,
      "layouts": 2,
      "layoutDurationMs": 0.9359999999999997,
      "taskDurationMs": 5879.137,
      "heapDeltaBytes": 13692,
      "heapUsedBytes": 123763032,
      "domNodes": -278,
      "jsHeapTotalBytes": 16437248,
      "scriptDurationMs": 4406.137000000001,
      "eventListeners": -130,
      "totalBlockingTimeMs": 78,
      "frameDurationMs": 23.15051194539249,
      "p95FrameDurationMs": 33.400000000000546
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 6399.866999999972,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 0.9999999999999991,
      "layouts": 3,
      "layoutDurationMs": 0.9489999999999997,
      "taskDurationMs": 5270.9929999999995,
      "heapDeltaBytes": -28093948,
      "heapUsedBytes": 100713484,
      "domNodes": -278,
      "jsHeapTotalBytes": -2486272,
      "scriptDurationMs": 3981.4319999999993,
      "eventListeners": -130,
      "totalBlockingTimeMs": 13,
      "frameDurationMs": 20.316825396825394,
      "p95FrameDurationMs": 33.399999999999636
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 6738.075000000009,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 0.7049999999999998,
      "layouts": 2,
      "layoutDurationMs": 0.6220000000000001,
      "taskDurationMs": 5530.233,
      "heapDeltaBytes": 11956068,
      "heapUsedBytes": 135721632,
      "domNodes": -298,
      "jsHeapTotalBytes": 15601664,
      "scriptDurationMs": 4329.173,
      "eventListeners": -130,
      "totalBlockingTimeMs": 71,
      "frameDurationMs": 21.44299363057325,
      "p95FrameDurationMs": 33.400000000000546
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 6483.579999999961,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 0.8989999999999996,
      "layouts": 3,
      "layoutDurationMs": 0.7180000000000003,
      "taskDurationMs": 5526.014,
      "heapDeltaBytes": -13619876,
      "heapUsedBytes": 115243832,
      "domNodes": -278,
      "jsHeapTotalBytes": -4009984,
      "scriptDurationMs": 4263.880999999999,
      "eventListeners": -130,
      "totalBlockingTimeMs": 49,
      "frameDurationMs": 21.828619528619527,
      "p95FrameDurationMs": 33.40000000000009
    },
    {
      "name": "large-combo-open",
      "durationMs": 162.1279999999956,
      "styleRecalcs": 21,
      "styleRecalcDurationMs": 12.489,
      "layouts": 12,
      "layoutDurationMs": 3.2849999999999997,
      "taskDurationMs": 124.96799999999999,
      "heapDeltaBytes": -7462616,
      "heapUsedBytes": 115119472,
      "domNodes": 936,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 6.216000000000001,
      "eventListeners": 205,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 20.849999999999966,
      "p95FrameDurationMs": 50
    },
    {
      "name": "large-combo-open",
      "durationMs": 175.38200000001325,
      "styleRecalcs": 22,
      "styleRecalcDurationMs": 12.562,
      "layouts": 12,
      "layoutDurationMs": 3.3360000000000003,
      "taskDurationMs": 133.604,
      "heapDeltaBytes": -7170576,
      "heapUsedBytes": 116611196,
      "domNodes": 936,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 6.388,
      "eventListeners": 205,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 20.837500000000034,
      "p95FrameDurationMs": 50
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2025.6269999999859,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 2.378,
      "layouts": 8,
      "layoutDurationMs": 2.021,
      "taskDurationMs": 482.34999999999997,
      "heapDeltaBytes": -25728668,
      "heapUsedBytes": 106095012,
      "domNodes": -298,
      "jsHeapTotalBytes": -2576384,
      "scriptDurationMs": 32.99999999999999,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66639344262295,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2026.6419999999812,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 2.479,
      "layouts": 9,
      "layoutDurationMs": 2.1530000000000005,
      "taskDurationMs": 416.41999999999996,
      "heapDeltaBytes": -11703672,
      "heapUsedBytes": 120005852,
      "domNodes": -278,
      "jsHeapTotalBytes": -3186688,
      "scriptDurationMs": 26.937999999999995,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66639344262295,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2918.160999999998,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 12.579,
      "layouts": 7,
      "layoutDurationMs": 2.0020000000000002,
      "taskDurationMs": 1402.544,
      "heapDeltaBytes": -27695632,
      "heapUsedBytes": 105997568,
      "domNodes": -298,
      "jsHeapTotalBytes": -991232,
      "scriptDurationMs": 648.988,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665714285714287,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2247.568000000001,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 10.211,
      "layouts": 8,
      "layoutDurationMs": 1.8000000000000003,
      "taskDurationMs": 1127.583,
      "heapDeltaBytes": -16821712,
      "heapUsedBytes": 116015548,
      "domNodes": -298,
      "jsHeapTotalBytes": -1650688,
      "scriptDurationMs": 543.791,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66592592592593,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3964.0890000000013,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 13.027,
      "layouts": 67,
      "layoutDurationMs": 13.518,
      "taskDurationMs": 1441.991,
      "heapDeltaBytes": -16144836,
      "heapUsedBytes": 95482912,
      "domNodes": -254,
      "jsHeapTotalBytes": -5971968,
      "scriptDurationMs": 605.905,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66638655462185,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3477.530999999999,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 12.216000000000001,
      "layouts": 66,
      "layoutDurationMs": 15.12,
      "taskDurationMs": 1309.861,
      "heapDeltaBytes": -13993152,
      "heapUsedBytes": 118269484,
      "domNodes": -274,
      "jsHeapTotalBytes": -1417216,
      "scriptDurationMs": 542.257,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66602870813397,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3109.342999999967,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 7.026,
      "layouts": 6,
      "layoutDurationMs": 1.945,
      "taskDurationMs": 1587.3290000000002,
      "heapDeltaBytes": 376004,
      "heapUsedBytes": 119898276,
      "domNodes": -298,
      "jsHeapTotalBytes": 1970176,
      "scriptDurationMs": 754.498,
      "eventListeners": 50,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665775401069517,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2503.167000000019,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 6.428999999999999,
      "layouts": 7,
      "layoutDurationMs": 1.9129999999999998,
      "taskDurationMs": 1355.367,
      "heapDeltaBytes": 7746156,
      "heapUsedBytes": 120354736,
      "domNodes": 0,
      "jsHeapTotalBytes": 3407872,
      "scriptDurationMs": 662.933,
      "eventListeners": 182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665999999999997,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2033.0099999999902,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 3.373,
      "layouts": 8,
      "layoutDurationMs": 2.6740000000000004,
      "taskDurationMs": 489.94500000000005,
      "heapDeltaBytes": -17648560,
      "heapUsedBytes": 116051796,
      "domNodes": -298,
      "jsHeapTotalBytes": -3497984,
      "scriptDurationMs": 33.233999999999995,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66639344262295,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2038.0040000000008,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 2.3349999999999995,
      "layouts": 9,
      "layoutDurationMs": 2.0080000000000005,
      "taskDurationMs": 424.449,
      "heapDeltaBytes": -15573432,
      "heapUsedBytes": 117726564,
      "domNodes": -278,
      "jsHeapTotalBytes": -2973696,
      "scriptDurationMs": 29.865000000000002,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666393442622947,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 558.1039999999575,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 6.428000000000001,
      "layouts": 10,
      "layoutDurationMs": 2.766,
      "taskDurationMs": 341.254,
      "heapDeltaBytes": 2592136,
      "heapUsedBytes": 113938520,
      "domNodes": 0,
      "jsHeapTotalBytes": 11534336,
      "scriptDurationMs": 107.994,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.664705882352937,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 493.14700000002176,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 5.798000000000001,
      "layouts": 9,
      "layoutDurationMs": 2.3309999999999995,
      "taskDurationMs": 311.346,
      "heapDeltaBytes": 396872,
      "heapUsedBytes": 111792008,
      "domNodes": 0,
      "jsHeapTotalBytes": 8650752,
      "scriptDurationMs": 103.245,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2025.4909999999882,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 2.8960000000000004,
      "layouts": 10,
      "layoutDurationMs": 2.5869999999999997,
      "taskDurationMs": 410.07,
      "heapDeltaBytes": -9279888,
      "heapUsedBytes": 101718220,
      "domNodes": -220,
      "jsHeapTotalBytes": 1843200,
      "scriptDurationMs": 8.25,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.667213114754095,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2026.8590000000017,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 3.294,
      "layouts": 10,
      "layoutDurationMs": 2.725,
      "taskDurationMs": 285.752,
      "heapDeltaBytes": -7921064,
      "heapUsedBytes": 104389020,
      "domNodes": -220,
      "jsHeapTotalBytes": 4202496,
      "scriptDurationMs": 7.583999999999999,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665573770491804,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1725.8679999999913,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 15.235999999999999,
      "layouts": 10,
      "layoutDurationMs": 2.6349999999999993,
      "taskDurationMs": 699.9830000000001,
      "heapDeltaBytes": -9613996,
      "heapUsedBytes": 101438000,
      "domNodes": -192,
      "jsHeapTotalBytes": 1581056,
      "scriptDurationMs": 95.47599999999998,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666346153846156,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1712.2420000000034,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 13.484,
      "layouts": 10,
      "layoutDurationMs": 2.34,
      "taskDurationMs": 627.794,
      "heapDeltaBytes": -16037624,
      "heapUsedBytes": 96654140,
      "domNodes": -212,
      "jsHeapTotalBytes": 2678784,
      "scriptDurationMs": 87.37,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66504854368932,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 867.6169999999956,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 17.377,
      "layouts": 5,
      "layoutDurationMs": 9.817000000000002,
      "taskDurationMs": 677.454,
      "heapDeltaBytes": 11791644,
      "heapUsedBytes": 127110748,
      "domNodes": 16030,
      "jsHeapTotalBytes": 16916480,
      "scriptDurationMs": 20.919,
      "eventListeners": 3244,
      "totalBlockingTimeMs": 84,
      "frameDurationMs": 19.697727272727267,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 10874.862000000008,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 40.121,
      "layouts": 8,
      "layoutDurationMs": 2.137,
      "taskDurationMs": 4823.512999999999,
      "heapDeltaBytes": 8652200,
      "heapUsedBytes": 121207544,
      "domNodes": -278,
      "jsHeapTotalBytes": -2109440,
      "scriptDurationMs": 2138.0910000000003,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.691717791411044,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8588.297000000011,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 38.864999999999995,
      "layouts": 9,
      "layoutDurationMs": 2.2960000000000003,
      "taskDurationMs": 4219.525,
      "heapDeltaBytes": -24958112,
      "heapUsedBytes": 106528200,
      "domNodes": -278,
      "jsHeapTotalBytes": -3088384,
      "scriptDurationMs": 1951.0449999999998,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666085271317826,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17417.27499999996,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16888.881,
      "heapDeltaBytes": -26698412,
      "heapUsedBytes": 304457536,
      "domNodes": -3343,
      "jsHeapTotalBytes": 21745664,
      "scriptDurationMs": 249.53099999999998,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 30.745326278659608,
      "p95FrameDurationMs": 66.59999999999854
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16714.320000000043,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15903.575,
      "heapDeltaBytes": -4258848,
      "heapUsedBytes": 307969656,
      "domNodes": -3343,
      "jsHeapTotalBytes": 27250688,
      "scriptDurationMs": 226.89900000000003,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 29.274956217162877,
      "p95FrameDurationMs": 50.10000000000218
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 18939.040999999976,
      "styleRecalcs": 139,
      "styleRecalcDurationMs": 19.04900000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18650.927,
      "heapDeltaBytes": -17916032,
      "heapUsedBytes": 299631748,
      "domNodes": -3343,
      "jsHeapTotalBytes": 18075648,
      "scriptDurationMs": 689.3359999999999,
      "eventListeners": -651,
      "totalBlockingTimeMs": 4,
      "frameDurationMs": 35.820793950850664,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 18762.737000000016,
      "styleRecalcs": 140,
      "styleRecalcDurationMs": 18.148999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18396.621,
      "heapDeltaBytes": -37842596,
      "heapUsedBytes": 289146960,
      "domNodes": -3343,
      "jsHeapTotalBytes": 17289216,
      "scriptDurationMs": 684.144,
      "eventListeners": -651,
      "totalBlockingTimeMs": 25,
      "frameDurationMs": 34.97985074626866,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6069.578000000036,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 49.237,
      "layouts": 20,
      "layoutDurationMs": 28.500999999999998,
      "taskDurationMs": 5941.514999999999,
      "heapDeltaBytes": -16846352,
      "heapUsedBytes": 315465168,
      "domNodes": -3343,
      "jsHeapTotalBytes": 23580672,
      "scriptDurationMs": 89.66399999999999,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 34.665714285714294,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6035.657000000015,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 52.243999999999986,
      "layouts": 20,
      "layoutDurationMs": 32.598,
      "taskDurationMs": 5874.378,
      "heapDeltaBytes": -35338848,
      "heapUsedBytes": 283449052,
      "domNodes": -3343,
      "jsHeapTotalBytes": 19648512,
      "scriptDurationMs": 92.021,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 34.47485714285715,
      "p95FrameDurationMs": 66.79999999999927
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8333.394999999997,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8033.397000000001,
      "heapDeltaBytes": -15100540,
      "heapUsedBytes": 286158568,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 109.75399999999996,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 29.8673835125448,
      "p95FrameDurationMs": 66.59999999999854
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8310.466000000019,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7902.976999999998,
      "heapDeltaBytes": -65068,
      "heapUsedBytes": 311674544,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 111.045,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 28.32627986348123,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "workflow-execution",
      "durationMs": 128.99900000002162,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 12.838,
      "layouts": 8,
      "layoutDurationMs": 4.563000000000001,
      "taskDurationMs": 105.805,
      "heapDeltaBytes": 4923084,
      "heapUsedBytes": 112374900,
      "domNodes": 107,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 11.893000000000002,
      "eventListeners": 7,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 19.04285714285717,
      "p95FrameDurationMs": 33.40000000000009
    },
    {
      "name": "workflow-execution",
      "durationMs": 89.28800000001047,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.188000000000001,
      "layouts": 6,
      "layoutDurationMs": 2.183,
      "taskDurationMs": 55.043000000000006,
      "heapDeltaBytes": 4664648,
      "heapUsedBytes": 112593040,
      "domNodes": 125,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 4.734,
      "eventListeners": 5,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 252.17799999995805,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 0.662,
      "layouts": 76,
      "layoutDurationMs": 12.897,
      "taskDurationMs": 204.915,
      "heapDeltaBytes": 9772892,
      "heapUsedBytes": 99522328,
      "domNodes": 4,
      "jsHeapTotalBytes": 9437184,
      "scriptDurationMs": 88.09599999999999,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 267.56299999999555,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 0.671,
      "layouts": 76,
      "layoutDurationMs": 13.027000000000001,
      "taskDurationMs": 217.686,
      "heapDeltaBytes": 10062088,
      "heapUsedBytes": 102351080,
      "domNodes": 4,
      "jsHeapTotalBytes": 9699328,
      "scriptDurationMs": 95.125,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.662500000000023,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 322.8350000000546,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 1.5610000000000002,
      "layouts": 76,
      "layoutDurationMs": 13.705,
      "taskDurationMs": 275.883,
      "heapDeltaBytes": -1061560,
      "heapUsedBytes": 123093368,
      "domNodes": 4,
      "jsHeapTotalBytes": 2007040,
      "scriptDurationMs": 94.10700000000001,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66842105263162,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 295.50000000006094,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 1.964,
      "layouts": 76,
      "layoutDurationMs": 13.135000000000002,
      "taskDurationMs": 265.483,
      "heapDeltaBytes": -1200360,
      "heapUsedBytes": 122052692,
      "domNodes": 4,
      "jsHeapTotalBytes": 1437696,
      "scriptDurationMs": 91.45599999999999,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663157894736813,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage

Line coverage: 64.2%

Coverage totals
Metric Covered Total Pct
Lines 57819 90025 64.2% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 66.9% 1175
src/LGraphNode.ts 71.3% 379
src/workbench/extensions/agent/crdt/docOpMinter.ts 0.6% 340
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 39.6% 332
src/platform/workspace/stores/billingOperationStore.ts 8.2% 313
src/core/billing/operationLifecycle.ts 1.3% 303
src/platform/workspace/components/TopUpCreditsDialogContentWorkspace.vue 1.1% 280
src/LGraph.ts 78.9% 274
src/platform/workspace/stores/teamWorkspaceStore.ts 46.8% 252
src/core/webSessionIdentity.ts 3.3% 231

🎭 Playwright: ✅ 3000 passed, 0 failed · 3 flaky

📊 Browser Reports
  • chromium: View Report (✅ 2303 / ❌ 0 / ⚠️ 2 / ⏭️ 0)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • cloud: View Report (✅ 668 / ❌ 0 / ⚠️ 1 / ⏭️ 0)
  • desktop: View Report (✅ 4 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 19 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-safari: View Report (✅ 3 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

No verdict is available. Open the workflow run to confirm the check was intentionally skipped, or fix the collection failure and re-run it.

Findings and check details

The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

Findings and check details

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since cfcff3a504815861c835bdb52cee50ca1d0f9d6a

Full docs: ADR-DEVEX-LINT-0015

🏛️ Architecture: ✅ Passed

Findings and check details

Warnings (132)

  • billing path matches no source files: src/components/dialog/content/credit/**. Remove or update it in docs/architecture/domains/records/billing.domain.json.
  • workspace path matches no source files: src/platform/workspace/fixtures/**. Remove or update it in docs/architecture/domains/records/workspace.domain.json.
  • src/components/graph/selectionToolbox/LinkSelectionActions.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/searchbox/v2/filterChip.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/Popover.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.stories.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardFooter.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardHeader.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/card.variants.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/billing/useSubscriptionPaywall.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/billing/useSubscriptionPaywall.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/graph/menuOption.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/litegraphServiceAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/nodeDef/ComfyNodeDefImpl.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/selection/selectionIntent.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/agentPanel.historyIdentity.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/cameraInfo.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/dynamicPrompts.serializeValue.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dHost.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dHost.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dInstances.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/reportLoadModelOutcome.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/reportLoadModelOutcome.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/i18n.literalMessages.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/LiteGraphGlobal.cloneObject.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/canvasClassAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkHideTransition.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkHideTransition.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkSelection.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkSelection.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkSnapGeometry.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkSnapGeometry.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/authStoreAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/currentUserAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/sessionCookieAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/sessionRevokedError.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/webSessionFetch.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/sso/ssoRequiredContext.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/missingModel/releaseModelOptions.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/missingModel/releaseModelOptions.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/telemetry/billingActionNames.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • …and 82 more
Reproduce locally
pnpm architecture:check

Full docs: Frontend domain catalog

🌐 Website E2E

Tip

All tests passed.

View Report

Test results
Status ✅ Passed

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-21561.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

Deployment details

This commit: https://website-frontend-26y4gjo1h-comfyui.vercel.app

Last updated: 2026-10-21T19:22:38Z for 1b66b79

@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 6cf98bef-28c3-491b-a3c3-8e65481f0820

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 21, 2026
@codecov

codecov Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.66667% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
apps/website/src/lib/cms/catalog-list-all.ts 90.00% 1 Missing and 1 partial ⚠️
apps/website/src/components/hub/CreatorAvatar.vue 0.00% 0 Missing and 1 partial ⚠️
apps/website/src/lib/cms/catalog.ts 87.50% 0 Missing and 1 partial ⚠️
@@                          Coverage Diff                          @@
##           work/ccc-mar-integration-20261014   #21561      +/-   ##
=====================================================================
- Coverage                              86.45%   86.34%   -0.11%     
=====================================================================
  Files                                   4030     3927     -103     
  Lines                                 184642   181412    -3230     
  Branches                               50825    47677    -3148     
=====================================================================
- Hits                                  159627   156644    -2983     
+ Misses                                 22316    22214     -102     
+ Partials                                2699     2554     -145     
Flag Coverage Δ
billing-web-unit ?
e2e 64.22% <ø> (+0.03%) ⬆️
unit 85.84% <ø> (-0.01%) ⬇️
website-unit 80.75% <94.66%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
apps/website/src/config/routes.ts 100.00% <ø> (ø)
.../website/src/integrations/workshop-release-gate.ts 96.05% <100.00%> (+0.33%) ⬆️
apps/website/src/lib/cms/catalog-creators.ts 100.00% <100.00%> (ø)
apps/website/src/lib/hub/creator-path.ts 100.00% <100.00%> (ø)
apps/website/src/lib/hub/creators.ts 100.00% <100.00%> (ø)
apps/website/src/components/hub/CreatorAvatar.vue 0.00% <0.00%> (ø)
apps/website/src/lib/cms/catalog.ts 84.31% <87.50%> (+2.68%) ⬆️
apps/website/src/lib/cms/catalog-list-all.ts 91.66% <90.00%> (-2.46%) ⬇️

... and 131 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MaanilVerma

Copy link
Copy Markdown
Collaborator Author

QA: Hub creators directory from the catalog

I ran astro dev in CMS mode (VERCEL_ENV=development) against a local mock catalog. The mock serves the cloud #14830 contract: GET /api/v1/catalog/creators over two pages, with HelloRob on page 1 and hellorob on page 2. Playwright drove the pages at 1440px and 390px. The screenshots come from the top of the stack (the profile PR), which contains this PR unchanged.

What it checks Proof
The directory lists one card per creator, busiest first, with links to lowercase profile URLs · unit reads every directory page and lists the busiest creators first
HelloRob and hellorob merge into one card with 2 workflows Same screenshot, Rob card · unit merges usernames that differ only in case into one lowercase creator
An avatar that is not on the Hub assets host shows the initial letter Same screenshot, Purz card · unit avatar table (4 cases)
The directory fits a 390px phone with no sideways scroll · Playwright scrollWidth check
The route exists only in CMS mode unit renders CMS routes only where the CMS is enabled (production) and (preview)
Full run trace

13 pass, 0 fail, 0 escalated, 1 inconclusive (for the whole stack run). 25 unit tests pass on this branch.

Not covered here: the real cloud #14830 build. It is not deployed to an environment I can reach, so a mock with the same contract served the data (inconclusive).

fetchCatalogJson() in catalog.ts is now the one bounded catalog read, and fetchDetail() uses it. everyCursorPage() in catalog-list-all.ts is now the one cursor walk, and both loadEverySiteCatalogCard() and the creator directory use it. hubAvatarUrl() first applies validAuthorAvatarURL(), so the directory and the workflow author use one avatar policy. CreatorAvatar sends no referrer. New loader tests cover the zero-count filter, the empty display name, CMS off, an error status with a body, a repeated cursor and the page cap.
hubCreatorPath() and HUB_CREATORS_PATH now live in lib/hub/creator-path.ts, which imports only the locale prefix. A client component can link to a creator without pulling server catalog data into its bundle. A new test pins the encoding of a username with a space or slash.
…irectory

The directory shows a sentence when no creator has public workflows, in place of an empty list. The ja locale now has the workshop.hub.creators keys, so /ja/hub/creators/ is no longer in English.
@MaanilVerma
MaanilVerma marked this pull request as ready for review October 22, 2026 02:37

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: Hub creators directory

No blockers. The everyCursorPage and fetchCatalogJson refactors keep the old behavior. The locale keys land at workshop.hub.creators in all three files. Route gating means a production build has no creators route. The zod schema matches the cloud #14830 contract (CCCCreatorsPage).

The main issue is the client-side merge of usernames that differ only in case. It disagrees with how cloud resolves a profile. See the inline comment.

Severity Count
BLOCKER 0
SHOULD FIX 2
TRIVIAL 2

Notes (no action in this PR):

  • Every card links to /hub/creators/<name>/, which 404s until #21564 lands. That is expected for the stack, but don't merge this into the integration branch without #21564.
  • There is no page-level test for routes/hub/creators/index.astro (the 503 path, the empty state, locale-prefixed links).
  • I checked that Cloudflare Image Resizing is enabled on comfy-hub-assets.comfy.org: the response has a cf-resized header.

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review at eb517ad

No fixes in this round. The only new commit is eb517adb Merge branch 'work/ccc-mar-integration-20261014'. The PR diff is identical to the one I reviewed apart from hunk offsets. I checked the merged base for changes to code this PR depends on (lib/cms, middleware, the release gate, BaseLayout props, routes.ts) and found nothing that affects it.

None of the 4 earlier threads has been addressed or answered, so I'm leaving them all open:

Severity Open
BLOCKER 0
SHOULD FIX 2: case-variant merge (catalog-creators.ts:46), page cap with no overall deadline (catalog-creators.ts:11)
TRIVIAL 2: charAt(0) on emoji names, breadcrumb not localized

I can't approve yet. The case-merge issue shows a wrong workflow count and links to the wrong account for creators already in the catalog. Fix it here, or in cloud #14830 and link it from the thread.

CI on this head has no failures; 11 checks are still pending (build, typecheck, lint, website-unit, website-e2e).

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review at 077e467: approving

I checked all 4 earlier findings against the new commits (cf8004e7..077e4675). All are fixed, and I resolved the threads.

Finding Fix Verified
SHOULD FIX: case-variant merge 7cf136ab removes the merge. Cloud acb8cb432d matches lowercase exactly. Safe: the only profile write path already rejected uppercase (hub.ValidateUsername, since #13030).
SHOULD FIX: page cap returned 503, no overall deadline a5965131 returns a partial list at page 20. 13d174d4 adds an 8s shared deadline through AbortSignal.any. The cap stops at exactly 20 fetches. A mid-body abort still maps to 503 through boundedBody. fetchDetail is unchanged. loadEverySiteCatalogCard is untouched. Node 26 supports AbortSignal.any.
TRIVIAL: charAt(0) on emoji names [...name][0], plus CreatorAvatar.test.ts The test runs in website-unit (happy-dom, @testing-library/vue) and catches a revert.
TRIVIAL: breadcrumb not localized catalogLocalePrefix(locale) Uses the same locale as the card links.

CI on this head: website-unit, typecheck, website-build and all 4 website-e2e shards pass. The only checks still pending are the main app's Playwright suites.

Optional, TRIVIAL, no need to block:

  • Above 2,000 creators the list is the first 2,000 in username order, sorted by count. That cut-off is silent. A one-line comment, or a log when a cursor is dropped, would help.
  • [...name][0] still splits flags and ZWJ emoji. That is cosmetic.
  • On cloud #14830: the lowercase rule is enforced only in Go. Consider a DB CHECK (details in the resolved thread).

@MaanilVerma

Copy link
Copy Markdown
Collaborator Author

Moved to Comfy-Org/comfy-website#27 (the website now lives there). This PR stays open for its review history.

@MaanilVerma

Copy link
Copy Markdown
Collaborator Author

Closing: the website moved; this change lives in Comfy-Org/comfy-website#27.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants