Repository navigation
refactor: move pure components into design system - #21240
Conversation
Consolidate the remaining theme work after extracting dialog naming and template-class pruning into separate pull requests. Amp-Thread-ID: https://ampcode.com/threads/T-f28235a7-d36d-4d59-bca2-622f64e673b5
Preserve the shared checkout ending frame and apply the consolidated theme tokens to it. Amp-Thread-ID: https://ampcode.com/threads/T-f28235a7-d36d-4d59-bca2-622f64e673b5
Keep the primary Run button and removal of embedded checkout from main. Retain theme-branch screenshot baselines for the existing CI expectation refresh. Amp-Thread-ID: https://ampcode.com/threads/T-f28235a7-d36d-4d59-bca2-622f64e673b5
Keep the original palette input, text, and border colors for LiteGraph DOM textareas and old-menu buttons. Modern controls continue using semantic theme tokens. Amp-Thread-ID: https://ampcode.com/threads/T-f28235a7-d36d-4d59-bca2-622f64e673b5
| snapshot | status | changed pixels | | --- | --- | --- | | `tests/agent/agentAskUserQuestion.spec.ts-snapshots/agent-ask-user-card-in-flight-cloud-linux.png` | modified | 8494B -> 8598B | | `tests/agent/agentConversationReplay.spec.ts-snapshots/two-turn-dependent-edit-wired-cloud-linux.png` | modified | 141009B -> 140966B | | `tests/collapsedNodeLinks.spec.ts-snapshots/subgraph-entry-collapsed-node-links-chromium-linux.png` | modified | 76119B -> 76181B | | `tests/colorPalette.spec.ts-snapshots/custom-light-palette-menu-open-chromium-linux.png` | modified | 109820B -> 110008B | | `tests/dialogs/publishDialog.spec.ts-snapshots/publish-dialog-2xl-chromium-linux.png` | modified | 54730B -> 54735B | | `tests/dialogs/publishDialog.spec.ts-snapshots/publish-dialog-lg-chromium-linux.png` | modified | 52587B -> 52625B | | `tests/dialogs/publishDialog.spec.ts-snapshots/publish-dialog-md-chromium-linux.png` | modified | 41163B -> 41211B | | `tests/dialogs/publishDialog.spec.ts-snapshots/publish-dialog-mobile-chromium-linux.png` | modified | 33192B -> 33179B | | `tests/dialogs/publishDialog.spec.ts-snapshots/publish-dialog-sm-chromium-linux.png` | modified | 39532B -> 39570B | | `tests/dialogs/publishDialog.spec.ts-snapshots/publish-dialog-wide-chromium-linux.png` | modified | 57320B -> 57345B | | `tests/dialogs/publishDialog.spec.ts-snapshots/publish-dialog-xl-chromium-linux.png` | modified | 52544B -> 52560B | | `tests/execution.spec.ts-snapshots/execution-error-unconnected-slot-chromium-linux.png` | modified | 102594B -> 102633B | | `tests/groupTitleContrast.spec.ts-snapshots/group-title-contrast-black-chromium-linux.png` | modified | 38566B -> 38544B | | `tests/mobileBaseline.spec.ts-snapshots/mobile-default-workflow-mobile-chrome-linux.png` | modified | 31769B -> 31876B | | `tests/mobileBaseline.spec.ts-snapshots/mobile-empty-canvas-mobile-chrome-linux.png` | modified | 19669B -> 19727B | | `tests/mobileBaseline.spec.ts-snapshots/mobile-graph-canvas-toolbar-mobile-chrome-linux.png` | modified | 34623B -> 34725B | | `tests/saveImageAndWebp.spec.ts-snapshots/save-image-and-webm-preview-chromium-linux.png` | modified | 97310B -> 97311B | | `tests/viewport.spec.ts-snapshots/viewport-fits-when-saved-offscreen-chromium-linux.png` | modified | 104479B -> 104432B | | `tests/vueNodes/groups/groups.spec.ts-snapshots/vue-groups-fit-to-contents-chromium-linux.png` | modified | 55992B -> 55965B | | `tests/vueNodes/interactions/canvas/pan.spec.ts-snapshots/vue-nodes-paned-with-touch-mobile-chrome-linux.png` | modified | 26867B -> 26964B | | `tests/vueNodes/interactions/canvas/zoom.spec.ts-snapshots/zoomed-in-ctrl-shift-chromium-linux.png` | modified | 30724B -> 30708B | | `tests/vueNodes/interactions/links/linkInteraction.spec.ts-snapshots/vue-node-dragging-link-chromium-linux.png` | modified | 64668B -> 64647B | | `tests/vueNodes/interactions/links/linkInteraction.spec.ts-snapshots/vue-node-input-drag-ctrl-alt-chromium-linux.png` | modified | 62809B -> 62786B | | `tests/vueNodes/interactions/links/linkInteraction.spec.ts-snapshots/vue-node-input-drag-reuses-origin-chromium-linux.png` | modified | 62260B -> 62225B | | `tests/vueNodes/interactions/links/linkInteraction.spec.ts-snapshots/vue-node-reroute-input-drag-chromium-linux.png` | modified | 64737B -> 64716B | | `tests/vueNodes/interactions/links/linkInteraction.spec.ts-snapshots/vue-node-reroute-output-shift-drag-chromium-linux.png` | modified | 64745B -> 64710B | | `tests/vueNodes/interactions/links/linkInteraction.spec.ts-snapshots/vue-node-shift-output-multi-link-chromium-linux.png` | modified | 63523B -> 63490B | | `tests/vueNodes/interactions/links/linkInteraction.spec.ts-snapshots/vue-node-snap-to-node-chromium-linux.png` | modified | 61174B -> 61166B | | `tests/vueNodes/interactions/links/linkInteraction.spec.ts-snapshots/vue-node-snap-to-slot-chromium-linux.png` | modified | 60463B -> 60432B | | `tests/vueNodes/interactions/node/imagePreview.spec.ts-snapshots/vue-node-multiple-promoted-previews-chromium-linux.png` | modified | 93093B -> 93048B | | `tests/vueNodes/nodeStates/bypass.spec.ts-snapshots/vue-node-bypassed-state-chromium-linux.png` | modified | 103037B -> 103019B | | `tests/vueNodes/nodeStates/colors.spec.ts-snapshots/vue-node-custom-color-blue-chromium-linux.png` | modified | 104960B -> 104955B | | `tests/vueNodes/nodeStates/colors.spec.ts-snapshots/vue-node-custom-colors-dark-all-colors-chromium-linux.png` | modified | 138282B -> 138263B | | `tests/vueNodes/nodeStates/colors.spec.ts-snapshots/vue-node-custom-colors-light-all-colors-chromium-linux.png` | modified | 145999B -> 146043B | | `tests/vueNodes/nodeStates/mute.spec.ts-snapshots/vue-node-muted-state-chromium-linux.png` | modified | 102625B -> 102605B | | `tests/vueNodes/rerouteNodeSize.spec.ts-snapshots/vue-reroute-node-compact-chromium-linux.png` | modified | 53755B -> 53736B | Screenshot capture is not bit-deterministic; small pixel deltas are usually text rasterization noise. Confirm each rewrite corresponds to a test expected to change.
Taken from the failed screenshot assertions of https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/38994831556 without rerunning Playwright. | snapshot | status | changed pixels | | --- | --- | --- | | `browser_tests/tests/colorPalette.spec.ts-snapshots/custom-color-palette-light-red-chromium-linux.png` | modified | 132143B -> 131666B | | `browser_tests/tests/colorPalette.spec.ts-snapshots/custom-light-palette-menu-open-chromium-linux.png` | modified | 110008B -> 110060B | | `browser_tests/tests/colorPalette.spec.ts-snapshots/node-opacity-0-3-color-changed-chromium-linux.png` | modified | 145592B -> 145145B | | `browser_tests/tests/colorPalette.spec.ts-snapshots/node-opacity-0-3-color-removed-chromium-linux.png` | modified | 144234B -> 143759B | Screenshot capture is not bit-deterministic; small pixel deltas are usually text rasterization noise. Confirm each update corresponds to a test expected to change.
Resolve semantic CSS at the consuming scope. Keep outline badges transparent, truncate chip labels, and restore inherited preview text, local table scrolling, focus rings, and checkout font parity. Amp-Thread-ID: https://ampcode.com/threads/T-f28235a7-d36d-4d59-bca2-622f64e673b5
Use opaque accent hovers for secondary controls and separate the light hover step from resting and selected fills. Preserve foreground strength on error labels and use an underlined foreground link in the free-use notice. Amp-Thread-ID: https://ampcode.com/threads/T-f28235a7-d36d-4d59-bca2-622f64e673b5
Keep the palette variables referenced by existing Light exports and the renamed widget variables consumed by published extensions. Cover the exported Light hover and selected expressions with a browser regression, and compare selected fills against the page surface. Amp-Thread-ID: https://ampcode.com/threads/T-f28235a7-d36d-4d59-bca2-622f64e673b5
Outline badges use the normal foreground because contrasting and warning foregrounds assume their matching filled background. Amp-Thread-ID: https://ampcode.com/threads/T-f28235a7-d36d-4d59-bca2-622f64e673b5
Mix opacity with transparent using the browser color parser instead of sending resolved theme colors through the RGB-only adjustment path. Amp-Thread-ID: https://ampcode.com/threads/T-f28235a7-d36d-4d59-bca2-622f64e673b5
Restore the 0.01 per-pixel threshold previously requested for the token migration, so neighboring palette steps cannot silently pass against stale baselines. Baselines remain CI-generated. Amp-Thread-ID: https://ampcode.com/threads/T-f28235a7-d36d-4d59-bca2-622f64e673b5
Provide a migration path to explicit theme values without promising exact legacy palette fidelity. Amp-Thread-ID: https://ampcode.com/threads/T-f28235a7-d36d-4d59-bca2-622f64e673b5
Taken from the failed screenshot assertions of https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39000914854 without rerunning Playwright. | snapshot | status | changed pixels | | --- | --- | --- | | `browser_tests/tests/agent/agentAskConsent.spec.ts-snapshots/agent-delete-approval-card-cloud-linux.png` | modified | 7481B -> 7489B | | `browser_tests/tests/agent/agentAskUserQuestion.spec.ts-snapshots/agent-ask-user-card-closed-cloud-linux.png` | modified | 4666B -> 4689B | | `browser_tests/tests/agent/agentAskUserQuestion.spec.ts-snapshots/agent-ask-user-card-cloud-linux.png` | modified | 13132B -> 13103B | | `browser_tests/tests/agent/agentConsent.spec.ts-snapshots/agent-consent-light-palette-cloud-linux.png` | modified | 26987B -> 27041B | | `browser_tests/tests/agent/agentConversationReplay.spec.ts-snapshots/asset-grid-fragmentation-cloud-linux.png` | modified | 37768B -> 37535B | | `browser_tests/tests/agent/agentCreditsExhaustionLifecycle.spec.ts-snapshots/agent-credit-transition-notice-cloud-linux.png` | modified | 6639B -> 6625B | | `browser_tests/tests/agent/agentFreeUsePlacement.spec.ts-snapshots/agent-free-use-notice-cloud-linux.png` | modified | 3550B -> 3030B | | `browser_tests/tests/canvasSettings.spec.ts-snapshots/canvas-info-hud-off-chromium-linux.png` | modified | 2474B -> 2496B | | `browser_tests/tests/colorPalette.spec.ts-snapshots/custom-color-palette-obsidian-dark-all-colors-chromium-linux.png` | modified | 128312B -> 127554B | | `browser_tests/tests/colorPalette.spec.ts-snapshots/custom-color-palette-obsidian-dark-chromium-linux.png` | modified | 93620B -> 93148B | | `browser_tests/tests/colorPalette.spec.ts-snapshots/node-lightened-colors-chromium-linux.png` | modified | 132792B -> 132094B | | `browser_tests/tests/colorPalette.spec.ts-snapshots/node-opacity-0-2-arc-theme-chromium-linux.png` | modified | 157314B -> 157204B | | `browser_tests/tests/colorPalette.spec.ts-snapshots/node-opacity-0-5-chromium-linux.png` | modified | 144211B -> 142076B | | `browser_tests/tests/copyPaste.spec.ts-snapshots/copied-node-chromium-linux.png` | modified | 97543B -> 94939B | | `browser_tests/tests/copyPaste.spec.ts-snapshots/copied-node-with-link-chromium-linux.png` | modified | 109568B -> 106647B | | `browser_tests/tests/copyPaste.spec.ts-snapshots/copied-widget-value-chromium-linux.png` | modified | 94163B -> 91600B | | `browser_tests/tests/copyPaste.spec.ts-snapshots/drag-copy-copied-node-chromium-linux.png` | modified | 99489B -> 96728B | | `browser_tests/tests/copyPaste.spec.ts-snapshots/no-node-copied-chromium-linux.png` | modified | 93871B -> 91308B | | `browser_tests/tests/copyPaste.spec.ts-snapshots/paste-in-text-area-with-node-previously-copied-chromium-linux.png` | modified | 101980B -> 99239B | | `browser_tests/tests/dialogs/modelImportProgressDialog.spec.ts-snapshots/model-import-progress-toast-recovered-completed-chromium-linux.png` | modified | 3637B -> 3635B | | `browser_tests/tests/dialogs/publishDialog.spec.ts-snapshots/publish-dialog-md-chromium-linux.png` | modified | 41211B -> 41030B | | `browser_tests/tests/dialogs/publishDialog.spec.ts-snapshots/publish-dialog-sm-chromium-linux.png` | modified | 39570B -> 39439B | | `browser_tests/tests/domWidget.spec.ts-snapshots/focus-mode-on-chromium-linux.png` | modified | 81315B -> 81166B | | `browser_tests/tests/execution.spec.ts-snapshots/execution-error-unconnected-slot-chromium-linux.png` | modified | 102633B -> 102513B | | `browser_tests/tests/graphCanvasMenu.spec.ts-snapshots/canvas-with-hidden-links-chromium-linux.png` | modified | 83079B -> 80587B | | `browser_tests/tests/groupColorPicker.spec.ts-snapshots/group-color-right-click-matches-toolbar-swatch-chromium-linux.png` | modified | 72405B -> 75678B | | `browser_tests/tests/interaction.spec.ts-snapshots/adjusted-widget-value-chromium-linux.png` | modified | 93851B -> 91290B | | `browser_tests/tests/interaction.spec.ts-snapshots/batch-disconnect-links-disconnected-chromium-linux.png` | modified | 87796B -> 85191B | | `browser_tests/tests/interaction.spec.ts-snapshots/batch-move-links-chromium-linux.png` | modified | 72991B -> 70691B | | `browser_tests/tests/interaction.spec.ts-snapshots/default-chromium-2x-linux.png` | modified | 94914B -> 91883B | | `browser_tests/tests/interaction.spec.ts-snapshots/default-chromium-linux.png` | modified | 93835B -> 91273B | | `browser_tests/tests/interaction.spec.ts-snapshots/disconnected-edge-chromium-linux.png` | modified | 90148B -> 87539B | | `browser_tests/tests/interaction.spec.ts-snapshots/dragging-link1-chromium-linux.png` | modified | 93583B -> 91030B | | `browser_tests/tests/interaction.spec.ts-snapshots/group-fit-to-contents-chromium-linux.png` | modified | 64779B -> 62153B | | `browser_tests/tests/interaction.spec.ts-snapshots/group-selected-nodes-chromium-linux.png` | modified | 103970B -> 101419B | | `browser_tests/tests/interaction.spec.ts-snapshots/group-title-edited-chromium-linux.png` | modified | 62043B -> 59266B | | `browser_tests/tests/interaction.spec.ts-snapshots/legacy-alt-shift-drag-chromium-linux.png` | modified | 86679B -> 84470B | | `browser_tests/tests/interaction.spec.ts-snapshots/legacy-click-node-select-chromium-linux.png` | modified | 95039B -> 92372B | | `browser_tests/tests/interaction.spec.ts-snapshots/legacy-left-drag-pan-chromium-linux.png` | modified | 86679B -> 84470B | | `browser_tests/tests/interaction.spec.ts-snapshots/legacy-middle-drag-pan-chromium-linux.png` | modified | 86679B -> 84470B | | `browser_tests/tests/interaction.spec.ts-snapshots/legacy-wheel-zoom-in-chromium-linux.png` | modified | 100021B -> 97327B | | `browser_tests/tests/interaction.spec.ts-snapshots/node-title-edited-chromium-linux.png` | modified | 56386B -> 53822B | | `browser_tests/tests/interaction.spec.ts-snapshots/nodes-bypassed-chromium-linux.png` | modified | 110975B -> 108517B | | `browser_tests/tests/interaction.spec.ts-snapshots/nodes-pinned-chromium-linux.png` | modified | 100273B -> 97608B | | `browser_tests/tests/interaction.spec.ts-snapshots/panned-chromium-linux.png` | modified | 70652B -> 68884B | | `browser_tests/tests/interaction.spec.ts-snapshots/panned-step-one-chromium-linux.png` | modified | 53263B -> 51007B | | `browser_tests/tests/interaction.spec.ts-snapshots/pinned-all-chromium-linux.png` | modified | 79730B -> 77133B | | `browser_tests/tests/interaction.spec.ts-snapshots/selected-all-chromium-linux.png` | modified | 77004B -> 74394B | | `browser_tests/tests/interaction.spec.ts-snapshots/single-ksampler-chromium-linux.png` | modified | 55654B -> 53115B | | `browser_tests/tests/interaction.spec.ts-snapshots/single-ksampler-fit-chromium-linux.png` | modified | 55654B -> 53115B | | `browser_tests/tests/interaction.spec.ts-snapshots/single-ksampler-modified-chromium-linux.png` | modified | 39184B -> 37646B | | `browser_tests/tests/interaction.spec.ts-snapshots/snap-to-slot-chromium-linux.png` | modified | 66530B -> 63843B | | `browser_tests/tests/interaction.spec.ts-snapshots/snapped-highlighted-chromium-linux.png` | modified | 93476B -> 90915B | | `browser_tests/tests/interaction.spec.ts-snapshots/standard-click-node-select-chromium-linux.png` | modified | 95039B -> 92372B | | `browser_tests/tests/interaction.spec.ts-snapshots/standard-ctrl-wheel-zoom-in-chromium-linux.png` | modified | 100021B -> 97327B | | `browser_tests/tests/interaction.spec.ts-snapshots/standard-initial-chromium-linux.png` | modified | 94977B -> 92243B | | `browser_tests/tests/interaction.spec.ts-snapshots/standard-left-drag-select-chromium-linux.png` | modified | 99395B -> 96667B | | `browser_tests/tests/interaction.spec.ts-snapshots/standard-middle-drag-pan-chromium-linux.png` | modified | 86679B -> 84470B | | `browser_tests/tests/interaction.spec.ts-snapshots/standard-space-drag-pan-chromium-linux.png` | modified | 87846B -> 85577B | | `browser_tests/tests/interaction.spec.ts-snapshots/string-input-chromium-linux.png` | modified | 41508B -> 39792B | | `browser_tests/tests/interaction.spec.ts-snapshots/string-node-id-chromium-linux.png` | modified | 93740B -> 90930B | | `browser_tests/tests/interaction.spec.ts-snapshots/zoomed-in-chromium-linux.png` | modified | 98153B -> 95590B | | `browser_tests/tests/interaction.spec.ts-snapshots/zoomed-in-ctrl-shift-chromium-linux.png` | modified | 70799B -> 68801B | | `browser_tests/tests/interaction.spec.ts-snapshots/zoomed-in-high-zoom-speed-chromium-linux.png` | modified | 32351B -> 30818B | | `browser_tests/tests/interaction.spec.ts-snapshots/zoomed-in-low-zoom-speed-chromium-linux.png` | modified | 94669B -> 92205B | | `browser_tests/tests/interaction.spec.ts-snapshots/zoomed-very-far-out-chromium-linux.png` | modified | 35774B -> 34260B | | `browser_tests/tests/links/linkVisibility.spec.ts-snapshots/link-hidden-chromium-linux.png` | modified | 50924B -> 49017B | | `browser_tests/tests/links/linkVisibility.spec.ts-snapshots/link-visible-chromium-linux.png` | modified | 53034B -> 50771B | | `browser_tests/tests/links/linkVisibility.spec.ts-snapshots/vue-link-hidden-chromium-linux.png` | modified | 55733B -> 53987B | | `browser_tests/tests/load3d/load3d.spec.ts-snapshots/load3d-controls-menu-open-chromium-linux.png` | modified | 45512B -> 49593B | | `browser_tests/tests/loadWorkflowInMedia.spec.ts-snapshots/edited-workflow-webp-chromium-linux.png` | modified | 98387B -> 95600B | | `browser_tests/tests/loadWorkflowInMedia.spec.ts-snapshots/large-workflow-webp-chromium-linux.png` | modified | 105363B -> 103236B | | `browser_tests/tests/loadWorkflowInMedia.spec.ts-snapshots/workflow-itxt-png-chromium-linux.png` | modified | 44756B -> 42926B | | `browser_tests/tests/loadWorkflowInMedia.spec.ts-snapshots/workflow-m4v-chromium-linux.png` | modified | 55741B -> 53228B | | `browser_tests/tests/loadWorkflowInMedia.spec.ts-snapshots/workflow-mov-chromium-linux.png` | modified | 55741B -> 53228B | | `browser_tests/tests/loadWorkflowInMedia.spec.ts-snapshots/workflow-mp4-chromium-linux.png` | modified | 55741B -> 53228B | | `browser_tests/tests/loadWorkflowInMedia.spec.ts-snapshots/workflow-prompt-parameters-png-chromium-linux.png` | modified | 44891B -> 43065B | | `browser_tests/tests/loadWorkflowInMedia.spec.ts-snapshots/workflow-svg-chromium-linux.png` | modified | 98387B -> 95600B | | `browser_tests/tests/loadWorkflowInMedia.spec.ts-snapshots/workflow-webm-chromium-linux.png` | modified | 56795B -> 54491B | | `browser_tests/tests/loadWorkflowInMedia.spec.ts-snapshots/workflow-webp-chromium-linux.png` | modified | 98387B -> 95600B | | `browser_tests/tests/lodThreshold.spec.ts-snapshots/lod-comparison-low-quality-chromium-linux.png` | modified | 36640B -> 35151B | | `browser_tests/tests/minimap.spec.ts-snapshots/minimap-before-pan-chromium-linux.png` | modified | 3673B -> 3634B | | `browser_tests/tests/minimap.spec.ts-snapshots/minimap-with-viewport-chromium-linux.png` | modified | 3673B -> 3634B | | `browser_tests/tests/mobileBaseline.spec.ts-snapshots/mobile-settings-dialog-mobile-chrome-linux.png` | modified | 21761B -> 21771B | | `browser_tests/tests/nodeBadge.spec.ts-snapshots/api-pricing-off-classic-chromium-linux.png` | modified | 54464B -> 52308B | | `browser_tests/tests/nodeBadge.spec.ts-snapshots/api-pricing-off-vue-chromium-linux.png` | modified | 53589B -> 51986B | | `browser_tests/tests/nodeBadge.spec.ts-snapshots/api-pricing-on-classic-chromium-linux.png` | modified | 56393B -> 54371B | | `browser_tests/tests/nodeBadge.spec.ts-snapshots/api-pricing-on-vue-chromium-linux.png` | modified | 55818B -> 54374B | | `browser_tests/tests/nodeBadge.spec.ts-snapshots/node-badge-Hide-built-in-chromium-linux.png` | modified | 44328B -> 42624B | | `browser_tests/tests/nodeBadge.spec.ts-snapshots/node-badge-None-chromium-linux.png` | modified | 42928B -> 41207B | | `browser_tests/tests/nodeBadge.spec.ts-snapshots/node-badge-Show-all-chromium-linux.png` | modified | 45239B -> 43538B | | `browser_tests/tests/nodeBadge.spec.ts-snapshots/node-badge-chromium-linux.png` | modified | 97963B -> 95422B | | `browser_tests/tests/nodeBadge.spec.ts-snapshots/node-badge-light-color-palette-chromium-linux.png` | modified | 98275B -> 97362B | | `browser_tests/tests/nodeBadge.spec.ts-snapshots/node-badge-multiple-chromium-linux.png` | modified | 100930B -> 98426B | | `browser_tests/tests/nodeBadge.spec.ts-snapshots/node-badge-unknown-color-palette-chromium-linux.png` | modified | 94519B -> 92170B | | `browser_tests/tests/nodeBadge.spec.ts-snapshots/node-lifecycle-None-classic-chromium-linux.png` | modified | 42569B -> 40884B | | `browser_tests/tests/nodeBadge.spec.ts-snapshots/node-lifecycle-None-vue-chromium-linux.png` | modified | 44072B -> 42483B | | `browser_tests/tests/nodeBadge.spec.ts-snapshots/node-lifecycle-Show-all-classic-chromium-linux.png` | modified | 43443B -> 41715B | | `browser_tests/tests/nodeBadge.spec.ts-snapshots/node-lifecycle-Show-all-vue-chromium-linux.png` | modified | 44873B -> 43321B | | `browser_tests/tests/nodeDisplay.spec.ts-snapshots/default-input-chromium-linux.png` | modified | 44328B -> 42566B | | `browser_tests/tests/nodeDisplay.spec.ts-snapshots/dynamically-added-input-chromium-linux.png` | modified | 56960B -> 54372B | | `browser_tests/tests/nodeDisplay.spec.ts-snapshots/force-input-chromium-linux.png` | modified | 43115B -> 41494B | | `browser_tests/tests/nodeDisplay.spec.ts-snapshots/missing-nodes-converted-widget-chromium-linux.png` | modified | 57623B -> 55347B | | `browser_tests/tests/nodeDisplay.spec.ts-snapshots/optional-input-chromium-linux.png` | modified | 42961B -> 41292B | | `browser_tests/tests/nodeDisplay.spec.ts-snapshots/simple-slider-chromium-linux.png` | modified | 41168B -> 39588B | | `browser_tests/tests/nodeSearchBox.spec.ts-snapshots/added-node-chromium-linux.png` | modified | 109779B -> 106432B | | `browser_tests/tests/nodeSearchBox.spec.ts-snapshots/added-node-no-connection-chromium-linux.png` | modified | 101225B -> 98466B | | `browser_tests/tests/nodeSearchBox.spec.ts-snapshots/auto-linked-node-batch-chromium-linux.png` | modified | 80373B -> 78082B | | `browser_tests/tests/nodeSearchBox.spec.ts-snapshots/auto-linked-node-chromium-linux.png` | modified | 94038B -> 91450B | | `browser_tests/tests/nodeSearchBox.spec.ts-snapshots/link-context-menu-search-chromium-linux.png` | modified | 94038B -> 91450B | | `browser_tests/tests/nodeSearchBox.spec.ts-snapshots/link-release-context-menu-chromium-linux.png` | modified | 101968B -> 99086B | | `browser_tests/tests/noteNode.spec.ts-snapshots/note-nodes-chromium-linux.png` | modified | 44240B -> 42679B | | `browser_tests/tests/primitiveNode.spec.ts-snapshots/primitive-node-chromium-linux.png` | modified | 64021B -> 61378B | | `browser_tests/tests/primitiveNode.spec.ts-snapshots/primitive-node-connected-chromium-linux.png` | modified | 62613B -> 59967B | | `browser_tests/tests/primitiveNode.spec.ts-snapshots/primitive-node-connected-dom-widget-chromium-linux.png` | modified | 46503B -> 44752B | | `browser_tests/tests/primitiveNode.spec.ts-snapshots/static-primitive-connected-chromium-linux.png` | modified | 62178B -> 59539B | | `browser_tests/tests/recordAudio.spec.ts-snapshots/record-audio-node-chromium-linux.png` | modified | 99415B -> 96608B | | `browser_tests/tests/rerouteNode.spec.ts-snapshots/native-reroute-alt-click-chromium-0-5x-linux.png` | modified | 94231B -> 91661B | | `browser_tests/tests/rerouteNode.spec.ts-snapshots/native-reroute-alt-click-chromium-2x-linux.png` | modified | 95359B -> 92314B | | `browser_tests/tests/rerouteNode.spec.ts-snapshots/native-reroute-alt-click-chromium-linux.png` | modified | 94231B -> 91661B | | `browser_tests/tests/rerouteNode.spec.ts-snapshots/native-reroute-chromium-linux.png` | modified | 53203B -> 50890B | | `browser_tests/tests/rerouteNode.spec.ts-snapshots/native-reroute-context-menu-chromium-linux.png` | modified | 94151B -> 91573B | | `browser_tests/tests/rerouteNode.spec.ts-snapshots/reroute-inserted-chromium-linux.png` | modified | 26258B -> 26317B | | `browser_tests/tests/rightClickMenu.spec.ts-snapshots/right-click-menu-chromium-linux.png` | modified | 101119B -> 98620B | | `browser_tests/tests/rightClickMenu.spec.ts-snapshots/right-click-node-chromium-linux.png` | modified | 107883B -> 105186B | | `browser_tests/tests/rightClickMenu.spec.ts-snapshots/right-click-node-collapsed-badge-chromium-linux.png` | modified | 92380B -> 89738B | | `browser_tests/tests/rightClickMenu.spec.ts-snapshots/selected-nodes-pinned-chromium-linux.png` | modified | 101217B -> 98472B | | `browser_tests/tests/selectionToolbox.spec.ts-snapshots/selection-toolbox-multiple-nodes-border-chromium-linux.png` | modified | 100692B -> 97759B | | `browser_tests/tests/selectionToolbox.spec.ts-snapshots/selection-toolbox-single-node-no-border-chromium-linux.png` | modified | 96560B -> 93613B | | `browser_tests/tests/viewport.spec.ts-snapshots/viewport-fits-when-saved-offscreen-chromium-linux.png` | modified | 104432B -> 104292B | | `browser_tests/tests/vueNodes/interactions/node/bringToFront.spec.ts-snapshots/bring-to-front-overlapped-before-chromium-linux.png` | modified | 62107B -> 60455B | | `browser_tests/tests/vueNodes/interactions/node/bringToFront.spec.ts-snapshots/bring-to-front-widget-overlapped-before-chromium-linux.png` | modified | 62855B -> 61069B | | `browser_tests/tests/vueNodes/nodeStates/colors.spec.ts-snapshots/vue-node-custom-colors-light-all-colors-chromium-linux.png` | modified | 146043B -> 146022B | | `browser_tests/tests/vueNodes/widgets/imageCrop.spec.ts-snapshots/image-crop-empty-state-chromium-linux.png` | modified | 20365B -> 18125B | | `browser_tests/tests/widget.spec.ts-snapshots/boolean-widget-chromium-linux.png` | modified | 41749B -> 40091B | | `browser_tests/tests/widget.spec.ts-snapshots/empty-latent-resized-80-percent-chromium-linux.png` | modified | 93968B -> 91319B | | `browser_tests/tests/widget.spec.ts-snapshots/image-preview-changed-by-combo-value-chromium-linux.png` | modified | 48790B -> 46966B | | `browser_tests/tests/widget.spec.ts-snapshots/image-preview-drag-and-dropped-chromium-linux.png` | modified | 48790B -> 46966B | | `browser_tests/tests/widget.spec.ts-snapshots/ksampler-widget-added-chromium-linux.png` | modified | 57462B -> 54695B | | `browser_tests/tests/widget.spec.ts-snapshots/load-audio-widget-chromium-linux.png` | modified | 47098B -> 45444B | | `browser_tests/tests/widget.spec.ts-snapshots/load-checkpoint-resized-min-width-chromium-linux.png` | modified | 99827B -> 97251B | | `browser_tests/tests/widget.spec.ts-snapshots/load-image-widget-chromium-linux.png` | modified | 54025B -> 51890B | | `browser_tests/tests/widget.spec.ts-snapshots/resized-to-original-chromium-linux.png` | modified | 93773B -> 91102B | | `browser_tests/tests/widget.spec.ts-snapshots/seed-widget-dragged-chromium-linux.png` | modified | 43966B -> 42324B | | `browser_tests/tests/widget.spec.ts-snapshots/slider-widget-dragged-chromium-linux.png` | modified | 41473B -> 39885B | | `browser_tests/tests/workspaceSwitcher.spec.ts-snapshots/workspace-switcher-scrolled-cloud-linux.png` | modified | 11220B -> 11218B | Screenshot capture is not bit-deterministic; small pixel deltas are usually text rasterization noise. Confirm each update corresponds to a test expected to change.
The CI-generated baselines now capture the intended theme colors. Remove the temporary strict color threshold at the owner’s request. Amp-Thread-ID: https://ampcode.com/threads/T-f28235a7-d36d-4d59-bca2-622f64e673b5
Compile published Vue components and declarations while keeping source exports for workspace consumers. Bundle the unpublished class-merging utility, preserve optional Vue usage for CSS consumers, and scan component classes from source and packed output. Amp-Thread-ID: https://ampcode.com/threads/T-f28235a7-d36d-4d59-bca2-622f64e673b5
📦 Bundle: 11.9 MB gzip 🟢 -261 BDetailsSummary
Category Glance App Entry Points — 6.49 kB (baseline 6.52 kB) • 🟢 -36 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 2.57 MB (baseline 2.57 MB) • 🔴 +6.08 kBGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 149 kB (baseline 148 kB) • 🔴 +574 BTop-level views, pages, and routed surfaces
Status: 15 added / 15 removed / 3 unchanged Panels & Settings — 874 kB (baseline 873 kB) • 🔴 +1.15 kBConfiguration panels, inspectors, and settings screens
Status: 17 added / 17 removed / 18 unchanged User & Accounts — 155 kB (baseline 154 kB) • 🔴 +194 BAuthentication, profile, and account management bundles
Status: 11 added / 11 removed / 5 unchanged Editors & Dialogs — 513 kB (baseline 513 kB) • 🔴 +549 BModals, dialogs, drawers, and in-app editors
Status: 14 added / 14 removed / 3 unchanged UI Components — 340 kB (baseline 337 kB) • 🔴 +3.08 kBReusable component library chunks
Status: 24 added / 25 removed / 6 unchanged Data & Services — 1.88 MB (baseline 1.88 MB) • 🔴 +307 BStores, services, APIs, and repositories
Status: 36 added / 36 removed / 5 unchanged Utilities & Hooks — 2.4 MB (baseline 2.4 MB) • 🔴 +2.87 kBHelpers, composables, and utility bundles
Status: 57 added / 57 removed / 23 unchanged Vendor & Third-Party — 9.69 MB (baseline 9.69 MB) • 🔴 +73 BExternal libraries and shared vendor chunks
Status: 3 added / 3 removed / 13 unchanged Other — 34.7 MB (baseline 34.7 MB) • 🟢 -2.81 kBBundles that do not match a named category
Status: 172 added / 174 removed / 568 unchanged ⚡ Performance
🎭 Playwright: ✅ 3132 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsFallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (915 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 9243ab46a527c4a38d34bd305ff6f35afe6b6536
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (205)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog 🌐 Website E2ETip All tests passed. Test results
🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-21240.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. Deployment detailsThis commit: https://website-frontend-k51838d52-comfyui.vercel.app Last updated: 2026-10-22T01:22:32Z for |
|
Important Review skippedToo many files! This PR contains 910 files, which is 610 over the limit of 300. To get a review, reduce the PR to 300 files or fewer by splitting it into smaller PRs or changing its base branch. Usage-priced reviews support at most 300 files.
|
comfy-greenlight-bot
left a comment
There was a problem hiding this comment.
This pull request at head commit db0e551 has been reviewed and approved by Swarmhost's agentic review process.
The detailed evaluation is available to employees in the internal Slack review thread.
The 1.60.0 locale sync removed commands.Comfy_3DViewer_Open3DViewer from en/commands.json while Load3DViewerButton.vue still references it, failing vue-i18n/no-missing-keys in the merge queue lint for PRs touching that file. Amp-Thread-ID: https://ampcode.com/threads/T-de5ae942-c5b2-4692-8855-2b05b92ff412
9dfaeb4
…-card-components Amp-Thread-ID: https://ampcode.com/threads/T-de5ae942-c5b2-4692-8855-2b05b92ff412 # Conflicts: # src/components/rightSidePanel/errors/MissingPackGroupRow.vue
Main moved the ui components into @comfyorg/design-system in #21240.
Main moved the ui components into @comfyorg/design-system in #21240.
Summary
Move app-independent components, supporting types, recipes, pure stories, and their tests into
@comfyorg/design-system. App wrappers with stores, translations, or app state remain app-owned. This PR also carries #21499 (components freed by #21396 and #21420) and the rootPopoverfreed by #21411.Workspace imports use Vue source. Published imports use compiled ES modules and ordinary declarations with Bundler resolution; every published component and
lib/*export has adefaultcondition.clsxandtailwind-mergeare declared dependencies and stay external, so consumers share one class-merging runtime. Scoped component CSS is exported separately and is published-only. Reka and its type-helper prerequisite are peers, optional for CSS-only consumers.MenuContentandMenuSubContentportal their own content, andMenuSubContentmust be rendered insideMenuSub. Context menus use the newContextMenuContent. Keyed menus skip the close animation, as fix: use one overlay tier with reopen-aware portal ordering #21396 accepts.DialogueandImageLightboxare built on the design-system dialog parts. The checkout saved-method picker uses the design-systemSingleSelect.DeploymentSwitcherRowstays in the app.DialogOrderingstories, and the component guidance (AGENTS.md) move into the package, which runs its own Vitest with happy-dom.Intended visual changes:
Dialogueuses thesmdialog size (384px) and the dialog surface.BillingAutoTopUpCardusesdestructive; its previousdestructive-backgroundtoken does not exist.PopoverContentdefaultscollisionPaddingto 8.Verification
Buttonand a searchable select throughfuse.js), Tailwind compilation, and scoped-animation checks. CI and the publish workflow run it.architecture:check, affected app unit tests, and the node-search E2E specs pass.DialogPanel, andDialogCloserender correctly.Two-way door. Mostly import-path churn. The main risks are unresolved package imports, duplicate provider contexts, and missing compiled styles or declarations. This PR does not publish a package.