Skip to content

refactor: move freed components into design system - #21499

Merged
DrJKL merged 27 commits into
design-system/extract-card-componentsfrom
design-system/move-freed-components
Oct 21, 2026
Merged

DrJKL merged 27 commits into
design-system/extract-card-componentsfrom
design-system/move-freed-components

Conversation

@DrJKL

@DrJKL DrJKL commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

Summary

Stacked on #21240. #21396 and #21420 removed the modal-stack and translation dependencies that kept these components in the app, so they move into @comfyorg/design-system with the same conventions: package specifiers, lib/* exports for .ts modules, pure stories alongside, app callers repointed with no re-export shims.

 @comfyorg/design-system
+  button, tooltip (TextTooltip, TooltipContent), PopoverContent, HoverCardContent
+  menu (Menu, ContextMenu, MenuItems, MenuSubmenu, MenuRadioGroup, MenuItemContent,
+        MenuAction, MenuContent, MenuSubContent) + mouse-repeat helper
+  Badge, Message, Spinner, Pagination, TableSortHead, TreeItem, PasswordInput, InputGroupButton
+  dialog (DialogClose, DialogMaximize, DialogPanel)
+  toast (ToastClose, ToastDock, ToastViewport)
+  search-input (SearchInput, SearchAutocomplete, AsyncSearchInput)
+  select (SelectContent, SingleSelect, SearchableSingleSelect, MultiSelect, MultiSelectContent)
+    + useSelectSearch, useAttrsClass, usePopoverSizing
+  NumberFieldIncrement/Decrement, TagsInputItemDelete, TagRemoveButton
 app
-  Toaster (ui) + AppToaster (wrapper)
+  AppToaster (one component: queue rendering, announcements, labels)

Evidence

  • Before: declaration emit silently failed for SingleSelect, MultiSelect, and MenuRadioGroup (private prop/option types). The build exited 0, but a packed consumer importing one got TS7016.
    After: the prop and option types are exported, every component ships a .vue.d.ts, and the packed-consumer check now SSR-renders a moved Button and a searchable select through fuse.js, plus a lib/menu/types type.
  • Package typecheck, build, tests, and the isolated non-hoisted packed-consumer check pass. App and browser typechecks, Knip, ESLint, oxlint, architecture check, Fallow audit, and Storybook build pass. Affected unit tests pass: the moved components' tests, AppToaster, and the sibling tests of every repointed caller.
  • Storybook checks: toasts of every kind, a select listbox and a nested menu above an open dialog, DialogPanel, and a dialog with DialogClose all render as before.

Merge Danger

Door: two-way

Blast Radius: imports

Mostly import-path churn. The risks are a missed import or a missing published declaration; typechecks and the packed consumer cover both. No intended visual change.

DrJKL added 2 commits October 20, 2026 23:45
Move the UI components that no longer depend on app stores, translations,
or modal-stack state into @comfyorg/design-system, with their helper
modules and pure stories, and repoint app callers to package specifiers.
Expose the type and helper modules app code still imports as lib exports.

Fold the toast renderer into AppToaster so the app owns one toast component.

Export the prop and option types that declaration emit needs, so
SingleSelect, MultiSelect, and MenuRadioGroup ship declarations, and extend
the packed-consumer check to render a moved button and searchable select.
The design system's select search imports @vueuse/integrations/useFuse,
whose optional fuse.js peer the package must install for consumers. Fallow
cannot see that import, so ignore the dependency instead of dropping it;
an isolated packed consumer fails with ERR_MODULE_NOT_FOUND without it.
@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: 176cf4ed-f436-449a-9c0b-0dfc3f519a4e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

❌ 8 scenarios below the ≥52 P5 FPS target. Expand the scenario timings below and profile the affected scenarios before merging.

Scenario timings

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 102.4 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 89.9 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 107.0 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 99.0 MB heap
dom-widget-order-dense-n200-w200-i120: · 32.9 avg FPS · 39.8 P5 FPS ❌ (target: ≥52) · 400ms TBT · 118.6 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 45.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 119ms TBT · 99.0 MB heap
extension-clean-combined-draw: · 39.7 avg FPS · 24.0 P5 FPS ❌ (target: ≥52) · 19ms TBT · 105.3 MB heap
extension-rgthree-prototype-draw: · 39.8 avg FPS · 29.9 P5 FPS ❌ (target: ≥52) · 15ms TBT · 101.1 MB heap
large-combo-open: · 47.3 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 107.9 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 99.6 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 95.9 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 94.7 MB heap
legacy-node-drag: · 59.5 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 99.0 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 98.1 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 110.0 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 92.6 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 101.0 MB heap
subgraph-transition-enter: · 48.7 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 127ms TBT · 134.7 MB heap
viewport-pan-sweep: · 59.9 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 108.1 MB heap
vue-large-graph-idle: · 48.0 avg FPS · 39.8 P5 FPS ❌ (target: ≥52) · 0ms TBT · 285.6 MB heap
vue-large-graph-pan: · 33.4 avg FPS · 17.1 P5 FPS ❌ (target: ≥52) · 0ms TBT · 284.0 MB heap
vue-node-resize-workload: · 36.7 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 281.4 MB heap
vue-zoom-out-idle: · 48.9 avg FPS · 39.8 P5 FPS ❌ (target: ≥52) · 0ms TBT · 275.4 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 102.0 MB heap
agent-composer-empty-conversation-typing: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 94.0 MB heap
agent-composer-long-conversation-typing: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 112.5 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 2ms
canvas-idle: style recalc duration 2ms
canvas-idle: layout count 10
canvas-idle: style recalc count 10
canvas-idle: task duration 409ms
canvas-idle: script duration 7ms
canvas-idle: TBT 0ms
canvas-idle: heap used 102.4 MB
canvas-idle: DOM nodes -192
canvas-idle: event listeners -130
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 2ms
canvas-mouse-sweep: style recalc duration 9ms
canvas-mouse-sweep: layout count 10
canvas-mouse-sweep: style recalc count 82
canvas-mouse-sweep: task duration 905ms
canvas-mouse-sweep: script duration 106ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 89.9 MB
canvas-mouse-sweep: DOM nodes -192
canvas-mouse-sweep: event listeners -130
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 2ms
canvas-zoom-sweep: style recalc duration 4ms
canvas-zoom-sweep: layout count 12
canvas-zoom-sweep: style recalc count 18
canvas-zoom-sweep: task duration 311ms
canvas-zoom-sweep: script duration 8ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 107.0 MB
canvas-zoom-sweep: DOM nodes 58
canvas-zoom-sweep: event listeners 42
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 2ms
dom-widget-clipping: style recalc duration 2ms
dom-widget-clipping: layout count 10
dom-widget-clipping: style recalc count 14
dom-widget-clipping: task duration 343ms
dom-widget-clipping: script duration 124ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 99.0 MB
dom-widget-clipping: DOM nodes 0
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 30ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 25ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 676ms
dom-widget-order-dense-n200-w200-i120: script duration 41ms
dom-widget-order-dense-n200-w200-i120: TBT 400ms
dom-widget-order-dense-n200-w200-i120: heap used 118.6 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes -86
dom-widget-order-dense-n200-w200-i120: event listeners -84
dom-widget-order-sparse-n1000-w20-i120: avg frame time 22ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 346ms
dom-widget-order-sparse-n1000-w20-i120: script duration 101ms
dom-widget-order-sparse-n1000-w20-i120: TBT 119ms
dom-widget-order-sparse-n1000-w20-i120: heap used 99.0 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 25ms
extension-clean-combined-draw: p95 frame time 42ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 0ms
extension-clean-combined-draw: layout count 1
extension-clean-combined-draw: style recalc count 1
extension-clean-combined-draw: task duration 5787ms
extension-clean-combined-draw: script duration 4708ms
extension-clean-combined-draw: TBT 19ms
extension-clean-combined-draw: heap used 105.3 MB
extension-clean-combined-draw: DOM nodes 0
extension-clean-combined-draw: event listeners 0
extension-rgthree-prototype-draw: avg frame time 25ms
extension-rgthree-prototype-draw: p95 frame time 33ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 0ms
extension-rgthree-prototype-draw: layout count 0
extension-rgthree-prototype-draw: style recalc count 0
extension-rgthree-prototype-draw: task duration 5452ms
extension-rgthree-prototype-draw: script duration 4267ms
extension-rgthree-prototype-draw: TBT 15ms
extension-rgthree-prototype-draw: heap used 101.1 MB
extension-rgthree-prototype-draw: DOM nodes 0
extension-rgthree-prototype-draw: event listeners 0
large-combo-open: avg frame time 21ms
large-combo-open: p95 frame time 50ms
large-combo-open: layout duration 2ms
large-combo-open: style recalc duration 10ms
large-combo-open: layout count 11
large-combo-open: style recalc count 23
large-combo-open: task duration 117ms
large-combo-open: script duration 6ms
large-combo-open: TBT 0ms
large-combo-open: heap used 107.9 MB
large-combo-open: DOM nodes 936
large-combo-open: event listeners 205
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 1ms
large-graph-idle: style recalc duration 1ms
large-graph-idle: layout count 7
large-graph-idle: style recalc count 8
large-graph-idle: task duration 482ms
large-graph-idle: script duration 24ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 99.6 MB
large-graph-idle: DOM nodes -278
large-graph-idle: event listeners -130
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 2ms
large-graph-pan: style recalc duration 5ms
large-graph-pan: layout count 8
large-graph-pan: style recalc count 69
large-graph-pan: task duration 1232ms
large-graph-pan: script duration 565ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 95.9 MB
large-graph-pan: DOM nodes -278
large-graph-pan: event listeners -128
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 7ms
large-graph-zoom: style recalc duration 6ms
large-graph-zoom: layout count 64
large-graph-zoom: style recalc count 70
large-graph-zoom: task duration 1154ms
large-graph-zoom: script duration 503ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 94.7 MB
large-graph-zoom: DOM nodes 24
large-graph-zoom: event listeners 0
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 1ms
legacy-node-drag: style recalc duration 2ms
legacy-node-drag: layout count 4
legacy-node-drag: style recalc count 43
legacy-node-drag: task duration 1303ms
legacy-node-drag: script duration 642ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 99.0 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 182
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 1ms
minimap-idle: style recalc duration 1ms
minimap-idle: layout count 6
minimap-idle: style recalc count 7
minimap-idle: task duration 494ms
minimap-idle: script duration 22ms
minimap-idle: TBT 0ms
minimap-idle: heap used 98.1 MB
minimap-idle: DOM nodes -149
minimap-idle: event listeners -65
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 2ms
subgraph-dom-widget-clipping: style recalc duration 3ms
subgraph-dom-widget-clipping: layout count 9
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 317ms
subgraph-dom-widget-clipping: script duration 99ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 110.0 MB
subgraph-dom-widget-clipping: DOM nodes 0
subgraph-dom-widget-clipping: event listeners 46
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 2ms
subgraph-idle: style recalc duration 2ms
subgraph-idle: layout count 10
subgraph-idle: style recalc count 11
subgraph-idle: task duration 423ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 92.6 MB
subgraph-idle: DOM nodes -220
subgraph-idle: event listeners -176
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 2ms
subgraph-mouse-sweep: style recalc duration 10ms
subgraph-mouse-sweep: layout count 11
subgraph-mouse-sweep: style recalc count 81
subgraph-mouse-sweep: task duration 723ms
subgraph-mouse-sweep: script duration 72ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 101.0 MB
subgraph-mouse-sweep: DOM nodes -220
subgraph-mouse-sweep: event listeners -176
subgraph-transition-enter: avg frame time 21ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 11ms
subgraph-transition-enter: style recalc duration 19ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 635ms
subgraph-transition-enter: script duration 18ms
subgraph-transition-enter: TBT 127ms
subgraph-transition-enter: heap used 134.7 MB
subgraph-transition-enter: DOM nodes 16030
subgraph-transition-enter: event listeners 3244
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 1ms
viewport-pan-sweep: style recalc duration 16ms
viewport-pan-sweep: layout count 7
viewport-pan-sweep: style recalc count 249
viewport-pan-sweep: task duration 3940ms
viewport-pan-sweep: script duration 1814ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 108.1 MB
viewport-pan-sweep: DOM nodes -278
viewport-pan-sweep: event listeners -128
vue-large-graph-idle: avg frame time 21ms
vue-large-graph-idle: p95 frame time 25ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 11114ms
vue-large-graph-idle: script duration 120ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 285.6 MB
vue-large-graph-idle: DOM nodes -3343
vue-large-graph-idle: event listeners -653
vue-large-graph-pan: avg frame time 30ms
vue-large-graph-pan: p95 frame time 58ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 11ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 123
vue-large-graph-pan: task duration 16335ms
vue-large-graph-pan: script duration 619ms
vue-large-graph-pan: TBT 0ms
vue-large-graph-pan: heap used 284.0 MB
vue-large-graph-pan: DOM nodes -3343
vue-large-graph-pan: event listeners -651
vue-node-resize-workload: avg frame time 27ms
vue-node-resize-workload: p95 frame time 50ms
vue-node-resize-workload: layout duration 17ms
vue-node-resize-workload: style recalc duration 48ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 4322ms
vue-node-resize-workload: script duration 69ms
vue-node-resize-workload: TBT 0ms
vue-node-resize-workload: heap used 281.4 MB
vue-node-resize-workload: DOM nodes -3343
vue-node-resize-workload: event listeners -653
vue-zoom-out-idle: avg frame time 20ms
vue-zoom-out-idle: p95 frame time 25ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 5573ms
vue-zoom-out-idle: script duration 61ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 275.4 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners 0
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 5ms
workflow-execution: layout count 6
workflow-execution: style recalc count 7
workflow-execution: task duration 60ms
workflow-execution: script duration 6ms
workflow-execution: TBT 0ms
workflow-execution: heap used 102.0 MB
workflow-execution: DOM nodes 113
workflow-execution: event listeners 4
agent-composer-empty-conversation-typing: avg frame time 17ms
agent-composer-empty-conversation-typing: p95 frame time 17ms
agent-composer-empty-conversation-typing: layout duration 13ms
agent-composer-empty-conversation-typing: style recalc duration 1ms
agent-composer-empty-conversation-typing: layout count 76
agent-composer-empty-conversation-typing: style recalc count 5
agent-composer-empty-conversation-typing: task duration 242ms
agent-composer-empty-conversation-typing: script duration 112ms
agent-composer-empty-conversation-typing: TBT 0ms
agent-composer-empty-conversation-typing: heap used 94.0 MB
agent-composer-empty-conversation-typing: DOM nodes 4
agent-composer-empty-conversation-typing: event listeners 292
agent-composer-long-conversation-typing: avg frame time 17ms
agent-composer-long-conversation-typing: p95 frame time 17ms
agent-composer-long-conversation-typing: layout duration 13ms
agent-composer-long-conversation-typing: style recalc duration 1ms
agent-composer-long-conversation-typing: layout count 76
agent-composer-long-conversation-typing: style recalc count 5
agent-composer-long-conversation-typing: task duration 281ms
agent-composer-long-conversation-typing: script duration 104ms
agent-composer-long-conversation-typing: TBT 0ms
agent-composer-long-conversation-typing: heap used 112.5 MB
agent-composer-long-conversation-typing: DOM nodes 4
agent-composer-long-conversation-typing: event listeners 292
Raw data
{
  "timestamp": "2026-10-21T17:57:21.495Z",
  "gitSha": "7a38e3a465ec925a1e5739c7005cc5c9a4216fb7",
  "branch": "design-system/move-freed-components",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2027.31,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 1.844,
      "layouts": 10,
      "layoutDurationMs": 1.895,
      "taskDurationMs": 356.41799999999995,
      "heapDeltaBytes": 1716364,
      "heapUsedBytes": 105976400,
      "domNodes": -202,
      "jsHeapTotalBytes": 2072576,
      "scriptDurationMs": 7.046,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6655737704918,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2040.8459999999877,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 1.6239999999999997,
      "layouts": 9,
      "layoutDurationMs": 1.907,
      "taskDurationMs": 462.48999999999995,
      "heapDeltaBytes": 11887356,
      "heapUsedBytes": 108678100,
      "domNodes": -182,
      "jsHeapTotalBytes": -1691648,
      "scriptDurationMs": 7.5680000000000005,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665853658536587,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1962.707000000023,
      "styleRecalcs": 82,
      "styleRecalcDurationMs": 8.95,
      "layouts": 10,
      "layoutDurationMs": 1.996,
      "taskDurationMs": 890.18,
      "heapDeltaBytes": -8652372,
      "heapUsedBytes": 95255684,
      "domNodes": -202,
      "jsHeapTotalBytes": 2240512,
      "scriptDurationMs": 103.36999999999999,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66610169491526,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1991.0050000000297,
      "styleRecalcs": 82,
      "styleRecalcDurationMs": 9.068999999999999,
      "layouts": 10,
      "layoutDurationMs": 2.039,
      "taskDurationMs": 920.4679999999998,
      "heapDeltaBytes": -19122412,
      "heapUsedBytes": 93278188,
      "domNodes": -182,
      "jsHeapTotalBytes": 2920448,
      "scriptDurationMs": 109.05000000000001,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665833333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1726.2249999999995,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 3.6149999999999998,
      "layouts": 12,
      "layoutDurationMs": 2.241,
      "taskDurationMs": 313.839,
      "heapDeltaBytes": -2712088,
      "heapUsedBytes": 105195564,
      "domNodes": 58,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 8.006999999999998,
      "eventListeners": 42,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666346153846156,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1725.4219999999805,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 3.593,
      "layouts": 11,
      "layoutDurationMs": 2.04,
      "taskDurationMs": 307.54499999999996,
      "heapDeltaBytes": 21917852,
      "heapUsedBytes": 119177096,
      "domNodes": 58,
      "jsHeapTotalBytes": 3145728,
      "scriptDurationMs": 8.722,
      "eventListeners": 42,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666346153846153,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 517.1970000000101,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 1.9950000000000003,
      "layouts": 10,
      "layoutDurationMs": 1.8150000000000002,
      "taskDurationMs": 328.85699999999997,
      "heapDeltaBytes": 4744892,
      "heapUsedBytes": 108983012,
      "domNodes": 0,
      "jsHeapTotalBytes": 7864320,
      "scriptDurationMs": 124.551,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.667741935483864,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 549.4489999999814,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 1.6640000000000001,
      "layouts": 9,
      "layoutDurationMs": 1.9449999999999998,
      "taskDurationMs": 358.006,
      "heapDeltaBytes": 1274468,
      "heapUsedBytes": 98541552,
      "domNodes": 0,
      "jsHeapTotalBytes": 3932160,
      "scriptDurationMs": 124.00900000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.669696969696982,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1069.439999999986,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 710.3479999999998,
      "heapDeltaBytes": 5651248,
      "heapUsedBytes": 132926764,
      "domNodes": -172,
      "jsHeapTotalBytes": 14438400,
      "scriptDurationMs": 39.800000000000004,
      "eventListeners": -168,
      "totalBlockingTimeMs": 421,
      "frameDurationMs": 30.474285714285724,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 992.4729999999613,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 641.1490000000001,
      "heapDeltaBytes": 18824360,
      "heapUsedBytes": 115802192,
      "domNodes": 0,
      "jsHeapTotalBytes": 9338880,
      "scriptDurationMs": 41.52,
      "eventListeners": 0,
      "totalBlockingTimeMs": 379,
      "frameDurationMs": 30.303030303030305,
      "p95FrameDurationMs": 33.399999999999636
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 731.7869999999971,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 340.7070000000001,
      "heapDeltaBytes": -3259640,
      "heapUsedBytes": 103502308,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 98.47599999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 118,
      "frameDurationMs": 22.221212121212126,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 748.2469999999921,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 352.11799999999994,
      "heapDeltaBytes": -2502780,
      "heapUsedBytes": 104196060,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 103.12000000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 120,
      "frameDurationMs": 22.058823529411764,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 7141.713999999979,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 0.13400000000000045,
      "layouts": 1,
      "layoutDurationMs": 0.1349999999999997,
      "taskDurationMs": 6283.15,
      "heapDeltaBytes": 8844992,
      "heapUsedBytes": 120981596,
      "domNodes": 0,
      "jsHeapTotalBytes": 9437184,
      "scriptDurationMs": 5161.514,
      "eventListeners": 0,
      "totalBlockingTimeMs": 37,
      "frameDurationMs": 25.384697508896796,
      "p95FrameDurationMs": 49.899999999999636
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 6141.385999999955,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5290.266,
      "heapDeltaBytes": -11890364,
      "heapUsedBytes": 99764104,
      "domNodes": 0,
      "jsHeapTotalBytes": 4194304,
      "scriptDurationMs": 4254.736999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 24.93089430894309,
      "p95FrameDurationMs": 33.399999999999636
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 6456.215000000015,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5684.937,
      "heapDeltaBytes": 11543368,
      "heapUsedBytes": 114108376,
      "domNodes": 0,
      "jsHeapTotalBytes": 1310720,
      "scriptDurationMs": 4363.337,
      "eventListeners": 0,
      "totalBlockingTimeMs": 29,
      "frameDurationMs": 25.19453125,
      "p95FrameDurationMs": 33.400000000000546
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 6137.798999999973,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5219.004,
      "heapDeltaBytes": -14600252,
      "heapUsedBytes": 97957140,
      "domNodes": 0,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 4171.095,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 25.033469387755105,
      "p95FrameDurationMs": 33.400000000000546
    },
    {
      "name": "large-combo-open",
      "durationMs": 163.32800000000702,
      "styleRecalcs": 22,
      "styleRecalcDurationMs": 10.165000000000001,
      "layouts": 12,
      "layoutDurationMs": 2.7310000000000003,
      "taskDurationMs": 113.341,
      "heapDeltaBytes": 14527912,
      "heapUsedBytes": 119613500,
      "domNodes": 936,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 6.1789999999999985,
      "eventListeners": 205,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 21.44285714285713,
      "p95FrameDurationMs": 50
    },
    {
      "name": "large-combo-open",
      "durationMs": 169.18299999997544,
      "styleRecalcs": 23,
      "styleRecalcDurationMs": 10.142000000000001,
      "layouts": 10,
      "layoutDurationMs": 2.2500000000000004,
      "taskDurationMs": 121.54099999999998,
      "heapDeltaBytes": 14766992,
      "heapUsedBytes": 106648644,
      "domNodes": 936,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 6.523000000000001,
      "eventListeners": 205,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 20.825000000000045,
      "p95FrameDurationMs": 50
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2019.7969999999827,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 1.3999999999999997,
      "layouts": 7,
      "layoutDurationMs": 1.399,
      "taskDurationMs": 480.3599999999999,
      "heapDeltaBytes": -7313648,
      "heapUsedBytes": 104735020,
      "domNodes": -278,
      "jsHeapTotalBytes": -5234688,
      "scriptDurationMs": 24.09,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665289256198346,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2034.0960000000337,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 1.0280000000000002,
      "layouts": 6,
      "layoutDurationMs": 1.0399999999999996,
      "taskDurationMs": 483.4360000000001,
      "heapDeltaBytes": -7999276,
      "heapUsedBytes": 104210576,
      "domNodes": -278,
      "jsHeapTotalBytes": -6283264,
      "scriptDurationMs": 23.169999999999995,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6655737704918,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2149.597999999969,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 5.082,
      "layouts": 8,
      "layoutDurationMs": 1.6369999999999998,
      "taskDurationMs": 1241.2230000000002,
      "heapDeltaBytes": -35977012,
      "heapUsedBytes": 95019604,
      "domNodes": -278,
      "jsHeapTotalBytes": 1556480,
      "scriptDurationMs": 566.7139999999999,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2176.8859999999677,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 4.56,
      "layouts": 7,
      "layoutDurationMs": 3.19,
      "taskDurationMs": 1222.7079999999999,
      "heapDeltaBytes": -6143968,
      "heapUsedBytes": 106074688,
      "domNodes": -278,
      "jsHeapTotalBytes": -3960832,
      "scriptDurationMs": 563.628,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666153846153843,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3121.3659999999663,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 5.304999999999999,
      "layouts": 63,
      "layoutDurationMs": 6.973,
      "taskDurationMs": 1223.172,
      "heapDeltaBytes": 4144240,
      "heapUsedBytes": 99239080,
      "domNodes": 24,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 510.616,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66631016042781,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3105.606000000023,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 5.849,
      "layouts": 64,
      "layoutDurationMs": 7.469000000000001,
      "taskDurationMs": 1085.411,
      "heapDeltaBytes": 3607308,
      "heapUsedBytes": 99311408,
      "domNodes": 24,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 495.35300000000007,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666486486486487,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2152.082000000007,
      "styleRecalcs": 43,
      "styleRecalcDurationMs": 2.361,
      "layouts": 4,
      "layoutDurationMs": 0.5950000000000001,
      "taskDurationMs": 1216.901,
      "heapDeltaBytes": 5468344,
      "heapUsedBytes": 101247584,
      "domNodes": 0,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 634.635,
      "eventListeners": 182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.796093750000004,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2265.8010000000104,
      "styleRecalcs": 42,
      "styleRecalcDurationMs": 2.4540000000000006,
      "layouts": 3,
      "layoutDurationMs": 0.503,
      "taskDurationMs": 1388.619,
      "heapDeltaBytes": 8849588,
      "heapUsedBytes": 106359744,
      "domNodes": 0,
      "jsHeapTotalBytes": 5206016,
      "scriptDurationMs": 650.086,
      "eventListeners": 182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.789629629629633,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2021.6559999999504,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 0.6879999999999994,
      "layouts": 4,
      "layoutDurationMs": 0.7109999999999999,
      "taskDurationMs": 456.65299999999996,
      "heapDeltaBytes": 11212240,
      "heapUsedBytes": 104483764,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 20.154000000000003,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2050.0469999999495,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 1.8409999999999997,
      "layouts": 8,
      "layoutDurationMs": 1.652,
      "taskDurationMs": 531.384,
      "heapDeltaBytes": -12809800,
      "heapUsedBytes": 101197992,
      "domNodes": -298,
      "jsHeapTotalBytes": -5386240,
      "scriptDurationMs": 23.209999999999994,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665853658536584,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 527.8099999999881,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 3.2569999999999997,
      "layouts": 9,
      "layoutDurationMs": 1.671,
      "taskDurationMs": 312.887,
      "heapDeltaBytes": 22863480,
      "heapUsedBytes": 120306068,
      "domNodes": 0,
      "jsHeapTotalBytes": 3145728,
      "scriptDurationMs": 98.706,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.668750000000003,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 515.6190000000151,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 3.291,
      "layouts": 9,
      "layoutDurationMs": 1.5469999999999997,
      "taskDurationMs": 321.67900000000003,
      "heapDeltaBytes": -164356,
      "heapUsedBytes": 110321128,
      "domNodes": 0,
      "jsHeapTotalBytes": 8126464,
      "scriptDurationMs": 99.912,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.664516129032254,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2027.830999999992,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 2.0180000000000002,
      "layouts": 10,
      "layoutDurationMs": 1.903,
      "taskDurationMs": 375.32500000000005,
      "heapDeltaBytes": 6014320,
      "heapUsedBytes": 105823804,
      "domNodes": -220,
      "jsHeapTotalBytes": 2334720,
      "scriptDurationMs": 6.369999999999999,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66639344262295,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2025.1260000000002,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 1.8309999999999997,
      "layouts": 10,
      "layoutDurationMs": 1.7810000000000001,
      "taskDurationMs": 470.216,
      "heapDeltaBytes": -13608156,
      "heapUsedBytes": 88312808,
      "domNodes": -220,
      "jsHeapTotalBytes": 3399680,
      "scriptDurationMs": 6.691000000000001,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666393442622947,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1979.263000000003,
      "styleRecalcs": 86,
      "styleRecalcDurationMs": 9.599,
      "layouts": 11,
      "layoutDurationMs": 1.9779999999999998,
      "taskDurationMs": 895.819,
      "heapDeltaBytes": 2156300,
      "heapUsedBytes": 110132444,
      "domNodes": -220,
      "jsHeapTotalBytes": 2613248,
      "scriptDurationMs": 72.729,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665546218487393,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1692.764000000011,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 9.482,
      "layouts": 10,
      "layoutDurationMs": 1.8630000000000002,
      "taskDurationMs": 550.7330000000001,
      "heapDeltaBytes": -4659532,
      "heapUsedBytes": 101626396,
      "domNodes": -220,
      "jsHeapTotalBytes": 3383296,
      "scriptDurationMs": 71.361,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.664705882352944,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 883.3369999999832,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 18.832,
      "layouts": 5,
      "layoutDurationMs": 10.672999999999998,
      "taskDurationMs": 634.8800000000001,
      "heapDeltaBytes": 11548948,
      "heapUsedBytes": 141261900,
      "domNodes": 16030,
      "jsHeapTotalBytes": 16392192,
      "scriptDurationMs": 18.355999999999998,
      "eventListeners": 3244,
      "totalBlockingTimeMs": 127,
      "frameDurationMs": 20.541860465116283,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8160.5220000000145,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 15.555,
      "layouts": 6,
      "layoutDurationMs": 0.9989999999999999,
      "taskDurationMs": 3689.6439999999993,
      "heapDeltaBytes": -12459088,
      "heapUsedBytes": 113364096,
      "domNodes": -278,
      "jsHeapTotalBytes": -4091904,
      "scriptDurationMs": 1824.158,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.700204918032785,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8176.024000000041,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 15.446,
      "layouts": 7,
      "layoutDurationMs": 1.1629999999999998,
      "taskDurationMs": 4189.541,
      "heapDeltaBytes": -14308944,
      "heapUsedBytes": 113311696,
      "domNodes": -278,
      "jsHeapTotalBytes": -4710400,
      "scriptDurationMs": 1803.997,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666053169734152,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 10266.769000000011,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8972.564999999999,
      "heapDeltaBytes": -297876,
      "heapUsedBytes": 309853664,
      "domNodes": -3343,
      "jsHeapTotalBytes": 30920704,
      "scriptDurationMs": 108.85600000000001,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.579109589041096,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 14325.079999999958,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13256.381,
      "heapDeltaBytes": -26365816,
      "heapUsedBytes": 289132212,
      "domNodes": -3343,
      "jsHeapTotalBytes": 17551360,
      "scriptDurationMs": 131.334,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 24.101346801346807,
      "p95FrameDurationMs": 33.400000000001455
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 16867.418999999983,
      "styleRecalcs": 120,
      "styleRecalcDurationMs": 10.727000000000015,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16355.509000000002,
      "heapDeltaBytes": -40681400,
      "heapUsedBytes": 284085484,
      "domNodes": -3343,
      "jsHeapTotalBytes": 8638464,
      "scriptDurationMs": 611.735,
      "eventListeners": -651,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 30.01067615658363,
      "p95FrameDurationMs": 50.10000000000218
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 16895.903999999973,
      "styleRecalcs": 126,
      "styleRecalcDurationMs": 10.881000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16314.050000000001,
      "heapDeltaBytes": -13536776,
      "heapUsedBytes": 311519476,
      "domNodes": -3343,
      "jsHeapTotalBytes": 6471680,
      "scriptDurationMs": 627.244,
      "eventListeners": -651,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 29.857420494699646,
      "p95FrameDurationMs": 66.60000000000218
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5192.201999999952,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 47.349000000000004,
      "layouts": 20,
      "layoutDurationMs": 16.547000000000008,
      "taskDurationMs": 5031.807,
      "heapDeltaBytes": -35243068,
      "heapUsedBytes": 289430752,
      "domNodes": -3343,
      "jsHeapTotalBytes": 17289216,
      "scriptDurationMs": 81.033,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 31.036526946107788,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 3837.350000000015,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 47.802000000000014,
      "layouts": 20,
      "layoutDurationMs": 17.161999999999995,
      "taskDurationMs": 3612.4570000000003,
      "heapDeltaBytes": -14633808,
      "heapUsedBytes": 300648080,
      "domNodes": -3343,
      "jsHeapTotalBytes": 33280000,
      "scriptDurationMs": 56.49,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 23.516564417177914,
      "p95FrameDurationMs": 50
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 5118.41499999997,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4447.481,
      "heapDeltaBytes": -22543248,
      "heapUsedBytes": 291276220,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 51.826000000000036,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.941721854304628,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7152.014000000008,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6699.187999999997,
      "heapDeltaBytes": -8734132,
      "heapUsedBytes": 286211304,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 69.19199999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 23.992281879194632,
      "p95FrameDurationMs": 33.400000000001455
    },
    {
      "name": "workflow-execution",
      "durationMs": 91.28200000003517,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 4.8149999999999995,
      "layouts": 6,
      "layoutDurationMs": 1.2949999999999997,
      "taskDurationMs": 61.925,
      "heapDeltaBytes": 4812660,
      "heapUsedBytes": 106903280,
      "domNodes": 101,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 6.737,
      "eventListeners": 3,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "workflow-execution",
      "durationMs": 86.037000000033,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 5.4319999999999995,
      "layouts": 5,
      "layoutDurationMs": 1.9719999999999998,
      "taskDurationMs": 57.75000000000001,
      "heapDeltaBytes": 4676440,
      "heapUsedBytes": 107017320,
      "domNodes": 125,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 4.947,
      "eventListeners": 5,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.67999999999993,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 287.95099999990725,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 0.523,
      "layouts": 76,
      "layoutDurationMs": 12.86,
      "taskDurationMs": 238.85099999999997,
      "heapDeltaBytes": 10300960,
      "heapUsedBytes": 98727184,
      "domNodes": 4,
      "jsHeapTotalBytes": 9961472,
      "scriptDurationMs": 110.233,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670588235294122,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 279.65500000004795,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 0.506,
      "layouts": 76,
      "layoutDurationMs": 13.145999999999999,
      "taskDurationMs": 245.336,
      "heapDeltaBytes": 10326368,
      "heapUsedBytes": 98474744,
      "domNodes": 4,
      "jsHeapTotalBytes": 10223616,
      "scriptDurationMs": 113.64200000000001,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.664705882352926,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 328.2850000000508,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 1.599,
      "layouts": 76,
      "layoutDurationMs": 12.757,
      "taskDurationMs": 287.79,
      "heapDeltaBytes": -872552,
      "heapUsedBytes": 118832276,
      "domNodes": 4,
      "jsHeapTotalBytes": 1437696,
      "scriptDurationMs": 107.918,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66500000000001,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 306.3449999999648,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 1.3619999999999999,
      "layouts": 76,
      "layoutDurationMs": 12.478,
      "taskDurationMs": 274.157,
      "heapDeltaBytes": -1364628,
      "heapUsedBytes": 117030204,
      "domNodes": 4,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 100.218,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66842105263157,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Line coverage: 64.3%

Coverage totals
Metric Covered Total Pct
Lines 57747 89841 64.3% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 66.9% 1175
src/LGraphNode.ts 71.3% 379
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 39.6% 332
src/platform/workspace/stores/billingOperationStore.ts 8.2% 313
src/workbench/extensions/agent/crdt/docOpMinter.ts 0.6% 312
src/core/billing/operationLifecycle.ts 1.3% 303
src/platform/workspace/components/TopUpCreditsDialogContentWorkspace.vue 1.1% 280
src/LGraph.ts 78.9% 274
src/platform/workspace/stores/teamWorkspaceStore.ts 46.8% 252
src/core/webSessionIdentity.ts 3.3% 231

🎭 Playwright: ✅ 3001 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 2307 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • cloud: View Report (✅ 665 / ❌ 0 / ⚠️ 2 / ⏭️ 0)
  • desktop: View Report (✅ 4 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 19 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-safari: View Report (✅ 3 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/21/2026, 09:53:57 PM UTC

Links

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

No verdict is available. Open the workflow run to confirm the check was intentionally skipped, or fix the collection failure and re-run it.

Findings and check details

The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

Findings and check details

Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (1030 changed files).

Kind Finding Where Usual remedy
Complexity <template>() — cyclomatic 13, CRAP undefined src/platform/cloud/oauth/OAuthConsentView.vue:3 Extract a branch, or raise branch coverage — CRAP is CC² × (1−cov)³ + CC, so either moves it.

Pre-existing findings are baselined in .fallow-baselines/ and are not your
responsibility — see ADR-DEVEX-LINT-0015.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 356617cdf4826d47a8ffa5591a9e8e92da3cf113

Full docs: ADR-DEVEX-LINT-0015

🏛️ Architecture: ✅ Passed

Findings and check details

Warnings (130)

  • billing path matches no source files: src/components/dialog/content/credit/**. Remove or update it in docs/architecture/domains/records/billing.domain.json.
  • design-system path matches no source files: src/components/ui/input-group/**. Remove or update it in docs/architecture/domains/records/design-system.domain.json.
  • design-system path matches no source files: src/composables/useAttrsClass.ts. Remove or update it in docs/architecture/domains/records/design-system.domain.json.
  • design-system path matches no source files: src/composables/usePopoverSizing.ts. Remove or update it in docs/architecture/domains/records/design-system.domain.json.
  • design-system path matches no source files: src/utils/mouseDownUtil.ts. Remove or update it in docs/architecture/domains/records/design-system.domain.json.
  • workspace path matches no source files: src/platform/workspace/fixtures/**. Remove or update it in docs/architecture/domains/records/workspace.domain.json.
  • src/components/TopbarActions.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/graph/selectionToolbox/LinkSelectionActions.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/searchbox/v2/filterChip.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/billing/useSubscriptionPaywall.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/billing/useSubscriptionPaywall.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/graph/menuOption.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/litegraphServiceAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/nodeDef/ComfyNodeDefImpl.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/selection/selectionIntent.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/agentPanel.historyIdentity.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/cameraInfo.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/dynamicPrompts.serializeValue.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dHost.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dHost.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dInstances.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/reportLoadModelOutcome.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/reportLoadModelOutcome.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/i18n.literalMessages.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/LiteGraphGlobal.cloneObject.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/canvasClassAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkHideTransition.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkHideTransition.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkSelection.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkSelection.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkSnapGeometry.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkSnapGeometry.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/authStoreAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/currentUserAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/sessionCookieAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/sessionRevokedError.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/webSessionFetch.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/sso/ssoRequiredContext.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/missingModel/releaseModelOptions.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/missingModel/releaseModelOptions.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/telemetry/billingActionNames.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/telemetry/billingActionNames.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • …and 80 more
Reproduce locally
pnpm architecture:check

Full docs: Frontend domain catalog

🌐 Website E2E

Tip

All tests passed.

View Report

Test results
Status ✅ Passed

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-21499.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

Deployment details

This commit: https://website-frontend-cx7daszu1-comfyui.vercel.app

Last updated: 2026-10-21T17:48:44Z for 1de9c4d

@codecov

codecov Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                            Coverage Diff                            @@
##           design-system/extract-card-components   #21499      +/-   ##
=========================================================================
- Coverage                                  86.41%   86.19%   -0.22%     
=========================================================================
  Files                                       3873     3900      +27     
  Lines                                     180195   180085     -110     
  Branches                                   48375    47288    -1087     
=========================================================================
- Hits                                      155711   155227     -484     
- Misses                                     22073    22452     +379     
+ Partials                                    2411     2406       -5     
Flag Coverage Δ
billing-web-unit 92.40% <ø> (ø)
e2e 64.22% <ø> (+<0.01%) ⬆️
unit 85.41% <ø> (-0.26%) ⬇️
website-unit 80.60% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
apps/website/src/components/blocks/FAQSplit01.vue 83.33% <100.00%> (ø)
apps/website/src/scripts/vfx-connected.ts 72.48% <100.00%> (ø)

... and 114 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Oct 21, 2026
christian-byrne and others added 13 commits October 21, 2026 03:08
…#19869)

## Summary

An explicit Reject on the Agent consent card now persists an
account-scoped promotion preference, so automatic offers stay suppressed
across reloads and devices while Escape/backdrop remain passive
dismissals. Explicit Send still reopens consent and cannot post a
message before acceptance, fixing
[PM-1910](https://linear.app/comfyorg/issue/PM-1910/agent-notifications-keep-appearing-after-i-close-them).

The preference uses `/api/settings`, not the audited consent registry:
rejection controls promotion rather than representing consent. On cloud,
`POST /api/settings/{id}` reads and writes the `settings` column of the
authenticated user's row, keyed only by user id, so the refusal is
account-wide across devices and workspaces ([`settings.go` L315 and L344
at cloud
`fb8d344f98`](https://github.com/Comfy-Org/cloud/blob/fb8d344f989a699558e2e34001df204a5377f08d/services/ingest/server/implementation/settings.go#L315-L345)).
The startup path reads the already-loaded setting synchronously before
spending the device-local one-shot; failed writes are reported and
remain retryable.

A startup offer suppressed by a prior refusal reports `exit:
'consent_declined'`, which the `AgentConsentOfferExit` contract lists as
correctly not needed, not as a lost offer.

## Verification

- Vitest: `src/extensions/core/agentPanel.test.ts`,
`src/workbench/extensions/agent/composables/agent/useAgentConsent.test.ts`,
`src/workbench/extensions/agent/services/agent/consentOfferDeclined.test.ts`.
- Cloud Playwright:
`browser_tests/tests/agent/agentConsentRefusal.spec.ts`, run by
`playwright-video-new-tests (cloud)`.
- Mutation proofs: disabling the startup refusal gate fails the browser
case and both refusal tests in `agentPanel.test.ts`; awaiting the
refusal write before closing the card fails the close-before-write test.
- Pre-commit lint/typecheck and pre-push dependency cruise, knip and
fallow.

Fixes PM-1910 rejection persistence. The separately reported forced
panel activation was accepted as-is and is intentionally unchanged.

---------

Co-authored-by: GitHub Action <action@github.com>
## Summary

Follow-up to #21509 for two of the review nits:

- The workspace domain record's `description` no longer lists "activity
history", which #21509 deleted.
- Drops the `.fallow-baselines` entries for the deleted
`ActiveMediaAssetCard.vue` (health) and
`useWorkspaceActivity.ts:UserSummary` (dead-code). No other deleted file
appears in the baselines or the architecture records.

The third nit, restoring the rationale in the `useCurrentUser` Storybook
mock docblock, is intentionally left out: AGENTS.md limits JSDoc to a
curt contract and puts rationale in commits or PR descriptions. The
reason is that the real composable reaches Firebase through `authStore`,
which throws in Storybook.

Part of FE-3529

## Verification

- `pnpm architecture:check` passes
- `pnpm fallow:audit` reports no issues in the changed files
## Summary

Pins the agent's human wire identity across a `/ws` reconnect. Main is
correct today; this makes the identity change in #20883 fail CI before
it can land, and replaces #21492, whose harness targets the pre-split
`/ws` doc transport.

<details><summary>Full context for agent readers</summary>

Review finding on #20883:
#20883 (comment)
(blocker) and
#20883 (comment)
(same root).

The agent refuses a `doc_ops` batch whose ops claim any writer other
than `human:<user>:<frame tab>` (cloud
`services/agent/server/doc_handler.go`, `messages.HumanActor(userID,
req.Tab)`, 403 → `forbidden`), and the relay refuses an empty tab
(`DocOpsFrame.Validate`). Cloud ingest mints a new session id per `/ws`
connection, which `api.ts` copies into `api.clientId`. `opSender` reads
the actor once at mint and the tab on every send and resend, so both
must come from the per-follower `tabId`, as on main. #20883 moved both
onto `api.clientId`.

#21492 fixed that against #20883's head, but #20883 is 262 commits
behind main and main has since moved doc frames onto
`/api/agent/events`, separate from `/ws`. #21492's harness and unit pin
conflict with main in three files and its reconnect proof would not
survive the rebase. This PR carries the same proof onto main instead.

Changes (tests and harness only, no product code):

- `agentFollowerHostSocket.ts`: refuses a frame without a tab as
`invalid_frame`, and a batch whose envelope and stamp actors do not name
one writer `human:<user>:<frame tab>` as `forbidden`, including held
batches released later. Mints a fresh sid per `/ws` connection and
records each doc frame's tab, writers and `/ws` connection. Adds
`disconnectComfySocket()` and `leaveHumanBatchesUnanswered()`, which
drops the next acceptable batch as lost in transit so the sender's
result-timeout resend is judged.
- `agentHumanEditResentAcrossReconnect.spec.ts`: rename, lose the first
send, reconnect `/ws` to a new session id; the resend must carry the
same op ids, tab and writer on a later `/ws` connection, be accepted,
and keep the rename.
- `crossWorkflowPending.test.ts`: the retried batch keeps its tab and
actor when `api.clientId` changes, and the tab is never empty before the
first session id.
- `agentFollowerHostSocket.test.ts`: refusal cases (missing tab, actor
for another tab, stamp for another tab, stamp for another user), the
unanswered-then-resent path, and a refused frame not consuming the drop.

Cloud references at `a0997c0498`: `services/agent/server/doc_handler.go`
(`messages.HumanActor(userID, req.Tab)`, 403 on mismatch) and
`common/websocket/messages/crdt.go` (tab required).

</details>

## Verification

- Mutation: with `useAgentCrdtFollower.ts` switched to #20883's identity
(`actor` and `tab` from `api.clientId`), the new spec fails (the
resend's tab is the new session id) and both unit pins fail
(`sid-after-reconnect` vs `sid-before-reconnect`; empty tab). Restored:
spec passes on every local run (5/5 and 5/5 repeats, then 3/3 at the
final head), unit 10/10.
- Fixture unit tests: the new cases fail against main's harness; 13/13
pass.
- 22 existing agent specs that use the apply host, held releases or
disconnects: 56/58 pass. The 2 failures are `@screenshot` diffs in
`agentConversationReplay` (1717 px and 509 px) that fail identically on
untouched main on this machine.
- `vitest src/workbench/extensions/agent browser_tests/fixtures`: 4328
passed, 1 expected fail; one unrelated `useAgentSession` timing case
failed once under load and passes alone (251/251).
- `typecheck`, `typecheck:browser`, oxlint, oxfmt, knip, fallow audit:
clean.
…ails (#21518)

> **Hold:** do not merge or queue until @june-bump gives the go-ahead.

## Summary

Design pass on `/solutions/vfx/v3/` (EN + zh-CN). `/solutions/vfx/` (v2)
is unchanged: v3 gets its own enterprise label, and the extra detail
row, row links and closing secondary CTA are v3-only props.

- CTA copy: CONTACT US, SEE VFX WORKFLOWS, TRY FOR FREE (workflow
modules), SEE ENTERPRISE PLAN (all with zh-CN equivalents).
- Workflow modules and Studio lose their Pause/Play buttons. With no
visitor control left, the `playbackIntent` state and toggle in
`vfx-connected.ts` are removed: previews play when visible and stay
paused under `prefers-reduced-motion`. Studio therefore always plays on
open and the canvas resumes on close.
- Studio back control is plain yellow text, "← BACK TO VFX PAGE".
- Each workflow canvas shows "Drag left or right to see full workflows"
(`pointer-events-none`, `aria-hidden`; keyboard panning is unchanged).
- Production details gain an "Enterprise plan & billing" row.
`FAQSplit01` accepts an optional per-row `link`, rendered after the
answer in the same tab with a locale-aware route; licensing and billing
rows use it, replacing the two outline buttons under the list.
- Closing section adds SEE ENTERPRISE PLAN as the secondary CTA.
Pipeline and closing CTAs go full width below `sm`, matching the hero.

**Accessibility tradeoff for review:** module and Studio previews are
looping autoplay video with no visible pause control. Reduced-motion
visitors still get still frames, but others cannot stop them (WCAG
2.2.2). This follows the design direction and needs a conscious
sign-off.

## Verification

- `vitest`: `vfx-connected.test.ts` + `FAQSplit01.test.ts`, 21 passed.
Updated the studio playback test (plays on open, canvas resumes on
close), added a reduced-motion Studio test and an FAQ row-link test.
Tests for the removed visitor pause/play control were deleted with the
feature.
- Playwright on a `build:e2e` build: `vfx-v3`, `vfx-studio-signup`,
`vfx` specs, 68 passed (desktop + mobile).
- Pre-commit (oxfmt, oxlint, eslint, prettier, `typecheck:website`) and
pre-push knip passed.
- Manual, local dev server at 375px and desktop: no horizontal overflow;
drag hint fits one line at 327px; Studio plays after the module was
paused; zh-CN row links resolve to `/zh-CN/enterprise/` and
`/zh-CN/minimax/license/`; v2 page still shows three detail rows and no
row links.
…est (#21428)

## Summary

Follow-up to the review nits on #21423.

- account-core's `requestAuth` imports only `name` and `version` from
`#package.json`. Vite's JSON tree-shaking now folds them into one
string, so the published bundle no longer carries the whole source
manifest with its `./src` exports and `workspace:` ranges. Marking the
manifest external was rejected because rolldown drops the `type: 'json'`
import attribute, which Node requires.
- `@comfyorg/published-package-build` declares `vite-plugin-dts` as a
dependency and `vite` as a peer dependency, since both run when a
package's Vite config loads.

## Verification

- account-core build output contains only the `COMFY_CLIENT` string, not
the manifest
- `smoke:pack`, `check:pack` for all four published packages,
account-core tests, app and tools typecheck, oxlint, knip

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…or) (#20747)

*PR Created by the Glary-Bot Agent*

---

## Summary

Fixes the prod error `DataCloneError: Proxy object could not be cloned`
on `cloud-frontend-prod`. Chrome reports it as `#<Object> could not be
cloned`, Safari as `The object can not be cloned`. Datadog RUM shows 116
errors across 70 sessions in 30 days, still happening on cloud/v1.56.3.
Workflows fail to open from templates, file open or drop, startup
restore, and shared links.

This is the third round of the same bug: code keeps moving from a JSON
copy to `structuredClone` on data that is not actually plain. This PR
removes the crash site, fixes both sources of proxies, and adds a
regression test for each earlier occurrence.

## Root cause

A strict `structuredClone` ran on `graph.serialize()` output, and that
output can still contain JS proxies:
- `createNewWorkflow` (`workflowStore.ts`) cloned
`rootGraph.serialize()` on every load.
- `serialize()` copies `extra` only one level deep and runs extension
`onSerialize` hooks on the output object.

## Timeline

| When | Change | Effect |
|---|---|---|
| Jul 2025 |
[litegraph.js#1158](Comfy-Org/litegraph.js#1158)
/ [#4696](#4696)
propose `structuredClone` for `LiteGraph.cloneObject()` | Review blocked
it: *"you cannot simply drop this in… It will break custom nodes."*
Still open; `cloneObject` is still a JSON copy. |
| Feb 2026 | #8898 (`3d88d0a6ab`) | First in-tree proxy fix: widget
values are JSON-copied in `LGraphNode.serialize`. |
| Mar 2026 | #9338 (`68b16e3a3f`) | App Builder writes `extra.linearData
= { inputs: [...data.inputs] }`. The shallow spread leaks reactive
tuples into the graph. |
| Aug 19 2026 | #11631 (`fb030dcdb8`), first in **cloud/v1.52.4** |
`createNewWorkflow` switches from a JSON copy to `structuredClone`.
**This creates the crash site.** |
| Aug 24 2026 | ECS migration #14246 (`a8abe573c0`), first in
**cloud/v1.53.4** | `NodeState` is now registered with `reactive()`, so
`node.properties` is a deep reactive proxy. |
| Sep 20 2026 | #18165 ("1.52.7 fine, 1.53.6 broken") | CRT Nodes "Fancy
Timer" does `onSerialize(o) { o.properties = this.properties }` →
`DataCloneError`. |
| Sep 22 2026 | #18252 (`8ff5db2f1e`, Sentry FRONTEND-51) | Fixes
extension-only fields. `properties` is a canonical field, so #18165
still crashed at `createNewWorkflow`. |

## Changes

The history alternates red and green: each failing test commit comes
before its fix.

**Crash site (`workflowStore.ts`).** `createNewWorkflow` no longer
deep-copies. `ensureWorkflowId` doesn't mutate its argument and the
result is only passed to `JSON.stringify`, so the stored bytes are
unchanged and nothing is left to clone (`e9f23ce`).

**Source 1: App Builder (`appModeStore.ts`).** `linearData` is written
as new typed tuples, and each config gets a JSON copy. A missing config
is omitted rather than written as `null`, so the value matches the
`zLinearInput` schema. End-to-end reorder, save and reopen is already
covered by `browser_tests/tests/builderReorder.spec.ts:125-147`. The
unit tests cover proxy depth and the omitted config.

**Source 2: serialize hooks (`extensionPersistence.ts →
runExtensionSerializeHook`).** This only runs when a hook exists; nodes
and graphs without hooks are untouched. After the hook runs, each
canonical field is checked with `structuredClone`, whether the hook
replaced it or edited it in place:
- **A cloneable value is kept exactly as the hook left it.** That
matches main: `Date`, `Map`, typed arrays and class instances keep their
in-memory types, and `toJSON` still runs at save time.
- **A value that can't be cloned is JSON-detached.** In practice that
means a live reactive proxy or a geometry view. Live geometry views
(`pos`/`size`, proxies over typed arrays) become `[x, y]`. Real typed
arrays keep main's `{"0":…}` JSON.
- **If JSON detachment also fails** (a cycle, BigInt, or a throwing
getter or `toJSON`), the value is kept and a warning is logged, so the
save fails loudly as it did on main instead of writing a workflow
without that field.

**Regression guards.** Each new test fails on base and passes here.
- `extensionPersistence.test.ts` covers:
- #18165, both the whole-field and the nested in-place variants, for
node and graph hooks;
  - later live edits not leaking into a serialized node;
  - geometry views, flat, nested and in place;
  - #8898 reactive widget values;
  - cloneable replaced values staying intact, including `toJSON`;
  - an untouched field keeping full fidelity;
  - a typed array keeping its saved shape next to a proxy;
  - an undetachable value kept so the save fails.
- `LiteGraphGlobal.cloneObject.test.ts` pins `cloneObject`'s proxy
tolerance, so repeating #1158 now fails a test.
-
`browser_tests/tests/legacyDoNotReplicate/legacyLiveSerializedProperties.spec.ts`
(from #21504) opens a workflow containing a devtools node that
reproduces the Fancy Timer hook. Before the fix the load fails with
`Failed to parse workflow: DataCloneError` and no tab opens.

## For reviewers

- **JSON vs `structuredClone` policy:** JSON is used only for values
`structuredClone` rejects, which in practice means live proxies.
Everything else is left as the hook wrote it, so saved JSON and
in-memory types match main.
- **Custom-node risk (#1158):** this PR moves away from it.
Hook-provided values are still honoured; only live proxies are replaced
with copies.
- **Performance** (1,000 nodes, mean of 20 `graph.serialize()` calls in
Vitest, two runs each):

  | Case | main | this branch |
  |---|---|---|
  | No hooks | 14–15 ms | 15 ms (unchanged) |
  | Graph `onSerialize` | 12–14 ms | 17 ms |
  | Graph hook + a hook on every node | 19.5 ms | 34–35 ms |

- The cost is the per-field `structuredClone` check. For a graph hook,
that clones `nodes` and `definitions` once per serialize.
- Skipping those fields is not safe, because a hook can push a live
proxy into an existing container.
- No code in this repo registers `onSerialize`, so only custom-node
packs that install hooks pay this.
- On main, the hooked-node case was not usable either: it produced the
proxy output that crashed on load.
- **Known limits:**
- A raw (non-proxy) object a hook assigns still aliases live state, as
on main.
- Other strict clones still exist (`structuredClone(extra)` in
`LGraph.configure`, `workflowToClipboardItems`,
`subgraphStore.getBlueprint`). Both proxy sources are now fixed before
data reaches them.
- **Commit history:** red/green is intentional. Squash-merge, or keep
the history as is; please don't squash red into green.

## Verification

- **Unit tests** under `src/lib/litegraph`, `src/platform/workflow`,
`src/stores` and `src/scripts`: 314 files, 5463 passed. Pre-commit
(oxfmt, oxlint, `typecheck:app`) passed on every commit.
- **E2E:** the `legacyDoNotReplicate` folder and
`builderReorder.spec.ts` passed (47 tests) with
`scripts/test-browser-offline.sh --project=chromium` against a dist
built from this head. The new Fancy Timer spec fails against a dist
built with the fix reverted.
- **Live dev app (Playwright):** select and reorder in builder mode,
then run `structuredClone(rootGraph.serialize())` and
`createNewTemporary(…)`. Both threw `DataCloneError` before the fix and
succeed after.

---------

Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>
Co-authored-by: Alexander Brown <drjkl@comfy.org>
## Why

While the server reports `subscription_state` as `activating`, the
Billing tab plan row still reads as a normal active plan ("Billed
monthly. Next invoice …"). The row should say "Activating your {Plan}
plan…" until that state clears, then return to the served status.

## Root cause

`subscription_state` is already on the billing status response
(`SubscriptionState` includes `activating`), but `useWorkspaceBilling`
and `useLegacyBilling` never passed it through `useBillingContext`. The
plan row only mapped `subscription_status`, so an activating
subscription with an active status rendered the invoice line.

## How

Both billing adapters expose `subscription_state` as received.
`derivePlanRow` treats `activating` as that served value: when it is
`activating` and a plan name is present, the line is the activating
copy. Any other served state, including once `activating` clears, uses
the existing status mapping. The copy is not inferred from a checkout
operation, tier, or `is_active`.

The line is only on the Billing tab. That tab mounts when
`flags.unifiedBillingSettingsEnabled` is true (`useSettingUI`). The flag
getter is unchanged, so it stays false off Cloud. The Plan & credits
panel (`SubscriptionPanelContentWorkspace`) does not render Activating
or Contact sales.

## AS IS / TO BE

Storybook `Platform/Workspace/BillingPlanRow`, mocked status. Images
follow.

| | |
| --- | --- |
| AS IS | Active plan line |
| TO BE | Activating line |

## Plan position

| Item | Ticket | PR | Status |
| --- | --- | --- | --- |
| Activating plan row | FE-3526 | this PR | **this PR** |
| Contact sales replaces Manage | FE-3524 | stacked on this branch |
next |

```mermaid
graph LR
  activating["FE-3526 Activating plan row"] --> sales["FE-3524 Contact sales"]
  style activating fill:#f9f,stroke:#333,stroke-width:2px
```

## Verification

- `pnpm exec vitest run` on `planRow.test.ts`, `BillingTab.test.ts`,
`useWorkspaceBilling.test.ts`, `useBillingContext.test.ts`,
`useLegacyBilling.test.ts`, `planLifecycle.test.ts`,
`SubscriptionPanelContentWorkspace.test.ts`
- Flag off: the Plan & credits panel test asserts it does not render
Activating or Contact sales
…ut-of-credits card (#21538)

## Summary

A new account's first prompt showed the standing "Out of credits" card
for the whole turn, although the turn ran normally. The panel had read
billing before the send, and pre-turn admission granted the free Agent
credits inside that send, so the stale no-funds read stayed on screen
until the turn finished. Stopping or finishing the turn cleared it.

Now, when the last read says no funds, the panel holds the standing card
from the send until a billing read taken after admission settles. A send
that is refused keeps its inline card, and funded users make no extra
request.

Reported by Windows Local Agent QA in `#comfy-agent-user-feedback` on
2026-10-21. The card is shared frontend code, so Cloud has the same race
whenever a grant is minted at admission. This finishes the work of
[PM-2066](https://linear.app/comfyorg/issue/PM-2066), whose #21241 kept
the card hidden only until the first message.

<details><summary>Full context for agent readers</summary>

- The standing card reads `subscription.agentHasFunds`, which is
`scoped_effective_has_funds.agent` from `GET /api/billing/status`.
Before this change, billing was refreshed only when a turn finished
(`AgentPanelRoot.vue`, the idle branch of the `[status,
conversationTurnId]` watch).
- Cloud ingest mints the monthly or Local Agent gratis grant in
`agentGratisEnsureBeforeAdmission` before `/v1/decide`, and it writes
the funds snapshot synchronously. So a 2xx on the turn POST means a
status read made after admission shows the grant.
- Ingest's `billing_status` websocket push is not consumed by the
frontend, and its payload has no Agent funds field, so it cannot correct
this read.
- The existing empty-thread spec still passes: when a post-admission
read still says exhausted, the card shows.

</details>

## Verification

- New black-box case in
`browser_tests/tests/agent/agentCreditsExhaustionEmptyThread.spec.ts`:
billing is exhausted at load, and the turn POST flips the fixture to
funded. On the parent commit it fails with `Expected: 0, Received: 1`
(the card is visible during the admitted turn). With this change it
passes, after waiting for the billing read that follows admission.
- `playwright test` over `agentCreditsExhaustionEmptyThread`,
`agentCreditsExhaustionLifecycle`, `agentPanel` and
`agentFreeUsePlacement` (`--project=cloud`): 19 passed.
- `vitest run src/workbench/extensions/agent/AgentPanelRoot.test.ts`:
465 passed.
- Commit hooks passed: oxfmt, stylelint, oxlint, eslint, server-facts,
`typecheck:app`, `typecheck:browser`.
- Not run: a packaged Desktop build with a brand-new account.

## Linear

Fixes
[PM-2239](https://linear.app/comfyorg/issue/PM-2239/out-of-credits-banner-shows-on-a-new-account-even-though-free-credits).
…ules (#21505)

## Summary

Two copy corrections to the Open Source Higgsfield rules, plus the test
that asserts them.

**1. The Developer Platform was a hard requirement.** `requirement1`,
listed under "Every submission must include", read: "Your work must be
built using the Comfy Developer Platform (Comfy Router and/or Comfy
SDK)". Entrants can build with ComfyUI however they like, including
entirely local, so that line misstated eligibility and would have ruled
out valid entries. It also contradicted the prize list: **Open Weights
Only** bars partner nodes and closed APIs, while `requirement1` forced
Router or SDK, so an entrant reading both carefully could conclude that
category was unwinnable.

Reworded so ComfyUI is the floor and the Developer Platform is one
option among several, plus the two positioning lines that repeated the
claim.

**2. NVIDIA out of the agreements line.** They still fund the GPU prizes
but are not part of the messaging. The `GeForce RTX 5090` prize copy is
untouched, since that names what an entrant wins rather than a partner.

| Key | Before | After |
| --- | --- | --- |
| `requirement1` | must be built using the Comfy **Developer Platform**
(Router and/or SDK) | must be built **with ComfyUI**; run it entirely
local, Comfy Cloud, Developer Platform, Router, SDK, or any mix |
| `enterLead` | Create your favorite app and more **using the Comfy
Developer Platform** | Create your favorite app and more **with ComfyUI,
running it wherever you like** |
| `description` | rebuild their most popular apps and more **on the
Comfy Developer Platform** | rebuild their most popular apps and more
**with ComfyUI** |
| `requirement5` | allow ComfyUI, **NVIDIA,** Runpod, LTX, Black Forest
Labs, and MiniMax to feature your work | allow ComfyUI, Runpod, LTX,
Black Forest Labs, and MiniMax to feature your work |

en and zh-CN both. `ja` has no `eventChallenge` block and falls back to
en.

## Verification

- `HowToEnterSection.test.ts` asserts the requirement list verbatim, so
the two reworded strings move with it. `pnpm vitest run
src/templates/challenge/` passes 10/10 locally, before and after merging
`main`.
- The `it.for` link assertions are unchanged and still pass: the
reworded `requirement1` keeps a link labelled "Developer Platform" to
`/platform/` (`开发者平台` to `/zh-CN/platform/`) and one labelled "Comfy
SDK" to the SDK docs, with `{sdkDocsHref}` interpolation intact in both
locales.
- `grep -i nvidia` over the `eventChallenge` block in both locales now
returns nothing. The partner strip on this page already rendered Runpod,
LTX, Black Forest Labs and MiniMax only, with no NVIDIA logo to remove.
- Locale JSON diffs are value-only, no structural or formatting churn.

Deadline note: the competition closes October 30, so this wants to land
well before then.
…e job (#21300)

## Summary

Frames from a job queued in a background tab paint the visible tab's
canvas: progress bars, previews, outputs and progress text land on
whichever nodes share an id. This gates every path that writes to the
visible canvas on one predicate, `belongsToActiveWorkflow(jobId)`, which
compares the workflow instance that queued the job (already recorded by
`storeJob`) with `workflowStore.activeWorkflow`. Per-job bookkeeping
(`queuedJobs`, `nodeProgressStatesByJob`, workflow tab status, job
previews) still accepts every frame.

```diff
 execution_start      per-job bookkeeping, tab status
+                     if owned: activeJobId, locator cache, start errors
 progress_state       nodeProgressStatesByJob
+                     if owned: nodeProgressStates mirror, executing progress
 progress             if owned: executingNodeProgress
 executed             if owned: activeJob.nodes, node outputs, onExecuted
 execution_cached     if owned: activeJob.nodes
 b_preview_with_meta  jobPreviewStore
+                     if owned: node previews
 progress_text        if owned: text preview widget
+activeWorkflow change
+  adopt that workflow's started job as activeJobId
+  restore its mirror from nodeProgressStatesByJob, or clear the mirror
```

Jobs whose owner is unknown (queued by another client, or before a
reload) keep today's behaviour: admitted unless a different job is
already active. Terminal frames (`execution_success`, `execution_error`,
`execution_interrupted`) are unchanged and still reset global state for
any job.

This is the minimal cut of #20045. It leaves out the `workflow_metadata`
wire field, the graph-id and path fallbacks, queue-poll eviction,
`api.lastExecutingMessage` and the backend simulator. Each can follow as
its own PR if it turns out to be needed.

Fixes #1293
Fixes #2660
Fixes #6730

## Verification

- `pnpm test:unit src/stores/executionStore.test.ts
src/composables/node/useProgressTextPreviews.test.ts
src/scripts/app.test.ts`: 293 passed.
- With the source changes stashed, the 8 new tests fail (background
`execution_start` becomes active, background `progress_state` reaches
the mirror, background `executed`/`execution_cached` mark the active
job, no adoption on tab switch, background outputs/previews/text reach
the visible nodes); the unknown-owner test passes on both sides.
- Not covered: a two-tab Playwright run against a real backend. The
tests fire the same frames the server sends through `api`'s event
listeners.

Known gap, unchanged from main: with two jobs running at once across
tabs (Cloud), a foreign job's terminal frame clears the visible mirror
until the next `progress_state` frame of the visible job.

## Merge Danger

**Door:** two-way. Revert restores the previous behaviour; no persisted
data or wire format changes.

**Blast Radius:** execution display

Extensions that read `executionStore.activeJobId` or `executingNodeId`
now see the visible tab's job rather than whichever job last started.
`node.onExecuted` no longer fires on the visible graph for a background
job's node.

---------

Co-authored-by: Christian Byrne <cbyrne@comfy.org>
…in) (#21491)

## Summary

Carries #20893 (DrJKL's agent platform lint boundary) onto current
`main` and fixes what broke after its base.

- #20893's three commits, rebased cleanly onto `main` with authorship
kept. Their combined patch is byte-identical to #20893's head
`8a1fb18ad4`.
- One added commit (`05f4256761`) clears the three new ESLint errors,
retargets a stale path, decides the `toLocaleString()` question, removes
four unused exemptions, and adds tests for the timer and filename
blocks.
- Lint and test boundary only. The two source edits behave exactly as
before.

<details><summary>Full context for agent readers</summary>

### Why a new PR

The head of #20893 has not moved since 2026-10-14, and its required
checks are still red from the run before its six dependencies merged.
All six are now merged. This PR does not push to the author's branch. If
the author prefers to keep #20893, cherry-picking `05f4256761` onto it
after a rebase gives the same tree.

### What the added commit changes

| Finding on #20893 merged with `main` | Change |
|---|---|
| `agentPanelStore.ts:82` calls `api.getServerFeature('agent')`. It
landed in #20971 after the base. True positive. | Adds
`ServerFeatureFlag.AGENT` and a `flags.agent` accessor to
`useFeatureFlags`, following the `maxUploadSize` migration in #20884.
The store reads `featureFlags.agent`. Its state filtering is unchanged.
|
| `attachableFiles.ts:105` calls `file.name.split('.')`. It landed in
#18389. True positive. | Now `extensionOf(file.name).slice(1)`, the
helper this file already uses to decide acceptance. It gives the same
result for every key in `VIDEO_CONTAINER_CHECKS`. |
| `attachableFiles.ts:69` `expected.split('')` splits magic bytes, not a
filename. False positive. | The filename block now matches only `split`
and `lastIndexOf` with a `'.'`, `'/'` or `'\\'` argument. That covers
every site #20890 migrated plus the one above. It uses
`no-restricted-syntax`, so the block now comes after the channels block
and repeats the channel restrictions, because flat config replaces a
rule's options for each file. |
| `standaloneAgentEventSource.ts` was deleted in #17469, so the deadline
block matched nothing there. | Now targets `agentEventSource.ts`, where
the reconnect timer lives (it already uses `useTimeoutFn`). |
| `new Date(0).toLocaleString()` was not reported (CodeRabbit and review
threads on #20893). | Every `toLocaleString`, `toLocaleDateString` and
`toLocaleTimeString` call is now rejected. A syntactic rule cannot tell
a Date from a number, and the platform provides both formatters:
`src/utils/dateTimeUtil.ts`, `src/utils/numberUtil.ts`, and vue-i18n
`d()`/`n()`. The agent folder has no such calls outside the exempt dev
panel. `toLocaleUpperCase` is still allowed, and a test pins that. |
| The `crdtDebugGate`, `schemaGuard`, `docFrameClient` and `CodeBlock`
exemptions suppress nothing (with all exemptions removed, only
`CrdtDevPanel`, `crdtLog` and `restoreOpMinter` report). | Removed. |
| Deleting the whole deadline or filename block left the test file
green. | Added rejected and allowed cases for both blocks, for both
target files of each: raw timers, local `.`/`/`/`\` parsing,
`expected.split('')`, `csv.split(',')`, an untargeted agent file, and a
check that the channel restrictions still apply in the filename files. |

### Verification

- `NODE_OPTIONS=--no-experimental-webstorage pnpm exec vitest run
tools/eslint-plugins/agentPlatformChannels.test.ts`: 50/50 pass.
- Mutation check: 15 hand-made config mutations, all killed. They
include deleting each block, restoring the stale path, the old file-wide
`split` ban, the old `(Date|Time)` regex, widening to `/^toLocale/`,
dropping the `ds` constraint, moving the filename block before the
channels block, and dropping the repeated channel restrictions.
- `pnpm exec eslint src/workbench/extensions/agent` plus the changed
files: 0 errors.
- `pnpm exec depcruise src`: no violations. `pnpm typecheck`: pass.
`pnpm typecheck:tools`: pass.
- `vitest related` for the four changed source files: 699 files and
14,865 tests pass.
- A scratch test (not committed) confirmed `comfyAgent` reacts to
`serverFeatureFlags` the same way before and after the store change.

### Not changed

Syntactic evasions noted in review (destructured `navigator`,
`globalThis.navigator`, aliased `ds`, `Object.assign(canvas.ds, …)`,
`i18n.global.t`, a variable `split` separator, regex separators) are
accepted limits of `no-restricted-syntax`.
`Intl.DateTimeFormat`/`NumberFormat` construction is not restricted.

[FE-3409](https://linear.app/comfyorg/issue/FE-3409), part of FE-3387.

</details>

---------

Co-authored-by: Alexander Brown <drjkl@comfy.org>
## Summary

The Agent's run notice says "Check Run permissions" without saying where
that control lives. This names it: the Run permissions popover in the
composer toolbar, and what it controls. It also finishes one test-name
follow-up from #18426.

This PR holds what remains of PM-1236. #18426 (merged 2026-10-21 as
[`820086de42`](820086d))
shipped the deferral. These two changes were moved out of it because
they touch files outside the Agent review paths, and those need a
frontend-team review:

1. **Copy** (`src/locales/en/main.json`)

| | text |
| --- | --- |
| **before** | The agent can modify the graph. Check Run permissions
before allowing it to execute the workflow. |
| **after** | The agent can modify the graph. Use Run permissions in the
composer toolbar to control whether it asks before executing. |
| **before** (expanded) | The agent can modify your workflow. Check Run
permissions before allowing it to execute. |
| **after** (expanded) | The agent can modify your workflow. Use Run
permissions in the composer toolbar to control whether it asks before
executing. |

The control exists on `main` as `RunModePopover.vue`, labelled
`agent.runPermissions` ("Run permissions"). English only; other locales
follow through the i18n workflow.

2. **Fixture rename** (`browser_tests/fixtures/agentPanelFixture.ts`
plus its two consumers). `agentComposerPerformanceTest` becomes
`restoredTargetlessAgentThreadTest`. The fixture provides a restored
conversation with no workflow target, and `runNotice.spec.ts` depends on
that state, not on performance measurement. The fixture body does not
change. This was the reviewer's last P3 on #18426; it previously sat in
draft #21501, which is now closed in favour of this PR.

Linear: PM-1236

## Verification

- No test or source file asserts the old wording. The Agent specs read
`enMessages.agent.runNotice`, so they pick up the new copy unchanged.
- No references to the old fixture names remain under `browser_tests/`
or `src/`. `typecheck:browser` passed in the pre-commit hook.
- A rendered comparison of the old and new copy in the same panel frame
is in [this #18426
comment](#18426 (comment)).
@mrseek-reviews

Copy link
Copy Markdown
Contributor

Merged design-system/extract-card-components at e73023edf3 into this branch in 1de9c4d0dc.

How I resolved the conflicts:

  • UserCredit.vue, ActiveMediaAssetCard.vue and WorkspaceActivityContent.vue: kept the base's deletions from refactor: delete components only imported by their own tests and stories #21509. This branch only repointed their imports.
  • Card.stories.ts: kept the story in the package with this branch's relative imports and the package Button, and dropped CardTitle as the base did.
  • BillingPausedBanner.vue is new on the base and still imported @/components/ui/button/Button.vue, which this PR moves. I repointed it to @comfyorg/design-system/button/Button.

Checked locally: app, browser and design-system typechecks, Knip, ESLint on the touched files, and the billing unit tests.

## Summary

On local ComfyUI and Desktop, a run-bar rocket opens the existing Deploy
to Comfy API dialog in installation mode. Choosing Deploy on Platform
uploads the local installation and opens the Platform build wizard with
that bundle. The graph-menu entry keeps its existing plain Platform
link.

Closes DES-1266. Frontend work for
[DPLAT-3048](https://linear.app/comfyorg/issue/DPLAT-3048), following
the [Deploy to Cloud API
contract](https://linear.app/comfyorg/document/api-contract-087dc1c667ee).

- The button renders the single server-owned `deploy_to_cloud`
capability. It does not combine that flag with another server fact,
remote configuration, or a PostHog flag. Until the server supplies it,
the button stays hidden.
- `POST /api/deploy/bundle` sends the open workflow (UI format, flushed
from the canvas at the click) as `workflow`, so the build wizard
pre-selects the models it uses; with no workflow open the body is `{}`.
If the server answers `too_large` with a workflow attached, the upload
is retried once without it, as the contract prescribes. Its request body
type, full success-response validator, and error contract come from
`@comfyorg/ingest-types`. The UI error mapping is exhaustive against the
generated error union. The generated response validator retains the
frontend's HTTPS-only destination check; incomplete or malformed
responses are reported and open no wizard link.
- Credentials follow the existing local-run rule: use the workspace
token; use the stored API key only while signed out. Missing credentials
open sign-in, and a signed-in account without its workspace token gets
the sign-in-again message.
- When the upload finishes, Deploy on Platform turns into an Open the
build wizard link; the frontend never calls `window.open`. The upload
usually outlasts the browser's popup allowance, so an automatic tab was
blocked almost every time anyway, and on Desktop the link goes through
the same system-browser handler. Following the link (click or
middle-click, not right-click) closes the dialog. The upload state
belongs to the button, so closing the dialog mid-upload abandons that
upload and a reopened dialog offers a fresh one. A credential found for
one account is dropped, before and after the upload, if another account
is current by then, so no link appears for another account's bundle. If
the sign-in prompt itself fails to open, the dialog shows Could not
reach Comfy, reports it once, and the next click tries again.
Same-account token refresh and signing in from the deployment prompt
still work; the owner identity never enters the public state or
telemetry.
- Known API errors use translated messages and retain the existing
reporting policy. A bundle refused by the builder shows the existing
upload-rejected message instead of claiming Comfy could not be reached.
Unknown response bodies fall back on HTTP status; plain-text 413
responses still mean the bundle is too large. The server's response body
remains the reporting cause.
- Existing click telemetry records rocket clicks, deployment clicks, and
wizard openings. Local frontend events use Desktop v2's host sink when
telemetry is enabled; plain pip/portable installs send none.

### Dependencies

- Generated-types dependency
[#21351](#21351) is
merged. It supplies the TypeScript types and Zod validators from Cloud's
shared API schema. Native stack #21425 retains that merged parent; this
feature now targets `main` and imports the generated output without
editing or copying it.
- [Core #17203](Comfy-Org/ComfyUI#17203)
implements the local deploy endpoints and computes the capability flag.
It is still open. This PR does not wait for it: the rocket renders only
when the server sends `deploy_to_cloud` (default false), so on any
ComfyUI without that change, including the core/1.56-1.58 backport
targets, the button stays hidden and `/api/deploy/bundle` is never
called.
- [Cloud #14034](Comfy-Org/cloud#14034), which
stores import bundles and declares the shared API schema, and [Platform
#1414](Comfy-Org/platform#1414), which prefills
the build wizard, are merged. Their deployment and the complete
upload-to-wizard flow have not been verified here.
- Disclosure copy is not a merge hold: installation mode keeps the
current workflow-oriented copy and summary for now, while the upload
also includes the installation's custom-node repositories, pip packages,
model filenames, and install name. Installation-wide counts from the
generated `GET /api/deploy/summary` contract are a possible follow-up.
- ComfyUI currently sends feature flags at WebSocket handshake. If
headless use enables deployment mid-session, the button appears after a
reload or reconnect.

## Verification

- `pnpm test:unit src/platform/workflow/deploy
src/components/TopMenuSection.test.ts --retry=0`: **135 tests passed
across 6 files**. Covers the server flag, upload credentials and
request, the open workflow in the request body (as flushed from the
canvas), the retry without it on `too_large` and no retry on other
failures, the build wizard link once the bundle is ready, error
messages, HTTPS restriction, malformed success-response refusal,
credentials and upload results that arrive after an account switch,
signing in from the deployment prompt, a sign-in prompt that fails to
open, and click, middle-click and right-click on the link. Removing
either account check, or taking the owner before the sign-in prompt,
fails a test.
- The new incomplete-response case failed against the handwritten
validator (22 existing cases passed), then passed after adopting the
generated validator. A separate regression test first reproduced the
misleading builder-rejected message, then passed with the corrected
mapping. Success and known-error fixtures are checked against the
generated types and use a valid bundle UUID.
- `pnpm lint:unstaged:fix` passed. The normal commit hook passed
formatting, type-aware lint, server-fact lint, app typecheck,
unused-translation checks, and frozen-directory checks.
- Normal pre-push dependency analysis, unused-code checks, and
changed-file audits passed.
- Claude review of `99edf6d4cc` found no blocking code issues. Its one
optional error-message correction is included with a regression test;
this small mapping fix does not require another review round. Claude
review round 2 at `274969b9fd` found no blocking code issues in the
account-bound state fix. The generated-types parent is already merged.
- Preserved all 14 existing feature commits through base updates, with
no manual conflict resolution. The account-bound state fix changes only
the deployment composable and its tests. Seven new regression cases
failed before the fix and pass afterward; the same-account refresh and
sign-in cases also pass. The feature diff contains no generated-package
changes; fresh CI must complete on the new head.
- A live staging upload passed the UUID/timestamp validators and opened
the prefilled wizard (see How to QA). A Desktop session is still
unverified.

### How to QA before core #17203 merges

Core #17203 does not need to merge for QA; its branch runs as is.

1. Run ComfyUI from `jacob/dplat-3049-3050-deploy-to-cloud` with
`--comfy-api-base https://stagingapi.comfy.org`. `/api/features` then
sends the staging API and platform URLs and `firebase_env: dev`, so
sign-in and the builder both use staging.
2. Run this branch with
`VITE_STAGING_CLOUD_BASE_URL=https://stagingcloud.comfy.org pnpm dev`
against it. On local ComfyUI the workspace token comes from the cloud
base URL, which core's staging override does not set (already true on
core master), and a dev build otherwise uses `testcloud.comfy.org`. The
upload then lands in a test-cloud workspace that staging Platform does
not have, and the wizard asks to switch to a workspace you cannot pick.
3. Queue one prompt without a `client_id`, as a script would, e.g.
`EmptyImage` into `SaveImage` via `curl -X POST
localhost:8188/api/prompt`. `deploy_to_cloud` turns true and stays true
(marker file `user/used_headlessly`). Reload the page; the server only
sends flags when the WebSocket connects.
4. Click the run-bar rocket, then Deploy on Platform, sign in with a
staging account, and confirm the wizard (or the Open the build wizard
link) lands on
`stagingplatform.comfy.org/profile/builds/new?step=import&bundle=…` with
the bundle prefilled. Close and reopen the rocket: it offers a fresh
Deploy on Platform.

Checked live on 2026-10-20 (core `7b97412` against the staging builder,
this branch at `58cfdc4b7a`, staging sign-in):

- The flag is false before the headless prompt and true after; the
rocket then appears and opens the dialog in installation mode.
- Signed out, Deploy on Platform opens sign-in and uploads nothing.
Signing in from that prompt continues the upload.
- The staging builder stored the bundle and core returned `{url,
bundle_id, workspace_id, expires_at}` (a UUIDv7 id, a `w-…` workspace
id, expiry 24 h out). It passed the generated validator and the HTTPS
check.
- The browser blocked the new tab both times (before c24a77e made the
link the only path), so the dialog showed Open the build wizard with the
`stagingplatform.comfy.org/profile/builds/new?step=import&bundle=…&workspace=…`
URL. Following the link closed the dialog; a reopened dialog offered a
fresh upload.
- Closing the dialog without following the link, then reopening, showed
Deploy on Platform and no old link (the 58cfdc4 fix).
- A signed-in upload of this small install took under 5 s.

- With the staging cloud base URL, the bundle landed in the same
Personal Workspace that staging Platform uses. After Platform's own
sign-in (it returned to the wizard URL), the wizard opened with the
Desktop snapshot loaded: ComfyUI `v0.42.0` from the snapshot instead of
the default latest stable, and 72 Python packages pinned. No build was
started.

Not checked: a Desktop session, an installation with custom nodes and
models, and a staging upload that carries the workflow (the live run
above predates it and sent `{}`).

### Risk and rollback

Switching accounts during a request silently discards the result; a
server-side bundle may still have been created for the original account.
A link that is already showing stays if the account changes in another
tab while the dialog is open; the builder must still enforce bundle
access. Closing the dialog during an upload abandons it; the unused
bundle counts toward the builder's limit until it expires.

Full generated validation rejects a response with missing or malformed
bundle metadata that the previous URL-only validator accepted. That
failure is reported and leaves the dialog open; it cannot undo a bundle
already stored by the server. Revert this PR to remove the feature; it
introduces no migration or persisted setting.

### Decisions made without Ben

- Used the generated-types PR as the native stack parent, preserving the
bot's ownership of its generated branch. This keeps generation out of
the feature's handwritten diff.
- Kept the generated full-response validator with the existing HTTPS
restriction. A URL-only projection would accept incomplete responses and
conceal schema drift.
- Reused `authStore.currentUserIdentity()` for the account check rather
than adding a global authentication watcher. Identity binding is
private, including on the API-key path. This authentication-adjacent
change needs Ben's review; it does not change how credentials are minted
or selected.

| Existing run-bar screenshot | Existing dialog screenshot |
| --- | --- |
| ![Run bar with the rocket button and its
tooltip](https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/des1266-run-bar.png)
| ![Deploy to Comfy API
dialog](https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/des1266-dialog.png)
|

---------

Co-authored-by: Benjamin Lu <benjaminlu1107@gmail.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: GitHub Action <action@github.com>
Co-authored-by: Alexander Brown <drjkl@comfy.org>
DrJKL and others added 11 commits October 21, 2026 18:22
…ers (#21411)

## Summary

Stacked on #21396. Replace `ImperativePopover` consumers with
declarative Reka popovers and delete the adapter. Preserve hover delays,
focus restoration, selection dismissal, and viewport dismissal. A shared
viewport-dismiss composable keeps scroll handling out of each consumer.

## Verification

- Focused Vitest run: 201 tests passed across the migrated consumers and
shared popovers.
- Chromium: 51 passed; one toast screenshot differs by five pixels. The
same screenshot fails with the same five-pixel difference on unchanged
#21396.
- Browser checks covered canvas menu keyboard focus, nested template
filters, toast filtering, and workflow previews. Inspected captures of
canvas, login, and workflow popovers and an interaction recording.
- Added regression coverage for a pending hover timer reopening a
workflow preview after a quick click-open/click-close.

Risk: popover focus, anchoring, and dismissal across the migrated
callers. No data migration; revert this PR to restore the adapter.

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Previously, selecting a node would fail to dirty the background canvas,
links connected to the node would not be highlighted until a different
action dirtied the background canvas.

This is resolved by adding a watch on the already reactive selection
state.
The 'arrange nodes' functionality previously used `node.size` instead of
`node.renderingSize`. This would cause nodes like 'Load Image' to
incorrectly overlap.
| Before | After |
| ------ | ----- |
| <img width="360" alt="before"
src="https://github.com/user-attachments/assets/860c0f7d-1d9c-456c-a13c-251610bfd31c"/>
| <img width="360" alt="after"
src="https://github.com/user-attachments/assets/95e72069-d557-4ebd-94d5-098949a35faf"
/>|
#21583)

## Summary

Plain `/update-playwright` has failed on every PR since #20307. The
harvest expected one `snapshot-updates-*` artifact per
`playwright-tests*` job. The new `playwright-tests-native-lora` job
uploads none, so the count never matched and nothing was committed (e.g.
[update
run](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39663645177)
against [E2E
run](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39660252932),
where shard 5's stale baseline was dropped).

- Fixes [FE-3552](https://linear.app/comfyorg/issue/FE-3552)

Changes:

- The harvest only expects jobs that have an `Upload snapshot updates`
step, so non-screenshot Playwright jobs no longer count. Jobs that
report no steps at all are still expected, so a job that died before
GitHub listed its steps cannot silently drop out.
- `snapshot-updates-*` artifacts (main and website E2E) now end in `-${{
job.check_run_id }}`, so the harvest can name the jobs that left no
artifact instead of only counting them.
- When some jobs are missing, the harvest still passes the run on, and
the commit workflow commits what exists.

Fail vs warn:

| Situation | Outcome |
| --- | --- |
| No E2E run, unfinished or cancelled jobs, no jobs ran, or zero
artifacts | Fails as before (CAUTION) |
| Some jobs missing, updates committed | Pushes the updates. WARNING
names the unchecked jobs. Run passes |
| Some jobs missing, nothing to commit | Fails (CAUTION) naming the
jobs. Never says "already up to date" |
| All jobs reported | Unchanged |

Tradeoff: a partial commit can leave stale baselines in the missing
jobs. The alternative, committing nothing, throws away correct updates
and forces `full` for one flaky shard. Each committed image is a real
actual from a failed assertion, so a partial commit is strictly
progress. The WARNING tells the author to push again or use `full`. A
green run with no changes would hide a broken shard, so that case still
fails.

Transition: E2E runs started before this merges have artifacts without
job IDs. For those runs, every job is listed as missing. Updates are
still committed with a WARNING, and a run with no changes fails. This
clears once the PR gets a new E2E run.

## Verification

- `pnpm test:unit tools/snapshot-updates`: the new harvest and report
tests run the real workflow scripts. They extract them from the YAML and
use a fake `gh` that serves job and artifact fixtures. The harvest and
report tests fail against the old workflows.
- I ran the new job filter against the jobs of run 39660252932. It
selects 25 jobs, matching its 25 artifacts, and excludes
`playwright-tests-native-lora`.
- The `job.check_run_id` artifact names are exercised by this PR's own
E2E run.
## Summary

Adds `screenshotRegion`
(`browser_tests/fixtures/utils/screenshotRegion.ts`), extracted from the
drag-link clip in #21397, and applies it across the E2E suite so
screenshot assertions capture the nodes, links, menus, groups and drag
points under test rather than the whole canvas plus app chrome (legacy
Queue panel, toolbars, minimap, unrelated nodes). Also adds
`getGraphItemClientRects` (page-space bounds for groups / all items /
subgraph IO nodes), `NodeReference.getClientBounding()`,
`nodeOps.getAllNodeRefs()` and `canvasOps.setOffset()`.

Left as full-canvas: tests whose subject is the viewport (pan, zoom, fit
view, mobile baselines, focus mode, minimap) and assertions already
targeting a single element locator. `copyPaste` "Can copy and paste
node" is left unchanged: its baseline shows a widget prompt and no
pasted node, so the test does not exercise paste today; that needs a
separate fix.

Some nodes/vue-node-state tests now shift the view or hide the minimap
so the clip is unobstructed. Default-graph clips remain wide because
KSampler sits under the legacy menu.

Baselines change size and need regenerating (`/update-playwright full`).

## Verification

- `pnpm typecheck:browser`, oxlint, oxfmt clean.
- All converted specs run locally with regenerated baselines, each new
PNG inspected for framing, then rerun without `--update-snapshots` to
confirm stability.

---------

Co-authored-by: github-actions <github-actions@github.com>
## Summary

Removes `comfyPage.canvasOps.resetView()` and its call sites. It clicked
the legacy menu's Reset View button only when that button was visible,
so on the default Top menu it did nothing. The `afterEach` hooks that
called it ran against a page that each test discards anyway. The
recorder transform, agent guidance and review checks no longer generate
or require it.

Stacked on #21430, which closes the legacy menu by default and left
`resetView` running a command instead of a user action.

## Verification

- `pnpm test:unit tools/test-recorder/src/transform/rules.test.ts`: 26
passed.
- `pnpm typecheck:browser` and oxlint on the changed files: clean.
- Locally, nodeBadge, canvasSettings, copyPaste, linksExecution and
resize: the only real diffs are the Node source badge shots. They now
use the workflow's saved zoom, so their baselines need regenerating. The
other local diffs are the usual 4–8 px rendering noise.

---------

Co-authored-by: github-actions <github-actions@github.com>
## Summary

Follow up on #21238, which merged before two exact-head CodeRabbit
findings were repaired. The raw permanent `doc_subscribed` refusal now
satisfies a CRDT wire-boundary type with the three existing terminal
codes, while repeated turn-state helpers and the user-message locator
live in the Agent fixture/page object instead of the spec.

No product behavior changes.

## Verification

- Existing #21238 proof preserved: parent `a8e134a988` failed 2 cases,
merged head `b5d885b3ec` passed 3, and this follow-up passes all 3
focused cloud cases.
- Mutation proof repeated: reducing `followerOwnsDocument` to the
incorrect bound-ID-only predicate fails the refused-follower case at
`draftNodeCount` with `Received: undefined`; restoring the production
predicate passes the case.
- `pnpm test:unit
src/workbench/extensions/agent/crdt/agentCrdtDocLifecycle.test.ts
src/workbench/extensions/agent/crdt/docFrameClient.test.ts` — 43 passed.
- `pnpm typecheck:browser`, targeted type-aware oxlint, and oxfmt check
passed.
- Full guarded commit and push hooks passed (`typecheck:app`,
`typecheck:browser`, dependency cruise, knip, fallow).
…nents' into design-system/move-freed-components

Amp-Thread-ID: https://ampcode.com/threads/T-683b0f27-c926-4f18-9572-a7ce9f3b1596

# Conflicts:
#	packages/design-system/package.json
…eed-components

Amp-Thread-ID: https://ampcode.com/threads/T-683b0f27-c926-4f18-9572-a7ce9f3b1596

# Conflicts:
#	src/components/common/ImperativePopover.vue
#	src/components/graph/CanvasModeSelector.vue
#	src/components/topbar/CurrentUserButton.vue
#	src/components/topbar/LoginButton.vue
#	src/platform/assets/components/ModelImportProgressDialog.vue
#	src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenuActions.vue
#	src/workbench/extensions/manager/components/manager/PackVersionBadge.vue
The package already exports popover/Popover as the bare Reka root, so the
trigger-plus-content wrapper takes the name of its button slot.
usePopoverViewportDismiss moves with it as a lib export.

Amp-Thread-ID: https://ampcode.com/threads/T-683b0f27-c926-4f18-9572-a7ce9f3b1596
@DrJKL
DrJKL merged commit 2e9a241 into design-system/extract-card-components Oct 21, 2026
59 of 60 checks passed
@DrJKL
DrJKL deleted the design-system/move-freed-components branch October 21, 2026 21:51
@github-actions github-actions Bot added risk:unknown and removed risk:xhigh PR risk grade (advisory shadow check; grader-owned) labels Oct 21, 2026
DrJKL added a commit that referenced this pull request Oct 27, 2026
## Summary

Move app-independent components, supporting types, recipes, pure
stories, and their tests into `@comfyorg/design-system`. App wrappers
with stores, translations, or app state remain app-owned. This PR also
carries #21499 (components freed by #21396 and #21420) and the root
`Popover` freed by #21411.

```text
App wrappers → design-system components → shared Vue and Reka peers
```

Workspace imports use Vue source. Published imports use compiled ES
modules and ordinary declarations with Bundler resolution; every
published component and `lib/*` export has a `default` condition. `clsx`
and `tailwind-merge` are declared dependencies and stay external, so
consumers share one class-merging runtime. Scoped component CSS is
exported separately and is published-only. Reka and its type-helper
prerequisite are peers, optional for CSS-only consumers.

```diff
 @comfyorg/design-system
+  button, tooltip (TextTooltip, TooltipContent), PopoverContent, HoverCardContent
+  menu (Menu, ContextMenu, ContextMenuContent, MenuItems, MenuSubmenu,
+        MenuRadioGroup, MenuItemContent, MenuAction, MenuContent, MenuSubContent)
+  Badge, Message, Spinner, Pagination, TableSortHead, TreeItem, PasswordInput, InputGroupButton
+  dialog (DialogClose, DialogMaximize, DialogPanel), toast (ToastClose, ToastDock, ToastViewport)
+  search-input (SearchInput, SearchAutocomplete, AsyncSearchInput)
+  select (SelectContent, SingleSelect, SearchableSingleSelect, MultiSelect, MultiSelectContent)
+  media/ZoomPane, NumberFieldIncrement/Decrement, TagsInputItemDelete, TagRemoveButton
+  lib: useSelectSearch, useAttrsClass, usePopoverSizing, usePopoverViewportDismiss, menu helpers
 app
-  Popover (ui): consumers use Reka PopoverRoot/Trigger with the design-system PopoverContent
-  Toaster (ui) + AppToaster (wrapper)
+  AppToaster (one component: queue rendering, announcements, labels)
```

- `MenuContent` and `MenuSubContent` portal their own content, and
`MenuSubContent` must be rendered inside `MenuSub`. Context menus use
the new `ContextMenuContent`. Keyed menus skip the close animation, as
#21396 accepts.
- `Dialogue` and `ImageLightbox` are built on the design-system dialog
parts. The checkout saved-method picker uses the design-system
`SingleSelect`. `DeploymentSwitcherRow` stays in the app.
- Component tests, `DialogOrdering` stories, and the component guidance
(`AGENTS.md`) move into the package, which runs its own Vitest with
happy-dom.
- Out of scope: the ColorPicker family (#21480) and CreditSlider
(subscription pricing).
- The package scans its stories for Tailwind classes because root
Storybook depends on them; tests and markdown are excluded.

Intended visual changes:

- `Dialogue` uses the `sm` dialog size (384px) and the dialog surface.
- The lightbox overlay is 70% opaque.
- `BillingAutoTopUpCard` uses `destructive`; its previous
`destructive-background` token does not exist.
- `PopoverContent` defaults `collisionPadding` to 8.

## Verification

- A new import guard fails when compiled JS or declarations import an
undeclared package. It failed on the bundled class-merging runtime
before the fix and passes now. CI and the publish workflow run it.
- An isolated, non-hoisted packed consumer, tested with Reka 2.11.0,
passes strict type checking, host-provider SSR (including `Button` and a
searchable select through `fuse.js`), Tailwind compilation, and
scoped-animation checks. CI and the publish workflow run it.
- Package Vitest, app/browser/package typechecks, build, lint, Knip,
`architecture:check`, affected app unit tests, and the node-search E2E
specs pass.
- Storybook checks: toasts of every kind, a select listbox and nested
menu above an open dialog, `DialogPanel`, and `DialogClose` render
correctly.

Two-way door. Mostly import-path churn. The main risks are unresolved
package imports, duplicate provider contexts, and missing compiled
styles or declarations. This PR does not publish a package.

---------

Co-authored-by: GitHub Action <action@github.com>
Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants