Repository navigation
[backport core/1.58] FE-1908 fix(billing): open blocked checkout and card pages from a real link - #21393
Conversation
…l link (#21388) ## Summary **Why:** people who block pop-ups get stuck in the workspace Add credits dialog. When the hosted-checkout tab (no default card) or the "Set a default card" portal tab is blocked, the retry is another `window.open`, which the blocker refuses too. For the portal, the dialog only showed a toast asking the user to allow pop-ups and try again. **Root cause:** both retries are scripted opens, and pop-up blockers refuse those. A clicked link is a navigation, not a pop-up, so blockers allow it. **How:** - "Checkout didn't open": "Open checkout" is now `Button as="a"` with `target="_blank"` and `rel="noopener"`. Its `href` is the checkout URL of the session created when the screen appeared. Clicking it starts the same pending top-up and balance watch as a successful open, then closes the dialog. It creates no new session and calls no `window.open`. - "Set a default card": when the reserved tab is blocked, the dialog still creates the portal session (`payment_method_update`). It then shows a new "Payment page didn't open" screen whose "Open payment page" button links to that portal URL. Following the link goes back to Confirm and registers the same refresh-on-return as a successful open. A failed or empty portal response shows the existing "Couldn't open card settings" toast. - New strings: `defaultCardBlockedTitle`, `defaultCardBlockedBody`, `openPaymentPage`. The old "Allow pop-ups and try again" toast is no longer used here. - No new client-derived facts. The links only reuse URLs the server returned. **Feature flag / routing:** no new flag. The dialog is `TopUpCreditsDialogContentWorkspace`, which `useBillingDialogs` picks when `useBillingRouting().type` is not `legacy`. Personal workspaces on the legacy billing rail still get the legacy dialog unless `legacyBillingMigrationEnabled` is on. The dialog also requires `canTopUp`. The no-default-card path is reached on a `NO_PAYMENT_METHOD` top-up refusal. **Overlap:** PR #21366 also turns the blocked checkout into a link, as part of a larger rework, and removes "Set a default card". This PR is the small fix for main and the 1.58 branches. Whichever PR lands second resolves the conflict. Decision: https://comfy-organization.slack.com/archives/C0BNGQG2LCW/p1792446469557019?thread_ts=1792446135.151939 ## AS IS / TO BE | Screen | AS IS (main) | TO BE (this PR) | | --- | --- | --- | | Checkout didn't open | <img src="https://gist.githubusercontent.com/dante01yoon/ac41345acd89867b2aed3b273b5f7ef3/raw/as-is-checkout-blocked.png" width="360"> | <img src="https://gist.githubusercontent.com/dante01yoon/ac41345acd89867b2aed3b273b5f7ef3/raw/to-be-checkout-blocked.png?v=2" width="360"> | | Set a default card, tab blocked | <img src="https://gist.githubusercontent.com/dante01yoon/ac41345acd89867b2aed3b273b5f7ef3/raw/as-is-default-card-blocked.png" width="360"> | <img src="https://gist.githubusercontent.com/dante01yoon/ac41345acd89867b2aed3b273b5f7ef3/raw/to-be-default-card-blocked.png?v=2" width="360"> | Captured on testcloud in a team workspace on workspace billing routing with `canTopUp`. Pop-ups were blocked, and the top-up (`NO_PAYMENT_METHOD`), checkout and portal requests were mocked. ## Verification - `pnpm exec vitest run src/platform/workspace/components/TopUpCreditsDialogContentWorkspace.test.ts`: 90 passed. One table-driven test covers both blocked screens and checks that each renders a link with the session URL, `target="_blank"` and `rel="noopener"`, and that clicking it makes no second session request and no second `window.open`. Other tests cover the checkout follow-up (pending top-up and dialog close), the portal follow-up (back to Pay once a default card exists on return), and portal failures while blocked. - `oxlint --type-aware`, `oxfmt` and `eslint` pass on the touched files, and the pre-commit typecheck passes. - No Playwright spec covers these blocked screens, so no E2E changes.
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-19T23:17:39.952Z",
"gitSha": "a9b553ef9a693fc55e03043bd282509f3eab9be6",
"branch": "backport-21388-to-core-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2009.9980000000528,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.377,
"layouts": 10,
"layoutDurationMs": 2.2329999999999997,
"taskDurationMs": 347.961,
"heapDeltaBytes": -1355668,
"heapUsedBytes": 97343972,
"domNodes": -181,
"jsHeapTotalBytes": 5935104,
"scriptDurationMs": 9.487,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2016.5949999999953,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.165,
"layouts": 10,
"layoutDurationMs": 2.0540000000000003,
"taskDurationMs": 293.704,
"heapDeltaBytes": 3576720,
"heapUsedBytes": 95055472,
"domNodes": 0,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 7.557999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1693.2500000000346,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.932,
"layouts": 11,
"layoutDurationMs": 2.5500000000000003,
"taskDurationMs": 741.7,
"heapDeltaBytes": -22750292,
"heapUsedBytes": 81474592,
"domNodes": -200,
"jsHeapTotalBytes": 2801664,
"scriptDurationMs": 114.75399999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1959.592999999984,
"styleRecalcs": 82,
"styleRecalcDurationMs": 12.488,
"layouts": 10,
"layoutDurationMs": 2.3600000000000003,
"taskDurationMs": 927.7180000000001,
"heapDeltaBytes": 23261756,
"heapUsedBytes": 114609004,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 123.438,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666101694915252,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1710.478999999964,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.066,
"layouts": 12,
"layoutDurationMs": 2.2960000000000003,
"taskDurationMs": 236.429,
"heapDeltaBytes": 1729560,
"heapUsedBytes": 105589228,
"domNodes": 47,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 8.989,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.0819999999903,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.074000000000001,
"layouts": 12,
"layoutDurationMs": 2.372,
"taskDurationMs": 313.533,
"heapDeltaBytes": 1791120,
"heapUsedBytes": 105652804,
"domNodes": 47,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 9.199999999999998,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262135,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 550.9969999999953,
"styleRecalcs": 15,
"styleRecalcDurationMs": 2.5419999999999994,
"layouts": 10,
"layoutDurationMs": 2.311,
"taskDurationMs": 348.371,
"heapDeltaBytes": 3747832,
"heapUsedBytes": 94792296,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 129.882,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 561.4909999999895,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.4830000000000005,
"layouts": 10,
"layoutDurationMs": 2.162,
"taskDurationMs": 401.146,
"heapDeltaBytes": 3895016,
"heapUsedBytes": 102872976,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 133.511,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66176470588235,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1025.718000000012,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 657.581,
"heapDeltaBytes": -16607584,
"heapUsedBytes": 102063156,
"domNodes": -210,
"jsHeapTotalBytes": 13873152,
"scriptDurationMs": 52.066,
"eventListeners": -168,
"totalBlockingTimeMs": 371,
"frameDurationMs": 28.700000000000006,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1009.4990000000053,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 656.317,
"heapDeltaBytes": -17261740,
"heapUsedBytes": 101854300,
"domNodes": -230,
"jsHeapTotalBytes": 15970304,
"scriptDurationMs": 50.12799999999999,
"eventListeners": -168,
"totalBlockingTimeMs": 369,
"frameDurationMs": 29.045714285714297,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 769.0230000000042,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 346.4739999999997,
"heapDeltaBytes": -5142816,
"heapUsedBytes": 96394636,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 108.25999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 154,
"frameDurationMs": 22.547058823529397,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 782.8669999999534,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 382.68499999999995,
"heapDeltaBytes": -3976040,
"heapUsedBytes": 96575308,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 113.66500000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 156,
"frameDurationMs": 23.03823529411765,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7346.314000000007,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.9630000000000003,
"layouts": 4,
"layoutDurationMs": 0.8579999999999999,
"taskDurationMs": 6498.5740000000005,
"heapDeltaBytes": 17255508,
"heapUsedBytes": 140475408,
"domNodes": -306,
"jsHeapTotalBytes": 30642176,
"scriptDurationMs": 5260.808,
"eventListeners": -130,
"totalBlockingTimeMs": 73,
"frameDurationMs": 24.3624584717608,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7035.097000000007,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.6089999999999993,
"layouts": 2,
"layoutDurationMs": 0.41899999999999965,
"taskDurationMs": 6335.2789999999995,
"heapDeltaBytes": 11615556,
"heapUsedBytes": 133044692,
"domNodes": -276,
"jsHeapTotalBytes": 20877312,
"scriptDurationMs": 4846.977,
"eventListeners": -130,
"totalBlockingTimeMs": 81,
"frameDurationMs": 24.590909090909086,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6758.18799999999,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.6179999999999997,
"layouts": 3,
"layoutDurationMs": 0.6400000000000003,
"taskDurationMs": 6054.296,
"heapDeltaBytes": -346144,
"heapUsedBytes": 113012008,
"domNodes": -296,
"jsHeapTotalBytes": 15437824,
"scriptDurationMs": 4880.932,
"eventListeners": -130,
"totalBlockingTimeMs": 124,
"frameDurationMs": 25.567424242424238,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7463.369000000001,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.7080000000000003,
"layouts": 3,
"layoutDurationMs": 0.556,
"taskDurationMs": 6678.17,
"heapDeltaBytes": 8709204,
"heapUsedBytes": 130171872,
"domNodes": -282,
"jsHeapTotalBytes": 34414592,
"scriptDurationMs": 5200.106,
"eventListeners": -130,
"totalBlockingTimeMs": 86,
"frameDurationMs": 24.641584158415842,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "large-combo-open",
"durationMs": 176.75300000001926,
"styleRecalcs": 22,
"styleRecalcDurationMs": 11.004,
"layouts": 12,
"layoutDurationMs": 2.832,
"taskDurationMs": 136.01099999999997,
"heapDeltaBytes": -9105912,
"heapUsedBytes": 104437416,
"domNodes": 917,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 6.679000000000001,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.366666666666635,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 163.81200000000717,
"styleRecalcs": 22,
"styleRecalcDurationMs": 12.328,
"layouts": 12,
"layoutDurationMs": 3.018,
"taskDurationMs": 125.168,
"heapDeltaBytes": 13255496,
"heapUsedBytes": 120133264,
"domNodes": 917,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 6.455000000000003,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.837499999999977,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2025.5630000000338,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.8159999999999998,
"layouts": 9,
"layoutDurationMs": 2.862,
"taskDurationMs": 519.3940000000001,
"heapDeltaBytes": -1544684,
"heapUsedBytes": 101323464,
"domNodes": -296,
"jsHeapTotalBytes": -1142784,
"scriptDurationMs": 28.357,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-idle",
"durationMs": 2024.3090000000166,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.6890000000000005,
"layouts": 8,
"layoutDurationMs": 1.626,
"taskDurationMs": 513.0669999999999,
"heapDeltaBytes": -19992136,
"heapUsedBytes": 91657964,
"domNodes": -296,
"jsHeapTotalBytes": -1601536,
"scriptDurationMs": 26.992999999999995,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2152.164999999968,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.161999999999999,
"layouts": 8,
"layoutDurationMs": 1.629,
"taskDurationMs": 1185.253,
"heapDeltaBytes": 902960,
"heapUsedBytes": 103984880,
"domNodes": -297,
"jsHeapTotalBytes": -393216,
"scriptDurationMs": 624.9319999999999,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66589147286822,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2267.2750000000406,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.939,
"layouts": 8,
"layoutDurationMs": 1.5379999999999998,
"taskDurationMs": 1417.465,
"heapDeltaBytes": -11833676,
"heapUsedBytes": 110368180,
"domNodes": -296,
"jsHeapTotalBytes": 233472,
"scriptDurationMs": 662.361,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66544117647059,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-zoom",
"durationMs": 3231.262000000015,
"styleRecalcs": 72,
"styleRecalcDurationMs": 9.246999999999998,
"layouts": 66,
"layoutDurationMs": 9.77,
"taskDurationMs": 1291.7730000000001,
"heapDeltaBytes": -9898248,
"heapUsedBytes": 95103796,
"domNodes": -272,
"jsHeapTotalBytes": -2060288,
"scriptDurationMs": 616.077,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75181347150259,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3334.3270000000302,
"styleRecalcs": 71,
"styleRecalcDurationMs": 8.848000000000003,
"layouts": 64,
"layoutDurationMs": 9.381,
"taskDurationMs": 1455.8819999999998,
"heapDeltaBytes": -1993020,
"heapUsedBytes": 104494396,
"domNodes": -272,
"jsHeapTotalBytes": 102400,
"scriptDurationMs": 637.045,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.749748743718595,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2493.9559999999688,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.084,
"layouts": 6,
"layoutDurationMs": 1.2719999999999998,
"taskDurationMs": 1430.849,
"heapDeltaBytes": 17440772,
"heapUsedBytes": 124297476,
"domNodes": 0,
"jsHeapTotalBytes": 6451200,
"scriptDurationMs": 790.4250000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.777852348993292,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2207.851000000005,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.025999999999999,
"layouts": 6,
"layoutDurationMs": 1.3519999999999999,
"taskDurationMs": 1383.8940000000002,
"heapDeltaBytes": 11988020,
"heapUsedBytes": 118346012,
"domNodes": 0,
"jsHeapTotalBytes": 6189056,
"scriptDurationMs": 753.418,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.92230769230769,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2047.4719999999706,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.6849999999999998,
"layouts": 8,
"layoutDurationMs": 1.575,
"taskDurationMs": 517.794,
"heapDeltaBytes": 4134488,
"heapUsedBytes": 106837284,
"domNodes": -276,
"jsHeapTotalBytes": -5861376,
"scriptDurationMs": 27.519999999999996,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-idle",
"durationMs": 2037.8090000000384,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.915,
"layouts": 9,
"layoutDurationMs": 1.9560000000000002,
"taskDurationMs": 397.23300000000006,
"heapDeltaBytes": -12327544,
"heapUsedBytes": 101355368,
"domNodes": -276,
"jsHeapTotalBytes": -1863680,
"scriptDurationMs": 26.483,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667213114754095,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 593.8509999999724,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.659999999999999,
"layouts": 10,
"layoutDurationMs": 2.152,
"taskDurationMs": 393.536,
"heapDeltaBytes": 22486936,
"heapUsedBytes": 114543684,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 118.839,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66388888888889,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 483.00300000005336,
"styleRecalcs": 48,
"styleRecalcDurationMs": 4.454999999999999,
"layouts": 10,
"layoutDurationMs": 2.233,
"taskDurationMs": 309.893,
"heapDeltaBytes": 2639512,
"heapUsedBytes": 108965060,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 116.85999999999999,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379302,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2009.568999999999,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.9259999999999997,
"layouts": 9,
"layoutDurationMs": 1.7969999999999997,
"taskDurationMs": 420.943,
"heapDeltaBytes": 3501388,
"heapUsedBytes": 95857036,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 6.637999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2027.4970000000394,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.099,
"layouts": 10,
"layoutDurationMs": 1.9720000000000002,
"taskDurationMs": 329.698,
"heapDeltaBytes": 3641732,
"heapUsedBytes": 94526560,
"domNodes": -218,
"jsHeapTotalBytes": -2191360,
"scriptDurationMs": 6.939999999999999,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1992.7279999999996,
"styleRecalcs": 88,
"styleRecalcDurationMs": 12.32,
"layouts": 10,
"layoutDurationMs": 1.9989999999999999,
"taskDurationMs": 942.884,
"heapDeltaBytes": -20571408,
"heapUsedBytes": 85124084,
"domNodes": -210,
"jsHeapTotalBytes": 2265088,
"scriptDurationMs": 83.66699999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66583333333333,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1711.3140000000158,
"styleRecalcs": 75,
"styleRecalcDurationMs": 10.765,
"layouts": 9,
"layoutDurationMs": 1.872,
"taskDurationMs": 562.7059999999999,
"heapDeltaBytes": -13092600,
"heapUsedBytes": 79087492,
"domNodes": -190,
"jsHeapTotalBytes": 2854912,
"scriptDurationMs": 80.477,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1334.7120000000245,
"styleRecalcs": 20,
"styleRecalcDurationMs": 19.293999999999997,
"layouts": 5,
"layoutDurationMs": 11.996999999999998,
"taskDurationMs": 816.6039999999999,
"heapDeltaBytes": 11500680,
"heapUsedBytes": 132717004,
"domNodes": 15950,
"jsHeapTotalBytes": 16654336,
"scriptDurationMs": 24.083999999999996,
"eventListeners": 3244,
"totalBlockingTimeMs": 103,
"frameDurationMs": 18.75,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8176.845000000014,
"styleRecalcs": 251,
"styleRecalcDurationMs": 27.727,
"layouts": 9,
"layoutDurationMs": 1.7360000000000002,
"taskDurationMs": 4033.83,
"heapDeltaBytes": 1156040,
"heapUsedBytes": 103831136,
"domNodes": -296,
"jsHeapTotalBytes": -917504,
"scriptDurationMs": 2094.716,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66591836734694,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8258.969999999976,
"styleRecalcs": 251,
"styleRecalcDurationMs": 26.442,
"layouts": 9,
"layoutDurationMs": 1.8339999999999999,
"taskDurationMs": 4603.749,
"heapDeltaBytes": -2026732,
"heapUsedBytes": 100060712,
"domNodes": -296,
"jsHeapTotalBytes": -1073152,
"scriptDurationMs": 2030.992,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665927419354837,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18670.826000000034,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18122.742000000002,
"heapDeltaBytes": -46874660,
"heapUsedBytes": 277854636,
"domNodes": -3337,
"jsHeapTotalBytes": 17813504,
"scriptDurationMs": 251.216,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.51898954703833,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "vue-large-graph-idle",
"durationMs": 18590.517999999975,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17867.763,
"heapDeltaBytes": -21127060,
"heapUsedBytes": 280095268,
"domNodes": -3337,
"jsHeapTotalBytes": 18599936,
"scriptDurationMs": 233.07,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.23448873483536,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-large-graph-pan",
"durationMs": 23428.31099999995,
"styleRecalcs": 181,
"styleRecalcDurationMs": 18.680000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23001.346,
"heapDeltaBytes": -20490980,
"heapUsedBytes": 284615828,
"domNodes": -3337,
"jsHeapTotalBytes": 9424896,
"scriptDurationMs": 734.358,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 44.29565217391304,
"p95FrameDurationMs": 99.89999999999964
},
{
"name": "vue-large-graph-pan",
"durationMs": 23222.569999999905,
"styleRecalcs": 180,
"styleRecalcDurationMs": 19.738000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22859.918,
"heapDeltaBytes": -7556588,
"heapUsedBytes": 297741396,
"domNodes": -3337,
"jsHeapTotalBytes": 12046336,
"scriptDurationMs": 736.118,
"eventListeners": -651,
"totalBlockingTimeMs": 4,
"frameDurationMs": 43.588180112570356,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 5061.284999999998,
"styleRecalcs": 20,
"styleRecalcDurationMs": 69.40199999999999,
"layouts": 20,
"layoutDurationMs": 26.886000000000006,
"taskDurationMs": 4962.931,
"heapDeltaBytes": -2362272,
"heapUsedBytes": 302893568,
"domNodes": -3337,
"jsHeapTotalBytes": 18862080,
"scriptDurationMs": 106.33000000000001,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.286127167630056,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-node-resize-workload",
"durationMs": 5004.558999999972,
"styleRecalcs": 20,
"styleRecalcDurationMs": 46.81399999999999,
"layouts": 20,
"layoutDurationMs": 20.845000000000002,
"taskDurationMs": 4879.804999999999,
"heapDeltaBytes": -8081092,
"heapUsedBytes": 302495600,
"domNodes": -3337,
"jsHeapTotalBytes": 29872128,
"scriptDurationMs": 78.146,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.06860465116279,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9282.275000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9039.206,
"heapDeltaBytes": -15974308,
"heapUsedBytes": 283014148,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 122.29600000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.361486486486488,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6663.551000000098,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6268.241000000002,
"heapDeltaBytes": 2476988,
"heapUsedBytes": 281656488,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 88.34600000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.109999999999992,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "workflow-execution",
"durationMs": 80.5520000000115,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.632,
"layouts": 5,
"layoutDurationMs": 1.6560000000000001,
"taskDurationMs": 58.628000000000014,
"heapDeltaBytes": 4802716,
"heapUsedBytes": 106839012,
"domNodes": 97,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.415000000000003,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.680000000000017,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 98.88100000000577,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.801,
"layouts": 6,
"layoutDurationMs": 2.111,
"taskDurationMs": 63.60799999999998,
"heapDeltaBytes": 4668320,
"heapUsedBytes": 106063332,
"domNodes": 120,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.753,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 262.6040000000103,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.6130000000000001,
"layouts": 76,
"layoutDurationMs": 11.351999999999999,
"taskDurationMs": 228.719,
"heapDeltaBytes": -17807936,
"heapUsedBytes": 69833448,
"domNodes": 4,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 103.603,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668750000000017,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 283.91799999997147,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.588,
"layouts": 76,
"layoutDurationMs": 11.523,
"taskDurationMs": 238.34199999999998,
"heapDeltaBytes": 10149788,
"heapUsedBytes": 96055780,
"domNodes": 4,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 108.916,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 315.1519999998982,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.46,
"layouts": 76,
"layoutDurationMs": 10.155000000000001,
"taskDurationMs": 282.317,
"heapDeltaBytes": -1311996,
"heapUsedBytes": 115346668,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 107.292,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66500000000001,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 341.39700000002904,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.57,
"layouts": 76,
"layoutDurationMs": 10.220999999999998,
"taskDurationMs": 304.586,
"heapDeltaBytes": -1140220,
"heapUsedBytes": 115557148,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 115.275,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageLine coverage: 64.0% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2951 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 2a9b5574c1761003744a4d546b915aa7e998e094
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (111)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.58 #21393 +/- ##
=============================================
- Coverage 87.64% 87.04% -0.61%
=============================================
Files 2808 2726 -82
Lines 153435 151400 -2035
Branches 40260 41268 +1008
=============================================
- Hits 134481 131786 -2695
- Misses 18406 19224 +818
+ Partials 548 390 -158
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 167 files with indirect coverage changes 🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
LGTM, clean backport.
…out instead of closing the dialog (#21409) ## Why Backport of #21395 to `core/1.58` (`git cherry-pick -x 0b0ffbe`): after the hosted checkout opens, the workspace Add credits dialog shows a "Checkout opened in a new tab" hand-off with Close / Reopen checkout instead of closing at once. ## How - Builds on the PR 21388 backport, already merged to `core/1.58` as #21393. - Conflicts: none. The auto-backport failed only because 21388 had not landed on `core/1.58` yet. With it merged the cherry-pick applies cleanly, and every hunk is identical to the original (only line offsets differ). No adaptation or extra main-only code. - Tests: `pnpm exec vitest run src/platform/workspace/components/TopUpCreditsDialogContentWorkspace.test.ts` (98 passed); `oxlint --type-aware`, `oxfmt --check` and `eslint` on the touched files clean. ## AS IS / TO BE Same behaviour change as #21395; see its screenshots.
Backport of #21388 to
core/1.58Automatically created by backport workflow.