Repository navigation
FE-1908 fix(billing): open blocked checkout and card pages from a real link - #21388
Conversation
When the browser blocks the new tab, the checkout and the card-settings portal screens now link to the session already created, so following the link is a navigation the pop-up blocker allows instead of another window.open that is blocked too.
📦 Bundle: 11.6 MB gzip 🔴 +368 BDetailsSummary
Category Glance App Entry Points — 6.92 kB (baseline 6.92 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 3.39 MB (baseline 3.39 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 3 added / 3 removed / 1 unchanged Views & Navigation — 147 kB (baseline 147 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 12 added / 12 removed / 6 unchanged Panels & Settings — 784 kB (baseline 784 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 14 added / 14 removed / 20 unchanged User & Accounts — 153 kB (baseline 153 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 9 added / 9 removed / 8 unchanged Editors & Dialogs — 366 kB (baseline 366 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 9 added / 9 removed / 4 unchanged UI Components — 225 kB (baseline 225 kB) • ⚪ 0 BReusable component library chunks
Status: 8 added / 8 removed / 22 unchanged Data & Services — 1.21 MB (baseline 1.21 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 36 added / 36 removed / 7 unchanged Utilities & Hooks — 1.01 MB (baseline 1.01 MB) • 🔴 +1.4 kBHelpers, composables, and utility bundles
Status: 40 added / 40 removed / 37 unchanged Vendor & Third-Party — 24.7 MB (baseline 24.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 17 unchanged Other — 20.6 MB (baseline 20.6 MB) • 🔴 +209 BBundles that do not match a named category
Status: 107 added / 107 removed / 580 unchanged ⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-19T22:40:45.435Z",
"gitSha": "c9bcec62bce74c6326d93adaa5bef9a52569a37a",
"branch": "dante/fe-1908-blocked-tab-links",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2007.2109999999839,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.423,
"layouts": 10,
"layoutDurationMs": 2.9859999999999998,
"taskDurationMs": 444.579,
"heapDeltaBytes": -17092032,
"heapUsedBytes": 86589528,
"domNodes": -180,
"jsHeapTotalBytes": 1753088,
"scriptDurationMs": 10.824,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2012.2860000000173,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.1079999999999997,
"layouts": 10,
"layoutDurationMs": 2.6740000000000004,
"taskDurationMs": 369.106,
"heapDeltaBytes": -13322620,
"heapUsedBytes": 90958116,
"domNodes": -200,
"jsHeapTotalBytes": 1740800,
"scriptDurationMs": 11.4,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1727.0730000000185,
"styleRecalcs": 72,
"styleRecalcDurationMs": 14.181,
"layouts": 10,
"layoutDurationMs": 2.678,
"taskDurationMs": 710.753,
"heapDeltaBytes": -12903756,
"heapUsedBytes": 90886508,
"domNodes": -180,
"jsHeapTotalBytes": 2265088,
"scriptDurationMs": 123.964,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6673076923077,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1694.107000000031,
"styleRecalcs": 71,
"styleRecalcDurationMs": 13.338000000000003,
"layouts": 9,
"layoutDurationMs": 2.398,
"taskDurationMs": 615.173,
"heapDeltaBytes": -12417360,
"heapUsedBytes": 91989420,
"domNodes": -200,
"jsHeapTotalBytes": 3313664,
"scriptDurationMs": 122.66700000000002,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1717.9209999999898,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.839,
"layouts": 11,
"layoutDurationMs": 2.8360000000000003,
"taskDurationMs": 295.549,
"heapDeltaBytes": 21526624,
"heapUsedBytes": 109942996,
"domNodes": 47,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 13.314000000000002,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.5330000000176,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.94,
"layouts": 12,
"layoutDurationMs": 3.3260000000000005,
"taskDurationMs": 324.498,
"heapDeltaBytes": 1830284,
"heapUsedBytes": 105529112,
"domNodes": 47,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 14.155,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 541.3970000000177,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.4530000000000003,
"layouts": 11,
"layoutDurationMs": 3.15,
"taskDurationMs": 365.461,
"heapDeltaBytes": 6479832,
"heapUsedBytes": 110631308,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 120.15199999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 483.496999999943,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.309,
"layouts": 11,
"layoutDurationMs": 2.9760000000000004,
"taskDurationMs": 313.989,
"heapDeltaBytes": 6490432,
"heapUsedBytes": 110286680,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 111.37700000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1006.4520000000243,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 665.9079999999999,
"heapDeltaBytes": -1764860,
"heapUsedBytes": 102456764,
"domNodes": -210,
"jsHeapTotalBytes": 9060352,
"scriptDurationMs": 47.917,
"eventListeners": -168,
"totalBlockingTimeMs": 325,
"frameDurationMs": 27.024324324324326,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 934.6310000000813,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 584.7750000000001,
"heapDeltaBytes": -8807328,
"heapUsedBytes": 102162868,
"domNodes": -210,
"jsHeapTotalBytes": 10137600,
"scriptDurationMs": 37.116,
"eventListeners": -168,
"totalBlockingTimeMs": 283,
"frameDurationMs": 26.668571428571433,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 717.2150000000101,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 316.4589999999996,
"heapDeltaBytes": -4208784,
"heapUsedBytes": 97070232,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 98.28800000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 99,
"frameDurationMs": 21.079411764705878,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 702.2759999999835,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 298.924,
"heapDeltaBytes": -2626400,
"heapUsedBytes": 97601036,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 97.73299999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 92,
"frameDurationMs": 20.58823529411765,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6802.503999999999,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.0230000000000006,
"layouts": 3,
"layoutDurationMs": 0.8059999999999998,
"taskDurationMs": 5800.516,
"heapDeltaBytes": 22282792,
"heapUsedBytes": 143961480,
"domNodes": -276,
"jsHeapTotalBytes": 36081664,
"scriptDurationMs": 4377.149,
"eventListeners": -130,
"totalBlockingTimeMs": 60,
"frameDurationMs": 20.297313432835818,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6406.953000000044,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.9459999999999998,
"layouts": 3,
"layoutDurationMs": 0.8200000000000004,
"taskDurationMs": 5467.988,
"heapDeltaBytes": -20439548,
"heapUsedBytes": 100089728,
"domNodes": -297,
"jsHeapTotalBytes": 2265088,
"scriptDurationMs": 4127.161,
"eventListeners": -130,
"totalBlockingTimeMs": 28,
"frameDurationMs": 20.98262295081967,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6340.20300000003,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.0280000000000002,
"layouts": 3,
"layoutDurationMs": 0.8739999999999998,
"taskDurationMs": 5666.273,
"heapDeltaBytes": 21609968,
"heapUsedBytes": 143361864,
"domNodes": -276,
"jsHeapTotalBytes": 21925888,
"scriptDurationMs": 4194.39,
"eventListeners": -130,
"totalBlockingTimeMs": 41,
"frameDurationMs": 24.080228136882127,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6589.36499999993,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.9839999999999997,
"layouts": 4,
"layoutDurationMs": 1.137,
"taskDurationMs": 5567.862,
"heapDeltaBytes": 16378536,
"heapUsedBytes": 138478712,
"domNodes": -276,
"jsHeapTotalBytes": 28831744,
"scriptDurationMs": 4191.227000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 76,
"frameDurationMs": 20.182874617737,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "large-combo-open",
"durationMs": 158.58800000000883,
"styleRecalcs": 21,
"styleRecalcDurationMs": 13.51,
"layouts": 10,
"layoutDurationMs": 2.8809999999999993,
"taskDurationMs": 119.719,
"heapDeltaBytes": 13256740,
"heapUsedBytes": 120367552,
"domNodes": 917,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 6.564,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.837499999999977,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 153.0329999999367,
"styleRecalcs": 21,
"styleRecalcDurationMs": 12.669,
"layouts": 11,
"layoutDurationMs": 2.974,
"taskDurationMs": 113.732,
"heapDeltaBytes": 13254596,
"heapUsedBytes": 119795316,
"domNodes": 917,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 6.27,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.428571428571427,
"p95FrameDurationMs": 49.90000000000009
},
{
"name": "large-graph-idle",
"durationMs": 2042.8589999999645,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.1159999999999997,
"layouts": 9,
"layoutDurationMs": 2.815,
"taskDurationMs": 506.5329999999999,
"heapDeltaBytes": -296552,
"heapUsedBytes": 101822816,
"domNodes": -296,
"jsHeapTotalBytes": -2703360,
"scriptDurationMs": 34.824999999999996,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2027.5179999999864,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.763,
"layouts": 9,
"layoutDurationMs": 2.3800000000000003,
"taskDurationMs": 477.822,
"heapDeltaBytes": 654900,
"heapUsedBytes": 102345000,
"domNodes": -276,
"jsHeapTotalBytes": -1654784,
"scriptDurationMs": 31.057000000000002,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2764.73500000003,
"styleRecalcs": 69,
"styleRecalcDurationMs": 11.234000000000002,
"layouts": 8,
"layoutDurationMs": 2.009,
"taskDurationMs": 1279.6270000000002,
"heapDeltaBytes": -3846312,
"heapUsedBytes": 99198908,
"domNodes": -296,
"jsHeapTotalBytes": -1167360,
"scriptDurationMs": 597.9010000000001,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66566265060241,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2747.8680000000395,
"styleRecalcs": 68,
"styleRecalcDurationMs": 10.788,
"layouts": 7,
"layoutDurationMs": 1.7289999999999999,
"taskDurationMs": 1291.295,
"heapDeltaBytes": 810744,
"heapUsedBytes": 103985672,
"domNodes": -296,
"jsHeapTotalBytes": -487424,
"scriptDurationMs": 588.08,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666664,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3743.204999999989,
"styleRecalcs": 72,
"styleRecalcDurationMs": 12.381,
"layouts": 66,
"layoutDurationMs": 12.261,
"taskDurationMs": 1348.339,
"heapDeltaBytes": -5841788,
"heapUsedBytes": 101226668,
"domNodes": -251,
"jsHeapTotalBytes": -2478080,
"scriptDurationMs": 563.4760000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666222222222224,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3736.1139999999295,
"styleRecalcs": 73,
"styleRecalcDurationMs": 12.601999999999999,
"layouts": 67,
"layoutDurationMs": 12.833,
"taskDurationMs": 1329.431,
"heapDeltaBytes": -3061240,
"heapUsedBytes": 101592368,
"domNodes": -272,
"jsHeapTotalBytes": -737280,
"scriptDurationMs": 557.196,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66607142857143,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3056.0100000000148,
"styleRecalcs": 45,
"styleRecalcDurationMs": 6.4399999999999995,
"layouts": 5,
"layoutDurationMs": 1.2249999999999999,
"taskDurationMs": 1527.285,
"heapDeltaBytes": 23230612,
"heapUsedBytes": 129139144,
"domNodes": 0,
"jsHeapTotalBytes": 8548352,
"scriptDurationMs": 760.4649999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666304347826088,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2866.800999999896,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.639,
"layouts": 6,
"layoutDurationMs": 1.601,
"taskDurationMs": 1455.1209999999999,
"heapDeltaBytes": 19789308,
"heapUsedBytes": 126453232,
"domNodes": 0,
"jsHeapTotalBytes": 6451200,
"scriptDurationMs": 696.6549999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665697674418606,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2037.524000000019,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.304,
"layouts": 10,
"layoutDurationMs": 2.8520000000000003,
"taskDurationMs": 485.956,
"heapDeltaBytes": 1159000,
"heapUsedBytes": 104222764,
"domNodes": -296,
"jsHeapTotalBytes": -5599232,
"scriptDurationMs": 29.974,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2034.1829999999845,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.7290000000000005,
"layouts": 8,
"layoutDurationMs": 2.2259999999999995,
"taskDurationMs": 465.53499999999997,
"heapDeltaBytes": 6887876,
"heapUsedBytes": 109590184,
"domNodes": -276,
"jsHeapTotalBytes": -5337088,
"scriptDurationMs": 28.520999999999997,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 495.3439999999887,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.382,
"layouts": 11,
"layoutDurationMs": 3.117,
"taskDurationMs": 318.819,
"heapDeltaBytes": 21224520,
"heapUsedBytes": 113153412,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 106.05499999999999,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 498.00600000003215,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.693,
"layouts": 10,
"layoutDurationMs": 2.4909999999999997,
"taskDurationMs": 303.39099999999996,
"heapDeltaBytes": 22527236,
"heapUsedBytes": 112582128,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 101.353,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2010.0440000000503,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.648,
"layouts": 11,
"layoutDurationMs": 3.081,
"taskDurationMs": 423.4309999999999,
"heapDeltaBytes": -8085612,
"heapUsedBytes": 97640624,
"domNodes": -198,
"jsHeapTotalBytes": 1740800,
"scriptDurationMs": 9.401000000000002,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2009.0639999999667,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.3859999999999992,
"layouts": 11,
"layoutDurationMs": 2.8730000000000007,
"taskDurationMs": 411.62399999999997,
"heapDeltaBytes": -13312188,
"heapUsedBytes": 91985568,
"domNodes": -198,
"jsHeapTotalBytes": 2015232,
"scriptDurationMs": 9.454,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1682.2159999999826,
"styleRecalcs": 76,
"styleRecalcDurationMs": 16.056,
"layouts": 9,
"layoutDurationMs": 2.3360000000000003,
"taskDurationMs": 644.6769999999999,
"heapDeltaBytes": -6341812,
"heapUsedBytes": 94434544,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 96.72600000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1678.8279999999531,
"styleRecalcs": 75,
"styleRecalcDurationMs": 14.283000000000001,
"layouts": 9,
"layoutDurationMs": 2.255,
"taskDurationMs": 609.147,
"heapDeltaBytes": 15070832,
"heapUsedBytes": 107484704,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 92.54799999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-transition-enter",
"durationMs": 1289.13399999999,
"styleRecalcs": 21,
"styleRecalcDurationMs": 17.723,
"layouts": 5,
"layoutDurationMs": 10.569,
"taskDurationMs": 802.8069999999998,
"heapDeltaBytes": 35933816,
"heapUsedBytes": 137185708,
"domNodes": 15950,
"jsHeapTotalBytes": 16654336,
"scriptDurationMs": 38.272000000000006,
"eventListeners": 3244,
"totalBlockingTimeMs": 75,
"frameDurationMs": 18.57285714285715,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 11008.166999999958,
"styleRecalcs": 250,
"styleRecalcDurationMs": 39.385999999999996,
"layouts": 9,
"layoutDurationMs": 2.418,
"taskDurationMs": 4819.249,
"heapDeltaBytes": 10476560,
"heapUsedBytes": 112635172,
"domNodes": -296,
"jsHeapTotalBytes": -425984,
"scriptDurationMs": 2188.5510000000004,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6661119515885,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8243.749999999978,
"styleRecalcs": 249,
"styleRecalcDurationMs": 37.540000000000006,
"layouts": 8,
"layoutDurationMs": 1.945,
"taskDurationMs": 3933.9730000000004,
"heapDeltaBytes": 1891224,
"heapUsedBytes": 104429704,
"domNodes": -296,
"jsHeapTotalBytes": -1441792,
"scriptDurationMs": 1970.7529999999997,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666060606060608,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16337.423,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15587.582,
"heapDeltaBytes": -44824584,
"heapUsedBytes": 279661444,
"domNodes": -3337,
"jsHeapTotalBytes": 23580672,
"scriptDurationMs": 222.756,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.404695652173913,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-idle",
"durationMs": 16486.90799999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15539.179999999998,
"heapDeltaBytes": -52390516,
"heapUsedBytes": 272271708,
"domNodes": -3337,
"jsHeapTotalBytes": 20697088,
"scriptDurationMs": 224.605,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.272384219554034,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-pan",
"durationMs": 15708.78399999998,
"styleRecalcs": 79,
"styleRecalcDurationMs": 14.672999999999991,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15291.868,
"heapDeltaBytes": -5694500,
"heapUsedBytes": 314290904,
"domNodes": -3337,
"jsHeapTotalBytes": 21938176,
"scriptDurationMs": 734.6850000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 116,
"frameDurationMs": 27.84548672566372,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-pan",
"durationMs": 19266.142000000058,
"styleRecalcs": 162,
"styleRecalcDurationMs": 22.615999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18841.996000000003,
"heapDeltaBytes": -15785024,
"heapUsedBytes": 294639580,
"domNodes": -3337,
"jsHeapTotalBytes": 9424896,
"scriptDurationMs": 739.7080000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 46,
"frameDurationMs": 35.94384328358209,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 4748.997000000031,
"styleRecalcs": 20,
"styleRecalcDurationMs": 43.629,
"layouts": 20,
"layoutDurationMs": 23.311,
"taskDurationMs": 4665.862000000001,
"heapDeltaBytes": -11070832,
"heapUsedBytes": 303933856,
"domNodes": -3337,
"jsHeapTotalBytes": 30396416,
"scriptDurationMs": 78.19000000000001,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.480555555555554,
"p95FrameDurationMs": 50
},
{
"name": "vue-node-resize-workload",
"durationMs": 4943.209000000024,
"styleRecalcs": 20,
"styleRecalcDurationMs": 44.103,
"layouts": 20,
"layoutDurationMs": 24.131,
"taskDurationMs": 4821.712,
"heapDeltaBytes": -9379564,
"heapUsedBytes": 310682016,
"domNodes": -3337,
"jsHeapTotalBytes": 27512832,
"scriptDurationMs": 81.971,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.652513966480452,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6458.13899999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6195.978999999999,
"heapDeltaBytes": 10507304,
"heapUsedBytes": 289387796,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 98.14,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.71649831649832,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8413.003000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8074.472,
"heapDeltaBytes": -3799372,
"heapUsedBytes": 272947740,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 116.80099999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.82328767123287,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "workflow-execution",
"durationMs": 480.15699999996286,
"styleRecalcs": 15,
"styleRecalcDurationMs": 9.258000000000001,
"layouts": 10,
"layoutDurationMs": 4.572,
"taskDurationMs": 116.45800000000001,
"heapDeltaBytes": -12539796,
"heapUsedBytes": 88791340,
"domNodes": 124,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 9.796000000000001,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662068965517236,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 447.9780000000346,
"styleRecalcs": 13,
"styleRecalcDurationMs": 7.986,
"layouts": 13,
"layoutDurationMs": 3.679,
"taskDurationMs": 93.89699999999999,
"heapDeltaBytes": -13162676,
"heapUsedBytes": 88665316,
"domNodes": 95,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 8.538,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670370370370385,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 280.35699999998087,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.643,
"layouts": 76,
"layoutDurationMs": 14.19,
"taskDurationMs": 232.112,
"heapDeltaBytes": 10271660,
"heapUsedBytes": 99755544,
"domNodes": 4,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 100.758,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.658823529411755,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 299.85499999997955,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.6920000000000001,
"layouts": 76,
"layoutDurationMs": 15.183,
"taskDurationMs": 245.535,
"heapDeltaBytes": -18293368,
"heapUsedBytes": 69494848,
"domNodes": 4,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 105.464,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.661111111111115,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 373.60800000010386,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.041,
"layouts": 76,
"layoutDurationMs": 16.67,
"taskDurationMs": 331.828,
"heapDeltaBytes": -5380940,
"heapUsedBytes": 109938676,
"domNodes": 4,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 119.833,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665217391304317,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 334.01100000003225,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.0370000000000004,
"layouts": 76,
"layoutDurationMs": 14.872,
"taskDurationMs": 297.925,
"heapDeltaBytes": -5896648,
"heapUsedBytes": 101133996,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 103.836,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428546,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E CoverageLine coverage: 64.0% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2950 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since d45abe324c75414c2066115473f54ee65271ea7c
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (111)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #21388 +/- ##
==========================================
- Coverage 87.52% 87.41% -0.11%
==========================================
Files 2812 2705 -107
Lines 153213 149946 -3267
Branches 42289 39075 -3214
==========================================
- Hits 134095 131080 -3015
+ Misses 18436 18342 -94
+ Partials 682 524 -158
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 123 files with indirect coverage changes 🚀 New features to boost your workflow:
|
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 4 Pipeline jobs failed
Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: 1facbc2 | Docs | View more details | Give us feedback! |
christian-byrne
left a comment
There was a problem hiding this comment.
Approved at exact head 1facbc29dbcc11e5e1a7da1ac643aa113a6baeb4.
- Blocked checkout and portal flows reuse only server-returned URLs and do not create a second session when the user activates the link.
- Current-workspace requests remain tab-local, so two tabs can intentionally act on different workspaces.
- The complete thread page is empty, and every latest check run is terminal with no failure.
Full context for agent readers
I reviewed the three-file change and the later two-line styling increment. The coverage exercises both blocked-link follow-up paths plus portal failure and empty-URL outcomes. The four red gates still visible in the aggregate rollup completed in 2–11 seconds during the superseded run; grouping exact-head check runs by name leaves 108 latest runs, all terminal and clean. I found no blocking issue.
|
@dante01yoon Successfully backported to #21393 |
|
@dante01yoon Successfully backported to #21394 |
…g the Add credits dialog (Comfy-Org#21395) ## Summary **Why:** after the hosted checkout opened, the workspace Add credits dialog closed at once. The customer lost the context of the purchase and had no way back to the checkout if they closed its tab. Product decision: show a hand-off screen instead (Figma: https://www.figma.com/design/C1fxz3akrW7Pl22zM2b301/?node-id=2100-10022, same as DES-1251 step 4). **Root cause:** `watchCheckoutCompletion` ended by closing the dialog. Nothing in the dialog represented an open checkout. **How:** both opening paths now land on the "Checkout opened in a new tab" screen: "Continue to checkout" opening its tab, and following the "Open checkout" link on "Checkout didn't open" (added in PR Comfy-Org#21388). Body copy and button layout follow the Figma frame. - The pending top-up marker and the balance/status watch start as before. The dialog now closes itself when that watch sees the balance rise. - **Close** (and the header close icon) closes the dialog and keeps the pending top-up and the watch running, as before. - **Reopen checkout** reserves a tab during the click and POSTs `/api/billing/topup/checkout` again, so every click gets a fresh session. If that tab is blocked, the dialog goes back to "Checkout didn't open", linking to the new session's URL. If the session can't be created, the dialog stays on the hand-off and shows the existing "The payment page couldn't open" message. - Ported only the screen, the copy keys (`checkoutOpenedTitle`, `checkoutOpenedBody`, `reopenCheckout`) and the reopen behaviour from PR Comfy-Org#21366. One-click Pay, "Set a default card" and its "Payment page didn't open" link are unchanged. The shared open path is `openCheckoutInReservedTab`, which returns `opened`, `blocked`, `failed` or `abandoned`. - No new client-derived facts. The dialog only reuses the checkout URL the server returned and the balance it already re-reads. **Feature flag / routing:** no new flag. `useBillingDialogs` shows `TopUpCreditsDialogContentWorkspace` when `useBillingRouting().type` is not `legacy`, which excludes personal workspaces on the legacy billing rail, and only when `canTopUp` is true. The checkout path is reached on a `NO_PAYMENT_METHOD` top-up refusal. Decision: https://comfy-organization.slack.com/archives/C0BNGQG2LCW/p1792450756887599 ## AS IS / TO BE | Path | AS IS (main) | TO BE (this PR) | | --- | --- | --- | | "Continue to checkout" opens its tab | <img src="https://gist.githubusercontent.com/dante01yoon/113bf168664254037d9c9479f926add1/raw/as-is-checkout-opened.png" width="420"> | <img src="https://gist.githubusercontent.com/dante01yoon/113bf168664254037d9c9479f926add1/raw/to-be-checkout-opened.png" width="360"> | | "Open checkout" link on "Checkout didn't open" | <img src="https://gist.githubusercontent.com/dante01yoon/113bf168664254037d9c9479f926add1/raw/as-is-checkout-link-followed.png" width="420"> | <img src="https://gist.githubusercontent.com/dante01yoon/113bf168664254037d9c9479f926add1/raw/to-be-checkout-link-followed.png" width="360"> | AS IS: the dialog closes and the canvas shows no toast. Captured on testcloud in a team workspace on workspace billing routing with `canTopUp`. The top-up (`NO_PAYMENT_METHOD`) and checkout requests were mocked, and the checkout tab was a stub or a blank page. ## Verification - `pnpm exec vitest run src/platform/workspace/components/TopUpCreditsDialogContentWorkspace.test.ts`: 97 passed. The tests cover: - both opening paths landing on the hand-off (table-driven); - Reopen checkout sending a second checkout request and opening a new tab; - a blocked reopen linking to the new URL; - a failed reopen staying on the hand-off with the error; - the hand-off closing itself once the balance rises; - Close and the header icon each keeping the watch and the pending marker (table-driven). - I checked that the close-on-balance and keep-watch tests fail when that behaviour is removed. - `oxlint --type-aware`, `oxfmt` and `eslint` pass on the touched files. `pnpm typecheck:app` and `pnpm typecheck:browser` pass. - `topUpNoPaymentMethod.spec.ts` now expects the hand-off screen after checkout opens, then closes it with Close. The `TopUpCreditsDialog` fixture also matches the hand-off and blocked-screen headings. I did not run E2E locally.
Summary
Why: people who block pop-ups get stuck in the workspace Add credits dialog. When the hosted-checkout tab (no default card) or the "Set a default card" portal tab is blocked, the retry is another
window.open, which the blocker refuses too. For the portal, the dialog only showed a toast asking the user to allow pop-ups and try again.Root cause: both retries are scripted opens, and pop-up blockers refuse those. A clicked link is a navigation, not a pop-up, so blockers allow it.
How:
Button as="a"withtarget="_blank"andrel="noopener". Itshrefis the checkout URL of the session created when the screen appeared. Clicking it starts the same pending top-up and balance watch as a successful open, then closes the dialog. It creates no new session and calls nowindow.open.payment_method_update). It then shows a new "Payment page didn't open" screen whose "Open payment page" button links to that portal URL. Following the link goes back to Confirm and registers the same refresh-on-return as a successful open. A failed or empty portal response shows the existing "Couldn't open card settings" toast.defaultCardBlockedTitle,defaultCardBlockedBody,openPaymentPage. The old "Allow pop-ups and try again" toast is no longer used here.Feature flag / routing: no new flag. The dialog is
TopUpCreditsDialogContentWorkspace, whichuseBillingDialogspicks whenuseBillingRouting().typeis notlegacy. Personal workspaces on the legacy billing rail still get the legacy dialog unlesslegacyBillingMigrationEnabledis on. The dialog also requirescanTopUp. The no-default-card path is reached on aNO_PAYMENT_METHODtop-up refusal.Overlap: PR #21366 also turns the blocked checkout into a link, as part of a larger rework, and removes "Set a default card". This PR is the small fix for main and the 1.58 branches. Whichever PR lands second resolves the conflict.
Decision: https://comfy-organization.slack.com/archives/C0BNGQG2LCW/p1792446469557019?thread_ts=1792446135.151939
AS IS / TO BE
Captured on testcloud in a team workspace on workspace billing routing with
canTopUp. Pop-ups were blocked, and the top-up (NO_PAYMENT_METHOD), checkout and portal requests were mocked.Verification
pnpm exec vitest run src/platform/workspace/components/TopUpCreditsDialogContentWorkspace.test.ts: 90 passed. One table-driven test covers both blocked screens and checks that each renders a link with the session URL,target="_blank"andrel="noopener", and that clicking it makes no second session request and no secondwindow.open. Other tests cover the checkout follow-up (pending top-up and dialog close), the portal follow-up (back to Pay once a default card exists on return), and portal failures while blocked.oxlint --type-aware,oxfmtandeslintpass on the touched files, and the pre-commit typecheck passes.